1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-27 19:53:09 +00:00
forgejo/modules/git
zeripath 716fcfcf72
Make every not exist error unwrappable to a fs.ErrNotExist (#20891)
A lot of our code is repeatedly testing if individual errors are
specific types of Not Exist errors. This is repetitative and unnecesary.
`Unwrap() error` provides a common way of labelling an error as a
NotExist error and we can/should use this.

This PR has chosen to use the common `io/fs` errors e.g.
`fs.ErrNotExist` for our errors. This is in some ways not completely
correct as these are not filesystem errors but it seems like a
reasonable thing to do and would allow us to simplify a lot of our code
to `errors.Is(err, fs.ErrNotExist)` instead of
`package.IsErr...NotExist(err)`

I am open to suggestions to use a different base error - perhaps
`models/db.ErrNotExist` if that would be felt to be better.


Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: delvh <dev.lh@web.de>
2022-10-18 07:50:37 +02:00
..
foreachref Go 1.19 format (#20758) 2022-08-30 21:15:45 -05:00
pipeline Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
tests/repos Auto merge pull requests when all checks succeeded via API (#9307) 2022-05-08 01:05:52 +08:00
url Fix some mirror bugs (#18649) 2022-06-11 21:50:14 +08:00
batch_reader.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
blame.go Set Setpgid on child git processes (#19865) 2022-06-03 15:36:18 +01:00
blame_test.go refactor: move from io/ioutil to io and os package (#17109) 2021-09-22 13:38:34 +08:00
blob.go Read expected buffer size (#17409) 2021-10-24 22:12:43 +01:00
blob_gogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
blob_nogogit.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
blob_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
command.go Follow improve code quality (#21465) 2022-10-15 14:18:31 +02:00
command_race_test.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
command_test.go Follow improve code quality (#21465) 2022-10-15 14:18:31 +02:00
commit.go alternative to PR "improve code quality" (#21464) 2022-10-15 12:49:26 +02:00
commit_convert_gogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
commit_info.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
commit_info_gogit.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
commit_info_nogogit.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
commit_info_test.go test: use T.TempDir to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
commit_reader.go Tagger can be empty, as can Commit and Author - tolerate this (#15835) 2021-05-12 01:11:42 -04:00
commit_test.go Use for a repo action one database transaction (#19576) 2022-05-03 21:46:28 +02:00
diff.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
diff_test.go Prevent off-by-one error on comments on newly appended lines (#18029) 2021-12-20 02:15:49 +00:00
error.go Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2022-10-18 07:50:37 +02:00
git.go Set uploadpack.allowFilter etc on gitea serv to enable partial clones with ssh (#20902) 2022-09-04 16:13:23 +01:00
git_test.go Refactor legacy git init (#20376) 2022-08-09 11:22:24 +08:00
hook.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
last_commit_cache.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
last_commit_cache_gogit.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
last_commit_cache_nogogit.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
log_name_status.go Add generic set type (#21408) 2022-10-12 13:18:26 +08:00
notes.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
notes_gogit.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
notes_nogogit.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
notes_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
parse_gogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
parse_gogit_test.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
parse_nogogit.go Refactor parseTreeEntries, speed up tree list (#21368) 2022-10-08 01:20:53 +08:00
parse_nogogit_test.go Refactor parseTreeEntries, speed up tree list (#21368) 2022-10-08 01:20:53 +08:00
README.md move code.gitea.io/git to code.gitea.io/gitea/modules/git (#6364) 2019-03-27 17:33:00 +08:00
ref.go Add more checks in migration code (#21011) 2022-09-04 13:47:56 +03:00
remote.go Fix some mirror bugs (#18649) 2022-06-11 21:50:14 +08:00
repo.go Remove git.Command.Run and git.Command.RunInDir* (#19280) 2022-04-01 10:55:30 +08:00
repo_archive.go Remove git.Command.Run and git.Command.RunInDir* (#19280) 2022-04-01 10:55:30 +08:00
repo_attribute.go Stop logging CheckPath returns error: context canceled (#21064) 2022-10-10 21:54:30 +01:00
repo_attribute_test.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
repo_base.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_base_gogit.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
repo_base_nogogit.go Slightly simplify LastCommitCache (#20444) 2022-07-25 16:39:42 +01:00
repo_blame.go Remove git.Command.Run and git.Command.RunInDir* (#19280) 2022-04-01 10:55:30 +08:00
repo_blob.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_blob_gogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
repo_blob_nogogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
repo_blob_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_branch.go Remove confusing TrimPrefix(... git.BranchPrefix) (#20369) 2022-07-16 08:10:02 +08:00
repo_branch_gogit.go Auto merge pull requests when all checks succeeded via API (#9307) 2022-05-08 01:05:52 +08:00
repo_branch_nogogit.go Passing command line arguments correctly by string slice (#21168) 2022-09-14 15:59:52 +02:00
repo_branch_test.go Sort branches and tags by date descending (#21136) 2022-09-14 14:11:24 +02:00
repo_commit.go probe if sha before exec git (#21467) 2022-10-17 16:40:37 +02:00
repo_commit_gogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
repo_commit_nogogit.go Add more checks in migration code (#21011) 2022-09-04 13:47:56 +03:00
repo_commit_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_commitgraph.go Remove git.Command.Run and git.Command.RunInDir* (#19280) 2022-04-01 10:55:30 +08:00
repo_commitgraph_gogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
repo_compare.go Set no-tags in git fetch on compare (#20893) 2022-08-23 14:12:43 -04:00
repo_compare_test.go test: use T.TempDir to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
repo_gpg.go Remove git.Command.Run and git.Command.RunInDir* (#19280) 2022-04-01 10:55:30 +08:00
repo_hook.go move code.gitea.io/git to code.gitea.io/gitea/modules/git (#6364) 2019-03-27 17:33:00 +08:00
repo_index.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
repo_language_stats.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
repo_language_stats_gogit.go Remove legacy git code (ver < 2.0), fine tune markup tests (#19930) 2022-06-16 23:47:44 +08:00
repo_language_stats_nogogit.go Refactor parseTreeEntries, speed up tree list (#21368) 2022-10-08 01:20:53 +08:00
repo_language_stats_test.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
repo_object.go Remove git.Command.Run and git.Command.RunInDir* (#19280) 2022-04-01 10:55:30 +08:00
repo_ref.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
repo_ref_gogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
repo_ref_nogogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
repo_ref_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_stats.go alternative to PR "improve code quality" (#21464) 2022-10-15 12:49:26 +02:00
repo_stats_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_tag.go Remove git.Command.Run and git.Command.RunInDir* (#19280) 2022-04-01 10:55:30 +08:00
repo_tag_gogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
repo_tag_nogogit.go Passing command line arguments correctly by string slice (#21168) 2022-09-14 15:59:52 +02:00
repo_tag_test.go test: use T.TempDir to create temporary test directory (#21043) 2022-09-04 16:14:53 +01:00
repo_test.go Make git.OpenRepository accept Context (#19260) 2022-03-30 03:13:41 +08:00
repo_tree.go Remove legacy git code (ver < 2.0), fine tune markup tests (#19930) 2022-06-16 23:47:44 +08:00
repo_tree_gogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
repo_tree_nogogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
sha1.go Add more checks in migration code (#21011) 2022-09-04 13:47:56 +03:00
sha1_gogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
sha1_nogogit.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
sha1_test.go probe if sha before exec git (#21467) 2022-10-17 16:40:37 +02:00
signature.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
signature_gogit.go Go 1.19 format (#20758) 2022-08-30 21:15:45 -05:00
signature_nogogit.go Go 1.19 format (#20758) 2022-08-30 21:15:45 -05:00
submodule.go Fix some lints (#17337) 2021-10-17 20:47:12 +01:00
submodule_test.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
tag.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
tag_test.go Fix NPE on try to get tag reference via API (#18245) 2022-01-12 20:37:46 +00:00
tree.go Remove git.Command.Run and git.Command.RunInDir* (#19280) 2022-04-01 10:55:30 +08:00
tree_blob.go Use native git variants by default with go-git variants as build tag (#13673) 2020-12-17 22:00:47 +08:00
tree_blob_gogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
tree_blob_nogogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
tree_entry.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
tree_entry_gogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
tree_entry_mode.go format with gofumpt (#18184) 2022-01-20 18:46:10 +01:00
tree_entry_nogogit.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
tree_entry_test.go Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
tree_gogit.go Refactor parseTreeEntries, speed up tree list (#21368) 2022-10-08 01:20:53 +08:00
tree_nogogit.go Refactor parseTreeEntries, speed up tree list (#21368) 2022-10-08 01:20:53 +08:00
utils.go Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
utils_test.go Fix ref links in issue overviews for tags (#8742) 2020-05-14 18:55:43 -04:00

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.