mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-29 12:43:11 +00:00
de484e86bc
This PR adds the support for scopes of access tokens, mimicking the design of GitHub OAuth scopes. The changes of the core logic are in `models/auth` that `AccessToken` struct will have a `Scope` field. The normalized (no duplication of scope), comma-separated scope string will be stored in `access_token` table in the database. In `services/auth`, the scope will be stored in context, which will be used by `reqToken` middleware in API calls. Only OAuth2 tokens will have granular token scopes, while others like BasicAuth will default to scope `all`. A large amount of work happens in `routers/api/v1/api.go` and the corresponding `tests/integration` tests, that is adding necessary scopes to each of the API calls as they fit. - [x] Add `Scope` field to `AccessToken` - [x] Add access control to all API endpoints - [x] Update frontend & backend for when creating tokens - [x] Add a database migration for `scope` column (enable 'all' access to past tokens) I'm aiming to complete it before Gitea 1.19 release. Fixes #4300
77 lines
2.9 KiB
Go
77 lines
2.9 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"fmt"
|
|
"net/http"
|
|
"testing"
|
|
|
|
auth_model "code.gitea.io/gitea/models/auth"
|
|
issues_model "code.gitea.io/gitea/models/issues"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
api "code.gitea.io/gitea/modules/structs"
|
|
"code.gitea.io/gitea/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestAPIIssueSubscriptions(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
issue1 := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 1})
|
|
issue2 := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 2})
|
|
issue3 := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 3})
|
|
issue4 := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 4})
|
|
issue5 := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 8})
|
|
|
|
owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: issue1.PosterID})
|
|
|
|
session := loginUser(t, owner.Name)
|
|
token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeRepo)
|
|
|
|
testSubscription := func(issue *issues_model.Issue, isWatching bool) {
|
|
issueRepo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: issue.RepoID})
|
|
|
|
urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d/subscriptions/check?token=%s", issueRepo.OwnerName, issueRepo.Name, issue.Index, token)
|
|
req := NewRequest(t, "GET", urlStr)
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
wi := new(api.WatchInfo)
|
|
DecodeJSON(t, resp, wi)
|
|
|
|
assert.EqualValues(t, isWatching, wi.Subscribed)
|
|
assert.EqualValues(t, !isWatching, wi.Ignored)
|
|
assert.EqualValues(t, issue.APIURL()+"/subscriptions", wi.URL)
|
|
assert.EqualValues(t, issue.CreatedUnix, wi.CreatedAt.Unix())
|
|
assert.EqualValues(t, issueRepo.APIURL(), wi.RepositoryURL)
|
|
}
|
|
|
|
testSubscription(issue1, true)
|
|
testSubscription(issue2, true)
|
|
testSubscription(issue3, true)
|
|
testSubscription(issue4, false)
|
|
testSubscription(issue5, false)
|
|
|
|
issue1Repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: issue1.RepoID})
|
|
urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d/subscriptions/%s?token=%s", issue1Repo.OwnerName, issue1Repo.Name, issue1.Index, owner.Name, token)
|
|
req := NewRequest(t, "DELETE", urlStr)
|
|
MakeRequest(t, req, http.StatusCreated)
|
|
testSubscription(issue1, false)
|
|
|
|
req = NewRequest(t, "DELETE", urlStr)
|
|
MakeRequest(t, req, http.StatusOK)
|
|
testSubscription(issue1, false)
|
|
|
|
issue5Repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: issue5.RepoID})
|
|
urlStr = fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d/subscriptions/%s?token=%s", issue5Repo.OwnerName, issue5Repo.Name, issue5.Index, owner.Name, token)
|
|
req = NewRequest(t, "PUT", urlStr)
|
|
MakeRequest(t, req, http.StatusCreated)
|
|
testSubscription(issue5, true)
|
|
|
|
req = NewRequest(t, "PUT", urlStr)
|
|
MakeRequest(t, req, http.StatusOK)
|
|
testSubscription(issue5, true)
|
|
}
|