From 0a6497a3b6c4219e6a6a9310849159b00c864671 Mon Sep 17 00:00:00 2001 From: Emmanuele Bassi Date: Tue, 16 Mar 2010 18:57:28 +0000 Subject: [PATCH] model: Add a comment on the n_columns field type To avoid another bug report like: http://bugzilla.openedhand.com/show_bug.cgi?id=2017 with a patch that gets applied without a proper review, resulting in a bug like: http://bugzilla.openedhand.com/show_bug.cgi?id=2032 I should probably add a comment on why on earth we're using an integer as the n_columns member of the ClutterModelPrivate structure, and why it is important that it is initialized as -1. --- clutter/clutter-model.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/clutter/clutter-model.c b/clutter/clutter-model.c index c2e975f74..2b1954270 100644 --- a/clutter/clutter-model.c +++ b/clutter/clutter-model.c @@ -193,6 +193,15 @@ struct _ClutterModelPrivate { GType *column_types; gchar **column_names; + + /* we use an integer here because we want to be able to use -1 as a + * guard value, to allow calling set_names() and set_types() from + * sub-classes of ClutterModel. see bug: + * + * http://bugzilla.openedhand.com/show_bug.cgi?id=2032 + * + * for a reference. + */ gint n_columns; ClutterModelFilterFunc filter_func;