sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

constraints: Allow resize of windows moved above screen

Browse source 
If the titlebar of a window has been moved above the screen by a user
via an unconstrained move, then any constrained user resize following
this move will cause the window to jump below the top of the screen or
cause other glitchy behavior.

This commit removes the constraint that the titlebar of a window must be
below the top of the screen for any resize that is both (1) triggered by
a user and (2) is a resize that affects only the left, right, or bottom
edges of the window.  This allows users to move a window partially above
the screen and then resize the window to be wider or resize the bottom
edge of the window to make it taller or shorter.

Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/1206
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3764>
(cherry picked from commit 5ba364a947)
This commit is contained in:
Jeffrey Knockel 2024-05-21 08:53:03 -04:00 committed by Jonas Ådahl
parent a0dd01c95f
commit 18c17aaa5a
1 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/core/constraints.c
View file

@ -1764,6 +1764,7 @@ constrain_titlebar_visible (MetaWindow *window,
gboolean check_only) gboolean check_only)
{ {
gboolean unconstrained_user_action; gboolean unconstrained_user_action;
gboolean user_nonnorthern_resize;
gboolean retval; gboolean retval;
int bottom_amount; int bottom_amount;
int horiz_amount_offscreen, vert_amount_offscreen; int horiz_amount_offscreen, vert_amount_offscreen;
@ -1784,6 +1785,19 @@ constrain_titlebar_visible (MetaWindow *window,
(meta_window_drag_get_grab_op (window_drag) & (meta_window_drag_get_grab_op (window_drag) &
META_GRAB_OP_WINDOW_FLAG_UNCONSTRAINED) != 0); META_GRAB_OP_WINDOW_FLAG_UNCONSTRAINED) != 0);
/* If the user is resizing anything other than the top, then don't check if
* the titlebar is beyond the top of the screen. This resize might be
* immediately following an unconstrained move that placed the titlebar above
* the top of the screen, in which case we don't want the titlebar
* immediately popping back below the top of the screen or other glitching
* (https://gitlab.gnome.org/GNOME/mutter/-/issues/1206).
*/
user_nonnorthern_resize =
info->is_user_action &&
window_drag &&
meta_grab_op_is_resizing (meta_window_drag_get_grab_op (window_drag)) &&
info->orig.y == info->current.y;
/* Exit early if we know the constraint won't apply--note that this constraint /* Exit early if we know the constraint won't apply--note that this constraint
* is only meant for normal windows (e.g. we don't want docks to be shoved * is only meant for normal windows (e.g. we don't want docks to be shoved
* "onscreen" by their own strut). * "onscreen" by their own strut).
@ -1793,6 +1807,7 @@ constrain_titlebar_visible (MetaWindow *window,
window->fullscreen || window->fullscreen ||
!window->require_titlebar_visible || !window->require_titlebar_visible ||
unconstrained_user_action || unconstrained_user_action ||
user_nonnorthern_resize ||
meta_window_get_placement_rule (window)) meta_window_get_placement_rule (window))
return TRUE; return TRUE;