sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

Revert "wayland/surface: Check buffer size also for role-less surfaces"

Browse source 
This reverts commit 98c8c03729.

Although the spec technically doesn't allow this for role-less surfaces
either, it's difficult for clients to avoid it for surfaces which later
assume a cursor role, and there's consensus to allow it for the time
being:
https://gitlab.freedesktop.org/wayland/wayland/-/issues/194#note_1371674

Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/3471
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3743>
This commit is contained in:
Michel Dänzer 2024-05-07 17:54:25 +02:00 committed by Marge Bot
parent da0bd303ad
commit 1c7ed16d05
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/wayland/meta-wayland-surface.c
View file

@ -981,7 +981,7 @@ meta_wayland_surface_commit (MetaWaylandSurface *surface)
if ((meta_multi_texture_get_width (committed_texture) % committed_scale != 0) ||
(meta_multi_texture_get_height (committed_texture) % committed_scale != 0))
{
if (!surface->role || !META_IS_WAYLAND_CURSOR_SURFACE (surface->role))
if (surface->role && !META_IS_WAYLAND_CURSOR_SURFACE (surface->role))
{
wl_resource_post_error (surface->resource, WL_SURFACE_ERROR_INVALID_SIZE,
"Buffer size (%dx%d) must be an integer multiple "