sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

x11/window: Add proper type guard to x11-specific public API calls

Browse source 
These functions are specific for X11 windows only so we should check
if the passed window is an X11 one, not just a MetaWindow since we're
casting to the actual type at later point.

Fixes changes part of commit e1e6534eb

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3727>
This commit is contained in:
Marco Trevisan (Treviño) 2024-05-01 03:15:51 +02:00 committed by Marge Bot
parent b422393bbc
commit 31165c2d86
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/x11/window-x11.c
View file

@ -4439,7 +4439,7 @@ meta_window_x11_get_xwindow (MetaWindow *window)
MetaWindowX11 *window_x11;
MetaWindowX11Private *priv;
g_return_val_if_fail (META_IS_WINDOW (window), None);
g_return_val_if_fail (META_IS_WINDOW_X11 (window), None);
window_x11 = META_WINDOW_X11 (window);
priv = meta_window_x11_get_instance_private (window_x11);
@ -4453,7 +4453,7 @@ meta_window_x11_get_xgroup_leader (MetaWindow *window)
MetaWindowX11 *window_x11;
MetaWindowX11Private *priv;
g_return_val_if_fail (META_IS_WINDOW (window), None);
g_return_val_if_fail (META_IS_WINDOW_X11 (window), None);
window_x11 = META_WINDOW_X11 (window);
priv = meta_window_x11_get_instance_private (window_x11);
@ -4467,7 +4467,7 @@ meta_window_x11_get_user_time_window (MetaWindow *window)
MetaWindowX11 *window_x11;
MetaWindowX11Private *priv;
g_return_val_if_fail (META_IS_WINDOW (window), None);
g_return_val_if_fail (META_IS_WINDOW_X11 (window), None);
window_x11 = META_WINDOW_X11 (window);
priv = meta_window_x11_get_instance_private (window_x11);
@ -4480,7 +4480,7 @@ meta_window_x11_get_xtransient_for (MetaWindow *window)
{
MetaWindow *transient_for;
g_return_val_if_fail (META_IS_WINDOW (window), None);
g_return_val_if_fail (META_IS_WINDOW_X11 (window), None);
transient_for = meta_window_get_transient_for (window);
if (transient_for)