sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

tests/cogl/read-texture-formats: Do not skip any test when using AMD

Browse source 
All the tests are correctly passing with an AMD card, so let's enable
them all in such case, so we can catch when the test will regress even
there

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3793>
This commit is contained in:
Marco Trevisan (Treviño) 2024-06-02 20:36:46 +02:00 committed by Marge Bot
parent 18fa5bd81e
commit 3e6cf75eec
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/tests/cogl/conform/test-read-texture-formats.c
View file

@ -200,7 +200,11 @@ test_read_int_case (gconstpointer data)
received_value_str = g_strdup_printf ("0x%08x", received_value);
expected_value_str = g_strdup_printf ("0x%08x", args->expected_value);
if (!g_test_undefined ())
/* The test is currently failing using sw rendering or intel hardware, but
* it does pass under AMD, so at least keep checking if this case works.
*/
if (!g_test_undefined () &&
!g_str_equal (test_utils_get_cogl_driver_vendor (test_ctx), "AMD"))
{
/* This test case is always considered failing */
g_test_skip_printf ("This test is a well known failure, "
@ -208,6 +212,15 @@ test_read_int_case (gconstpointer data)
expected_value_str, received_value_str);
return;
}
else if (g_test_undefined () &&
g_str_equal (test_utils_get_cogl_driver_vendor (test_ctx), "AMD") &&
cogl_renderer_get_driver (cogl_context_get_renderer (test_ctx)) ==
COGL_DRIVER_GL3)
{
g_test_fail_printf ("This test is not failing on AMD, but we mark it "
"to make meson happy.");
return;
}
g_assert_cmpstr (received_value_str, ==, expected_value_str);
}