From 3eb5381c460000280947ad6240d654c15a544696 Mon Sep 17 00:00:00 2001 From: Bilal Elmoussaoui Date: Tue, 17 Sep 2024 17:03:45 +0200 Subject: [PATCH] wayland/inhibit-dialog: Drop duplicated hide call the destroy and the response handler, already hide the dialog themselves. The calls here were unnecessary. Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/3048 Part-of: --- src/core/meta-inhibit-shortcuts-dialog.c | 1 - src/wayland/meta-wayland-inhibit-shortcuts-dialog.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/core/meta-inhibit-shortcuts-dialog.c b/src/core/meta-inhibit-shortcuts-dialog.c index 7c2249834..789d6b3c4 100644 --- a/src/core/meta-inhibit-shortcuts-dialog.c +++ b/src/core/meta-inhibit-shortcuts-dialog.c @@ -97,5 +97,4 @@ meta_inhibit_shortcuts_dialog_response (MetaInhibitShortcutsDialog *dial MetaInhibitShortcutsDialogResponse response) { g_signal_emit (dialog, inhibit_dialog_signals[RESPONSE], 0, response); - meta_inhibit_shortcuts_dialog_hide (dialog); } diff --git a/src/wayland/meta-wayland-inhibit-shortcuts-dialog.c b/src/wayland/meta-wayland-inhibit-shortcuts-dialog.c index 818098460..59f4e3e29 100644 --- a/src/wayland/meta-wayland-inhibit-shortcuts-dialog.c +++ b/src/wayland/meta-wayland-inhibit-shortcuts-dialog.c @@ -99,7 +99,6 @@ inhibit_shortcuts_dialog_response_cb (MetaInhibitShortcutsDialog *dialog, if (!data->request_canceled) inhibit_shortcuts_dialog_response_apply (data); - meta_inhibit_shortcuts_dialog_hide (data->dialog); surface_inhibit_shortcuts_data_destroy_dialog (data); }