sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

* clutter/cogl/common/cogl-mesh.c:

Browse source 
Re-works validate_custom_attribute_name() so it doesn't access an
	un-initialised variable.
This commit is contained in:
Robert Bragg 2008-11-18 16:24:31 +00:00
parent 8b557c6c13
commit 454d4a69a2
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
common/cogl-mesh.c
View file

@ -300,7 +300,6 @@ validate_custom_attribute_name (const char *attribute_name)
{
char *detail_seperator = NULL;
int name_len;
const char *p;
int i;
detail_seperator = strstr (attribute_name, "::");
@ -309,11 +308,13 @@ validate_custom_attribute_name (const char *attribute_name)
else
name_len = strlen (attribute_name);
if (name_len == 0 || !g_ascii_isalpha (*p) || *p != '_')
if (name_len == 0
|| !g_ascii_isalpha (attribute_name[0])
|| attribute_name[0] != '_')
return FALSE;
for (i = 1; i < name_len; i++)
if (!g_ascii_isalnum (*p) || *p != '_')
if (!g_ascii_isalnum (attribute_name[i]) || attribute_name[i] != '_')
return FALSE;
return TRUE;