sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

[cogl] handle_automatic_blend_enable(): consider layers with invalid textures

Browse source 
A layer object may be instantiated when setting a combine mode, but before a
texture is associated. (e.g. this is done by the pango renderer) if this is the
case we shouldn't call cogl_texture_get_format() with an invalid cogl handle.

This patch skips over layers without a texture handle when determining if any
textures have an alpha channel.
This commit is contained in:
Robert Bragg 2009-04-02 11:50:44 +01:00
parent c2afbd415e
commit 4b484d6496
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
common/cogl-material.c
View file

@ -100,6 +100,12 @@ handle_automatic_blend_enable (CoglMaterial *material)
for (tmp = material->layers; tmp != NULL; tmp = tmp->next)
{
CoglMaterialLayer *layer = tmp->data;
/* NB: A layer may have a combine mode set on it but not yet have an
* associated texture. */
if (!layer->texture)
continue;
if (cogl_texture_get_format (layer->texture) & COGL_A_BIT)
material->flags |= COGL_MATERIAL_FLAG_ENABLE_BLEND;
}