sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

screen-cast/src: Ceil cursor buffer size

Browse source 
meta_screen_cast_stream_src_set_cursor_sprite_metadata() receives
the cursor sprite, position, and scale, and with that it downloads
the cursor sprite by drawing it into a separate framebuffer, then
calls cogl_framebuffer_read_pixels() in it - this is the offscren
path that is very common when using screen capturing applications
such as OBS Studio.

There's a sneaky issue in this code path though: the 'scale' value
is a float. The cursor size is then determined by multiplying the
sprite width and height - two integer variables - by scale, and
this relies on standard float-to-int conversions. This is problematic
as sometimes the rounded values disagree with what is expected by
cogl_framebuffer_read_pixels(). If the packing of either the cursor
width or height is off by one, glReadPixels() will try to write into
off bounds, which crashes.

This can be reproduced by enabling fractional scaling, setting a 150%
zoom level, on a 4K screen, and opening any commit with an image diff
in gitlab.gnome.org, all while screencasting. When hovering the new
image, the cursor sprite will be such that it triggers this code path,
and reproduces this issue.

Fix this by always ceiling the cursor sprite sizes.

Closes https://gitlab.gnome.org/GNOME/mutter/-/issues/2542

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2736>
This commit is contained in:
Georges Basile Stavracas Neto 2022-12-03 09:25:52 -03:00
parent 7a103bbfe9
commit 4d4e8e5862
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/backends/meta-screen-cast-stream-src.c
View file

@ -445,8 +445,8 @@ meta_screen_cast_stream_src_set_cursor_sprite_metadata (MetaScreenCastStreamSrc
texture_width = cogl_texture_get_width (cursor_texture); texture_width = cogl_texture_get_width (cursor_texture);
texture_height = cogl_texture_get_height (cursor_texture); texture_height = cogl_texture_get_height (cursor_texture);
bitmap_width = texture_width * scale; bitmap_width = ceilf (texture_width * scale);
bitmap_height = texture_height * scale; bitmap_height = ceilf (texture_height * scale);
spa_meta_bitmap->size.width = bitmap_width; spa_meta_bitmap->size.width = bitmap_width;
spa_meta_bitmap->size.height = bitmap_height; spa_meta_bitmap->size.height = bitmap_height;