sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

cogl/onscreen/glx: Remove comment about clipped redraws not being supported

Browse source 
They've been supported for a very long time.

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3587>
This commit is contained in:
Daniel van Vugt 2024-02-15 14:52:10 +08:00
parent ea486b200f
commit 53ca3a0089
1 changed files with 5 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
cogl/cogl/winsys/cogl-onscreen-glx.c
View file

@ -755,20 +755,11 @@ cogl_onscreen_glx_swap_region (CoglOnscreen *onscreen,
* the GPU, only the CPU so we have to resort to synchronizing the
* GPU with the CPU to throttle it.
*
* Note: since calling glFinish() and synchronizing the CPU with
* the GPU is far from ideal, we hope that this is only a short
* term solution.
* - One idea is to using sync objects to track render
* completion so we can throttle the backlog (ideally with an
* additional extension that lets us get notifications in our
* mainloop instead of having to busy wait for the
* completion.)
* - Another option is to support clipped redraws by reusing the
* contents of old back buffers such that we can flip instead
* of using a blit and then we can use GLX_INTEL_swap_events
* to throttle. For this though we would still probably want an
* additional extension so we can report the limited region of
* the window damage to X/compositors.
* Note: calling glFinish() and synchronizing the CPU with the GPU is far
* from ideal. One idea is to use sync objects to track render completion
* so we can throttle the backlog (ideally with an additional extension that
* lets us get notifications in our mainloop instead of having to busy wait
* for the completion).
*/
cogl_framebuffer_finish (framebuffer);