sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

Bug 682071-cogl/cogl-sdl.h: MSVC: Link to SDL when apps are built

Browse source 
Link to SDL.lib and SDLmain.lib if Cogl was built with the SDL winsys.

Recent changes to the SDL winsys introduced a direct dependency to
SDLmain.lib (and hence SDL.lib) when programs are built, causing linker
errors to appear when any programs using cogl (with the SDL winsys built
in) are built.

Since we cannot determine whether a Cogl build is built with the SDL winsys
at build time easily, we could use #pragma comment (lib, ...) whenever
cogl-sdl.h is included by cogl.h so that SDLmain.lib and SDL.lib is linked
into the resulting binary, so that the program can link and run correctly.

This does not add any external dependencies as the Cogl DLL already depends
on SDL.dll when it is built with the SDL winsys.

https://bugzilla.gnome.org/show_bug.cgi?id=682071

(cherry picked from commit 2921d2a4d9c79f1ca7530171e0dfa8c945607bc7)
This commit is contained in:
Chun-wei Fan 2012-08-17 11:30:17 +08:00 committed by Robert Bragg
parent e3e53f2c70
commit 7253c5ca29
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
cogl/cogl-sdl.h
View file

@ -31,6 +31,15 @@
#include <cogl/cogl-context.h>
#include <SDL.h>
#ifdef _MSC_VER
/* We need to link to SDL.lib/SDLmain.lib
* if we are using Cogl
* that uses the SDL winsys
*/
#pragma comment (lib, "SDL.lib")
#pragma comment (lib, "SDLmain.lib")
#endif
G_BEGIN_DECLS
/**