sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

screen: Remove stray assert

Browse source 
When the number of (static) workspaces decreases, we relocate windows
from extra workspaces before removing them. As removing a non-empty
workspace is not allowed, we assert that it doesn't contain any windows
before removing it.

However that assert is

 - pointless, because meta_workspace_remove() already asserts that
   the workspace is empty

 - wrong, because even empty workspaces contain windows that are set
   to show on all workspaces

Simply drop the assert to avoid a crash when trying to remove a workspace
while on-all-workspaces windows are present.

https://bugzilla.gnome.org/show_bug.cgi?id=784223
This commit is contained in:
Florian Müllner 2017-06-26 17:56:36 +02:00
parent ce989976fa
commit 80e5955918
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/core/screen.c
View file

@ -1260,7 +1260,6 @@ update_num_workspaces (MetaScreen *screen,
{ {
MetaWorkspace *w = l->data; MetaWorkspace *w = l->data;
g_assert (w->windows == NULL);
meta_workspace_remove (w); meta_workspace_remove (w);
} }