From 8290e1f09aac4a96b8f7474afc619e7133c2360b Mon Sep 17 00:00:00 2001 From: Rui Matos Date: Fri, 14 Oct 2016 18:24:34 +0200 Subject: [PATCH] MetaRendererNative: don't call drmModeGetResources() There's no need to call this and we were leaking the returned memory. https://bugzilla.gnome.org/show_bug.cgi?id=773116 --- src/backends/native/meta-renderer-native.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/src/backends/native/meta-renderer-native.c b/src/backends/native/meta-renderer-native.c index 2093e0996..b4c93c422 100644 --- a/src/backends/native/meta-renderer-native.c +++ b/src/backends/native/meta-renderer-native.c @@ -1235,7 +1235,6 @@ meta_renderer_native_initable_init (GInitable *initable, GError **error) { MetaRendererNative *renderer_native = META_RENDERER_NATIVE (initable); - drmModeRes *resources; renderer_native->gbm = gbm_create_device (renderer_native->kms_fd); if (!renderer_native->gbm) @@ -1243,25 +1242,10 @@ meta_renderer_native_initable_init (GInitable *initable, g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED, "Failed to create gbm device"); - goto err; - } - - resources = drmModeGetResources (renderer_native->kms_fd); - if (!resources) - { - g_set_error (error, G_IO_ERROR, - G_IO_ERROR_FAILED, - "drmModeGetResources failed"); - goto err_resources; + return FALSE; } return TRUE; - -err_resources: - g_clear_pointer (&renderer_native->gbm, gbm_device_destroy); - -err: - return FALSE; } static void