From 8d3d8b86e517c97accf11eb243078faf31dd72bb Mon Sep 17 00:00:00 2001 From: Robert Mader Date: Fri, 13 Oct 2023 18:29:19 +0200 Subject: [PATCH] screen-cast/stream-src: Assert that dmabuf handle lookup succeeds To prevent issues like the one fixed in the previous commit. Also remove a redundant variable assignment. Part-of: --- src/backends/meta-screen-cast-stream-src.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/backends/meta-screen-cast-stream-src.c b/src/backends/meta-screen-cast-stream-src.c index fd49c5339..273c085d5 100644 --- a/src/backends/meta-screen-cast-stream-src.c +++ b/src/backends/meta-screen-cast-stream-src.c @@ -564,12 +564,12 @@ meta_screen_cast_stream_src_calculate_stride (MetaScreenCastStreamSrc *src, if (spa_data->type == SPA_DATA_DmaBuf) { - CoglDmaBufHandle *dmabuf_handle = NULL; + CoglDmaBufHandle *dmabuf_handle; dmabuf_handle = g_hash_table_lookup (priv->dmabuf_handles, GINT_TO_POINTER (spa_data->fd)); - if (dmabuf_handle) - return cogl_dma_buf_handle_get_stride (dmabuf_handle); + g_assert (dmabuf_handle != NULL); + return cogl_dma_buf_handle_get_stride (dmabuf_handle); } if (!cogl_pixel_format_from_spa_video_format (priv->video_format.format,