From 9434b01998ff07520e710b7ff19f52fd2433fc4f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jonas=20=C3=85dahl?= Date: Wed, 22 Feb 2023 09:02:38 +0100 Subject: [PATCH] renderer/native: Don't leak onscreen in error path Part-of: --- src/backends/native/meta-renderer-native.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/backends/native/meta-renderer-native.c b/src/backends/native/meta-renderer-native.c index f8de8b303..83c373a9a 100644 --- a/src/backends/native/meta-renderer-native.c +++ b/src/backends/native/meta-renderer-native.c @@ -1280,7 +1280,7 @@ meta_renderer_native_create_view (MetaRenderer *renderer, if (META_IS_CRTC_KMS (crtc)) { MetaGpuKms *gpu_kms = META_GPU_KMS (meta_crtc_get_gpu (crtc)); - MetaOnscreenNative *onscreen_native; + g_autoptr (MetaOnscreenNative) onscreen_native = NULL; if (!meta_renderer_native_ensure_gpu_data (renderer_native, gpu_kms, @@ -1322,7 +1322,8 @@ meta_renderer_native_create_view (MetaRenderer *renderer, { use_shadowfb = should_force_shadow_fb (renderer_native, primary_gpu_kms); - framebuffer = COGL_FRAMEBUFFER (onscreen_native); + framebuffer = + COGL_FRAMEBUFFER (g_steal_pointer (&onscreen_native)); } } }