sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

clutter/actor: Handle getting (un-)mapped during painting differently

Browse source 
We currently support only one case where an actor can get mapped or
unmapped during painting, that is using
_clutter_actor_enable_paint_unmapped() (although we could arguably do a
better job explicitely forbidding it in other cases). This function is
called when painting ClutterClone or MetaWindowActors during
screensharing. It temporarily (fake) realizes and maps the actor and all
its children so it can get painted.

Now a problem will appear when we'll start coupling layout and the
mapped state of actors more closely with the next commit: Since
enable_paint_unmapped() is meant to be enabled and disabled during every
clone paint, we also notify the "mapped" property twice on every clone
paint. That means with the next commit we would queue a relayout for the
source actor on every clone paint.

To avoid this unnecessary work, check whether we're being painted while
unmapped using the new unmapped_paint_branch_counter. Then avoid queuing
relayouts or invalidating paint volumes in that case.

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1366
This commit is contained in:
Jonas Dreßler 2020-07-08 14:38:57 +02:00 committed by Carlos Garnacho
parent 650efb6445
commit 9b50215008
1 changed files with 22 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
clutter/clutter/clutter-actor.c
View file

@ -1619,6 +1619,8 @@ clutter_actor_real_map (ClutterActor *self)
CLUTTER_ACTOR_SET_FLAGS (self, CLUTTER_ACTOR_MAPPED); CLUTTER_ACTOR_SET_FLAGS (self, CLUTTER_ACTOR_MAPPED);
if (self->priv->unmapped_paint_branch_counter == 0)
{
self->priv->needs_paint_volume_update = TRUE; self->priv->needs_paint_volume_update = TRUE;
/* We skip unmapped actors when updating the stage-views list, so if /* We skip unmapped actors when updating the stage-views list, so if
@ -1632,6 +1634,7 @@ clutter_actor_real_map (ClutterActor *self)
self->priv->needs_update_stage_views = FALSE; self->priv->needs_update_stage_views = FALSE;
queue_update_stage_views (self); queue_update_stage_views (self);
} }
}
/* notify on parent mapped before potentially mapping /* notify on parent mapped before potentially mapping
* children, so apps see a top-down notification. * children, so apps see a top-down notification.
@ -1731,11 +1734,14 @@ clutter_actor_real_unmap (ClutterActor *self)
CLUTTER_ACTOR_UNSET_FLAGS (self, CLUTTER_ACTOR_MAPPED); CLUTTER_ACTOR_UNSET_FLAGS (self, CLUTTER_ACTOR_MAPPED);
if (self->priv->unmapped_paint_branch_counter == 0)
{
/* clear the contents of the last paint volume, so that hiding + moving + /* clear the contents of the last paint volume, so that hiding + moving +
* showing will not result in the wrong area being repainted * showing will not result in the wrong area being repainted
*/ */
_clutter_paint_volume_init_static (&priv->last_paint_volume, NULL); _clutter_paint_volume_init_static (&priv->last_paint_volume, NULL);
priv->last_paint_volume_valid = TRUE; priv->last_paint_volume_valid = TRUE;
}
/* notify on parent mapped after potentially unmapping /* notify on parent mapped after potentially unmapping
* children, so apps see a bottom-up notification. * children, so apps see a bottom-up notification.