sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

Use an epsilon for float comparison

Browse source 
We tend to use float comparison for structured data types like Vertex,
Point, and Size; we should take into consideration fluctuations in the
floating point representation as well.
This commit is contained in:
Emmanuele Bassi 2012-04-19 12:30:45 +01:00
parent 695621f5ea
commit 9c637ccb41
1 changed files with 9 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
clutter/clutter-base-types.c
View file

@ -39,6 +39,8 @@
#include <math.h>
#define FLOAT_EPSILON (1e-15)
/*
@ -277,9 +279,9 @@ clutter_vertex_equal (const ClutterVertex *vertex_a,
if (vertex_a == vertex_b)
return TRUE;
return vertex_a->x == vertex_b->x &&
vertex_a->y == vertex_b->y &&
vertex_a->z == vertex_b->z;
return fabsf (vertex_a->x - vertex_b->x) < FLOAT_EPSILON &&
fabsf (vertex_a->y - vertex_b->y) < FLOAT_EPSILON &&
fabsf (vertex_a->z - vertex_b->z) < FLOAT_EPSILON;
}
static gboolean
@ -469,7 +471,8 @@ clutter_point_equals (const ClutterPoint *a,
if (a == NULL || b == NULL)
return FALSE;
return a->x == b->x && a->y == b->y;
return fabsf (a->x - b->x) < FLOAT_EPSILON &&
fabsf (a->y - b->y) < FLOAT_EPSILON;
}
/**
@ -636,7 +639,8 @@ clutter_size_equals (const ClutterSize *a,
if (a == NULL || b == NULL)
return FALSE;
return a->width == b->width && a->height == b->height;
return fabsf (a->width - b->width) < FLOAT_EPSILON &&
fabsf (a->height - b->height) < FLOAT_EPSILON;
}
static gboolean