sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

window: Ensure window-visibility-updated is emitted when flushing queue

Browse source 
Currently the signal is getting emitted accidentally, because even when
removing a window from the queue, the later handler of that queue will
still get run due to a bug. This bug is going to get fixed in the next
commit, but some things might depend on the signal getting emitted when
the visibility of a window has changed.

This change affects the behavior in two ways. First the signal is now
emitted immediately rather than from an idle. And second it now
correctly includes the window in the should_show or should_hide list.

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2414>
This commit is contained in:
Sebastian Keller 2022-05-13 19:12:52 +02:00 committed by Marge Bot
parent 2a3c964e64
commit b289c8f01e
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/core/window.c
View file

@ -1800,11 +1800,13 @@ meta_window_flush_calc_showing (MetaWindow *window)
{
MetaWindowPrivate *priv = meta_window_get_instance_private (window);
if (priv->queued_types & META_QUEUE_CALC_SHOWING)
{
meta_window_unqueue (window, META_QUEUE_CALC_SHOWING);
meta_window_update_visibility (window);
}
if (!(priv->queued_types & META_QUEUE_CALC_SHOWING))
return;
meta_display_flush_queued_window (window->display, window,
META_QUEUE_CALC_SHOWING);
priv->queued_types &= ~META_QUEUE_CALC_SHOWING;
}
void