sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

egl: Don't free source error after propagating it

Browse source 
local_error in meta_egl_query_device_string() is using g_autoptr,
meaning that it was getting freed after g_propagate_error(). This then
would result in error->message becoming invalid, causing crashes when
logging the error message later on.

Fixes: 8234f5bc7 ("egl: Return success status from meta_egl_query_device_string")
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3758>
(cherry picked from commit 7a38e12ed0)
This commit is contained in:
Sebastian Keller 2024-05-19 19:53:37 +02:00 committed by Jonas Ådahl
parent d3a73d1a2d
commit b34fbc3120
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/backends/meta-egl.c
View file

@ -827,7 +827,7 @@ meta_egl_query_device_string (MetaEgl *egl,
check_egl_error (&local_error); check_egl_error (&local_error);
if (local_error) if (local_error)
{ {
g_propagate_error (error, local_error); g_propagate_error (error, g_steal_pointer (&local_error));
return FALSE; return FALSE;
} }
} }