From b69d49e43c694e9fbd1c617a9620fde508b2c734 Mon Sep 17 00:00:00 2001
From: Robert Bragg <robert@linux.intel.com>
Date: Tue, 27 Jan 2009 11:07:22 +0000
Subject: [PATCH] Removes cogl_color_set_from_4d as it may mislead people.
Someone not sure which cogl_color_set_from_* version is "best" may use
set_from_4d because taking doubles implies higher precision. Currently
it doesn't have any advantage.
---
cogl-color.h | 17 -----------------
common/cogl-color.c | 15 ---------------
2 files changed, 32 deletions(-)
diff --git a/cogl-color.h b/cogl-color.h
index 05650d34a..8303f29e9 100644
--- a/cogl-color.h
+++ b/cogl-color.h
@@ -49,23 +49,6 @@ void cogl_color_set_from_4ub (CoglColor *dest,
guint8 green,
guint8 blue,
guint8 alpha);
-/**
- * cogl_color_set_from_4d:
- * @dest: return location for a #CoglColor
- * @red: value of the red channel, between 0 and 1
- * @green: value of the green channel, between 0 and 1
- * @blue: value of the blue channel, between 0 and 1
- * @alpha: value of the alpha channel, between 0 and 1
- *
- * Sets the values of the passed channels into a #CoglColor.
- *
- * Since: 1.0
- */
-void cogl_color_set_from_4d (CoglColor *dest,
- gdouble red,
- gdouble green,
- gdouble blue,
- gdouble alpha);
/**
* cogl_color_set_from_4f:
diff --git a/common/cogl-color.c b/common/cogl-color.c
index e4b74c6b0..1a23d8191 100644
--- a/common/cogl-color.c
+++ b/common/cogl-color.c
@@ -42,21 +42,6 @@ cogl_color_set_from_4ub (CoglColor *dest,
dest->alpha = alpha;
}
-void
-cogl_color_set_from_4d (CoglColor *dest,
- gdouble red,
- gdouble green,
- gdouble blue,
- gdouble alpha)
-{
- g_return_if_fail (dest != NULL);
-
- dest->red = 255 * red;
- dest->green = 255 * green;
- dest->blue = 255 * blue;
- dest->alpha = 255 * alpha;
-}
-
void
cogl_color_set_from_4f (CoglColor *dest,
float red,