sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

onscreen/native: Always free the next framebuffer on dispose

Browse source 
There was a sanity check that complained if there was still a "next
framebuffer" when disposing an onscreen. This is correct to complain
about under normal operation, as we always wait until receiving the page
flip callback before cleaning up the onscreen and their state.

However, when there are many hotplugs occurring, we might end up with
race conditions when the above sanity check is not valid: when we have
more than one monitor active, paint 1 one of them, but receive a hotplug
event before we paint the other(s), we will discard the already painted
onscreen before really issuing a page flip.

In this situation, we will have the "next framebuffer", but having that
is not a bug, it's a race condition, thus to not leak in this situation,
make sure to clean up the next framebuffer here too.

Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/2081
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2225>
This commit is contained in:
Jonas Ådahl 2022-01-09 23:37:45 +01:00 committed by Marge Bot
parent 8e91c6295d
commit bb6ae40a0f
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/backends/native/meta-onscreen-native.c
View file

@ -2146,10 +2146,7 @@ meta_onscreen_native_dispose (GObject *object)
switch (renderer_gpu_data->mode)
{
case META_RENDERER_NATIVE_MODE_GBM:
/* flip state takes a reference on the onscreen so there should
* never be outstanding flips when we reach here. */
g_warn_if_fail (onscreen_native->gbm.next_fb == NULL);
g_clear_object (&onscreen_native->gbm.next_fb);
free_current_bo (onscreen);
break;
case META_RENDERER_NATIVE_MODE_SURFACELESS: