sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

backend/native: Log more about what pixel formats are attempted

Browse source 
This might help identifying pixel format related issues.

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4016>
This commit is contained in:
Jonas Ådahl 2024-09-10 16:58:02 +02:00 • committed by Marge Bot
parent be39717639
commit c2273784ce
1 changed files with 21 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/backends/native/meta-renderer-native.c
View file

@ -428,13 +428,23 @@ meta_renderer_native_choose_gbm_format (MetaKmsPlane *kms_plane,
for (i = 0; i < num_formats; i++) for (i = 0; i < num_formats; i++)
{ {
g_autoptr (GError) local_error = NULL;
MetaDrmFormatBuf format_string;
meta_drm_format_to_string (&format_string, formats[i]);
g_clear_error (error); g_clear_error (error);
if (kms_plane && if (kms_plane &&
!meta_kms_plane_is_format_supported (kms_plane, formats[i])) !meta_kms_plane_is_format_supported (kms_plane, formats[i]))
{ {
g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED, g_set_error (&local_error, G_IO_ERROR, G_IO_ERROR_FAILED,
"KMS CRTC doesn't support format"); "KMS CRTC doesn't support format");
meta_topic (META_DEBUG_RENDER,
"Not using format %s: %s",
format_string.s,
local_error->message);
g_propagate_error (error, g_steal_pointer (&local_error));
continue; continue;
} }
@ -443,17 +453,22 @@ meta_renderer_native_choose_gbm_format (MetaKmsPlane *kms_plane,
attributes, attributes,
formats[i], formats[i],
out_config, out_config,
error)) &local_error))
{ {
MetaDrmFormatBuf format_string; meta_topic (META_DEBUG_RENDER,
meta_drm_format_to_string (&format_string, formats[i]);
meta_topic (META_DEBUG_KMS,
"Using GBM format %s for primary GPU EGL %s", "Using GBM format %s for primary GPU EGL %s",
format_string.s, purpose); format_string.s, purpose);
return TRUE; return TRUE;
} }
else
{
meta_topic (META_DEBUG_RENDER,
"Not using format %s: %s",
format_string.s,
local_error->message);
g_propagate_error (error, g_steal_pointer (&local_error));
}
} }
return FALSE; return FALSE;