sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

cogl-auto-texture: Avoid a double-free crash

Browse source 
If texture allocation fails (e.g. on an old GPU with size limit 2048)
then `cogl_texture_new_with_size` was trying to use the same CoglError
twice. The second time was after it had already been freed.

Bug reported and fix provided by Gert van de Kraats.

https://launchpad.net/bugs/1790525
This commit is contained in:
Daniel van Vugt 2018-10-11 14:49:22 +08:00 committed by Jonas Ådahl
parent b86d87453d
commit d21478b0f0
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cogl/cogl/deprecated/cogl-auto-texture.c
View file

@ -94,6 +94,7 @@ cogl_texture_new_with_size (unsigned int width,
if (!cogl_texture_allocate (tex, &skip_error)) if (!cogl_texture_allocate (tex, &skip_error))
{ {
cogl_error_free (skip_error); cogl_error_free (skip_error);
skip_error = NULL;
cogl_object_unref (tex); cogl_object_unref (tex);
tex = NULL; tex = NULL;
} }