sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

evdev: remove keyboard state accessor

Browse source 
It was a bad idea to add it, because clutter events are batched,
so by the time the application processes one, the keyboard state
internally tracked by clutter could be already different.
Instead, apps should use clutter_event_get_state_full()

https://bugzilla.gnome.org/show_bug.cgi?id=706494
This commit is contained in:
Giovanni Campagna 2013-09-09 13:19:20 +02:00
parent bf007a1339
commit d4ddabeaad
2 changed files with 0 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
clutter/evdev/clutter-device-manager-evdev.c
View file

@ -1435,24 +1435,6 @@ clutter_evdev_set_open_callback (ClutterOpenDeviceCallback callback,
open_callback_data = user_data;
}
/**
* clutter_evdev_get_keyboard_state: (skip)
* @evdev: the #ClutterDeviceManager created by the evdev backend
*
* Returns the xkb state tracking object for keyboard devices.
* The object must be treated as read only, and should be used only
* for reading out the detailed group and modifier state.
*
* Return value: the #xkb_state struct
*/
struct xkb_state *
clutter_evdev_get_keyboard_state (ClutterDeviceManager *evdev)
{
g_return_val_if_fail (CLUTTER_IS_DEVICE_MANAGER_EVDEV (evdev), NULL);
return (CLUTTER_DEVICE_MANAGER_EVDEV (evdev))->priv->xkb;
}
/**
* clutter_evdev_set_keyboard_map: (skip)
* @evdev: the #ClutterDeviceManager created by the evdev backend

1
clutter/evdev/clutter-evdev.h
View file

@ -78,7 +78,6 @@ void clutter_evdev_set_pointer_constrain_callback (ClutterDeviceManager
gpointer user_data,
GDestroyNotify user_data_notify);
struct xkb_state * clutter_evdev_get_keyboard_state (ClutterDeviceManager *evdev);
void clutter_evdev_set_keyboard_map (ClutterDeviceManager *evdev,
struct xkb_keymap *keymap);