sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

build: Make the generated glib-mkenums c file depend on the headers

Browse source 
What happens now if you rename an enum inside a header:

  • glib-mkenums generates the header file
  • a comparison is made with the previous version of the heade is made
    and no difference is found as you don't remove or create enums
  • the compilation of the generated mkenums c file fails because it has
    not been regenerated with the new, renamed, enum.

That's why the generated clutter-enum-types.c needs to depend on the
headers too.

Of course such scenario should not happen in stable releases as enums
are part of the API, but renaming enums happens in the development cycle
and create compilation errors (very annoying when doing git bissects for
instance).
This commit is contained in:
Damien Lespiau 2010-09-07 14:17:18 +01:00
parent 1eae9fcd7e
commit d7e5e9247b
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
build/autotools/Makefile.am.enums
View file

@ -34,7 +34,7 @@ stamp-enum-types: $(glib_enum_headers) $(srcdir)/$(enum_tmpl_h)
$(glib_enum_h): stamp-enum-types
@true
$(glib_enum_c): $(glib_enum_h) $(srcdir)/$(enum_tmpl_c)
$(glib_enum_c): $(glib_enum_headers) $(glib_enum_h) $(srcdir)/$(enum_tmpl_c)
$(QUIET_GEN)$(GLIB_MKENUMS) \
--template $(srcdir)/$(enum_tmpl_c) \
$(glib_enum_headers) > xgen-ec \