sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

window-actor: Remove negation in function name

Browse source 
Double negations are the spawn of the devil, and is_non_opaque() is
used like that to find out if it's opaque most often, change the
function name to see the glass half full.

https://gitlab.gnome.org/GNOME/mutter/merge_requests/698
This commit is contained in:
Carlos Garnacho 2019-07-30 23:01:04 +02:00
parent 90a5582a73
commit f501fdcc56
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/compositor/meta-window-actor.c
View file

@ -288,13 +288,13 @@ is_argb32 (MetaWindowActor *self)
} }
static gboolean static gboolean
is_non_opaque (MetaWindowActor *self) is_opaque (MetaWindowActor *self)
{ {
MetaWindowActorPrivate *priv = MetaWindowActorPrivate *priv =
meta_window_actor_get_instance_private (self); meta_window_actor_get_instance_private (self);
MetaWindow *window = priv->window; MetaWindow *window = priv->window;
return is_argb32 (self) || (window->opacity != 0xFF); return !is_argb32 (self) && (window->opacity == 0xFF);
} }
static gboolean static gboolean
@ -650,7 +650,7 @@ clip_shadow_under_window (MetaWindowActor *self)
if (priv->window->frame) if (priv->window->frame)
return TRUE; return TRUE;
return !is_non_opaque (self); return is_opaque (self);
} }
static void static void
@ -791,7 +791,7 @@ meta_window_actor_has_shadow (MetaWindowActor *self)
* Do not add shadows to non-opaque (ARGB32) windows, as we can't easily * Do not add shadows to non-opaque (ARGB32) windows, as we can't easily
* generate shadows for them. * generate shadows for them.
*/ */
if (is_non_opaque (self)) if (!is_opaque (self))
return FALSE; return FALSE;
/* /*
@ -1376,7 +1376,7 @@ meta_window_actor_cull_out (MetaCullable *cullable,
meta_cullable_cull_out_children (cullable, unobscured_region, clip_region); meta_cullable_cull_out_children (cullable, unobscured_region, clip_region);
meta_window_actor_set_clip_region_beneath (self, clip_region); meta_window_actor_set_clip_region_beneath (self, clip_region);
if (unobscured_region && !is_non_opaque (self)) if (unobscured_region && is_opaque (self))
{ {
cairo_region_t *region = meta_window_get_frame_bounds (priv->window); cairo_region_t *region = meta_window_get_frame_bounds (priv->window);