sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

stack: Add prerequisites to some stack API

Browse source 
Passing a NULL workspace does not make sense, since it silently
returns no windows. Mandate that a workspace is explicitly requested,
and while at it check the other arguments as well.

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2124>
This commit is contained in:
Carlos Garnacho 2021-12-01 12:22:12 +01:00
parent e74e8061a4
commit fa31c97aec
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/core/stack.c
View file

@ -1088,6 +1088,10 @@ meta_stack_get_default_focus_window_at_point (MetaStack *stack,
int root_x, int root_x,
int root_y) int root_y)
{ {
g_return_val_if_fail (META_IS_STACK (stack), NULL);
g_return_val_if_fail (META_IS_WORKSPACE (workspace), NULL);
g_return_val_if_fail (!not_this_one || META_IS_WINDOW (not_this_one), NULL);
return get_default_focus_window (stack, workspace, not_this_one, return get_default_focus_window (stack, workspace, not_this_one,
TRUE, root_x, root_y); TRUE, root_x, root_y);
} }
@ -1097,6 +1101,10 @@ meta_stack_get_default_focus_window (MetaStack *stack,
MetaWorkspace *workspace, MetaWorkspace *workspace,
MetaWindow *not_this_one) MetaWindow *not_this_one)
{ {
g_return_val_if_fail (META_IS_STACK (stack), NULL);
g_return_val_if_fail (META_IS_WORKSPACE (workspace), NULL);
g_return_val_if_fail (!not_this_one || META_IS_WINDOW (not_this_one), NULL);
return get_default_focus_window (stack, workspace, not_this_one, return get_default_focus_window (stack, workspace, not_this_one,
FALSE, 0, 0); FALSE, 0, 0);
} }