sungmg/mutter-performance-source
1
0
Fork 0
Code Activity

Remove unused variables

Browse source 
Detected through codeql

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3837>
(cherry picked from commit 6e1c761330)
This commit is contained in:
Bilal Elmoussaoui 2024-06-22 14:39:21 +02:00 • committed by Jonas Ådahl
parent 34ee35a53a
commit fc1532efc4
18 changed files with 1 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cogl/cogl/driver/gl/cogl-gl-framebuffer-back.c
View file

@ -55,7 +55,6 @@ ensure_bits_initialized (CoglGlFramebufferBack *gl_framebuffer_back)
cogl_framebuffer_driver_get_framebuffer (driver);
CoglContext *ctx = cogl_framebuffer_get_context (framebuffer);
CoglFramebufferBits *bits = &gl_framebuffer_back->bits;
g_autoptr (GError) error = NULL;
if (!gl_framebuffer_back->dirty_bitmasks)
return TRUE;

1
cogl/cogl/driver/gl/cogl-gl-framebuffer-fbo.c
View file

@ -65,7 +65,6 @@ ensure_bits_initialized (CoglGlFramebufferFbo *gl_framebuffer_fbo)
cogl_framebuffer_driver_get_framebuffer (driver);
CoglContext *ctx = cogl_framebuffer_get_context (framebuffer);
CoglFramebufferBits *bits = &gl_framebuffer_fbo->bits;
g_autoptr (GError) error = NULL;
if (!gl_framebuffer_fbo->dirty_bitmasks)
return TRUE;

1
src/backends/native/meta-onscreen-native.c
View file

@ -2127,7 +2127,6 @@ choose_onscreen_egl_config (CoglOnscreen *onscreen,
MetaCrtcKms *crtc_kms = META_CRTC_KMS (onscreen_native->crtc);
MetaKmsPlane *kms_plane = meta_crtc_kms_get_assigned_primary_plane (crtc_kms);
EGLint attrs[MAX_EGL_CONFIG_ATTRIBS];
g_autoptr (GError) local_error = NULL;
static const uint32_t alphaless_10bpc_formats[] = {
GBM_FORMAT_XRGB2101010,
GBM_FORMAT_XBGR2101010,

1
src/backends/native/meta-renderer-native.c
View file

@ -2172,7 +2172,6 @@ meta_renderer_native_unset_modes (MetaRendererNative *renderer_native)
MetaKmsDevice *kms_device =
meta_gpu_kms_get_kms_device (META_GPU_KMS (gpu));
GList *k;
g_autoptr (MetaKmsFeedback) kms_feedback = NULL;
MetaKmsUpdate *kms_update = NULL;
for (k = meta_gpu_get_crtcs (gpu); k; k = k->next)

1
src/backends/native/meta-thread.c
View file

@ -765,7 +765,6 @@ meta_thread_reset_thread_type (MetaThread *thread,
MetaThreadType thread_type)
{
MetaThreadPrivate *priv = meta_thread_get_instance_private (thread);
g_autoptr (GMainContext) thread_context = NULL;
if (priv->thread_type == thread_type)
return;

1
src/core/window.c
View file

@ -6851,7 +6851,6 @@ meta_window_get_unit_cgroup (MetaWindow *window)
g_autofree char *contents = NULL;
g_autofree char *complete_path = NULL;
g_autofree char *unit_name = NULL;
g_autofree char *unit_path = NULL;
char *unit_end;
pid_t pid;

1
src/tests/color-management-profile-conflict-test.c
View file

@ -35,7 +35,6 @@ get_colord_mock_proxy (void)
{
GDBusProxy *proxy;
g_autoptr (GError) error = NULL;
g_autoptr (GVariant) ret = NULL;
proxy =
g_dbus_proxy_new_for_bus_sync (G_BUS_TYPE_SYSTEM,

2
src/tests/color-management-tests.c
View file

@ -126,7 +126,6 @@ get_colord_mock_proxy (void)
{
GDBusProxy *proxy;
g_autoptr (GError) error = NULL;
g_autoptr (GVariant) ret = NULL;
proxy =
g_dbus_proxy_new_for_bus_sync (G_BUS_TYPE_SYSTEM,
@ -259,7 +258,6 @@ get_gsd_color_mock_proxy (void)
{
GDBusProxy *proxy;
g_autoptr (GError) error = NULL;
g_autoptr (GVariant) ret = NULL;
proxy =
g_dbus_proxy_new_for_bus_sync (G_BUS_TYPE_SESSION,

3
src/tests/input-capture-tests.c
View file

@ -318,7 +318,6 @@ meta_test_input_capture_clear_barriers (void)
MetaBackend *backend = meta_context_get_backend (test_context);
ClutterSeat *seat = meta_backend_get_default_seat (backend);
g_autoptr (MetaVirtualMonitor) virtual_monitor1 = NULL;
g_autoptr (MetaVirtualMonitor) virtual_monitor2 = NULL;
g_autoptr (ClutterVirtualInputDevice) virtual_pointer = NULL;
InputCaptureTestClient *test_client;
@ -436,7 +435,6 @@ meta_test_input_capture_events (void)
MetaBackend *backend = meta_context_get_backend (test_context);
ClutterSeat *seat = meta_backend_get_default_seat (backend);
g_autoptr (MetaVirtualMonitor) virtual_monitor1 = NULL;
g_autoptr (MetaVirtualMonitor) virtual_monitor2 = NULL;
g_autoptr (ClutterVirtualInputDevice) virtual_pointer = NULL;
g_autoptr (ClutterVirtualInputDevice) virtual_keyboard = NULL;
InputCaptureTestClient *test_client;
@ -595,7 +593,6 @@ main (int argc,
char **argv)
{
g_autoptr (MetaContext) context = NULL;
g_autoptr (GError) error = NULL;
g_assert_cmpstr (getenv ("GSETTINGS_BACKEND"), ==, "memory");

1
src/tests/meta-backend-test.c
View file

@ -100,7 +100,6 @@ meta_backend_test_add_test_device (MetaBackendTest *backend_test,
ClutterInputDeviceType device_type,
int n_buttons)
{
g_autoptr (GList) devices = NULL;
MetaBackend *backend = META_BACKEND (backend_test);
ClutterBackend *clutter_backend = meta_backend_get_clutter_backend (backend);
ClutterSeat *seat = clutter_backend_get_default_seat (clutter_backend);

2
src/tests/native-thread.c
View file

@ -1147,7 +1147,6 @@ assert_realtime (MetaThreadImpl *thread_impl,
GError **error)
{
g_autoptr (GVariant) ret = NULL;
g_autoptr (GVariant) priority_variant = NULL;
uint32_t priority = 0;
g_assert_true (meta_thread_impl_is_realtime (thread_impl));
@ -1196,7 +1195,6 @@ assert_no_realtime (MetaThreadImpl *thread_impl,
GError **error)
{
g_autoptr (GVariant) ret = NULL;
g_autoptr (GVariant) priority_variant = NULL;
uint32_t priority = UINT32_MAX;
g_assert_false (meta_thread_impl_is_realtime (thread_impl));

1
src/tests/service-channel-tests.c
View file

@ -93,7 +93,6 @@ main (int argc,
char **argv)
{
g_autoptr (MetaContext) context = NULL;
g_autoptr (GError) error = NULL;
context = meta_create_test_context (META_CONTEXT_TEST_TYPE_HEADLESS,
META_CONTEXT_TEST_FLAG_NO_X11);

1
src/tests/wayland-client-tests.c
View file

@ -168,7 +168,6 @@ main (int argc,
char **argv)
{
g_autoptr (MetaContext) context = NULL;
g_autoptr (GError) error = NULL;
context = meta_create_test_context (META_CONTEXT_TEST_TYPE_HEADLESS,
META_CONTEXT_TEST_FLAG_NO_X11);

1
src/tests/wayland-x11-interop-tests.c
View file

@ -275,7 +275,6 @@ main (int argc,
char **argv)
{
g_autoptr (MetaContext) context = NULL;
g_autoptr (GError) error = NULL;
context = meta_create_test_context (META_CONTEXT_TEST_TYPE_HEADLESS,
META_CONTEXT_TEST_FLAG_TEST_CLIENT);

1
src/tests/xwayland-tests.c
View file

@ -320,7 +320,6 @@ main (int argc,
char **argv)
{
g_autoptr (MetaContext) context = NULL;
g_autoptr (GError) error = NULL;
context = test_context =
meta_create_test_context (META_CONTEXT_TEST_TYPE_HEADLESS,

2
src/wayland/meta-wayland-data-device-primary.c
View file

@ -175,7 +175,6 @@ primary_device_set_selection (struct wl_client *client,
uint32_t serial)
{
MetaWaylandDataDevicePrimary *data_device = wl_resource_get_user_data (resource);
MetaWaylandSeat *seat = wl_container_of (data_device, seat, primary_data_device);
MetaWaylandDataSource *source = NULL;
if (source_resource)
@ -343,7 +342,6 @@ void
meta_wayland_data_device_primary_set_focus (MetaWaylandDataDevicePrimary *data_device,
MetaWaylandSurface *surface)
{
MetaWaylandSeat *seat = wl_container_of (data_device, seat, primary_data_device);
struct wl_client *focus_client = NULL;
struct wl_resource *data_device_resource;

2
src/wayland/meta-wayland-data-device.c
View file

@ -1048,7 +1048,6 @@ data_device_set_selection (struct wl_client *client,
uint32_t serial)
{
MetaWaylandDataDevice *data_device = wl_resource_get_user_data (resource);
MetaWaylandSeat *seat = wl_container_of (data_device, seat, data_device);
MetaWaylandDataSource *source;
if (source_resource)
@ -1250,7 +1249,6 @@ void
meta_wayland_data_device_set_focus (MetaWaylandDataDevice *data_device,
MetaWaylandSurface *surface)
{
MetaWaylandSeat *seat = wl_container_of (data_device, seat, data_device);
struct wl_client *focus_client = NULL;
struct wl_resource *data_device_resource;

8
src/wayland/meta-wayland-input.c
View file

@ -337,13 +337,7 @@ meta_wayland_input_detach_event_handler (MetaWaylandInput *input,
wl_list_remove (&handler->link);
if (handler_change && !wl_list_empty (&input->event_handler_list))
{
MetaWaylandEventHandler *head =
wl_container_of (input->event_handler_list.next,
head, link);
meta_wayland_input_invalidate_all_focus (input);
}
meta_wayland_input_invalidate_all_focus (input);
if (input->grab && !should_be_grabbed (input))
{