Carlos Garnacho
e74e8061a4
wayland: Specify workspace when looking for Xdnd drop target
...
The meta_stack_get_default_focus_window_at_point() function started silently
requiring a workspace, returning always NULL otherwise. Specify the current
workspace here.
Fixes: https://gitlab.gnome.org/GNOME/mutter/-/issues/2042
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2124 >
2021-12-01 15:39:08 +01:00
Jonas Ådahl
fb78ac4016
xwayland: Init/shutdown DND using MetaX11Display
...
Before it was passed an Display pointer, and had to e.g. fetch the root
window from GDK instead of the MetaX11Display.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1796 >
2021-10-26 16:55:12 +02:00
Jonas Ådahl
5bc8823701
xwayland: Don't fetch global when shutting down DND
...
It might not be there when shutting down, so get it from a more managed
place. Note that this isn't strictly needed right now, but eventually,
the MetaWaylandCompositor pointer will be cleared using a g_clear*()
helper, which clears the pointer before freeing the instance, which
wouldn't work here.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1863 >
2021-05-18 14:03:22 +00:00
Robert Mader
6eeeffdc68
src: Stop using GSlice
...
It has been inofficially deprecated for years, is known to cause issues
with valgrind and potentially hides memory corruption.
Lets stop using it.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1512 >
2021-02-22 13:52:27 +01:00
Carlos Garnacho
8e01ea1e04
wayland: Plug XDnD drag source leak
...
This object is just being detached, with no code unref'ing it. Do
this whenever the XDnD selection goes unowned, usually a good
indication that the drag source no longer is one.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1720 >
2021-02-09 19:33:13 +00:00
Carlos Garnacho
3799606fc2
wayland: Make XDnD grab unlink source/offer manually
...
This currently happens by default whenever the grab is finished.
We want to eventually do this manually everywhere, so start here.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1720 >
2021-02-09 19:33:13 +00:00
Carlos Garnacho
c6849a66e8
clutter: Drop clutter_input_device_get_coords() method
...
This is not device state anymore. It uses ClutterSeat API underneath,
so let callers do that instead.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1403 >
2020-11-27 15:14:33 +00:00
Jonas Ådahl
2c95e08998
Remove misplaced line break in g_* logging functions
...
They resulted in empty lines in the log.
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1466
2020-10-08 16:38:41 +02:00
Sebastian Keller
dd32ff018a
wayland: Free selection streams streams after transfer
...
They were only being closed but never freed.
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1293
2020-06-08 12:11:11 +00:00
Carlos Garnacho
6a3d521466
wayland: Split MetaWaylandDataSource into a separate file
...
The split wasn't 100% clean, and some extra private API had to be
added for it (but well, looking at the API, it's already evident
there's a cleanup/streamlining task due). This is meant to be a
refactor with no functional changes, so just go with it.
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1193
2020-04-17 00:46:21 +02:00
Carlos Garnacho
ba3417667f
wayland/xdnd: Add error traps around Xdnd* IPC
...
Make all of them spew criticals, except for XdndLeave as it's feasible
to expect the window we are sending the event to did disappear in the
way (eg. if the window is destroyed while the DnD operation is ongoing
and the pointer is over the window).
Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2590
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1184
2020-04-07 18:08:03 +00:00
Sebastian Keller
509e9ca5a0
xwayland: Fix mime type atom list leak on DnD with more than 3 types
...
Found using the clang static analyzer
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1117
2020-03-11 03:21:36 +01:00
Jonas Ådahl
c0c74484bc
wayland: Don't access MetaWaylandSurface::window directly
...
It'll be moved to the role owning it, accessed via a helper function
implemented by the role. Currently it still just fetches the field in
MetaWaylandSurface.
https://gitlab.gnome.org/GNOME/mutter/merge_requests/835
2020-02-19 22:34:28 +00:00
Carlos Garnacho
090a6ad409
xwayland: Set XDND source-side actions as per XDND
...
In XDND, we just get a hint on XdndPosition about what's the action
chosen by the user. Make the data source actions the full set on
XdndEnter (as we can't know better), and pass the hint in XdndPosition
as the user chosen action as it should be.
Makes Wayland drop sites aware of the user action as per XDND with X11
drag sources, and still makes modifiers during DnD work.
https://gitlab.gnome.org/GNOME/mutter/issues/974
https://gitlab.gnome.org/GNOME/mutter/merge_requests/1005
2020-01-27 14:07:47 +00:00
Carlos Garnacho
c1df48befd
wayland: Preserve XdndTypeList for future callers
...
This Xdnd property is owned by the drag source, we shouldn't delete
it when reading/proxying it to Wayland clients.
Closes: https://gitlab.gnome.org/GNOME/gtk/issues/2347
https://gitlab.gnome.org/GNOME/mutter/merge_requests/1005
2020-01-27 14:07:47 +00:00
Georges Basile Stavracas Neto
160cc9182d
Replace ClutterPoint by graphene_point_t
...
Remove the tests for ClutterPoint since it's
corresponding code moved to private ClutterStage
methods.
https://gitlab.gnome.org/GNOME/mutter/merge_requests/458
2019-10-16 11:38:14 +00:00
Olivier Fourdan
bc166aa6b4
xwayland: Use given X11 display for DnD setup
...
Use the provided X11 display instead of poking into GDK to get the X11
display.
https://gitlab.gnome.org/GNOME/mutter/merge_requests/735
2019-08-19 17:14:40 +02:00
Carlos Garnacho
17d00d49d4
wayland: Reduce MetaXWaylandSelection to just DnD
...
All the actual selection management functionality is superseded by
MetaSelection. Reduce it to just handling the XDND messaging and leave
selections to MetaSelection.
https://gitlab.gnome.org/GNOME/mutter/merge_requests/320
2019-05-02 16:31:45 +02:00
