185630085c
This option to GCC makes it give a warning whenever a global function is defined without a declaration. This should catch cases were we've defined a function but forgot to put it in a header. In that case it is either only used within one file so we should make it static or we should declare it in a header. The following changes where made to fix problems: • Some functions were made static • cogl-path.h (the one containing the 1.0 API) was split into two files, one defining the functions and one defining the enums so that cogl-path.c can include the enum and function declarations from the 2.0 API as well as the function declarations from the 1.0 API. • cogl2-clip-state has been removed. This only had one experimental function called cogl_clip_push_from_path but as this is unstable we might as well remove it favour of the equivalent cogl_framebuffer_* API. • The GLX, SDL and WGL winsys's now have a private header to define their get_vtable function instead of directly declaring in the C file where it is called. • All places that were calling COGL_OBJECT_DEFINE need to have the cogl_is_whatever function declared so these have been added either as a public function or in a private header. • Some files that were not including the header containing their function declarations have been fixed to do so. • Any unused error quark functions have been removed. If we later want them we should add them back one by one and add a declaration for them in a header. • _cogl_is_framebuffer has been renamed to cogl_is_framebuffer and made a public function with a declaration in cogl-framebuffer.h • Similarly for CoglOnscreen. • cogl_vdraw_indexed_attributes is called cogl_framebuffer_vdraw_indexed_attributes in the header. The definition has been changed to match the header. • cogl_index_buffer_allocate has been removed. This had no declaration and I'm not sure what it's supposed to do. • CoglJournal has been changed to use the internal CoglObject macro so that it won't define an exported cogl_is_journal symbol. • The _cogl_blah_pointer_from_handle functions have been removed. CoglHandle isn't used much anymore anyway and in the few places where it is used I think it's safe to just use the implicit cast from void* to the right type. • The test-utils.h header for the conformance tests explicitly disables the -Wmissing-declaration option using a pragma because all of the tests declare their main function without a header. Any mistakes relating to missing declarations aren't really important for the tests. • cogl_quaternion_init_from_quaternion and init_from_matrix have been given declarations in cogl-quaternion.h Reviewed-by: Robert Bragg <robert@linux.intel.com>
82 lines
2.5 KiB
C
82 lines
2.5 KiB
C
/*
|
|
* Cogl
|
|
*
|
|
* An object oriented GL/GLES Abstraction/Utility Layer
|
|
*
|
|
* Copyright (C) 2008,2009 Intel Corporation.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*
|
|
*/
|
|
|
|
#ifndef __COGL_PROGRAM_H
|
|
#define __COGL_PROGRAM_H
|
|
|
|
#include "cogl-handle.h"
|
|
#include "cogl-internal.h"
|
|
#include "cogl-shader-private.h"
|
|
|
|
typedef struct _CoglProgram CoglProgram;
|
|
|
|
struct _CoglProgram
|
|
{
|
|
CoglHandleObject _parent;
|
|
|
|
GSList *attached_shaders;
|
|
|
|
GArray *custom_uniforms;
|
|
|
|
/* An age counter that changes whenever the list of shaders is modified */
|
|
unsigned int age;
|
|
};
|
|
|
|
typedef struct _CoglProgramUniform CoglProgramUniform;
|
|
|
|
struct _CoglProgramUniform
|
|
{
|
|
char *name;
|
|
CoglBoxedValue value;
|
|
/* The cached GL location for this uniform. This is only valid
|
|
between calls to _cogl_program_dirty_all_uniforms */
|
|
GLint location;
|
|
/* Whether we have a location yet */
|
|
unsigned int location_valid : 1;
|
|
/* Whether the uniform value has changed since the last time the
|
|
uniforms were flushed */
|
|
unsigned int dirty : 1;
|
|
};
|
|
|
|
/* Internal function to flush the custom uniforms for the given use
|
|
program. This assumes the target GL program is already bound. The
|
|
gl_program still needs to be passed so that CoglProgram can query
|
|
the uniform locations. gl_program_changed should be set to TRUE if
|
|
we are flushing the uniforms against a different GL program from
|
|
the last time it was flushed. This will cause it to requery all of
|
|
the locations and assume that all uniforms are dirty */
|
|
void
|
|
_cogl_program_flush_uniforms (CoglProgram *program,
|
|
GLuint gl_program,
|
|
gboolean gl_program_changed);
|
|
|
|
CoglShaderLanguage
|
|
_cogl_program_get_language (CoglHandle handle);
|
|
|
|
gboolean
|
|
_cogl_program_has_fragment_shader (CoglHandle handle);
|
|
|
|
gboolean
|
|
_cogl_program_has_vertex_shader (CoglHandle handle);
|
|
|
|
#endif /* __COGL_PROGRAM_H */
|