1
0
Fork 0
mutter-performance-source/cogl
Robert Bragg 1acf5cc36f [cogl_read_pixels] don't force a 4 byte pack alignment
Technically this change shouldn't make a difference since we are
calling glReadPixels with GL_RGBA GL_UNSIGNED_BYTE which is a 4
byte format and it should always result in the same value according
to how OpenGL calculates the location of sequential rows.

i.e. k  = a/s * ceil(snl/a) where:
 a = alignment
 s = component size (1)
 n = number of components per pixel (4)
 l = number of pixels in a row
gives:
k = 4/1 * ceil(4l/4) and k = 1/1 * ceil(4l/1) which are equivalent

I'm changing it because I've seen i915 driver code that bails out of
hardware accelerated paths if the alignment isn't 1, and because
conceptually we have no alignment constraints here so even if the current
value has no effect, when we start reading back other formats it may upset
things.
2009-11-04 03:34:03 +00:00
..
driver [draw-buffers] First pass at overhauling Cogl's framebuffer management 2009-11-03 17:23:03 +00:00
winsys build: Make COGL pass distcheck 2009-10-23 13:38:40 +01:00
cogl-bitmap-fallback.c Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-bitmap-pixbuf.c Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-bitmap-private.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-bitmap.c Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-bitmap.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-blend-string.c Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-blend-string.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-clip-stack.c [clip-stack] tidy up transform_point() code 2009-11-04 03:32:52 +00:00
cogl-clip-stack.h [draw-buffers] First pass at overhauling Cogl's framebuffer management 2009-11-03 17:23:03 +00:00
cogl-color.c Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-color.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-context.c [cogl] Make sure Cogl always knows the current window geometry 2009-11-04 03:23:20 +00:00
cogl-context.h [cogl] Make sure Cogl always knows the current window geometry 2009-11-04 03:23:20 +00:00
cogl-debug.c Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-debug.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-deprecated.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-draw-buffer-private.h [draw-buffer] Adds cogl_draw_buffer_get_{width,height} API 2009-11-04 03:23:20 +00:00
cogl-draw-buffer.c [draw-buffer] Adds cogl_draw_buffer_get_{width,height} API 2009-11-04 03:23:20 +00:00
cogl-enum-types.c.in Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-enum-types.h.in Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-fixed.c Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-fixed.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-handle.h [cogl-texture] Split CoglTexture into an abstract class + CoglTexture2dSliced 2009-10-16 18:58:51 +01:00
cogl-internal.h [cogl] Removes the cogl-current-matrix abstraction 2009-10-20 12:32:50 +01:00
cogl-journal-private.h [cogl-primitives] Split the journal out from cogl-primitives.c 2009-10-16 18:58:52 +01:00
cogl-journal.c [draw-buffers] First pass at overhauling Cogl's framebuffer management 2009-11-03 17:23:03 +00:00
cogl-material-private.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-material.c [cogl] Removes the cogl-current-matrix abstraction 2009-10-20 12:32:50 +01:00
cogl-material.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-matrix-stack.c [cogl] Make sure we draw upside down to offscreen draw buffers 2009-11-04 03:23:19 +00:00
cogl-matrix-stack.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-matrix.c Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-matrix.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-offscreen.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-path.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-primitives.c [draw-buffers] First pass at overhauling Cogl's framebuffer management 2009-11-03 17:23:03 +00:00
cogl-primitives.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-shader.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-spans.c [cogl-spans] split out cogl-spans code from cogl-texture-2d-sliced 2009-10-16 18:58:52 +01:00
cogl-spans.h [cogl-spans] split out cogl-spans code from cogl-texture-2d-sliced 2009-10-16 18:58:52 +01:00
cogl-texture-2d-sliced-private.h [cogl-spans] split out cogl-spans code from cogl-texture-2d-sliced 2009-10-16 18:58:52 +01:00
cogl-texture-2d-sliced.c [cogl-spans] split out cogl-spans code from cogl-texture-2d-sliced 2009-10-16 18:58:52 +01:00
cogl-texture-driver.h [cogl-texture] Split CoglTexture into an abstract class + CoglTexture2dSliced 2009-10-16 18:58:51 +01:00
cogl-texture-private.h [cogl-primitives] Split the journal out from cogl-primitives.c 2009-10-16 18:58:52 +01:00
cogl-texture.c [draw-buffers] First pass at overhauling Cogl's framebuffer management 2009-11-03 17:23:03 +00:00
cogl-texture.h [docs] switch gl_handle+gl_target docs for cogl_texture_new_from_foreign 2009-10-16 18:58:51 +01:00
cogl-types.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-util.c [cogl] Removes the cogl-current-matrix abstraction 2009-10-20 12:32:50 +01:00
cogl-util.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-vertex-buffer-private.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl-vertex-buffer.c [draw-buffers] First pass at overhauling Cogl's framebuffer management 2009-11-03 17:23:03 +00:00
cogl-vertex-buffer.h Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
cogl.c [cogl_read_pixels] don't force a 4 byte pack alignment 2009-11-04 03:34:03 +00:00
cogl.h.in [cogl] deprecate cogl_viewport() in favour of cogl_set_viewport() 2009-11-04 03:23:21 +00:00
cogl.pc.in Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00
Makefile.am [draw-buffers] First pass at overhauling Cogl's framebuffer management 2009-11-03 17:23:03 +00:00
stb_image.c Intial Re-layout of the Cogl source code and introduction of a Cogl Winsys 2009-10-16 18:58:50 +01:00