sungmg/mutter-performance-source
1
0
Fork 0
Code Activity
mutter-performance-source/src/core/window.c

8596 lines
260 KiB
C
Raw Normal View History

Stick an emacs comment directive at the beginning of all the code files so 2006-10-01 Elijah Newren <newren gmail com> * src/*.[ch]: Stick an emacs comment directive at the beginning of all the code files so that people using emacs will be more likely to get coding style correct in their patches. We still need a similar vi directive. #358866
2006-10-01 22:30:10 +00:00
/* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*- */
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
/*
Add _NET_WM_ICON_GEOMETRY atom. 2001-08-05 Anders Carlsson <andersca@gnu.org> * src/display.h, src/display.c: Add _NET_WM_ICON_GEOMETRY atom. * src/window.c (meta_window_calc_showing): See if the window has an icon geometry and show a morphing animation from the window's coordinates to the icon's coordinates. (meta_window_get_icon_geometry): New function that fetches a window's icon geometry. * src/Makefile.am: Add effects.[ch]. * src/effects.c: New file with cool effects.
2001-08-05 16:04:52 +00:00
* Copyright (C) 2001 Havoc Pennington, Anders Carlsson
Patch from Rob Adams addresses #95014 (placement issues), makes first fit 2003-02-23 Havoc Pennington <hp@pobox.com> Patch from Rob Adams addresses #95014 (placement issues), makes first fit algorithm "center tile", adds most code for per-xinerama workspaces (#86682) but disables it for now. * src/workspace.c (meta_workspace_get_work_area_for_xinerama) (meta_workspace_get_work_area_all_xineramas): new xinerama functions, maintain workspace->work_areas with a different work area for each xinerama. However for now all the work areas are the same, because haven't quite figured out how _NET_WM_STRUT is supposed to work * src/window.c: adapt to new meta_window_* xinerama APIs (meta_window_get_work_area_current_xinerama): new xinerama API (meta_window_get_work_area_for_xinerama): new xinerama API (constrain_position): be a bit more clever about which xinerama's work area we choose to use. * src/stack.c: adapt to new Xinerama API * src/screen.c (reload_xinerama_infos): invalidate all work areas (meta_screen_get_xinerama_for_rect): new function (meta_screen_window_intersects_xinerama): new function * src/place.c (find_first_fit): change to use "center tiling" (center a screen full of tiled windows, rather than aligning them top left). Adapt to new xinerama functions.
2003-02-23 17:09:46 +00:00
* Copyright (C) 2002, 2003 Red Hat, Inc.
* Copyright (C) 2003 Rob Adams
Whoops, I forgot to keep my copyright info updated with my previous 2006-01-10 Elijah Newren <newren@gmail.com> * src/bell.c: * src/boxes.c: * src/boxes.h: * src/constraints.c: * src/core.c: * src/display.c: * src/display.h: * src/edge-resistance.c: * src/frames.c: * src/keybindings.c: * src/main.c: * src/prefs.c: * src/prefs.h: * src/screen.c: * src/screen.h: * src/window.c: * src/window.h: Whoops, I forgot to keep my copyright info updated with my previous commits as Havoc had asked me to do. Doing that now...
2006-01-10 19:43:21 +00:00
* Copyright (C) 2004-2006 Elijah Newren
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
*
...
2001-05-30 15:36:31 +00:00
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; either version 2 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* General Public License for more details.
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
*
...
2001-05-30 15:36:31 +00:00
* You should have received a copy of the GNU General Public License
Changed obsolete FSF postal address into generic URL. Fix https://bugzilla.gnome.org/show_bug.cgi?id=721517 #2
2014-01-12 01:42:06 +00:00
* along with this program; if not, see <http://www.gnu.org/licenses/>.
...
2001-05-30 15:36:31 +00:00
*/
Add a meaningful name and description to all sections/files in the API docs https://bugzilla.gnome.org/show_bug.cgi?id=695641
2013-03-11 15:52:36 +00:00
/**
Add some gtk-doc comments.
2018-10-19 07:15:54 +00:00
* SECTION:meta-window
Add a meaningful name and description to all sections/files in the API docs https://bugzilla.gnome.org/show_bug.cgi?id=695641
2013-03-11 15:52:36 +00:00
* @title: MetaWindow
Add some gtk-doc comments.
2018-10-19 07:15:54 +00:00
* @short_description: A display-agnostic abstraction for a window.
*
* #MetaWindow is the core abstraction in Mutter of a window. It has the
* properties you'd expect, such as a title, an icon, whether it's fullscreen,
* has decorations, etc.
*
* Since a lot of different kinds of windows exist, each window also a
* #MetaWindowType which denotes which kind of window we're exactly dealing
* with. For example, one expects slightly different behaviour from a dialog
* than a "normal" window. The type of a window can be queried with
* meta_window_get_type().
*
* Common API for windows include:
* - Minimizing: meta_window_minimize() / meta_window_unminimize()
* - Maximizing: meta_window_maximize() / meta_window_unmaximize()
* - Fullscreen: meta_window_make_fullscreen() / meta_window_unmake_fullscreen()
* / meta_window_is_fullscreen()
*
* Each #MetaWindow is part of either one or all #MetaWorkspace<!-- -->s of the
* desktop. You can activate a window on a certain workspace using
* meta_window_activate_with_workspace(), and query on which workspace it is
* located using meta_window_located_on_workspace(). The workspace it is part
* of can be obtained using meta_window_get_workspace().
*
* Each display protocol should make a subclass to be compatible with that
* protocols' specifics, for example #MetaWindowX11 and #MetaWindowWayland.
* This is independent of the protocol that the client uses, which is modeled
* using the #MetaWindowClientType enum.
*
* To integrate within the Clutter scene graph, which deals with the actual
* rendering, each #MetaWindow will be part of a #MetaWindowActor.
Add a meaningful name and description to all sections/files in the API docs https://bugzilla.gnome.org/show_bug.cgi?id=695641
2013-03-11 15:52:36 +00:00
*/
Clean up include macros mess The order and way include macros were structured was chaotic, with no real common thread between files. Try to tidy up the mess with some common scheme, to make things look less messy.
2018-07-10 08:36:24 +00:00
#include "config.h"
...
2001-06-06 04:47:37 +00:00
Clean up include macros mess The order and way include macros were structured was chaotic, with no real common thread between files. Try to tidy up the mess with some common scheme, to make things look less messy.
2018-07-10 08:36:24 +00:00
#include "core/window-private.h"
#include <math.h>
Free memory allocated by XIQueryPointer() https://bugzilla.gnome.org/show_bug.cgi?id=695135
2013-03-04 14:57:01 +00:00
#include <stdlib.h>
new function (meta_prop_get_wm_hints): new function 2002-10-26 Havoc Pennington <hp@pobox.com> * src/xprops.c (meta_prop_get_text_property): new function (meta_prop_get_wm_hints): new function (meta_prop_get_class_hint): new function
2002-10-26 16:40:50 +00:00
#include <string.h>
Clean up include macros mess The order and way include macros were structured was chaotic, with no real common thread between files. Try to tidy up the mess with some common scheme, to make things look less messy.
2018-07-10 08:36:24 +00:00
#include <X11/Xatom.h>
...
2001-06-02 04:14:18 +00:00
Clean up include macros mess The order and way include macros were structured was chaotic, with no real common thread between files. Try to tidy up the mess with some common scheme, to make things look less messy.
2018-07-10 08:36:24 +00:00
#include "backends/meta-backend-private.h"
#include "backends/meta-logical-monitor.h"
core: Trace various window management actions https://gitlab.gnome.org/GNOME/mutter/merge_requests/765
2019-08-29 17:34:18 +00:00
#include "cogl/cogl-trace.h"
Clean up include macros mess The order and way include macros were structured was chaotic, with no real common thread between files. Try to tidy up the mess with some common scheme, to make things look less messy.
2018-07-10 08:36:24 +00:00
#include "core/boxes-private.h"
#include "core/constraints.h"
#include "core/edge-resistance.h"
#include "core/frame.h"
#include "core/keybindings-private.h"
#include "core/meta-workspace-manager-private.h"
#include "core/place.h"
#include "core/stack.h"
#include "core/util-private.h"
#include "core/workspace-private.h"
display: Move the pointer event handling code to work in terms of Clutter events There is now a meta_display_handle_event alongside the meta_display_handle_xevent function which handles events in terms of Clutter events instead of X events. A Clutter event filter is registered so that all Clutter events will pass through this function. The pointer event handling code from the X event version has been moved into this new function and has been modified to use the details from the Clutter event instead of the X event. This is a step towards moving all of the event handling code over to use Clutter events. Based-heavily-on-a-patch-by: Neil Roberts <neil@linux.intel.com>
2013-10-03 19:29:44 +00:00
#include "meta/compositor-mutter.h"
Clean up include macros mess The order and way include macros were structured was chaotic, with no real common thread between files. Try to tidy up the mess with some common scheme, to make things look less messy.
2018-07-10 08:36:24 +00:00
#include "meta/group.h"
#include "meta/meta-cursor-tracker.h"
#include "meta/meta-enum-types.h"
#include "meta/meta-x11-errors.h"
#include "meta/prefs.h"
#include "ui/ui.h"
Start populating MetaX11Display - Moved xdisplay, name and various atoms from MetaDisplay - Moved xroot, screen_name, default_depth and default_xvisual from MetaScreen - Moved some X11 specific functions from screen.c and display.c to meta-x11-display.c https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 16:26:30 +00:00
#include "x11/meta-x11-display-private.h"
Remove x11/ directory from default include path
2014-03-19 01:56:45 +00:00
#include "x11/window-props.h"
Clean up include macros mess The order and way include macros were structured was chaotic, with no real common thread between files. Try to tidy up the mess with some common scheme, to make things look less messy.
2018-07-10 08:36:24 +00:00
#include "x11/window-x11.h"
Remove x11/ directory from default include path
2014-03-19 01:56:45 +00:00
#include "x11/xprops.h"
Conditionalize Wayland support again
2014-08-14 00:19:35 +00:00
#ifdef HAVE_WAYLAND
Clean up include macros mess The order and way include macros were structured was chaotic, with no real common thread between files. Try to tidy up the mess with some common scheme, to make things look less messy.
2018-07-10 08:36:24 +00:00
#include "wayland/meta-wayland-private.h"
#include "wayland/meta-wayland-surface.h"
window-wayland.[ch] => meta-window-wayland.[ch] This finishes off the meta- prefix for wayland/.
2015-04-28 01:09:16 +00:00
#include "wayland/meta-window-wayland.h"
xwayland: Add MetaWindowXwayland MetaWindowXwayland derives from MetaWindowX11 to allow for some Xwayland specific vfunc that wouldn't apply to plain X11 windows, such as shortcut inhibit routines. https://bugzilla.gnome.org/show_bug.cgi?id=783342
2017-08-30 07:17:41 +00:00
#include "wayland/meta-window-xwayland.h"
Conditionalize Wayland support again
2014-08-14 00:19:35 +00:00
#endif
Don't include wayland/ by default either
2014-03-19 02:01:31 +00:00
Don't unmaximize to nearly maximized size Basically we don't really want to create windows that are almost maximized in size but not actually maximized. This creates work for the user and makes it very difficult to use and resize manually. So set the newly unmaximized window size to the previously used size or 80% of the size of the current workarea (attempting to retain natural aspect ratio if possible), whichever is smaller. https://bugzilla.gnome.org/show_bug.cgi?id=671677
2012-03-12 16:09:17 +00:00
/* Windows that unmaximize to a size bigger than that fraction of the workarea
Automaximize large windows on map Windows that start up in a size that is almost as big as the workarea create extra work for the user (resizing or maximizing) so save the user's time by detecting such windows and automaximize them. https://bugzilla.gnome.org/show_bug.cgi?id=671677
2012-03-15 19:42:11 +00:00
* will be scaled down to that size (while maintaining aspect ratio).
* Windows that cover an area greater then this size are automaximized on map.
*/
Don't unmaximize to nearly maximized size Basically we don't really want to create windows that are almost maximized in size but not actually maximized. This creates work for the user and makes it very difficult to use and resize manually. So set the newly unmaximized window size to the previously used size or 80% of the size of the current workarea (attempting to retain natural aspect ratio if possible), whichever is smaller. https://bugzilla.gnome.org/show_bug.cgi?id=671677
2012-03-12 16:09:17 +00:00
#define MAX_UNMAXIMIZED_WINDOW_AREA .8
window: Support snap packages for sandboxed app IDs For now we abuse of meta_window_get_flatpak_id not to break the APIs, so that it's working seamlessly in gnone shell too. Rename flatpak_id to sandboxed_app_id internally to get prepared to the future API. https://bugzilla.gnome.org/show_bug.cgi?id=788217
2017-09-26 21:22:43 +00:00
#define SNAP_SECURITY_LABEL_PREFIX "snap."
give priority to keeping NW corner onscreen rather than SE, if we need to 2002-01-18 Havoc Pennington <hp@pobox.com> * src/window.c (constrain_position): give priority to keeping NW corner onscreen rather than SE, if we need to shift the window to fit inside constraints * src/frames.c (meta_frames_get_geometry): don't depend on the current window size * src/theme.c: move geometry stuff in here, to be calculated as part of the theme * src/core.c (meta_core_get_client_size): new function to replace meta_core_get_frame_size() so we don't have weird cycles in the geometry calculation
2002-01-19 03:50:03 +00:00
static int destroying_windows_disallowed = 0;
window: Don't use C++-style comments
2015-03-14 23:03:23 +00:00
/* Each window has a "stamp" which is a non-recycled 64-bit ID. They
* start after the end of the XID space so that, for stacking
* we can keep a guint64 that represents one or the other
*/
Replace MetaStackWindow with a 64-bit "stack ID" Putting X windows and pointers to MetaWindows into a union had a number of problems: - It caused awkward initialization and conditionalization - There was no way to refer to Wayland windows (represented by MetaWindow *) in the past, which is necessary for the MetaStackTracker algorithms - We never even cleaned up old MetaStackWindow so there could be records in MetaStackWindow pointing to freed MetaWindow. Replace MetaStackWindow with a 64-bit "stack ID" which is: - The XID for X Windows - a "window stamp" for Wayland windows - window stamps are assigned for all MetaWindow and are unique across the life of the process. https://bugzilla.gnome.org/show_bug.cgi?id=736559
2014-09-09 01:20:14 +00:00
static guint64 next_window_stamp = G_GUINT64_CONSTANT(0x100000000);
...
2001-06-09 21:58:30 +00:00
add more debug spew about conditional build stuff (main): panic to 2003-02-27 Havoc Pennington <hp@pobox.com> * src/main.c (main): add more debug spew about conditional build stuff (main): panic to "Simple" theme * src/window.c, src/window-props.c: move WM_NORMAL_HINTS and WM_PROTOCOLS to new property system; don't queue move resize on updating WM_PROTOCOLS; move WM_HINTS to new property system; reload icon in an idle handler. Changes made on plane from FOSDEM, syncing from laptop.
2003-02-28 01:24:44 +00:00
static void invalidate_work_areas (MetaWindow *window);
window: Centralize WM_STATE management
2014-02-02 00:03:33 +00:00
static void set_wm_state (MetaWindow *window);
Optimizations for managing new windows (do not all take effect if 2002-10-21 Havoc Pennington <hp@redhat.com> Optimizations for managing new windows (do not all take effect if METACITY_DEBUG=1). Bug #96404 * src/keybindings.c (meta_change_keygrab): use error trap nesting and conditionalize on meta_is_verbose() to avoid a ton of XSync * src/display.c (meta_change_button_grab): ditto Throughout: move to new error trap setup to save on XSync calls, new setup is: * src/errors.c (meta_error_trap_push_with_return): new function, an error trap that needs to care about return value and thus sync even if an outer trap still exists (meta_error_trap_pop_with_return): new function (meta_error_trap_pop): add "last_request_was_roundtrip" argument allowing us to avoid XSync() if we just did a GetProperty or whatever. * src/util.c (meta_warning): flush the warning file descriptor * src/Makefile.am (INCLUDES): define G_LOG_DOMAIN
2002-10-21 21:44:35 +00:00
static void set_net_wm_state (MetaWindow *window);
MetaWindow: Add :resizable and :above properties Allow libmutter users to treat windows different based on these attributes and to watch for changes. https://bugzilla.gnome.org/show_bug.cgi?id=653858
2011-07-02 11:08:17 +00:00
static void meta_window_set_above (MetaWindow *window,
gboolean new_value);
Add _NET_FRAME_EXTENTS and _NET_REQUEST_FRAME_EXTENTS. 2004-01-09 Thomas Fitzsimmons <fitzsim@redhat.com> Add _NET_FRAME_EXTENTS and _NET_REQUEST_FRAME_EXTENTS. * src/display.c: include xprops.h (process_request_frame_extents): new function (meta_display_open): add _NET_FRAME_EXTENTS and _NET_REQUEST_FRAME_EXTENTS atoms (event_callback): handle frame extents message * src/display.h (struct _MetaDisplay): add atom_net_frame_extents and atom_net_request_frame_extents * src/theme.c (meta_pango_font_desc_get_text_height): make font_desc parameter const * src/ui.c: include prefs.h (meta_ui_theme_get_frame_borders): new function * src/window.c (update_net_frame_extents): new function (meta_window_move_resize_internal): update frame extents property when frame geometry changes * src/screen.c (set_supported_hint): add atom_net_frame_extents and atom_net_request_frame_extents
2004-01-10 17:16:07 +00:00
...
2001-06-06 04:47:37 +00:00
static void meta_window_show (MetaWindow *window);
static void meta_window_hide (MetaWindow *window);
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
static void meta_window_save_rect (MetaWindow *window);
Have newly mapped windows that are denied focus appear after the focused 2004-08-05 Elijah Newren <newren@math.utah.edu> Have newly mapped windows that are denied focus appear after the focused window in the alt-tab list. This allows one to switch to such a window with a single alt-tab press. * src/window.c (ensure_mru_position_after): new function, (meta_window_show): If newly mapped window is denied focus, call ensure_mru_position_after to make the window appear after the focus window in the mru list.
2004-08-05 17:48:39 +00:00
static void ensure_mru_position_after (MetaWindow *window,
MetaWindow *after_this_one);
Patch from Kjartan Maraas to fix a lot of tiny issues (unused variable 2006-01-20 Elijah Newren <newren gmail com> * src/async-getprop.c: * src/common.h: * src/display.c: * src/eggaccelerators.c: * src/frames.c: * src/gradient.c: * src/iconcache.c: * src/keybindings.c: * src/metaaccellabel.c: * src/place.c: * src/prefs.c: * src/preview-widget.c: * src/screen.c: * src/session.c: * src/stack.c: * src/tabpopup.c: * src/theme-viewer.c: * src/theme.c: * src/window-props.c: * src/window.c: * src/workspace.c: * src/tools/metacity-window-demo.c: * src/wm-tester/test-gravity.c: * src/wm-tester/test-resizing.c: * src/wm-tester/test-size-hints.c: Patch from Kjartan Maraas to fix a lot of tiny issues (unused variable removal, making unused variables used again, correction of types passed/declared for printf arguments, removal of unneeded breaks and returns, dead code removal, dead code revival, renaming to prevent shadowed variables, declaring unexported functions as static) spotted by the intel compiler. #321439
2006-01-20 22:03:56 +00:00
static void meta_window_move_resize_now (MetaWindow *window);
...
2001-06-23 18:30:27 +00:00
make prototype of meta_window_unqueue match implementation. Closes 2007-06-16 Damien Carbery <damien.carbery@sun.com> * window.h: make prototype of meta_window_unqueue match implementation. Closes #446535. svn path=/trunk/; revision=3243
2007-06-17 02:15:07 +00:00
static void meta_window_unqueue (MetaWindow *window, guint queuebits);
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
static void update_move (MetaWindow *window,
gboolean snap,
int x,
int y);
static gboolean update_move_timeout (gpointer data);
static void update_resize (MetaWindow *window,
gboolean snap,
int x,
int y,
gboolean force);
static gboolean update_resize_timeout (gpointer data);
Split out on_all_workspaces and on_all_workspaces_requested Sometimes on_all_workspaces is requested by the client/user, and sometimes its calculated implicitly due to internal state. We split this up so that we know when the user has explicitly asked for sticky window, when e.g. setting wmspec properties or storing session info. on_all_workspaces means this window is visible on all workspaces. on_all_workspaces_requested, means the user explicitly made the window sticky somehow (via imported session, _NET_WM_STATE from another wm, toggled in the window menu, etc). It always implies on_all_workspaces is TRUE. Right now the only time we set on_all_workspaces is for override-redirect windows, but later we can add a "windows on non-primary monitor are not part of the workspace switching" feature. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 10:41:23 +00:00
static gboolean should_be_on_all_workspaces (MetaWindow *window);
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
Patch from Kjartan Maraas to fix a lot of tiny issues (unused variable 2006-01-20 Elijah Newren <newren gmail com> * src/async-getprop.c: * src/common.h: * src/display.c: * src/eggaccelerators.c: * src/frames.c: * src/gradient.c: * src/iconcache.c: * src/keybindings.c: * src/metaaccellabel.c: * src/place.c: * src/prefs.c: * src/preview-widget.c: * src/screen.c: * src/session.c: * src/stack.c: * src/tabpopup.c: * src/theme-viewer.c: * src/theme.c: * src/window-props.c: * src/window.c: * src/workspace.c: * src/tools/metacity-window-demo.c: * src/wm-tester/test-gravity.c: * src/wm-tester/test-resizing.c: * src/wm-tester/test-size-hints.c: Patch from Kjartan Maraas to fix a lot of tiny issues (unused variable removal, making unused variables used again, correction of types passed/declared for printf arguments, removal of unneeded breaks and returns, dead code removal, dead code revival, renaming to prevent shadowed variables, declaring unexported functions as static) spotted by the intel compiler. #321439
2006-01-20 22:03:56 +00:00
static void meta_window_flush_calc_showing (MetaWindow *window);
...
2001-06-22 03:20:21 +00:00
put all transients of the new window, if any exist, in the calc_showing 2005-05-26 Elijah Newren <newren@gmail.com> * src/window.c: (meta_window_new_with_attrs): put all transients of the new window, if any exist, in the calc_showing queue. Fixes #303284.
2005-05-26 17:15:56 +00:00
static gboolean queue_calc_showing_func (MetaWindow *window,
void *data);
When monitors change, keep windows on same output. If XRANDR is availible, we track the first (or primary) output per crtc (== xinerama monitor) so when the monitors change we can try to find the same output and move windows there. If we can't find the original monitor in the new set (or XRANDR is not supported) we move the window to the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=645408
2011-05-20 08:56:12 +00:00
static void meta_window_move_between_rects (MetaWindow *window,
window: Really force update monitor on hot plugs Commit 8d3e05305 ("window: Force update monitor on hot plugs") added the flag `META_WINDOW_UPDATE_MONITOR_FLAGS_FORCE` passed to `update_monitor()` from `update_for_monitors_changed()`. However, `update_for_monitors_changed()` may choose to call another code path to `move_between_rects()` and `meta_window_move_resize_internal()` eventually. As `meta_window_move_resize_internal()` does not use the "force" flag, we may still end up in case where the window->monitor is left unchanged. To avoid that problem, add a new `MetaMoveResizeFlags` that `update_for_monitors_changed()` can use to force the monitor update from `meta_window_move_resize_internal()`. Fixes: 8d3e05305 ("window: Force update monitor on hot plugs") Closes: https://gitlab.gnome.org/GNOME/mutter/issues/189
2018-11-06 12:35:31 +00:00
MetaMoveResizeFlags move_resize_flags,
When monitors change, keep windows on same output. If XRANDR is availible, we track the first (or primary) output per crtc (== xinerama monitor) so when the monitors change we can try to find the same output and move windows there. If we can't find the original monitor in the new set (or XRANDR is not supported) we move the window to the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=645408
2011-05-20 08:56:12 +00:00
const MetaRectangle *old_area,
const MetaRectangle *new_area);
...
2001-07-27 04:36:44 +00:00
Patch from Dan Sanders to fix #334899. 2006-04-16 Elijah Newren <newren gmail com> Patch from Dan Sanders to fix #334899. * window.c (meta_window_new_with_attrs): Unminimize ancestors of new windows when mapped; this prevents e.g. confirmation windows from causing applications to appear locked when closing via the window list.
2006-04-17 03:54:49 +00:00
static void unmaximize_window_before_freeing (MetaWindow *window);
static void unminimize_window_and_all_transient_parents (MetaWindow *window);
window: Make propagate_focus_appearance internal to MetaWindow It's an internal helper function. The public interface is meta_window_activate or meta_window_focus.
2014-05-20 17:56:41 +00:00
static void meta_window_propagate_focus_appearance (MetaWindow *window,
gboolean focused);
window: Force updating icons when initially loading them Otherwise, Wayland windows will never get an icon.
2014-07-14 19:26:09 +00:00
static void meta_window_update_icon_now (MetaWindow *window,
gboolean force);
window: Make propagate_focus_appearance internal to MetaWindow It's an internal helper function. The public interface is meta_window_activate or meta_window_focus.
2014-05-20 17:56:41 +00:00
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
static void set_workspace_state (MetaWindow *window,
gboolean on_all_workspaces,
MetaWorkspace *workspace);
window: Tile and resize considering the tile match After the introduction of the possibility to resize tiled windows, it is a sensible decision to make windows aware of their tiling match. A tiling match is another window that is tiled in such a way that is the complement of the current window. The newly introduced behavior attepts to make tiling as smooth as possible, with the following rules: * Windows now compute their tile match when tiling and, if there's a match, they automatically complement the sibling's width. * Resizing a window with a sibling automatically resizes the sibling too to be the complement of the window's width. * It is not possible to resize below windows' minimum widths. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-12 01:13:03 +00:00
static MetaWindow * meta_window_find_tile_match (MetaWindow *window,
MetaTileMode mode);
window: Track edge constraints GTK has the ability to handle client-decorated windows in such a way that the behavior of these windows must match the behavior of the current window manager. In Mutter, windows can be tiled horizontally (and, in the future, vertically as well), which comes with a few requirements that the toolkit must supply. Tiled windows have their borders' behavior changed depending on the tiled position, and the toolkit must be aware of this information in order to properly match the window manager behavior. In order to provide toolkits with more precise and general data regarding resizable and constrained edges, this patch makes MetaWindow track its own edge constraints. This will later be used by the backends to send information to the toolkit. https://bugzilla.gnome.org/show_bug.cgi?id=751857
2017-08-17 03:43:21 +00:00
static void update_edge_constraints (MetaWindow *window);
window: Tile and resize considering the tile match After the introduction of the possibility to resize tiled windows, it is a sensible decision to make windows aware of their tiling match. A tiling match is another window that is tiled in such a way that is the complement of the current window. The newly introduced behavior attepts to make tiling as smooth as possible, with the following rules: * Windows now compute their tile match when tiling and, if there's a match, they automatically complement the sibling's width. * Resizing a window with a sibling automatically resizes the sibling too to be the complement of the window's width. * It is not possible to resize below windows' minimum widths. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-12 01:13:03 +00:00
Use "later functions" to fix priority problems with Clutter redraw There was a problem where if, for example, a restack was triggered out of a clutter event handler, then after Clutter processed the events, it would proceed immmediately on to repaint the stage without ever returning control to the GLib main loop. So even though we had an idle handler installed with a higher priority than the Clutter stage repainting the clutter stage repainting would happen first and we'd get a wrong frame. Fix this by introducing the idea of "later functions", which abstract the idea of "doing something later" away from g_idle_add() and use a combination of GLib idle functions and Clutter "repaint functions" to get our callbacks triggered at the right time, even when they are installed from a clutter event handler. https://bugzilla.gnome.org/show_bug.cgi?id=596334 This also resolve a FIXME where MUTTER_PRIORITY_BEFORE_REDRAW could starve stage repainting.
2009-09-25 19:47:22 +00:00
/* Idle handlers for the three queues (run with meta_later_add()). The
* "data" parameter in each case will be a GINT_TO_POINTER of the
* index into the queue arrays to use.
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
*
* TODO: Possibly there is still some code duplication among these, which we
* need to sort out at some point.
*/
static gboolean idle_calc_showing (gpointer data);
static gboolean idle_move_resize (gpointer data);
static gboolean idle_update_icon (gpointer data);
Avoid flashing when closing a maximized window. Fixes #317254. 2006-01-20 Elijah Newren <newren gmail com> Avoid flashing when closing a maximized window. Fixes #317254. * src/window.c (unmaximize_window_before_freeing): new function that just fixes the net_wm_state and sends a configure_notify, (meta_window_free): use unmaximize_window_before_freeing() instead of meta_window_unmaximize() to avoid flicker
2006-01-20 23:36:23 +00:00
window: MetaWindow is now abstract
2014-03-19 13:36:36 +00:00
G_DEFINE_ABSTRACT_TYPE (MetaWindow, meta_window, G_TYPE_OBJECT);
Make MetaWindow a GObject Make MetaWindow into a GObject so that it is accessible to gobject-introspection (also allows for signals to be added.) Renames: meta_window_free() => meta_window_unmanage() meta_window_get_type() => meta_window_get_window_type() meta_window_get_type_atom() => meta_window_get_window_type_atom()
2008-11-07 09:57:00 +00:00
Use a consistent style for enum braces https://gitlab.gnome.org/GNOME/mutter/merge_requests/361
2018-12-19 08:04:25 +00:00
enum
{
Add gproperties to MetaWindow: "title", "icon", "mini-icon" We need these properties to do things outside of the frame, without dropping to libwnck. http://bugzilla.gnome.org/show_bug.cgi?id=563405
2008-12-06 01:03:27 +00:00
PROP_0,
PROP_TITLE,
PROP_ICON,
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
PROP_MINI_ICON,
Turned window decorated flag into MetaWindow::decorated property. This allows things like the compositor to easily track decoration status.
2009-02-11 12:16:41 +00:00
PROP_DECORATED,
Added MetaWindow::fullscreen property (read only).
2009-03-17 12:27:13 +00:00
PROP_FULLSCREEN,
[MetaWindow] Expose maximized state as properties Add properties for the EWMH _NET_WM_STATE_MAXIMIZED_HORZ and _NET_WM_STATE_MAXIMIZED_VERT hints. https://bugzilla.gnome.org/show_bug.cgi?id=590706
2010-02-12 20:26:52 +00:00
PROP_MAXIMIZED_HORIZONTALLY,
PROP_MAXIMIZED_VERTICALLY,
window: Expose minimized state as property Track the minimized state in a property, so that we can receive change notifications. https://bugzilla.gnome.org/show_bug.cgi?id=651568
2011-05-31 17:52:04 +00:00
PROP_MINIMIZED,
[MetaWindow] Make user-time a GObject property Notification of changes are useful for code ordering windows.
2009-08-31 16:06:53 +00:00
PROP_WINDOW_TYPE,
[MetaWindow] Added boolean demands-attention property https://bugzilla.gnome.org/show_bug.cgi?id=588065
2009-11-17 10:02:06 +00:00
PROP_USER_TIME,
[MetaWindow] added urgent property Property tracking ICCCM urgency hint https://bugzilla.gnome.org/show_bug.cgi?id=600068
2009-11-20 08:51:19 +00:00
PROP_DEMANDS_ATTENTION,
_MUTTER_HINTS A per-window _MUTTER_HINTS property allowing plugins to use custom hints. The property holds a colon separated list of key=value pairs; plugin-specific keys must be suitably namespaced, while 'mutter-' prefix is reserved for internal Mutter use only. This commit adds MetaWindow::mutter-hints property, and meta_window_get_mutter_hints() accessor, as well as the internal machinery for reading and updating of the hints. https://bugzilla.gnome.org/show_bug.cgi?id=613123
2010-01-18 10:12:17 +00:00
PROP_URGENT,
window: Add "skip-taskbar" property We currently only have a method to query the skip-taskbar hint. Add a corresponding property to allow listening for change notifications. https://bugzilla.gnome.org/show_bug.cgi?id=723307
2014-01-30 21:39:54 +00:00
PROP_SKIP_TASKBAR,
window: add an appears-focused property, redraw shadows when it changes We need to redraw a window's shadow any time the value of meta_window_appears_focused() changes. So make that into a property so we can get notifications on it. https://bugzilla.gnome.org/show_bug.cgi?id=636904
2011-03-25 01:36:47 +00:00
PROP_MUTTER_HINTS,
window: Add wm-class property and notify it when changed. https://bugzilla.gnome.org/show_bug.cgi?id=649315
2011-03-03 09:01:04 +00:00
PROP_APPEARS_FOCUSED,
MetaWindow: Add :resizable and :above properties Allow libmutter users to treat windows different based on these attributes and to watch for changes. https://bugzilla.gnome.org/show_bug.cgi?id=653858
2011-07-02 11:08:17 +00:00
PROP_RESIZEABLE,
PROP_ABOVE,
Load _DBUS_APPLICATION_ID property, expose it via API This is used to associate GtkApplication -> X window, and will be consumed by gnome-shell. https://bugzilla.gnome.org/show_bug.cgi?id=664851
2011-11-25 23:42:41 +00:00
PROP_WM_CLASS,
adjust to new Gtk properties for app menu https://bugzilla.gnome.org/show_bug.cgi?id=668118
2012-01-17 18:27:10 +00:00
PROP_GTK_APPLICATION_ID,
PROP_GTK_UNIQUE_BUS_NAME,
PROP_GTK_APPLICATION_OBJECT_PATH,
PROP_GTK_WINDOW_OBJECT_PATH,
PROP_GTK_APP_MENU_OBJECT_PATH,
window: Add a property for on_all_workspaces Some plugins and extensions want to be able to know when the sticky field of a window changes, so add a property for it and allow them to connect to the notify::on-all-workspaces signal.
2014-06-24 20:05:36 +00:00
PROP_GTK_MENUBAR_OBJECT_PATH,
window: Use g_object_class_install_properties
2014-06-24 20:18:26 +00:00
PROP_ON_ALL_WORKSPACES,
Change naming of GParmSpec enum id string for naming consistency GParamSpec enum string usually follows "PROP_" prefix and PROP_LAST is used for last PROP string. https://gitlab.gnome.org/GNOME/mutter/issues/28 Closes: #28
2018-02-10 12:36:48 +00:00
PROP_LAST,
Add gproperties to MetaWindow: "title", "icon", "mini-icon" We need these properties to do things outside of the frame, without dropping to libwnck. http://bugzilla.gnome.org/show_bug.cgi?id=563405
2008-12-06 01:03:27 +00:00
};
Change naming of GParmSpec enum id string for naming consistency GParamSpec enum string usually follows "PROP_" prefix and PROP_LAST is used for last PROP string. https://gitlab.gnome.org/GNOME/mutter/issues/28 Closes: #28
2018-02-10 12:36:48 +00:00
static GParamSpec *obj_props[PROP_LAST];
window: Use g_object_class_install_properties
2014-06-24 20:18:26 +00:00
MetaWindow::workspace-changed signal. Emitted when window is moved from one workspace to another; the number of the old workspace is passed to the signal handlers.
2009-01-20 12:52:06 +00:00
enum
{
WORKSPACE_CHANGED,
MetaWindow::focus signal.
2009-02-02 11:00:13 +00:00
FOCUS,
MetaWindow::raised signal.
2009-02-02 14:08:46 +00:00
RAISED,
wayland: Move MetaWindow ownership to window owning roles There are two surface roles owning a MetaWindow: MetaWaylandShellSurface (basis of MetaWaylandXdgToplevel, MetaWaylandXdgPopup, MetaWaylandWlShellSurface, etc), and MetaXwaylandSurface. With these two role types, the MetaWindow has two different types of life times. With MetaWaylandShellSurface, the window is owned and managed by the role itself, while with MetaXwaylandSurface, the MetaWindow is tied to the X11 window, while the Wayland surface and its role plays more the role of the backing rendering surface. Before, for historical reasons, MetaWindow was part of MetaWaylandSurface, even though just some roles used it, and before 'wayland: Untie MetaWindowXwayland lifetime from the wl_surface' had equivalent life times as well. But since that commit, the management changed. To not have the same fied in MetaWaylandSurface being managed in such drastically different ways, rearrange it so that the roles that has a MetaWindow themself manages it in the way it is meant to; meaning MetaWaylandShellSurface practically owns it, while with Xwayland, the existance of a MetaWindow is tracked via X11. https://gitlab.gnome.org/GNOME/mutter/merge_requests/835
2019-10-09 07:57:40 +00:00
UNMANAGING,
Add "window-created" signal to MetaDisplay, "unmanaged" signal for MetaWindow For some consumers it's significantly more convenient to be able to directly connect to a signal on the Window to know when Mutter is done with it, rather than having to connect to each Workspace object (and handle workspace additions, etc.). Similarly, add window-created which acts globally. https://bugzilla.gnome.org/show_bug.cgi?id=598289
2009-10-13 14:34:34 +00:00
UNMANAGED,
Move position-changed / size-changed signals to the MetaWindow They fit more appropriately over here... https://bugzilla.gnome.org/show_bug.cgi?id=720631
2013-12-06 20:39:24 +00:00
SIZE_CHANGED,
POSITION_CHANGED,
tests: Move window-shown verification to test-runner Previously we relied on the test-client to make sure that a window was shown. For X11, we did not need to do anything, but for Wayland we had to make sure we had drawn the first frame, otherwise mutter wouldn't have a buffer making the window not showable. Doing it this way doesn't work anymore however, since the 'after-paint' event will be emitted even if we didn't actually paint anything. This is the case with current Gtk under Wayland, where we won't draw until the compositor has configured the surface. In effect, this mean we'll get a dummy after-paint emission before the first frame is actually painted. Instead, move the verification that a "show" command has completed by having the test-runner wait for a "shown" signal on the window, which is emitted in the end of meta_window_show(). This requires an additional call to gdk_display_sync() in the test-client after creating the window, to make sure that the window creation vents has been received in the compositor.
2018-07-12 08:25:16 +00:00
SHOWN,
MetaWindow::workspace-changed signal. Emitted when window is moved from one workspace to another; the number of the old workspace is passed to the signal handlers.
2009-01-20 12:52:06 +00:00
LAST_SIGNAL
};
static guint window_signals[LAST_SIGNAL] = { 0 };
window: Listen for pref changes The workspaces-only-on-primary preference changes how windows are displayed, so listen for pref changes and update the visibility accordingly. https://bugzilla.gnome.org/show_bug.cgi?id=664853
2011-11-26 00:52:24 +00:00
static void
prefs_changed_callback (MetaPreference pref,
gpointer data)
{
MetaWindow *window = data;
window: Handle changes of the attach-modal-dialogs preference Currently we decide whether a modal dialog should be attached or not when mapping it, i.e. we don't pick up preference changes that happen while the dialog is up. It's not really a big deal given that modal dialogs are usually transitory, but it's easy enough to add a bit of extra polish ... https://bugzilla.gnome.org/show_bug.cgi?id=679904
2012-07-13 22:22:51 +00:00
if (pref == META_PREF_WORKSPACES_ONLY_ON_PRIMARY)
{
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
meta_window_on_all_workspaces_changed (window);
window: Handle changes of the attach-modal-dialogs preference Currently we decide whether a modal dialog should be attached or not when mapping it, i.e. we don't pick up preference changes that happen while the dialog is up. It's not really a big deal given that modal dialogs are usually transitory, but it's easy enough to add a bit of extra polish ... https://bugzilla.gnome.org/show_bug.cgi?id=679904
2012-07-13 22:22:51 +00:00
}
else if (pref == META_PREF_ATTACH_MODAL_DIALOGS &&
window->type == META_WINDOW_MODAL_DIALOG)
{
window->attached = meta_window_should_attach_to_parent (window);
window: Fix build The proper function name is "meta_window_recalc_features"
2014-02-01 23:58:58 +00:00
meta_window_recalc_features (window);
window: Handle changes of the attach-modal-dialogs preference Currently we decide whether a modal dialog should be attached or not when mapping it, i.e. we don't pick up preference changes that happen while the dialog is up. It's not really a big deal given that modal dialogs are usually transitory, but it's easy enough to add a bit of extra polish ... https://bugzilla.gnome.org/show_bug.cgi?id=679904
2012-07-13 22:22:51 +00:00
meta_window_queue (window, META_QUEUE_MOVE_RESIZE);
}
window: Listen for pref changes The workspaces-only-on-primary preference changes how windows are displayed, so listen for pref changes and update the visibility accordingly. https://bugzilla.gnome.org/show_bug.cgi?id=664853
2011-11-26 00:52:24 +00:00
}
window: Turn grab_op_begin / grab_op_ended into vfuncs And move the grab_resize_popup management to the X11 window class, as this is only used under X11.
2014-04-29 19:55:55 +00:00
static void
meta_window_real_grab_op_began (MetaWindow *window,
MetaGrabOp op)
{
}
static void
meta_window_real_grab_op_ended (MetaWindow *window,
MetaGrabOp op)
{
window->shaken_loose = FALSE;
}
window: Move _NET_WM_DESKTOP setting to window-x11
2014-05-20 19:46:21 +00:00
static void
meta_window_real_current_workspace_changed (MetaWindow *window)
{
}
window: Move X11 struts implementation to X11 codepath
2014-04-28 21:06:38 +00:00
static gboolean
meta_window_real_update_struts (MetaWindow *window)
{
return FALSE;
}
Start splitting the X11-specific stuff of MetaWindow out into a subclass This is fairly simple and basic for now, with just skip_taskbar / skip_pager, but eventually a lot of "WM policy" like this, including move-resize, will be in subclasses for each individual surface.
2014-03-18 15:20:22 +00:00
static void
meta_window_real_get_default_skip_hints (MetaWindow *window,
gboolean *skip_taskbar_out,
gboolean *skip_pager_out)
{
*skip_taskbar_out = FALSE;
*skip_pager_out = FALSE;
}
window: Move X11-specific icon code to MetaWindowX11
2014-07-14 16:01:22 +00:00
static gboolean
x11: Change the iconcache / window icons to being cairo surfaces This simplifies the drawing codepath and makes us able to delete a bunch of GdkPixbuf manipulation.
2015-01-01 04:39:36 +00:00
meta_window_real_update_icon (MetaWindow *window,
cairo_surface_t **icon,
cairo_surface_t **mini_icon)
window: Move X11-specific icon code to MetaWindowX11
2014-07-14 16:01:22 +00:00
{
*icon = NULL;
*mini_icon = NULL;
return FALSE;
}
window: Add get_client_pid() method It is often useful to identify the client process that created a particular window, however the existing meta_window_get_pid() method relies on _NET_WM_PID, which is only available on X11 and depends on applications to set it correctly (which may not even be possible when the app runs in its own PID namespace as Flatpak apps do). So add a get_client_pid() method that uses windowing system facilities to resolve the PID associated with a particular window. https://bugzilla.gnome.org/show_bug.cgi?id=772613
2016-10-07 15:55:32 +00:00
static uint32_t
meta_window_real_get_client_pid (MetaWindow *window)
{
return 0;
}
Make MetaWindow a GObject Make MetaWindow into a GObject so that it is accessible to gobject-introspection (also allows for signals to be added.) Renames: meta_window_free() => meta_window_unmanage() meta_window_get_type() => meta_window_get_window_type() meta_window_get_type_atom() => meta_window_get_window_type_atom()
2008-11-07 09:57:00 +00:00
static void
meta_window_finalize (GObject *object)
{
MetaWindow *window = META_WINDOW (object);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Make MetaWindow a GObject Make MetaWindow into a GObject so that it is accessible to gobject-introspection (also allows for signals to be added.) Renames: meta_window_free() => meta_window_unmanage() meta_window_get_type() => meta_window_get_window_type() meta_window_get_type_atom() => meta_window_get_window_type_atom()
2008-11-07 09:57:00 +00:00
if (window->icon)
x11: Change the iconcache / window icons to being cairo surfaces This simplifies the drawing codepath and makes us able to delete a bunch of GdkPixbuf manipulation.
2015-01-01 04:39:36 +00:00
cairo_surface_destroy (window->icon);
Make MetaWindow a GObject Make MetaWindow into a GObject so that it is accessible to gobject-introspection (also allows for signals to be added.) Renames: meta_window_free() => meta_window_unmanage() meta_window_get_type() => meta_window_get_window_type() meta_window_get_type_atom() => meta_window_get_window_type_atom()
2008-11-07 09:57:00 +00:00
if (window->mini_icon)
x11: Change the iconcache / window icons to being cairo surfaces This simplifies the drawing codepath and makes us able to delete a bunch of GdkPixbuf manipulation.
2015-01-01 04:39:36 +00:00
cairo_surface_destroy (window->mini_icon);
Make MetaWindow a GObject Make MetaWindow into a GObject so that it is accessible to gobject-introspection (also allows for signals to be added.) Renames: meta_window_free() => meta_window_unmanage() meta_window_get_type() => meta_window_get_window_type() meta_window_get_type_atom() => meta_window_get_window_type_atom()
2008-11-07 09:57:00 +00:00
Only shadow ARGB windows with a frame outside the frame An ARGB window with a frame is likely something like a transparent terminal. It looks awful (and breaks transparency) to draw a big opaque black shadow under the window, so clip out the region under the terminal from the shadow we draw. Add meta_window_get_frame_bounds() to get a cairo region for the outer bounds of the frame of a window, and modify the frame handling code to notice changes to the frame shape and discard a cached region. meta_frames_apply_shapes() is refactored so we can extract meta_frames_get_frame_bounds() from it. https://bugzilla.gnome.org/show_bug.cgi?id=635268
2011-03-22 19:36:12 +00:00
if (window->frame_bounds)
cairo_region_destroy (window->frame_bounds);
window: Fix memory leak https://bugzilla.gnome.org/show_bug.cgi?id=708070
2013-09-14 12:19:46 +00:00
if (window->shape_region)
cairo_region_destroy (window->shape_region);
Support _NET_WM_OPAQUE_REGION This new hint allows compositors to know what portions of a window will be obscured, as a region above them is opaque. For an RGB window, possible to glean this information from the bounding shape region of a client window, but not for an ARGB32 window. This new hint allows clients that use ARGB32 windows to say which part of the window is opaque, allowing this sort of optimization. https://bugzilla.gnome.org/show_bug.cgi?id=679901
2013-01-15 01:45:31 +00:00
if (window->opaque_region)
cairo_region_destroy (window->opaque_region);
window: Don't leak the input region
2014-07-28 09:20:19 +00:00
if (window->input_region)
cairo_region_destroy (window->input_region);
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
if (window->transient_for)
g_object_unref (window->transient_for);
Make MetaWindow a GObject Make MetaWindow into a GObject so that it is accessible to gobject-introspection (also allows for signals to be added.) Renames: meta_window_free() => meta_window_unmanage() meta_window_get_type() => meta_window_get_window_type() meta_window_get_type_atom() => meta_window_get_window_type_atom()
2008-11-07 09:57:00 +00:00
g_free (window->sm_client_id);
g_free (window->wm_client_machine);
g_free (window->startup_id);
g_free (window->role);
g_free (window->res_class);
g_free (window->res_name);
g_free (window->title);
g_free (window->desc);
window: Support snap packages for sandboxed app IDs For now we abuse of meta_window_get_flatpak_id not to break the APIs, so that it's working seamlessly in gnone shell too. Rename flatpak_id to sandboxed_app_id internally to get prepared to the future API. https://bugzilla.gnome.org/show_bug.cgi?id=788217
2017-09-26 21:22:43 +00:00
g_free (window->sandboxed_app_id);
window: Parse _GTK_THEME_VARIANT property Since version 3.0, GTK+ has support for style variants. At the moment, themes may provide a dark variant, which can be requested by applications via GtkSettings. The requested variant is exported to X11 via the _GTK_THEME_VARIANT property - support this property, in order to pick up the correct style variant in the future. https://bugzilla.gnome.org/show_bug.cgi?id=645355
2011-03-19 09:31:25 +00:00
g_free (window->gtk_theme_variant);
adjust to new Gtk properties for app menu https://bugzilla.gnome.org/show_bug.cgi?id=668118
2012-01-17 18:27:10 +00:00
g_free (window->gtk_application_id);
g_free (window->gtk_unique_bus_name);
g_free (window->gtk_application_object_path);
g_free (window->gtk_window_object_path);
g_free (window->gtk_app_menu_object_path);
g_free (window->gtk_menubar_object_path);
window: Put placement related fields in a anynomous struct To organize things a bit better, put the fields related to the placement rule state in its own anonymous struct inside MetaWindow. While at it, rename the somewhat oddly named variable that in practice means the current relative window position. https://gitlab.gnome.org/GNOME/mutter/merge_requests/705
2020-02-13 21:40:15 +00:00
g_free (window->placement.rule);
window: Add missing chain-up for finalize() https://bugzilla.gnome.org/show_bug.cgi?id=698710
2013-04-23 12:47:19 +00:00
G_OBJECT_CLASS (meta_window_parent_class)->finalize (object);
Make MetaWindow a GObject Make MetaWindow into a GObject so that it is accessible to gobject-introspection (also allows for signals to be added.) Renames: meta_window_free() => meta_window_unmanage() meta_window_get_type() => meta_window_get_window_type() meta_window_get_type_atom() => meta_window_get_window_type_atom()
2008-11-07 09:57:00 +00:00
}
Add gproperties to MetaWindow: "title", "icon", "mini-icon" We need these properties to do things outside of the frame, without dropping to libwnck. http://bugzilla.gnome.org/show_bug.cgi?id=563405
2008-12-06 01:03:27 +00:00
static void
meta_window_get_property(GObject *object,
guint prop_id,
GValue *value,
GParamSpec *pspec)
{
MetaWindow *win = META_WINDOW (object);
switch (prop_id)
{
case PROP_TITLE:
g_value_set_string (value, win->title);
break;
case PROP_ICON:
MetaWindow: Change icon properties to be of pointer type Follow up to commit af7f51b992b20da543312fa9fdf1dcef39704b37 . https://bugzilla.gnome.org/show_bug.cgi?id=742824
2015-01-12 20:23:42 +00:00
g_value_set_pointer (value, win->icon);
Add gproperties to MetaWindow: "title", "icon", "mini-icon" We need these properties to do things outside of the frame, without dropping to libwnck. http://bugzilla.gnome.org/show_bug.cgi?id=563405
2008-12-06 01:03:27 +00:00
break;
case PROP_MINI_ICON:
MetaWindow: Change icon properties to be of pointer type Follow up to commit af7f51b992b20da543312fa9fdf1dcef39704b37 . https://bugzilla.gnome.org/show_bug.cgi?id=742824
2015-01-12 20:23:42 +00:00
g_value_set_pointer (value, win->mini_icon);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
break;
Turned window decorated flag into MetaWindow::decorated property. This allows things like the compositor to easily track decoration status.
2009-02-11 12:16:41 +00:00
case PROP_DECORATED:
g_value_set_boolean (value, win->decorated);
break;
Added MetaWindow::fullscreen property (read only).
2009-03-17 12:27:13 +00:00
case PROP_FULLSCREEN:
g_value_set_boolean (value, win->fullscreen);
break;
[MetaWindow] Expose maximized state as properties Add properties for the EWMH _NET_WM_STATE_MAXIMIZED_HORZ and _NET_WM_STATE_MAXIMIZED_VERT hints. https://bugzilla.gnome.org/show_bug.cgi?id=590706
2010-02-12 20:26:52 +00:00
case PROP_MAXIMIZED_HORIZONTALLY:
g_value_set_boolean (value, win->maximized_horizontally);
break;
case PROP_MAXIMIZED_VERTICALLY:
g_value_set_boolean (value, win->maximized_vertically);
break;
window: Expose minimized state as property Track the minimized state in a property, so that we can receive change notifications. https://bugzilla.gnome.org/show_bug.cgi?id=651568
2011-05-31 17:52:04 +00:00
case PROP_MINIMIZED:
g_value_set_boolean (value, win->minimized);
break;
Added MetaWindow::window-type property Read-only property for querying the type of MetaWindow. http://bugzilla.gnome.org/show_bug.cgi?id=588230
2009-08-04 07:06:30 +00:00
case PROP_WINDOW_TYPE:
g_value_set_enum (value, win->type);
break;
[MetaWindow] Make user-time a GObject property Notification of changes are useful for code ordering windows.
2009-08-31 16:06:53 +00:00
case PROP_USER_TIME:
g_value_set_uint (value, win->net_wm_user_time);
break;
[MetaWindow] Added boolean demands-attention property https://bugzilla.gnome.org/show_bug.cgi?id=588065
2009-11-17 10:02:06 +00:00
case PROP_DEMANDS_ATTENTION:
g_value_set_boolean (value, win->wm_state_demands_attention);
break;
[MetaWindow] added urgent property Property tracking ICCCM urgency hint https://bugzilla.gnome.org/show_bug.cgi?id=600068
2009-11-20 08:51:19 +00:00
case PROP_URGENT:
window: Rename wm_hints_urgent to urgent The flag and setter is now decoupled from the WM_HINTS state.
2014-03-18 17:53:42 +00:00
g_value_set_boolean (value, win->urgent);
[MetaWindow] added urgent property Property tracking ICCCM urgency hint https://bugzilla.gnome.org/show_bug.cgi?id=600068
2009-11-20 08:51:19 +00:00
break;
window: Add "skip-taskbar" property We currently only have a method to query the skip-taskbar hint. Add a corresponding property to allow listening for change notifications. https://bugzilla.gnome.org/show_bug.cgi?id=723307
2014-01-30 21:39:54 +00:00
case PROP_SKIP_TASKBAR:
g_value_set_boolean (value, win->skip_taskbar);
break;
_MUTTER_HINTS A per-window _MUTTER_HINTS property allowing plugins to use custom hints. The property holds a colon separated list of key=value pairs; plugin-specific keys must be suitably namespaced, while 'mutter-' prefix is reserved for internal Mutter use only. This commit adds MetaWindow::mutter-hints property, and meta_window_get_mutter_hints() accessor, as well as the internal machinery for reading and updating of the hints. https://bugzilla.gnome.org/show_bug.cgi?id=613123
2010-01-18 10:12:17 +00:00
case PROP_MUTTER_HINTS:
g_value_set_string (value, win->mutter_hints);
break;
window: add an appears-focused property, redraw shadows when it changes We need to redraw a window's shadow any time the value of meta_window_appears_focused() changes. So make that into a property so we can get notifications on it. https://bugzilla.gnome.org/show_bug.cgi?id=636904
2011-03-25 01:36:47 +00:00
case PROP_APPEARS_FOCUSED:
g_value_set_boolean (value, meta_window_appears_focused (win));
break;
window: Add wm-class property and notify it when changed. https://bugzilla.gnome.org/show_bug.cgi?id=649315
2011-03-03 09:01:04 +00:00
case PROP_WM_CLASS:
g_value_set_string (value, win->res_class);
break;
MetaWindow: Add :resizable and :above properties Allow libmutter users to treat windows different based on these attributes and to watch for changes. https://bugzilla.gnome.org/show_bug.cgi?id=653858
2011-07-02 11:08:17 +00:00
case PROP_RESIZEABLE:
g_value_set_boolean (value, win->has_resize_func);
break;
case PROP_ABOVE:
g_value_set_boolean (value, win->wm_state_above);
break;
adjust to new Gtk properties for app menu https://bugzilla.gnome.org/show_bug.cgi?id=668118
2012-01-17 18:27:10 +00:00
case PROP_GTK_APPLICATION_ID:
g_value_set_string (value, win->gtk_application_id);
Load _DBUS_APPLICATION_ID property, expose it via API This is used to associate GtkApplication -> X window, and will be consumed by gnome-shell. https://bugzilla.gnome.org/show_bug.cgi?id=664851
2011-11-25 23:42:41 +00:00
break;
adjust to new Gtk properties for app menu https://bugzilla.gnome.org/show_bug.cgi?id=668118
2012-01-17 18:27:10 +00:00
case PROP_GTK_UNIQUE_BUS_NAME:
g_value_set_string (value, win->gtk_unique_bus_name);
Add _DBUS_UNIQUE_NAME and _OBJECT_PATH properties https://bugzilla.gnome.org/show_bug.cgi?id=664851
2011-12-05 17:52:35 +00:00
break;
adjust to new Gtk properties for app menu https://bugzilla.gnome.org/show_bug.cgi?id=668118
2012-01-17 18:27:10 +00:00
case PROP_GTK_APPLICATION_OBJECT_PATH:
g_value_set_string (value, win->gtk_application_object_path);
break;
case PROP_GTK_WINDOW_OBJECT_PATH:
g_value_set_string (value, win->gtk_window_object_path);
break;
case PROP_GTK_APP_MENU_OBJECT_PATH:
g_value_set_string (value, win->gtk_app_menu_object_path);
break;
case PROP_GTK_MENUBAR_OBJECT_PATH:
g_value_set_string (value, win->gtk_menubar_object_path);
Add _DBUS_UNIQUE_NAME and _OBJECT_PATH properties https://bugzilla.gnome.org/show_bug.cgi?id=664851
2011-12-05 17:52:35 +00:00
break;
window: Add a property for on_all_workspaces Some plugins and extensions want to be able to know when the sticky field of a window changes, so add a property for it and allow them to connect to the notify::on-all-workspaces signal.
2014-06-24 20:05:36 +00:00
case PROP_ON_ALL_WORKSPACES:
g_value_set_boolean (value, win->on_all_workspaces);
break;
Add gproperties to MetaWindow: "title", "icon", "mini-icon" We need these properties to do things outside of the frame, without dropping to libwnck. http://bugzilla.gnome.org/show_bug.cgi?id=563405
2008-12-06 01:03:27 +00:00
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
break;
Add gproperties to MetaWindow: "title", "icon", "mini-icon" We need these properties to do things outside of the frame, without dropping to libwnck. http://bugzilla.gnome.org/show_bug.cgi?id=563405
2008-12-06 01:03:27 +00:00
}
}
static void
meta_window_set_property(GObject *object,
guint prop_id,
const GValue *value,
GParamSpec *pspec)
{
switch (prop_id)
{
default:
G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
break;
Add gproperties to MetaWindow: "title", "icon", "mini-icon" We need these properties to do things outside of the frame, without dropping to libwnck. http://bugzilla.gnome.org/show_bug.cgi?id=563405
2008-12-06 01:03:27 +00:00
}
}
Make MetaWindow a GObject Make MetaWindow into a GObject so that it is accessible to gobject-introspection (also allows for signals to be added.) Renames: meta_window_free() => meta_window_unmanage() meta_window_get_type() => meta_window_get_window_type() meta_window_get_type_atom() => meta_window_get_window_type_atom()
2008-11-07 09:57:00 +00:00
static void
meta_window_class_init (MetaWindowClass *klass)
{
GObjectClass *object_class = G_OBJECT_CLASS (klass);
object_class->finalize = meta_window_finalize;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Add gproperties to MetaWindow: "title", "icon", "mini-icon" We need these properties to do things outside of the frame, without dropping to libwnck. http://bugzilla.gnome.org/show_bug.cgi?id=563405
2008-12-06 01:03:27 +00:00
object_class->get_property = meta_window_get_property;
object_class->set_property = meta_window_set_property;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window: Turn grab_op_begin / grab_op_ended into vfuncs And move the grab_resize_popup management to the X11 window class, as this is only used under X11.
2014-04-29 19:55:55 +00:00
klass->grab_op_began = meta_window_real_grab_op_began;
klass->grab_op_ended = meta_window_real_grab_op_ended;
window: Move _NET_WM_DESKTOP setting to window-x11
2014-05-20 19:46:21 +00:00
klass->current_workspace_changed = meta_window_real_current_workspace_changed;
window: Move X11 struts implementation to X11 codepath
2014-04-28 21:06:38 +00:00
klass->update_struts = meta_window_real_update_struts;
Start splitting the X11-specific stuff of MetaWindow out into a subclass This is fairly simple and basic for now, with just skip_taskbar / skip_pager, but eventually a lot of "WM policy" like this, including move-resize, will be in subclasses for each individual surface.
2014-03-18 15:20:22 +00:00
klass->get_default_skip_hints = meta_window_real_get_default_skip_hints;
window: Move X11-specific icon code to MetaWindowX11
2014-07-14 16:01:22 +00:00
klass->update_icon = meta_window_real_update_icon;
window: Add get_client_pid() method It is often useful to identify the client process that created a particular window, however the existing meta_window_get_pid() method relies on _NET_WM_PID, which is only available on X11 and depends on applications to set it correctly (which may not even be possible when the app runs in its own PID namespace as Flatpak apps do). So add a get_client_pid() method that uses windowing system facilities to resolve the PID associated with a particular window. https://bugzilla.gnome.org/show_bug.cgi?id=772613
2016-10-07 15:55:32 +00:00
klass->get_client_pid = meta_window_real_get_client_pid;
Start splitting the X11-specific stuff of MetaWindow out into a subclass This is fairly simple and basic for now, with just skip_taskbar / skip_pager, but eventually a lot of "WM policy" like this, including move-resize, will be in subclasses for each individual surface.
2014-03-18 15:20:22 +00:00
window: Use g_object_class_install_properties
2014-06-24 20:18:26 +00:00
obj_props[PROP_TITLE] =
g_param_spec_string ("title",
"Title",
"The title of the window",
NULL,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_ICON] =
MetaWindow: Change icon properties to be of pointer type Follow up to commit af7f51b992b20da543312fa9fdf1dcef39704b37 . https://bugzilla.gnome.org/show_bug.cgi?id=742824
2015-01-12 20:23:42 +00:00
g_param_spec_pointer ("icon",
"Icon",
theme: Fix icon scaling When painting the titlebar, button icons that aren't available in the desired size need to be scaled. However the current code inverses the scale factor, with the result that the adjusted icons are much worse than the original icons, whoops. This went unnoticed for a long time given that most icons are availa- ble in the desired 16x16 size, and the most likely exceptions - window icons - are not shown by default. https://gitlab.gnome.org/GNOME/mutter/issues/23
2018-03-01 16:08:41 +00:00
"Normal icon, usually 96x96 pixels",
MetaWindow: Change icon properties to be of pointer type Follow up to commit af7f51b992b20da543312fa9fdf1dcef39704b37 . https://bugzilla.gnome.org/show_bug.cgi?id=742824
2015-01-12 20:23:42 +00:00
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
window: Use g_object_class_install_properties
2014-06-24 20:18:26 +00:00
obj_props[PROP_MINI_ICON] =
MetaWindow: Change icon properties to be of pointer type Follow up to commit af7f51b992b20da543312fa9fdf1dcef39704b37 . https://bugzilla.gnome.org/show_bug.cgi?id=742824
2015-01-12 20:23:42 +00:00
g_param_spec_pointer ("mini-icon",
"Mini Icon",
theme: Fix icon scaling When painting the titlebar, button icons that aren't available in the desired size need to be scaled. However the current code inverses the scale factor, with the result that the adjusted icons are much worse than the original icons, whoops. This went unnoticed for a long time given that most icons are availa- ble in the desired 16x16 size, and the most likely exceptions - window icons - are not shown by default. https://gitlab.gnome.org/GNOME/mutter/issues/23
2018-03-01 16:08:41 +00:00
"Mini icon, usually 16x16 pixels",
MetaWindow: Change icon properties to be of pointer type Follow up to commit af7f51b992b20da543312fa9fdf1dcef39704b37 . https://bugzilla.gnome.org/show_bug.cgi?id=742824
2015-01-12 20:23:42 +00:00
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
window: Use g_object_class_install_properties
2014-06-24 20:18:26 +00:00
obj_props[PROP_DECORATED] =
g_param_spec_boolean ("decorated",
"Decorated",
"Whether window is decorated",
TRUE,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_FULLSCREEN] =
g_param_spec_boolean ("fullscreen",
"Fullscreen",
"Whether window is fullscreened",
FALSE,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_MAXIMIZED_HORIZONTALLY] =
g_param_spec_boolean ("maximized-horizontally",
"Maximized horizontally",
"Whether window is maximized horizontally",
FALSE,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_MAXIMIZED_VERTICALLY] =
g_param_spec_boolean ("maximized-vertically",
"Maximizing vertically",
"Whether window is maximized vertically",
FALSE,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_MINIMIZED] =
g_param_spec_boolean ("minimized",
"Minimizing",
"Whether window is minimized",
FALSE,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_WINDOW_TYPE] =
g_param_spec_enum ("window-type",
"Window Type",
"The type of the window",
META_TYPE_WINDOW_TYPE,
META_WINDOW_NORMAL,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_USER_TIME] =
g_param_spec_uint ("user-time",
"User time",
"Timestamp of last user interaction",
0,
G_MAXUINT,
0,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_DEMANDS_ATTENTION] =
g_param_spec_boolean ("demands-attention",
"Demands Attention",
"Whether the window has _NET_WM_STATE_DEMANDS_ATTENTION set",
FALSE,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_URGENT] =
g_param_spec_boolean ("urgent",
"Urgent",
"Whether the urgent flag of WM_HINTS is set",
FALSE,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_SKIP_TASKBAR] =
g_param_spec_boolean ("skip-taskbar",
"Skip taskbar",
"Whether the skip-taskbar flag of WM_HINTS is set",
FALSE,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_MUTTER_HINTS] =
g_param_spec_string ("mutter-hints",
"_MUTTER_HINTS",
"Contents of the _MUTTER_HINTS property of this window",
NULL,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_APPEARS_FOCUSED] =
g_param_spec_boolean ("appears-focused",
"Appears focused",
"Whether the window is drawn as being focused",
FALSE,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_RESIZEABLE] =
g_param_spec_boolean ("resizeable",
"Resizeable",
"Whether the window can be resized",
FALSE,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_ABOVE] =
g_param_spec_boolean ("above",
"Above",
"Whether the window is shown as always-on-top",
FALSE,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_WM_CLASS] =
g_param_spec_string ("wm-class",
"WM_CLASS",
"Contents of the WM_CLASS property of this window",
NULL,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_GTK_APPLICATION_ID] =
g_param_spec_string ("gtk-application-id",
"_GTK_APPLICATION_ID",
"Contents of the _GTK_APPLICATION_ID property of this window",
NULL,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_GTK_UNIQUE_BUS_NAME] =
g_param_spec_string ("gtk-unique-bus-name",
"_GTK_UNIQUE_BUS_NAME",
"Contents of the _GTK_UNIQUE_BUS_NAME property of this window",
NULL,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_GTK_APPLICATION_OBJECT_PATH] =
g_param_spec_string ("gtk-application-object-path",
"_GTK_APPLICATION_OBJECT_PATH",
"Contents of the _GTK_APPLICATION_OBJECT_PATH property of this window",
NULL,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_GTK_WINDOW_OBJECT_PATH] =
g_param_spec_string ("gtk-window-object-path",
"_GTK_WINDOW_OBJECT_PATH",
"Contents of the _GTK_WINDOW_OBJECT_PATH property of this window",
NULL,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_GTK_APP_MENU_OBJECT_PATH] =
g_param_spec_string ("gtk-app-menu-object-path",
"_GTK_APP_MENU_OBJECT_PATH",
"Contents of the _GTK_APP_MENU_OBJECT_PATH property of this window",
NULL,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_GTK_MENUBAR_OBJECT_PATH] =
g_param_spec_string ("gtk-menubar-object-path",
"_GTK_MENUBAR_OBJECT_PATH",
"Contents of the _GTK_MENUBAR_OBJECT_PATH property of this window",
NULL,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
obj_props[PROP_ON_ALL_WORKSPACES] =
g_param_spec_boolean ("on-all-workspaces",
"On all workspaces",
"Whether the window is set to appear on all workspaces",
FALSE,
G_PARAM_READABLE | G_PARAM_STATIC_STRINGS);
Change naming of GParmSpec enum id string for naming consistency GParamSpec enum string usually follows "PROP_" prefix and PROP_LAST is used for last PROP string. https://gitlab.gnome.org/GNOME/mutter/issues/28 Closes: #28
2018-02-10 12:36:48 +00:00
g_object_class_install_properties (object_class, PROP_LAST, obj_props);
window: Add a property for on_all_workspaces Some plugins and extensions want to be able to know when the sticky field of a window changes, so add a property for it and allow them to connect to the notify::on-all-workspaces signal.
2014-06-24 20:05:36 +00:00
MetaWindow::workspace-changed signal. Emitted when window is moved from one workspace to another; the number of the old workspace is passed to the signal handlers.
2009-01-20 12:52:06 +00:00
window_signals[WORKSPACE_CHANGED] =
g_signal_new ("workspace-changed",
G_TYPE_FROM_CLASS (object_class),
G_SIGNAL_RUN_LAST,
window: Remove vfunc slots for signals These aren't used currently, and we're going to be adding more vfuncs.
2014-03-18 15:21:02 +00:00
0,
Use generic marshaller https://bugzilla.gnome.org/show_bug.cgi?id=662153
2011-10-18 22:06:14 +00:00
NULL, NULL, NULL,
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
G_TYPE_NONE, 0);
MetaWindow::focus signal.
2009-02-02 11:00:13 +00:00
window_signals[FOCUS] =
g_signal_new ("focus",
G_TYPE_FROM_CLASS (object_class),
G_SIGNAL_RUN_LAST,
window: Remove vfunc slots for signals These aren't used currently, and we're going to be adding more vfuncs.
2014-03-18 15:21:02 +00:00
0,
Use generic marshaller https://bugzilla.gnome.org/show_bug.cgi?id=662153
2011-10-18 22:06:14 +00:00
NULL, NULL, NULL,
MetaWindow::focus signal.
2009-02-02 11:00:13 +00:00
G_TYPE_NONE, 0);
MetaWindow::raised signal.
2009-02-02 14:08:46 +00:00
window_signals[RAISED] =
g_signal_new ("raised",
G_TYPE_FROM_CLASS (object_class),
G_SIGNAL_RUN_LAST,
window: Remove vfunc slots for signals These aren't used currently, and we're going to be adding more vfuncs.
2014-03-18 15:21:02 +00:00
0,
Use generic marshaller https://bugzilla.gnome.org/show_bug.cgi?id=662153
2011-10-18 22:06:14 +00:00
NULL, NULL, NULL,
MetaWindow::raised signal.
2009-02-02 14:08:46 +00:00
G_TYPE_NONE, 0);
Add "window-created" signal to MetaDisplay, "unmanaged" signal for MetaWindow For some consumers it's significantly more convenient to be able to directly connect to a signal on the Window to know when Mutter is done with it, rather than having to connect to each Workspace object (and handle workspace additions, etc.). Similarly, add window-created which acts globally. https://bugzilla.gnome.org/show_bug.cgi?id=598289
2009-10-13 14:34:34 +00:00
wayland: Move MetaWindow ownership to window owning roles There are two surface roles owning a MetaWindow: MetaWaylandShellSurface (basis of MetaWaylandXdgToplevel, MetaWaylandXdgPopup, MetaWaylandWlShellSurface, etc), and MetaXwaylandSurface. With these two role types, the MetaWindow has two different types of life times. With MetaWaylandShellSurface, the window is owned and managed by the role itself, while with MetaXwaylandSurface, the MetaWindow is tied to the X11 window, while the Wayland surface and its role plays more the role of the backing rendering surface. Before, for historical reasons, MetaWindow was part of MetaWaylandSurface, even though just some roles used it, and before 'wayland: Untie MetaWindowXwayland lifetime from the wl_surface' had equivalent life times as well. But since that commit, the management changed. To not have the same fied in MetaWaylandSurface being managed in such drastically different ways, rearrange it so that the roles that has a MetaWindow themself manages it in the way it is meant to; meaning MetaWaylandShellSurface practically owns it, while with Xwayland, the existance of a MetaWindow is tracked via X11. https://gitlab.gnome.org/GNOME/mutter/merge_requests/835
2019-10-09 07:57:40 +00:00
window_signals[UNMANAGING] =
g_signal_new ("unmanaging",
G_TYPE_FROM_CLASS (object_class),
G_SIGNAL_RUN_LAST,
0,
NULL, NULL, NULL,
G_TYPE_NONE, 0);
Add "window-created" signal to MetaDisplay, "unmanaged" signal for MetaWindow For some consumers it's significantly more convenient to be able to directly connect to a signal on the Window to know when Mutter is done with it, rather than having to connect to each Workspace object (and handle workspace additions, etc.). Similarly, add window-created which acts globally. https://bugzilla.gnome.org/show_bug.cgi?id=598289
2009-10-13 14:34:34 +00:00
window_signals[UNMANAGED] =
g_signal_new ("unmanaged",
G_TYPE_FROM_CLASS (object_class),
G_SIGNAL_RUN_LAST,
window: Remove vfunc slots for signals These aren't used currently, and we're going to be adding more vfuncs.
2014-03-18 15:21:02 +00:00
0,
Use generic marshaller https://bugzilla.gnome.org/show_bug.cgi?id=662153
2011-10-18 22:06:14 +00:00
NULL, NULL, NULL,
Add "window-created" signal to MetaDisplay, "unmanaged" signal for MetaWindow For some consumers it's significantly more convenient to be able to directly connect to a signal on the Window to know when Mutter is done with it, rather than having to connect to each Workspace object (and handle workspace additions, etc.). Similarly, add window-created which acts globally. https://bugzilla.gnome.org/show_bug.cgi?id=598289
2009-10-13 14:34:34 +00:00
G_TYPE_NONE, 0);
Move position-changed / size-changed signals to the MetaWindow They fit more appropriately over here... https://bugzilla.gnome.org/show_bug.cgi?id=720631
2013-12-06 20:39:24 +00:00
/**
* MetaWindow::position-changed:
* @window: a #MetaWindow
*
* This is emitted when the position of a window might
* have changed. Specifically, this is emitted when the
* position of the toplevel window has changed, or when
* the position of the client window has changed.
*/
window_signals[POSITION_CHANGED] =
g_signal_new ("position-changed",
G_TYPE_FROM_CLASS (object_class),
G_SIGNAL_RUN_LAST,
0,
NULL, NULL, NULL,
G_TYPE_NONE, 0);
tests: Move window-shown verification to test-runner Previously we relied on the test-client to make sure that a window was shown. For X11, we did not need to do anything, but for Wayland we had to make sure we had drawn the first frame, otherwise mutter wouldn't have a buffer making the window not showable. Doing it this way doesn't work anymore however, since the 'after-paint' event will be emitted even if we didn't actually paint anything. This is the case with current Gtk under Wayland, where we won't draw until the compositor has configured the surface. In effect, this mean we'll get a dummy after-paint emission before the first frame is actually painted. Instead, move the verification that a "show" command has completed by having the test-runner wait for a "shown" signal on the window, which is emitted in the end of meta_window_show(). This requires an additional call to gdk_display_sync() in the test-client after creating the window, to make sure that the window creation vents has been received in the compositor.
2018-07-12 08:25:16 +00:00
/**
* MetaWindow::shown:
* @window: a #MetaWindow
*
* This is emitted after a window has been shown.
*/
window_signals[SHOWN] =
g_signal_new ("shown",
G_TYPE_FROM_CLASS (object_class),
G_SIGNAL_RUN_LAST,
0,
NULL, NULL, NULL,
G_TYPE_NONE, 0);
Move position-changed / size-changed signals to the MetaWindow They fit more appropriately over here... https://bugzilla.gnome.org/show_bug.cgi?id=720631
2013-12-06 20:39:24 +00:00
/**
* MetaWindow::size-changed:
* @window: a #MetaWindow
*
core/window: Fix copy/paste error in size-changed docs It appears it was copied from MetaWindow::position-changed and pasted for MetaWindow::size-changed, without updating all the words. https://gitlab.gnome.org/GNOME/mutter/merge_requests/567
2019-05-07 09:42:13 +00:00
* This is emitted when the size of a window might
Move position-changed / size-changed signals to the MetaWindow They fit more appropriately over here... https://bugzilla.gnome.org/show_bug.cgi?id=720631
2013-12-06 20:39:24 +00:00
* have changed. Specifically, this is emitted when the
* size of the toplevel window has changed, or when the
* size of the client window has changed.
*/
window_signals[SIZE_CHANGED] =
g_signal_new ("size-changed",
G_TYPE_FROM_CLASS (object_class),
G_SIGNAL_RUN_LAST,
0,
NULL, NULL, NULL,
G_TYPE_NONE, 0);
Make MetaWindow a GObject Make MetaWindow into a GObject so that it is accessible to gobject-introspection (also allows for signals to be added.) Renames: meta_window_free() => meta_window_unmanage() meta_window_get_type() => meta_window_get_window_type() meta_window_get_type_atom() => meta_window_get_window_type_atom()
2008-11-07 09:57:00 +00:00
}
static void
meta_window_init (MetaWindow *self)
{
Replace MetaStackWindow with a 64-bit "stack ID" Putting X windows and pointers to MetaWindows into a union had a number of problems: - It caused awkward initialization and conditionalization - There was no way to refer to Wayland windows (represented by MetaWindow *) in the past, which is necessary for the MetaStackTracker algorithms - We never even cleaned up old MetaStackWindow so there could be records in MetaStackWindow pointing to freed MetaWindow. Replace MetaStackWindow with a 64-bit "stack ID" which is: - The XID for X Windows - a "window stamp" for Wayland windows - window stamps are assigned for all MetaWindow and are unique across the life of the process. https://bugzilla.gnome.org/show_bug.cgi?id=736559
2014-09-09 01:20:14 +00:00
self->stamp = next_window_stamp++;
window: Listen for pref changes The workspaces-only-on-primary preference changes how windows are displayed, so listen for pref changes and update the visibility accordingly. https://bugzilla.gnome.org/show_bug.cgi?id=664853
2011-11-26 00:52:24 +00:00
meta_prefs_add_listener (prefs_changed_callback, self);
Make MetaWindow a GObject Make MetaWindow into a GObject so that it is accessible to gobject-introspection (also allows for signals to be added.) Renames: meta_window_free() => meta_window_unmanage() meta_window_get_type() => meta_window_get_window_type() meta_window_get_type_atom() => meta_window_get_window_type_atom()
2008-11-07 09:57:00 +00:00
}
fill in window->desc sooner since we use it sooner now. 2003-05-16 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new): fill in window->desc sooner since we use it sooner now. * src/display.c (meta_display_open): init display->grab_update_alarm * src/window.c (meta_window_new): initialize the always_sticky field (meta_window_new): initialize the update_icon_queued field Patch from Julien Olivier bug #92335 for converting "show desktop mode" to "all windows are minimized" when you open a new window, instead of just mapping all the windows again. * src/window.c (meta_window_activate): minimize all windows before coming out of show desktop mode. (meta_window_unminimize): don't toggle show desktop mode here * src/screen.c (meta_screen_minimize_all_except): new function
2003-05-16 21:59:08 +00:00
static gboolean
is_desktop_or_dock_foreach (MetaWindow *window,
void *data)
{
gboolean *result = data;
*result =
window->type == META_WINDOW_DESKTOP ||
window->type == META_WINDOW_DOCK;
if (*result)
return FALSE; /* stop as soon as we find one */
else
return TRUE;
}
/* window is the window that's newly mapped provoking
* the possible change
*/
static void
maybe_leave_show_desktop_mode (MetaWindow *window)
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
fill in window->desc sooner since we use it sooner now. 2003-05-16 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new): fill in window->desc sooner since we use it sooner now. * src/display.c (meta_display_open): init display->grab_update_alarm * src/window.c (meta_window_new): initialize the always_sticky field (meta_window_new): initialize the update_icon_queued field Patch from Julien Olivier bug #92335 for converting "show desktop mode" to "all windows are minimized" when you open a new window, instead of just mapping all the windows again. * src/window.c (meta_window_activate): minimize all windows before coming out of show desktop mode. (meta_window_unminimize): don't toggle show desktop mode here * src/screen.c (meta_screen_minimize_all_except): new function
2003-05-16 21:59:08 +00:00
gboolean is_desktop_or_dock;
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
if (!workspace_manager->active_workspace->showing_desktop)
fill in window->desc sooner since we use it sooner now. 2003-05-16 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new): fill in window->desc sooner since we use it sooner now. * src/display.c (meta_display_open): init display->grab_update_alarm * src/window.c (meta_window_new): initialize the always_sticky field (meta_window_new): initialize the update_icon_queued field Patch from Julien Olivier bug #92335 for converting "show desktop mode" to "all windows are minimized" when you open a new window, instead of just mapping all the windows again. * src/window.c (meta_window_activate): minimize all windows before coming out of show desktop mode. (meta_window_unminimize): don't toggle show desktop mode here * src/screen.c (meta_screen_minimize_all_except): new function
2003-05-16 21:59:08 +00:00
return;
/* If the window is a transient for the dock or desktop, don't
* leave show desktop mode when the window opens. That's
* so you can e.g. hide all windows, manipulate a file on
* the desktop via a dialog, then unshow windows again.
*/
is_desktop_or_dock = FALSE;
revert broken change that assumed foreach_ancestor iterated over the 2003-05-18 Havoc Pennington <hp@pobox.com> * src/window.c (unminimize_window_and_all_transient_parents): revert broken change that assumed foreach_ancestor iterated over the window itself. Andrew Sobala, Rob Adams, #113232 `
2003-05-18 17:16:03 +00:00
is_desktop_or_dock_foreach (window,
&is_desktop_or_dock);
fill in window->desc sooner since we use it sooner now. 2003-05-16 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new): fill in window->desc sooner since we use it sooner now. * src/display.c (meta_display_open): init display->grab_update_alarm * src/window.c (meta_window_new): initialize the always_sticky field (meta_window_new): initialize the update_icon_queued field Patch from Julien Olivier bug #92335 for converting "show desktop mode" to "all windows are minimized" when you open a new window, instead of just mapping all the windows again. * src/window.c (meta_window_activate): minimize all windows before coming out of show desktop mode. (meta_window_unminimize): don't toggle show desktop mode here * src/screen.c (meta_screen_minimize_all_except): new function
2003-05-16 21:59:08 +00:00
meta_window_foreach_ancestor (window, is_desktop_or_dock_foreach,
&is_desktop_or_dock);
if (!is_desktop_or_dock)
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
meta_workspace_manager_minimize_all_on_active_workspace_except (workspace_manager,
window);
meta_workspace_manager_unshow_desktop (workspace_manager);
fill in window->desc sooner since we use it sooner now. 2003-05-16 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new): fill in window->desc sooner since we use it sooner now. * src/display.c (meta_display_open): init display->grab_update_alarm * src/window.c (meta_window_new): initialize the always_sticky field (meta_window_new): initialize the update_icon_queued field Patch from Julien Olivier bug #92335 for converting "show desktop mode" to "all windows are minimized" when you open a new window, instead of just mapping all the windows again. * src/window.c (meta_window_activate): minimize all windows before coming out of show desktop mode. (meta_window_unminimize): don't toggle show desktop mode here * src/screen.c (meta_screen_minimize_all_except): new function
2003-05-16 21:59:08 +00:00
}
}
window: make determination of attached dialog windows more consistent Different bits of code were using slightly different checks to test whether a window was an attached dialog. Add a new meta_window_is_attached_dialog(), and use that everywhere. Also, freeze the is-attached status when the window is first shown, rather than recomputing it each time the caller asks, since this could cause problems if a window changes its type after it has already been attached, etc. However, if an attached window's parent is destroyed, or an attached window changes its transient-for, then fix things up by destroying the old MetaWindow and creating a new one (causing compositor unmap and map events to be fired off, allowing the display of the window to be fixed up). Remove some code in display.c that tried to fix existing windows if the gconf setting changed, but which didn't actually do anything (at least under gnome-shell). However, if 654643 was fixed then the new behavior with this patch would be that changing the gconf setting would affect new dialogs, but not existing ones. https://bugzilla.gnome.org/show_bug.cgi?id=646761
2011-04-05 14:14:52 +00:00
gboolean
meta_window_should_attach_to_parent (MetaWindow *window)
{
MetaWindow *parent;
if (!meta_prefs_get_attach_modal_dialogs () ||
window->type != META_WINDOW_MODAL_DIALOG)
return FALSE;
parent = meta_window_get_transient_for (window);
if (!parent)
return FALSE;
window: only attach dialogs to NORMAL, DIALOG, and MODAL_DIALOG windows Attaching dialogs to unusual windows (like the desktop) looks bad, so don't do it. https://bugzilla.gnome.org/show_bug.cgi?id=646761
2011-07-22 16:34:10 +00:00
switch (parent->type)
{
case META_WINDOW_NORMAL:
case META_WINDOW_DIALOG:
case META_WINDOW_MODAL_DIALOG:
return TRUE;
default:
return FALSE;
}
window: make determination of attached dialog windows more consistent Different bits of code were using slightly different checks to test whether a window was an attached dialog. Add a new meta_window_is_attached_dialog(), and use that everywhere. Also, freeze the is-attached status when the window is first shown, rather than recomputing it each time the caller asks, since this could cause problems if a window changes its type after it has already been attached, etc. However, if an attached window's parent is destroyed, or an attached window changes its transient-for, then fix things up by destroying the old MetaWindow and creating a new one (causing compositor unmap and map events to be fired off, allowing the display of the window to be fixed up). Remove some code in display.c that tried to fix existing windows if the gconf setting changed, but which didn't actually do anything (at least under gnome-shell). However, if 654643 was fixed then the new behavior with this patch would be that changing the gconf setting would affect new dialogs, but not existing ones. https://bugzilla.gnome.org/show_bug.cgi?id=646761
2011-04-05 14:14:52 +00:00
}
Always map the client and frame windows Traditionally, WMs unmap windows when minimizing them, and map them when restoring them or wanting to show them for other reasons, like upon creation. However, as metacity morphed into mutter, we optionally chose to keep windows mapped for the lifetime of the window under the user option "live-window-previews", which makes the code keep windows mapped so it can show window preview for minimized windows in other places, like Alt-Tab and Expose. I removed this preference two years ago mechanically, by removing all the if statements, but never went through and cleaned up the code so that windows are simply mapped for the lifetime of the window -- the "architecture" of the old code that maps and unmaps on show/hide was still there. Remove this now. The one case we still need to be careful of is shaded windows, in which we do still unmap the client window. In the future, we might want to show previews of shaded windows in the overview and Alt-Tab. In that we'd also keep shaded windows mapped, and could remove all unmap logic, but we'd need a more complex method of showing the shaded titlebar, such as using a different actor. At the same time, simplify the compositor interface by removing meta_compositor_window_[un]mapped API, and instead adding/removing the window on-demand. https://bugzilla.gnome.org/show_bug.cgi?id=720631
2014-02-02 00:06:51 +00:00
static gboolean
client_window_should_be_mapped (MetaWindow *window)
{
build: Fix non-wayland build This fixes error introduced in 09120132ef87061d527b5324a14ab5950db3dc0a. https://bugzilla.gnome.org/show_bug.cgi?id=750552
2015-06-17 10:37:20 +00:00
#ifdef HAVE_WAYLAND
core: Refrain from showing wayland windows when we don't have a buffer yet The "calc showing" operation is queued in a few places alongside MetaWindow creation, we should be ignoring these until there is a buffer to show. https://bugzilla.gnome.org/show_bug.cgi?id=750552
2015-06-08 09:55:54 +00:00
if (window->client_type == META_WINDOW_CLIENT_TYPE_WAYLAND &&
wayland: Move buffer use count to MetaWaylandSurface Each wl_surface.commit with a newly attached buffer should result in one wl_buffer.release for the attached buffer. For example attaching the same buffer to two different surfaces must always result in two wl_buffer.release events being emitted by the server. The client is responsible for counting the wl_buffer.release events and be sure to have received as many release events as it has attached and committed the buffer, before reusing it. https://bugzilla.gnome.org/show_bug.cgi?id=762828
2016-03-16 06:47:53 +00:00
!meta_wayland_surface_get_buffer (window->surface))
core: Refrain from showing wayland windows when we don't have a buffer yet The "calc showing" operation is queued in a few places alongside MetaWindow creation, we should be ignoring these until there is a buffer to show. https://bugzilla.gnome.org/show_bug.cgi?id=750552
2015-06-08 09:55:54 +00:00
return FALSE;
build: Fix non-wayland build This fixes error introduced in 09120132ef87061d527b5324a14ab5950db3dc0a. https://bugzilla.gnome.org/show_bug.cgi?id=750552
2015-06-17 10:37:20 +00:00
#endif
core: Refrain from showing wayland windows when we don't have a buffer yet The "calc showing" operation is queued in a few places alongside MetaWindow creation, we should be ignoring these until there is a buffer to show. https://bugzilla.gnome.org/show_bug.cgi?id=750552
2015-06-08 09:55:54 +00:00
Always map the client and frame windows Traditionally, WMs unmap windows when minimizing them, and map them when restoring them or wanting to show them for other reasons, like upon creation. However, as metacity morphed into mutter, we optionally chose to keep windows mapped for the lifetime of the window under the user option "live-window-previews", which makes the code keep windows mapped so it can show window preview for minimized windows in other places, like Alt-Tab and Expose. I removed this preference two years ago mechanically, by removing all the if statements, but never went through and cleaned up the code so that windows are simply mapped for the lifetime of the window -- the "architecture" of the old code that maps and unmaps on show/hide was still there. Remove this now. The one case we still need to be careful of is shaded windows, in which we do still unmap the client window. In the future, we might want to show previews of shaded windows in the overview and Alt-Tab. In that we'd also keep shaded windows mapped, and could remove all unmap logic, but we'd need a more complex method of showing the shaded titlebar, such as using a different actor. At the same time, simplify the compositor interface by removing meta_compositor_window_[un]mapped API, and instead adding/removing the window on-demand. https://bugzilla.gnome.org/show_bug.cgi?id=720631
2014-02-02 00:06:51 +00:00
return !window->shaded;
}
static void
sync_client_window_mapped (MetaWindow *window)
{
gboolean should_be_mapped = client_window_should_be_mapped (window);
window: Don't try to map / unmap OR windows by ourselves This is bad behavior, and can also cause us to get in an infinite loop if an OR window is mapped and unmapped in quick succession. This sequence causes a MapNotify followed by an UnmapNotify, and when processing the events, we'll call XMapWindow, XUnmapWindow, which will put another set of MapNotify, UnmapNotify events in our queue, which we then process by calling XMapWindow, XUnmapWindow, and so it goes forever, or at least some scheduler uncorks us by making us call XMapWindow when the window is already mapped, or XUnmapWindow when the window is already unmapped. We can stop this madness by simply making sure never to call neither XMapWindow or XUnmapWindow on OR windows, which is the correct thing to do anyway.
2014-08-19 19:57:52 +00:00
g_return_if_fail (!window->override_redirect);
Always map the client and frame windows Traditionally, WMs unmap windows when minimizing them, and map them when restoring them or wanting to show them for other reasons, like upon creation. However, as metacity morphed into mutter, we optionally chose to keep windows mapped for the lifetime of the window under the user option "live-window-previews", which makes the code keep windows mapped so it can show window preview for minimized windows in other places, like Alt-Tab and Expose. I removed this preference two years ago mechanically, by removing all the if statements, but never went through and cleaned up the code so that windows are simply mapped for the lifetime of the window -- the "architecture" of the old code that maps and unmaps on show/hide was still there. Remove this now. The one case we still need to be careful of is shaded windows, in which we do still unmap the client window. In the future, we might want to show previews of shaded windows in the overview and Alt-Tab. In that we'd also keep shaded windows mapped, and could remove all unmap logic, but we'd need a more complex method of showing the shaded titlebar, such as using a different actor. At the same time, simplify the compositor interface by removing meta_compositor_window_[un]mapped API, and instead adding/removing the window on-demand. https://bugzilla.gnome.org/show_bug.cgi?id=720631
2014-02-02 00:06:51 +00:00
if (window->mapped == should_be_mapped)
return;
window->mapped = should_be_mapped;
x11: Move X11 calls to map/unmap a MetaWindow to MetaWindowX11 Add 2 vmethods so that MetaWindowX11 may handle the X11 calls itself. https://gitlab.gnome.org/GNOME/mutter/merge_requests/420
2018-12-30 12:55:52 +00:00
if (window->mapped)
META_WINDOW_GET_CLASS (window)->map (window);
Always map the client and frame windows Traditionally, WMs unmap windows when minimizing them, and map them when restoring them or wanting to show them for other reasons, like upon creation. However, as metacity morphed into mutter, we optionally chose to keep windows mapped for the lifetime of the window under the user option "live-window-previews", which makes the code keep windows mapped so it can show window preview for minimized windows in other places, like Alt-Tab and Expose. I removed this preference two years ago mechanically, by removing all the if statements, but never went through and cleaned up the code so that windows are simply mapped for the lifetime of the window -- the "architecture" of the old code that maps and unmaps on show/hide was still there. Remove this now. The one case we still need to be careful of is shaded windows, in which we do still unmap the client window. In the future, we might want to show previews of shaded windows in the overview and Alt-Tab. In that we'd also keep shaded windows mapped, and could remove all unmap logic, but we'd need a more complex method of showing the shaded titlebar, such as using a different actor. At the same time, simplify the compositor interface by removing meta_compositor_window_[un]mapped API, and instead adding/removing the window on-demand. https://bugzilla.gnome.org/show_bug.cgi?id=720631
2014-02-02 00:06:51 +00:00
else
x11: Move X11 calls to map/unmap a MetaWindow to MetaWindowX11 Add 2 vmethods so that MetaWindowX11 may handle the X11 calls itself. https://gitlab.gnome.org/GNOME/mutter/merge_requests/420
2018-12-30 12:55:52 +00:00
META_WINDOW_GET_CLASS (window)->unmap (window);
Always map the client and frame windows Traditionally, WMs unmap windows when minimizing them, and map them when restoring them or wanting to show them for other reasons, like upon creation. However, as metacity morphed into mutter, we optionally chose to keep windows mapped for the lifetime of the window under the user option "live-window-previews", which makes the code keep windows mapped so it can show window preview for minimized windows in other places, like Alt-Tab and Expose. I removed this preference two years ago mechanically, by removing all the if statements, but never went through and cleaned up the code so that windows are simply mapped for the lifetime of the window -- the "architecture" of the old code that maps and unmaps on show/hide was still there. Remove this now. The one case we still need to be careful of is shaded windows, in which we do still unmap the client window. In the future, we might want to show previews of shaded windows in the overview and Alt-Tab. In that we'd also keep shaded windows mapped, and could remove all unmap logic, but we'd need a more complex method of showing the shaded titlebar, such as using a different actor. At the same time, simplify the compositor interface by removing meta_compositor_window_[un]mapped API, and instead adding/removing the window on-demand. https://bugzilla.gnome.org/show_bug.cgi?id=720631
2014-02-02 00:06:51 +00:00
}
window: Support snap packages for sandboxed app IDs For now we abuse of meta_window_get_flatpak_id not to break the APIs, so that it's working seamlessly in gnone shell too. Rename flatpak_id to sandboxed_app_id internally to get prepared to the future API. https://bugzilla.gnome.org/show_bug.cgi?id=788217
2017-09-26 21:22:43 +00:00
static gboolean
meta_window_update_flatpak_id (MetaWindow *window,
uint32_t pid)
window: Expose Flatpak application ID GNOME Shell's window matching currently fails frequently with Flatpak applications, as one of the primary hints used to link windows with .desktop files - the WM_CLASS - no longer matches when flatpak renames the exported .desktop file. Luckily, Flatpak provides us with a fail-safe way to map from the PID to the corresponding application ID, so expose an appropriate method that allows GNOME Shell to reliably match windows to the corresponding Flatpak app. https://bugzilla.gnome.org/show_bug.cgi?id=772614
2016-10-07 15:55:32 +00:00
{
g_autoptr(GKeyFile) key_file = NULL;
g_autofree char *info_filename = NULL;
window: Support snap packages for sandboxed app IDs For now we abuse of meta_window_get_flatpak_id not to break the APIs, so that it's working seamlessly in gnone shell too. Rename flatpak_id to sandboxed_app_id internally to get prepared to the future API. https://bugzilla.gnome.org/show_bug.cgi?id=788217
2017-09-26 21:22:43 +00:00
g_return_val_if_fail (pid != 0, FALSE);
g_return_val_if_fail (window->sandboxed_app_id == NULL, FALSE);
window: Expose Flatpak application ID GNOME Shell's window matching currently fails frequently with Flatpak applications, as one of the primary hints used to link windows with .desktop files - the WM_CLASS - no longer matches when flatpak renames the exported .desktop file. Luckily, Flatpak provides us with a fail-safe way to map from the PID to the corresponding application ID, so expose an appropriate method that allows GNOME Shell to reliably match windows to the corresponding Flatpak app. https://bugzilla.gnome.org/show_bug.cgi?id=772614
2016-10-07 15:55:32 +00:00
key_file = g_key_file_new ();
info_filename = g_strdup_printf ("/proc/%u/root/.flatpak-info", pid);
if (!g_key_file_load_from_file (key_file, info_filename, G_KEY_FILE_NONE, NULL))
window: Support snap packages for sandboxed app IDs For now we abuse of meta_window_get_flatpak_id not to break the APIs, so that it's working seamlessly in gnone shell too. Rename flatpak_id to sandboxed_app_id internally to get prepared to the future API. https://bugzilla.gnome.org/show_bug.cgi?id=788217
2017-09-26 21:22:43 +00:00
return FALSE;
window->sandboxed_app_id = g_key_file_get_string (key_file, "Application", "name", NULL);
return TRUE;
}
static gboolean
meta_window_update_snap_id (MetaWindow *window,
uint32_t pid)
{
g_autofree char *security_label_filename = NULL;
g_autofree char *security_label_contents = NULL;
gsize i, security_label_contents_size = 0;
char *contents_start;
char *contents_end;
char *sandboxed_app_id;
g_return_val_if_fail (pid != 0, FALSE);
g_return_val_if_fail (window->sandboxed_app_id == NULL, FALSE);
security_label_filename = g_strdup_printf ("/proc/%u/attr/current", pid);
if (!g_file_get_contents (security_label_filename,
&security_label_contents,
&security_label_contents_size,
NULL))
return FALSE;
if (!g_str_has_prefix (security_label_contents, SNAP_SECURITY_LABEL_PREFIX))
return FALSE;
/* We need to translate the security profile into the desktop-id.
* The profile is in the form of 'snap.name-space.binary-name (current)'
* while the desktop id will be name-space_binary-name.
*/
security_label_contents_size -= sizeof (SNAP_SECURITY_LABEL_PREFIX) - 1;
contents_start = security_label_contents + sizeof (SNAP_SECURITY_LABEL_PREFIX) - 1;
contents_end = strchr (contents_start, ' ');
if (contents_end)
security_label_contents_size = contents_end - contents_start;
for (i = 0; i < security_label_contents_size; ++i)
{
if (contents_start[i] == '.')
contents_start[i] = '_';
}
sandboxed_app_id = g_malloc0 (security_label_contents_size + 1);
memcpy (sandboxed_app_id, contents_start, security_label_contents_size);
window->sandboxed_app_id = sandboxed_app_id;
return TRUE;
}
static void
meta_window_update_sandboxed_app_id (MetaWindow *window)
{
uint32_t pid;
g_clear_pointer (&window->sandboxed_app_id, g_free);
pid = meta_window_get_client_pid (window);
if (pid == 0)
window: Expose Flatpak application ID GNOME Shell's window matching currently fails frequently with Flatpak applications, as one of the primary hints used to link windows with .desktop files - the WM_CLASS - no longer matches when flatpak renames the exported .desktop file. Luckily, Flatpak provides us with a fail-safe way to map from the PID to the corresponding application ID, so expose an appropriate method that allows GNOME Shell to reliably match windows to the corresponding Flatpak app. https://bugzilla.gnome.org/show_bug.cgi?id=772614
2016-10-07 15:55:32 +00:00
return;
window: Support snap packages for sandboxed app IDs For now we abuse of meta_window_get_flatpak_id not to break the APIs, so that it's working seamlessly in gnone shell too. Rename flatpak_id to sandboxed_app_id internally to get prepared to the future API. https://bugzilla.gnome.org/show_bug.cgi?id=788217
2017-09-26 21:22:43 +00:00
if (meta_window_update_flatpak_id (window, pid))
return;
if (meta_window_update_snap_id (window, pid))
return;
window: Expose Flatpak application ID GNOME Shell's window matching currently fails frequently with Flatpak applications, as one of the primary hints used to link windows with .desktop files - the WM_CLASS - no longer matches when flatpak renames the exported .desktop file. Luckily, Flatpak provides us with a fail-safe way to map from the PID to the corresponding application ID, so expose an appropriate method that allows GNOME Shell to reliably match windows to the corresponding Flatpak app. https://bugzilla.gnome.org/show_bug.cgi?id=772614
2016-10-07 15:55:32 +00:00
}
window: Make window->desc a bit clearer And remove the hack for the "broken GNU libc". It works fine on my system here.
2014-03-19 01:19:51 +00:00
static void
meta_window_update_desc (MetaWindow *window)
{
g_clear_pointer (&window->desc, g_free);
Improve debug logging of Wayland windows Displaying all Wayland windows with the XID of 0x0 makes it hard to figure out what is going on ... use the recently-added window->stamp to show Wayland windows as W1/W2/W3...
2015-10-12 12:04:55 +00:00
if (window->client_type == META_WINDOW_CLIENT_TYPE_X11)
Don't include potentially sensitive window titles in logs For various error and warning messages, mutter includes a description of the window, and that description includes a snippet of the title of the window. Those snippets find their way into system logs, which then means they can potentially find their way into bug reports and similar. Remove the window title information to eliminate this potential privacy issue.
2018-08-10 00:16:02 +00:00
window->desc = g_strdup_printf ("0x%lx", window->xwindow);
window: Make window->desc a bit clearer And remove the hack for the "broken GNU libc". It works fine on my system here.
2014-03-19 01:19:51 +00:00
else
Improve debug logging of Wayland windows Displaying all Wayland windows with the XID of 0x0 makes it hard to figure out what is going on ... use the recently-added window->stamp to show Wayland windows as W1/W2/W3...
2015-10-12 12:04:55 +00:00
{
guint64 small_stamp = window->stamp - G_GUINT64_CONSTANT(0x100000000);
Don't include potentially sensitive window titles in logs For various error and warning messages, mutter includes a description of the window, and that description includes a snippet of the title of the window. Those snippets find their way into system logs, which then means they can potentially find their way into bug reports and similar. Remove the window title information to eliminate this potential privacy issue.
2018-08-10 00:16:02 +00:00
window->desc = g_strdup_printf ("W%" G_GUINT64_FORMAT , small_stamp);
Improve debug logging of Wayland windows Displaying all Wayland windows with the XID of 0x0 makes it hard to figure out what is going on ... use the recently-added window->stamp to show Wayland windows as W1/W2/W3...
2015-10-12 12:04:55 +00:00
}
window: Make window->desc a bit clearer And remove the hack for the "broken GNU libc". It works fine on my system here.
2014-03-19 01:19:51 +00:00
}
wayland: Sync surface actor state when changing main monitor In order to switch to the correct surface actor scale given the monitor the surface is on, without relying on the client committing a new state given some other side effect, sync the surface actor state when the main monitor associated with the corresponding window changed. https://bugzilla.gnome.org/show_bug.cgi?id=744933
2015-03-03 03:13:05 +00:00
static void
Rename MetaMonitorInfo MetaLogicalMonitor In preparation for further refactorizations, rename the MetaMonitorInfo struct to MetaLogicalMonitor. Eventually, part of MetaLogicalMonitor will be split into a MetaMonitor type. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-25 06:31:38 +00:00
meta_window_main_monitor_changed (MetaWindow *window,
const MetaLogicalMonitor *old)
wayland: Sync surface actor state when changing main monitor In order to switch to the correct surface actor scale given the monitor the surface is on, without relying on the client committing a new state given some other side effect, sync the surface actor state when the main monitor associated with the corresponding window changed. https://bugzilla.gnome.org/show_bug.cgi?id=744933
2015-03-03 03:13:05 +00:00
{
META_WINDOW_GET_CLASS (window)->main_monitor_changed (window, old);
if (old)
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
g_signal_emit_by_name (window->display, "window-left-monitor",
wayland: Sync surface actor state when changing main monitor In order to switch to the correct surface actor scale given the monitor the surface is on, without relying on the client committing a new state given some other side effect, sync the surface actor state when the main monitor associated with the corresponding window changed. https://bugzilla.gnome.org/show_bug.cgi?id=744933
2015-03-03 03:13:05 +00:00
old->number, window);
if (window->monitor)
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
g_signal_emit_by_name (window->display, "window-entered-monitor",
wayland: Sync surface actor state when changing main monitor In order to switch to the correct surface actor scale given the monitor the surface is on, without relying on the client committing a new state given some other side effect, sync the surface actor state when the main monitor associated with the corresponding window changed. https://bugzilla.gnome.org/show_bug.cgi?id=744933
2015-03-03 03:13:05 +00:00
window->monitor->number, window);
}
Let the MetaWindow calculate its main logical monitor itself There is no point in going via a MetaScreen API to calculate the "main monitor" of a window, so let the window do that calculation itself. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-12-01 05:01:39 +00:00
MetaLogicalMonitor *
meta_window_calculate_main_logical_monitor (MetaWindow *window)
{
MetaBackend *backend = meta_get_backend ();
MetaMonitorManager *monitor_manager =
meta_backend_get_monitor_manager (backend);
MetaRectangle window_rect;
meta_window_get_frame_rect (window, &window_rect);
return meta_monitor_manager_get_logical_monitor_from_rect (monitor_manager,
&window_rect);
}
core: Trace various window management actions https://gitlab.gnome.org/GNOME/mutter/merge_requests/765
2019-08-29 17:34:18 +00:00
static void
meta_window_manage (MetaWindow *window)
{
COGL_TRACE_BEGIN_SCOPED (MetaWindowManage,
"Window (manage)");
META_WINDOW_GET_CLASS (window)->manage (window);
}
window-x11: Move meta_window_new to window-x11.c and rename
2014-02-02 00:19:22 +00:00
MetaWindow *
_meta_window_shared_new (MetaDisplay *display,
MetaWindowClientType client_type,
MetaWaylandSurface *surface,
Window xwindow,
gulong existing_wm_state,
MetaCompEffect effect,
XWindowAttributes *attrs)
new function 2003-11-20 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new_with_attrs): new function * src/display.c, src/screen.c: create the compositor and feed windows and events to it
2003-11-21 02:32:05 +00:00
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = display->workspace_manager;
new function 2003-11-20 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new_with_attrs): new function * src/display.c, src/screen.c: create the compositor and feed windows and events to it
2003-11-21 02:32:05 +00:00
MetaWindow *window;
core: Trace various window management actions https://gitlab.gnome.org/GNOME/mutter/merge_requests/765
2019-08-29 17:34:18 +00:00
COGL_TRACE_BEGIN_SCOPED (MetaWindowSharedNew,
"Window (new)");
new function 2003-11-20 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new_with_attrs): new function * src/display.c, src/screen.c: create the compositor and feed windows and events to it
2003-11-21 02:32:05 +00:00
g_assert (attrs != NULL);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window: Remove unused parameter from meta_window_new_shared()
2013-11-19 19:42:50 +00:00
meta_verbose ("attrs->map_state = %d (%s)\n",
new function 2003-11-20 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new_with_attrs): new function * src/display.c, src/screen.c: create the compositor and feed windows and events to it
2003-11-21 02:32:05 +00:00
attrs->map_state,
(attrs->map_state == IsUnmapped) ?
add prototype thingy to display windows we're cycling through with tab. 2001-08-19 Havoc Pennington <hp@pobox.com> * src/tabpopup.c: add prototype thingy to display windows we're cycling through with tab. Not wired up to keybindings yet.
2001-08-19 06:23:59 +00:00
"IsUnmapped" :
new function 2003-11-20 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new_with_attrs): new function * src/display.c, src/screen.c: create the compositor and feed windows and events to it
2003-11-21 02:32:05 +00:00
(attrs->map_state == IsViewable) ?
add prototype thingy to display windows we're cycling through with tab. 2001-08-19 Havoc Pennington <hp@pobox.com> * src/tabpopup.c: add prototype thingy to display windows we're cycling through with tab. Not wired up to keybindings yet.
2001-08-19 06:23:59 +00:00
"IsViewable" :
new function 2003-11-20 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new_with_attrs): new function * src/display.c, src/screen.c: create the compositor and feed windows and events to it
2003-11-21 02:32:05 +00:00
(attrs->map_state == IsUnviewable) ?
add prototype thingy to display windows we're cycling through with tab. 2001-08-19 Havoc Pennington <hp@pobox.com> * src/tabpopup.c: add prototype thingy to display windows we're cycling through with tab. Not wired up to keybindings yet.
2001-08-19 06:23:59 +00:00
"IsUnviewable" :
"(unknown)");
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
xwayland: Add MetaWindowXwayland MetaWindowXwayland derives from MetaWindowX11 to allow for some Xwayland specific vfunc that wouldn't apply to plain X11 windows, such as shortcut inhibit routines. https://bugzilla.gnome.org/show_bug.cgi?id=783342
2017-08-30 07:17:41 +00:00
if (client_type == META_WINDOW_CLIENT_TYPE_X11 && !meta_is_wayland_compositor ())
Start splitting the X11-specific stuff of MetaWindow out into a subclass This is fairly simple and basic for now, with just skip_taskbar / skip_pager, but eventually a lot of "WM policy" like this, including move-resize, will be in subclasses for each individual surface.
2014-03-18 15:20:22 +00:00
window = g_object_new (META_TYPE_WINDOW_X11, NULL);
Conditionalize Wayland support again
2014-08-14 00:19:35 +00:00
#ifdef HAVE_WAYLAND
xwayland: Add MetaWindowXwayland MetaWindowXwayland derives from MetaWindowX11 to allow for some Xwayland specific vfunc that wouldn't apply to plain X11 windows, such as shortcut inhibit routines. https://bugzilla.gnome.org/show_bug.cgi?id=783342
2017-08-30 07:17:41 +00:00
else if (client_type == META_WINDOW_CLIENT_TYPE_X11)
window = g_object_new (META_TYPE_WINDOW_XWAYLAND, NULL);
Conditionalize Wayland support again
2014-08-14 00:19:35 +00:00
else if (client_type == META_WINDOW_CLIENT_TYPE_WAYLAND)
window: Add a type for Wayland windows
2014-03-19 13:26:17 +00:00
window = g_object_new (META_TYPE_WINDOW_WAYLAND, NULL);
Conditionalize Wayland support again
2014-08-14 00:19:35 +00:00
#endif
else
g_assert_not_reached ();
...
2001-05-30 15:36:31 +00:00
deleted and moved into window-props.c (meta_window_new_with_attrs): added 2006-03-25 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (update_net_wm_state, update_mwm_hints, update_wm_class, update_transient_for): deleted and moved into window-props.c (meta_window_new_with_attrs): added constructing field and four new initial properties (as above) (meta_window_recalc_features, meta_window_recalc_window_type): new functions * src/window-props.c (init_net_wm_state, reload_net_wm_state init_mwm_hints, reload_mwm_hints, init_wm_class, reload_mwm_class, init_transient_for, reload_transient_for): new functions, moved in from window.c (meta_display_init_window_prop_hooks): initialise new properties
2006-03-25 22:57:22 +00:00
window->constructing = TRUE;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
wayland: Adds basic hybrid X + Wayland support This adds support for running mutter as a hybrid X and Wayland compositor. It runs a headless XWayland server for X applications that presents wayland surfaces back to mutter which mutter can then composite. This aims to not break Mutter's existing support for the traditional X compositing model which means a single build of Mutter can be distributed supporting the traditional model and the new Wayland based compositing model. TODO: although building with --disable-wayland has at least been tested, I still haven't actually verified that running as a traditional compositor isn't broken currently. Note: At this point no input is supported Note: multiple authors have contributed to this patch: Authored-by: Robert Bragg <robert@linux.intel.com> Authored-by: Neil Roberts <neil@linux.intel.com> Authored-by: Rico Tzschichholz. Authored-by: Giovanni Campagna <gcampagna@src.gnome.org>
2012-01-07 22:21:32 +00:00
window->client_type = client_type;
window->surface = surface;
...
2001-05-30 15:36:31 +00:00
window->xwindow = xwindow;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-05-31 06:42:58 +00:00
window->display = display;
Replace MetaStackWindow with a 64-bit "stack ID" Putting X windows and pointers to MetaWindows into a union had a number of problems: - It caused awkward initialization and conditionalization - There was no way to refer to Wayland windows (represented by MetaWindow *) in the past, which is necessary for the MetaStackTracker algorithms - We never even cleaned up old MetaStackWindow so there could be records in MetaStackWindow pointing to freed MetaWindow. Replace MetaStackWindow with a 64-bit "stack ID" which is: - The XID for X Windows - a "window stamp" for Wayland windows - window stamps are assigned for all MetaWindow and are unique across the life of the process. https://bugzilla.gnome.org/show_bug.cgi?id=736559
2014-09-09 01:20:14 +00:00
meta_display_register_stamp (window->display, &window->stamp, window);
Partially resolve the conflicting requirements of windows on multiple 2004-12-22 Elijah Newren <newren@gmail.com> Partially resolve the conflicting requirements of windows on multiple workspaces and hidden being a global quantity for windows (fixes bug 156182; the remainder of the work is bug 87531 and is a libwnck issue) * src/display.c (event_callback): * src/window.c (meta_window_visible_on_workspace, meta_window_unstick): * src/workspace.c (meta_workspace_add_window, meta_workspace_contains_window, meta_workspace_queue_calc_showing): * src/workspace.h: Remove meta_workspace_contains_window, replace with simple comparison utilizing window->workspace * src/place.c (meta_window_place): * src/window.c (meta_window_shares_some_workspace): * src/window.h: Remove meta_window_shares_some_workspace, replace with a simple comparison utilizing window->workspace * src/session.c (save_state), * src/window.c (meta_window_new_with_attrs, meta_window_apply_session_info, meta_window_free, window_showing_on_its_workspace, meta_window_change_workspace_without_transients, meta_window_unstick, meta_window_set_current_workspace_hint, meta_window_get_workspaces): * src/window.h: * src/workspace.c (meta_workspace_free, meta_workspace_add_window, meta_workspace_remove_window): Only one workspace now
2004-12-22 23:52:52 +00:00
window->workspace = NULL;
add myself here, bug #100789 2002-12-09 Havoc Pennington <hp@pobox.com> * AUTHORS: add myself here, bug #100789 * src/display.c (meta_display_set_grab_op_cursor): drop PointerMotionHintMask * src/window.c (meta_window_handle_mouse_grab_op_event): don't use XQueryPointer, as we aren't using PointerMotionHint now * src/display.c (event_callback): rearrange a bit of code for slight speedup and clarity * src/window.c (update_resize) (meta_window_handle_mouse_grab_op_event): implement usage of the _METACITY_UPDATE_COUNTER (meta_window_handle_mouse_grab_op_event): fix code that used event->xbutton with a motion event * src/display.c (meta_display_open): add new atoms, and initialize Xsync if we have it (grab_op_is_resizing): new function (meta_display_begin_grab_op): create an alarm monitoring window's _METACITY_UPDATE_COUNTER (meta_spew_event): conditionalize this on WITH_VERBOSE_MODE and print alarm events. * src/window.c (meta_window_new): fetch _METACITY_UPDATE_COUNTER * configure.in (HAVE_XSYNC): check for Xsync extension
2002-12-10 03:23:04 +00:00
Fix bug 143333, support for update counter spec, and 109362, schedule Sat Jun 19 02:21:08 2004 Soeren Sandmann <sandmann@daimi.au.dk> Fix bug 143333, support for update counter spec, and 109362, schedule compensation events when events are ignored. * src/display.c (meta_display_open): Add _NET_WM_SYNC_REQUEST and _NET_WM_SYNC_REQUEST_COUNTER atoms. Remove the old METACITY_SYNC_COUNTER stuff. (meta_display_begin_op): Setup the sync counter * src/xprops.c, src/xprops.h, src/window-props.c, src/display.h: Add new atoms. * src/window.c (send_sync_request): new function. (meta_window_move_resize_internal): send a sync request before resizing. (check_move_resize_frequence): Rework logic to also check the SYNC case. If an event is ignored return the remaining time. (update_resize_timeout): Timeout that gets called when a compensation event is scheduled. (uddate_resize): schedule compensation events when an event is ignored. (meta_window_handle_mouse_grap_op_event): When an alarm is received and sync was turned off, turn it back on. * src/window.h (struct MetaWindow) Add some variables
2004-06-19 00:45:24 +00:00
window->sync_request_counter = None;
window->sync_request_serial = 0;
Make handling of windows that don't respond to _NET_WM_SYNC_REQUEST reliable Previously, we were handling failure to respond to _NET_WM_SYNC_REQUEST in the code path for throttling motion events. But this meant that if a window didn't respond to _NET_WM_SYNC_REQUEST and there were no motion events - for a keyboard resize, or after the end of the grab operation - it would end up in a stuck state. Use a separate per-window timeout to reliably catch the failure to respond to _NET_WM_SYNC_REQUEST. https://bugzilla.gnome.org/show_bug.cgi?id=694046
2013-03-13 19:31:11 +00:00
window->sync_request_timeout_id = 0;
Move sync alarms to be per-window and permanent Instead of creating a new alarm each time we resize a window interactively, create an alarm the first time we resize a window and keep it around permanently until we unmanage the window. Doing it this way will be useful when we allow the application to spontaneously generate sync request updates to indicate frames it is drawing. https://bugzilla.gnome.org/show_bug.cgi?id=685463
2011-06-08 15:26:03 +00:00
window->sync_request_alarm = None;
search for the window's screen by root window instead of Screen*, maybe it 2002-05-27 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_new): search for the window's screen by root window instead of Screen*, maybe it will help with bug #82664
2002-05-27 19:26:56 +00:00
window: Support snap packages for sandboxed app IDs For now we abuse of meta_window_get_flatpak_id not to break the APIs, so that it's working seamlessly in gnone shell too. Rename flatpak_id to sandboxed_app_id internally to get prepared to the future API. https://bugzilla.gnome.org/show_bug.cgi?id=788217
2017-09-26 21:22:43 +00:00
meta_window_update_sandboxed_app_id (window);
window: Make window->desc a bit clearer And remove the hack for the "broken GNU libc". It works fine on my system here.
2014-03-19 01:19:51 +00:00
meta_window_update_desc (window);
call meta_group_compute_group after setting window->desc to avoid SIGSEGV 2003-06-07 Rob Adams <robadams@ucla.edu> * src/window.c (meta_window_new): call meta_group_compute_group after setting window->desc to avoid SIGSEGV when verbose mode is enabled.
2003-06-07 17:15:33 +00:00
Adds support in src/core for tracking override redirect windows. The metacity core is now directly aware of override redirect windows. - They get MetaWindows like normal windows, so mutter no longer need to special case them. The net wm types applicable to override redirects are also recognised. - The original positioning/stacking semantics of metacity with respect to OR windows are maintained, but now it's easier to synchronize the stacking between the core and mutter. - mutter no longer needs to manualy track UnmapNotify, MapNotify, ReparentNotify, CreateNotify and DestroyNotify events; instead map, unmap, add and remove events can now be consistently delivered via the MetaCompositor callbacks.
2008-11-23 19:28:40 +00:00
window->override_redirect = attrs->override_redirect;
...
2001-06-11 03:24:20 +00:00
/* avoid tons of stack updates */
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_freeze (window->display->stack);
handle the client having a shape mask, fixes #101806 2003-01-05 Havoc Pennington <hp@pobox.com> * src/frames.c (meta_frames_apply_shapes): handle the client having a shape mask, fixes #101806 * src/core.c (meta_core_get_client_xwindow): new function * src/frame.c, src/frame.h: keep a flag for whether we need to update the frame shape * src/window.c (meta_window_new): select for ShapeNotify * src/display.h, src/display.c: actually query the shape extension, instead of just using it all over the place. * src/prefs.c (update_application_based): don't let people turn on application_based, as it just causes funky bugs. We can reenable the pref when/if it ever does something useful.
2003-01-05 07:51:02 +00:00
new function 2003-11-20 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new_with_attrs): new function * src/display.c, src/screen.c: create the compositor and feed windows and events to it
2003-11-21 02:32:05 +00:00
window->rect.x = attrs->x;
window->rect.y = attrs->y;
window->rect.width = attrs->width;
window->rect.height = attrs->height;
...
2001-06-03 01:33:27 +00:00
window: Make border_width private to X11
2014-05-20 13:19:10 +00:00
/* size_hints are the "request" */
new function 2003-11-20 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new_with_attrs): new function * src/display.c, src/screen.c: create the compositor and feed windows and events to it
2003-11-21 02:32:05 +00:00
window->size_hints.x = attrs->x;
window->size_hints.y = attrs->y;
window->size_hints.width = attrs->width;
window->size_hints.height = attrs->height;
Initialize size_hints on window creation using code shared with size_hints property reload
2003-04-26 17:40:32 +00:00
/* initialize the remaining size_hints as if size_hints.flags were zero */
meta_set_normal_hints (window, NULL);
...
2001-06-07 05:18:10 +00:00
/* And this is our unmaximized size */
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
window->saved_rect = window->rect;
window: Replace the user_rect with the unconstrained_rect Realistically, the user rect contains the unconstrained window rectangle coordinates that we want to be displaying, in case something in the constraints change. Rename it to the "unconstrained_rect", and change the code to always save it, regardless of current state. When metacity was originally being built, the purpose of the user rect was a lot less clear. The code only saved it on user actions, with various other calls to save_user_window_placement() and a force mechanism sprinkled in to avoid windows being snapped back to odd places when constraints changed. This could lead to odd bugs. For instance, if the user uses some extension which automatically tiles windows and didn't pass user_action=TRUE, and then the struts changed, the window would be placed back at the last place a user moved it to, rather than where the window was tiled to. The META_IS_USER_ACTION flag is still used in the constraints code to determine whether we should allow shoving windows offscreen, so we can't remove it completely, but we should think about splitting out the constrainment policies it commands for a bit more fine-grained control. https://bugzilla.gnome.org/show_bug.cgi?id=726714
2014-03-18 14:53:00 +00:00
window->unconstrained_rect = window->rect;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
new function 2003-11-20 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new_with_attrs): new function * src/display.c, src/screen.c: create the compositor and feed windows and events to it
2003-11-21 02:32:05 +00:00
window->depth = attrs->depth;
window->xvisual = attrs->visual;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-06-02 04:14:18 +00:00
window->title = NULL;
...
2001-06-24 02:22:10 +00:00
window->icon = NULL;
add support for a mini icon in the titlebar (update_icon): re-enable 2001-09-15 Havoc Pennington <hp@pobox.com> * src/window.c: add support for a mini icon in the titlebar (update_icon): re-enable support for _NET_WM_ICON * src/session.c (save_state): add an ferror check when writing session file
2001-09-16 00:30:45 +00:00
window->mini_icon = NULL;
...
2001-06-03 01:33:27 +00:00
window->frame = NULL;
...
2001-06-04 04:58:22 +00:00
window->has_focus = FALSE;
window: add an appears-focused property, redraw shadows when it changes We need to redraw a window's shadow any time the value of meta_window_appears_focused() changes. So make that into a property so we can get notifications on it. https://bugzilla.gnome.org/show_bug.cgi?id=636904
2011-03-25 01:36:47 +00:00
window->attached_focus_window = NULL;
...
2001-06-04 06:17:52 +00:00
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
window->maximized_horizontally = FALSE;
window->maximized_vertically = FALSE;
window->maximize_horizontally_after_placement = FALSE;
window->maximize_vertically_after_placement = FALSE;
Patch from Carlo Wood to ensure that maximized and minimized properties 2006-10-01 Elijah Newren <newren gmail com> Patch from Carlo Wood to ensure that maximized and minimized properties are maintained across restarts. #358042. * src/constraints.c (place_window_if_needed): fix up partial maximization handling and add minimize_after_placement handling. * src/display.[ch] (struct MetaDisplay, meta_display_open): add a new display->display_opening flag to allow handling startup differently where needed. * src/window-props.c (reload_net_wm_state): handle _net_wm_state_hidden as well, setting window->minimize_after_placement appropriately * src/window.[ch] (struct MetaWindow, meta_window_new_with_attrs): add a window->minimize_after_placement field * src/window.c (meta_window_new_with_attrs): only unminimize the window and its transients if the display isn't being opened, (unmaximize_window_before_freeing): don't reset the state unless the window is becoming withdrawn, if the screen is being closed be sure to save the unmaximized state of the window so the next window manager can restore it
2006-10-01 21:59:09 +00:00
window->minimize_after_placement = FALSE;
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
window->fullscreen = FALSE;
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
window->require_fully_onscreen = TRUE;
Refer to monitors as "monitors" rather than "xineramas" http://bugzilla.gnome.org/show_bug.cgi?id=593686
2009-08-31 13:52:16 +00:00
window->require_on_single_monitor = TRUE;
Add a constrain_titlebar_visible constraint; should fix both bug 333328 2006-08-07 Elijah Newren <newren gmail com> Add a constrain_titlebar_visible constraint; should fix both bug 333328 and bug 345522. Not perfect (minor annoying snap pulling windows back onscreen, plus an ugly hack almost as bad as the old one), but tarballs are due in less than half an hour. ;-) * src/boxes.[ch] (meta_rectangle_overlaps_with_region): new function * src/constraints.c (constrain_titlebar_visible): new function, (enum ConstraintPriority, array all_constraints, update_onscreen_requirements): various small changes to accomodate the new function * src/edge-resistance.c: remove the infinite edge resistance, which was a big hack of a way to workaround the lack of a titlebar_visible constraint * src/window.[ch] (MetaWindow): new require_titlebar_visible bitfield, (meta_window_new_with_attrs): initialized here
2006-08-07 23:34:55 +00:00
window->require_titlebar_visible = TRUE;
...
2001-06-10 03:17:15 +00:00
window->on_all_workspaces = FALSE;
Split out on_all_workspaces and on_all_workspaces_requested Sometimes on_all_workspaces is requested by the client/user, and sometimes its calculated implicitly due to internal state. We split this up so that we know when the user has explicitly asked for sticky window, when e.g. setting wmspec properties or storing session info. on_all_workspaces means this window is visible on all workspaces. on_all_workspaces_requested, means the user explicitly made the window sticky somehow (via imported session, _NET_WM_STATE from another wm, toggled in the window menu, etc). It always implies on_all_workspaces is TRUE. Right now the only time we set on_all_workspaces is for override-redirect windows, but later we can add a "windows on non-primary monitor are not part of the workspace switching" feature. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 10:41:23 +00:00
window->on_all_workspaces_requested = FALSE;
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
window->tile_mode = META_TILE_NONE;
window->tile_monitor_number = -1;
window: Allow resizing of tiled windows Currently tiled windows are not resizable and their size is fixed to half the screen width. Adjust the code to work with fractions other than half, and allow users to adjust the split by dragging the window edge that is not constrained by a monitor edge. Follow-up patches will improve on that by resizing neighboring tiled windows by a shared edge, and making the functionality available to client-side decorated windows implementing the new edge constraints protocol.
2017-09-27 12:37:57 +00:00
window->tile_hfraction = -1.;
...
2001-06-08 02:17:48 +00:00
window->shaded = FALSE;
...
2001-06-04 06:17:52 +00:00
window->initially_iconic = FALSE;
window->minimized = FALSE;
Patch from Ross Cohen to make alt-esc (show windows instantly) actually 2005-10-03 Elijah Newren <newren@gmail.com> Patch from Ross Cohen to make alt-esc (show windows instantly) actually show minimized windows too. Fixes #107072. * src/keybindings.c (process_tab_grab): initialize tab_unminimized to FALSE for the target window when starting the grab, when advancing through the list check to find the previous window and re-minimize it if it was tab-unminimized, unminimize the new window we're alt-esc'ing to if it's minimized, (do_choose_window): raise and unminimize the initial window as well in alt-esc'ing * src/window.h (struct _MetaWindow): add a tab_unminimized field * src/window.c (meta_window_new_with_attrs): initialize tab_unminimized to false
2005-10-03 20:02:31 +00:00
window->tab_unminimized = FALSE;
...
2001-06-04 06:17:52 +00:00
window->iconic = FALSE;
new function 2003-11-20 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new_with_attrs): new function * src/display.c, src/screen.c: create the compositor and feed windows and events to it
2003-11-21 02:32:05 +00:00
window->mapped = attrs->map_state != IsUnmapped;
window: Track known_to_compositor and visible_to_compositor separately Really, visible_to_compositor means that the window is shown, e.g. not minimized. We need to be using a boolean tracking whether we've called meta_compositor_add_window / meta_compositor_remove_window. This fixes a jump during window placement when a window appears.
2014-03-28 17:50:45 +00:00
window->known_to_compositor = FALSE;
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
window->visible_to_compositor = FALSE;
window->pending_compositor_effect = effect;
Focus windows that manually position themselves too (fixes #107347). 2004-12-27 Elijah Newren <newren@gmail.com> Focus windows that manually position themselves too (fixes #107347). * src/window.h (struct _MetaWindow): add a new showing_for_first_time flag * src/window.c (meta_window_new_with_attrs): initialize showing_for_first_time flag to !mapped, (meta_window_show): replace did_placement with showing_for_first_time in the section to decided whether to focus since did_placement isn't quite what we want
2004-12-28 06:01:42 +00:00
/* if already mapped, no need to worry about focus-on-first-time-showing */
window->showing_for_first_time = !window->mapped;
Avoid moving and resizing override-redirect windows Override-redirect windows should not be moved or resized by the window manager. - Mark override-redirect windows as already placed to avoid placing them when first shown. - Don't move-resize newly created override-redirect MetaWindow - Don't queue a resize on override-redirect windows when reading their WM_TRANSIENT_FOR hint. - Add g_return_if_fail (!window->override_redirect) to catch unexpected code paths that might result in override-redirect windows being moved or resized. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-15 22:25:07 +00:00
/* if already mapped we don't want to do the placement thing;
* override-redirect windows are placed by the app */
window->placed = ((window->mapped && !window->hidden) || window->override_redirect);
Avoid new windows being obscured by the focus window (and thus possibly 2005-02-11 Elijah Newren <newren@gmail.com> Avoid new windows being obscured by the focus window (and thus possibly lost). Fixes #166524. * src/place.c: new MetaWindowDirection enum, (find_most_freespace): new function to find where there is the most space available around the focused window, (meta_window_place): if a window is denied focus and the window overlaps the focused window, retry the first-fit algorithm only paying attention to the focus window position and if that fails just find the location on the screen with the most space available. * src/window.h: (struct MetaWindow): new denied_focus_and_not_transient bitfield * src/window.c: (meta_window_new_with_attrs): initialize denied_focus_and_not_transient, (meta_window_show): set and unset the denied_focus_and_not_transient field appropriately
2005-02-11 19:20:44 +00:00
window->denied_focus_and_not_transient = FALSE;
...
2001-06-22 03:20:21 +00:00
window->unmanaging = FALSE;
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
window->is_in_queues = 0;
...
2001-06-23 05:49:35 +00:00
window->keys_grabbed = FALSE;
window->grab_on_frame = FALSE;
...
2001-07-11 06:22:00 +00:00
window->all_keys_grabbed = FALSE;
...
2001-06-23 18:30:27 +00:00
window->withdrawn = FALSE;
...
2001-06-24 06:47:54 +00:00
window->initial_workspace_set = FALSE;
Add support for _NET_WM_USER_TIME 2004-06-17 Elijah Newren <newren@math.utah.edu> Add support for _NET_WM_USER_TIME * src/display.c: (meta_display_open): Add _NET_WM_USER_TIME to atom_names[], (event_callback): Manually set _NET_WM_USER_TIME upon KeyPress (doesn't work since keyboard isn't grabbed) and ButtonPress (does work), this is just a fallback for applications that don't update this themselves. * src/display.h: (struct _MetaDisplay): Add atom_net_wm_user_time field * src/screen.c: (meta_screen_apply_startup_properties): Check for TIMESTAMP provided from startup sequence as well. * src/stack.c: s/meta_window_set_stack_position/meta_window_set_stack_position_no_sync/, (meta_window_set_stack_position): New function which calls the meta_window_set_stack_position_no_sync function followed immediately by calling meta_stack_sync_to_server. * src/window-props.c: (init_net_wm_user_time), (reload_net_wm_user_time): new functions, (reload_wm_hints): also load atom_net_wm_user_time * src/window.c: new XSERVER_TIME_IS_LATER macro (accounts for timestamp wraparound), (meta_window_new_with_attrs): add timestamp attributes, (window_takes_focus_on_map): use TIMESTAMP from startup notification and _NET_WM_USER_TIME to decide whether to focus new windows, (meta_window_show): if app doesn't take focus on map, place it just below the focused window in the stack (process_property_notify): check for changes to _NET_WM_USRE_TIME, (meta_window_stack_just_below): new function * src/window.h: (_MetaWindow struct): new fields for initial_timestamp, initial_timestamp_set, net_wm_user_time_set, and net_wm_user_time, (meta_window_stack_just_below): new function
2004-06-24 15:47:05 +00:00
window->initial_timestamp_set = FALSE;
window->net_wm_user_time_set = FALSE;
Add support for _NET_WM_USER_TIME_WINDOW in order to cut down on context 2007-03-30 Elijah Newren <newren gmail com> Add support for _NET_WM_USER_TIME_WINDOW in order to cut down on context switches. * src/display.c (meta_display_open): * src/display.h (struct _MetaDisplay): * src/screen.c (set_supported_hint): new atom * src/display.c (meta_display_open, meta_display_get_current_time_roundtrip): * src/display.h (struct _MetaDisplay): create a dedicated timestamp pinging window instead of reusing display->leader_window * src/display.c (event_callback): * src/window-props.c (reload_net_wm_user_time_window): * src/window.c (meta_window_new_with_attrs, meta_window_free, process_property_notify): * src/window.h (struct _MetaWindow): monitor property notify events on _NET_WM_USER_TIME_WINDOW windows too * src/window-props.[ch]: new meta_window_reload_propert(y|ies)_from_xwindow() functions * src/window-props.[ch] (init_net_wm_user_time_window, reload_net_wm_user_time_window, meta_display_init_window_prop_hooks): * src/window.c (meta_window_new_with_attrs): new hooks to handle new atom svn path=/trunk/; revision=3134
2007-03-31 05:19:41 +00:00
window->user_time_window = None;
Correctly initialize window->input field With the change from bug 582639, we no longer call the reload functions for properties that are not initially set, so the initialization of fields in window.c has to match what window-props.c would set for a missing property. There was only one discrepancy, window->input, which needs to be set to TRUE by default (or a window missing a WM_HINTS property won't get focus); we also add explicit initializers for a couple of fields that were getting 0-initialized to the correct default value of FALSE for consistency with the explicit intialization of the rest of the fields. Bug reported by Dominique Leuenberger https://bugzilla.gnome.org/show_bug.cgi?id=601228
2009-11-09 18:47:16 +00:00
window->input = TRUE;
...
2001-06-24 08:09:10 +00:00
window->calc_placement = FALSE;
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
window->shaken_loose = FALSE;
In the "prefs cause code complexity" department, here's a "sloppy focus 2003-10-13 Havoc Pennington <hp@redhat.com> In the "prefs cause code complexity" department, here's a "sloppy focus die die die" kind of moment. * src/display.c (meta_display_grab_focus_window_button): don't grab in sloppy focus mode, since we were dropping the grab on window enter anyway this just removes races from the current behavior. * src/display.c (prefs_changed_callback): ungrab/grab on focus mode changes, since we treat sloppy and click differently.
2003-10-13 20:15:40 +00:00
window->have_focus_click_grab = FALSE;
Fix bug 143333, support for update counter spec, and 109362, schedule Sat Jun 19 02:21:08 2004 Soeren Sandmann <sandmann@daimi.au.dk> Fix bug 143333, support for update counter spec, and 109362, schedule compensation events when events are ignored. * src/display.c (meta_display_open): Add _NET_WM_SYNC_REQUEST and _NET_WM_SYNC_REQUEST_COUNTER atoms. Remove the old METACITY_SYNC_COUNTER stuff. (meta_display_begin_op): Setup the sync counter * src/xprops.c, src/xprops.h, src/window-props.c, src/display.h: Add new atoms. * src/window.c (send_sync_request): new function. (meta_window_move_resize_internal): send a sync request before resizing. (check_move_resize_frequence): Rework logic to also check the SYNC case. If an event is ignored return the remaining time. (update_resize_timeout): Timeout that gets called when a compensation event is scheduled. (uddate_resize): schedule compensation events when an event is ignored. (meta_window_handle_mouse_grap_op_event): When an alarm is received and sync was turned off, turn it back on. * src/window.h (struct MetaWindow) Add some variables
2004-06-19 00:45:24 +00:00
window->disable_sync = FALSE;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-06-11 03:24:20 +00:00
window->unmaps_pending = 0;
core: Fix multiple reparent requests handling If window decoration is modified within a short period of time, mutter sometimes starts processing the second request before the first UnmapNotify event has been received. In this situation, it considers that the window is not mapped and does not expect another UnmapNotify / MapNotify event sequence to happen. This adds a separate counter to keep track of the pending reparents. The input focus is then restored when MapNotify event is received iff all the expected pending ReparentNotify events have been received. Signed-off-by: Rémi Bernon <rbernon@codeweavers.com> https://gitlab.gnome.org/GNOME/mutter/merge_requests/657
2019-06-24 13:10:22 +00:00
window->reparents_pending = 0;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-06-23 18:30:27 +00:00
window->mwm_decorated = TRUE;
Theme breakage! Themes have to implement "border" frames now, see Atlanta 2002-06-21 Havoc Pennington <hp@pobox.com> Theme breakage! Themes have to implement "border" frames now, see Atlanta for an example. Fixes #84285 * src/tools/metacity-window-demo.c (do_appwindow): add a border-only window * src/window.c (update_mwm_hints): read border only from the MWM hints * src/window.h (struct _MetaWindow): add border_only flag * src/core.c (meta_core_get_frame_type): report border type if required * src/common.h (enum): add META_FRAME_TYPE_BORDER
2002-06-22 03:23:02 +00:00
window->mwm_border_only = FALSE;
...
2001-06-23 18:30:27 +00:00
window->mwm_has_close_func = TRUE;
window->mwm_has_minimize_func = TRUE;
window->mwm_has_maximize_func = TRUE;
window->mwm_has_move_func = TRUE;
window->mwm_has_resize_func = TRUE;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window/wayland: Don't initialize a window as showing With Wayland, a window is not showing until it's shown. Until this patch, the initial state of MetaWindow, on the other hand, was that a window is initialized as showing. This means that for a window to actually be classified as shown (MetaWindow::hidden set to FALSE), something would first have to hide it. Normally, this wasn't an issue, as normally we'd first create a window, determine it shouldn't be visible (due to missing buffer), hide it before the next paint, then eventually show it. This doesn't work if mutter isn't drawing any frames at the moment (e.g. the user switched VT), as we'd miss the hiding before showing as e result of a buffer being attached. The most visible side effect is that a window can't be moved as the window actor remains frozen. This commit fixes this issue by correctly classifying a newly created Wayland window as "hidden". Fixes: https://gitlab.gnome.org/GNOME/mutter/issues/331
2018-10-05 13:31:46 +00:00
switch (client_type)
{
case META_WINDOW_CLIENT_TYPE_X11:
window->decorated = TRUE;
window->hidden = FALSE;
break;
case META_WINDOW_CLIENT_TYPE_WAYLAND:
window->decorated = FALSE;
window->hidden = TRUE;
break;
}
wayland: Adds basic hybrid X + Wayland support This adds support for running mutter as a hybrid X and Wayland compositor. It runs a headless XWayland server for X applications that presents wayland surfaces back to mutter which mutter can then composite. This aims to not break Mutter's existing support for the traditional X compositing model which means a single build of Mutter can be distributed supporting the traditional model and the new Wayland based compositing model. TODO: although building with --disable-wayland has at least been tested, I still haven't actually verified that running as a traditional compositor isn't broken currently. Note: At this point no input is supported Note: multiple authors have contributed to this patch: Authored-by: Robert Bragg <robert@linux.intel.com> Authored-by: Neil Roberts <neil@linux.intel.com> Authored-by: Rico Tzschichholz. Authored-by: Giovanni Campagna <gcampagna@src.gnome.org>
2012-01-07 22:21:32 +00:00
...
2001-06-08 06:39:38 +00:00
window->has_close_func = TRUE;
window->has_minimize_func = TRUE;
window->has_maximize_func = TRUE;
...
2001-06-23 18:30:27 +00:00
window->has_move_func = TRUE;
window->has_resize_func = TRUE;
...
2001-06-23 06:54:28 +00:00
window->has_shade_func = TRUE;
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
window->has_fullscreen_func = TRUE;
fill in window->desc sooner since we use it sooner now. 2003-05-16 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new): fill in window->desc sooner since we use it sooner now. * src/display.c (meta_display_open): init display->grab_update_alarm * src/window.c (meta_window_new): initialize the always_sticky field (meta_window_new): initialize the update_icon_queued field Patch from Julien Olivier bug #92335 for converting "show desktop mode" to "all windows are minimized" when you open a new window, instead of just mapping all the windows again. * src/window.c (meta_window_activate): minimize all windows before coming out of show desktop mode. (meta_window_unminimize): don't toggle show desktop mode here * src/screen.c (meta_screen_minimize_all_except): new function
2003-05-16 21:59:08 +00:00
window->always_sticky = FALSE;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Apply blackc@speakeasy.net patch, bug #83940, to do mini-workspaces 2002-07-06 Havoc Pennington <hp@pobox.com> Apply blackc@speakeasy.net patch, bug #83940, to do mini-workspaces similar to the pager, when switching spaces. * src/window.c (update_net_wm_state): actually fill in wm_state_skip_taskbar, wm_state_skip_pager flags * src/tabpopup.c: support drawing a mini-workspace similar to the one the pager draws. * src/stack.c (meta_stack_list_windows): new function to list the windows in stacking order * src/screen.c (meta_screen_ensure_workspace_popup): don't pass in the ugly default app icon for workspaces * src/display.c (event_callback): fix from blackc@speakeasy.net to avoid dereferencing a NULL grab window.
2002-07-06 19:05:37 +00:00
window->skip_taskbar = FALSE;
window->skip_pager = FALSE;
make it static 2002-10-01 Havoc Pennington <hp@pobox.com> * src/screen.c (meta_screen_resize_func): make it static * src/stack.c (get_standalone_layer): put above/below windows in an appropriate layer. * src/screen.c (set_supported_hint): say we support above/below * src/display.h (struct _MetaDisplay): add _NET_WM_STATE_ABOVE, _NET_WM_STATE_BELOW atoms * src/window.c (meta_window_client_message): handle above/below state messages (set_net_wm_state): handler above/below state (update_net_wm_state): handle above/below states
2002-10-02 00:47:29 +00:00
window->wm_state_above = FALSE;
window->wm_state_below = FALSE;
Fix some support for EWMH hints, and fix USER_TIME support to include the 2004-07-31 Rob Adams <readams@readams.net> Fix some support for EWMH hints, and fix USER_TIME support to include the DEMANDS_ATTENTION hint. Also includes some code for implementing _NET_RESTACK_WINDOW and _NET_MOVERESIZE_WINDOW, but this is disabled pending feature thaw. * COMPLIANCE: update with new information * src/display.c (meta_display_open): add new hints to list * src/display.h (_MetaDisplay): Add new atoms to struct * src/screen.c (set_supported_hint): update the list of support hints. (set_desktop_viewport_hint): new function sets the viewport hint to (0,0) as required by the spec for WMs with no viewport support. (set_desktop_geometry_hint): new function to set the desktop size hint to the size of the display, since we don't implement large desktop support, as required by the spec. (meta_screen_resize): update the geometry hint on screen resize * src/window.c (meta_window_new_with_attrs): Initialize demands_attention state (set_net_wm_state): Set demands_attention hint in the window state (meta_window_show): If we don't pop up a window because of USER_TIME, set DEMANDS_ATTENTION on the window. (meta_window_focus): When a window receives focus, remove DEMANDS_ATTENTION hint (meta_window_client_message): Allow other apps to set DEMANDS_ATTENTION on a window. Also, if the _NET_ACTIVE_WINDOW hint includes a timestamp, use it. (update_net_wm_state): Read DEMANDS_ATTENTION state also * src/window.h (_MetaWindow): add wm_state_demands_attention bit.
2004-07-31 19:56:10 +00:00
window->wm_state_demands_attention = FALSE;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-06-09 21:58:30 +00:00
window->res_class = NULL;
window->res_name = NULL;
window->role = NULL;
window->sm_client_id = NULL;
new file containing all the wacky mess I just added to a simple "click the 2002-04-13 Havoc Pennington <hp@pobox.com> * src/delete.c: new file containing all the wacky mess I just added to a simple "click the close button", contains all the dealing-with-dead-application cruft. Use metacity-window-demo to test by clicking the toolbar button that locks it up.
2002-04-13 04:58:45 +00:00
window->wm_client_machine = NULL;
window: fix meta_window_is_remote across hostname changes meta_window_is_remote compares a cached copy of the system hostname with the hostname of the client window (as presented by the WM_CLIENT_MACHINE property). Of course, the system hostname can change at any time, so caching it is wrong. Also, the WM_CLIENT_MACHINE property won't necessarily change when the system hostname changes, so comparing it with the new system hostname is wrong, too. This commit makes the code call gethostname() at the time WM_CLIENT_MACHINE is set, check whether it's remote then, and cache that value, rather than comparing potentially out of sync hostnames later. https://bugzilla.gnome.org/show_bug.cgi?id=688716
2013-02-20 20:17:21 +00:00
window->is_remote = FALSE;
lengthen to 15 seconds 2002-11-30 Havoc Pennington <hp@pobox.com> * src/screen.c (STARTUP_TIMEOUT): lengthen to 15 seconds * src/util.c (utf8_fputs): hmm, return a value * src/screen.c (meta_screen_apply_startup_properties): new function to apply initial workspace based on startup sequence. * src/window.c (meta_window_new): load _NET_STARTUP_ID (meta_window_get_startup_id): new function * src/window-props.c (meta_display_init_window_prop_hooks): add hooks for _NET_STARTUP_ID * src/display.c (event_callback): send property events to groups. * src/xprops.c (meta_prop_get_values): make a type of INVALID mean to ignore that property (don't fetch its value). * src/group.c (meta_group_property_notify): new function * src/screen.c (set_supported_hint): support _NET_STARTUP_ID * src/display.c (meta_display_open): add _NET_STARTUP_ID to atoms we initialize * src/group-private.h: private header shared between group-props.c, group.c * src/group-props.h, src/group-props.c: new files to contain functions for retrieving group properties * src/window.c (meta_window_same_application): change this a bit to work with new definition of group * src/group.c (meta_window_get_group): always create a group for every window, using the window's own ID as group leader if required. * src/window.c (update_wm_hints): handle changes to group leader * src/group.c (meta_window_group_leader_changed): new function * src/display.h (struct _MetaDisplay): _NET_WM_WINDOW_TYPE_SPLASH, not SPLASHSCREEN. Reported by Gregory Merchan and Matthias Clasen. * src/screen.c (startup_sequence_timeout): when timing out a startup sequence, send a remove message, don't just time it out locally.
2002-12-01 03:58:04 +00:00
window->startup_id = NULL;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
new file containing all the wacky mess I just added to a simple "click the 2002-04-13 Havoc Pennington <hp@pobox.com> * src/delete.c: new file containing all the wacky mess I just added to a simple "click the close button", contains all the dealing-with-dead-application cruft. Use metacity-window-demo to test by clicking the toolbar button that locks it up.
2002-04-13 04:58:45 +00:00
window->net_wm_pid = -1;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-06-09 21:58:30 +00:00
window->xtransient_for = None;
window->xclient_leader = None;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-06-10 03:17:15 +00:00
window->type = META_WINDOW_NORMAL;
...
2001-06-10 07:27:11 +00:00
Update constraints code to support the new _NET_WM_STRUT_PARTIAL EWMH 2003-06-10 Rob Adams <robadams@ucla.edu> Update constraints code to support the new _NET_WM_STRUT_PARTIAL EWMH draft specification. See #86682. Also, fix a bug involving work area invalidation on metacity startup. Fix for #108497. Finally, some minor fixes for full screen windows. * src/window.h: Add new MetaStruts structure to store strut rects for a window. Remove has_struts and do_not_cover flag, and support new MetaStruts instead of the four ints. * src/window.c (meta_window_new): change initialization to work with new struts. Also, move meta_window_update_struts call to after the workspaces are initialized to fix #108497. Remove do_not_cover and related code. (process_property_notify): add strut_partial (update_struts): change function name to meta_window_update_struts and expose in external MetaWindow API. Support partial width struts and the new strut rects. * src/workspace.h: add new GSLists containing pointers to all relevant struts for this workspace. * src/workspace.c (meta_workspace_new): initialize the list of strut rects for this workspace. (meta_workspace_free): free the strut rect lists (ensure_work_areas_validated): support new struts and new strut rect lists. Unleash the per-xinerama work areas. * src/constraints.c (get_outermost_onscreen_positions): Use the current window position along with the new per-workspace strut rects to compute the constraints that apply to a particular window. (constraint_hint_applies_func): don't do hints constraints on fullscreen windows (update_position_limits): for maximized windows use the work areas to set the position limits; for other windows rely on the struts constraints to be computed later in get_outermost_onscreen_positions (meta_window_constrain): don't apply aspect ratio hints to full screen windows * src/display.c (meta_display_open): add _NET_WM_STRUT_PARTIAL atom (meta_rectangle_equal): new helper function for MetaRectangles (event_queue_callback): #ifndef out if USE_GDK_DISPLAY not set to avoid compiler warning * src/display.h: add atom_net_wm_strut_partial, and add meta_rectangle_equal. * src/screen.c (meta_screen_rect_intersects_xinerama): change _window_intersects_ to _rect_intersects_ which is more useful now. (meta_screen_resize_func): update struts on windows with struts since struts are relative to the screen size, and this function is called when the screen size updates. * src/screen.h (meta_screen_rect_intersects_xinerama): change _window_intersects_ to _rect_intersects_ which is more useful now. * src/window-props.c (meta_display_init_window_prop_hooks): add hook for strut_partial * src/tools/metacity-window-demo.c: Support partial-width struts on the dock window tests for metacity testing purposes.
2003-06-26 03:09:38 +00:00
window->struts = NULL;
window is in fullscreen layer if any member of its group is fullscreen 2002-08-12 Havoc Pennington <hp@redhat.com> * src/stack.c (compute_layer): window is in fullscreen layer if any member of its group is fullscreen * src/window.c (meta_window_unmake_fullscreen): update layer for whole window group (meta_window_make_fullscreen): ditto * src/util.c (meta_unsigned_long_hash): move hash/equal funcs for Window in here. * src/group.c: track window groups so we can do stuff with them.
2002-08-12 21:32:13 +00:00
Rewrite stack code to work a lot differently. Should be better now, and 2002-09-28 Havoc Pennington <hp@pobox.com> * src/window.c, src/stack.c: Rewrite stack code to work a lot differently. Should be better now, and not lose relative positions of windows when moving among layers. Also should now be possible to get session management to restore the stacking order. Probably breaks some stuff, and makes all the stack.c changes I made yesterday sort of irrelevant.
2002-09-28 16:33:39 +00:00
window->layer = META_LAYER_LAST; /* invalid value */
window->stack_position = -1;
...
2001-06-24 06:47:54 +00:00
window->initial_workspace = 0; /* not used */
Add support for _NET_WM_USER_TIME 2004-06-17 Elijah Newren <newren@math.utah.edu> Add support for _NET_WM_USER_TIME * src/display.c: (meta_display_open): Add _NET_WM_USER_TIME to atom_names[], (event_callback): Manually set _NET_WM_USER_TIME upon KeyPress (doesn't work since keyboard isn't grabbed) and ButtonPress (does work), this is just a fallback for applications that don't update this themselves. * src/display.h: (struct _MetaDisplay): Add atom_net_wm_user_time field * src/screen.c: (meta_screen_apply_startup_properties): Check for TIMESTAMP provided from startup sequence as well. * src/stack.c: s/meta_window_set_stack_position/meta_window_set_stack_position_no_sync/, (meta_window_set_stack_position): New function which calls the meta_window_set_stack_position_no_sync function followed immediately by calling meta_stack_sync_to_server. * src/window-props.c: (init_net_wm_user_time), (reload_net_wm_user_time): new functions, (reload_wm_hints): also load atom_net_wm_user_time * src/window.c: new XSERVER_TIME_IS_LATER macro (accounts for timestamp wraparound), (meta_window_new_with_attrs): add timestamp attributes, (window_takes_focus_on_map): use TIMESTAMP from startup notification and _NET_WM_USER_TIME to decide whether to focus new windows, (meta_window_show): if app doesn't take focus on map, place it just below the focused window in the stack (process_property_notify): check for changes to _NET_WM_USRE_TIME, (meta_window_stack_just_below): new function * src/window.h: (_MetaWindow struct): new fields for initial_timestamp, initial_timestamp_set, net_wm_user_time_set, and net_wm_user_time, (meta_window_stack_just_below): new function
2004-06-24 15:47:05 +00:00
window->initial_timestamp = 0; /* not used */
Ensure window->compositor_private is initialised in meta_window_new_with_attrs
2008-10-31 12:57:47 +00:00
window->compositor_private = NULL;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Let the MetaWindow calculate its main logical monitor itself There is no point in going via a MetaScreen API to calculate the "main monitor" of a window, so let the window do that calculation itself. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-12-01 05:01:39 +00:00
window->monitor = meta_window_calculate_main_logical_monitor (window);
core/window: Don't set a preferred output when there is none If there are no active logical monitors, don't try to dereference a NULL one to get a preferred output winsys id. Instead just set an invalid one. https://bugzilla.gnome.org/show_bug.cgi?id=730551
2017-04-12 06:21:49 +00:00
if (window->monitor)
window->preferred_output_winsys_id = window->monitor->winsys_id;
else
window->preferred_output_winsys_id = UINT_MAX;
Track the monitor for each window https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-25 15:37:05 +00:00
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
window->tile_match = NULL;
Add meta_window_get_stable_sequence Useful for plugins which want to order windows in a stable fashion. https://bugzilla.gnome.org/show_bug.cgi?id=595882
2009-09-19 00:50:11 +00:00
/* Assign this #MetaWindow a sequence number which can be used
* for sorting.
*/
window->stable_sequence = ++display->window_sequence_counter;
init prev_mask field 2003-11-24 Havoc Pennington <hp@redhat.com> * src/iconcache.c (meta_icon_cache_init): init prev_mask field * src/window.c (meta_window_new_with_attrs): init xgroup_leader prior to use
2003-11-24 19:09:25 +00:00
Move _NET_WM_WINDOW_OPACITY handling to the standard window-props interface
2013-12-06 18:44:31 +00:00
window->opacity = 0xFF;
wayland: implement support for popup surfaces Popup surfaces are mapped into override_redirect surfaces of a DROPDOWN_MENU type, with the addition of a special pointer grab. https://bugzilla.gnome.org/show_bug.cgi?id=707863
2013-09-10 13:53:31 +00:00
if (window->override_redirect)
{
window->decorated = FALSE;
window->always_sticky = TRUE;
window->has_close_func = FALSE;
window->has_shade_func = FALSE;
window->has_move_func = FALSE;
window->has_resize_func = FALSE;
}
window: Add window id Generate a unique 64bit window-id which is unrelated to any windowing backend. https://gitlab.gnome.org/GNOME/mutter/merge_requests/306
2018-09-21 15:49:36 +00:00
window->id = meta_display_generate_window_id (display);
core: Trace various window management actions https://gitlab.gnome.org/GNOME/mutter/merge_requests/765
2019-08-29 17:34:18 +00:00
meta_window_manage (window);
window: Manage after setting the OR special case properties
2014-07-10 21:08:14 +00:00
Adds support in src/core for tracking override redirect windows. The metacity core is now directly aware of override redirect windows. - They get MetaWindows like normal windows, so mutter no longer need to special case them. The net wm types applicable to override redirects are also recognised. - The original positioning/stacking semantics of metacity with respect to OR windows are maintained, but now it's easier to synchronize the stacking between the core and mutter. - mutter no longer needs to manualy track UnmapNotify, MapNotify, ReparentNotify, CreateNotify and DestroyNotify events; instead map, unmap, add and remove events can now be consistently delivered via the MetaCompositor callbacks.
2008-11-23 19:28:40 +00:00
if (!window->override_redirect)
window: Force updating icons when initially loading them Otherwise, Wayland windows will never get an icon.
2014-07-14 19:26:09 +00:00
meta_window_update_icon_now (window, TRUE);
Precompute groups to guarantee that meta_group_list_windows always returns 2003-06-04 Rob Adams <robadams@ucla.edu> Precompute groups to guarantee that meta_group_list_windows always returns the correct list of windows. See Bug #96973 * src/window.h: change cached_group variable to group * src/window.c (meta_window_new): change cached_group to group and call meta_window_compute_group * src/groups.c (meta_window_get_group): simply return window->group rather than computing it and returning window->cached_group (meta_window_compute_group): new function computes window->group. Designed to be called once from meta_window_new (remove_window_from_group): change cached_group to group (meta_window_group_leader_changed): call meta_window_compute_group instead of meta_window_get_group
2003-06-04 19:15:46 +00:00
...
2001-06-04 06:17:52 +00:00
if (window->initially_iconic)
{
...
2001-06-06 04:47:37 +00:00
/* WM_HINTS said minimized */
window->minimized = TRUE;
meta_verbose ("Window %s asked to start out minimized\n", window->desc);
...
2001-06-04 06:17:52 +00:00
}
...
2001-06-24 06:47:54 +00:00
if (existing_wm_state == IconicState)
{
/* WM_STATE said minimized */
window->minimized = TRUE;
meta_verbose ("Window %s had preexisting WM_STATE = IconicState, minimizing\n",
window->desc);
/* Assume window was previously placed, though perhaps it's
* been iconic its whole life, we have no way of knowing.
*/
window->placed = TRUE;
}
lengthen to 15 seconds 2002-11-30 Havoc Pennington <hp@pobox.com> * src/screen.c (STARTUP_TIMEOUT): lengthen to 15 seconds * src/util.c (utf8_fputs): hmm, return a value * src/screen.c (meta_screen_apply_startup_properties): new function to apply initial workspace based on startup sequence. * src/window.c (meta_window_new): load _NET_STARTUP_ID (meta_window_get_startup_id): new function * src/window-props.c (meta_display_init_window_prop_hooks): add hooks for _NET_STARTUP_ID * src/display.c (event_callback): send property events to groups. * src/xprops.c (meta_prop_get_values): make a type of INVALID mean to ignore that property (don't fetch its value). * src/group.c (meta_group_property_notify): new function * src/screen.c (set_supported_hint): support _NET_STARTUP_ID * src/display.c (meta_display_open): add _NET_STARTUP_ID to atoms we initialize * src/group-private.h: private header shared between group-props.c, group.c * src/group-props.h, src/group-props.c: new files to contain functions for retrieving group properties * src/window.c (meta_window_same_application): change this a bit to work with new definition of group * src/group.c (meta_window_get_group): always create a group for every window, using the window's own ID as group leader if required. * src/window.c (update_wm_hints): handle changes to group leader * src/group.c (meta_window_group_leader_changed): new function * src/display.h (struct _MetaDisplay): _NET_WM_WINDOW_TYPE_SPLASH, not SPLASHSCREEN. Reported by Gregory Merchan and Matthias Clasen. * src/screen.c (startup_sequence_timeout): when timing out a startup sequence, send a remove message, don't just time it out locally.
2002-12-01 03:58:04 +00:00
/* Apply any window attributes such as initial workspace
* based on startup notification
*/
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
meta_display_apply_startup_properties (window->display, window);
If a window is launched without any kind of launch timestamp, grab the 2007-11-09 Elijah Newren <newren gmail com> * src/window.c (meta_window_new_with_attrs): If a window is launched without any kind of launch timestamp, grab the current time and stash it away. When transients of that window are also launched without a timestamp, we can use the stashed timestamp from the parent. Fixes #488468. svn path=/trunk/; revision=3381
2007-11-09 20:41:45 +00:00
/* Try to get a "launch timestamp" for the window. If the window is
* a transient, we'd like to be able to get a last-usage timestamp
* from the parent window. If the window has no parent, there isn't
* much we can do...except record the current time so that any children
* can use this time as a fallback.
*/
Don't read most properties for override-redirect windows Skipping handling of properties for override redirect windows has two advantages: first it reduces the amount of work needed to get an override-redirect window (menu, tooltip, drag icon) onto the screen. But more importantly, it reduces the number of code-paths for an override-redirect to get into some code portion where it isn't expected. * Integrate the list of properties we load initially with the list of property hooks; this avoids having two separate lists that we have to keep in sync. * Add a flag to MetaWindowPropHooks to indicate whether the property should be handled for override-redirect windows; currently we load a) properties that identify the window - useful for debugging purposes b) WM_TRANSIENT_FOR (could be used to associate menus with toplevels.) * For properties that aren't always loaded through window-props.c, add !window->override checks to places that trigger loading, and add g_return_if_fail(!window->override) to the load functions as a double-check. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:37:57 +00:00
if (!window->override_redirect && !window->net_wm_user_time_set) {
Lots of tiny fixes to make sure we compile with "gcc -ansi -Werror". 2008-02-27 Thomas Thurman <tthurman@gnome.org> Lots of tiny fixes to make sure we compile with "gcc -ansi -Werror". svn path=/trunk/; revision=3606
2008-02-27 04:39:10 +00:00
/* First, maybe the app was launched with startup notification using an
* obsolete version of the spec; use that timestamp if it exists.
*/
If a window is launched without any kind of launch timestamp, grab the 2007-11-09 Elijah Newren <newren gmail com> * src/window.c (meta_window_new_with_attrs): If a window is launched without any kind of launch timestamp, grab the current time and stash it away. When transients of that window are also launched without a timestamp, we can use the stashed timestamp from the parent. Fixes #488468. svn path=/trunk/; revision=3381
2007-11-09 20:41:45 +00:00
if (window->initial_timestamp_set)
Lots of tiny fixes to make sure we compile with "gcc -ansi -Werror". 2008-02-27 Thomas Thurman <tthurman@gnome.org> Lots of tiny fixes to make sure we compile with "gcc -ansi -Werror". svn path=/trunk/; revision=3606
2008-02-27 04:39:10 +00:00
/* NOTE: Do NOT toggle net_wm_user_time_set to true; this is just
* being recorded as a fallback for potential transients
*/
If a window is launched without any kind of launch timestamp, grab the 2007-11-09 Elijah Newren <newren gmail com> * src/window.c (meta_window_new_with_attrs): If a window is launched without any kind of launch timestamp, grab the current time and stash it away. When transients of that window are also launched without a timestamp, we can use the stashed timestamp from the parent. Fixes #488468. svn path=/trunk/; revision=3381
2007-11-09 20:41:45 +00:00
window->net_wm_user_time = window->initial_timestamp;
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
else if (window->transient_for != NULL)
meta_window_set_user_time (window, window->transient_for->net_wm_user_time);
If a window is launched without any kind of launch timestamp, grab the 2007-11-09 Elijah Newren <newren gmail com> * src/window.c (meta_window_new_with_attrs): If a window is launched without any kind of launch timestamp, grab the current time and stash it away. When transients of that window are also launched without a timestamp, we can use the stashed timestamp from the parent. Fixes #488468. svn path=/trunk/; revision=3381
2007-11-09 20:41:45 +00:00
else
Lots of tiny fixes to make sure we compile with "gcc -ansi -Werror". 2008-02-27 Thomas Thurman <tthurman@gnome.org> Lots of tiny fixes to make sure we compile with "gcc -ansi -Werror". svn path=/trunk/; revision=3606
2008-02-27 04:39:10 +00:00
/* NOTE: Do NOT toggle net_wm_user_time_set to true; this is just
* being recorded as a fallback for potential transients
*/
If a window is launched without any kind of launch timestamp, grab the 2007-11-09 Elijah Newren <newren gmail com> * src/window.c (meta_window_new_with_attrs): If a window is launched without any kind of launch timestamp, grab the current time and stash it away. When transients of that window are also launched without a timestamp, we can use the stashed timestamp from the parent. Fixes #488468. svn path=/trunk/; revision=3381
2007-11-09 20:41:45 +00:00
window->net_wm_user_time =
meta_display_get_current_time_roundtrip (window->display);
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window: make determination of attached dialog windows more consistent Different bits of code were using slightly different checks to test whether a window was an attached dialog. Add a new meta_window_is_attached_dialog(), and use that everywhere. Also, freeze the is-attached status when the window is first shown, rather than recomputing it each time the caller asks, since this could cause problems if a window changes its type after it has already been attached, etc. However, if an attached window's parent is destroyed, or an attached window changes its transient-for, then fix things up by destroying the old MetaWindow and creating a new one (causing compositor unmap and map events to be fired off, allowing the display of the window to be fixed up). Remove some code in display.c that tried to fix existing windows if the gconf setting changed, but which didn't actually do anything (at least under gnome-shell). However, if 654643 was fixed then the new behavior with this patch would be that changing the gconf setting would affect new dialogs, but not existing ones. https://bugzilla.gnome.org/show_bug.cgi?id=646761
2011-04-05 14:14:52 +00:00
window->attached = meta_window_should_attach_to_parent (window);
if (window->attached)
window: Fix build The proper function name is "meta_window_recalc_features"
2014-02-01 23:58:58 +00:00
meta_window_recalc_features (window);
window: make determination of attached dialog windows more consistent Different bits of code were using slightly different checks to test whether a window was an attached dialog. Add a new meta_window_is_attached_dialog(), and use that everywhere. Also, freeze the is-attached status when the window is first shown, rather than recomputing it each time the caller asks, since this could cause problems if a window changes its type after it has already been attached, etc. However, if an attached window's parent is destroyed, or an attached window changes its transient-for, then fix things up by destroying the old MetaWindow and creating a new one (causing compositor unmap and map events to be fired off, allowing the display of the window to be fixed up). Remove some code in display.c that tried to fix existing windows if the gconf setting changed, but which didn't actually do anything (at least under gnome-shell). However, if 654643 was fixed then the new behavior with this patch would be that changing the gconf setting would affect new dialogs, but not existing ones. https://bugzilla.gnome.org/show_bug.cgi?id=646761
2011-04-05 14:14:52 +00:00
set on_all_workspaces in all cases _before_ adding to the workspaces, so 2003-12-13 Rob Adams <readams@readams.net> * src/window.c (meta_window_new_with_attrs): set on_all_workspaces in all cases _before_ adding to the workspaces, so that windows initially on all workspaces are added correctly to the MRU lists. Fix for #120907. * src/workspace.c (meta_workspace_add_window): handle sticky windows so that we add to add mru lists if needed (meta_workspace_remove_window): handle sticky windows so that they are removed from all mru lists if needed.
2003-12-14 19:19:40 +00:00
if (window->type == META_WINDOW_DESKTOP ||
Split out on_all_workspaces and on_all_workspaces_requested Sometimes on_all_workspaces is requested by the client/user, and sometimes its calculated implicitly due to internal state. We split this up so that we know when the user has explicitly asked for sticky window, when e.g. setting wmspec properties or storing session info. on_all_workspaces means this window is visible on all workspaces. on_all_workspaces_requested, means the user explicitly made the window sticky somehow (via imported session, _NET_WM_STATE from another wm, toggled in the window menu, etc). It always implies on_all_workspaces is TRUE. Right now the only time we set on_all_workspaces is for override-redirect windows, but later we can add a "windows on non-primary monitor are not part of the workspace switching" feature. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 10:41:23 +00:00
window->type == META_WINDOW_DOCK)
set on_all_workspaces in all cases _before_ adding to the workspaces, so 2003-12-13 Rob Adams <readams@readams.net> * src/window.c (meta_window_new_with_attrs): set on_all_workspaces in all cases _before_ adding to the workspaces, so that windows initially on all workspaces are added correctly to the MRU lists. Fix for #120907. * src/workspace.c (meta_workspace_add_window): handle sticky windows so that we add to add mru lists if needed (meta_workspace_remove_window): handle sticky windows so that they are removed from all mru lists if needed.
2003-12-14 19:19:40 +00:00
{
/* Change the default, but don't enforce this if the user
* focuses the dock/desktop and unsticks it using key shortcuts.
* Need to set this before adding to the workspaces so the MRU
* lists will be updated.
*/
Split out on_all_workspaces and on_all_workspaces_requested Sometimes on_all_workspaces is requested by the client/user, and sometimes its calculated implicitly due to internal state. We split this up so that we know when the user has explicitly asked for sticky window, when e.g. setting wmspec properties or storing session info. on_all_workspaces means this window is visible on all workspaces. on_all_workspaces_requested, means the user explicitly made the window sticky somehow (via imported session, _NET_WM_STATE from another wm, toggled in the window menu, etc). It always implies on_all_workspaces is TRUE. Right now the only time we set on_all_workspaces is for override-redirect windows, but later we can add a "windows on non-primary monitor are not part of the workspace switching" feature. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 10:41:23 +00:00
window->on_all_workspaces_requested = TRUE;
set on_all_workspaces in all cases _before_ adding to the workspaces, so 2003-12-13 Rob Adams <readams@readams.net> * src/window.c (meta_window_new_with_attrs): set on_all_workspaces in all cases _before_ adding to the workspaces, so that windows initially on all workspaces are added correctly to the MRU lists. Fix for #120907. * src/workspace.c (meta_workspace_add_window): handle sticky windows so that we add to add mru lists if needed (meta_workspace_remove_window): handle sticky windows so that they are removed from all mru lists if needed.
2003-12-14 19:19:40 +00:00
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Split out on_all_workspaces and on_all_workspaces_requested Sometimes on_all_workspaces is requested by the client/user, and sometimes its calculated implicitly due to internal state. We split this up so that we know when the user has explicitly asked for sticky window, when e.g. setting wmspec properties or storing session info. on_all_workspaces means this window is visible on all workspaces. on_all_workspaces_requested, means the user explicitly made the window sticky somehow (via imported session, _NET_WM_STATE from another wm, toggled in the window menu, etc). It always implies on_all_workspaces is TRUE. Right now the only time we set on_all_workspaces is for override-redirect windows, but later we can add a "windows on non-primary monitor are not part of the workspace switching" feature. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 10:41:23 +00:00
window->on_all_workspaces = should_be_on_all_workspaces (window);
...
2001-06-24 06:47:54 +00:00
/* For the workspace, first honor hints,
* if that fails put transients with parents,
* otherwise put window on active space
*/
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-06-24 06:47:54 +00:00
if (window->initial_workspace_set)
{
window: Be more careful when setting initial workspace state A window may either be sticky because it has been requested as such, or because it is placed on a non-primary monitor (and the corresponding preference is set). While we do take the latter into account, we currently override the sticky state later during initialization; be a bit more careful there to get the initial state right. https://bugzilla.gnome.org/show_bug.cgi?id=737178
2014-09-25 10:46:16 +00:00
gboolean on_all_workspaces = window->on_all_workspaces;
MetaWorkspace *workspace = NULL;
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
disable custom log handler and fatal mask for now 2002-02-06 Havoc Pennington <hp@pobox.com> * src/main.c (main): disable custom log handler and fatal mask for now * src/theme.c (meta_draw_op_list_draw): Add META_DRAW_CLIP * src/main.c: load theme, monitor current theme setting * src/prefs.c: add "current theme" setting * src/stack.c (meta_stack_free): don't try to free last_root_children_stacked if it doesn't exist * src/themewidget.c: pluggable GtkMisc subclass to use for menu icons * src/screen.c (meta_screen_manage_all_windows): fix signed/unsigned warning * src/frames.c: port to theme system (meta_frames_style_set): chain up * theme-format.txt: new file * configure.in: add more compiler warnings * src/theme.c: add various stuff needed to get theme parser working. Remove the "spacer" concept from FrameLayout object. Add draw op that references a draw op list. * configure.in: require GTK 1.3.13 * src/Makefile.am: add theme-parser.[hc], implement loading a theme * src/theme.c: add "draw title" and "draw window icon" operations (meta_draw_op_draw): put object_width/object_height in expression environment before computing x/y. Handle out-of-memory when creating pixbufs. Assorted other cleanups.
2002-02-07 03:07:56 +00:00
if (window->initial_workspace == (int) 0xFFFFFFFF)
support initial on-all-workspaces setting 2001-10-24 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_new): support initial on-all-workspaces setting
2001-10-25 01:39:36 +00:00
{
improve debug spew about initial workspace 2002-03-03 Havoc Pennington <hp@pobox.com> * src/window.c: improve debug spew about initial workspace
2002-03-04 04:54:46 +00:00
meta_topic (META_DEBUG_PLACEMENT,
"Window %s is initially on all spaces\n",
window->desc);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
set on_all_workspaces in all cases _before_ adding to the workspaces, so 2003-12-13 Rob Adams <readams@readams.net> * src/window.c (meta_window_new_with_attrs): set on_all_workspaces in all cases _before_ adding to the workspaces, so that windows initially on all workspaces are added correctly to the MRU lists. Fix for #120907. * src/workspace.c (meta_workspace_add_window): handle sticky windows so that we add to add mru lists if needed (meta_workspace_remove_window): handle sticky windows so that they are removed from all mru lists if needed.
2003-12-14 19:19:40 +00:00
/* need to set on_all_workspaces first so that it will be
* added to all the MRU lists
*/
Split out on_all_workspaces and on_all_workspaces_requested Sometimes on_all_workspaces is requested by the client/user, and sometimes its calculated implicitly due to internal state. We split this up so that we know when the user has explicitly asked for sticky window, when e.g. setting wmspec properties or storing session info. on_all_workspaces means this window is visible on all workspaces. on_all_workspaces_requested, means the user explicitly made the window sticky somehow (via imported session, _NET_WM_STATE from another wm, toggled in the window menu, etc). It always implies on_all_workspaces is TRUE. Right now the only time we set on_all_workspaces is for override-redirect windows, but later we can add a "windows on non-primary monitor are not part of the workspace switching" feature. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 10:41:23 +00:00
window->on_all_workspaces_requested = TRUE;
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
on_all_workspaces = TRUE;
support initial on-all-workspaces setting 2001-10-24 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_new): support initial on-all-workspaces setting
2001-10-25 01:39:36 +00:00
}
window: Be more careful when setting initial workspace state A window may either be sticky because it has been requested as such, or because it is placed on a non-primary monitor (and the corresponding preference is set). While we do take the latter into account, we currently override the sticky state later during initialization; be a bit more careful there to get the initial state right. https://bugzilla.gnome.org/show_bug.cgi?id=737178
2014-09-25 10:46:16 +00:00
else if (!on_all_workspaces)
support initial on-all-workspaces setting 2001-10-24 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_new): support initial on-all-workspaces setting
2001-10-25 01:39:36 +00:00
{
improve debug spew about initial workspace 2002-03-03 Havoc Pennington <hp@pobox.com> * src/window.c: improve debug spew about initial workspace
2002-03-04 04:54:46 +00:00
meta_topic (META_DEBUG_PLACEMENT,
"Window %s is initially on space %d\n",
window->desc, window->initial_workspace);
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
workspace = meta_workspace_manager_get_workspace_by_index (workspace_manager,
window->initial_workspace);
support initial on-all-workspaces setting 2001-10-24 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_new): support initial on-all-workspaces setting
2001-10-25 01:39:36 +00:00
}
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
window: Ignore requests to be placed on non-existent workspaces When an X11 window requests an initial workspace, we currently trust it that the workspace actually exists. However dynamic workspaces make this easy to get wrong for applications: They make it likely for the number of workspaces to change between application starts, and if the app blindly applies its saved state on startup, it will trigger an assertion. Make sure that we pass valid parameters to set_workspace_state(), and simply let the workspace assignment fall through to the default handling otherwise. https://gitlab.gnome.org/GNOME/mutter/issues/1029
2020-02-03 21:58:38 +00:00
/* Ignore when a window requests to be placed on a non-existent workspace
*/
if (on_all_workspaces || workspace != NULL)
set_workspace_state (window, on_all_workspaces, workspace);
...
2001-06-24 06:47:54 +00:00
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Don't add override-redirect windows to workspaces Normally a window that is "on all workspaces", is also on a particular workspace (to deal with being unstuck.) This is pointless for override-redirect windows. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-15 22:02:32 +00:00
/* override-redirect windows are subtly different from other windows
* with window->on_all_workspaces == TRUE. Other windows are part of
* some workspace (so they can return to that if the flag is turned off),
* but appear on other workspaces. override-redirect windows are part
* of no workspace.
*/
window: Fix another case of uninitialized workspace state Since commit 2eec11b4453e, windows without a __NET_WM_DESKTOP property that should be on all workspaces are not added to the active workspace; this is correct, however not adding them to any workspace is not ...
2014-09-26 10:39:31 +00:00
if (!window->override_redirect && window->workspace == NULL)
...
2001-06-24 06:47:54 +00:00
{
window: Fix another case of uninitialized workspace state Since commit 2eec11b4453e, windows without a __NET_WM_DESKTOP property that should be on all workspaces are not added to the active workspace; this is correct, however not adding them to any workspace is not ...
2014-09-26 10:39:31 +00:00
if (window->transient_for != NULL)
Don't add override-redirect windows to workspaces Normally a window that is "on all workspaces", is also on a particular workspace (to deal with being unstuck.) This is pointless for override-redirect windows. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-15 22:02:32 +00:00
{
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
meta_topic (META_DEBUG_PLACEMENT,
"Putting window %s on same workspace as parent %s\n",
window->desc, window->transient_for->desc);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window: Warn if O-R window workspace state is used Override-redirect windows have no workspace by default, and can't be parent of a top-level window, so we must check that the parent window is not an O-R one when setting the workspace state. https://gitlab.gnome.org/GNOME/mutter/merge_requests/895
2019-10-29 16:48:00 +00:00
g_warn_if_fail (!window->transient_for->override_redirect);
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
set_workspace_state (window,
core: propagate the effective on-all-workspaces setting to transient window Commit 09bab98b1e tried to avoid several workspace changes while in window construction, but it missed a case: If we have a window on a secondary monitor with no workspaces enabled (so it implicitly gets on_all_workspaces = TRUE without requesting it) and trigger the creation of a second window that has the first as transient-for, it would first try to set the first workspace than the transient-for window and then fallback to all/current workspace. After that commit we only try to set the same workspace than the transient-for window, but it gets none as neither is on a single workspace, nor did really request to be on all workspaces. Fixes crashes when opening transient X11 dialogs in the secondary monitor. https://gitlab.gnome.org/GNOME/mutter/merge_requests/714
2019-08-05 16:29:54 +00:00
should_be_on_all_workspaces (window->transient_for),
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
window->transient_for->workspace);
...
2001-06-24 06:47:54 +00:00
}
core: Avoid consecutive workspace changes in window construction We first set the workspace to the transient-for parent's, and then try to set on the current workspace. If both happen, we double the work on adding/removing it from the workspace, and everything that happens in result. Should reduce some activity while typing on the Epiphany address bar, as the animation results in a number of xdg_popup being created and destroyed to handle the animation. https://gitlab.gnome.org/GNOME/mutter/issues/556
2019-07-19 15:48:42 +00:00
else if (window->on_all_workspaces)
window: Fix another case of uninitialized workspace state Since commit 2eec11b4453e, windows without a __NET_WM_DESKTOP property that should be on all workspaces are not added to the active workspace; this is correct, however not adding them to any workspace is not ...
2014-09-26 10:39:31 +00:00
{
meta_topic (META_DEBUG_PLACEMENT,
"Putting window %s on all workspaces\n",
window->desc);
set_workspace_state (window, TRUE, NULL);
}
else
Don't add override-redirect windows to workspaces Normally a window that is "on all workspaces", is also on a particular workspace (to deal with being unstuck.) This is pointless for override-redirect windows. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-15 22:02:32 +00:00
{
meta_topic (META_DEBUG_PLACEMENT,
"Putting window %s on active workspace\n",
window->desc);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
set_workspace_state (window, FALSE, workspace_manager->active_workspace);
Don't add override-redirect windows to workspaces Normally a window that is "on all workspaces", is also on a particular workspace (to deal with being unstuck.) This is pointless for override-redirect windows. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-15 22:02:32 +00:00
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Don't read most properties for override-redirect windows Skipping handling of properties for override redirect windows has two advantages: first it reduces the amount of work needed to get an override-redirect window (menu, tooltip, drag icon) onto the screen. But more importantly, it reduces the number of code-paths for an override-redirect to get into some code portion where it isn't expected. * Integrate the list of properties we load initially with the list of property hooks; this avoids having two separate lists that we have to keep in sync. * Add a flag to MetaWindowPropHooks to indicate whether the property should be handled for override-redirect windows; currently we load a) properties that identify the window - useful for debugging purposes b) WM_TRANSIENT_FOR (could be used to associate menus with toplevels.) * For properties that aren't always loaded through window-props.c, add !window->override checks to places that trigger loading, and add g_return_if_fail(!window->override) to the load functions as a double-check. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:37:57 +00:00
meta_window_update_struts (window);
}
Implements support for _NET_WM_ALLOWED_ACTIONS. Fixes #84282. 2002-08-01 Mark McLoughlin <mark@skynet.ie> Implements support for _NET_WM_ALLOWED_ACTIONS. Fixes #84282. * src/display.[ch]: (meta_display_open): add _NET_WM_ALLOWED_ACTIONS atoms. * src/screen.c: (set_supported_hint): set them as being supported. * src/window.c: (set_allowed_actions_hint): impl setting _NET_WM_ALLOWED_ACTIONS. (recalc_window_features): use it here, but only if things have changed.
2002-08-01 23:52:47 +00:00
wayland: Sync surface actor state when changing main monitor In order to switch to the correct surface actor scale given the monitor the surface is on, without relying on the client committing a new state given some other side effect, sync the surface actor state when the main monitor associated with the corresponding window changed. https://bugzilla.gnome.org/show_bug.cgi?id=744933
2015-03-03 03:13:05 +00:00
meta_window_main_monitor_changed (window, NULL);
Add signals for when windows change monitors This is useful in order to track e.g. which windows are on the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 20:26:11 +00:00
Fix several bugs with handling of fullscreen windows, causing them to not 2006-08-21 Elijah Newren <newren gmail com> Fix several bugs with handling of fullscreen windows, causing them to not actually be fullscreen. #343115 (and also #346927, #350547, #351643, the recent additional WINE-related issue mentioned on the mailing list, and probably others...) * src/constraints.c (setup_constraint_info): if a window tries to resize to fullscreen-size and it has a fullscreen function but isn't actually marked as fullscreen then assist it by marking it as such, (constrain_fully_onscreen, constrain_titlebar_visible): ignore this constraint for fullscreen windows since such windows have a separate specialized constraint * src/stack.c (window_is_fullscreen_size, get_standalone_layer): remove the old window_is_fullscreen_size() hack for detecting windows to treat as fullscreen since it doesn't work well with the new constraints framework (i.e. we needed a slightly different hack) * src/window.[ch] (meta_window_new_with_addrs): shuffle the order of adding the window to the stack and moveresizing the window since moveresizing can cause stack changes if the window's initial size is fullscreen size, (meta_window_make_fullscreen, meta_window_make_fullscreen_internal): split meta_window_make_fullscreen() similar to meta_window_maximize() so that constraints can make use of it
2006-08-21 18:08:05 +00:00
/* Must add window to stack before doing move/resize, since the
* window might have fullscreen size (i.e. should have been
* fullscreen'd; acrobat is one such braindead case; it withdraws
* and remaps its window whenever trying to become fullscreen...)
* and thus constraints may try to auto-fullscreen it which also
* means restacking it.
*/
window: Defer stack placement without a buffer When closing a window and showing a new one, the new one may not be granted input focus until it gets a buffer on Wayland. If another window is chosen to receive focus and raised on top of stack, the newly mapped window is focused but placed underneath that other window. Meaning that for Wayland surfaces, we need to defer adding the window to the stack until we actually get to show it, once we have a buffer attached. Rather that checking the windowing backend prior to decide if a window is stackable or not, introduce a new vfunc is_stackable() which tells if a window should be added to the stack regardless of the underlying windowing system. Also add meta_window_is_in_stack() API rather than checking the stack position directly (replacing the define WINDOW_IN_STACK only available in stack.c) and remove a window from the stack only if it is present in the stack, so that the test in meta_stack_remote() becomes irrelevant. https://bugzilla.gnome.org/show_bug.cgi?id=780820
2018-01-09 12:19:40 +00:00
if (meta_window_is_stackable (window))
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_add (window->display->stack,
Don't do stacking for override-redirect windows Don't add override-redirect windows to MetaStack; we shouldn't be restacking them. Since we *aren't* stacking the override-redirect windows, we need to be careful that to ignore them when looking for the top managed window. http://bugzilla.gnome.org/show_bug.cgi?id=585984
2009-06-15 18:31:04 +00:00
window);
window: Defer stack placement without a buffer When closing a window and showing a new one, the new one may not be granted input focus until it gets a buffer on Wayland. If another window is chosen to receive focus and raised on top of stack, the newly mapped window is focused but placed underneath that other window. Meaning that for Wayland surfaces, we need to defer adding the window to the stack until we actually get to show it, once we have a buffer attached. Rather that checking the windowing backend prior to decide if a window is stackable or not, introduce a new vfunc is_stackable() which tells if a window should be added to the stack regardless of the underlying windowing system. Also add meta_window_is_in_stack() API rather than checking the stack position directly (replacing the define WINDOW_IN_STACK only available in stack.c) and remove a window from the stack only if it is present in the stack, so that the test in meta_stack_remote() becomes irrelevant. https://bugzilla.gnome.org/show_bug.cgi?id=780820
2018-01-09 12:19:40 +00:00
else if (window->override_redirect)
Don't do stacking for override-redirect windows Don't add override-redirect windows to MetaStack; we shouldn't be restacking them. Since we *aren't* stacking the override-redirect windows, we need to be careful that to ignore them when looking for the top managed window. http://bugzilla.gnome.org/show_bug.cgi?id=585984
2009-06-15 18:31:04 +00:00
window->layer = META_LAYER_OVERRIDE_REDIRECT; /* otherwise set by MetaStack */
Fix several bugs with handling of fullscreen windows, causing them to not 2006-08-21 Elijah Newren <newren gmail com> Fix several bugs with handling of fullscreen windows, causing them to not actually be fullscreen. #343115 (and also #346927, #350547, #351643, the recent additional WINE-related issue mentioned on the mailing list, and probably others...) * src/constraints.c (setup_constraint_info): if a window tries to resize to fullscreen-size and it has a fullscreen function but isn't actually marked as fullscreen then assist it by marking it as such, (constrain_fully_onscreen, constrain_titlebar_visible): ignore this constraint for fullscreen windows since such windows have a separate specialized constraint * src/stack.c (window_is_fullscreen_size, get_standalone_layer): remove the old window_is_fullscreen_size() hack for detecting windows to treat as fullscreen since it doesn't work well with the new constraints framework (i.e. we needed a slightly different hack) * src/window.[ch] (meta_window_new_with_addrs): shuffle the order of adding the window to the stack and moveresizing the window since moveresizing can cause stack changes if the window's initial size is fullscreen size, (meta_window_make_fullscreen, meta_window_make_fullscreen_internal): split meta_window_make_fullscreen() similar to meta_window_maximize() so that constraints can make use of it
2006-08-21 18:08:05 +00:00
Adds support in src/core for tracking override redirect windows. The metacity core is now directly aware of override redirect windows. - They get MetaWindows like normal windows, so mutter no longer need to special case them. The net wm types applicable to override redirects are also recognised. - The original positioning/stacking semantics of metacity with respect to OR windows are maintained, but now it's easier to synchronize the stacking between the core and mutter. - mutter no longer needs to manualy track UnmapNotify, MapNotify, ReparentNotify, CreateNotify and DestroyNotify events; instead map, unmap, add and remove events can now be consistently delivered via the MetaCompositor callbacks.
2008-11-23 19:28:40 +00:00
if (!window->override_redirect)
{
/* FIXME we have a tendency to set this then immediately
* change it again.
*/
window: Centralize WM_STATE management
2014-02-02 00:03:33 +00:00
set_wm_state (window);
Adds support in src/core for tracking override redirect windows. The metacity core is now directly aware of override redirect windows. - They get MetaWindows like normal windows, so mutter no longer need to special case them. The net wm types applicable to override redirects are also recognised. - The original positioning/stacking semantics of metacity with respect to OR windows are maintained, but now it's easier to synchronize the stacking between the core and mutter. - mutter no longer needs to manualy track UnmapNotify, MapNotify, ReparentNotify, CreateNotify and DestroyNotify events; instead map, unmap, add and remove events can now be consistently delivered via the MetaCompositor callbacks.
2008-11-23 19:28:40 +00:00
set_net_wm_state (window);
}
set the window state hints _after_ applying session information. Fixes 2005-01-25 Elijah Newren <newren@gmail.com> * src/window.c: (meta_window_new_with_attrs): set the window state hints _after_ applying session information. Fixes #164677.
2005-01-26 02:47:49 +00:00
Stop using MetaScreen where it is unnecessary https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:43:17 +00:00
meta_compositor_add_window (window->display->compositor, window);
window: Track known_to_compositor and visible_to_compositor separately Really, visible_to_compositor means that the window is shown, e.g. not minimized. We need to be using a boolean tracking whether we've called meta_compositor_add_window / meta_compositor_remove_window. This fixes a jump during window placement when a window appears.
2014-03-28 17:50:45 +00:00
window->known_to_compositor = TRUE;
Revert "compositor: Delay meta_compositor_add_window until the first show" This reverts commit 4efe4483fbc7602e8358fda936074216a8e5544b.
2014-02-24 17:56:30 +00:00
...
2001-06-11 03:24:20 +00:00
/* Sync stack changes */
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_thaw (window->display->stack);
include locale.h, fix from Hidetoshi Tajima 2002-05-11 Havoc Pennington <hp@pobox.com> * src/main.c: include locale.h, fix from Hidetoshi Tajima * src/window.c (meta_window_new): disable show desktop mode when a new window is managed.
2002-05-11 05:47:04 +00:00
Move compositor-stack handling to MetaStackTracker In order to properly track the stacking order for override-redirect windows, move meta_compositor_sync_stack() call into MetaStackTracker. In the new location, we sync the stack as a before-redraw idle function, rather then using the freeze-thaw facilities of MetaStack. This is simpler, and also properly compresses multiple stack changes on notifications received from the X server. http://bugzilla.gnome.org/show_bug.cgi?id=585984
2009-06-14 12:04:28 +00:00
/* Usually the we'll have queued a stack sync anyways, because we've
* added a new frame window or restacked. But if an undecorated
* window is mapped, already stacked in the right place, then we
* might need to do this explicitly.
*/
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_tracker_queue_sync_stack (window->display->stack_tracker);
Move compositor-stack handling to MetaStackTracker In order to properly track the stacking order for override-redirect windows, move meta_compositor_sync_stack() call into MetaStackTracker. In the new location, we sync the stack as a before-redraw idle function, rather then using the freeze-thaw facilities of MetaStack. This is simpler, and also properly compresses multiple stack changes on notifications received from the X server. http://bugzilla.gnome.org/show_bug.cgi?id=585984
2009-06-14 12:04:28 +00:00
include locale.h, fix from Hidetoshi Tajima 2002-05-11 Havoc Pennington <hp@pobox.com> * src/main.c: include locale.h, fix from Hidetoshi Tajima * src/window.c (meta_window_new): disable show desktop mode when a new window is managed.
2002-05-11 05:47:04 +00:00
/* disable show desktop mode unless we're a desktop component */
fill in window->desc sooner since we use it sooner now. 2003-05-16 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new): fill in window->desc sooner since we use it sooner now. * src/display.c (meta_display_open): init display->grab_update_alarm * src/window.c (meta_window_new): initialize the always_sticky field (meta_window_new): initialize the update_icon_queued field Patch from Julien Olivier bug #92335 for converting "show desktop mode" to "all windows are minimized" when you open a new window, instead of just mapping all the windows again. * src/window.c (meta_window_activate): minimize all windows before coming out of show desktop mode. (meta_window_unminimize): don't toggle show desktop mode here * src/screen.c (meta_screen_minimize_all_except): new function
2003-05-16 21:59:08 +00:00
maybe_leave_show_desktop_mode (window);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
meta_window_queue (window, META_QUEUE_CALC_SHOWING);
put all transients of the new window, if any exist, in the calc_showing 2005-05-26 Elijah Newren <newren@gmail.com> * src/window.c: (meta_window_new_with_attrs): put all transients of the new window, if any exist, in the calc_showing queue. Fixes #303284.
2005-05-26 17:15:56 +00:00
/* See bug 303284; a transient of the given window can already exist, in which
* case we think it should probably be shown.
*/
meta_window_foreach_transient (window,
queue_calc_showing_func,
NULL);
Patch from Carlo Wood to ensure that maximized and minimized properties 2006-10-01 Elijah Newren <newren gmail com> Patch from Carlo Wood to ensure that maximized and minimized properties are maintained across restarts. #358042. * src/constraints.c (place_window_if_needed): fix up partial maximization handling and add minimize_after_placement handling. * src/display.[ch] (struct MetaDisplay, meta_display_open): add a new display->display_opening flag to allow handling startup differently where needed. * src/window-props.c (reload_net_wm_state): handle _net_wm_state_hidden as well, setting window->minimize_after_placement appropriately * src/window.[ch] (struct MetaWindow, meta_window_new_with_attrs): add a window->minimize_after_placement field * src/window.c (meta_window_new_with_attrs): only unminimize the window and its transients if the display isn't being opened, (unmaximize_window_before_freeing): don't reset the state unless the window is becoming withdrawn, if the screen is being closed be sure to save the unmaximized state of the window so the next window manager can restore it
2006-10-01 21:59:09 +00:00
/* See bug 334899; the window may have minimized ancestors
* which need to be shown.
*
* However, we shouldn't unminimize windows here when opening
* a new display because that breaks passing _NET_WM_STATE_HIDDEN
* between window managers when replacing them; see bug 358042.
Don't immediately unminimize an initially iconic window (#491090) 2008-03-28 Owen Taylor <otaylor@redhat.com> * src/core/window.c (meta_window_new_with_attrs): Don't immediately unminimize an initially iconic window (#491090) svn path=/trunk/; revision=3667
2008-03-28 18:44:59 +00:00
*
* And we shouldn't unminimize windows if they were initially
* iconic.
Patch from Dan Sanders to fix #334899. 2006-04-16 Elijah Newren <newren gmail com> Patch from Dan Sanders to fix #334899. * window.c (meta_window_new_with_attrs): Unminimize ancestors of new windows when mapped; this prevents e.g. confirmation windows from causing applications to appear locked when closing via the window list.
2006-04-17 03:54:49 +00:00
*/
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
if (!window->override_redirect &&
!display->display_opening &&
!window->initially_iconic)
Patch from Carlo Wood to ensure that maximized and minimized properties 2006-10-01 Elijah Newren <newren gmail com> Patch from Carlo Wood to ensure that maximized and minimized properties are maintained across restarts. #358042. * src/constraints.c (place_window_if_needed): fix up partial maximization handling and add minimize_after_placement handling. * src/display.[ch] (struct MetaDisplay, meta_display_open): add a new display->display_opening flag to allow handling startup differently where needed. * src/window-props.c (reload_net_wm_state): handle _net_wm_state_hidden as well, setting window->minimize_after_placement appropriately * src/window.[ch] (struct MetaWindow, meta_window_new_with_attrs): add a window->minimize_after_placement field * src/window.c (meta_window_new_with_attrs): only unminimize the window and its transients if the display isn't being opened, (unmaximize_window_before_freeing): don't reset the state unless the window is becoming withdrawn, if the screen is being closed be sure to save the unmaximized state of the window so the next window manager can restore it
2006-10-01 21:59:09 +00:00
unminimize_window_and_all_transient_parents (window);
Optimizations for managing new windows (do not all take effect if 2002-10-21 Havoc Pennington <hp@redhat.com> Optimizations for managing new windows (do not all take effect if METACITY_DEBUG=1). Bug #96404 * src/keybindings.c (meta_change_keygrab): use error trap nesting and conditionalize on meta_is_verbose() to avoid a ton of XSync * src/display.c (meta_change_button_grab): ditto Throughout: move to new error trap setup to save on XSync calls, new setup is: * src/errors.c (meta_error_trap_push_with_return): new function, an error trap that needs to care about return value and thus sync even if an outer trap still exists (meta_error_trap_pop_with_return): new function (meta_error_trap_pop): add "last_request_was_roundtrip" argument allowing us to avoid XSync() if we just did a GetProperty or whatever. * src/util.c (meta_warning): flush the warning file descriptor * src/Makefile.am (INCLUDES): define G_LOG_DOMAIN
2002-10-21 21:44:35 +00:00
deleted and moved into window-props.c (meta_window_new_with_attrs): added 2006-03-25 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (update_net_wm_state, update_mwm_hints, update_wm_class, update_transient_for): deleted and moved into window-props.c (meta_window_new_with_attrs): added constructing field and four new initial properties (as above) (meta_window_recalc_features, meta_window_recalc_window_type): new functions * src/window-props.c (init_net_wm_state, reload_net_wm_state init_mwm_hints, reload_mwm_hints, init_wm_class, reload_mwm_class, init_transient_for, reload_transient_for): new functions, moved in from window.c (meta_display_init_window_prop_hooks): initialise new properties
2006-03-25 22:57:22 +00:00
window->constructing = FALSE;
Add "window-created" signal to MetaDisplay, "unmanaged" signal for MetaWindow For some consumers it's significantly more convenient to be able to directly connect to a signal on the Window to know when Mutter is done with it, rather than having to connect to each Workspace object (and handle workspace additions, etc.). Similarly, add window-created which acts globally. https://bugzilla.gnome.org/show_bug.cgi?id=598289
2009-10-13 14:34:34 +00:00
meta_display_notify_window_created (display, window);
[MetaDisplay] Added window-demands-attention signal Having a MetaDisplay::window-demands-attention signal allows to deal with windows demanding attention in a cetralized fashion. The signal is emitted when a window is created with initial demands-attention state and/or when the state changes later on. Based on original patch by Jon Nettleton. https://bugzilla.gnome.org/show_bug.cgi?id=597052
2009-10-28 17:19:24 +00:00
if (window->wm_state_demands_attention)
g_signal_emit_by_name (window->display, "window-demands-attention", window);
Reduce server grabs during window creation Remove some obvious server grabs from the window creation codepath, also ones that are taken at startup. During startup, there is no need to grab: we install the event handlers before querying for the already-existing windows, so there is no danger that we will 'lose' some window. We might try to create a window twice (if it comes back in the original query and then we get an event for it) but the code is already protected against such conditions. When windows are created later, we also do not need grabs, we just need appropriate error checking as the window may be destroyed at any time (or it may have already been destroyed). The stack tracker is unaffected here - as it listens to CreateNotify and DestroyNotify events and responds directly, the internal stack representation will always be consistent even if the window goes away while we are processing MapRequest or similar. Now that there are no grabs we don't have to worry about explicitly calling display_notify_window after grabs have been dropped. Fold that into meta_window_new_shared(). https://bugzilla.gnome.org/show_bug.cgi?id=721345
2013-12-30 19:01:28 +00:00
return window;
wayland: Adds basic hybrid X + Wayland support This adds support for running mutter as a hybrid X and Wayland compositor. It runs a headless XWayland server for X applications that presents wayland surfaces back to mutter which mutter can then composite. This aims to not break Mutter's existing support for the traditional X compositing model which means a single build of Mutter can be distributed supporting the traditional model and the new Wayland based compositing model. TODO: although building with --disable-wayland has at least been tested, I still haven't actually verified that running as a traditional compositor isn't broken currently. Note: At this point no input is supported Note: multiple authors have contributed to this patch: Authored-by: Robert Bragg <robert@linux.intel.com> Authored-by: Neil Roberts <neil@linux.intel.com> Authored-by: Rico Tzschichholz. Authored-by: Giovanni Campagna <gcampagna@src.gnome.org>
2012-01-07 22:21:32 +00:00
}
window: make determination of attached dialog windows more consistent Different bits of code were using slightly different checks to test whether a window was an attached dialog. Add a new meta_window_is_attached_dialog(), and use that everywhere. Also, freeze the is-attached status when the window is first shown, rather than recomputing it each time the caller asks, since this could cause problems if a window changes its type after it has already been attached, etc. However, if an attached window's parent is destroyed, or an attached window changes its transient-for, then fix things up by destroying the old MetaWindow and creating a new one (causing compositor unmap and map events to be fired off, allowing the display of the window to be fixed up). Remove some code in display.c that tried to fix existing windows if the gconf setting changed, but which didn't actually do anything (at least under gnome-shell). However, if 654643 was fixed then the new behavior with this patch would be that changing the gconf setting would affect new dialogs, but not existing ones. https://bugzilla.gnome.org/show_bug.cgi?id=646761
2011-04-05 14:14:52 +00:00
static gboolean
detach_foreach_func (MetaWindow *window,
void *data)
{
GList **children = data;
MetaWindow *parent;
if (window->attached)
{
/* Only return the immediate children of the window being unmanaged */
parent = meta_window_get_transient_for (window);
if (parent->unmanaging)
*children = g_list_prepend (*children, window);
}
return TRUE;
}
...
2001-05-30 15:36:31 +00:00
void
Make MetaWindow a GObject Make MetaWindow into a GObject so that it is accessible to gobject-introspection (also allows for signals to be added.) Renames: meta_window_free() => meta_window_unmanage() meta_window_get_type() => meta_window_get_window_type() meta_window_get_type_atom() => meta_window_get_window_type_atom()
2008-11-07 09:57:00 +00:00
meta_window_unmanage (MetaWindow *window,
guint32 timestamp)
...
2001-05-30 15:36:31 +00:00
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
...
2001-06-06 04:47:37 +00:00
GList *tmp;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window: Remove some superfluous uses of window->xwindow
2014-04-29 19:23:06 +00:00
meta_verbose ("Unmanaging %s\n", window->desc);
wayland: don't send notify when window is being unmanaged If we try to send notify event (either from surface_state_changed() or from meta_window_wayland_move_resize_internal()), we will crash, because we don't have a sufrace anymore. There's no reason why to resize the window that is being unmanaged anyway. https://bugzilla.gnome.org/show_bug.cgi?id=751847
2016-03-17 13:52:46 +00:00
window->unmanaging = TRUE;
...
2001-06-06 04:47:37 +00:00
cleanup: Use g_clear_handle_id() for g_source_remove() It makes sure we do not forget to zero the id and lets us avoid zero checks before. We use it for all new code, lets clean up the existing code base. https://gitlab.gnome.org/GNOME/mutter/merge_requests/947
2019-11-21 23:25:30 +00:00
g_clear_handle_id (&window->unmanage_idle_id, g_source_remove);
window: Unmanage rule placed window if ending up outside of parent If a client maps a persistent popup with a placement rule, then resizes the parent window so that the popup ends up outside of the parent, unmanage the popup and log a warning about the client being buggy. https://gitlab.gnome.org/GNOME/mutter/merge_requests/496
2018-10-18 14:24:18 +00:00
wayland: Move MetaWindow ownership to window owning roles There are two surface roles owning a MetaWindow: MetaWaylandShellSurface (basis of MetaWaylandXdgToplevel, MetaWaylandXdgPopup, MetaWaylandWlShellSurface, etc), and MetaXwaylandSurface. With these two role types, the MetaWindow has two different types of life times. With MetaWaylandShellSurface, the window is owned and managed by the role itself, while with MetaXwaylandSurface, the MetaWindow is tied to the X11 window, while the Wayland surface and its role plays more the role of the backing rendering surface. Before, for historical reasons, MetaWindow was part of MetaWaylandSurface, even though just some roles used it, and before 'wayland: Untie MetaWindowXwayland lifetime from the wl_surface' had equivalent life times as well. But since that commit, the management changed. To not have the same fied in MetaWaylandSurface being managed in such drastically different ways, rearrange it so that the roles that has a MetaWindow themself manages it in the way it is meant to; meaning MetaWaylandShellSurface practically owns it, while with Xwayland, the existance of a MetaWindow is tracked via X11. https://gitlab.gnome.org/GNOME/mutter/merge_requests/835
2019-10-09 07:57:40 +00:00
g_signal_emit (window, window_signals[UNMANAGING], 0);
window: free close dialog before unmanaging window from compositor When an application stops responding, the shell darkens its windows. If a window from a not-responding application gets unmanaged then the shell will currently throw an exception trying to retrieve the now-dissociated window actor. That leads to a "stuck window" ghost on screen and a traceback in the log. This commit addresses the problem by making sure the effect is cleaned up before the actor is disocciated from its window. https://gitlab.gnome.org/GNOME/mutter/issues/575
2019-04-29 17:46:37 +00:00
wayland: Move MetaWindow ownership to window owning roles There are two surface roles owning a MetaWindow: MetaWaylandShellSurface (basis of MetaWaylandXdgToplevel, MetaWaylandXdgPopup, MetaWaylandWlShellSurface, etc), and MetaXwaylandSurface. With these two role types, the MetaWindow has two different types of life times. With MetaWaylandShellSurface, the window is owned and managed by the role itself, while with MetaXwaylandSurface, the MetaWindow is tied to the X11 window, while the Wayland surface and its role plays more the role of the backing rendering surface. Before, for historical reasons, MetaWindow was part of MetaWaylandSurface, even though just some roles used it, and before 'wayland: Untie MetaWindowXwayland lifetime from the wl_surface' had equivalent life times as well. But since that commit, the management changed. To not have the same fied in MetaWaylandSurface being managed in such drastically different ways, rearrange it so that the roles that has a MetaWindow themself manages it in the way it is meant to; meaning MetaWaylandShellSurface practically owns it, while with Xwayland, the existance of a MetaWindow is tracked via X11. https://gitlab.gnome.org/GNOME/mutter/merge_requests/835
2019-10-09 07:57:40 +00:00
meta_window_free_delete_dialog (window);
wayland: Rework how surface destruction works To prevent the MetaSurfaceActor from being destroyed, we normally unparent it before we unmanage the window. However, this doesn't work for XWayland windows, which we unmanage when we get UnmapNotify or DestroyNotify, not when we get the wl_surface_destroy. To solve this, add an early hook in meta_window_unmanage that unparents the surface actor if we have one. At the same time, clean up the destruction code to remove old comments and assumptions about how wl_shell behaves.
2014-02-18 21:39:23 +00:00
Assume the compositor always exists At one point, it was supported to run mutter without a compositor, but we don't allow that any longer. A lot of code already assumes display->compositor exists and doesn't check for a NULL pointer, so just kill the rest of the checks.
2014-03-18 21:06:42 +00:00
if (window->visible_to_compositor)
window: Ensure that visible_to_compositor is set when unmanaging visible_to_compositor should always be in sync with show_window / hide_window calls, even when unmananging. This fixes a crash where we call sync_window_state when the window is unmanaging, since we use visible_to_compositor to determine whether the compositor will crash. This is actually wrong; we should be using the knowledge about whether we have called add_window / remove_window. We'll introduce this with a new boolean next time.
2014-03-28 17:51:34 +00:00
{
window->visible_to_compositor = FALSE;
meta_compositor_hide_window (window->display->compositor, window,
META_COMP_EFFECT_DESTROY);
}
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
Assume the compositor always exists At one point, it was supported to run mutter without a compositor, but we don't allow that any longer. A lot of code already assumes display->compositor exists and doesn't check for a NULL pointer, so just kill the rest of the checks.
2014-03-18 21:06:42 +00:00
meta_compositor_remove_window (window->display->compositor, window);
window: Track known_to_compositor and visible_to_compositor separately Really, visible_to_compositor means that the window is shown, e.g. not minimized. We need to be using a boolean tracking whether we've called meta_compositor_add_window / meta_compositor_remove_window. This fixes a jump during window placement when a window appears.
2014-03-28 17:50:45 +00:00
window->known_to_compositor = FALSE;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
give priority to keeping NW corner onscreen rather than SE, if we need to 2002-01-18 Havoc Pennington <hp@pobox.com> * src/window.c (constrain_position): give priority to keeping NW corner onscreen rather than SE, if we need to shift the window to fit inside constraints * src/frames.c (meta_frames_get_geometry): don't depend on the current window size * src/theme.c: move geometry stuff in here, to be calculated as part of the theme * src/core.c (meta_core_get_client_size): new function to replace meta_core_get_frame_size() so we don't have weird cycles in the geometry calculation
2002-01-19 03:50:03 +00:00
if (destroying_windows_disallowed > 0)
meta_bug ("Tried to destroy window %s while destruction was not allowed\n",
window->desc);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Replace MetaStackWindow with a 64-bit "stack ID" Putting X windows and pointers to MetaWindows into a union had a number of problems: - It caused awkward initialization and conditionalization - There was no way to refer to Wayland windows (represented by MetaWindow *) in the past, which is necessary for the MetaStackTracker algorithms - We never even cleaned up old MetaStackWindow so there could be records in MetaStackWindow pointing to freed MetaWindow. Replace MetaStackWindow with a 64-bit "stack ID" which is: - The XID for X Windows - a "window stamp" for Wayland windows - window stamps are assigned for all MetaWindow and are unique across the life of the process. https://bugzilla.gnome.org/show_bug.cgi?id=736559
2014-09-09 01:20:14 +00:00
meta_display_unregister_stamp (window->display, window->stamp);
window: make determination of attached dialog windows more consistent Different bits of code were using slightly different checks to test whether a window was an attached dialog. Add a new meta_window_is_attached_dialog(), and use that everywhere. Also, freeze the is-attached status when the window is first shown, rather than recomputing it each time the caller asks, since this could cause problems if a window changes its type after it has already been attached, etc. However, if an attached window's parent is destroyed, or an attached window changes its transient-for, then fix things up by destroying the old MetaWindow and creating a new one (causing compositor unmap and map events to be fired off, allowing the display of the window to be fixed up). Remove some code in display.c that tried to fix existing windows if the gconf setting changed, but which didn't actually do anything (at least under gnome-shell). However, if 654643 was fixed then the new behavior with this patch would be that changing the gconf setting would affect new dialogs, but not existing ones. https://bugzilla.gnome.org/show_bug.cgi?id=646761
2011-04-05 14:14:52 +00:00
if (meta_prefs_get_attach_modal_dialogs ())
{
GList *attached_children = NULL, *iter;
/* Detach any attached dialogs by unmapping and letting them
* be remapped after @window is destroyed.
*/
meta_window_foreach_transient (window,
detach_foreach_func,
&attached_children);
for (iter = attached_children; iter; iter = iter->next)
meta_window_unmanage (iter->data, timestamp);
g_list_free (attached_children);
}
window: Don't make windows on non-primaries sticky on restart When workspaces-only-on-primary is set, a window can be on all workspaces either because it is on a non-primary workspace, or because it was explicitly made sticky. Only the latter is reflected in _NET_WM_STATE, but both will result in a "magic" _NET_WM_DESKTOP, which we (and probably other WMs) use to set the initial sticky state. So to avoid confusing other WMs (or ourselves), make sure to only have _NET_WM_STATE_STICKY reflected in _NET_WM_DESKTOP when unmanaging.
2014-06-23 23:45:15 +00:00
/* Make sure to only show window on all workspaces if requested, to
* not confuse other window managers that may take over
*/
Stop using MetaScreen where it is unnecessary https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:43:17 +00:00
if (meta_prefs_get_workspaces_only_on_primary ())
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
meta_window_on_all_workspaces_changed (window);
window: Don't make windows on non-primaries sticky on restart When workspaces-only-on-primary is set, a window can be on all workspaces either because it is on a non-primary workspace, or because it was explicitly made sticky. Only the latter is reflected in _NET_WM_STATE, but both will result in a "magic" _NET_WM_DESKTOP, which we (and probably other WMs) use to set the initial sticky state. So to avoid confusing other WMs (or ourselves), make sure to only have _NET_WM_STATE_STICKY reflected in _NET_WM_DESKTOP when unmanaging.
2014-06-23 23:45:15 +00:00
when freeing a fullscreen window, update layers of the window's group. 2002-08-25 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_free): when freeing a fullscreen window, update layers of the window's group.
2002-08-25 20:59:09 +00:00
if (window->fullscreen)
{
MetaGroup *group;
/* If the window is fullscreen, it may be forcing
* other windows in its group to a higher layer
*/
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_freeze (window->display->stack);
when freeing a fullscreen window, update layers of the window's group. 2002-08-25 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_free): when freeing a fullscreen window, update layers of the window's group.
2002-08-25 20:59:09 +00:00
group = meta_window_get_group (window);
if (group)
meta_group_update_layers (group);
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_thaw (window->display->stack);
when freeing a fullscreen window, update layers of the window's group. 2002-08-25 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_free): when freeing a fullscreen window, update layers of the window's group.
2002-08-25 20:59:09 +00:00
}
move meta_window_shutdown_group() much earlier in the destroy process. May 2002-10-27 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_free): move meta_window_shutdown_group() much earlier in the destroy process. May fix #96928 tracked down by Kjartan Maraas and Martin Garton. * src/group.c (meta_window_get_group): never add window to a group after we've started unmanaging the window
2002-10-27 14:45:29 +00:00
window: Remove pending pings in unmanage This makes sure that we see them for Wayland clients as well, and don't time out and crash when we're accessing an invalid window / surface. Spotted-by: Rui Matos <tiagomatos@gmail.com>
2014-07-08 16:16:11 +00:00
meta_display_remove_pending_pings_for_window (window->display, window);
window: Reformat a comment
2014-07-08 16:45:34 +00:00
/* safe to do this early as group.c won't re-add to the
* group if window->unmanaging */
meta_window_shutdown_group (window);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
focus top window when switching to a new workspace 2002-01-03 Havoc Pennington <hp@pobox.com> * src/workspace.c (meta_workspace_activate): focus top window when switching to a new workspace * src/util.c (meta_topic): start putting verbose output in categories * src/window.c (meta_window_shade): focus frame after we queue the calc_showing so the maps/unmaps have already happened. * src/display.c (meta_display_get_current_time): add the "get time of current event" function and call it occasionally. * src/window.c (meta_window_free): if we have focus, call meta_screen_focus_top_window(). (meta_window_minimize): ditto (meta_window_delete): ditto * src/screen.c (meta_screen_ensure_tab_popup): fix memory leak - didn't free tab list (meta_screen_focus_top_window): new function to use when we unmap or unmanage a focused window * src/stack.c (meta_stack_get_default_focus_window): function used in meta_screen_focus_top_window
2002-01-03 23:28:19 +00:00
/* If we have the focus, focus some other window.
* This is done first, so that if the unmap causes
* an EnterNotify the EnterNotify will have final say
* on what gets focused, maintaining sloppy focus
* invariants.
*/
window: fix appears-focused propagation with attached grandchildren When detaching/attaching a dialog, we were only updating appears-focused on the parent if the child itself was focused, but in fact, we need to do it if the child has an attached child which is focused too. To simplify the case of detaching a focused subtree from its parent, we change meta_window_propagate_focus_appearance() to use @window->display->focus_window as the window to add/remove as the attached_focus_window, and @window only as the starting point to propagate from. That way we can propagate focus-removal up to @window's (soon-to-be-ex-)ancestors without having to remove it from its descendants as well. https://bugzilla.gnome.org/show_bug.cgi?id=647712
2011-04-13 21:08:12 +00:00
if (meta_window_appears_focused (window))
meta_window_propagate_focus_appearance (window, FALSE);
focus top window when switching to a new workspace 2002-01-03 Havoc Pennington <hp@pobox.com> * src/workspace.c (meta_workspace_activate): focus top window when switching to a new workspace * src/util.c (meta_topic): start putting verbose output in categories * src/window.c (meta_window_shade): focus frame after we queue the calc_showing so the maps/unmaps have already happened. * src/display.c (meta_display_get_current_time): add the "get time of current event" function and call it occasionally. * src/window.c (meta_window_free): if we have focus, call meta_screen_focus_top_window(). (meta_window_minimize): ditto (meta_window_delete): ditto * src/screen.c (meta_screen_ensure_tab_popup): fix memory leak - didn't free tab list (meta_screen_focus_top_window): new function to use when we unmap or unmanage a focused window * src/stack.c (meta_stack_get_default_focus_window): function used in meta_screen_focus_top_window
2002-01-03 23:28:19 +00:00
if (window->has_focus)
{
meta_topic (META_DEBUG_FOCUS,
Make choice of focus window be consistent for each focus mode. Fixes 2004-06-24 Elijah Newren <newren@math.utah.edu> Make choice of focus window be consistent for each focus mode. Fixes #135810. * src/delete.c: (meta_window_delete): In some #if 0'ed code, replace meta_workspace_focus_mru_window with meta_workspace_focus_default_window (just in case the code becomes un-#if 0'ed out). * src/screen.c, src/screen.h: Change meta_screen_focus_mouse_window to meta_screen_get_mouse_window, and don't focus the window when found but rather return it. * src/window.c: (meta_window_free, meta_window_minimize): replace meta_workspace_focus_mru_window with meta_workspace_focus_default_window. * src/workspace.c: (meta_workspace_focus_default_window): Focus appropriately for the given focus method: click-to-focus: focus MRU window (== toplevel window) sloppy focus: focus the window under the pointer if there is such a window, otherwise focus the mru window mouse focus: focus the window under the pointer if there is such a window, otherwise don't focus anything
2004-06-24 20:02:46 +00:00
"Focusing default window since we're unmanaging %s\n",
focus top window when switching to a new workspace 2002-01-03 Havoc Pennington <hp@pobox.com> * src/workspace.c (meta_workspace_activate): focus top window when switching to a new workspace * src/util.c (meta_topic): start putting verbose output in categories * src/window.c (meta_window_shade): focus frame after we queue the calc_showing so the maps/unmaps have already happened. * src/display.c (meta_display_get_current_time): add the "get time of current event" function and call it occasionally. * src/window.c (meta_window_free): if we have focus, call meta_screen_focus_top_window(). (meta_window_minimize): ditto (meta_window_delete): ditto * src/screen.c (meta_screen_ensure_tab_popup): fix memory leak - didn't free tab list (meta_screen_focus_top_window): new function to use when we unmap or unmanage a focused window * src/stack.c (meta_stack_get_default_focus_window): function used in meta_screen_focus_top_window
2002-01-03 23:28:19 +00:00
window->desc);
window: Explicitly exclude unmanaging window from focus again Since commit b3b9d9e16 we no longer have to pass the unmanaging window to make sure we don't try to focus it again, however the parameter also influences the focus policy by giving ancestors preference over the normal stack order. https://gitlab.gnome.org/GNOME/mutter/issues/15
2018-05-25 19:24:17 +00:00
meta_workspace_focus_default_window (workspace_manager->active_workspace,
window,
timestamp);
focus top window when switching to a new workspace 2002-01-03 Havoc Pennington <hp@pobox.com> * src/workspace.c (meta_workspace_activate): focus top window when switching to a new workspace * src/util.c (meta_topic): start putting verbose output in categories * src/window.c (meta_window_shade): focus frame after we queue the calc_showing so the maps/unmaps have already happened. * src/display.c (meta_display_get_current_time): add the "get time of current event" function and call it occasionally. * src/window.c (meta_window_free): if we have focus, call meta_screen_focus_top_window(). (meta_window_minimize): ditto (meta_window_delete): ditto * src/screen.c (meta_screen_ensure_tab_popup): fix memory leak - didn't free tab list (meta_screen_focus_top_window): new function to use when we unmap or unmanage a focused window * src/stack.c (meta_stack_get_default_focus_window): function used in meta_screen_focus_top_window
2002-01-03 23:28:19 +00:00
}
else
{
meta_topic (META_DEBUG_FOCUS,
"Unmanaging window %s which doesn't currently have focus\n",
window->desc);
}
only bump unmaps_pending if the window was mapped 2002-01-10 Havoc Pennington <hp@pobox.com> * src/frame.c (meta_window_destroy_frame): only bump unmaps_pending if the window was mapped (meta_window_ensure_frame): ditto * src/keybindings.c: change arrow key bindings to use Ctrl+Alt not just Alt, and add debug mode key bindings * src/stack.c (meta_stack_get_default_focus_window): don't choose a default focus window with unmaps pending, since we probably just unmapped it. * src/display.c (event_callback): move notify_focus on UnmapNotify after the window_free check, so we can move focus to another window when we unmanage * src/window.c (meta_window_hide): invalidate work areas when hiding a window with struts (meta_window_free): invalidate work areas when unmanaging a window with struts
2002-01-11 03:31:14 +00:00
display: clean up focus_window vs expected_focus_window Mutter previously defined display->focus_window as the window that the server says is focused, but kept display->expected_focus_window to indicate the window that we have requested to be focused. But it turns out that "expected_focus_window" was almost always what we wanted. Make MetaDisplay do a better job of tracking focus-related requests and events, and change display->focus_window to be our best guess of the "currently" focused window (ie, the window that will be focused at the time when the server processes the next request we send it). https://bugzilla.gnome.org/show_bug.cgi?id=647706
2011-04-26 12:12:04 +00:00
g_assert (window->display->focus_window != window);
Update constraints code to support the new _NET_WM_STRUT_PARTIAL EWMH 2003-06-10 Rob Adams <robadams@ucla.edu> Update constraints code to support the new _NET_WM_STRUT_PARTIAL EWMH draft specification. See #86682. Also, fix a bug involving work area invalidation on metacity startup. Fix for #108497. Finally, some minor fixes for full screen windows. * src/window.h: Add new MetaStruts structure to store strut rects for a window. Remove has_struts and do_not_cover flag, and support new MetaStruts instead of the four ints. * src/window.c (meta_window_new): change initialization to work with new struts. Also, move meta_window_update_struts call to after the workspaces are initialized to fix #108497. Remove do_not_cover and related code. (process_property_notify): add strut_partial (update_struts): change function name to meta_window_update_struts and expose in external MetaWindow API. Support partial width struts and the new strut rects. * src/workspace.h: add new GSLists containing pointers to all relevant struts for this workspace. * src/workspace.c (meta_workspace_new): initialize the list of strut rects for this workspace. (meta_workspace_free): free the strut rect lists (ensure_work_areas_validated): support new struts and new strut rect lists. Unleash the per-xinerama work areas. * src/constraints.c (get_outermost_onscreen_positions): Use the current window position along with the new per-workspace strut rects to compute the constraints that apply to a particular window. (constraint_hint_applies_func): don't do hints constraints on fullscreen windows (update_position_limits): for maximized windows use the work areas to set the position limits; for other windows rely on the struts constraints to be computed later in get_outermost_onscreen_positions (meta_window_constrain): don't apply aspect ratio hints to full screen windows * src/display.c (meta_display_open): add _NET_WM_STRUT_PARTIAL atom (meta_rectangle_equal): new helper function for MetaRectangles (event_queue_callback): #ifndef out if USE_GDK_DISPLAY not set to avoid compiler warning * src/display.h: add atom_net_wm_strut_partial, and add meta_rectangle_equal. * src/screen.c (meta_screen_rect_intersects_xinerama): change _window_intersects_ to _rect_intersects_ which is more useful now. (meta_screen_resize_func): update struts on windows with struts since struts are relative to the screen size, and this function is called when the screen size updates. * src/screen.h (meta_screen_rect_intersects_xinerama): change _window_intersects_ to _rect_intersects_ which is more useful now. * src/window-props.c (meta_display_init_window_prop_hooks): add hook for strut_partial * src/tools/metacity-window-demo.c: Support partial-width struts on the dock window tests for metacity testing purposes.
2003-06-26 03:09:38 +00:00
if (window->struts)
Throughout: move to meta_topic rather than meta_verbose so metacity.log 2002-02-07 Havoc Pennington <hp@pobox.com> Throughout: move to meta_topic rather than meta_verbose so metacity.log can start being more useful * src/util.h (enum): add more debug topics * src/frames.c: clean up some cruft that caused warnings
2002-02-08 03:34:26 +00:00
{
meta: Remove meta_free_gslist_and_elements This function was added for historic reasons, before that we had GSlist's free_full function. Since this can be now easily implemented with a function call and an explicit GDestroyFunc, while no known dependency uses it let's move to use g_slist_free_func instead. https://gitlab.gnome.org/GNOME/mutter/merge_requests/57
2019-05-15 19:28:55 +00:00
g_slist_free_full (window->struts, g_free);
Update constraints code to support the new _NET_WM_STRUT_PARTIAL EWMH 2003-06-10 Rob Adams <robadams@ucla.edu> Update constraints code to support the new _NET_WM_STRUT_PARTIAL EWMH draft specification. See #86682. Also, fix a bug involving work area invalidation on metacity startup. Fix for #108497. Finally, some minor fixes for full screen windows. * src/window.h: Add new MetaStruts structure to store strut rects for a window. Remove has_struts and do_not_cover flag, and support new MetaStruts instead of the four ints. * src/window.c (meta_window_new): change initialization to work with new struts. Also, move meta_window_update_struts call to after the workspaces are initialized to fix #108497. Remove do_not_cover and related code. (process_property_notify): add strut_partial (update_struts): change function name to meta_window_update_struts and expose in external MetaWindow API. Support partial width struts and the new strut rects. * src/workspace.h: add new GSLists containing pointers to all relevant struts for this workspace. * src/workspace.c (meta_workspace_new): initialize the list of strut rects for this workspace. (meta_workspace_free): free the strut rect lists (ensure_work_areas_validated): support new struts and new strut rect lists. Unleash the per-xinerama work areas. * src/constraints.c (get_outermost_onscreen_positions): Use the current window position along with the new per-workspace strut rects to compute the constraints that apply to a particular window. (constraint_hint_applies_func): don't do hints constraints on fullscreen windows (update_position_limits): for maximized windows use the work areas to set the position limits; for other windows rely on the struts constraints to be computed later in get_outermost_onscreen_positions (meta_window_constrain): don't apply aspect ratio hints to full screen windows * src/display.c (meta_display_open): add _NET_WM_STRUT_PARTIAL atom (meta_rectangle_equal): new helper function for MetaRectangles (event_queue_callback): #ifndef out if USE_GDK_DISPLAY not set to avoid compiler warning * src/display.h: add atom_net_wm_strut_partial, and add meta_rectangle_equal. * src/screen.c (meta_screen_rect_intersects_xinerama): change _window_intersects_ to _rect_intersects_ which is more useful now. (meta_screen_resize_func): update struts on windows with struts since struts are relative to the screen size, and this function is called when the screen size updates. * src/screen.h (meta_screen_rect_intersects_xinerama): change _window_intersects_ to _rect_intersects_ which is more useful now. * src/window-props.c (meta_display_init_window_prop_hooks): add hook for strut_partial * src/tools/metacity-window-demo.c: Support partial-width struts on the dock window tests for metacity testing purposes.
2003-06-26 03:09:38 +00:00
window->struts = NULL;
Throughout: move to meta_topic rather than meta_verbose so metacity.log 2002-02-07 Havoc Pennington <hp@pobox.com> Throughout: move to meta_topic rather than meta_verbose so metacity.log can start being more useful * src/util.h (enum): add more debug topics * src/frames.c: clean up some cruft that caused warnings
2002-02-08 03:34:26 +00:00
meta_topic (META_DEBUG_WORKAREA,
"Unmanaging window %s which has struts, so invalidating work areas\n",
window->desc);
invalidate_work_areas (window);
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
cleanup: Use g_clear_handle_id() for g_source_remove() It makes sure we do not forget to zero the id and lets us avoid zero checks before. We use it for all new code, lets clean up the existing code base. https://gitlab.gnome.org/GNOME/mutter/merge_requests/947
2019-11-21 23:25:30 +00:00
g_clear_handle_id (&window->sync_request_timeout_id, g_source_remove);
Make handling of windows that don't respond to _NET_WM_SYNC_REQUEST reliable Previously, we were handling failure to respond to _NET_WM_SYNC_REQUEST in the code path for throttling motion events. But this meant that if a window didn't respond to _NET_WM_SYNC_REQUEST and there were no motion events - for a keyboard resize, or after the end of the grab operation - it would end up in a stuck state. Use a separate per-window timeout to reliably catch the failure to respond to _NET_WM_SYNC_REQUEST. https://bugzilla.gnome.org/show_bug.cgi?id=694046
2013-03-13 19:31:11 +00:00
...
2001-07-11 06:22:00 +00:00
if (window->display->grab_window == window)
Partial audit to fix timestamp usage. One step towards fixing #355180; see 2006-09-18 Elijah Newren <newren gmail com> Partial audit to fix timestamp usage. One step towards fixing #355180; see important comments in that bug. * src/core.[ch] (meta_core_unshade, meta_core_shade): * src/delete.c (meta_window_present_delete_dialog, delete_ping_timeout_func): * src/display.[ch] (meta_display_open, meta_display_close, event_callback, meta_display_begin_grab_op, process_selection_clear, meta_display_unmanage_screen, meta_display_unmanage_windows_for_screen): * src/frames.c (meta_frames_button_press_event): * src/keybindings.c (handle_toggle_shade): * src/main.c (main): * src/screen.[ch] (update_num_workspaces, meta_screen_new, meta_screen_free, prefs_changed_callback): * src/window.[ch] (meta_window_free, finish_minimize, implement_showing, meta_window_show, meta_window_maximize, meta_window_make_fullscreen_internal, meta_window_unmake_fullscreen, meta_window_shade, meta_window_unshade, window_activate, send_sync_request, meta_window_client_message, menu_callback, meta_window_update_keyboard_resize): Remove usage of CurrentTime, meta_display_get_current_time() and meta_display_get_current_time_roundtrip() where possible, or document why it isn't possible, or at very least add a FIXME with some explanation of my laziness and what needs to be done.
2006-09-18 17:27:24 +00:00
meta_display_end_grab_op (window->display, timestamp);
use hash_table_replace instead of g_hash_table_insert 2002-03-06 Havoc Pennington <hp@redhat.com> * src/frames.c (meta_frames_manage_window): use hash_table_replace instead of g_hash_table_insert * src/main.c (main): only enable verbose/debug if you set METACITY_VERBOSE/METACITY_DEBUG * src/util.c (ensure_logfile): only use a log file if METACITY_USE_LOGFILE is set * src/display.c (meta_display_for_x_display): add warning if MetaDisplay isn't found * src/window.c (meta_window_free): add an assertion that we successfully cleared the grab window
2002-03-06 22:27:24 +00:00
g_assert (window->display->grab_window != window);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Only unmaximise window before freeing if the window is actually maximised. 2006-03-06 Ryan Lortie <desrt@desrt.ca> * src/window.c (meta_window_free): Only unmaximise window before freeing if the window is actually maximised. #333563.
2006-03-06 16:33:33 +00:00
if (window->maximized_horizontally || window->maximized_vertically)
unmaximize_window_before_freeing (window);
Make sure apps have correct info about their coordinates, even on unmap. 2007-04-11 Elijah Newren <newren gmail com> Make sure apps have correct info about their coordinates, even on unmap. Fixes temporary hang with libXt (XtVaSetValues setting x & y coordinates). #399552. * src/frame.c (meta_window_destroy_frame): Add a comment noting that the current choice causes the need for a ConfigureNotify event * src/window.c (meta_window_free): Send a configure notify event due to our XReparentWindow coordinate choices on withdrawal, (unmaximize_window_before_freeing): no need to send a configure notify from here since it is always done in meta_window_free new, (send_configure_notify): have to special case the coordinates used when withdrawing the window svn path=/trunk/; revision=3192
2007-04-12 04:02:57 +00:00
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
meta_window_unqueue (window, META_QUEUE_CALC_SHOWING |
META_QUEUE_MOVE_RESIZE |
META_QUEUE_UPDATE_ICON);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
set_workspace_state (window, FALSE, NULL);
...
2001-06-06 04:47:37 +00:00
Partially resolve the conflicting requirements of windows on multiple 2004-12-22 Elijah Newren <newren@gmail.com> Partially resolve the conflicting requirements of windows on multiple workspaces and hidden being a global quantity for windows (fixes bug 156182; the remainder of the work is bug 87531 and is a libwnck issue) * src/display.c (event_callback): * src/window.c (meta_window_visible_on_workspace, meta_window_unstick): * src/workspace.c (meta_workspace_add_window, meta_workspace_contains_window, meta_workspace_queue_calc_showing): * src/workspace.h: Remove meta_workspace_contains_window, replace with simple comparison utilizing window->workspace * src/place.c (meta_window_place): * src/window.c (meta_window_shares_some_workspace): * src/window.h: Remove meta_window_shares_some_workspace, replace with a simple comparison utilizing window->workspace * src/session.c (save_state), * src/window.c (meta_window_new_with_attrs, meta_window_apply_session_info, meta_window_free, window_showing_on_its_workspace, meta_window_change_workspace_without_transients, meta_window_unstick, meta_window_set_current_workspace_hint, meta_window_get_workspaces): * src/window.h: * src/workspace.c (meta_workspace_free, meta_workspace_add_window, meta_workspace_remove_window): Only one workspace now
2004-12-22 23:52:52 +00:00
g_assert (window->workspace == NULL);
...
2001-06-07 05:18:10 +00:00
unstick window to get it out of mru_list it should not be in; assert that 2003-12-12 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_free): unstick window to get it out of mru_list it should not be in; assert that window has been removed from all mru_list. Perhaps fixes #122016 crash.
2003-12-13 03:58:55 +00:00
#ifndef G_DISABLE_CHECKS
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
tmp = workspace_manager->workspaces;
unstick window to get it out of mru_list it should not be in; assert that 2003-12-12 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_free): unstick window to get it out of mru_list it should not be in; assert that window has been removed from all mru_list. Perhaps fixes #122016 crash.
2003-12-13 03:58:55 +00:00
while (tmp != NULL)
{
MetaWorkspace *workspace = tmp->data;
g_assert (g_list_find (workspace->windows, window) == NULL);
g_assert (g_list_find (workspace->mru_list, window) == NULL);
tmp = tmp->next;
}
#endif
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Add signals for when windows change monitors This is useful in order to track e.g. which windows are on the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 20:26:11 +00:00
if (window->monitor)
{
Rename MetaMonitorInfo MetaLogicalMonitor In preparation for further refactorizations, rename the MetaMonitorInfo struct to MetaLogicalMonitor. Eventually, part of MetaLogicalMonitor will be split into a MetaMonitor type. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-25 06:31:38 +00:00
const MetaLogicalMonitor *old = window->monitor;
wayland: Sync surface actor state when changing main monitor In order to switch to the correct surface actor scale given the monitor the surface is on, without relying on the client committing a new state given some other side effect, sync the surface actor state when the main monitor associated with the corresponding window changed. https://bugzilla.gnome.org/show_bug.cgi?id=744933
2015-03-03 03:13:05 +00:00
Add signals for when windows change monitors This is useful in order to track e.g. which windows are on the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 20:26:11 +00:00
window->monitor = NULL;
wayland: Sync surface actor state when changing main monitor In order to switch to the correct surface actor scale given the monitor the surface is on, without relying on the client committing a new state given some other side effect, sync the surface actor state when the main monitor associated with the corresponding window changed. https://bugzilla.gnome.org/show_bug.cgi?id=744933
2015-03-03 03:13:05 +00:00
meta_window_main_monitor_changed (window, old);
Add signals for when windows change monitors This is useful in order to track e.g. which windows are on the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 20:26:11 +00:00
}
window: Defer stack placement without a buffer When closing a window and showing a new one, the new one may not be granted input focus until it gets a buffer on Wayland. If another window is chosen to receive focus and raised on top of stack, the newly mapped window is focused but placed underneath that other window. Meaning that for Wayland surfaces, we need to defer adding the window to the stack until we actually get to show it, once we have a buffer attached. Rather that checking the windowing backend prior to decide if a window is stackable or not, introduce a new vfunc is_stackable() which tells if a window should be added to the stack regardless of the underlying windowing system. Also add meta_window_is_in_stack() API rather than checking the stack position directly (replacing the define WINDOW_IN_STACK only available in stack.c) and remove a window from the stack only if it is present in the stack, so that the test in meta_stack_remote() becomes irrelevant. https://bugzilla.gnome.org/show_bug.cgi?id=780820
2018-01-09 12:19:40 +00:00
if (meta_window_is_in_stack (window))
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_remove (window->display->stack, window);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Move compositor-stack handling to MetaStackTracker In order to properly track the stacking order for override-redirect windows, move meta_compositor_sync_stack() call into MetaStackTracker. In the new location, we sync the stack as a before-redraw idle function, rather then using the freeze-thaw facilities of MetaStack. This is simpler, and also properly compresses multiple stack changes on notifications received from the X server. http://bugzilla.gnome.org/show_bug.cgi?id=585984
2009-06-14 12:04:28 +00:00
/* If an undecorated window is being withdrawn, that will change the
* stack as presented to the compositing manager, without actually
* changing the stacking order of X windows.
*/
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_tracker_queue_sync_stack (window->display->stack_tracker);
Move compositor-stack handling to MetaStackTracker In order to properly track the stacking order for override-redirect windows, move meta_compositor_sync_stack() call into MetaStackTracker. In the new location, we sync the stack as a before-redraw idle function, rather then using the freeze-thaw facilities of MetaStack. This is simpler, and also properly compresses multiple stack changes on notifications received from the X server. http://bugzilla.gnome.org/show_bug.cgi?id=585984
2009-06-14 12:04:28 +00:00
display: Use MetaWindow for auto-raise callbacks This allows us to autoraise Wayland windows... well, except for the XQueryPointer, but we'll replace that soon.
2013-10-16 04:19:33 +00:00
if (window->display->autoraise_window == window)
meta_display_remove_autoraise_callback (window->display);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window: Move client-type-specific managing / unmanaging to a vfunc
2014-03-19 13:36:15 +00:00
META_WINDOW_GET_CLASS (window)->unmanage (window);
port to icon cache 2002-02-09 Havoc Pennington <hp@pobox.com> * src/window.c (update_icon): port to icon cache * src/iconcache.c, src/iconcache.c: begin process of cleaning up window.c by moving the icon-reading code in here, based on the code in libwnck, which was in turn based on the earlier metacity code
2002-02-09 23:03:52 +00:00
window: Remove prefs listener in _unmanage instead of _finalize After _unmanage the object is semantically dead even if technically it's not, so remove the prefs listener here to prevent it being called for a dead object. In particular this fixes a crash when starting up gnome-shell with at least one gimp utility window opened which causes mutter to create a MetaWindow for it only to immediately get an UnmapNotify afterwards which causes mutter to unmanage the MetaWindow. Afterwards prefs_changed_callback is called for this dead MetaWindow and tries to dereference the window->monitor pointer which is already NULL. https://bugzilla.gnome.org/show_bug.cgi?id=671087
2012-02-29 21:31:30 +00:00
meta_prefs_remove_listener (prefs_changed_callback, window);
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
meta_display_queue_check_fullscreen (window->display);
MetaScreen: Add tracking of whether there are fullscreen windows Trying to track the fullscreen status outside of Mutter, as GNOME Shell was doing previously, was very prone to errors, because Mutter has a very tricky definition of when a window is set to be fullscreen and *actually* acting like a fullscreen window. * Add meta_screen_get_monitor_in_fullscreen() and an ::in-fullscreen-changed signal. This allows an application to track when there are fullscreen windows on a monitor. * Do the computation of fullscreen status in a "later" function that runs after showing, so we properly take focus into account. * To get ordering of different phases right, add more values to MetaLaterType. * Add auto-minimization, similar to what was added to GNOME Shell earlier in this cycle - if a window is set to be fullscreen, but not actually fullscreen, minimize. https://bugzilla.gnome.org/show_bug.cgi?id=649748
2013-03-14 20:55:49 +00:00
Add "window-created" signal to MetaDisplay, "unmanaged" signal for MetaWindow For some consumers it's significantly more convenient to be able to directly connect to a signal on the Window to know when Mutter is done with it, rather than having to connect to each Workspace object (and handle workspace additions, etc.). Similarly, add window-created which acts globally. https://bugzilla.gnome.org/show_bug.cgi?id=598289
2009-10-13 14:34:34 +00:00
g_signal_emit (window, window_signals[UNMANAGED], 0);
Make MetaWindow a GObject Make MetaWindow into a GObject so that it is accessible to gobject-introspection (also allows for signals to be added.) Renames: meta_window_free() => meta_window_unmanage() meta_window_get_type() => meta_window_get_window_type() meta_window_get_type_atom() => meta_window_get_window_type_atom()
2008-11-07 09:57:00 +00:00
g_object_unref (window);
...
2001-05-30 15:36:31 +00:00
}
Add MUTTER_WM_CLASS_FILTER environment variable In a performance or regression testing environment, we may want to only manage windows from a particular test program, and ignore all other windows. The MUTTER_WM_CLASS_FILTER environment variable is a list of WM_CLASS values that should be managed; other windows will be unmapped and ignored. https://bugzilla.gnome.org/show_bug.cgi?id=644252
2011-03-08 22:15:56 +00:00
static void
window: Centralize WM_STATE management
2014-02-02 00:03:33 +00:00
set_wm_state (MetaWindow *window)
Add MUTTER_WM_CLASS_FILTER environment variable In a performance or regression testing environment, we may want to only manage windows from a particular test program, and ignore all other windows. The MUTTER_WM_CLASS_FILTER environment variable is a list of WM_CLASS values that should be managed; other windows will be unmapped and ignored. https://bugzilla.gnome.org/show_bug.cgi?id=644252
2011-03-08 22:15:56 +00:00
{
window-x11: Move meta_window_new to window-x11.c and rename
2014-02-02 00:19:22 +00:00
if (window->client_type == META_WINDOW_CLIENT_TYPE_X11)
meta_window_x11_set_wm_state (window);
...
2001-06-11 03:24:20 +00:00
}
Optimizations for managing new windows (do not all take effect if 2002-10-21 Havoc Pennington <hp@redhat.com> Optimizations for managing new windows (do not all take effect if METACITY_DEBUG=1). Bug #96404 * src/keybindings.c (meta_change_keygrab): use error trap nesting and conditionalize on meta_is_verbose() to avoid a ton of XSync * src/display.c (meta_change_button_grab): ditto Throughout: move to new error trap setup to save on XSync calls, new setup is: * src/errors.c (meta_error_trap_push_with_return): new function, an error trap that needs to care about return value and thus sync even if an outer trap still exists (meta_error_trap_pop_with_return): new function (meta_error_trap_pop): add "last_request_was_roundtrip" argument allowing us to avoid XSync() if we just did a GetProperty or whatever. * src/util.c (meta_warning): flush the warning file descriptor * src/Makefile.am (INCLUDES): define G_LOG_DOMAIN
2002-10-21 21:44:35 +00:00
static void
...
2001-06-11 03:24:20 +00:00
set_net_wm_state (MetaWindow *window)
{
Start moving X11-specific code to window-x11.c The goal here is to make MetaWindow represent a toplevel, managed window, regardless of if it's X11 or Wayland, and build an abstraction layer up. Right now, most of the X11 code is in core/ and the wayland code in wayland/, but in the future, I want to move a lot of the X11 code to a new toplevel, x11/.
2014-01-23 21:33:53 +00:00
if (window->client_type == META_WINDOW_CLIENT_TYPE_X11)
meta_window_x11_set_net_wm_state (window);
...
2001-06-06 04:47:37 +00:00
}
window: Move _NET_WM_ALLOWED_ACTIONS setting to window-x11 as well
2014-04-29 19:18:40 +00:00
static void
set_allowed_actions_hint (MetaWindow *window)
{
if (window->client_type == META_WINDOW_CLIENT_TYPE_X11)
meta_window_x11_set_allowed_actions_hint (window);
}
window: Make meta_window_located_on_workspace() public We have some code in gnome-shell that does the equivalent of: window.get_workspace() == workspace || window.is_on_all_workspaces(); which is a bit unwieldy. We already have a method in mutter, so use that and document it. https://bugzilla.gnome.org/show_bug.cgi?id=691744
2013-01-14 17:34:14 +00:00
/**
* meta_window_located_on_workspace:
* @window: a #MetaWindow
* @workspace: a #MetaWorkspace
*
Fix gobs of gtk-doc warnings https://bugzilla.gnome.org/show_bug.cgi?id=676856
2013-02-15 18:42:08 +00:00
* Returns: whether @window is displayed on @workspace, or whether it
window: Make meta_window_located_on_workspace() public We have some code in gnome-shell that does the equivalent of: window.get_workspace() == workspace || window.is_on_all_workspaces(); which is a bit unwieldy. We already have a method in mutter, so use that and document it. https://bugzilla.gnome.org/show_bug.cgi?id=691744
2013-01-14 17:34:14 +00:00
* will be displayed on all workspaces.
*/
I was using meta_workspace_contains_window() in a number of places where 2001-10-25 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_visible_on_workspace): I was using meta_workspace_contains_window() in a number of places where on_all_workspaces should also have been considered, thus this new function. Fixes bugs such as pinned windows not appearing in the tab order. (meta_window_client_message): use meta_window_visible_on_workspace * src/stack.c (find_tab_forward): ditto (find_tab_backward): ditto (meta_stack_get_tab_next): ditto (meta_stack_get_tab_list): ditto * src/place.c (get_windows_on_same_workspace): ditto * src/keybindings.c (handle_focus_previous): ditto (handle_focus_previous): ditto
2001-10-25 04:51:25 +00:00
gboolean
Rename meta_window_visible_on_workspace to 2004-12-22 Elijah Newren <newren@gmail.com> * src/core.c (meta_core_user_lower_and_unfocus): * src/display.c (meta_display_get_current_tab): * src/stack.c (get_default_focus_window, meta_stack_list_windows): * src/window.c (set_net_wm_state, meta_window_should_be_showing, implement_showing, meta_window_activate, meta_window_notify_focus): * src/window.h: * src/workspace.c (meta_workspace_list_windows): Rename meta_window_visible_on_workspace to meta_window_located_on_workspace (whether or not the window was showing wasn't taken into account, which made "visible" confusing). Fixes #136314.
2004-12-23 00:20:33 +00:00
meta_window_located_on_workspace (MetaWindow *window,
I was using meta_workspace_contains_window() in a number of places where 2001-10-25 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_visible_on_workspace): I was using meta_workspace_contains_window() in a number of places where on_all_workspaces should also have been considered, thus this new function. Fixes bugs such as pinned windows not appearing in the tab order. (meta_window_client_message): use meta_window_visible_on_workspace * src/stack.c (find_tab_forward): ditto (find_tab_backward): ditto (meta_stack_get_tab_next): ditto (meta_stack_get_tab_list): ditto * src/place.c (get_windows_on_same_workspace): ditto * src/keybindings.c (handle_focus_previous): ditto (handle_focus_previous): ditto
2001-10-25 04:51:25 +00:00
MetaWorkspace *workspace)
{
screen: Remove a bunch of screen checks Now that we only manage one screen, this isn't necessary anymore.
2014-08-15 23:43:08 +00:00
return (window->on_all_workspaces) || (window->workspace == workspace);
I was using meta_workspace_contains_window() in a number of places where 2001-10-25 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_visible_on_workspace): I was using meta_workspace_contains_window() in a number of places where on_all_workspaces should also have been considered, thus this new function. Fixes bugs such as pinned windows not appearing in the tab order. (meta_window_client_message): use meta_window_visible_on_workspace * src/stack.c (find_tab_forward): ditto (find_tab_backward): ditto (meta_stack_get_tab_next): ditto (meta_stack_get_tab_list): ditto * src/place.c (get_windows_on_same_workspace): ditto * src/keybindings.c (handle_focus_previous): ditto (handle_focus_previous): ditto
2001-10-25 04:51:25 +00:00
}
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
static gboolean
is_minimized_foreach (MetaWindow *window,
void *data)
{
gboolean *result = data;
*result = window->minimized;
if (*result)
return FALSE; /* stop as soon as we find one */
else
return TRUE;
}
static gboolean
ancestor_is_minimized (MetaWindow *window)
{
gboolean is_minimized;
is_minimized = FALSE;
meta_window_foreach_ancestor (window, is_minimized_foreach, &is_minimized);
return is_minimized;
}
expose MetaWindow .move(), resize() and add/expose .move_frame() The latter move method will place the window by the origin of the enclosing window decoration/frame, while the former will place by the origin of the inner window, itself. (Also moved meta_window_showing_on_its_workspace comment into gtk-doc) https://bugzilla.gnome.org/show_bug.cgi?id=642355
2011-03-09 15:01:44 +00:00
/**
* meta_window_showing_on_its_workspace:
* @window: A #MetaWindow
*
* Returns: %TRUE if window would be visible, if its workspace was current
*/
Take into account the appropriate list of windows when placing a new one. 2005-01-28 Elijah Newren <newren@gmail.com> Take into account the appropriate list of windows when placing a new one. Fixes #165381. * src/place.c: (meta_window_place): use meta_window_showing_on_its_workspace(w) instead of !w->minimzed, also take into account sticky windows * src/window.[ch]: rename window_showing_on_its_workspace to meta_window_showing_on_its_workspace and export it
2005-01-28 14:48:47 +00:00
gboolean
meta_window_showing_on_its_workspace (MetaWindow *window)
...
2001-06-06 04:47:37 +00:00
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to 2004-10-22 Elijah Newren <newren@math.utah.edu> Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to display windows as visible or hidden (#105665) * src/screen.c (queue_windows_showing): Revert the queue_windows_showing portion of the patch committed on 2004-10-16 for #142198--it was an ill-advised optimization. * src/window.c (window_showing_on_its_workspace, window_should_be_showing): split the old window_should_be_showing into these two functions, (set_net_wm_state): hidden state is more complex; use window_showing_on_its_workspace to determine the correct value
2004-10-22 20:28:36 +00:00
gboolean showing;
show the window if it's a transient of a dock or desktop, since otherwise 2003-11-07 Rob Adams <readams@readams.net> * src/window.c (window_should_be_showing): show the window if it's a transient of a dock or desktop, since otherwise such windows are invisible in show desktop mode. Fix for #124648.
2003-11-08 05:29:23 +00:00
gboolean is_desktop_or_dock;
Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to 2004-10-22 Elijah Newren <newren@math.utah.edu> Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to display windows as visible or hidden (#105665) * src/screen.c (queue_windows_showing): Revert the queue_windows_showing portion of the patch committed on 2004-10-16 for #142198--it was an ill-advised optimization. * src/window.c (window_showing_on_its_workspace, window_should_be_showing): split the old window_should_be_showing into these two functions, (set_net_wm_state): hidden state is more complex; use window_showing_on_its_workspace to determine the correct value
2004-10-22 20:28:36 +00:00
MetaWorkspace* workspace_of_window;
...
2001-07-04 02:10:54 +00:00
Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to 2004-10-22 Elijah Newren <newren@math.utah.edu> Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to display windows as visible or hidden (#105665) * src/screen.c (queue_windows_showing): Revert the queue_windows_showing portion of the patch committed on 2004-10-16 for #142198--it was an ill-advised optimization. * src/window.c (window_showing_on_its_workspace, window_should_be_showing): split the old window_should_be_showing into these two functions, (set_net_wm_state): hidden state is more complex; use window_showing_on_its_workspace to determine the correct value
2004-10-22 20:28:36 +00:00
showing = TRUE;
raise/focus windows on left-click, seem to have broken that yesterday 2001-10-14 Havoc Pennington <hp@pobox.com> * src/frames.c (meta_frames_button_press_event): raise/focus windows on left-click, seem to have broken that yesterday * src/keybindings.c, src/display.c, src/window.c: add keybinding to show/hide all normal windows (so you can see the desktop). Currently Ctrl+Alt+D, which I don't like, but yay.
2001-10-15 03:39:41 +00:00
Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to 2004-10-22 Elijah Newren <newren@math.utah.edu> Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to display windows as visible or hidden (#105665) * src/screen.c (queue_windows_showing): Revert the queue_windows_showing portion of the patch committed on 2004-10-16 for #142198--it was an ill-advised optimization. * src/window.c (window_showing_on_its_workspace, window_should_be_showing): split the old window_should_be_showing into these two functions, (set_net_wm_state): hidden state is more complex; use window_showing_on_its_workspace to determine the correct value
2004-10-22 20:28:36 +00:00
/* 1. See if we're minimized */
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
if (window->minimized)
showing = FALSE;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to 2004-10-22 Elijah Newren <newren@math.utah.edu> Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to display windows as visible or hidden (#105665) * src/screen.c (queue_windows_showing): Revert the queue_windows_showing portion of the patch committed on 2004-10-16 for #142198--it was an ill-advised optimization. * src/window.c (window_showing_on_its_workspace, window_should_be_showing): split the old window_should_be_showing into these two functions, (set_net_wm_state): hidden state is more complex; use window_showing_on_its_workspace to determine the correct value
2004-10-22 20:28:36 +00:00
/* 2. See if we're in "show desktop" mode */
show the window if it's a transient of a dock or desktop, since otherwise 2003-11-07 Rob Adams <readams@readams.net> * src/window.c (window_should_be_showing): show the window if it's a transient of a dock or desktop, since otherwise such windows are invisible in show desktop mode. Fix for #124648.
2003-11-08 05:29:23 +00:00
is_desktop_or_dock = FALSE;
is_desktop_or_dock_foreach (window,
&is_desktop_or_dock);
meta_window_foreach_ancestor (window, is_desktop_or_dock_foreach,
&is_desktop_or_dock);
Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to 2004-10-22 Elijah Newren <newren@math.utah.edu> Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to display windows as visible or hidden (#105665) * src/screen.c (queue_windows_showing): Revert the queue_windows_showing portion of the patch committed on 2004-10-16 for #142198--it was an ill-advised optimization. * src/window.c (window_showing_on_its_workspace, window_should_be_showing): split the old window_should_be_showing into these two functions, (set_net_wm_state): hidden state is more complex; use window_showing_on_its_workspace to determine the correct value
2004-10-22 20:28:36 +00:00
if (window->on_all_workspaces)
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
workspace_of_window = workspace_manager->active_workspace;
Partially resolve the conflicting requirements of windows on multiple 2004-12-22 Elijah Newren <newren@gmail.com> Partially resolve the conflicting requirements of windows on multiple workspaces and hidden being a global quantity for windows (fixes bug 156182; the remainder of the work is bug 87531 and is a libwnck issue) * src/display.c (event_callback): * src/window.c (meta_window_visible_on_workspace, meta_window_unstick): * src/workspace.c (meta_workspace_add_window, meta_workspace_contains_window, meta_workspace_queue_calc_showing): * src/workspace.h: Remove meta_workspace_contains_window, replace with simple comparison utilizing window->workspace * src/place.c (meta_window_place): * src/window.c (meta_window_shares_some_workspace): * src/window.h: Remove meta_window_shares_some_workspace, replace with a simple comparison utilizing window->workspace * src/session.c (save_state), * src/window.c (meta_window_new_with_attrs, meta_window_apply_session_info, meta_window_free, window_showing_on_its_workspace, meta_window_change_workspace_without_transients, meta_window_unstick, meta_window_set_current_workspace_hint, meta_window_get_workspaces): * src/window.h: * src/workspace.c (meta_workspace_free, meta_workspace_add_window, meta_workspace_remove_window): Only one workspace now
2004-12-22 23:52:52 +00:00
else if (window->workspace)
workspace_of_window = window->workspace;
Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to 2004-10-22 Elijah Newren <newren@math.utah.edu> Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to display windows as visible or hidden (#105665) * src/screen.c (queue_windows_showing): Revert the queue_windows_showing portion of the patch committed on 2004-10-16 for #142198--it was an ill-advised optimization. * src/window.c (window_showing_on_its_workspace, window_should_be_showing): split the old window_should_be_showing into these two functions, (set_net_wm_state): hidden state is more complex; use window_showing_on_its_workspace to determine the correct value
2004-10-22 20:28:36 +00:00
else /* This only seems to be needed for startup */
workspace_of_window = NULL;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
if (showing &&
Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to 2004-10-22 Elijah Newren <newren@math.utah.edu> Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to display windows as visible or hidden (#105665) * src/screen.c (queue_windows_showing): Revert the queue_windows_showing portion of the patch committed on 2004-10-16 for #142198--it was an ill-advised optimization. * src/window.c (window_showing_on_its_workspace, window_should_be_showing): split the old window_should_be_showing into these two functions, (set_net_wm_state): hidden state is more complex; use window_showing_on_its_workspace to determine the correct value
2004-10-22 20:28:36 +00:00
workspace_of_window && workspace_of_window->showing_desktop &&
show the window if it's a transient of a dock or desktop, since otherwise 2003-11-07 Rob Adams <readams@readams.net> * src/window.c (window_should_be_showing): show the window if it's a transient of a dock or desktop, since otherwise such windows are invisible in show desktop mode. Fix for #124648.
2003-11-08 05:29:23 +00:00
!is_desktop_or_dock)
raise/focus windows on left-click, seem to have broken that yesterday 2001-10-14 Havoc Pennington <hp@pobox.com> * src/frames.c (meta_frames_button_press_event): raise/focus windows on left-click, seem to have broken that yesterday * src/keybindings.c, src/display.c, src/window.c: add keybinding to show/hide all normal windows (so you can see the desktop). Currently Ctrl+Alt+D, which I don't like, but yay.
2001-10-15 03:39:41 +00:00
{
Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to 2004-10-22 Elijah Newren <newren@math.utah.edu> Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to display windows as visible or hidden (#105665) * src/screen.c (queue_windows_showing): Revert the queue_windows_showing portion of the patch committed on 2004-10-16 for #142198--it was an ill-advised optimization. * src/window.c (window_showing_on_its_workspace, window_should_be_showing): split the old window_should_be_showing into these two functions, (set_net_wm_state): hidden state is more complex; use window_showing_on_its_workspace to determine the correct value
2004-10-22 20:28:36 +00:00
meta_verbose ("We're showing the desktop on the workspace(s) that window %s is on\n",
raise/focus windows on left-click, seem to have broken that yesterday 2001-10-14 Havoc Pennington <hp@pobox.com> * src/frames.c (meta_frames_button_press_event): raise/focus windows on left-click, seem to have broken that yesterday * src/keybindings.c, src/display.c, src/window.c: add keybinding to show/hide all normal windows (so you can see the desktop). Currently Ctrl+Alt+D, which I don't like, but yay.
2001-10-15 03:39:41 +00:00
window->desc);
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
showing = FALSE;
raise/focus windows on left-click, seem to have broken that yesterday 2001-10-14 Havoc Pennington <hp@pobox.com> * src/frames.c (meta_frames_button_press_event): raise/focus windows on left-click, seem to have broken that yesterday * src/keybindings.c, src/display.c, src/window.c: add keybinding to show/hide all normal windows (so you can see the desktop). Currently Ctrl+Alt+D, which I don't like, but yay.
2001-10-15 03:39:41 +00:00
}
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to 2004-10-22 Elijah Newren <newren@math.utah.edu> Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to display windows as visible or hidden (#105665) * src/screen.c (queue_windows_showing): Revert the queue_windows_showing portion of the patch committed on 2004-10-16 for #142198--it was an ill-advised optimization. * src/window.c (window_showing_on_its_workspace, window_should_be_showing): split the old window_should_be_showing into these two functions, (set_net_wm_state): hidden state is more complex; use window_showing_on_its_workspace to determine the correct value
2004-10-22 20:28:36 +00:00
/* 3. See if an ancestor is minimized (note that
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
* ancestor's "mapped" field may not be up to date
* since it's being computed in this same idle queue)
*/
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
if (showing)
{
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
if (ancestor_is_minimized (window))
showing = FALSE;
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
}
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
return showing;
}
When snap-moving, don't snap to transients of minimized windows since they 2004-12-19 Elijah Newren <newren@gmail.com> When snap-moving, don't snap to transients of minimized windows since they are hidden. Fixes #157180 * src/place.c (get_windows_on_same_workspace): make the logic to determine hidden windows more thorough by calling meta_window_should_be_showing() * src/window.c (meta_window_should_be_showing): rename this function from window_should_be_showing and also export it, (implement_showing): s/window_should_be_showing/meta_window_should_be_showing/, (idle_calc_showing): s/window_should_be_showing/meta_window_should_be_showing/ * src/window.h (meta_window_should_be_showing): Add this function to the list so that it can be used in src/place.c
2004-12-20 02:53:08 +00:00
gboolean
meta_window_should_be_showing (MetaWindow *window)
Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to 2004-10-22 Elijah Newren <newren@math.utah.edu> Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to display windows as visible or hidden (#105665) * src/screen.c (queue_windows_showing): Revert the queue_windows_showing portion of the patch committed on 2004-10-16 for #142198--it was an ill-advised optimization. * src/window.c (window_showing_on_its_workspace, window_should_be_showing): split the old window_should_be_showing into these two functions, (set_net_wm_state): hidden state is more complex; use window_showing_on_its_workspace to determine the correct value
2004-10-22 20:28:36 +00:00
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
build: Fix non-wayland build This fixes error introduced in 09120132ef87061d527b5324a14ab5950db3dc0a. https://bugzilla.gnome.org/show_bug.cgi?id=750552
2015-06-17 10:37:20 +00:00
#ifdef HAVE_WAYLAND
core: Refrain from showing wayland windows when we don't have a buffer yet The "calc showing" operation is queued in a few places alongside MetaWindow creation, we should be ignoring these until there is a buffer to show. https://bugzilla.gnome.org/show_bug.cgi?id=750552
2015-06-08 09:55:54 +00:00
if (window->client_type == META_WINDOW_CLIENT_TYPE_WAYLAND &&
wayland: Move buffer use count to MetaWaylandSurface Each wl_surface.commit with a newly attached buffer should result in one wl_buffer.release for the attached buffer. For example attaching the same buffer to two different surfaces must always result in two wl_buffer.release events being emitted by the server. The client is responsible for counting the wl_buffer.release events and be sure to have received as many release events as it has attached and committed the buffer, before reusing it. https://bugzilla.gnome.org/show_bug.cgi?id=762828
2016-03-16 06:47:53 +00:00
!meta_wayland_surface_get_buffer (window->surface))
core: Refrain from showing wayland windows when we don't have a buffer yet The "calc showing" operation is queued in a few places alongside MetaWindow creation, we should be ignoring these until there is a buffer to show. https://bugzilla.gnome.org/show_bug.cgi?id=750552
2015-06-08 09:55:54 +00:00
return FALSE;
build: Fix non-wayland build This fixes error introduced in 09120132ef87061d527b5324a14ab5950db3dc0a. https://bugzilla.gnome.org/show_bug.cgi?id=750552
2015-06-17 10:37:20 +00:00
#endif
core: Refrain from showing wayland windows when we don't have a buffer yet The "calc showing" operation is queued in a few places alongside MetaWindow creation, we should be ignoring these until there is a buffer to show. https://bugzilla.gnome.org/show_bug.cgi?id=750552
2015-06-08 09:55:54 +00:00
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
/* Windows should be showing if they're located on the
* active workspace and they're showing on their own workspace. */
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
return (meta_window_located_on_workspace (window, workspace_manager->active_workspace) &&
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
meta_window_showing_on_its_workspace (window));
Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to 2004-10-22 Elijah Newren <newren@math.utah.edu> Update _NET_WM_STATE_HIDDEN so the pager on the panel will know whether to display windows as visible or hidden (#105665) * src/screen.c (queue_windows_showing): Revert the queue_windows_showing portion of the patch committed on 2004-10-16 for #142198--it was an ill-advised optimization. * src/window.c (window_showing_on_its_workspace, window_should_be_showing): split the old window_should_be_showing into these two functions, (set_net_wm_state): hidden state is more complex; use window_showing_on_its_workspace to determine the correct value
2004-10-22 20:28:36 +00:00
}
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
static void
implement_showing (MetaWindow *window,
gboolean showing)
{
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
/* Actually show/hide the window */
use window-props.h stuff for a couple of properties (implement_showing): 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_new): use window-props.h stuff for a couple of properties (implement_showing): fix printf string * src/xprops.c (meta_prop_free_values): new function * src/window-props.h, src/window-props.c: start moving code that handles loading window properties into this file.
2002-11-03 23:42:21 +00:00
meta_verbose ("Implement showing = %d for window %s\n",
showing, window->desc);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window: Defer stack placement without a buffer When closing a window and showing a new one, the new one may not be granted input focus until it gets a buffer on Wayland. If another window is chosen to receive focus and raised on top of stack, the newly mapped window is focused but placed underneath that other window. Meaning that for Wayland surfaces, we need to defer adding the window to the stack until we actually get to show it, once we have a buffer attached. Rather that checking the windowing backend prior to decide if a window is stackable or not, introduce a new vfunc is_stackable() which tells if a window should be added to the stack regardless of the underlying windowing system. Also add meta_window_is_in_stack() API rather than checking the stack position directly (replacing the define WINDOW_IN_STACK only available in stack.c) and remove a window from the stack only if it is present in the stack, so that the test in meta_stack_remote() becomes irrelevant. https://bugzilla.gnome.org/show_bug.cgi?id=780820
2018-01-09 12:19:40 +00:00
/* Some windows are not stackable until being showed, so add those now. */
if (meta_window_is_stackable (window) && !meta_window_is_in_stack (window))
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_add (window->display->stack, window);
window: Defer stack placement without a buffer When closing a window and showing a new one, the new one may not be granted input focus until it gets a buffer on Wayland. If another window is chosen to receive focus and raised on top of stack, the newly mapped window is focused but placed underneath that other window. Meaning that for Wayland surfaces, we need to defer adding the window to the stack until we actually get to show it, once we have a buffer attached. Rather that checking the windowing backend prior to decide if a window is stackable or not, introduce a new vfunc is_stackable() which tells if a window should be added to the stack regardless of the underlying windowing system. Also add meta_window_is_in_stack() API rather than checking the stack position directly (replacing the define WINDOW_IN_STACK only available in stack.c) and remove a window from the stack only if it is present in the stack, so that the test in meta_stack_remote() becomes irrelevant. https://bugzilla.gnome.org/show_bug.cgi?id=780820
2018-01-09 12:19:40 +00:00
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
if (!showing)
When live_hidden_previews is set, force placement for hidden windows If we are previewing hidden windows, we might be previewing them in a context like a thumbnail view of a workspace where we care about positioning. So, instead of waiting until the window is first actually shown to place it, if live_hidden_previews is set, place the window window when we first compute its visibility, even if we don't end up showing it. https://bugzilla.gnome.org/show_bug.cgi?id=641309
2011-02-03 00:14:27 +00:00
{
/* When we manage a new window, we normally delay placing it
* until it is is first shown, but if we're previewing hidden
* windows we might want to know where they are on the screen,
* so we should place the window even if we're hiding it rather
* than showing it.
window: do not force placing window if it is not mapped When managing window, we queue showing the window. Under wayland, if we commit surface quickly enough, the showing is unqueued and commit procedure takes care of mapping and placing the window. In the oposite case, queue is processed before client sets all we need and then we have wrong size of window, which leads to broken placement. Therefore force placement in queue only if the window should already be mapped. If it is not mapped, we don't care where it is anyway. https://bugzilla.gnome.org/show_bug.cgi?id=751887
2015-07-10 15:24:55 +00:00
* Force placing windows only when they should be already mapped,
* see #751887
When live_hidden_previews is set, force placement for hidden windows If we are previewing hidden windows, we might be previewing them in a context like a thumbnail view of a workspace where we care about positioning. So, instead of waiting until the window is first actually shown to place it, if live_hidden_previews is set, place the window window when we first compute its visibility, even if we don't end up showing it. https://bugzilla.gnome.org/show_bug.cgi?id=641309
2011-02-03 00:14:27 +00:00
*/
window: do not force placing window if it is not mapped When managing window, we queue showing the window. Under wayland, if we commit surface quickly enough, the showing is unqueued and commit procedure takes care of mapping and placing the window. In the oposite case, queue is processed before client sets all we need and then we have wrong size of window, which leads to broken placement. Therefore force placement in queue only if the window should already be mapped. If it is not mapped, we don't care where it is anyway. https://bugzilla.gnome.org/show_bug.cgi?id=751887
2015-07-10 15:24:55 +00:00
if (!window->placed && client_window_should_be_mapped (window))
wayland: update location prior to maximize When maximizing a window, the previous location is saved so that un-maximize would restore the same original window location. However, if a Wayland client starts with a window maximized, the previous location will be 0x0, so if we have to force placement in xdg_toplevel_set_maximized(), we should update the location as well so that the window is placed on the right monitor when un-maximizing. For that purpose, add a new flag to force the update of the window location, and use that flag from xdg_toplevel_set_maximized(). https://bugzilla.gnome.org/show_bug.cgi?id=783901
2017-06-21 11:30:22 +00:00
meta_window_force_placement (window, FALSE);
When live_hidden_previews is set, force placement for hidden windows If we are previewing hidden windows, we might be previewing them in a context like a thumbnail view of a workspace where we care about positioning. So, instead of waiting until the window is first actually shown to place it, if live_hidden_previews is set, place the window window when we first compute its visibility, even if we don't end up showing it. https://bugzilla.gnome.org/show_bug.cgi?id=641309
2011-02-03 00:14:27 +00:00
meta_window_hide (window);
}
...
2001-06-06 04:47:37 +00:00
else
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
meta_window_show (window);
window: Don't map the client window before placing it A lot of applications assume that the window is fully positioned when it gets the MapNotify, especially simple applications. Make sure that the window is only mapped through the calc_showing logic.
2014-09-01 18:44:48 +00:00
if (!window->override_redirect)
sync_client_window_mapped (window);
...
2001-06-06 04:47:37 +00:00
}
...
2001-06-22 03:20:21 +00:00
window: Make calc_showing private
2014-09-01 18:42:16 +00:00
static void
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
meta_window_calc_showing (MetaWindow *window)
{
When snap-moving, don't snap to transients of minimized windows since they 2004-12-19 Elijah Newren <newren@gmail.com> When snap-moving, don't snap to transients of minimized windows since they are hidden. Fixes #157180 * src/place.c (get_windows_on_same_workspace): make the logic to determine hidden windows more thorough by calling meta_window_should_be_showing() * src/window.c (meta_window_should_be_showing): rename this function from window_should_be_showing and also export it, (implement_showing): s/window_should_be_showing/meta_window_should_be_showing/, (idle_calc_showing): s/window_should_be_showing/meta_window_should_be_showing/ * src/window.h (meta_window_should_be_showing): Add this function to the list so that it can be used in src/place.c
2004-12-20 02:53:08 +00:00
implement_showing (window, meta_window_should_be_showing (window));
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
}
...
2001-06-22 03:20:21 +00:00
Use "later functions" to fix priority problems with Clutter redraw There was a problem where if, for example, a restack was triggered out of a clutter event handler, then after Clutter processed the events, it would proceed immmediately on to repaint the stage without ever returning control to the GLib main loop. So even though we had an idle handler installed with a higher priority than the Clutter stage repainting the clutter stage repainting would happen first and we'd get a wrong frame. Fix this by introducing the idea of "later functions", which abstract the idea of "doing something later" away from g_idle_add() and use a combination of GLib idle functions and Clutter "repaint functions" to get our callbacks triggered at the right time, even when they are installed from a clutter event handler. https://bugzilla.gnome.org/show_bug.cgi?id=596334 This also resolve a FIXME where MUTTER_PRIORITY_BEFORE_REDRAW could starve stage repainting.
2009-09-25 19:47:22 +00:00
static guint queue_later[NUMBER_OF_QUEUES] = {0, 0, 0};
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
static GSList *queue_pending[NUMBER_OF_QUEUES] = {NULL, NULL, NULL};
...
2001-06-22 03:20:21 +00:00
...
2001-06-24 08:09:10 +00:00
static int
stackcmp (gconstpointer a, gconstpointer b)
{
MetaWindow *aw = (gpointer) a;
MetaWindow *bw = (gpointer) b;
Stop using MetaScreen where it is unnecessary https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:43:17 +00:00
return meta_stack_windows_cmp (aw->display->stack,
aw, bw);
...
2001-06-24 08:09:10 +00:00
}
...
2001-06-22 03:20:21 +00:00
static gboolean
idle_calc_showing (gpointer data)
{
GSList *tmp;
handle queue/unqueue of calc showings as we are iterating over the pending 2001-10-29 Havoc Pennington <hp@pobox.com> * src/window.c (idle_calc_showing): handle queue/unqueue of calc showings as we are iterating over the pending list (meta_window_show): focus placed transients in here instead of in meta_window_place - now it should actually work, yay * src/place.c (meta_window_place): remove focusing of transient child from here; this was really broken
2001-10-30 02:00:53 +00:00
GSList *copy;
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
GSList *should_show;
GSList *should_hide;
GSList *unplaced;
CVS2003-05-29 Rob Adams <robadams@ucla.edu> CVS2003-05-29 Rob Adams <robadams@ucla.edu> Use a new property _METACITY_SENTINEL to eliminate a race condition that causes focus to behave badly with sloppy/mouse focus when lots of windows are mapped/unmapped, such as with a workspace switch. The EnterNotify events on a display are ignored until the PropertyNotify sent after all the window maps is received. This is a fix for #110970. * src/display.[ch]: New _METACITY_SENTINEL atom. (event_callback): ignore EnterNotify if the sentinel isn't clear, and decrement the sentinel counter when the PropertyNotify is received. (meta_display_increment_focus_sentinel): new function. Increments the sentinel counter and updates the property on a root window on this display. (meta_display_decrement_focus_sentinel): Decrement the sentinel counter. (meta_display_focus_sentinel_clear): returns whether the sentinel counter is zero. * src/window.c (idle_calc_showing): after showing windows, call meta_display_increment_focus_sentinel on each display for windows to be shown. * src/workspace.[ch] (meta_workspace_activate_with_focus): new function activates a workspace and focuses a particular window after the workspace is activated. (meta_workspace_activate): now just a wrapper for meta_workspace_activate_with_focus * src/keybindings.c: use new meta_workspace_activate_with_focus function to ensure that focus will follow the focused window through the workspace switch. : ----------------------------------------------------------------------
2003-05-30 20:24:00 +00:00
GSList *displays;
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
guint queue_index = GPOINTER_TO_INT (data);
Make choice of focus window be consistent for each focus mode. Fixes 2004-06-24 Elijah Newren <newren@math.utah.edu> Make choice of focus window be consistent for each focus mode. Fixes #135810. * src/delete.c: (meta_window_delete): In some #if 0'ed code, replace meta_workspace_focus_mru_window with meta_workspace_focus_default_window (just in case the code becomes un-#if 0'ed out). * src/screen.c, src/screen.h: Change meta_screen_focus_mouse_window to meta_screen_get_mouse_window, and don't focus the window when found but rather return it. * src/window.c: (meta_window_free, meta_window_minimize): replace meta_workspace_focus_mru_window with meta_workspace_focus_default_window. * src/workspace.c: (meta_workspace_focus_default_window): Focus appropriately for the given focus method: click-to-focus: focus MRU window (== toplevel window) sloppy focus: focus the window under the pointer if there is such a window, otherwise focus the mru window mouse focus: focus the window under the pointer if there is such a window, otherwise don't focus anything
2004-06-24 20:02:46 +00:00
window: don't crash on spurious calls to idle_calc_showing() If idle_calc_showing() gets called when its queue is empty (which shouldn't happen), just return rather than crashing. https://bugzilla.gnome.org/show_bug.cgi?id=642957
2011-03-29 19:16:23 +00:00
g_return_val_if_fail (queue_pending[queue_index] != NULL, FALSE);
Throughout: move to meta_topic rather than meta_verbose so metacity.log 2002-02-07 Havoc Pennington <hp@pobox.com> Throughout: move to meta_topic rather than meta_verbose so metacity.log can start being more useful * src/util.h (enum): add more debug topics * src/frames.c: clean up some cruft that caused warnings
2002-02-08 03:34:26 +00:00
meta_topic (META_DEBUG_WINDOW_STATE,
"Clearing the calc_showing queue\n");
handle queue/unqueue of calc showings as we are iterating over the pending 2001-10-29 Havoc Pennington <hp@pobox.com> * src/window.c (idle_calc_showing): handle queue/unqueue of calc showings as we are iterating over the pending list (meta_window_show): focus placed transients in here instead of in meta_window_place - now it should actually work, yay * src/place.c (meta_window_place): remove focusing of transient child from here; this was really broken
2001-10-30 02:00:53 +00:00
/* Work with a copy, for reentrancy. The allowed reentrancy isn't
* complete; destroying a window while we're in here would result in
* badness. But it's OK to queue/unqueue calc_showings.
*/
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
copy = g_slist_copy (queue_pending[queue_index]);
g_slist_free (queue_pending[queue_index]);
queue_pending[queue_index] = NULL;
Use "later functions" to fix priority problems with Clutter redraw There was a problem where if, for example, a restack was triggered out of a clutter event handler, then after Clutter processed the events, it would proceed immmediately on to repaint the stage without ever returning control to the GLib main loop. So even though we had an idle handler installed with a higher priority than the Clutter stage repainting the clutter stage repainting would happen first and we'd get a wrong frame. Fix this by introducing the idea of "later functions", which abstract the idea of "doing something later" away from g_idle_add() and use a combination of GLib idle functions and Clutter "repaint functions" to get our callbacks triggered at the right time, even when they are installed from a clutter event handler. https://bugzilla.gnome.org/show_bug.cgi?id=596334 This also resolve a FIXME where MUTTER_PRIORITY_BEFORE_REDRAW could starve stage repainting.
2009-09-25 19:47:22 +00:00
queue_later[queue_index] = 0;
give priority to keeping NW corner onscreen rather than SE, if we need to 2002-01-18 Havoc Pennington <hp@pobox.com> * src/window.c (constrain_position): give priority to keeping NW corner onscreen rather than SE, if we need to shift the window to fit inside constraints * src/frames.c (meta_frames_get_geometry): don't depend on the current window size * src/theme.c: move geometry stuff in here, to be calculated as part of the theme * src/core.c (meta_core_get_client_size): new function to replace meta_core_get_frame_size() so we don't have weird cycles in the geometry calculation
2002-01-19 03:50:03 +00:00
destroying_windows_disallowed += 1;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
/* We map windows from top to bottom and unmap from bottom to
* top, to avoid extra expose events. The exception is
* for unplaced windows, which have to be mapped from bottom to
* top so placement works.
...
2001-06-24 08:09:10 +00:00
*/
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
should_show = NULL;
should_hide = NULL;
unplaced = NULL;
CVS2003-05-29 Rob Adams <robadams@ucla.edu> CVS2003-05-29 Rob Adams <robadams@ucla.edu> Use a new property _METACITY_SENTINEL to eliminate a race condition that causes focus to behave badly with sloppy/mouse focus when lots of windows are mapped/unmapped, such as with a workspace switch. The EnterNotify events on a display are ignored until the PropertyNotify sent after all the window maps is received. This is a fix for #110970. * src/display.[ch]: New _METACITY_SENTINEL atom. (event_callback): ignore EnterNotify if the sentinel isn't clear, and decrement the sentinel counter when the PropertyNotify is received. (meta_display_increment_focus_sentinel): new function. Increments the sentinel counter and updates the property on a root window on this display. (meta_display_decrement_focus_sentinel): Decrement the sentinel counter. (meta_display_focus_sentinel_clear): returns whether the sentinel counter is zero. * src/window.c (idle_calc_showing): after showing windows, call meta_display_increment_focus_sentinel on each display for windows to be shown. * src/workspace.[ch] (meta_workspace_activate_with_focus): new function activates a workspace and focuses a particular window after the workspace is activated. (meta_workspace_activate): now just a wrapper for meta_workspace_activate_with_focus * src/keybindings.c: use new meta_workspace_activate_with_focus function to ensure that focus will follow the focused window through the workspace switch. : ----------------------------------------------------------------------
2003-05-30 20:24:00 +00:00
displays = NULL;
handle queue/unqueue of calc showings as we are iterating over the pending 2001-10-29 Havoc Pennington <hp@pobox.com> * src/window.c (idle_calc_showing): handle queue/unqueue of calc showings as we are iterating over the pending list (meta_window_show): focus placed transients in here instead of in meta_window_place - now it should actually work, yay * src/place.c (meta_window_place): remove focusing of transient child from here; this was really broken
2001-10-30 02:00:53 +00:00
tmp = copy;
...
2001-06-22 03:20:21 +00:00
while (tmp != NULL)
{
MetaWindow *window;
window = tmp->data;
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
if (!window->placed)
unplaced = g_slist_prepend (unplaced, window);
When snap-moving, don't snap to transients of minimized windows since they 2004-12-19 Elijah Newren <newren@gmail.com> When snap-moving, don't snap to transients of minimized windows since they are hidden. Fixes #157180 * src/place.c (get_windows_on_same_workspace): make the logic to determine hidden windows more thorough by calling meta_window_should_be_showing() * src/window.c (meta_window_should_be_showing): rename this function from window_should_be_showing and also export it, (implement_showing): s/window_should_be_showing/meta_window_should_be_showing/, (idle_calc_showing): s/window_should_be_showing/meta_window_should_be_showing/ * src/window.h (meta_window_should_be_showing): Add this function to the list so that it can be used in src/place.c
2004-12-20 02:53:08 +00:00
else if (meta_window_should_be_showing (window))
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
should_show = g_slist_prepend (should_show, window);
else
should_hide = g_slist_prepend (should_hide, window);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
tmp = tmp->next;
}
/* bottom to top */
unplaced = g_slist_sort (unplaced, stackcmp);
should_hide = g_slist_sort (should_hide, stackcmp);
/* top to bottom */
should_show = g_slist_sort (should_show, stackcmp);
should_show = g_slist_reverse (should_show);
Fix http://bugzilla.gnome.org/show_bug.cgi?id=381127: 2006-12-03 Federico Mena Quintero <federico@novell.com> Fix http://bugzilla.gnome.org/show_bug.cgi?id=381127: * src/window.c (idle_calc_showing): Grab the server while the windows are being shuffled. First show the windows to be shown, and then hide the windows to be hidden, in order to minimize the number of expose events.
2006-12-03 20:05:23 +00:00
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
tmp = unplaced;
while (tmp != NULL)
{
MetaWindow *window;
window = tmp->data;
...
2001-06-22 03:20:21 +00:00
meta_window_calc_showing (window);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
tmp = tmp->next;
}
Fix http://bugzilla.gnome.org/show_bug.cgi?id=381127: 2006-12-03 Federico Mena Quintero <federico@novell.com> Fix http://bugzilla.gnome.org/show_bug.cgi?id=381127: * src/window.c (idle_calc_showing): Grab the server while the windows are being shuffled. First show the windows to be shown, and then hide the windows to be hidden, in order to minimize the number of expose events.
2006-12-03 20:05:23 +00:00
tmp = should_show;
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
while (tmp != NULL)
{
MetaWindow *window;
window = tmp->data;
Fix http://bugzilla.gnome.org/show_bug.cgi?id=381127: 2006-12-03 Federico Mena Quintero <federico@novell.com> Fix http://bugzilla.gnome.org/show_bug.cgi?id=381127: * src/window.c (idle_calc_showing): Grab the server while the windows are being shuffled. First show the windows to be shown, and then hide the windows to be hidden, in order to minimize the number of expose events.
2006-12-03 20:05:23 +00:00
implement_showing (window, TRUE);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
tmp = tmp->next;
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Fix http://bugzilla.gnome.org/show_bug.cgi?id=381127: 2006-12-03 Federico Mena Quintero <federico@novell.com> Fix http://bugzilla.gnome.org/show_bug.cgi?id=381127: * src/window.c (idle_calc_showing): Grab the server while the windows are being shuffled. First show the windows to be shown, and then hide the windows to be hidden, in order to minimize the number of expose events.
2006-12-03 20:05:23 +00:00
tmp = should_hide;
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
while (tmp != NULL)
{
MetaWindow *window;
window = tmp->data;
Fix http://bugzilla.gnome.org/show_bug.cgi?id=381127: 2006-12-03 Federico Mena Quintero <federico@novell.com> Fix http://bugzilla.gnome.org/show_bug.cgi?id=381127: * src/window.c (idle_calc_showing): Grab the server while the windows are being shuffled. First show the windows to be shown, and then hide the windows to be hidden, in order to minimize the number of expose events.
2006-12-03 20:05:23 +00:00
implement_showing (window, FALSE);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
tmp = tmp->next;
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
tmp = copy;
while (tmp != NULL)
{
MetaWindow *window;
window = tmp->data;
give priority to keeping NW corner onscreen rather than SE, if we need to 2002-01-18 Havoc Pennington <hp@pobox.com> * src/window.c (constrain_position): give priority to keeping NW corner onscreen rather than SE, if we need to shift the window to fit inside constraints * src/frames.c (meta_frames_get_geometry): don't depend on the current window size * src/theme.c: move geometry stuff in here, to be calculated as part of the theme * src/core.c (meta_core_get_client_size): new function to replace meta_core_get_frame_size() so we don't have weird cycles in the geometry calculation
2002-01-19 03:50:03 +00:00
/* important to set this here for reentrancy -
* if we queue a window again while it's in "copy",
* then queue_calc_showing will just return since
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
* we are still in the calc_showing queue
give priority to keeping NW corner onscreen rather than SE, if we need to 2002-01-18 Havoc Pennington <hp@pobox.com> * src/window.c (constrain_position): give priority to keeping NW corner onscreen rather than SE, if we need to shift the window to fit inside constraints * src/frames.c (meta_frames_get_geometry): don't depend on the current window size * src/theme.c: move geometry stuff in here, to be calculated as part of the theme * src/core.c (meta_core_get_client_size): new function to replace meta_core_get_frame_size() so we don't have weird cycles in the geometry calculation
2002-01-19 03:50:03 +00:00
*/
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
window->is_in_queues &= ~META_QUEUE_CALC_SHOWING;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-06-22 03:20:21 +00:00
tmp = tmp->next;
}
CVS2003-05-29 Rob Adams <robadams@ucla.edu> CVS2003-05-29 Rob Adams <robadams@ucla.edu> Use a new property _METACITY_SENTINEL to eliminate a race condition that causes focus to behave badly with sloppy/mouse focus when lots of windows are mapped/unmapped, such as with a workspace switch. The EnterNotify events on a display are ignored until the PropertyNotify sent after all the window maps is received. This is a fix for #110970. * src/display.[ch]: New _METACITY_SENTINEL atom. (event_callback): ignore EnterNotify if the sentinel isn't clear, and decrement the sentinel counter when the PropertyNotify is received. (meta_display_increment_focus_sentinel): new function. Increments the sentinel counter and updates the property on a root window on this display. (meta_display_decrement_focus_sentinel): Decrement the sentinel counter. (meta_display_focus_sentinel_clear): returns whether the sentinel counter is zero. * src/window.c (idle_calc_showing): after showing windows, call meta_display_increment_focus_sentinel on each display for windows to be shown. * src/workspace.[ch] (meta_workspace_activate_with_focus): new function activates a workspace and focuses a particular window after the workspace is activated. (meta_workspace_activate): now just a wrapper for meta_workspace_activate_with_focus * src/keybindings.c: use new meta_workspace_activate_with_focus function to ensure that focus will follow the focused window through the workspace switch. : ----------------------------------------------------------------------
2003-05-30 20:24:00 +00:00
Port preferences to GSettings Move preferences to GSettings, using mainly shared schemas from gsettings-desktop-schemas. Unlike GConf, GSettings support is not optional, as Gio is already a hard dependency of GTK+. https://bugzilla.gnome.org/show_bug.cgi?id=635378
2011-06-24 16:14:15 +00:00
if (meta_prefs_get_focus_mode () != G_DESKTOP_FOCUS_MODE_CLICK)
Handle keynav vs. mousenav in mouse and sloppy focus modes. Fixes #167545. 2005-02-21 Elijah Newren <newren@gmail.com> Handle keynav vs. mousenav in mouse and sloppy focus modes. Fixes #167545. * doc/how-to-get-focus-right.txt: Update due to this new method for handling keynav vs. mousenav, plus various other updates that I previously forgot. * src/display.h: (struct _MetaDisplay): add a mouse_mode boolean * src/display.c: (meta_display_open): initialize mouse_mode to true, (event_callback): have EnterNotify and LeaveNotify events set mouse_mode to true when focusing a window * src/keybindings.c: (process_tab_grab): set mouse_mode to false when using alt-tab/alt-esc, (do_choose_window): likewise, (do_handle_move_to_workspace): set mouse_mode to false on move-window-to-workspace-<n> keybindings * src/window.c (idle_calc_showing): if we're in keynav mode while using sloppy or mouse focus, use metacity_sentinel to avoid EnterNotify events being generated from events other than mouse movement. * src/workspace.c (meta_workspace_activate_with_focus): add a FIXME in a potentially duplicate section of code, (meta_workspace_focus_default_window): use the same focus choice as click-to-focus if in keynav mode.
2005-02-22 02:11:25 +00:00
{
/* When display->mouse_mode is false, we want to ignore
* EnterNotify events unless they come from mouse motion. To do
* that, we set a sentinel property on the root window if we're
* not in mouse_mode.
*/
tmp = should_show;
while (tmp != NULL)
{
MetaWindow *window = tmp->data;
x11: Move focus sentinel to MetaX11Display This focus sentinel is a mechanism to avoid some X11-specific race conditions in focus-follows-pointer, using X11 mechanisms. Move it to MetaX11Display altogether. https://gitlab.gnome.org/GNOME/mutter/merge_requests/420
2018-12-30 11:58:31 +00:00
MetaDisplay *display = window->display;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
x11: Move focus sentinel to MetaX11Display This focus sentinel is a mechanism to avoid some X11-specific race conditions in focus-follows-pointer, using X11 mechanisms. Move it to MetaX11Display altogether. https://gitlab.gnome.org/GNOME/mutter/merge_requests/420
2018-12-30 11:58:31 +00:00
if (display->x11_display && !display->mouse_mode)
meta_x11_display_increment_focus_sentinel (display->x11_display);
Handle keynav vs. mousenav in mouse and sloppy focus modes. Fixes #167545. 2005-02-21 Elijah Newren <newren@gmail.com> Handle keynav vs. mousenav in mouse and sloppy focus modes. Fixes #167545. * doc/how-to-get-focus-right.txt: Update due to this new method for handling keynav vs. mousenav, plus various other updates that I previously forgot. * src/display.h: (struct _MetaDisplay): add a mouse_mode boolean * src/display.c: (meta_display_open): initialize mouse_mode to true, (event_callback): have EnterNotify and LeaveNotify events set mouse_mode to true when focusing a window * src/keybindings.c: (process_tab_grab): set mouse_mode to false when using alt-tab/alt-esc, (do_choose_window): likewise, (do_handle_move_to_workspace): set mouse_mode to false on move-window-to-workspace-<n> keybindings * src/window.c (idle_calc_showing): if we're in keynav mode while using sloppy or mouse focus, use metacity_sentinel to avoid EnterNotify events being generated from events other than mouse movement. * src/workspace.c (meta_workspace_activate_with_focus): add a FIXME in a potentially duplicate section of code, (meta_workspace_focus_default_window): use the same focus choice as click-to-focus if in keynav mode.
2005-02-22 02:11:25 +00:00
tmp = tmp->next;
}
}
handle queue/unqueue of calc showings as we are iterating over the pending 2001-10-29 Havoc Pennington <hp@pobox.com> * src/window.c (idle_calc_showing): handle queue/unqueue of calc showings as we are iterating over the pending list (meta_window_show): focus placed transients in here instead of in meta_window_place - now it should actually work, yay * src/place.c (meta_window_place): remove focusing of transient child from here; this was really broken
2001-10-30 02:00:53 +00:00
g_slist_free (copy);
give priority to keeping NW corner onscreen rather than SE, if we need to 2002-01-18 Havoc Pennington <hp@pobox.com> * src/window.c (constrain_position): give priority to keeping NW corner onscreen rather than SE, if we need to shift the window to fit inside constraints * src/frames.c (meta_frames_get_geometry): don't depend on the current window size * src/theme.c: move geometry stuff in here, to be calculated as part of the theme * src/core.c (meta_core_get_client_size): new function to replace meta_core_get_frame_size() so we don't have weird cycles in the geometry calculation
2002-01-19 03:50:03 +00:00
split into "see if we should be showing" and "actually show/hide" 2002-11-03 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_calc_showing): split into "see if we should be showing" and "actually show/hide" functions (idle_calc_showing): rework to first unmap all newly-hidden windows from bottom to top then map all newly-showing windows from top to bottom resulting in fewer exposes, #95220
2002-11-03 20:30:45 +00:00
g_slist_free (unplaced);
g_slist_free (should_show);
g_slist_free (should_hide);
CVS2003-05-29 Rob Adams <robadams@ucla.edu> CVS2003-05-29 Rob Adams <robadams@ucla.edu> Use a new property _METACITY_SENTINEL to eliminate a race condition that causes focus to behave badly with sloppy/mouse focus when lots of windows are mapped/unmapped, such as with a workspace switch. The EnterNotify events on a display are ignored until the PropertyNotify sent after all the window maps is received. This is a fix for #110970. * src/display.[ch]: New _METACITY_SENTINEL atom. (event_callback): ignore EnterNotify if the sentinel isn't clear, and decrement the sentinel counter when the PropertyNotify is received. (meta_display_increment_focus_sentinel): new function. Increments the sentinel counter and updates the property on a root window on this display. (meta_display_decrement_focus_sentinel): Decrement the sentinel counter. (meta_display_focus_sentinel_clear): returns whether the sentinel counter is zero. * src/window.c (idle_calc_showing): after showing windows, call meta_display_increment_focus_sentinel on each display for windows to be shown. * src/workspace.[ch] (meta_workspace_activate_with_focus): new function activates a workspace and focuses a particular window after the workspace is activated. (meta_workspace_activate): now just a wrapper for meta_workspace_activate_with_focus * src/keybindings.c: use new meta_workspace_activate_with_focus function to ensure that focus will follow the focused window through the workspace switch. : ----------------------------------------------------------------------
2003-05-30 20:24:00 +00:00
g_slist_free (displays);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
give priority to keeping NW corner onscreen rather than SE, if we need to 2002-01-18 Havoc Pennington <hp@pobox.com> * src/window.c (constrain_position): give priority to keeping NW corner onscreen rather than SE, if we need to shift the window to fit inside constraints * src/frames.c (meta_frames_get_geometry): don't depend on the current window size * src/theme.c: move geometry stuff in here, to be calculated as part of the theme * src/core.c (meta_core_get_client_size): new function to replace meta_core_get_frame_size() so we don't have weird cycles in the geometry calculation
2002-01-19 03:50:03 +00:00
destroying_windows_disallowed -= 1;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-06-22 03:20:21 +00:00
return FALSE;
}
Don't define meta_spew_event unless verbose mode is on. Closes #571126. svn path=/trunk/; revision=4132
2009-02-11 04:34:17 +00:00
#ifdef WITH_VERBOSE_MODE
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
static const gchar* meta_window_queue_names[NUMBER_OF_QUEUES] =
{"calc_showing", "move_resize", "update_icon"};
Don't define meta_spew_event unless verbose mode is on. Closes #571126. svn path=/trunk/; revision=4132
2009-02-11 04:34:17 +00:00
#endif
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
Patch from Kjartan Maraas to fix a lot of tiny issues (unused variable 2006-01-20 Elijah Newren <newren gmail com> * src/async-getprop.c: * src/common.h: * src/display.c: * src/eggaccelerators.c: * src/frames.c: * src/gradient.c: * src/iconcache.c: * src/keybindings.c: * src/metaaccellabel.c: * src/place.c: * src/prefs.c: * src/preview-widget.c: * src/screen.c: * src/session.c: * src/stack.c: * src/tabpopup.c: * src/theme-viewer.c: * src/theme.c: * src/window-props.c: * src/window.c: * src/workspace.c: * src/tools/metacity-window-demo.c: * src/wm-tester/test-gravity.c: * src/wm-tester/test-resizing.c: * src/wm-tester/test-size-hints.c: Patch from Kjartan Maraas to fix a lot of tiny issues (unused variable removal, making unused variables used again, correction of types passed/declared for printf arguments, removal of unneeded breaks and returns, dead code removal, dead code revival, renaming to prevent shadowed variables, declaring unexported functions as static) spotted by the intel compiler. #321439
2006-01-20 22:03:56 +00:00
static void
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
meta_window_unqueue (MetaWindow *window, guint queuebits)
...
2001-06-22 03:20:21 +00:00
{
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
gint queuenum;
handle queue/unqueue of calc showings as we are iterating over the pending 2001-10-29 Havoc Pennington <hp@pobox.com> * src/window.c (idle_calc_showing): handle queue/unqueue of calc showings as we are iterating over the pending list (meta_window_show): focus placed transients in here instead of in meta_window_place - now it should actually work, yay * src/place.c (meta_window_place): remove focusing of transient child from here; this was really broken
2001-10-30 02:00:53 +00:00
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
for (queuenum=0; queuenum<NUMBER_OF_QUEUES; queuenum++)
...
2001-06-22 03:20:21 +00:00
{
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
if ((queuebits & 1<<queuenum) /* they have asked to unqueue */
&&
(window->is_in_queues & 1<<queuenum)) /* it's in the queue */
{
meta_topic (META_DEBUG_WINDOW_STATE,
"Removing %s from the %s queue\n",
window->desc,
meta_window_queue_names[queuenum]);
/* Note that window may not actually be in the queue
* because it may have been in "copy" inside the idle handler
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
*/
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
queue_pending[queuenum] = g_slist_remove (queue_pending[queuenum], window);
window->is_in_queues &= ~(1<<queuenum);
/* Okay, so maybe we've used up all the entries in the queue.
* In that case, we should kill the function that deals with
* the queue, because there's nothing left for it to do.
*/
Use "later functions" to fix priority problems with Clutter redraw There was a problem where if, for example, a restack was triggered out of a clutter event handler, then after Clutter processed the events, it would proceed immmediately on to repaint the stage without ever returning control to the GLib main loop. So even though we had an idle handler installed with a higher priority than the Clutter stage repainting the clutter stage repainting would happen first and we'd get a wrong frame. Fix this by introducing the idea of "later functions", which abstract the idea of "doing something later" away from g_idle_add() and use a combination of GLib idle functions and Clutter "repaint functions" to get our callbacks triggered at the right time, even when they are installed from a clutter event handler. https://bugzilla.gnome.org/show_bug.cgi?id=596334 This also resolve a FIXME where MUTTER_PRIORITY_BEFORE_REDRAW could starve stage repainting.
2009-09-25 19:47:22 +00:00
if (queue_pending[queuenum] == NULL && queue_later[queuenum] != 0)
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
{
Use "later functions" to fix priority problems with Clutter redraw There was a problem where if, for example, a restack was triggered out of a clutter event handler, then after Clutter processed the events, it would proceed immmediately on to repaint the stage without ever returning control to the GLib main loop. So even though we had an idle handler installed with a higher priority than the Clutter stage repainting the clutter stage repainting would happen first and we'd get a wrong frame. Fix this by introducing the idea of "later functions", which abstract the idea of "doing something later" away from g_idle_add() and use a combination of GLib idle functions and Clutter "repaint functions" to get our callbacks triggered at the right time, even when they are installed from a clutter event handler. https://bugzilla.gnome.org/show_bug.cgi?id=596334 This also resolve a FIXME where MUTTER_PRIORITY_BEFORE_REDRAW could starve stage repainting.
2009-09-25 19:47:22 +00:00
meta_later_remove (queue_later[queuenum]);
queue_later[queuenum] = 0;
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
}
}
...
2001-06-22 03:20:21 +00:00
}
}
Patch from Kjartan Maraas to fix a lot of tiny issues (unused variable 2006-01-20 Elijah Newren <newren gmail com> * src/async-getprop.c: * src/common.h: * src/display.c: * src/eggaccelerators.c: * src/frames.c: * src/gradient.c: * src/iconcache.c: * src/keybindings.c: * src/metaaccellabel.c: * src/place.c: * src/prefs.c: * src/preview-widget.c: * src/screen.c: * src/session.c: * src/stack.c: * src/tabpopup.c: * src/theme-viewer.c: * src/theme.c: * src/window-props.c: * src/window.c: * src/workspace.c: * src/tools/metacity-window-demo.c: * src/wm-tester/test-gravity.c: * src/wm-tester/test-resizing.c: * src/wm-tester/test-size-hints.c: Patch from Kjartan Maraas to fix a lot of tiny issues (unused variable removal, making unused variables used again, correction of types passed/declared for printf arguments, removal of unneeded breaks and returns, dead code removal, dead code revival, renaming to prevent shadowed variables, declaring unexported functions as static) spotted by the intel compiler. #321439
2006-01-20 22:03:56 +00:00
static void
note exciting new unminimize feature for the tab popup 2001-10-29 Havoc Pennington <hp@pobox.com> * README: note exciting new unminimize feature for the tab popup * src/keybindings.c (process_tab_grab): use meta_window_activate() when choosing a window with tab popup, this should deiconify it * src/window.c (meta_window_client_message): use meta_window_activate for _NET_ACTIVE_WINDOW message (meta_window_activate): new function to raise/focus/unminimize (meta_window_flush_calc_showing): new function (meta_window_focus): force a calc showing on focus, so that we can focus the window if appropriate (it must be mapped)
2001-10-29 07:00:46 +00:00
meta_window_flush_calc_showing (MetaWindow *window)
{
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
if (window->is_in_queues & META_QUEUE_CALC_SHOWING)
note exciting new unminimize feature for the tab popup 2001-10-29 Havoc Pennington <hp@pobox.com> * README: note exciting new unminimize feature for the tab popup * src/keybindings.c (process_tab_grab): use meta_window_activate() when choosing a window with tab popup, this should deiconify it * src/window.c (meta_window_client_message): use meta_window_activate for _NET_ACTIVE_WINDOW message (meta_window_activate): new function to raise/focus/unminimize (meta_window_flush_calc_showing): new function (meta_window_focus): force a calc showing on focus, so that we can focus the window if appropriate (it must be mapped)
2001-10-29 07:00:46 +00:00
{
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
meta_window_unqueue (window, META_QUEUE_CALC_SHOWING);
note exciting new unminimize feature for the tab popup 2001-10-29 Havoc Pennington <hp@pobox.com> * README: note exciting new unminimize feature for the tab popup * src/keybindings.c (process_tab_grab): use meta_window_activate() when choosing a window with tab popup, this should deiconify it * src/window.c (meta_window_client_message): use meta_window_activate for _NET_ACTIVE_WINDOW message (meta_window_activate): new function to raise/focus/unminimize (meta_window_flush_calc_showing): new function (meta_window_focus): force a calc showing on focus, so that we can focus the window if appropriate (it must be mapped)
2001-10-29 07:00:46 +00:00
meta_window_calc_showing (window);
}
}
...
2001-06-06 04:47:37 +00:00
void
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
meta_window_queue (MetaWindow *window, guint queuebits)
...
2001-06-06 04:47:37 +00:00
{
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
guint queuenum;
...
2001-06-22 03:20:21 +00:00
Avoid moving and resizing override-redirect windows Override-redirect windows should not be moved or resized by the window manager. - Mark override-redirect windows as already placed to avoid placing them when first shown. - Don't move-resize newly created override-redirect MetaWindow - Don't queue a resize on override-redirect windows when reading their WM_TRANSIENT_FOR hint. - Add g_return_if_fail (!window->override_redirect) to catch unexpected code paths that might result in override-redirect windows being moved or resized. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-15 22:25:07 +00:00
/* Easier to debug by checking here rather than in the idle */
g_return_if_fail (!window->override_redirect || (queuebits & META_QUEUE_MOVE_RESIZE) == 0);
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
for (queuenum=0; queuenum<NUMBER_OF_QUEUES; queuenum++)
{
if (queuebits & 1<<queuenum)
{
/* Data which varies between queues.
* Yes, these do look a lot like associative arrays:
* I seem to be turning into a Perl programmer.
*/
...
2001-06-22 03:20:21 +00:00
Use "later functions" to fix priority problems with Clutter redraw There was a problem where if, for example, a restack was triggered out of a clutter event handler, then after Clutter processed the events, it would proceed immmediately on to repaint the stage without ever returning control to the GLib main loop. So even though we had an idle handler installed with a higher priority than the Clutter stage repainting the clutter stage repainting would happen first and we'd get a wrong frame. Fix this by introducing the idea of "later functions", which abstract the idea of "doing something later" away from g_idle_add() and use a combination of GLib idle functions and Clutter "repaint functions" to get our callbacks triggered at the right time, even when they are installed from a clutter event handler. https://bugzilla.gnome.org/show_bug.cgi?id=596334 This also resolve a FIXME where MUTTER_PRIORITY_BEFORE_REDRAW could starve stage repainting.
2009-09-25 19:47:22 +00:00
const MetaLaterType window_queue_later_when[NUMBER_OF_QUEUES] =
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
{
MetaScreen: Add tracking of whether there are fullscreen windows Trying to track the fullscreen status outside of Mutter, as GNOME Shell was doing previously, was very prone to errors, because Mutter has a very tricky definition of when a window is set to be fullscreen and *actually* acting like a fullscreen window. * Add meta_screen_get_monitor_in_fullscreen() and an ::in-fullscreen-changed signal. This allows an application to track when there are fullscreen windows on a monitor. * Do the computation of fullscreen status in a "later" function that runs after showing, so we properly take focus into account. * To get ordering of different phases right, add more values to MetaLaterType. * Add auto-minimization, similar to what was added to GNOME Shell earlier in this cycle - if a window is set to be fullscreen, but not actually fullscreen, minimize. https://bugzilla.gnome.org/show_bug.cgi?id=649748
2013-03-14 20:55:49 +00:00
META_LATER_CALC_SHOWING, /* CALC_SHOWING */
Use "later functions" to fix priority problems with Clutter redraw There was a problem where if, for example, a restack was triggered out of a clutter event handler, then after Clutter processed the events, it would proceed immmediately on to repaint the stage without ever returning control to the GLib main loop. So even though we had an idle handler installed with a higher priority than the Clutter stage repainting the clutter stage repainting would happen first and we'd get a wrong frame. Fix this by introducing the idea of "later functions", which abstract the idea of "doing something later" away from g_idle_add() and use a combination of GLib idle functions and Clutter "repaint functions" to get our callbacks triggered at the right time, even when they are installed from a clutter event handler. https://bugzilla.gnome.org/show_bug.cgi?id=596334 This also resolve a FIXME where MUTTER_PRIORITY_BEFORE_REDRAW could starve stage repainting.
2009-09-25 19:47:22 +00:00
META_LATER_RESIZE, /* MOVE_RESIZE */
META_LATER_BEFORE_REDRAW /* UPDATE_ICON */
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
};
Use "later functions" to fix priority problems with Clutter redraw There was a problem where if, for example, a restack was triggered out of a clutter event handler, then after Clutter processed the events, it would proceed immmediately on to repaint the stage without ever returning control to the GLib main loop. So even though we had an idle handler installed with a higher priority than the Clutter stage repainting the clutter stage repainting would happen first and we'd get a wrong frame. Fix this by introducing the idea of "later functions", which abstract the idea of "doing something later" away from g_idle_add() and use a combination of GLib idle functions and Clutter "repaint functions" to get our callbacks triggered at the right time, even when they are installed from a clutter event handler. https://bugzilla.gnome.org/show_bug.cgi?id=596334 This also resolve a FIXME where MUTTER_PRIORITY_BEFORE_REDRAW could starve stage repainting.
2009-09-25 19:47:22 +00:00
const GSourceFunc window_queue_later_handler[NUMBER_OF_QUEUES] =
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
{
idle_calc_showing,
idle_move_resize,
idle_update_icon,
};
/* If we're about to drop the window, there's no point in putting
* it on a queue.
*/
if (window->unmanaging)
break;
/* If the window already claims to be in that queue, there's no
* point putting it in the queue.
*/
if (window->is_in_queues & 1<<queuenum)
break;
meta_topic (META_DEBUG_WINDOW_STATE,
"Putting %s in the %s queue\n",
window->desc,
meta_window_queue_names[queuenum]);
/* So, mark it as being in this queue. */
window->is_in_queues |= 1<<queuenum;
/* There's not a lot of point putting things into a queue if
* nobody's on the other end pulling them out. Therefore,
* let's check to see whether an idle handler exists to do
* that. If not, we'll create one.
*/
...
2001-06-22 03:20:21 +00:00
Use "later functions" to fix priority problems with Clutter redraw There was a problem where if, for example, a restack was triggered out of a clutter event handler, then after Clutter processed the events, it would proceed immmediately on to repaint the stage without ever returning control to the GLib main loop. So even though we had an idle handler installed with a higher priority than the Clutter stage repainting the clutter stage repainting would happen first and we'd get a wrong frame. Fix this by introducing the idea of "later functions", which abstract the idea of "doing something later" away from g_idle_add() and use a combination of GLib idle functions and Clutter "repaint functions" to get our callbacks triggered at the right time, even when they are installed from a clutter event handler. https://bugzilla.gnome.org/show_bug.cgi?id=596334 This also resolve a FIXME where MUTTER_PRIORITY_BEFORE_REDRAW could starve stage repainting.
2009-09-25 19:47:22 +00:00
if (queue_later[queuenum] == 0)
queue_later[queuenum] = meta_later_add
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
(
Use "later functions" to fix priority problems with Clutter redraw There was a problem where if, for example, a restack was triggered out of a clutter event handler, then after Clutter processed the events, it would proceed immmediately on to repaint the stage without ever returning control to the GLib main loop. So even though we had an idle handler installed with a higher priority than the Clutter stage repainting the clutter stage repainting would happen first and we'd get a wrong frame. Fix this by introducing the idea of "later functions", which abstract the idea of "doing something later" away from g_idle_add() and use a combination of GLib idle functions and Clutter "repaint functions" to get our callbacks triggered at the right time, even when they are installed from a clutter event handler. https://bugzilla.gnome.org/show_bug.cgi?id=596334 This also resolve a FIXME where MUTTER_PRIORITY_BEFORE_REDRAW could starve stage repainting.
2009-09-25 19:47:22 +00:00
window_queue_later_when[queuenum],
window_queue_later_handler[queuenum],
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
GUINT_TO_POINTER(queuenum),
NULL
);
/* And now we actually put it on the queue. */
queue_pending[queuenum] = g_slist_prepend (queue_pending[queuenum],
window);
}
}
...
2001-06-06 04:47:37 +00:00
}
always focus new windows, trying to be smart about it was a flop. 2002-06-14 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_show): always focus new windows, trying to be smart about it was a flop.
2002-06-15 01:46:13 +00:00
static gboolean
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
intervening_user_event_occurred (MetaWindow *window)
always focus new windows, trying to be smart about it was a flop. 2002-06-14 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_show): always focus new windows, trying to be smart about it was a flop.
2002-06-15 01:46:13 +00:00
{
Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ 2006-09-13 Elijah Newren <newren gmail com> * src/common.h (MetaWindowMenuFunc): * src/core.[ch] (meta_core_user_lower_and_unfocus, meta_core_user_focus, meta_core_show_window_menu, meta_core_begin_grab_op, meta_core_end_grab_op): * src/delete.c (delete_ping_reply_func, delete_ping_timeout_func, meta_window_delete): * src/display.[ch] (struct MetaDisplay, struct MetaPingData, sanity_check_timestamps, meta_display_open, event_callback, meta_spew_event, meta_display_set_grab_op_cursor, meta_display_begin_grab_op, meta_display_end_grab_op, meta_display_ping_timeout, meta_display_ping_window, process_pong_message, timestamp_too_old, meta_display_set_input_focus_window): * src/keybindings.[ch] (grab_keyboard, ungrab_keyboard, meta_screen_grab_all_keys, meta_window_grab_all_keys, meta_window_ungrab_all_keys, error_on_generic_command, error_on_command, error_on_terminal_command): * src/metacity-dialog.c (on_realize, warn_about_no_sm_support, error_about_command, main): * src/screen.[ch] (struct _MetaScreen, meta_screen_new, meta_screen_show_desktop, meta_screen_apply_startup_properties): * src/session.c (warn_about_lame_clients_and_finish_interact): * src/window.[ch] (struct _MetaWindow, intervening_user_event_occurred, window_activate, meta_window_delete, meta_window_focus, meta_window_send_icccm_message, meta_window_client_message, menu_callback, meta_window_show_menu, struct EventScannerData, check_use_this_motion_notify, meta_window_begin_grab_op, meta_window_set_user_time): * src/workspace.[ch] (focus_ancestor_or_mru_window, meta_workspace_activate_with_focus, meta_workspace_activate, meta_workspace_focus_default_window, focus_ancestor_or_mru_window): Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ does) instead of Time. #348305
2006-09-13 16:32:33 +00:00
guint32 compare;
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
MetaWindow *focus_window;
focus_window = window->display->focus_window;
meta_topic (META_DEBUG_STARTUP,
"COMPARISON:\n"
" net_wm_user_time_set : %d\n"
Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ 2006-09-13 Elijah Newren <newren gmail com> * src/common.h (MetaWindowMenuFunc): * src/core.[ch] (meta_core_user_lower_and_unfocus, meta_core_user_focus, meta_core_show_window_menu, meta_core_begin_grab_op, meta_core_end_grab_op): * src/delete.c (delete_ping_reply_func, delete_ping_timeout_func, meta_window_delete): * src/display.[ch] (struct MetaDisplay, struct MetaPingData, sanity_check_timestamps, meta_display_open, event_callback, meta_spew_event, meta_display_set_grab_op_cursor, meta_display_begin_grab_op, meta_display_end_grab_op, meta_display_ping_timeout, meta_display_ping_window, process_pong_message, timestamp_too_old, meta_display_set_input_focus_window): * src/keybindings.[ch] (grab_keyboard, ungrab_keyboard, meta_screen_grab_all_keys, meta_window_grab_all_keys, meta_window_ungrab_all_keys, error_on_generic_command, error_on_command, error_on_terminal_command): * src/metacity-dialog.c (on_realize, warn_about_no_sm_support, error_about_command, main): * src/screen.[ch] (struct _MetaScreen, meta_screen_new, meta_screen_show_desktop, meta_screen_apply_startup_properties): * src/session.c (warn_about_lame_clients_and_finish_interact): * src/window.[ch] (struct _MetaWindow, intervening_user_event_occurred, window_activate, meta_window_delete, meta_window_focus, meta_window_send_icccm_message, meta_window_client_message, menu_callback, meta_window_show_menu, struct EventScannerData, check_use_this_motion_notify, meta_window_begin_grab_op, meta_window_set_user_time): * src/workspace.[ch] (focus_ancestor_or_mru_window, meta_workspace_activate_with_focus, meta_workspace_activate, meta_workspace_focus_default_window, focus_ancestor_or_mru_window): Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ does) instead of Time. #348305
2006-09-13 16:32:33 +00:00
" net_wm_user_time : %u\n"
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
" initial_timestamp_set: %d\n"
Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ 2006-09-13 Elijah Newren <newren gmail com> * src/common.h (MetaWindowMenuFunc): * src/core.[ch] (meta_core_user_lower_and_unfocus, meta_core_user_focus, meta_core_show_window_menu, meta_core_begin_grab_op, meta_core_end_grab_op): * src/delete.c (delete_ping_reply_func, delete_ping_timeout_func, meta_window_delete): * src/display.[ch] (struct MetaDisplay, struct MetaPingData, sanity_check_timestamps, meta_display_open, event_callback, meta_spew_event, meta_display_set_grab_op_cursor, meta_display_begin_grab_op, meta_display_end_grab_op, meta_display_ping_timeout, meta_display_ping_window, process_pong_message, timestamp_too_old, meta_display_set_input_focus_window): * src/keybindings.[ch] (grab_keyboard, ungrab_keyboard, meta_screen_grab_all_keys, meta_window_grab_all_keys, meta_window_ungrab_all_keys, error_on_generic_command, error_on_command, error_on_terminal_command): * src/metacity-dialog.c (on_realize, warn_about_no_sm_support, error_about_command, main): * src/screen.[ch] (struct _MetaScreen, meta_screen_new, meta_screen_show_desktop, meta_screen_apply_startup_properties): * src/session.c (warn_about_lame_clients_and_finish_interact): * src/window.[ch] (struct _MetaWindow, intervening_user_event_occurred, window_activate, meta_window_delete, meta_window_focus, meta_window_send_icccm_message, meta_window_client_message, menu_callback, meta_window_show_menu, struct EventScannerData, check_use_this_motion_notify, meta_window_begin_grab_op, meta_window_set_user_time): * src/workspace.[ch] (focus_ancestor_or_mru_window, meta_workspace_activate_with_focus, meta_workspace_activate, meta_workspace_focus_default_window, focus_ancestor_or_mru_window): Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ does) instead of Time. #348305
2006-09-13 16:32:33 +00:00
" initial_timestamp : %u\n",
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
window->net_wm_user_time_set,
window->net_wm_user_time,
window->initial_timestamp_set,
window->initial_timestamp);
if (focus_window != NULL)
{
meta_topic (META_DEBUG_STARTUP,
"COMPARISON (continued):\n"
Vytautus Liuolia totally rocks; he tested and debugged and tracked down 2006-08-07 Elijah Newren <newren gmail com> * src/window.c (intervening_user_event_occurred): Vytautus Liuolia totally rocks; he tested and debugged and tracked down where we were using the focus window's net_wm_user_time even when it was uninitialized. This may fix bug 311868 and others I've heard about (with Valknut, IIRC). It definitely fixes the issues Vytas was seeing with his single instance library. :-)
2006-08-09 18:32:30 +00:00
" focus_window : %s\n"
" fw->net_wm_user_time_set : %d\n"
Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ 2006-09-13 Elijah Newren <newren gmail com> * src/common.h (MetaWindowMenuFunc): * src/core.[ch] (meta_core_user_lower_and_unfocus, meta_core_user_focus, meta_core_show_window_menu, meta_core_begin_grab_op, meta_core_end_grab_op): * src/delete.c (delete_ping_reply_func, delete_ping_timeout_func, meta_window_delete): * src/display.[ch] (struct MetaDisplay, struct MetaPingData, sanity_check_timestamps, meta_display_open, event_callback, meta_spew_event, meta_display_set_grab_op_cursor, meta_display_begin_grab_op, meta_display_end_grab_op, meta_display_ping_timeout, meta_display_ping_window, process_pong_message, timestamp_too_old, meta_display_set_input_focus_window): * src/keybindings.[ch] (grab_keyboard, ungrab_keyboard, meta_screen_grab_all_keys, meta_window_grab_all_keys, meta_window_ungrab_all_keys, error_on_generic_command, error_on_command, error_on_terminal_command): * src/metacity-dialog.c (on_realize, warn_about_no_sm_support, error_about_command, main): * src/screen.[ch] (struct _MetaScreen, meta_screen_new, meta_screen_show_desktop, meta_screen_apply_startup_properties): * src/session.c (warn_about_lame_clients_and_finish_interact): * src/window.[ch] (struct _MetaWindow, intervening_user_event_occurred, window_activate, meta_window_delete, meta_window_focus, meta_window_send_icccm_message, meta_window_client_message, menu_callback, meta_window_show_menu, struct EventScannerData, check_use_this_motion_notify, meta_window_begin_grab_op, meta_window_set_user_time): * src/workspace.[ch] (focus_ancestor_or_mru_window, meta_workspace_activate_with_focus, meta_workspace_activate, meta_workspace_focus_default_window, focus_ancestor_or_mru_window): Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ does) instead of Time. #348305
2006-09-13 16:32:33 +00:00
" fw->net_wm_user_time : %u\n",
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
focus_window->desc,
Vytautus Liuolia totally rocks; he tested and debugged and tracked down 2006-08-07 Elijah Newren <newren gmail com> * src/window.c (intervening_user_event_occurred): Vytautus Liuolia totally rocks; he tested and debugged and tracked down where we were using the focus window's net_wm_user_time even when it was uninitialized. This may fix bug 311868 and others I've heard about (with Valknut, IIRC). It definitely fixes the issues Vytas was seeing with his single instance library. :-)
2006-08-09 18:32:30 +00:00
focus_window->net_wm_user_time_set,
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
focus_window->net_wm_user_time);
}
/* We expect the most common case for not focusing a new window
* to be when a hint to not focus it has been set. Since we can
* deal with that case rapidly, we use special case it--this is
* merely a preliminary optimization. :)
*/
if ( ((window->net_wm_user_time_set == TRUE) &&
(window->net_wm_user_time == 0))
||
((window->initial_timestamp_set == TRUE) &&
(window->initial_timestamp == 0)))
{
meta_topic (META_DEBUG_STARTUP,
"window %s explicitly requested no focus\n",
window->desc);
return TRUE;
}
if (!(window->net_wm_user_time_set) && !(window->initial_timestamp_set))
{
meta_topic (META_DEBUG_STARTUP,
"no information about window %s found\n",
window->desc);
Oops, revert patch which I didn't intend to commit - stupid 'git-svn dcommit' - Federico Signed-off-by: Federico Mena Quintero <federico@gnu.org> svn path=/trunk/; revision=3379
2007-11-09 19:01:31 +00:00
return FALSE;
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
}
Vytautus Liuolia totally rocks; he tested and debugged and tracked down 2006-08-07 Elijah Newren <newren gmail com> * src/window.c (intervening_user_event_occurred): Vytautus Liuolia totally rocks; he tested and debugged and tracked down where we were using the focus window's net_wm_user_time even when it was uninitialized. This may fix bug 311868 and others I've heard about (with Valknut, IIRC). It definitely fixes the issues Vytas was seeing with his single instance library. :-)
2006-08-09 18:32:30 +00:00
if (focus_window != NULL &&
!focus_window->net_wm_user_time_set)
{
meta_topic (META_DEBUG_STARTUP,
"focus window, %s, doesn't have a user time set yet!\n",
window->desc);
return FALSE;
}
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
/* To determine the "launch" time of an application,
* startup-notification can set the TIMESTAMP and the
* application (usually via its toolkit such as gtk or qt) can
Use correct timestamp for focus stealing prevention When window initially maps, use the more recent of NET_WM_USER_TIME and startup notification timestamps to compare against last known user action to decide whether to focus the window or not. Once we show the window, clear the initial_timestamp_set flag, so the startup notification timestamp is not taken into account again. Based on patch for metacity by Alexander Larsson http://bugzilla.gnome.org/show_bug.cgi?id=573922
2009-08-08 16:59:01 +00:00
* set the _NET_WM_USER_TIME. If both are set, we need to be
* using the newer of the two values.
*
* See http://bugzilla.gnome.org/show_bug.cgi?id=573922
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
*/
Use correct timestamp for focus stealing prevention When window initially maps, use the more recent of NET_WM_USER_TIME and startup notification timestamps to compare against last known user action to decide whether to focus the window or not. Once we show the window, clear the initial_timestamp_set flag, so the startup notification timestamp is not taken into account again. Based on patch for metacity by Alexander Larsson http://bugzilla.gnome.org/show_bug.cgi?id=573922
2009-08-08 16:59:01 +00:00
compare = 0;
if (window->net_wm_user_time_set &&
window->initial_timestamp_set)
compare =
XSERVER_TIME_IS_BEFORE (window->net_wm_user_time,
window->initial_timestamp) ?
window->initial_timestamp : window->net_wm_user_time;
else if (window->net_wm_user_time_set)
compare = window->net_wm_user_time;
else if (window->initial_timestamp_set)
compare = window->initial_timestamp;
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
if ((focus_window != NULL) &&
XSERVER_TIME_IS_BEFORE (compare, focus_window->net_wm_user_time))
{
meta_topic (META_DEBUG_STARTUP,
Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ 2006-09-13 Elijah Newren <newren gmail com> * src/common.h (MetaWindowMenuFunc): * src/core.[ch] (meta_core_user_lower_and_unfocus, meta_core_user_focus, meta_core_show_window_menu, meta_core_begin_grab_op, meta_core_end_grab_op): * src/delete.c (delete_ping_reply_func, delete_ping_timeout_func, meta_window_delete): * src/display.[ch] (struct MetaDisplay, struct MetaPingData, sanity_check_timestamps, meta_display_open, event_callback, meta_spew_event, meta_display_set_grab_op_cursor, meta_display_begin_grab_op, meta_display_end_grab_op, meta_display_ping_timeout, meta_display_ping_window, process_pong_message, timestamp_too_old, meta_display_set_input_focus_window): * src/keybindings.[ch] (grab_keyboard, ungrab_keyboard, meta_screen_grab_all_keys, meta_window_grab_all_keys, meta_window_ungrab_all_keys, error_on_generic_command, error_on_command, error_on_terminal_command): * src/metacity-dialog.c (on_realize, warn_about_no_sm_support, error_about_command, main): * src/screen.[ch] (struct _MetaScreen, meta_screen_new, meta_screen_show_desktop, meta_screen_apply_startup_properties): * src/session.c (warn_about_lame_clients_and_finish_interact): * src/window.[ch] (struct _MetaWindow, intervening_user_event_occurred, window_activate, meta_window_delete, meta_window_focus, meta_window_send_icccm_message, meta_window_client_message, menu_callback, meta_window_show_menu, struct EventScannerData, check_use_this_motion_notify, meta_window_begin_grab_op, meta_window_set_user_time): * src/workspace.[ch] (focus_ancestor_or_mru_window, meta_workspace_activate_with_focus, meta_workspace_activate, meta_workspace_focus_default_window, focus_ancestor_or_mru_window): Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ does) instead of Time. #348305
2006-09-13 16:32:33 +00:00
"window %s focus prevented by other activity; %u < %u\n",
window->desc,
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
compare,
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
focus_window->net_wm_user_time);
return TRUE;
}
else
{
meta_topic (META_DEBUG_STARTUP,
"new window %s with no intervening events\n",
window->desc);
return FALSE;
}
}
Don't "steal" focus from terminal windows for new window mappings as the 2006-01-10 Elijah Newren <newren@gmail.com> Don't "steal" focus from terminal windows for new window mappings as the difference in usage between terminals and other apps seems to suggest this difference in treatment. See #326159 for details, feedback welcome. * src/window.[ch] (__window_is_terminal): New function, currently an ugly hack and should be replaced by a new property set by applications if the behavior works to our liking, (window_state_on_map): don't transfer focus to new windows from terminals unless the new window is a transient of the focused terminal * src/keybindigns.c (handle_panel_keybinding): panel run dialog keybinding should be counted as an explicit transfer of focus to the new window, so override the don't-transfer-focus-from-terminals in this case
2006-01-10 18:33:53 +00:00
/* This function is an ugly hack. It's experimental in nature and ought to be
* replaced by a real hint from the app to the WM if we decide the experimental
* behavior is worthwhile. The basic idea is to get more feedback about how
* usage scenarios of "strict" focus users and what they expect. See #326159.
*/
window: Make window_is_terminal private
2014-03-18 14:08:28 +00:00
static gboolean
window_is_terminal (MetaWindow *window)
Don't "steal" focus from terminal windows for new window mappings as the 2006-01-10 Elijah Newren <newren@gmail.com> Don't "steal" focus from terminal windows for new window mappings as the difference in usage between terminals and other apps seems to suggest this difference in treatment. See #326159 for details, feedback welcome. * src/window.[ch] (__window_is_terminal): New function, currently an ugly hack and should be replaced by a new property set by applications if the behavior works to our liking, (window_state_on_map): don't transfer focus to new windows from terminals unless the new window is a transient of the focused terminal * src/keybindigns.c (handle_panel_keybinding): panel run dialog keybinding should be counted as an explicit transfer of focus to the new window, so override the don't-transfer-focus-from-terminals in this case
2006-01-10 18:33:53 +00:00
{
Fix strict focus mode by picking up on res_class. Fixes #361054, strict 2006-10-30 Dan Mick <dan.mick@sun.com> * src/window.c: (__window_is_terminal): Fix strict focus mode by picking up on res_class. Fixes #361054, strict focus mode still not working; should look for res_class, not res_name
2006-10-29 20:30:18 +00:00
if (window == NULL || window->res_class == NULL)
Don't "steal" focus from terminal windows for new window mappings as the 2006-01-10 Elijah Newren <newren@gmail.com> Don't "steal" focus from terminal windows for new window mappings as the difference in usage between terminals and other apps seems to suggest this difference in treatment. See #326159 for details, feedback welcome. * src/window.[ch] (__window_is_terminal): New function, currently an ugly hack and should be replaced by a new property set by applications if the behavior works to our liking, (window_state_on_map): don't transfer focus to new windows from terminals unless the new window is a transient of the focused terminal * src/keybindigns.c (handle_panel_keybinding): panel run dialog keybinding should be counted as an explicit transfer of focus to the new window, so override the don't-transfer-focus-from-terminals in this case
2006-01-10 18:33:53 +00:00
return FALSE;
Fix strict focus mode by picking up on res_class. Fixes #361054, strict 2006-10-30 Dan Mick <dan.mick@sun.com> * src/window.c: (__window_is_terminal): Fix strict focus mode by picking up on res_class. Fixes #361054, strict focus mode still not working; should look for res_class, not res_name
2006-10-29 20:30:18 +00:00
/*
* Compare res_class, which is not user-settable, and thus theoretically
* a more-reliable indication of term-ness.
*/
Don't "steal" focus from terminal windows for new window mappings as the 2006-01-10 Elijah Newren <newren@gmail.com> Don't "steal" focus from terminal windows for new window mappings as the difference in usage between terminals and other apps seems to suggest this difference in treatment. See #326159 for details, feedback welcome. * src/window.[ch] (__window_is_terminal): New function, currently an ugly hack and should be replaced by a new property set by applications if the behavior works to our liking, (window_state_on_map): don't transfer focus to new windows from terminals unless the new window is a transient of the focused terminal * src/keybindigns.c (handle_panel_keybinding): panel run dialog keybinding should be counted as an explicit transfer of focus to the new window, so override the don't-transfer-focus-from-terminals in this case
2006-01-10 18:33:53 +00:00
/* gnome-terminal -- if you couldn't guess */
Fix strict focus mode by picking up on res_class. Fixes #361054, strict 2006-10-30 Dan Mick <dan.mick@sun.com> * src/window.c: (__window_is_terminal): Fix strict focus mode by picking up on res_class. Fixes #361054, strict focus mode still not working; should look for res_class, not res_name
2006-10-29 20:30:18 +00:00
if (strcmp (window->res_class, "Gnome-terminal") == 0)
Don't "steal" focus from terminal windows for new window mappings as the 2006-01-10 Elijah Newren <newren@gmail.com> Don't "steal" focus from terminal windows for new window mappings as the difference in usage between terminals and other apps seems to suggest this difference in treatment. See #326159 for details, feedback welcome. * src/window.[ch] (__window_is_terminal): New function, currently an ugly hack and should be replaced by a new property set by applications if the behavior works to our liking, (window_state_on_map): don't transfer focus to new windows from terminals unless the new window is a transient of the focused terminal * src/keybindigns.c (handle_panel_keybinding): panel run dialog keybinding should be counted as an explicit transfer of focus to the new window, so override the don't-transfer-focus-from-terminals in this case
2006-01-10 18:33:53 +00:00
return TRUE;
/* xterm, rxvt, aterm */
Fix strict focus mode by picking up on res_class. Fixes #361054, strict 2006-10-30 Dan Mick <dan.mick@sun.com> * src/window.c: (__window_is_terminal): Fix strict focus mode by picking up on res_class. Fixes #361054, strict focus mode still not working; should look for res_class, not res_name
2006-10-29 20:30:18 +00:00
else if (strcmp (window->res_class, "XTerm") == 0)
Don't "steal" focus from terminal windows for new window mappings as the 2006-01-10 Elijah Newren <newren@gmail.com> Don't "steal" focus from terminal windows for new window mappings as the difference in usage between terminals and other apps seems to suggest this difference in treatment. See #326159 for details, feedback welcome. * src/window.[ch] (__window_is_terminal): New function, currently an ugly hack and should be replaced by a new property set by applications if the behavior works to our liking, (window_state_on_map): don't transfer focus to new windows from terminals unless the new window is a transient of the focused terminal * src/keybindigns.c (handle_panel_keybinding): panel run dialog keybinding should be counted as an explicit transfer of focus to the new window, so override the don't-transfer-focus-from-terminals in this case
2006-01-10 18:33:53 +00:00
return TRUE;
/* konsole, KDE's terminal program */
Fix strict focus mode by picking up on res_class. Fixes #361054, strict 2006-10-30 Dan Mick <dan.mick@sun.com> * src/window.c: (__window_is_terminal): Fix strict focus mode by picking up on res_class. Fixes #361054, strict focus mode still not working; should look for res_class, not res_name
2006-10-29 20:30:18 +00:00
else if (strcmp (window->res_class, "Konsole") == 0)
Don't "steal" focus from terminal windows for new window mappings as the 2006-01-10 Elijah Newren <newren@gmail.com> Don't "steal" focus from terminal windows for new window mappings as the difference in usage between terminals and other apps seems to suggest this difference in treatment. See #326159 for details, feedback welcome. * src/window.[ch] (__window_is_terminal): New function, currently an ugly hack and should be replaced by a new property set by applications if the behavior works to our liking, (window_state_on_map): don't transfer focus to new windows from terminals unless the new window is a transient of the focused terminal * src/keybindigns.c (handle_panel_keybinding): panel run dialog keybinding should be counted as an explicit transfer of focus to the new window, so override the don't-transfer-focus-from-terminals in this case
2006-01-10 18:33:53 +00:00
return TRUE;
/* rxvt-unicode */
Fix strict focus mode by picking up on res_class. Fixes #361054, strict 2006-10-30 Dan Mick <dan.mick@sun.com> * src/window.c: (__window_is_terminal): Fix strict focus mode by picking up on res_class. Fixes #361054, strict focus mode still not working; should look for res_class, not res_name
2006-10-29 20:30:18 +00:00
else if (strcmp (window->res_class, "URxvt") == 0)
Don't "steal" focus from terminal windows for new window mappings as the 2006-01-10 Elijah Newren <newren@gmail.com> Don't "steal" focus from terminal windows for new window mappings as the difference in usage between terminals and other apps seems to suggest this difference in treatment. See #326159 for details, feedback welcome. * src/window.[ch] (__window_is_terminal): New function, currently an ugly hack and should be replaced by a new property set by applications if the behavior works to our liking, (window_state_on_map): don't transfer focus to new windows from terminals unless the new window is a transient of the focused terminal * src/keybindigns.c (handle_panel_keybinding): panel run dialog keybinding should be counted as an explicit transfer of focus to the new window, so override the don't-transfer-focus-from-terminals in this case
2006-01-10 18:33:53 +00:00
return TRUE;
/* eterm */
Fix strict focus mode by picking up on res_class. Fixes #361054, strict 2006-10-30 Dan Mick <dan.mick@sun.com> * src/window.c: (__window_is_terminal): Fix strict focus mode by picking up on res_class. Fixes #361054, strict focus mode still not working; should look for res_class, not res_name
2006-10-29 20:30:18 +00:00
else if (strcmp (window->res_class, "Eterm") == 0)
Don't "steal" focus from terminal windows for new window mappings as the 2006-01-10 Elijah Newren <newren@gmail.com> Don't "steal" focus from terminal windows for new window mappings as the difference in usage between terminals and other apps seems to suggest this difference in treatment. See #326159 for details, feedback welcome. * src/window.[ch] (__window_is_terminal): New function, currently an ugly hack and should be replaced by a new property set by applications if the behavior works to our liking, (window_state_on_map): don't transfer focus to new windows from terminals unless the new window is a transient of the focused terminal * src/keybindigns.c (handle_panel_keybinding): panel run dialog keybinding should be counted as an explicit transfer of focus to the new window, so override the don't-transfer-focus-from-terminals in this case
2006-01-10 18:33:53 +00:00
return TRUE;
/* KTerm -- some terminal not KDE based; so not like Konsole */
Fix strict focus mode by picking up on res_class. Fixes #361054, strict 2006-10-30 Dan Mick <dan.mick@sun.com> * src/window.c: (__window_is_terminal): Fix strict focus mode by picking up on res_class. Fixes #361054, strict focus mode still not working; should look for res_class, not res_name
2006-10-29 20:30:18 +00:00
else if (strcmp (window->res_class, "KTerm") == 0)
Don't "steal" focus from terminal windows for new window mappings as the 2006-01-10 Elijah Newren <newren@gmail.com> Don't "steal" focus from terminal windows for new window mappings as the difference in usage between terminals and other apps seems to suggest this difference in treatment. See #326159 for details, feedback welcome. * src/window.[ch] (__window_is_terminal): New function, currently an ugly hack and should be replaced by a new property set by applications if the behavior works to our liking, (window_state_on_map): don't transfer focus to new windows from terminals unless the new window is a transient of the focused terminal * src/keybindigns.c (handle_panel_keybinding): panel run dialog keybinding should be counted as an explicit transfer of focus to the new window, so override the don't-transfer-focus-from-terminals in this case
2006-01-10 18:33:53 +00:00
return TRUE;
/* Multi-gnome-terminal */
Fix strict focus mode by picking up on res_class. Fixes #361054, strict 2006-10-30 Dan Mick <dan.mick@sun.com> * src/window.c: (__window_is_terminal): Fix strict focus mode by picking up on res_class. Fixes #361054, strict focus mode still not working; should look for res_class, not res_name
2006-10-29 20:30:18 +00:00
else if (strcmp (window->res_class, "Multi-gnome-terminal") == 0)
Don't "steal" focus from terminal windows for new window mappings as the 2006-01-10 Elijah Newren <newren@gmail.com> Don't "steal" focus from terminal windows for new window mappings as the difference in usage between terminals and other apps seems to suggest this difference in treatment. See #326159 for details, feedback welcome. * src/window.[ch] (__window_is_terminal): New function, currently an ugly hack and should be replaced by a new property set by applications if the behavior works to our liking, (window_state_on_map): don't transfer focus to new windows from terminals unless the new window is a transient of the focused terminal * src/keybindigns.c (handle_panel_keybinding): panel run dialog keybinding should be counted as an explicit transfer of focus to the new window, so override the don't-transfer-focus-from-terminals in this case
2006-01-10 18:33:53 +00:00
return TRUE;
/* mlterm ("multi lingual terminal emulator on X") */
Fix strict focus mode by picking up on res_class. Fixes #361054, strict 2006-10-30 Dan Mick <dan.mick@sun.com> * src/window.c: (__window_is_terminal): Fix strict focus mode by picking up on res_class. Fixes #361054, strict focus mode still not working; should look for res_class, not res_name
2006-10-29 20:30:18 +00:00
else if (strcmp (window->res_class, "mlterm") == 0)
Don't "steal" focus from terminal windows for new window mappings as the 2006-01-10 Elijah Newren <newren@gmail.com> Don't "steal" focus from terminal windows for new window mappings as the difference in usage between terminals and other apps seems to suggest this difference in treatment. See #326159 for details, feedback welcome. * src/window.[ch] (__window_is_terminal): New function, currently an ugly hack and should be replaced by a new property set by applications if the behavior works to our liking, (window_state_on_map): don't transfer focus to new windows from terminals unless the new window is a transient of the focused terminal * src/keybindigns.c (handle_panel_keybinding): panel run dialog keybinding should be counted as an explicit transfer of focus to the new window, so override the don't-transfer-focus-from-terminals in this case
2006-01-10 18:33:53 +00:00
return TRUE;
Add XFCE Terminal as a terminal Include the XFCE terminal program 'Terminal' in the list of terminals. https://bugzilla.gnome.org/show_bug.cgi?id=599262
2009-10-22 01:11:46 +00:00
/* Terminal -- XFCE Terminal */
else if (strcmp (window->res_class, "Terminal") == 0)
return TRUE;
Don't "steal" focus from terminal windows for new window mappings as the 2006-01-10 Elijah Newren <newren@gmail.com> Don't "steal" focus from terminal windows for new window mappings as the difference in usage between terminals and other apps seems to suggest this difference in treatment. See #326159 for details, feedback welcome. * src/window.[ch] (__window_is_terminal): New function, currently an ugly hack and should be replaced by a new property set by applications if the behavior works to our liking, (window_state_on_map): don't transfer focus to new windows from terminals unless the new window is a transient of the focused terminal * src/keybindigns.c (handle_panel_keybinding): panel run dialog keybinding should be counted as an explicit transfer of focus to the new window, so override the don't-transfer-focus-from-terminals in this case
2006-01-10 18:33:53 +00:00
return FALSE;
}
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
/* This function determines what state the window should have assuming that it
* and the focus_window have no relation
*/
static void
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window_state_on_map (MetaWindow *window,
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
gboolean *takes_focus,
gboolean *places_on_top)
{
gboolean intervening_events;
intervening_events = intervening_user_event_occurred (window);
*takes_focus = !intervening_events;
*places_on_top = *takes_focus;
Add support for _NET_WM_USER_TIME 2004-06-17 Elijah Newren <newren@math.utah.edu> Add support for _NET_WM_USER_TIME * src/display.c: (meta_display_open): Add _NET_WM_USER_TIME to atom_names[], (event_callback): Manually set _NET_WM_USER_TIME upon KeyPress (doesn't work since keyboard isn't grabbed) and ButtonPress (does work), this is just a fallback for applications that don't update this themselves. * src/display.h: (struct _MetaDisplay): Add atom_net_wm_user_time field * src/screen.c: (meta_screen_apply_startup_properties): Check for TIMESTAMP provided from startup sequence as well. * src/stack.c: s/meta_window_set_stack_position/meta_window_set_stack_position_no_sync/, (meta_window_set_stack_position): New function which calls the meta_window_set_stack_position_no_sync function followed immediately by calling meta_stack_sync_to_server. * src/window-props.c: (init_net_wm_user_time), (reload_net_wm_user_time): new functions, (reload_wm_hints): also load atom_net_wm_user_time * src/window.c: new XSERVER_TIME_IS_LATER macro (accounts for timestamp wraparound), (meta_window_new_with_attrs): add timestamp attributes, (window_takes_focus_on_map): use TIMESTAMP from startup notification and _NET_WM_USER_TIME to decide whether to focus new windows, (meta_window_show): if app doesn't take focus on map, place it just below the focused window in the stack (process_property_notify): check for changes to _NET_WM_USRE_TIME, (meta_window_stack_just_below): new function * src/window.h: (_MetaWindow struct): new fields for initial_timestamp, initial_timestamp_set, net_wm_user_time_set, and net_wm_user_time, (meta_window_stack_just_below): new function
2004-06-24 15:47:05 +00:00
always focus new windows, trying to be smart about it was a flop. 2002-06-14 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_show): always focus new windows, trying to be smart about it was a flop.
2002-06-15 01:46:13 +00:00
/* don't initially focus windows that are intended to not accept
* focus
*/
window: Add is_focusable class method Implement is_focusable for both x11 and wayland and just use this check so that we can abstract things more and be less dependent on window backend. https://gitlab.gnome.org/GNOME/mutter/merge_requests/421
2018-11-13 07:56:53 +00:00
if (!meta_window_is_focusable (window))
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
{
*takes_focus = FALSE;
return;
}
always focus new windows, trying to be smart about it was a flop. 2002-06-14 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_show): always focus new windows, trying to be smart about it was a flop.
2002-06-15 01:46:13 +00:00
Patch from Ron Yorston to add a focus_new_windows option. Default is 2006-04-12 Elijah Newren <newren gmail com> Patch from Ron Yorston to add a focus_new_windows option. Default is 'smart' (focus by default but normal focus-stealing-prevention can kick in); 'strict' is current other choice (like 'smart' except that programs launched by the terminal will not be focused). Fixes remainder of #326159. Should also close #152004 and a bunch of others. * src/common.h: Add a MetaFocusNewWindows enum giving the current types allowed * src/display.h: Update docs on allow_terminal_deactivation to note that it is only relevant when focus_new_windows is 'strict' * src/prefs.c: * src/prefs.h: * src/metacity.schemas.in: add the new gconf key and explanation * src/prefs.[ch] (#define KEY_FOCUS_NEW_WINDOWS, static gboolean focus_new_windows, update_focus_new_windows, meta_prefs_init, change_notify, meta_prefs_get_focus_new_windows, meta_preference_to_string): Add all the normal preference handling stuff for this new focus-new-windows option. * src/window.c (window_state_on_map, meta_window_set_user_time): Don't focus windows launched from a terminal
2006-04-12 18:01:20 +00:00
/* Terminal usage may be different; some users intend to launch
Don't "steal" focus from terminal windows for new window mappings as the 2006-01-10 Elijah Newren <newren@gmail.com> Don't "steal" focus from terminal windows for new window mappings as the difference in usage between terminals and other apps seems to suggest this difference in treatment. See #326159 for details, feedback welcome. * src/window.[ch] (__window_is_terminal): New function, currently an ugly hack and should be replaced by a new property set by applications if the behavior works to our liking, (window_state_on_map): don't transfer focus to new windows from terminals unless the new window is a transient of the focused terminal * src/keybindigns.c (handle_panel_keybinding): panel run dialog keybinding should be counted as an explicit transfer of focus to the new window, so override the don't-transfer-focus-from-terminals in this case
2006-01-10 18:33:53 +00:00
* many apps in quick succession or to just view things in the new
Patch from Ron Yorston to add a focus_new_windows option. Default is 2006-04-12 Elijah Newren <newren gmail com> Patch from Ron Yorston to add a focus_new_windows option. Default is 'smart' (focus by default but normal focus-stealing-prevention can kick in); 'strict' is current other choice (like 'smart' except that programs launched by the terminal will not be focused). Fixes remainder of #326159. Should also close #152004 and a bunch of others. * src/common.h: Add a MetaFocusNewWindows enum giving the current types allowed * src/display.h: Update docs on allow_terminal_deactivation to note that it is only relevant when focus_new_windows is 'strict' * src/prefs.c: * src/prefs.h: * src/metacity.schemas.in: add the new gconf key and explanation * src/prefs.[ch] (#define KEY_FOCUS_NEW_WINDOWS, static gboolean focus_new_windows, update_focus_new_windows, meta_prefs_init, change_notify, meta_prefs_get_focus_new_windows, meta_preference_to_string): Add all the normal preference handling stuff for this new focus-new-windows option. * src/window.c (window_state_on_map, meta_window_set_user_time): Don't focus windows launched from a terminal
2006-04-12 18:01:20 +00:00
* window while still interacting with the terminal. In that case,
Don't "steal" focus from terminal windows for new window mappings as the 2006-01-10 Elijah Newren <newren@gmail.com> Don't "steal" focus from terminal windows for new window mappings as the difference in usage between terminals and other apps seems to suggest this difference in treatment. See #326159 for details, feedback welcome. * src/window.[ch] (__window_is_terminal): New function, currently an ugly hack and should be replaced by a new property set by applications if the behavior works to our liking, (window_state_on_map): don't transfer focus to new windows from terminals unless the new window is a transient of the focused terminal * src/keybindigns.c (handle_panel_keybinding): panel run dialog keybinding should be counted as an explicit transfer of focus to the new window, so override the don't-transfer-focus-from-terminals in this case
2006-01-10 18:33:53 +00:00
* apps launched from the terminal should not take focus. This
* isn't quite the same as not allowing focus to transfer from
* terminals due to new window map, but the latter is a much easier
* approximation to enforce so we do that.
*/
if (*takes_focus &&
Port preferences to GSettings Move preferences to GSettings, using mainly shared schemas from gsettings-desktop-schemas. Unlike GConf, GSettings support is not optional, as Gio is already a hard dependency of GTK+. https://bugzilla.gnome.org/show_bug.cgi?id=635378
2011-06-24 16:14:15 +00:00
meta_prefs_get_focus_new_windows () == G_DESKTOP_FOCUS_NEW_WINDOWS_STRICT &&
Fix accidental overzealous focus holding by the terminal introduced by the 2006-01-15 Elijah Newren <newren@gmail.com> Fix accidental overzealous focus holding by the terminal introduced by the original patch in bug 326159. Windows launched from panel icons, the panel menu, or global keybindings should get focus now. #326159. * src/display.c (meta_display_open, event_callback): * src/display.h (struct MetaDisplay): * src/keybindings.c (process_event): * src/window.c (meta_window_set_user_time): Add a new allow_terminal_deactivation field to MetaDisplay and use it to track whether the user's last action was interaction with the terminal or some outside action (global keybinding, clicking on a dock, etc.) likely to launch a new window. * src/window.c (window_state_on_map): Allow the focus switch from a terminal to something else if allow_terminal_deactiviation is true. * src/keybindings.c (handle_panel_keybinding): Remove some unneeded code.
2006-01-15 17:03:57 +00:00
!window->display->allow_terminal_deactivation &&
window: Make window_is_terminal private
2014-03-18 14:08:28 +00:00
window_is_terminal (window->display->focus_window) &&
Don't "steal" focus from terminal windows for new window mappings as the 2006-01-10 Elijah Newren <newren@gmail.com> Don't "steal" focus from terminal windows for new window mappings as the difference in usage between terminals and other apps seems to suggest this difference in treatment. See #326159 for details, feedback welcome. * src/window.[ch] (__window_is_terminal): New function, currently an ugly hack and should be replaced by a new property set by applications if the behavior works to our liking, (window_state_on_map): don't transfer focus to new windows from terminals unless the new window is a transient of the focused terminal * src/keybindigns.c (handle_panel_keybinding): panel run dialog keybinding should be counted as an explicit transfer of focus to the new window, so override the don't-transfer-focus-from-terminals in this case
2006-01-10 18:33:53 +00:00
!meta_window_is_ancestor_of_transient (window->display->focus_window,
window))
{
meta_topic (META_DEBUG_FOCUS,
"focus_window is terminal; not focusing new window.\n");
*takes_focus = FALSE;
*places_on_top = FALSE;
}
always focus new windows, trying to be smart about it was a flop. 2002-06-14 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_show): always focus new windows, trying to be smart about it was a flop.
2002-06-15 01:46:13 +00:00
switch (window->type)
{
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
case META_WINDOW_UTILITY:
case META_WINDOW_TOOLBAR:
*takes_focus = FALSE;
*places_on_top = FALSE;
break;
always focus new windows, trying to be smart about it was a flop. 2002-06-14 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_show): always focus new windows, trying to be smart about it was a flop.
2002-06-15 01:46:13 +00:00
case META_WINDOW_DOCK:
case META_WINDOW_DESKTOP:
case META_WINDOW_SPLASHSCREEN:
case META_WINDOW_MENU:
Adds support in src/core for tracking override redirect windows. The metacity core is now directly aware of override redirect windows. - They get MetaWindows like normal windows, so mutter no longer need to special case them. The net wm types applicable to override redirects are also recognised. - The original positioning/stacking semantics of metacity with respect to OR windows are maintained, but now it's easier to synchronize the stacking between the core and mutter. - mutter no longer needs to manualy track UnmapNotify, MapNotify, ReparentNotify, CreateNotify and DestroyNotify events; instead map, unmap, add and remove events can now be consistently delivered via the MetaCompositor callbacks.
2008-11-23 19:28:40 +00:00
/* override redirect types: */
case META_WINDOW_DROPDOWN_MENU:
case META_WINDOW_POPUP_MENU:
case META_WINDOW_TOOLTIP:
case META_WINDOW_NOTIFICATION:
case META_WINDOW_COMBO:
case META_WINDOW_DND:
case META_WINDOW_OVERRIDE_OTHER:
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
/* don't focus any of these; places_on_top may be irrelevant for some of
* these (e.g. dock)--but you never know--the focus window might also be
* of the same type in some weird situation...
*/
*takes_focus = FALSE;
always focus new windows, trying to be smart about it was a flop. 2002-06-14 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_show): always focus new windows, trying to be smart about it was a flop.
2002-06-15 01:46:13 +00:00
break;
case META_WINDOW_NORMAL:
Add support for _NET_WM_USER_TIME 2004-06-17 Elijah Newren <newren@math.utah.edu> Add support for _NET_WM_USER_TIME * src/display.c: (meta_display_open): Add _NET_WM_USER_TIME to atom_names[], (event_callback): Manually set _NET_WM_USER_TIME upon KeyPress (doesn't work since keyboard isn't grabbed) and ButtonPress (does work), this is just a fallback for applications that don't update this themselves. * src/display.h: (struct _MetaDisplay): Add atom_net_wm_user_time field * src/screen.c: (meta_screen_apply_startup_properties): Check for TIMESTAMP provided from startup sequence as well. * src/stack.c: s/meta_window_set_stack_position/meta_window_set_stack_position_no_sync/, (meta_window_set_stack_position): New function which calls the meta_window_set_stack_position_no_sync function followed immediately by calling meta_stack_sync_to_server. * src/window-props.c: (init_net_wm_user_time), (reload_net_wm_user_time): new functions, (reload_wm_hints): also load atom_net_wm_user_time * src/window.c: new XSERVER_TIME_IS_LATER macro (accounts for timestamp wraparound), (meta_window_new_with_attrs): add timestamp attributes, (window_takes_focus_on_map): use TIMESTAMP from startup notification and _NET_WM_USER_TIME to decide whether to focus new windows, (meta_window_show): if app doesn't take focus on map, place it just below the focused window in the stack (process_property_notify): check for changes to _NET_WM_USRE_TIME, (meta_window_stack_just_below): new function * src/window.h: (_MetaWindow struct): new fields for initial_timestamp, initial_timestamp_set, net_wm_user_time_set, and net_wm_user_time, (meta_window_stack_just_below): new function
2004-06-24 15:47:05 +00:00
case META_WINDOW_DIALOG:
case META_WINDOW_MODAL_DIALOG:
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
/* The default is correct for these */
always focus new windows, trying to be smart about it was a flop. 2002-06-14 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_show): always focus new windows, trying to be smart about it was a flop.
2002-06-15 01:46:13 +00:00
break;
}
}
Make the taskbar less flash happy and fix up some related stacking issues. 2006-01-09 Elijah Newren <newren@gmail.com> Make the taskbar less flash happy and fix up some related stacking issues. #326035. * src/window.c (windows_overlap): new function, (meta_window_show): if a window is denied focus but doesn't overlap with the focus window there is no need to set the demands attention hint nor stack that window below the focus window, (meta_window_get_outer_rect): we're not modifying the window so declare it to be const
2006-01-10 05:14:48 +00:00
static gboolean
windows_overlap (const MetaWindow *w1, const MetaWindow *w2)
{
MetaRectangle w1rect, w2rect;
Rename meta_window_get_outer_rect() to meta_window_get_frame_rect() For clarity, rename meta_window_get_outer_rect() to match terminology we use elsewhere. The old function is left as a deprecated compatibility wrapper.
2013-11-19 17:24:45 +00:00
meta_window_get_frame_rect (w1, &w1rect);
meta_window_get_frame_rect (w2, &w2rect);
Make the taskbar less flash happy and fix up some related stacking issues. 2006-01-09 Elijah Newren <newren@gmail.com> Make the taskbar less flash happy and fix up some related stacking issues. #326035. * src/window.c (windows_overlap): new function, (meta_window_show): if a window is denied focus but doesn't overlap with the focus window there is no need to set the demands attention hint nor stack that window below the focus window, (meta_window_get_outer_rect): we're not modifying the window so declare it to be const
2006-01-10 05:14:48 +00:00
return meta_rectangle_overlap (&w1rect, &w2rect);
}
new function. rewrite assertion not to put window on top in terms of 2007-10-16 Thomas Thurman <thomas@thurman.org.uk> * src/window.c (window_would_be_covered): new function. * src/window.c (meta_window_show): rewrite assertion not to put window on top in terms of window_would_be_covered(); remove assertion because it's no longer valid; explicitly don't focus windows that shouldn't be focussed; closes #486445. svn path=/trunk/; revision=3358
2007-10-16 22:29:59 +00:00
/* Returns whether a new window would be covered by any
* existing window on the same workspace that is set
* to be "above" ("always on top"). A window that is not
* set "above" would be underneath the new window anyway.
*
* We take "covered" to mean even partially covered, but
* some people might prefer entirely covered. I think it
* is more useful to behave this way if any part of the
* window is covered, because a partial coverage could be
* (say) ninety per cent and almost indistinguishable from total.
*/
static gboolean
window_would_be_covered (const MetaWindow *newbie)
{
window: Fix crash when mapping sticky window Since the introduction of set_workspace_state(), window->workspace will always be NULL when on_all_workspaces is set - passing that to a workspace function that does not validate its input will then result in a crash. Use the get_workspace() function instead, which will always return a valid workspace.
2014-09-27 02:11:00 +00:00
MetaWorkspace *workspace = meta_window_get_workspace ((MetaWindow *)newbie);
new function. rewrite assertion not to put window on top in terms of 2007-10-16 Thomas Thurman <thomas@thurman.org.uk> * src/window.c (window_would_be_covered): new function. * src/window.c (meta_window_show): rewrite assertion not to put window on top in terms of window_would_be_covered(); remove assertion because it's no longer valid; explicitly don't focus windows that shouldn't be focussed; closes #486445. svn path=/trunk/; revision=3358
2007-10-16 22:29:59 +00:00
GList *tmp, *windows;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
new function. rewrite assertion not to put window on top in terms of 2007-10-16 Thomas Thurman <thomas@thurman.org.uk> * src/window.c (window_would_be_covered): new function. * src/window.c (meta_window_show): rewrite assertion not to put window on top in terms of window_would_be_covered(); remove assertion because it's no longer valid; explicitly don't focus windows that shouldn't be focussed; closes #486445. svn path=/trunk/; revision=3358
2007-10-16 22:29:59 +00:00
windows = meta_workspace_list_windows (workspace);
tmp = windows;
while (tmp != NULL)
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
{
new function. rewrite assertion not to put window on top in terms of 2007-10-16 Thomas Thurman <thomas@thurman.org.uk> * src/window.c (window_would_be_covered): new function. * src/window.c (meta_window_show): rewrite assertion not to put window on top in terms of window_would_be_covered(); remove assertion because it's no longer valid; explicitly don't focus windows that shouldn't be focussed; closes #486445. svn path=/trunk/; revision=3358
2007-10-16 22:29:59 +00:00
MetaWindow *w = tmp->data;
newly created windows can't be considered to be above themselves; fixes 2008-03-18 Marco Pesenti Gritti <mpgritti@gmail.com> * src/core/window.c (window_would_be_covered): newly created windows can't be considered to be above themselves; fixes bug #519188. svn path=/trunk/; revision=3650
2008-03-18 12:22:25 +00:00
if (w->wm_state_above && w != newbie)
new function. rewrite assertion not to put window on top in terms of 2007-10-16 Thomas Thurman <thomas@thurman.org.uk> * src/window.c (window_would_be_covered): new function. * src/window.c (meta_window_show): rewrite assertion not to put window on top in terms of window_would_be_covered(); remove assertion because it's no longer valid; explicitly don't focus windows that shouldn't be focussed; closes #486445. svn path=/trunk/; revision=3358
2007-10-16 22:29:59 +00:00
{
/* We have found a window that is "above". Perhaps it overlaps. */
if (windows_overlap (w, newbie))
{
g_list_free (windows); /* clean up... */
return TRUE; /* yes, it does */
}
}
tmp = tmp->next;
}
g_list_free (windows);
return FALSE; /* none found */
}
core: Add support for custom window placement rules Add support for assigning a window a custom window placement rule used for calculating the initial window position as well as defining how a window is constrained. The custom rule is a declarative rule which defines a set of parameters which the placing algorithm and constrain algorithm uses for calculating the position of a window. It is meant to be used to implement positioning of menus and other popup windows created via Wayland. A custom placement rule replaces any other placement or constraint rule. https://bugzilla.gnome.org/show_bug.cgi?id=769936
2016-02-01 10:46:11 +00:00
void
wayland: update location prior to maximize When maximizing a window, the previous location is saved so that un-maximize would restore the same original window location. However, if a Wayland client starts with a window maximized, the previous location will be 0x0, so if we have to force placement in xdg_toplevel_set_maximized(), we should update the location as well so that the window is placed on the right monitor when un-maximizing. For that purpose, add a new flag to force the update of the window location, and use that flag from xdg_toplevel_set_maximized(). https://bugzilla.gnome.org/show_bug.cgi?id=783901
2017-06-21 11:30:22 +00:00
meta_window_force_placement (MetaWindow *window,
gboolean force_move)
When live_hidden_previews is set, force placement for hidden windows If we are previewing hidden windows, we might be previewing them in a context like a thumbnail view of a workspace where we care about positioning. So, instead of waiting until the window is first actually shown to place it, if live_hidden_previews is set, place the window window when we first compute its visibility, even if we don't end up showing it. https://bugzilla.gnome.org/show_bug.cgi?id=641309
2011-02-03 00:14:27 +00:00
{
wayland: update location prior to maximize When maximizing a window, the previous location is saved so that un-maximize would restore the same original window location. However, if a Wayland client starts with a window maximized, the previous location will be 0x0, so if we have to force placement in xdg_toplevel_set_maximized(), we should update the location as well so that the window is placed on the right monitor when un-maximizing. For that purpose, add a new flag to force the update of the window location, and use that flag from xdg_toplevel_set_maximized(). https://bugzilla.gnome.org/show_bug.cgi?id=783901
2017-06-21 11:30:22 +00:00
MetaMoveResizeFlags flags;
When live_hidden_previews is set, force placement for hidden windows If we are previewing hidden windows, we might be previewing them in a context like a thumbnail view of a workspace where we care about positioning. So, instead of waiting until the window is first actually shown to place it, if live_hidden_previews is set, place the window window when we first compute its visibility, even if we don't end up showing it. https://bugzilla.gnome.org/show_bug.cgi?id=641309
2011-02-03 00:14:27 +00:00
if (window->placed)
return;
/* We have to recalc the placement here since other windows may
* have been mapped/placed since we last did constrain_position
*/
/* calc_placement is an efficiency hack to avoid
* multiple placement calculations before we finally
* show the window.
*/
window->calc_placement = TRUE;
wayland: update location prior to maximize When maximizing a window, the previous location is saved so that un-maximize would restore the same original window location. However, if a Wayland client starts with a window maximized, the previous location will be 0x0, so if we have to force placement in xdg_toplevel_set_maximized(), we should update the location as well so that the window is placed on the right monitor when un-maximizing. For that purpose, add a new flag to force the update of the window location, and use that flag from xdg_toplevel_set_maximized(). https://bugzilla.gnome.org/show_bug.cgi?id=783901
2017-06-21 11:30:22 +00:00
flags = META_MOVE_RESIZE_MOVE_ACTION | META_MOVE_RESIZE_RESIZE_ACTION;
if (force_move)
flags |= META_MOVE_RESIZE_FORCE_MOVE;
meta_window_move_resize_internal (window,
flags,
NorthWestGravity,
window->unconstrained_rect);
When live_hidden_previews is set, force placement for hidden windows If we are previewing hidden windows, we might be previewing them in a context like a thumbnail view of a workspace where we care about positioning. So, instead of waiting until the window is first actually shown to place it, if live_hidden_previews is set, place the window window when we first compute its visibility, even if we don't end up showing it. https://bugzilla.gnome.org/show_bug.cgi?id=641309
2011-02-03 00:14:27 +00:00
window->calc_placement = FALSE;
/* don't ever do the initial position constraint thing again.
* This is toggled here so that initially-iconified windows
* still get placed when they are ultimately shown.
*/
window->placed = TRUE;
/* Don't want to accidentally reuse the fact that we had been denied
* focus in any future constraints unless we're denied focus again.
*/
window->denied_focus_and_not_transient = FALSE;
}
Fix missing static for meta_window_show() Definition of meta_window_show() was missing static although it was forward-declared with static. http://bugzilla.gnome.org/show_bug.cgi?id=585978
2009-06-14 11:59:59 +00:00
static void
...
2001-06-02 04:14:18 +00:00
meta_window_show (MetaWindow *window)
{
when mapping a window with struts, invalidate the work areas it's on. 2002-02-08 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_show): when mapping a window with struts, invalidate the work areas it's on. Should fix at least part of the problem with windows maximizing over panels. * src/workspace.c (meta_workspace_invalidate_work_area): also queue move/resize on sticky windows * src/tools/Makefile.am: consolidate reload-theme, restart into a "metacity-message" app and add enable/disable keybindings to the messages it knows about. * src/keybindings.c: (meta_change_keygrab): grab keyboard synchronously (meta_display_process_key_event): if all keybindings are toggled off, ReplayKeyboard, else AsyncKeyboard, except that the debug binding for toggling back on is always processed (meta_set_keybindings_disabled): function to disable/enable all keybindings
2002-02-08 06:01:58 +00:00
gboolean did_show;
Add support for _NET_WM_USER_TIME 2004-06-17 Elijah Newren <newren@math.utah.edu> Add support for _NET_WM_USER_TIME * src/display.c: (meta_display_open): Add _NET_WM_USER_TIME to atom_names[], (event_callback): Manually set _NET_WM_USER_TIME upon KeyPress (doesn't work since keyboard isn't grabbed) and ButtonPress (does work), this is just a fallback for applications that don't update this themselves. * src/display.h: (struct _MetaDisplay): Add atom_net_wm_user_time field * src/screen.c: (meta_screen_apply_startup_properties): Check for TIMESTAMP provided from startup sequence as well. * src/stack.c: s/meta_window_set_stack_position/meta_window_set_stack_position_no_sync/, (meta_window_set_stack_position): New function which calls the meta_window_set_stack_position_no_sync function followed immediately by calling meta_stack_sync_to_server. * src/window-props.c: (init_net_wm_user_time), (reload_net_wm_user_time): new functions, (reload_wm_hints): also load atom_net_wm_user_time * src/window.c: new XSERVER_TIME_IS_LATER macro (accounts for timestamp wraparound), (meta_window_new_with_attrs): add timestamp attributes, (window_takes_focus_on_map): use TIMESTAMP from startup notification and _NET_WM_USER_TIME to decide whether to focus new windows, (meta_window_show): if app doesn't take focus on map, place it just below the focused window in the stack (process_property_notify): check for changes to _NET_WM_USRE_TIME, (meta_window_stack_just_below): new function * src/window.h: (_MetaWindow struct): new fields for initial_timestamp, initial_timestamp_set, net_wm_user_time_set, and net_wm_user_time, (meta_window_stack_just_below): new function
2004-06-24 15:47:05 +00:00
gboolean takes_focus_on_map;
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
gboolean place_on_top_on_map;
Make the taskbar less flash happy and fix up some related stacking issues. 2006-01-09 Elijah Newren <newren@gmail.com> Make the taskbar less flash happy and fix up some related stacking issues. #326035. * src/window.c (windows_overlap): new function, (meta_window_show): if a window is denied focus but doesn't overlap with the focus window there is no need to set the demands attention hint nor stack that window below the focus window, (meta_window_get_outer_rect): we're not modifying the window so declare it to be const
2006-01-10 05:14:48 +00:00
gboolean needs_stacking_adjustment;
MetaWindow *focus_window;
[MetaWindow] Added boolean demands-attention property https://bugzilla.gnome.org/show_bug.cgi?id=588065
2009-11-17 10:02:06 +00:00
gboolean notify_demands_attention = FALSE;
x11: Move focus sentinel to MetaX11Display This focus sentinel is a mechanism to avoid some X11-specific race conditions in focus-follows-pointer, using X11 mechanisms. Move it to MetaX11Display altogether. https://gitlab.gnome.org/GNOME/mutter/merge_requests/420
2018-12-30 11:58:31 +00:00
MetaDisplay *display = window->display;
Add support for _NET_WM_USER_TIME 2004-06-17 Elijah Newren <newren@math.utah.edu> Add support for _NET_WM_USER_TIME * src/display.c: (meta_display_open): Add _NET_WM_USER_TIME to atom_names[], (event_callback): Manually set _NET_WM_USER_TIME upon KeyPress (doesn't work since keyboard isn't grabbed) and ButtonPress (does work), this is just a fallback for applications that don't update this themselves. * src/display.h: (struct _MetaDisplay): Add atom_net_wm_user_time field * src/screen.c: (meta_screen_apply_startup_properties): Check for TIMESTAMP provided from startup sequence as well. * src/stack.c: s/meta_window_set_stack_position/meta_window_set_stack_position_no_sync/, (meta_window_set_stack_position): New function which calls the meta_window_set_stack_position_no_sync function followed immediately by calling meta_stack_sync_to_server. * src/window-props.c: (init_net_wm_user_time), (reload_net_wm_user_time): new functions, (reload_wm_hints): also load atom_net_wm_user_time * src/window.c: new XSERVER_TIME_IS_LATER macro (accounts for timestamp wraparound), (meta_window_new_with_attrs): add timestamp attributes, (window_takes_focus_on_map): use TIMESTAMP from startup notification and _NET_WM_USER_TIME to decide whether to focus new windows, (meta_window_show): if app doesn't take focus on map, place it just below the focused window in the stack (process_property_notify): check for changes to _NET_WM_USRE_TIME, (meta_window_stack_just_below): new function * src/window.h: (_MetaWindow struct): new fields for initial_timestamp, initial_timestamp_set, net_wm_user_time_set, and net_wm_user_time, (meta_window_stack_just_below): new function
2004-06-24 15:47:05 +00:00
Throughout: move to meta_topic rather than meta_verbose so metacity.log 2002-02-07 Havoc Pennington <hp@pobox.com> Throughout: move to meta_topic rather than meta_verbose so metacity.log can start being more useful * src/util.h (enum): add more debug topics * src/frames.c: clean up some cruft that caused warnings
2002-02-08 03:34:26 +00:00
meta_topic (META_DEBUG_WINDOW_STATE,
"Showing window %s, shaded: %d iconic: %d placed: %d\n",
window->desc, window->shaded, window->iconic, window->placed);
...
2001-06-08 02:17:48 +00:00
Make the taskbar less flash happy and fix up some related stacking issues. 2006-01-09 Elijah Newren <newren@gmail.com> Make the taskbar less flash happy and fix up some related stacking issues. #326035. * src/window.c (windows_overlap): new function, (meta_window_show): if a window is denied focus but doesn't overlap with the focus window there is no need to set the demands attention hint nor stack that window below the focus window, (meta_window_get_outer_rect): we're not modifying the window so declare it to be const
2006-01-10 05:14:48 +00:00
focus_window = window->display->focus_window; /* May be NULL! */
when mapping a window with struts, invalidate the work areas it's on. 2002-02-08 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_show): when mapping a window with struts, invalidate the work areas it's on. Should fix at least part of the problem with windows maximizing over panels. * src/workspace.c (meta_workspace_invalidate_work_area): also queue move/resize on sticky windows * src/tools/Makefile.am: consolidate reload-theme, restart into a "metacity-message" app and add enable/disable keybindings to the messages it knows about. * src/keybindings.c: (meta_change_keygrab): grab keyboard synchronously (meta_display_process_key_event): if all keybindings are toggled off, ReplayKeyboard, else AsyncKeyboard, except that the debug binding for toggling back on is always processed (meta_set_keybindings_disabled): function to disable/enable all keybindings
2002-02-08 06:01:58 +00:00
did_show = FALSE;
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
window_state_on_map (window, &takes_focus_on_map, &place_on_top_on_map);
Make the taskbar less flash happy and fix up some related stacking issues. 2006-01-09 Elijah Newren <newren@gmail.com> Make the taskbar less flash happy and fix up some related stacking issues. #326035. * src/window.c (windows_overlap): new function, (meta_window_show): if a window is denied focus but doesn't overlap with the focus window there is no need to set the demands attention hint nor stack that window below the focus window, (meta_window_get_outer_rect): we're not modifying the window so declare it to be const
2006-01-10 05:14:48 +00:00
needs_stacking_adjustment = FALSE;
Add support for _NET_WM_USER_TIME 2004-06-17 Elijah Newren <newren@math.utah.edu> Add support for _NET_WM_USER_TIME * src/display.c: (meta_display_open): Add _NET_WM_USER_TIME to atom_names[], (event_callback): Manually set _NET_WM_USER_TIME upon KeyPress (doesn't work since keyboard isn't grabbed) and ButtonPress (does work), this is just a fallback for applications that don't update this themselves. * src/display.h: (struct _MetaDisplay): Add atom_net_wm_user_time field * src/screen.c: (meta_screen_apply_startup_properties): Check for TIMESTAMP provided from startup sequence as well. * src/stack.c: s/meta_window_set_stack_position/meta_window_set_stack_position_no_sync/, (meta_window_set_stack_position): New function which calls the meta_window_set_stack_position_no_sync function followed immediately by calling meta_stack_sync_to_server. * src/window-props.c: (init_net_wm_user_time), (reload_net_wm_user_time): new functions, (reload_wm_hints): also load atom_net_wm_user_time * src/window.c: new XSERVER_TIME_IS_LATER macro (accounts for timestamp wraparound), (meta_window_new_with_attrs): add timestamp attributes, (window_takes_focus_on_map): use TIMESTAMP from startup notification and _NET_WM_USER_TIME to decide whether to focus new windows, (meta_window_show): if app doesn't take focus on map, place it just below the focused window in the stack (process_property_notify): check for changes to _NET_WM_USRE_TIME, (meta_window_stack_just_below): new function * src/window.h: (_MetaWindow struct): new fields for initial_timestamp, initial_timestamp_set, net_wm_user_time_set, and net_wm_user_time, (meta_window_stack_just_below): new function
2004-06-24 15:47:05 +00:00
Don't unconditionally place splashscreens (and other not-to-befocused 2005-02-12 Elijah Newren <newren@gmail.com> Don't unconditionally place splashscreens (and other not-to-befocused windows) below the focus window. Fixes #167042. * src/window.c: (intervening_user_event_occurred): new function taken from the timestamp comparison portion of the old window_takes_focus_on_map function, (window_state_on_map): new function with remainder of old window_takes_focus_on_map function that determines both whether the window will take focus and whether it should be placed on top, (meta_window_show): use place_on_top_on_map to determine window stacking instead of trying to infer it from takes_focus_on_map
2005-02-12 07:19:41 +00:00
meta_topic (META_DEBUG_WINDOW_STATE,
"Window %s %s focus on map, and %s place on top on map.\n",
window->desc,
takes_focus_on_map ? "does" : "does not",
place_on_top_on_map ? "does" : "does not");
new function. rewrite assertion not to put window on top in terms of 2007-10-16 Thomas Thurman <thomas@thurman.org.uk> * src/window.c (window_would_be_covered): new function. * src/window.c (meta_window_show): rewrite assertion not to put window on top in terms of window_would_be_covered(); remove assertion because it's no longer valid; explicitly don't focus windows that shouldn't be focussed; closes #486445. svn path=/trunk/; revision=3358
2007-10-16 22:29:59 +00:00
/* Now, in some rare cases we should *not* put a new window on top.
adjust expression which decides whether new windows should not go on top, 2007-11-11 Thomas Thurman <thomas@thurman.org.uk> * src/window.c (meta_window_show): adjust expression which decides whether new windows should not go on top, so that restacking happens only the first time a window is mapped. Thanks to Olav Vitters for pointing out the problem. Re-fixes #486445. svn path=/trunk/; revision=3386
2007-11-12 00:45:35 +00:00
* These cases include certain types of windows showing for the first
new function. rewrite assertion not to put window on top in terms of 2007-10-16 Thomas Thurman <thomas@thurman.org.uk> * src/window.c (window_would_be_covered): new function. * src/window.c (meta_window_show): rewrite assertion not to put window on top in terms of window_would_be_covered(); remove assertion because it's no longer valid; explicitly don't focus windows that shouldn't be focussed; closes #486445. svn path=/trunk/; revision=3358
2007-10-16 22:29:59 +00:00
* time, and any window which would be covered because of another window
* being set "above" ("always on top").
*
* FIXME: Although "place_on_top_on_map" and "takes_focus_on_map" are
* generally based on the window type, there is a special case when the
* focus window is a terminal for them both to be false; this should
* probably rather be a term in the "if" condition below.
*/
adjust expression which decides whether new windows should not go on top, 2007-11-11 Thomas Thurman <thomas@thurman.org.uk> * src/window.c (meta_window_show): adjust expression which decides whether new windows should not go on top, so that restacking happens only the first time a window is mapped. Thanks to Olav Vitters for pointing out the problem. Re-fixes #486445. svn path=/trunk/; revision=3386
2007-11-12 00:45:35 +00:00
if ( focus_window != NULL && window->showing_for_first_time &&
( (!place_on_top_on_map && !takes_focus_on_map) ||
window_would_be_covered (window) )
) {
window: Do not unfocus on new window mutter would remove focus from a toplevel when showing one of its transient window which is not on top and not focused. When using xdg_popup without grab as allowed in xdg_shell v6, the popup wouldn't be focused, and if an intermediate event occurs before the popup is shown, it's not placed on top either, which could randomly trigger a loss of focus in the corresponding toplevel window. Remove that special case, it doesn't make much sense to globally unset focus when mapping a new window. https://bugzilla.gnome.org/show_bug.cgi?id=773210
2016-10-19 11:43:38 +00:00
if (!meta_window_is_ancestor_of_transient (focus_window, window))
Don't lower newly mapped windows when they're denied focus, if they are 2004-10-25 Elijah Newren <newren@math.utah.edu> Don't lower newly mapped windows when they're denied focus, if they are transients of the focused window. Instead, defocus the currently focused window. (fixes #151996). (Also, reenable focus stealing prevention and do a small spacing cleanup) * src/window-props.c (init_net_startup_id): fix spacing * src/window.c (window_takes_focus_on_map): re-enable focus stealing prevention, (meta_window_show): if the new window is denied focus and is a transient of the currently focused window, defocus the currently focused window but keep the transient on top; remove some old code about transients and focus; make sure that EnterNotify events won't accidentally focus the new window.
2004-10-25 16:28:57 +00:00
{
Make the taskbar less flash happy and fix up some related stacking issues. 2006-01-09 Elijah Newren <newren@gmail.com> Make the taskbar less flash happy and fix up some related stacking issues. #326035. * src/window.c (windows_overlap): new function, (meta_window_show): if a window is denied focus but doesn't overlap with the focus window there is no need to set the demands attention hint nor stack that window below the focus window, (meta_window_get_outer_rect): we're not modifying the window so declare it to be const
2006-01-10 05:14:48 +00:00
needs_stacking_adjustment = TRUE;
Avoid new windows being obscured by the focus window (and thus possibly 2005-02-11 Elijah Newren <newren@gmail.com> Avoid new windows being obscured by the focus window (and thus possibly lost). Fixes #166524. * src/place.c: new MetaWindowDirection enum, (find_most_freespace): new function to find where there is the most space available around the focused window, (meta_window_place): if a window is denied focus and the window overlaps the focused window, retry the first-fit algorithm only paying attention to the focus window position and if that fails just find the location on the screen with the most space available. * src/window.h: (struct MetaWindow): new denied_focus_and_not_transient bitfield * src/window.c: (meta_window_new_with_attrs): initialize denied_focus_and_not_transient, (meta_window_show): set and unset the denied_focus_and_not_transient field appropriately
2005-02-11 19:20:44 +00:00
if (!window->placed)
window->denied_focus_and_not_transient = TRUE;
Don't lower newly mapped windows when they're denied focus, if they are 2004-10-25 Elijah Newren <newren@math.utah.edu> Don't lower newly mapped windows when they're denied focus, if they are transients of the focused window. Instead, defocus the currently focused window. (fixes #151996). (Also, reenable focus stealing prevention and do a small spacing cleanup) * src/window-props.c (init_net_startup_id): fix spacing * src/window.c (window_takes_focus_on_map): re-enable focus stealing prevention, (meta_window_show): if the new window is denied focus and is a transient of the currently focused window, defocus the currently focused window but keep the transient on top; remove some old code about transients and focus; make sure that EnterNotify events won't accidentally focus the new window.
2004-10-25 16:28:57 +00:00
}
Have newly mapped windows that are denied focus appear after the focused 2004-08-05 Elijah Newren <newren@math.utah.edu> Have newly mapped windows that are denied focus appear after the focused window in the alt-tab list. This allows one to switch to such a window with a single alt-tab press. * src/window.c (ensure_mru_position_after): new function, (meta_window_show): If newly mapped window is denied focus, call ensure_mru_position_after to make the window appear after the focus window in the mru list.
2004-08-05 17:48:39 +00:00
}
Add support for _NET_WM_USER_TIME 2004-06-17 Elijah Newren <newren@math.utah.edu> Add support for _NET_WM_USER_TIME * src/display.c: (meta_display_open): Add _NET_WM_USER_TIME to atom_names[], (event_callback): Manually set _NET_WM_USER_TIME upon KeyPress (doesn't work since keyboard isn't grabbed) and ButtonPress (does work), this is just a fallback for applications that don't update this themselves. * src/display.h: (struct _MetaDisplay): Add atom_net_wm_user_time field * src/screen.c: (meta_screen_apply_startup_properties): Check for TIMESTAMP provided from startup sequence as well. * src/stack.c: s/meta_window_set_stack_position/meta_window_set_stack_position_no_sync/, (meta_window_set_stack_position): New function which calls the meta_window_set_stack_position_no_sync function followed immediately by calling meta_stack_sync_to_server. * src/window-props.c: (init_net_wm_user_time), (reload_net_wm_user_time): new functions, (reload_wm_hints): also load atom_net_wm_user_time * src/window.c: new XSERVER_TIME_IS_LATER macro (accounts for timestamp wraparound), (meta_window_new_with_attrs): add timestamp attributes, (window_takes_focus_on_map): use TIMESTAMP from startup notification and _NET_WM_USER_TIME to decide whether to focus new windows, (meta_window_show): if app doesn't take focus on map, place it just below the focused window in the stack (process_property_notify): check for changes to _NET_WM_USRE_TIME, (meta_window_stack_just_below): new function * src/window.h: (_MetaWindow struct): new fields for initial_timestamp, initial_timestamp_set, net_wm_user_time_set, and net_wm_user_time, (meta_window_stack_just_below): new function
2004-06-24 15:47:05 +00:00
...
2001-06-24 08:09:10 +00:00
if (!window->placed)
Automaximize large windows on map Windows that start up in a size that is almost as big as the workarea create extra work for the user (resizing or maximizing) so save the user's time by detecting such windows and automaximize them. https://bugzilla.gnome.org/show_bug.cgi?id=671677
2012-03-15 19:42:11 +00:00
{
window: Don't try to auto-maximize when headless Automatic maximization is done when a window is almost the size of the work area of a monitor. This makes no sense to try when there is no monitor available, so skip trying to do this when headless. https://bugzilla.gnome.org/show_bug.cgi?id=787637
2017-09-25 18:11:22 +00:00
if (window->monitor &&
meta_prefs_get_auto_maximize() &&
window->showing_for_first_time &&
window->has_maximize_func)
Automaximize large windows on map Windows that start up in a size that is almost as big as the workarea create extra work for the user (resizing or maximizing) so save the user's time by detecting such windows and automaximize them. https://bugzilla.gnome.org/show_bug.cgi?id=671677
2012-03-15 19:42:11 +00:00
{
MetaRectangle work_area;
meta_window_get_work_area_for_monitor (window, window->monitor->number, &work_area);
/* Automaximize windows that map with a size > MAX_UNMAXIMIZED_WINDOW_AREA of the work area */
if (window->rect.width * window->rect.height > work_area.width * work_area.height * MAX_UNMAXIMIZED_WINDOW_AREA)
{
window->maximize_horizontally_after_placement = TRUE;
window->maximize_vertically_after_placement = TRUE;
}
}
wayland: update location prior to maximize When maximizing a window, the previous location is saved so that un-maximize would restore the same original window location. However, if a Wayland client starts with a window maximized, the previous location will be 0x0, so if we have to force placement in xdg_toplevel_set_maximized(), we should update the location as well so that the window is placed on the right monitor when un-maximizing. For that purpose, add a new flag to force the update of the window location, and use that flag from xdg_toplevel_set_maximized(). https://bugzilla.gnome.org/show_bug.cgi?id=783901
2017-06-21 11:30:22 +00:00
meta_window_force_placement (window, FALSE);
Automaximize large windows on map Windows that start up in a size that is almost as big as the workarea create extra work for the user (resizing or maximizing) so save the user's time by detecting such windows and automaximize them. https://bugzilla.gnome.org/show_bug.cgi?id=671677
2012-03-15 19:42:11 +00:00
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Patch from Thomas Andersen to make windows be stacked correctly before 2006-09-13 Elijah Newren <newren gmail com> * src/window.c (meta_window_show): Patch from Thomas Andersen to make windows be stacked correctly before showing them, to prevent flicker with focus stealing prevention. #332385.
2006-09-13 22:21:19 +00:00
if (needs_stacking_adjustment)
{
Patch from Jens Granseuer to fix c89 cleanness, again. #356631. 2006-09-18 Elijah Newren <newren gmail com> * src/window.c (meta_window_show): Patch from Jens Granseuer to fix c89 cleanness, again. #356631.
2006-09-18 22:00:57 +00:00
gboolean overlap;
Patch from Thomas Andersen to make windows be stacked correctly before 2006-09-13 Elijah Newren <newren gmail com> * src/window.c (meta_window_show): Patch from Thomas Andersen to make windows be stacked correctly before showing them, to prevent flicker with focus stealing prevention. #332385.
2006-09-13 22:21:19 +00:00
/* This window isn't getting focus on map. We may need to do some
* special handing with it in regards to
* - the stacking of the window
* - the MRU position of the window
* - the demands attention setting of the window
new function. rewrite assertion not to put window on top in terms of 2007-10-16 Thomas Thurman <thomas@thurman.org.uk> * src/window.c (window_would_be_covered): new function. * src/window.c (meta_window_show): rewrite assertion not to put window on top in terms of window_would_be_covered(); remove assertion because it's no longer valid; explicitly don't focus windows that shouldn't be focussed; closes #486445. svn path=/trunk/; revision=3358
2007-10-16 22:29:59 +00:00
*
* Firstly, set the flag so we don't give the window focus anyway
* and confuse people.
Patch from Thomas Andersen to make windows be stacked correctly before 2006-09-13 Elijah Newren <newren gmail com> * src/window.c (meta_window_show): Patch from Thomas Andersen to make windows be stacked correctly before showing them, to prevent flicker with focus stealing prevention. #332385.
2006-09-13 22:21:19 +00:00
*/
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
new function. rewrite assertion not to put window on top in terms of 2007-10-16 Thomas Thurman <thomas@thurman.org.uk> * src/window.c (window_would_be_covered): new function. * src/window.c (meta_window_show): rewrite assertion not to put window on top in terms of window_would_be_covered(); remove assertion because it's no longer valid; explicitly don't focus windows that shouldn't be focussed; closes #486445. svn path=/trunk/; revision=3358
2007-10-16 22:29:59 +00:00
takes_focus_on_map = FALSE;
Patch from Thomas Andersen to make windows be stacked correctly before 2006-09-13 Elijah Newren <newren gmail com> * src/window.c (meta_window_show): Patch from Thomas Andersen to make windows be stacked correctly before showing them, to prevent flicker with focus stealing prevention. #332385.
2006-09-13 22:21:19 +00:00
overlap = windows_overlap (window, focus_window);
/* We want alt tab to go to the denied-focus window */
ensure_mru_position_after (window, focus_window);
/* We don't want the denied-focus window to obscure the focus
* window, and if we're in both click-to-focus mode and
* raise-on-click mode then we want to maintain the invariant
* that MRU order == stacking order. The need for this if
* comes from the fact that in sloppy/mouse focus the focus
* window may not overlap other windows and also can be
* considered "below" them; this combination means that
* placing the denied-focus window "below" the focus window
* in the stack when it doesn't overlap it confusingly places
* that new window below a lot of other windows.
*/
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
if (overlap ||
Port preferences to GSettings Move preferences to GSettings, using mainly shared schemas from gsettings-desktop-schemas. Unlike GConf, GSettings support is not optional, as Gio is already a hard dependency of GTK+. https://bugzilla.gnome.org/show_bug.cgi?id=635378
2011-06-24 16:14:15 +00:00
(meta_prefs_get_focus_mode () == G_DESKTOP_FOCUS_MODE_CLICK &&
Patch from Thomas Andersen to make windows be stacked correctly before 2006-09-13 Elijah Newren <newren gmail com> * src/window.c (meta_window_show): Patch from Thomas Andersen to make windows be stacked correctly before showing them, to prevent flicker with focus stealing prevention. #332385.
2006-09-13 22:21:19 +00:00
meta_prefs_get_raise_on_click ()))
meta_window_stack_just_below (window, focus_window);
/* If the window will be obscured by the focus window, then the
* user might not notice the window appearing so set the
* demands attention hint.
*
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
* We set the hint ourselves rather than calling
Patch from Thomas Andersen to make windows be stacked correctly before 2006-09-13 Elijah Newren <newren gmail com> * src/window.c (meta_window_show): Patch from Thomas Andersen to make windows be stacked correctly before showing them, to prevent flicker with focus stealing prevention. #332385.
2006-09-13 22:21:19 +00:00
* meta_window_set_demands_attention() because that would cause
* a recalculation of overlap, and a call to set_net_wm_state()
* which we are going to call ourselves here a few lines down.
*/
if (overlap)
[MetaWindow] Added boolean demands-attention property https://bugzilla.gnome.org/show_bug.cgi?id=588065
2009-11-17 10:02:06 +00:00
{
if (!window->wm_state_demands_attention)
{
window->wm_state_demands_attention = TRUE;
notify_demands_attention = TRUE;
}
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
}
Patch from Thomas Andersen to make windows be stacked correctly before 2006-09-13 Elijah Newren <newren gmail com> * src/window.c (meta_window_show): Patch from Thomas Andersen to make windows be stacked correctly before showing them, to prevent flicker with focus stealing prevention. #332385.
2006-09-13 22:21:19 +00:00
Always map the client and frame windows Traditionally, WMs unmap windows when minimizing them, and map them when restoring them or wanting to show them for other reasons, like upon creation. However, as metacity morphed into mutter, we optionally chose to keep windows mapped for the lifetime of the window under the user option "live-window-previews", which makes the code keep windows mapped so it can show window preview for minimized windows in other places, like Alt-Tab and Expose. I removed this preference two years ago mechanically, by removing all the if statements, but never went through and cleaned up the code so that windows are simply mapped for the lifetime of the window -- the "architecture" of the old code that maps and unmaps on show/hide was still there. Remove this now. The one case we still need to be careful of is shaded windows, in which we do still unmap the client window. In the future, we might want to show previews of shaded windows in the overview and Alt-Tab. In that we'd also keep shaded windows mapped, and could remove all unmap logic, but we'd need a more complex method of showing the shaded titlebar, such as using a different actor. At the same time, simplify the compositor interface by removing meta_compositor_window_[un]mapped API, and instead adding/removing the window on-demand. https://bugzilla.gnome.org/show_bug.cgi?id=720631
2014-02-02 00:06:51 +00:00
if (window->hidden)
...
2001-06-08 02:17:48 +00:00
{
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_freeze (window->display->stack);
Always map the client and frame windows Traditionally, WMs unmap windows when minimizing them, and map them when restoring them or wanting to show them for other reasons, like upon creation. However, as metacity morphed into mutter, we optionally chose to keep windows mapped for the lifetime of the window under the user option "live-window-previews", which makes the code keep windows mapped so it can show window preview for minimized windows in other places, like Alt-Tab and Expose. I removed this preference two years ago mechanically, by removing all the if statements, but never went through and cleaned up the code so that windows are simply mapped for the lifetime of the window -- the "architecture" of the old code that maps and unmaps on show/hide was still there. Remove this now. The one case we still need to be careful of is shaded windows, in which we do still unmap the client window. In the future, we might want to show previews of shaded windows in the overview and Alt-Tab. In that we'd also keep shaded windows mapped, and could remove all unmap logic, but we'd need a more complex method of showing the shaded titlebar, such as using a different actor. At the same time, simplify the compositor interface by removing meta_compositor_window_[un]mapped API, and instead adding/removing the window on-demand. https://bugzilla.gnome.org/show_bug.cgi?id=720631
2014-02-02 00:06:51 +00:00
window->hidden = FALSE;
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_thaw (window->display->stack);
Always map the client and frame windows Traditionally, WMs unmap windows when minimizing them, and map them when restoring them or wanting to show them for other reasons, like upon creation. However, as metacity morphed into mutter, we optionally chose to keep windows mapped for the lifetime of the window under the user option "live-window-previews", which makes the code keep windows mapped so it can show window preview for minimized windows in other places, like Alt-Tab and Expose. I removed this preference two years ago mechanically, by removing all the if statements, but never went through and cleaned up the code so that windows are simply mapped for the lifetime of the window -- the "architecture" of the old code that maps and unmaps on show/hide was still there. Remove this now. The one case we still need to be careful of is shaded windows, in which we do still unmap the client window. In the future, we might want to show previews of shaded windows in the overview and Alt-Tab. In that we'd also keep shaded windows mapped, and could remove all unmap logic, but we'd need a more complex method of showing the shaded titlebar, such as using a different actor. At the same time, simplify the compositor interface by removing meta_compositor_window_[un]mapped API, and instead adding/removing the window on-demand. https://bugzilla.gnome.org/show_bug.cgi?id=720631
2014-02-02 00:06:51 +00:00
did_show = TRUE;
Revert unintentional merge from wip/surface-content to wayland This reverts a lot of commits.
2014-01-22 14:16:56 +00:00
}
Always map the client and frame windows Traditionally, WMs unmap windows when minimizing them, and map them when restoring them or wanting to show them for other reasons, like upon creation. However, as metacity morphed into mutter, we optionally chose to keep windows mapped for the lifetime of the window under the user option "live-window-previews", which makes the code keep windows mapped so it can show window preview for minimized windows in other places, like Alt-Tab and Expose. I removed this preference two years ago mechanically, by removing all the if statements, but never went through and cleaned up the code so that windows are simply mapped for the lifetime of the window -- the "architecture" of the old code that maps and unmaps on show/hide was still there. Remove this now. The one case we still need to be careful of is shaded windows, in which we do still unmap the client window. In the future, we might want to show previews of shaded windows in the overview and Alt-Tab. In that we'd also keep shaded windows mapped, and could remove all unmap logic, but we'd need a more complex method of showing the shaded titlebar, such as using a different actor. At the same time, simplify the compositor interface by removing meta_compositor_window_[un]mapped API, and instead adding/removing the window on-demand. https://bugzilla.gnome.org/show_bug.cgi?id=720631
2014-02-02 00:06:51 +00:00
if (window->iconic)
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
{
Always map the client and frame windows Traditionally, WMs unmap windows when minimizing them, and map them when restoring them or wanting to show them for other reasons, like upon creation. However, as metacity morphed into mutter, we optionally chose to keep windows mapped for the lifetime of the window under the user option "live-window-previews", which makes the code keep windows mapped so it can show window preview for minimized windows in other places, like Alt-Tab and Expose. I removed this preference two years ago mechanically, by removing all the if statements, but never went through and cleaned up the code so that windows are simply mapped for the lifetime of the window -- the "architecture" of the old code that maps and unmaps on show/hide was still there. Remove this now. The one case we still need to be careful of is shaded windows, in which we do still unmap the client window. In the future, we might want to show previews of shaded windows in the overview and Alt-Tab. In that we'd also keep shaded windows mapped, and could remove all unmap logic, but we'd need a more complex method of showing the shaded titlebar, such as using a different actor. At the same time, simplify the compositor interface by removing meta_compositor_window_[un]mapped API, and instead adding/removing the window on-demand. https://bugzilla.gnome.org/show_bug.cgi?id=720631
2014-02-02 00:06:51 +00:00
window->iconic = FALSE;
set_wm_state (window);
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
if (!window->visible_to_compositor)
{
Assume the compositor always exists At one point, it was supported to run mutter without a compositor, but we don't allow that any longer. A lot of code already assumes display->compositor exists and doesn't check for a NULL pointer, so just kill the rest of the checks.
2014-03-18 21:06:42 +00:00
MetaCompEffect effect = META_COMP_EFFECT_NONE;
Update window->visible_to_compositor before calling into compositor To deal with reentrancy from compositor plugins doing things like moving windows between workspaces in an effect callback, update the visible_to_compositor flag before calling into the compositor. https://bugzilla.gnome.org/show_bug.cgi?id=613124
2011-01-04 16:43:02 +00:00
window->visible_to_compositor = TRUE;
Assume the compositor always exists At one point, it was supported to run mutter without a compositor, but we don't allow that any longer. A lot of code already assumes display->compositor exists and doesn't check for a NULL pointer, so just kill the rest of the checks.
2014-03-18 21:06:42 +00:00
switch (window->pending_compositor_effect)
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
{
Assume the compositor always exists At one point, it was supported to run mutter without a compositor, but we don't allow that any longer. A lot of code already assumes display->compositor exists and doesn't check for a NULL pointer, so just kill the rest of the checks.
2014-03-18 21:06:42 +00:00
case META_COMP_EFFECT_CREATE:
case META_COMP_EFFECT_UNMINIMIZE:
effect = window->pending_compositor_effect;
break;
case META_COMP_EFFECT_NONE:
case META_COMP_EFFECT_DESTROY:
case META_COMP_EFFECT_MINIMIZE:
break;
Ensure that meta_compositor_map_window() is even when we only get MapNotify.
2009-01-12 16:41:06 +00:00
}
Assume the compositor always exists At one point, it was supported to run mutter without a compositor, but we don't allow that any longer. A lot of code already assumes display->compositor exists and doesn't check for a NULL pointer, so just kill the rest of the checks.
2014-03-18 21:06:42 +00:00
meta_compositor_show_window (window->display->compositor,
window, effect);
window: Don't reset pending_compositor_effect too early With our surface_mapped strategy, implement_showing might not change whether the window has been shown or not, and thus we might end up clearing pending_compositor_effect before the window is mapped. Only clear pending_compositor_effect when the effect has actually been used.
2014-04-28 20:58:45 +00:00
window->pending_compositor_effect = META_COMP_EFFECT_NONE;
...
2001-06-06 04:47:37 +00:00
}
handle queue/unqueue of calc showings as we are iterating over the pending 2001-10-29 Havoc Pennington <hp@pobox.com> * src/window.c (idle_calc_showing): handle queue/unqueue of calc showings as we are iterating over the pending list (meta_window_show): focus placed transients in here instead of in meta_window_place - now it should actually work, yay * src/place.c (meta_window_place): remove focusing of transient child from here; this was really broken
2001-10-30 02:00:53 +00:00
Focus windows that manually position themselves too (fixes #107347). 2004-12-27 Elijah Newren <newren@gmail.com> Focus windows that manually position themselves too (fixes #107347). * src/window.h (struct _MetaWindow): add a new showing_for_first_time flag * src/window.c (meta_window_new_with_attrs): initialize showing_for_first_time flag to !mapped, (meta_window_show): replace did_placement with showing_for_first_time in the section to decided whether to focus since did_placement isn't quite what we want
2004-12-28 06:01:42 +00:00
/* We don't want to worry about all cases from inside
* implement_showing(); we only want to worry about focus if this
* window has not been shown before.
*/
if (window->showing_for_first_time)
handle queue/unqueue of calc showings as we are iterating over the pending 2001-10-29 Havoc Pennington <hp@pobox.com> * src/window.c (idle_calc_showing): handle queue/unqueue of calc showings as we are iterating over the pending list (meta_window_show): focus placed transients in here instead of in meta_window_place - now it should actually work, yay * src/place.c (meta_window_place): remove focusing of transient child from here; this was really broken
2001-10-30 02:00:53 +00:00
{
Focus windows that manually position themselves too (fixes #107347). 2004-12-27 Elijah Newren <newren@gmail.com> Focus windows that manually position themselves too (fixes #107347). * src/window.h (struct _MetaWindow): add a new showing_for_first_time flag * src/window.c (meta_window_new_with_attrs): initialize showing_for_first_time flag to !mapped, (meta_window_show): replace did_placement with showing_for_first_time in the section to decided whether to focus since did_placement isn't quite what we want
2004-12-28 06:01:42 +00:00
window->showing_for_first_time = FALSE;
Add support for _NET_WM_USER_TIME 2004-06-17 Elijah Newren <newren@math.utah.edu> Add support for _NET_WM_USER_TIME * src/display.c: (meta_display_open): Add _NET_WM_USER_TIME to atom_names[], (event_callback): Manually set _NET_WM_USER_TIME upon KeyPress (doesn't work since keyboard isn't grabbed) and ButtonPress (does work), this is just a fallback for applications that don't update this themselves. * src/display.h: (struct _MetaDisplay): Add atom_net_wm_user_time field * src/screen.c: (meta_screen_apply_startup_properties): Check for TIMESTAMP provided from startup sequence as well. * src/stack.c: s/meta_window_set_stack_position/meta_window_set_stack_position_no_sync/, (meta_window_set_stack_position): New function which calls the meta_window_set_stack_position_no_sync function followed immediately by calling meta_stack_sync_to_server. * src/window-props.c: (init_net_wm_user_time), (reload_net_wm_user_time): new functions, (reload_wm_hints): also load atom_net_wm_user_time * src/window.c: new XSERVER_TIME_IS_LATER macro (accounts for timestamp wraparound), (meta_window_new_with_attrs): add timestamp attributes, (window_takes_focus_on_map): use TIMESTAMP from startup notification and _NET_WM_USER_TIME to decide whether to focus new windows, (meta_window_show): if app doesn't take focus on map, place it just below the focused window in the stack (process_property_notify): check for changes to _NET_WM_USRE_TIME, (meta_window_stack_just_below): new function * src/window.h: (_MetaWindow struct): new fields for initial_timestamp, initial_timestamp_set, net_wm_user_time_set, and net_wm_user_time, (meta_window_stack_just_below): new function
2004-06-24 15:47:05 +00:00
if (takes_focus_on_map)
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
{
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
guint32 timestamp;
timestamp = meta_display_get_current_time_roundtrip (window->display);
Partial audit to fix timestamp usage. One step towards fixing #355180; see 2006-09-18 Elijah Newren <newren gmail com> Partial audit to fix timestamp usage. One step towards fixing #355180; see important comments in that bug. * src/core.[ch] (meta_core_unshade, meta_core_shade): * src/delete.c (meta_window_present_delete_dialog, delete_ping_timeout_func): * src/display.[ch] (meta_display_open, meta_display_close, event_callback, meta_display_begin_grab_op, process_selection_clear, meta_display_unmanage_screen, meta_display_unmanage_windows_for_screen): * src/frames.c (meta_frames_button_press_event): * src/keybindings.c (handle_toggle_shade): * src/main.c (main): * src/screen.[ch] (update_num_workspaces, meta_screen_new, meta_screen_free, prefs_changed_callback): * src/window.[ch] (meta_window_free, finish_minimize, implement_showing, meta_window_show, meta_window_maximize, meta_window_make_fullscreen_internal, meta_window_unmake_fullscreen, meta_window_shade, meta_window_unshade, window_activate, send_sync_request, meta_window_client_message, menu_callback, meta_window_update_keyboard_resize): Remove usage of CurrentTime, meta_display_get_current_time() and meta_display_get_current_time_roundtrip() where possible, or document why it isn't possible, or at very least add a FIXME with some explanation of my laziness and what needs to be done.
2006-09-18 17:27:24 +00:00
meta_window_focus (window, timestamp);
don't focus dock, desktop, etc. windows on initial map, only windows that 2002-05-16 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_show): don't focus dock, desktop, etc. windows on initial map, only windows that should have focus.
2002-05-16 19:08:20 +00:00
}
x11: Move focus sentinel to MetaX11Display This focus sentinel is a mechanism to avoid some X11-specific race conditions in focus-follows-pointer, using X11 mechanisms. Move it to MetaX11Display altogether. https://gitlab.gnome.org/GNOME/mutter/merge_requests/420
2018-12-30 11:58:31 +00:00
else if (display->x11_display)
Don't lower newly mapped windows when they're denied focus, if they are 2004-10-25 Elijah Newren <newren@math.utah.edu> Don't lower newly mapped windows when they're denied focus, if they are transients of the focused window. Instead, defocus the currently focused window. (fixes #151996). (Also, reenable focus stealing prevention and do a small spacing cleanup) * src/window-props.c (init_net_startup_id): fix spacing * src/window.c (window_takes_focus_on_map): re-enable focus stealing prevention, (meta_window_show): if the new window is denied focus and is a transient of the currently focused window, defocus the currently focused window but keep the transient on top; remove some old code about transients and focus; make sure that EnterNotify events won't accidentally focus the new window.
2004-10-25 16:28:57 +00:00
{
/* Prevent EnterNotify events in sloppy/mouse focus from
* erroneously focusing the window that had been denied
* focus. FIXME: This introduces a race; I have a couple
* ideas for a better way to accomplish the same thing, but
* they're more involved so do it this way for now.
*/
x11: Move focus sentinel to MetaX11Display This focus sentinel is a mechanism to avoid some X11-specific race conditions in focus-follows-pointer, using X11 mechanisms. Move it to MetaX11Display altogether. https://gitlab.gnome.org/GNOME/mutter/merge_requests/420
2018-12-30 11:58:31 +00:00
meta_x11_display_increment_focus_sentinel (display->x11_display);
Don't lower newly mapped windows when they're denied focus, if they are 2004-10-25 Elijah Newren <newren@math.utah.edu> Don't lower newly mapped windows when they're denied focus, if they are transients of the focused window. Instead, defocus the currently focused window. (fixes #151996). (Also, reenable focus stealing prevention and do a small spacing cleanup) * src/window-props.c (init_net_startup_id): fix spacing * src/window.c (window_takes_focus_on_map): re-enable focus stealing prevention, (meta_window_show): if the new window is denied focus and is a transient of the currently focused window, defocus the currently focused window but keep the transient on top; remove some old code about transients and focus; make sure that EnterNotify events won't accidentally focus the new window.
2004-10-25 16:28:57 +00:00
}
handle queue/unqueue of calc showings as we are iterating over the pending 2001-10-29 Havoc Pennington <hp@pobox.com> * src/window.c (idle_calc_showing): handle queue/unqueue of calc showings as we are iterating over the pending list (meta_window_show): focus placed transients in here instead of in meta_window_place - now it should actually work, yay * src/place.c (meta_window_place): remove focusing of transient child from here; this was really broken
2001-10-30 02:00:53 +00:00
}
when mapping a window with struts, invalidate the work areas it's on. 2002-02-08 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_show): when mapping a window with struts, invalidate the work areas it's on. Should fix at least part of the problem with windows maximizing over panels. * src/workspace.c (meta_workspace_invalidate_work_area): also queue move/resize on sticky windows * src/tools/Makefile.am: consolidate reload-theme, restart into a "metacity-message" app and add enable/disable keybindings to the messages it knows about. * src/keybindings.c: (meta_change_keygrab): grab keyboard synchronously (meta_display_process_key_event): if all keybindings are toggled off, ReplayKeyboard, else AsyncKeyboard, except that the debug binding for toggling back on is always processed (meta_set_keybindings_disabled): function to disable/enable all keybindings
2002-02-08 06:01:58 +00:00
Always set _NET_WM_STATE when a window is shown or hidden, even if it 2006-03-03 Thomas Thurman <thomas@thurman.org.uk> Always set _NET_WM_STATE when a window is shown or hidden, even if it wasn't mapped. * src/window.c (meta_window_hide, meta_window_show): call set_net_wm_state unconditionally
2006-03-17 03:26:25 +00:00
set_net_wm_state (window);
Fix some support for EWMH hints, and fix USER_TIME support to include the 2004-07-31 Rob Adams <readams@readams.net> Fix some support for EWMH hints, and fix USER_TIME support to include the DEMANDS_ATTENTION hint. Also includes some code for implementing _NET_RESTACK_WINDOW and _NET_MOVERESIZE_WINDOW, but this is disabled pending feature thaw. * COMPLIANCE: update with new information * src/display.c (meta_display_open): add new hints to list * src/display.h (_MetaDisplay): Add new atoms to struct * src/screen.c (set_supported_hint): update the list of support hints. (set_desktop_viewport_hint): new function sets the viewport hint to (0,0) as required by the spec for WMs with no viewport support. (set_desktop_geometry_hint): new function to set the desktop size hint to the size of the display, since we don't implement large desktop support, as required by the spec. (meta_screen_resize): update the geometry hint on screen resize * src/window.c (meta_window_new_with_attrs): Initialize demands_attention state (set_net_wm_state): Set demands_attention hint in the window state (meta_window_show): If we don't pop up a window because of USER_TIME, set DEMANDS_ATTENTION on the window. (meta_window_focus): When a window receives focus, remove DEMANDS_ATTENTION hint (meta_window_client_message): Allow other apps to set DEMANDS_ATTENTION on a window. Also, if the _NET_ACTIVE_WINDOW hint includes a timestamp, use it. (update_net_wm_state): Read DEMANDS_ATTENTION state also * src/window.h (_MetaWindow): add wm_state_demands_attention bit.
2004-07-31 19:56:10 +00:00
Always set _NET_WM_STATE when a window is shown or hidden, even if it 2006-03-03 Thomas Thurman <thomas@thurman.org.uk> Always set _NET_WM_STATE when a window is shown or hidden, even if it wasn't mapped. * src/window.c (meta_window_hide, meta_window_show): call set_net_wm_state unconditionally
2006-03-17 03:26:25 +00:00
if (did_show && window->struts)
{
meta_topic (META_DEBUG_WORKAREA,
"Mapped window %s with struts, so invalidating work areas\n",
window->desc);
invalidate_work_areas (window);
when mapping a window with struts, invalidate the work areas it's on. 2002-02-08 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_show): when mapping a window with struts, invalidate the work areas it's on. Should fix at least part of the problem with windows maximizing over panels. * src/workspace.c (meta_workspace_invalidate_work_area): also queue move/resize on sticky windows * src/tools/Makefile.am: consolidate reload-theme, restart into a "metacity-message" app and add enable/disable keybindings to the messages it knows about. * src/keybindings.c: (meta_change_keygrab): grab keyboard synchronously (meta_display_process_key_event): if all keybindings are toggled off, ReplayKeyboard, else AsyncKeyboard, except that the debug binding for toggling back on is always processed (meta_set_keybindings_disabled): function to disable/enable all keybindings
2002-02-08 06:01:58 +00:00
}
Use correct timestamp for focus stealing prevention When window initially maps, use the more recent of NET_WM_USER_TIME and startup notification timestamps to compare against last known user action to decide whether to focus the window or not. Once we show the window, clear the initial_timestamp_set flag, so the startup notification timestamp is not taken into account again. Based on patch for metacity by Alexander Larsson http://bugzilla.gnome.org/show_bug.cgi?id=573922
2009-08-08 16:59:01 +00:00
MetaScreen: Add tracking of whether there are fullscreen windows Trying to track the fullscreen status outside of Mutter, as GNOME Shell was doing previously, was very prone to errors, because Mutter has a very tricky definition of when a window is set to be fullscreen and *actually* acting like a fullscreen window. * Add meta_screen_get_monitor_in_fullscreen() and an ::in-fullscreen-changed signal. This allows an application to track when there are fullscreen windows on a monitor. * Do the computation of fullscreen status in a "later" function that runs after showing, so we properly take focus into account. * To get ordering of different phases right, add more values to MetaLaterType. * Add auto-minimization, similar to what was added to GNOME Shell earlier in this cycle - if a window is set to be fullscreen, but not actually fullscreen, minimize. https://bugzilla.gnome.org/show_bug.cgi?id=649748
2013-03-14 20:55:49 +00:00
if (did_show)
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
meta_display_queue_check_fullscreen (window->display);
MetaScreen: Add tracking of whether there are fullscreen windows Trying to track the fullscreen status outside of Mutter, as GNOME Shell was doing previously, was very prone to errors, because Mutter has a very tricky definition of when a window is set to be fullscreen and *actually* acting like a fullscreen window. * Add meta_screen_get_monitor_in_fullscreen() and an ::in-fullscreen-changed signal. This allows an application to track when there are fullscreen windows on a monitor. * Do the computation of fullscreen status in a "later" function that runs after showing, so we properly take focus into account. * To get ordering of different phases right, add more values to MetaLaterType. * Add auto-minimization, similar to what was added to GNOME Shell earlier in this cycle - if a window is set to be fullscreen, but not actually fullscreen, minimize. https://bugzilla.gnome.org/show_bug.cgi?id=649748
2013-03-14 20:55:49 +00:00
Use correct timestamp for focus stealing prevention When window initially maps, use the more recent of NET_WM_USER_TIME and startup notification timestamps to compare against last known user action to decide whether to focus the window or not. Once we show the window, clear the initial_timestamp_set flag, so the startup notification timestamp is not taken into account again. Based on patch for metacity by Alexander Larsson http://bugzilla.gnome.org/show_bug.cgi?id=573922
2009-08-08 16:59:01 +00:00
/*
* Now that we have shown the window, we no longer want to consider the
* initial timestamp in any subsequent deliberations whether to focus this
* window or not, so clear the flag.
*
* See http://bugzilla.gnome.org/show_bug.cgi?id=573922
*/
window->initial_timestamp_set = FALSE;
[MetaWindow] Added boolean demands-attention property https://bugzilla.gnome.org/show_bug.cgi?id=588065
2009-11-17 10:02:06 +00:00
if (notify_demands_attention)
[MetaDisplay] Added window-demands-attention signal Having a MetaDisplay::window-demands-attention signal allows to deal with windows demanding attention in a cetralized fashion. The signal is emitted when a window is created with initial demands-attention state and/or when the state changes later on. Based on original patch by Jon Nettleton. https://bugzilla.gnome.org/show_bug.cgi?id=597052
2009-10-28 17:19:24 +00:00
{
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_DEMANDS_ATTENTION]);
[MetaDisplay] Added window-demands-attention signal Having a MetaDisplay::window-demands-attention signal allows to deal with windows demanding attention in a cetralized fashion. The signal is emitted when a window is created with initial demands-attention state and/or when the state changes later on. Based on original patch by Jon Nettleton. https://bugzilla.gnome.org/show_bug.cgi?id=597052
2009-10-28 17:19:24 +00:00
g_signal_emit_by_name (window->display, "window-demands-attention",
window);
}
tests: Move window-shown verification to test-runner Previously we relied on the test-client to make sure that a window was shown. For X11, we did not need to do anything, but for Wayland we had to make sure we had drawn the first frame, otherwise mutter wouldn't have a buffer making the window not showable. Doing it this way doesn't work anymore however, since the 'after-paint' event will be emitted even if we didn't actually paint anything. This is the case with current Gtk under Wayland, where we won't draw until the compositor has configured the surface. In effect, this mean we'll get a dummy after-paint emission before the first frame is actually painted. Instead, move the verification that a "show" command has completed by having the test-runner wait for a "shown" signal on the window, which is emitted in the end of meta_window_show(). This requires an additional call to gdk_display_sync() in the test-client after creating the window, to make sure that the window creation vents has been received in the compositor.
2018-07-12 08:25:16 +00:00
if (did_show)
g_signal_emit (window, window_signals[SHOWN], 0);
...
2001-06-02 04:14:18 +00:00
}
Add a dependency on libcm when building with compositor. Fri Jan 13 14:40:19 2006 Søren Sandmann <sandmann@redhat.com> * configure.in: Add a dependency on libcm when building with compositor. * src/window.c (meta_window_hide): Make this function static. * src/window.c (implement_showing): Use meta_compositor_minimize() to do a weird minimize effect. * src/compositor.[ch]: Beginning of new GL based compositor. * src/screen.h (struct _MetaScreen): Add void pointer to compositor data. * src/screen.c (meta_screen_new): Remove obsolete compositor stuff; initialize compositor_data. Don't composite manage screen out of this function. * src/errors.c (x_error_handler): Check that display is non-NULL before using it. Add comment about how that can happen. * src/display.c (meta_display_{begin,end}_grab_op): Remove explicity damage of windows. * src/display.c (meta_display_open): Composite manage all the screens.
2006-01-13 19:41:01 +00:00
static void
...
2001-06-02 04:14:18 +00:00
meta_window_hide (MetaWindow *window)
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
only bump unmaps_pending if the window was mapped 2002-01-10 Havoc Pennington <hp@pobox.com> * src/frame.c (meta_window_destroy_frame): only bump unmaps_pending if the window was mapped (meta_window_ensure_frame): ditto * src/keybindings.c: change arrow key bindings to use Ctrl+Alt not just Alt, and add debug mode key bindings * src/stack.c (meta_stack_get_default_focus_window): don't choose a default focus window with unmaps pending, since we probably just unmapped it. * src/display.c (event_callback): move notify_focus on UnmapNotify after the window_free check, so we can move focus to another window when we unmanage * src/window.c (meta_window_hide): invalidate work areas when hiding a window with struts (meta_window_free): invalidate work areas when unmanaging a window with struts
2002-01-11 03:31:14 +00:00
gboolean did_hide;
Live previews for hidden windows. ClutterActors for hidden windows (such windows on different than active workspaces and windows that are minimized) are available, and reflect the actual state of the window. This is intended for use in task-switchers etc. This feature is disabled by default (due to increased demand on resources), and can be enabled through the metacity/general/live_hidden_windows gconf key. A trivial sample window switcher is included in the scratch plugin (activated by clicking on the slide out panel).
2008-10-24 09:07:24 +00:00
Throughout: move to meta_topic rather than meta_verbose so metacity.log 2002-02-07 Havoc Pennington <hp@pobox.com> Throughout: move to meta_topic rather than meta_verbose so metacity.log can start being more useful * src/util.h (enum): add more debug topics * src/frames.c: clean up some cruft that caused warnings
2002-02-08 03:34:26 +00:00
meta_topic (META_DEBUG_WINDOW_STATE,
"Hiding window %s\n", window->desc);
only bump unmaps_pending if the window was mapped 2002-01-10 Havoc Pennington <hp@pobox.com> * src/frame.c (meta_window_destroy_frame): only bump unmaps_pending if the window was mapped (meta_window_ensure_frame): ditto * src/keybindings.c: change arrow key bindings to use Ctrl+Alt not just Alt, and add debug mode key bindings * src/stack.c (meta_stack_get_default_focus_window): don't choose a default focus window with unmaps pending, since we probably just unmapped it. * src/display.c (event_callback): move notify_focus on UnmapNotify after the window_free check, so we can move focus to another window when we unmanage * src/window.c (meta_window_hide): invalidate work areas when hiding a window with struts (meta_window_free): invalidate work areas when unmanaging a window with struts
2002-01-11 03:31:14 +00:00
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
if (window->visible_to_compositor)
{
Assume the compositor always exists At one point, it was supported to run mutter without a compositor, but we don't allow that any longer. A lot of code already assumes display->compositor exists and doesn't check for a NULL pointer, so just kill the rest of the checks.
2014-03-18 21:06:42 +00:00
MetaCompEffect effect = META_COMP_EFFECT_NONE;
Update window->visible_to_compositor before calling into compositor To deal with reentrancy from compositor plugins doing things like moving windows between workspaces in an effect callback, update the visible_to_compositor flag before calling into the compositor. https://bugzilla.gnome.org/show_bug.cgi?id=613124
2011-01-04 16:43:02 +00:00
window->visible_to_compositor = FALSE;
Assume the compositor always exists At one point, it was supported to run mutter without a compositor, but we don't allow that any longer. A lot of code already assumes display->compositor exists and doesn't check for a NULL pointer, so just kill the rest of the checks.
2014-03-18 21:06:42 +00:00
switch (window->pending_compositor_effect)
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
{
Assume the compositor always exists At one point, it was supported to run mutter without a compositor, but we don't allow that any longer. A lot of code already assumes display->compositor exists and doesn't check for a NULL pointer, so just kill the rest of the checks.
2014-03-18 21:06:42 +00:00
case META_COMP_EFFECT_CREATE:
case META_COMP_EFFECT_UNMINIMIZE:
case META_COMP_EFFECT_NONE:
break;
case META_COMP_EFFECT_DESTROY:
case META_COMP_EFFECT_MINIMIZE:
effect = window->pending_compositor_effect;
break;
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
}
Assume the compositor always exists At one point, it was supported to run mutter without a compositor, but we don't allow that any longer. A lot of code already assumes display->compositor exists and doesn't check for a NULL pointer, so just kill the rest of the checks.
2014-03-18 21:06:42 +00:00
meta_compositor_hide_window (window->display->compositor, window, effect);
window: Don't reset pending_compositor_effect too early With our surface_mapped strategy, implement_showing might not change whether the window has been shown or not, and thus we might end up clearing pending_compositor_effect before the window is mapped. Only clear pending_compositor_effect when the effect has actually been used.
2014-04-28 20:58:45 +00:00
window->pending_compositor_effect = META_COMP_EFFECT_NONE;
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
}
only bump unmaps_pending if the window was mapped 2002-01-10 Havoc Pennington <hp@pobox.com> * src/frame.c (meta_window_destroy_frame): only bump unmaps_pending if the window was mapped (meta_window_ensure_frame): ditto * src/keybindings.c: change arrow key bindings to use Ctrl+Alt not just Alt, and add debug mode key bindings * src/stack.c (meta_stack_get_default_focus_window): don't choose a default focus window with unmaps pending, since we probably just unmapped it. * src/display.c (event_callback): move notify_focus on UnmapNotify after the window_free check, so we can move focus to another window when we unmanage * src/window.c (meta_window_hide): invalidate work areas when hiding a window with struts (meta_window_free): invalidate work areas when unmanaging a window with struts
2002-01-11 03:31:14 +00:00
did_hide = FALSE;
Live previews for hidden windows. ClutterActors for hidden windows (such windows on different than active workspaces and windows that are minimized) are available, and reflect the actual state of the window. This is intended for use in task-switchers etc. This feature is disabled by default (due to increased demand on resources), and can be enabled through the metacity/general/live_hidden_windows gconf key. A trivial sample window switcher is included in the scratch plugin (activated by clicking on the slide out panel).
2008-10-24 09:07:24 +00:00
prefs: Remove live-hidden-windows preference The preference existed, even though it was hard-coded to true. Just remove it for good. https://bugzilla.gnome.org/show_bug.cgi?id=671104
2012-03-01 03:15:12 +00:00
if (!window->hidden)
...
2001-06-10 03:17:15 +00:00
{
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_freeze (window->display->stack);
prefs: Remove live-hidden-windows preference The preference existed, even though it was hard-coded to true. Just remove it for good. https://bugzilla.gnome.org/show_bug.cgi?id=671104
2012-03-01 03:15:12 +00:00
window->hidden = TRUE;
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_thaw (window->display->stack);
prefs: Remove live-hidden-windows preference The preference existed, even though it was hard-coded to true. Just remove it for good. https://bugzilla.gnome.org/show_bug.cgi?id=671104
2012-03-01 03:15:12 +00:00
did_hide = TRUE;
...
2001-06-10 03:17:15 +00:00
}
...
2001-06-04 06:17:52 +00:00
...
2001-06-06 04:47:37 +00:00
if (!window->iconic)
{
window->iconic = TRUE;
window: Centralize WM_STATE management
2014-02-02 00:03:33 +00:00
set_wm_state (window);
...
2001-06-06 04:47:37 +00:00
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Always set _NET_WM_STATE when a window is shown or hidden, even if it 2006-03-03 Thomas Thurman <thomas@thurman.org.uk> Always set _NET_WM_STATE when a window is shown or hidden, even if it wasn't mapped. * src/window.c (meta_window_hide, meta_window_show): call set_net_wm_state unconditionally
2006-03-17 03:26:25 +00:00
set_net_wm_state (window);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Always set _NET_WM_STATE when a window is shown or hidden, even if it 2006-03-03 Thomas Thurman <thomas@thurman.org.uk> Always set _NET_WM_STATE when a window is shown or hidden, even if it wasn't mapped. * src/window.c (meta_window_hide, meta_window_show): call set_net_wm_state unconditionally
2006-03-17 03:26:25 +00:00
if (did_hide && window->struts)
{
meta_topic (META_DEBUG_WORKAREA,
"Unmapped window %s with struts, so invalidating work areas\n",
window->desc);
invalidate_work_areas (window);
only bump unmaps_pending if the window was mapped 2002-01-10 Havoc Pennington <hp@pobox.com> * src/frame.c (meta_window_destroy_frame): only bump unmaps_pending if the window was mapped (meta_window_ensure_frame): ditto * src/keybindings.c: change arrow key bindings to use Ctrl+Alt not just Alt, and add debug mode key bindings * src/stack.c (meta_stack_get_default_focus_window): don't choose a default focus window with unmaps pending, since we probably just unmapped it. * src/display.c (event_callback): move notify_focus on UnmapNotify after the window_free check, so we can move focus to another window when we unmanage * src/window.c (meta_window_hide): invalidate work areas when hiding a window with struts (meta_window_free): invalidate work areas when unmanaging a window with struts
2002-01-11 03:31:14 +00:00
}
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
display: clean up focus_window vs expected_focus_window Mutter previously defined display->focus_window as the window that the server says is focused, but kept display->expected_focus_window to indicate the window that we have requested to be focused. But it turns out that "expected_focus_window" was almost always what we wanted. Make MetaDisplay do a better job of tracking focus-related requests and events, and change display->focus_window to be our best guess of the "currently" focused window (ie, the window that will be focused at the time when the server processes the next request we send it). https://bugzilla.gnome.org/show_bug.cgi?id=647706
2011-04-26 12:12:04 +00:00
if (window->has_focus)
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
{
MetaWindow *not_this_one = NULL;
MetaWorkspace *my_workspace = meta_window_get_workspace (window);
guint32 timestamp = meta_display_get_current_time_roundtrip (window->display);
/*
* If this window is modal, passing the not_this_one window to
* _focus_default_window() makes the focus to be given to this window's
* ancestor. This can only be the case if the window is on the currently
* active workspace; when it is not, we need to pass in NULL, so as to
* focus the default window for the active workspace (this scenario
* arises when we are switching workspaces).
window: Avoid spurious focus-window changes when showing desktop When using the show-desktop shortcut with no desktop window, unshowing will focus the second-most-recently-used window. If we find a desktop window, it will be focused explicitly and everything works as expected; however without a desktop window, we end up hiding the focus window, which will use focus_default_window() with the not_this_one parameter to move focus away. We used to get away with this, as the not_this_one parameter was ignored until commit e257580b9484, now with bug 675982 fixed, we need to explicitly handle the show-desktop case. https://bugzilla.gnome.org/show_bug.cgi?id=686928
2012-10-26 12:39:21 +00:00
* We also pass in NULL if we are in the process of hiding all non-desktop
* windows to avoid unexpected changes to the stacking order.
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
*/
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
if (my_workspace == workspace_manager->active_workspace &&
window: Avoid spurious focus-window changes when showing desktop When using the show-desktop shortcut with no desktop window, unshowing will focus the second-most-recently-used window. If we find a desktop window, it will be focused explicitly and everything works as expected; however without a desktop window, we end up hiding the focus window, which will use focus_default_window() with the not_this_one parameter to move focus away. We used to get away with this, as the not_this_one parameter was ignored until commit e257580b9484, now with bug 675982 fixed, we need to explicitly handle the show-desktop case. https://bugzilla.gnome.org/show_bug.cgi?id=686928
2012-10-26 12:39:21 +00:00
!my_workspace->showing_desktop)
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
not_this_one = window;
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
meta_workspace_focus_default_window (workspace_manager->active_workspace,
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
not_this_one,
timestamp);
}
MetaScreen: Add tracking of whether there are fullscreen windows Trying to track the fullscreen status outside of Mutter, as GNOME Shell was doing previously, was very prone to errors, because Mutter has a very tricky definition of when a window is set to be fullscreen and *actually* acting like a fullscreen window. * Add meta_screen_get_monitor_in_fullscreen() and an ::in-fullscreen-changed signal. This allows an application to track when there are fullscreen windows on a monitor. * Do the computation of fullscreen status in a "later" function that runs after showing, so we properly take focus into account. * To get ordering of different phases right, add more values to MetaLaterType. * Add auto-minimization, similar to what was added to GNOME Shell earlier in this cycle - if a window is set to be fullscreen, but not actually fullscreen, minimize. https://bugzilla.gnome.org/show_bug.cgi?id=649748
2013-03-14 20:55:49 +00:00
if (did_hide)
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
meta_display_queue_check_fullscreen (window->display);
...
2001-06-04 06:17:52 +00:00
}
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
static gboolean
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
queue_calc_showing_func (MetaWindow *window,
void *data)
{
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
meta_window_queue(window, META_QUEUE_CALC_SHOWING);
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
return TRUE;
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
}
...
2001-06-04 06:17:52 +00:00
void
meta_window_minimize (MetaWindow *window)
{
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
...
2001-06-04 06:17:52 +00:00
if (!window->minimized)
{
window->minimized = TRUE;
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
window->pending_compositor_effect = META_COMP_EFFECT_MINIMIZE;
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
meta_window_queue(window, META_QUEUE_CALC_SHOWING);
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
meta_window_foreach_transient (window,
queue_calc_showing_func,
NULL);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
focus top window when switching to a new workspace 2002-01-03 Havoc Pennington <hp@pobox.com> * src/workspace.c (meta_workspace_activate): focus top window when switching to a new workspace * src/util.c (meta_topic): start putting verbose output in categories * src/window.c (meta_window_shade): focus frame after we queue the calc_showing so the maps/unmaps have already happened. * src/display.c (meta_display_get_current_time): add the "get time of current event" function and call it occasionally. * src/window.c (meta_window_free): if we have focus, call meta_screen_focus_top_window(). (meta_window_minimize): ditto (meta_window_delete): ditto * src/screen.c (meta_screen_ensure_tab_popup): fix memory leak - didn't free tab list (meta_screen_focus_top_window): new function to use when we unmap or unmanage a focused window * src/stack.c (meta_stack_get_default_focus_window): function used in meta_screen_focus_top_window
2002-01-03 23:28:19 +00:00
if (window->has_focus)
{
meta_topic (META_DEBUG_FOCUS,
Make choice of focus window be consistent for each focus mode. Fixes 2004-06-24 Elijah Newren <newren@math.utah.edu> Make choice of focus window be consistent for each focus mode. Fixes #135810. * src/delete.c: (meta_window_delete): In some #if 0'ed code, replace meta_workspace_focus_mru_window with meta_workspace_focus_default_window (just in case the code becomes un-#if 0'ed out). * src/screen.c, src/screen.h: Change meta_screen_focus_mouse_window to meta_screen_get_mouse_window, and don't focus the window when found but rather return it. * src/window.c: (meta_window_free, meta_window_minimize): replace meta_workspace_focus_mru_window with meta_workspace_focus_default_window. * src/workspace.c: (meta_workspace_focus_default_window): Focus appropriately for the given focus method: click-to-focus: focus MRU window (== toplevel window) sloppy focus: focus the window under the pointer if there is such a window, otherwise focus the mru window mouse focus: focus the window under the pointer if there is such a window, otherwise don't focus anything
2004-06-24 20:02:46 +00:00
"Focusing default window due to minimization of focus window %s\n",
focus top window when switching to a new workspace 2002-01-03 Havoc Pennington <hp@pobox.com> * src/workspace.c (meta_workspace_activate): focus top window when switching to a new workspace * src/util.c (meta_topic): start putting verbose output in categories * src/window.c (meta_window_shade): focus frame after we queue the calc_showing so the maps/unmaps have already happened. * src/display.c (meta_display_get_current_time): add the "get time of current event" function and call it occasionally. * src/window.c (meta_window_free): if we have focus, call meta_screen_focus_top_window(). (meta_window_minimize): ditto (meta_window_delete): ditto * src/screen.c (meta_screen_ensure_tab_popup): fix memory leak - didn't free tab list (meta_screen_focus_top_window): new function to use when we unmap or unmanage a focused window * src/stack.c (meta_stack_get_default_focus_window): function used in meta_screen_focus_top_window
2002-01-03 23:28:19 +00:00
window->desc);
}
else
{
meta_topic (META_DEBUG_FOCUS,
"Minimizing window %s which doesn't have the focus\n",
window->desc);
}
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_MINIMIZED]);
...
2001-06-04 06:17:52 +00:00
}
}
void
meta_window_unminimize (MetaWindow *window)
{
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
...
2001-06-04 06:17:52 +00:00
if (window->minimized)
{
window->minimized = FALSE;
Simplify relationship between mapping and visibility Previously, changes to the visibility of a window could be indicated by meta_compositor_map_window(), meta_compositor_unminimize_window(), meta_compositor_set_window_hidden(), etc, with the exact behavior depending on the 'live_hidden_windows' preference. Simplify this so that visibility is controlled by: meta_compositor_show_window() meta_compositor_hide_window() With an 'effect' parameter provided to indicate the appropriate effect (CREATE/UNMINIMIZE/MINIMIZE/DESTROY/NONE.) The map state of the window is signalled separately by: meta_compositor_map_window() meta_compositor_unmap_window() And is used only to control resource handling. Other changes: * The desired effect on show/hide is explicitly stored in MetaWindow, avoiding the need for the was_minimized flag. At idle, once we calculate the window state, we pass the effect to the compositor if it matches the new window state, and then clear the effect to start over for future map state changes. * meta_compositor_switch_workspace() is called before any windows are hidden or shown, allowing the compositor to avoid hiding or showing an effect for windows involved in the switch. http://bugzilla.gnome.org/show_bug.cgi?id=582341 * Handling of post-effect cleanups for MutterWindow are simplified - instead of trying to do different things based on the individual needs of different effects, we just wait until all effects complete and sync the window state to what it should be. * On unmap, once we destroy the pixmap, we tell ClutterX11Pixmap that we've done so, so it can clean up and unbind. (The unbinding doesn't seem to be working properly because of ClutterGLXPixmap or video driver issues.) http://bugzilla.gnome.org/show_bug.cgi?id=587251
2009-06-28 21:10:40 +00:00
window->pending_compositor_effect = META_COMP_EFFECT_UNMINIMIZE;
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
meta_window_queue(window, META_QUEUE_CALC_SHOWING);
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
meta_window_foreach_transient (window,
queue_calc_showing_func,
NULL);
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_MINIMIZED]);
...
2001-06-07 05:18:10 +00:00
}
}
Fix lots of little issues with min/max constraints and size increment 2004-04-04 Elijah Newren <newren gmail com> Fix lots of little issues with min/max constraints and size increment constraints. Fixes #329152, #418395, and possibly others. * src/window-props.c (meta_set_normal_hints): Do more checking to make sure application specified constraints are self-consistent, modifying the size_hints as necessary to achieve self-consistency. * src/constraints.c (setup_constraint_info): remove ugly copy-pasto, (constrain_size_increments): be careful that fixing violation of the constraints doesn't cause a violation of the minimum size constraints. * src/window.c (ensure_size_hints_satisfied): new function, (meta_window_unmaximize, meta_window_unmake_fullscreen): the saved_rect may no longer be valid (as in the case of #329152) so call ensure_size_hints_satisfied to fix it up. * doc/how-to-get-focus-right.txt: Some minor spacing and wording fixes completely unrelated to the rest of this commit svn path=/trunk/; revision=3155
2007-04-04 21:54:56 +00:00
static void
ensure_size_hints_satisfied (MetaRectangle *rect,
const XSizeHints *size_hints)
{
int minw, minh, maxw, maxh; /* min/max width/height */
int basew, baseh, winc, hinc; /* base width/height, width/height increment */
int extra_width, extra_height;
minw = size_hints->min_width; minh = size_hints->min_height;
maxw = size_hints->max_width; maxh = size_hints->max_height;
basew = size_hints->base_width; baseh = size_hints->base_height;
winc = size_hints->width_inc; hinc = size_hints->height_inc;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Fix lots of little issues with min/max constraints and size increment 2004-04-04 Elijah Newren <newren gmail com> Fix lots of little issues with min/max constraints and size increment constraints. Fixes #329152, #418395, and possibly others. * src/window-props.c (meta_set_normal_hints): Do more checking to make sure application specified constraints are self-consistent, modifying the size_hints as necessary to achieve self-consistency. * src/constraints.c (setup_constraint_info): remove ugly copy-pasto, (constrain_size_increments): be careful that fixing violation of the constraints doesn't cause a violation of the minimum size constraints. * src/window.c (ensure_size_hints_satisfied): new function, (meta_window_unmaximize, meta_window_unmake_fullscreen): the saved_rect may no longer be valid (as in the case of #329152) so call ensure_size_hints_satisfied to fix it up. * doc/how-to-get-focus-right.txt: Some minor spacing and wording fixes completely unrelated to the rest of this commit svn path=/trunk/; revision=3155
2007-04-04 21:54:56 +00:00
/* First, enforce min/max size constraints */
rect->width = CLAMP (rect->width, minw, maxw);
rect->height = CLAMP (rect->height, minh, maxh);
/* Now, verify size increment constraints are satisfied, or make them be */
extra_width = (rect->width - basew) % winc;
extra_height = (rect->height - baseh) % hinc;
rect->width -= extra_width;
rect->height -= extra_height;
/* Adjusting width/height down, as done above, may violate minimum size
* constraints, so one last fix.
*/
if (rect->width < minw)
rect->width += ((minw - rect->width)/winc + 1)*winc;
if (rect->height < minh)
rect->height += ((minh - rect->height)/hinc + 1)*hinc;
}
new function, only saves rect after checking current state, #93795 2002-09-24 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_save_rect): new function, only saves rect after checking current state, #93795 (meta_window_make_fullscreen): use new function (meta_window_maximize): use new function
2002-09-24 21:33:34 +00:00
static void
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
meta_window_save_rect (MetaWindow *window)
new function, only saves rect after checking current state, #93795 2002-09-24 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_save_rect): new function, only saves rect after checking current state, #93795 (meta_window_make_fullscreen): use new function (meta_window_maximize): use new function
2002-09-24 21:33:34 +00:00
{
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
if (!(META_WINDOW_MAXIMIZED (window) || META_WINDOW_TILED_SIDE_BY_SIDE (window) || window->fullscreen))
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
{
/* save size/pos as appropriate args for move_resize */
if (!window->maximized_horizontally)
{
window->saved_rect.x = window->rect.x;
window->saved_rect.width = window->rect.width;
}
if (!window->maximized_vertically)
{
window->saved_rect.y = window->rect.y;
window->saved_rect.height = window->rect.height;
}
}
new function, only saves rect after checking current state, #93795 2002-09-24 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_save_rect): new function, only saves rect after checking current state, #93795 (meta_window_make_fullscreen): use new function (meta_window_maximize): use new function
2002-09-24 21:33:34 +00:00
}
Revamp placement policy for windows that are maximized when they are 2003-06-09 Rob Adams <robadams@ucla.edu> Revamp placement policy for windows that are maximized when they are mapped, including windows that set a hint to be maximized or windows that are auto-maximized using our heuristic. See #111902. * src/window.h: add new flag maximize_after_placement and new function meta_window_maximize_internal. * src/window.c (meta_window_new): initialize maximize_after_placement to FALSE and remove the automaximize heuristic. (meta_window_maximize_internal): new function accepts a saved_rect argument to be used as the new saved_rect for the window, and does not queue a move_resize. (meta_window_maximize): re-implement using meta_window_maximize_internal. (update_net_wm_state): If a window has a maximize hint set on startup set maximize_after_placement to TRUE * src/constraints.c (meta_window_constrain): Update the xinerama information in the ConstraintInfo after placing the window, and maximize the window after placement if window->maximize_after_placement * src/place.c (find_first_fit): take a natural xinerama list as an argument instead of generating it here (constrain_placement): remove function, since it is no longer needed (meta_window_place): generate the natural xinerama list here and pass it into find_first_fit. If find_first_fit fails, use the list to find empty xineramas where we can place windows that may be maximized later. This makes maximized windows follow the correct placement policy. Move the automaximize heuristic here.
2003-06-09 23:49:02 +00:00
void
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
meta_window_maximize_internal (MetaWindow *window,
MetaMaximizeFlags directions,
MetaRectangle *saved_rect)
Revamp placement policy for windows that are maximized when they are 2003-06-09 Rob Adams <robadams@ucla.edu> Revamp placement policy for windows that are maximized when they are mapped, including windows that set a hint to be maximized or windows that are auto-maximized using our heuristic. See #111902. * src/window.h: add new flag maximize_after_placement and new function meta_window_maximize_internal. * src/window.c (meta_window_new): initialize maximize_after_placement to FALSE and remove the automaximize heuristic. (meta_window_maximize_internal): new function accepts a saved_rect argument to be used as the new saved_rect for the window, and does not queue a move_resize. (meta_window_maximize): re-implement using meta_window_maximize_internal. (update_net_wm_state): If a window has a maximize hint set on startup set maximize_after_placement to TRUE * src/constraints.c (meta_window_constrain): Update the xinerama information in the ConstraintInfo after placing the window, and maximize the window after placement if window->maximize_after_placement * src/place.c (find_first_fit): take a natural xinerama list as an argument instead of generating it here (constrain_placement): remove function, since it is no longer needed (meta_window_place): generate the natural xinerama list here and pass it into find_first_fit. If find_first_fit fails, use the list to find empty xineramas where we can place windows that may be maximized later. This makes maximized windows follow the correct placement policy. Move the automaximize heuristic here.
2003-06-09 23:49:02 +00:00
{
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
/* At least one of the two directions ought to be set */
gboolean maximize_horizontally, maximize_vertically;
maximize_horizontally = directions & META_MAXIMIZE_HORIZONTAL;
maximize_vertically = directions & META_MAXIMIZE_VERTICAL;
g_assert (maximize_horizontally || maximize_vertically);
Revamp placement policy for windows that are maximized when they are 2003-06-09 Rob Adams <robadams@ucla.edu> Revamp placement policy for windows that are maximized when they are mapped, including windows that set a hint to be maximized or windows that are auto-maximized using our heuristic. See #111902. * src/window.h: add new flag maximize_after_placement and new function meta_window_maximize_internal. * src/window.c (meta_window_new): initialize maximize_after_placement to FALSE and remove the automaximize heuristic. (meta_window_maximize_internal): new function accepts a saved_rect argument to be used as the new saved_rect for the window, and does not queue a move_resize. (meta_window_maximize): re-implement using meta_window_maximize_internal. (update_net_wm_state): If a window has a maximize hint set on startup set maximize_after_placement to TRUE * src/constraints.c (meta_window_constrain): Update the xinerama information in the ConstraintInfo after placing the window, and maximize the window after placement if window->maximize_after_placement * src/place.c (find_first_fit): take a natural xinerama list as an argument instead of generating it here (constrain_placement): remove function, since it is no longer needed (meta_window_place): generate the natural xinerama list here and pass it into find_first_fit. If find_first_fit fails, use the list to find empty xineramas where we can place windows that may be maximized later. This makes maximized windows follow the correct placement policy. Move the automaximize heuristic here.
2003-06-09 23:49:02 +00:00
meta_topic (META_DEBUG_WINDOW_OPS,
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
"Maximizing %s%s\n",
window->desc,
maximize_horizontally && maximize_vertically ? "" :
maximize_horizontally ? " horizontally" :
maximize_vertically ? " vertically" : "BUGGGGG");
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
if (saved_rect != NULL)
window->saved_rect = *saved_rect;
else
meta_window_save_rect (window);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
if (maximize_horizontally && maximize_vertically)
window->saved_maximize = TRUE;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window->maximized_horizontally =
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
window->maximized_horizontally || maximize_horizontally;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window->maximized_vertically =
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
window->maximized_vertically || maximize_vertically;
Make it so maximized windows do not have rounded corners. #336850.
2006-07-31 19:56:56 +00:00
window: Track edge constraints GTK has the ability to handle client-decorated windows in such a way that the behavior of these windows must match the behavior of the current window manager. In Mutter, windows can be tiled horizontally (and, in the future, vertically as well), which comes with a few requirements that the toolkit must supply. Tiled windows have their borders' behavior changed depending on the tiled position, and the toolkit must be aware of this information in order to properly match the window manager behavior. In order to provide toolkits with more precise and general data regarding resizable and constrained edges, this patch makes MetaWindow track its own edge constraints. This will later be used by the backends to send information to the toolkit. https://bugzilla.gnome.org/show_bug.cgi?id=751857
2017-08-17 03:43:21 +00:00
/* Update the edge constraints */
update_edge_constraints (window);;
window: Fix build The proper function name is "meta_window_recalc_features"
2014-02-01 23:58:58 +00:00
meta_window_recalc_features (window);
Revamp placement policy for windows that are maximized when they are 2003-06-09 Rob Adams <robadams@ucla.edu> Revamp placement policy for windows that are maximized when they are mapped, including windows that set a hint to be maximized or windows that are auto-maximized using our heuristic. See #111902. * src/window.h: add new flag maximize_after_placement and new function meta_window_maximize_internal. * src/window.c (meta_window_new): initialize maximize_after_placement to FALSE and remove the automaximize heuristic. (meta_window_maximize_internal): new function accepts a saved_rect argument to be used as the new saved_rect for the window, and does not queue a move_resize. (meta_window_maximize): re-implement using meta_window_maximize_internal. (update_net_wm_state): If a window has a maximize hint set on startup set maximize_after_placement to TRUE * src/constraints.c (meta_window_constrain): Update the xinerama information in the ConstraintInfo after placing the window, and maximize the window after placement if window->maximize_after_placement * src/place.c (find_first_fit): take a natural xinerama list as an argument instead of generating it here (constrain_placement): remove function, since it is no longer needed (meta_window_place): generate the natural xinerama list here and pass it into find_first_fit. If find_first_fit fails, use the list to find empty xineramas where we can place windows that may be maximized later. This makes maximized windows follow the correct placement policy. Move the automaximize heuristic here.
2003-06-09 23:49:02 +00:00
set_net_wm_state (window);
[MetaWindow] Expose maximized state as properties Add properties for the EWMH _NET_WM_STATE_MAXIMIZED_HORZ and _NET_WM_STATE_MAXIMIZED_VERT hints. https://bugzilla.gnome.org/show_bug.cgi?id=590706
2010-02-12 20:26:52 +00:00
window: Handle maximize when headless When for some reason a window is maximized while the compositor is headless, `window->monitor` will be NULL, so check for a NULL monitor to avoid a NULL-pointer dereference. Closes: https://gitlab.gnome.org/GNOME/mutter/issues/58 https://gitlab.gnome.org/GNOME/mutter/merge_requests/383
2019-01-09 10:52:18 +00:00
if (window->monitor && window->monitor->in_fullscreen)
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
meta_display_queue_check_fullscreen (window->display);
screen: Always consider monitors with fullscreen windows "in-fullscreen" Fullscreen windows look weird when they are overlapped by system chrome, which currently happens when another window is stacked above. We used to auto-minimize fullscreen windows in that case, which proved to be both unreliable and unpopular. So instead, keep the system chrome hidden even when the fullscreen window is not stacked at the top. https://bugzilla.gnome.org/show_bug.cgi?id=693991
2014-10-02 22:55:45 +00:00
[MetaWindow] Expose maximized state as properties Add properties for the EWMH _NET_WM_STATE_MAXIMIZED_HORZ and _NET_WM_STATE_MAXIMIZED_VERT hints. https://bugzilla.gnome.org/show_bug.cgi?id=590706
2010-02-12 20:26:52 +00:00
g_object_freeze_notify (G_OBJECT (window));
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_MAXIMIZED_HORIZONTALLY]);
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_MAXIMIZED_VERTICALLY]);
[MetaWindow] Expose maximized state as properties Add properties for the EWMH _NET_WM_STATE_MAXIMIZED_HORZ and _NET_WM_STATE_MAXIMIZED_VERT hints. https://bugzilla.gnome.org/show_bug.cgi?id=590706
2010-02-12 20:26:52 +00:00
g_object_thaw_notify (G_OBJECT (window));
Revamp placement policy for windows that are maximized when they are 2003-06-09 Rob Adams <robadams@ucla.edu> Revamp placement policy for windows that are maximized when they are mapped, including windows that set a hint to be maximized or windows that are auto-maximized using our heuristic. See #111902. * src/window.h: add new flag maximize_after_placement and new function meta_window_maximize_internal. * src/window.c (meta_window_new): initialize maximize_after_placement to FALSE and remove the automaximize heuristic. (meta_window_maximize_internal): new function accepts a saved_rect argument to be used as the new saved_rect for the window, and does not queue a move_resize. (meta_window_maximize): re-implement using meta_window_maximize_internal. (update_net_wm_state): If a window has a maximize hint set on startup set maximize_after_placement to TRUE * src/constraints.c (meta_window_constrain): Update the xinerama information in the ConstraintInfo after placing the window, and maximize the window after placement if window->maximize_after_placement * src/place.c (find_first_fit): take a natural xinerama list as an argument instead of generating it here (constrain_placement): remove function, since it is no longer needed (meta_window_place): generate the natural xinerama list here and pass it into find_first_fit. If find_first_fit fails, use the list to find empty xineramas where we can place windows that may be maximized later. This makes maximized windows follow the correct placement policy. Move the automaximize heuristic here.
2003-06-09 23:49:02 +00:00
}
...
2001-06-07 05:18:10 +00:00
void
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
meta_window_maximize (MetaWindow *window,
MetaMaximizeFlags directions)
...
2001-06-07 05:18:10 +00:00
{
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
MetaRectangle *saved_rect = NULL;
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
gboolean maximize_horizontally, maximize_vertically;
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
/* At least one of the two directions ought to be set */
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
maximize_horizontally = directions & META_MAXIMIZE_HORIZONTAL;
maximize_vertically = directions & META_MAXIMIZE_VERTICAL;
g_assert (maximize_horizontally || maximize_vertically);
/* Only do something if the window isn't already maximized in the
* given direction(s).
*/
if ((maximize_horizontally && !window->maximized_horizontally) ||
(maximize_vertically && !window->maximized_vertically))
...
2001-06-07 05:18:10 +00:00
{
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
if (window->shaded && maximize_vertically)
Partial audit to fix timestamp usage. One step towards fixing #355180; see 2006-09-18 Elijah Newren <newren gmail com> Partial audit to fix timestamp usage. One step towards fixing #355180; see important comments in that bug. * src/core.[ch] (meta_core_unshade, meta_core_shade): * src/delete.c (meta_window_present_delete_dialog, delete_ping_timeout_func): * src/display.[ch] (meta_display_open, meta_display_close, event_callback, meta_display_begin_grab_op, process_selection_clear, meta_display_unmanage_screen, meta_display_unmanage_windows_for_screen): * src/frames.c (meta_frames_button_press_event): * src/keybindings.c (handle_toggle_shade): * src/main.c (main): * src/screen.[ch] (update_num_workspaces, meta_screen_new, meta_screen_free, prefs_changed_callback): * src/window.[ch] (meta_window_free, finish_minimize, implement_showing, meta_window_show, meta_window_maximize, meta_window_make_fullscreen_internal, meta_window_unmake_fullscreen, meta_window_shade, meta_window_unshade, window_activate, send_sync_request, meta_window_client_message, menu_callback, meta_window_update_keyboard_resize): Remove usage of CurrentTime, meta_display_get_current_time() and meta_display_get_current_time_roundtrip() where possible, or document why it isn't possible, or at very least add a FIXME with some explanation of my laziness and what needs to be done.
2006-09-18 17:27:24 +00:00
{
/* Shading sucks anyway; I'm not adding a timestamp argument
* to this function just for this niche usage & corner case.
*/
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
guint32 timestamp =
Partial audit to fix timestamp usage. One step towards fixing #355180; see 2006-09-18 Elijah Newren <newren gmail com> Partial audit to fix timestamp usage. One step towards fixing #355180; see important comments in that bug. * src/core.[ch] (meta_core_unshade, meta_core_shade): * src/delete.c (meta_window_present_delete_dialog, delete_ping_timeout_func): * src/display.[ch] (meta_display_open, meta_display_close, event_callback, meta_display_begin_grab_op, process_selection_clear, meta_display_unmanage_screen, meta_display_unmanage_windows_for_screen): * src/frames.c (meta_frames_button_press_event): * src/keybindings.c (handle_toggle_shade): * src/main.c (main): * src/screen.[ch] (update_num_workspaces, meta_screen_new, meta_screen_free, prefs_changed_callback): * src/window.[ch] (meta_window_free, finish_minimize, implement_showing, meta_window_show, meta_window_maximize, meta_window_make_fullscreen_internal, meta_window_unmake_fullscreen, meta_window_shade, meta_window_unshade, window_activate, send_sync_request, meta_window_client_message, menu_callback, meta_window_update_keyboard_resize): Remove usage of CurrentTime, meta_display_get_current_time() and meta_display_get_current_time_roundtrip() where possible, or document why it isn't possible, or at very least add a FIXME with some explanation of my laziness and what needs to be done.
2006-09-18 17:27:24 +00:00
meta_display_get_current_time_roundtrip (window->display);
meta_window_unshade (window, timestamp);
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Revamp placement policy for windows that are maximized when they are 2003-06-09 Rob Adams <robadams@ucla.edu> Revamp placement policy for windows that are maximized when they are mapped, including windows that set a hint to be maximized or windows that are auto-maximized using our heuristic. See #111902. * src/window.h: add new flag maximize_after_placement and new function meta_window_maximize_internal. * src/window.c (meta_window_new): initialize maximize_after_placement to FALSE and remove the automaximize heuristic. (meta_window_maximize_internal): new function accepts a saved_rect argument to be used as the new saved_rect for the window, and does not queue a move_resize. (meta_window_maximize): re-implement using meta_window_maximize_internal. (update_net_wm_state): If a window has a maximize hint set on startup set maximize_after_placement to TRUE * src/constraints.c (meta_window_constrain): Update the xinerama information in the ConstraintInfo after placing the window, and maximize the window after placement if window->maximize_after_placement * src/place.c (find_first_fit): take a natural xinerama list as an argument instead of generating it here (constrain_placement): remove function, since it is no longer needed (meta_window_place): generate the natural xinerama list here and pass it into find_first_fit. If find_first_fit fails, use the list to find empty xineramas where we can place windows that may be maximized later. This makes maximized windows follow the correct placement policy. Move the automaximize heuristic here.
2003-06-09 23:49:02 +00:00
/* if the window hasn't been placed yet, we'll maximize it then
*/
if (!window->placed)
{
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window->maximize_horizontally_after_placement =
window->maximize_horizontally_after_placement ||
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
maximize_horizontally;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window->maximize_vertically_after_placement =
window->maximize_vertically_after_placement ||
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
maximize_vertically;
Revamp placement policy for windows that are maximized when they are 2003-06-09 Rob Adams <robadams@ucla.edu> Revamp placement policy for windows that are maximized when they are mapped, including windows that set a hint to be maximized or windows that are auto-maximized using our heuristic. See #111902. * src/window.h: add new flag maximize_after_placement and new function meta_window_maximize_internal. * src/window.c (meta_window_new): initialize maximize_after_placement to FALSE and remove the automaximize heuristic. (meta_window_maximize_internal): new function accepts a saved_rect argument to be used as the new saved_rect for the window, and does not queue a move_resize. (meta_window_maximize): re-implement using meta_window_maximize_internal. (update_net_wm_state): If a window has a maximize hint set on startup set maximize_after_placement to TRUE * src/constraints.c (meta_window_constrain): Update the xinerama information in the ConstraintInfo after placing the window, and maximize the window after placement if window->maximize_after_placement * src/place.c (find_first_fit): take a natural xinerama list as an argument instead of generating it here (constrain_placement): remove function, since it is no longer needed (meta_window_place): generate the natural xinerama list here and pass it into find_first_fit. If find_first_fit fails, use the list to find empty xineramas where we can place windows that may be maximized later. This makes maximized windows follow the correct placement policy. Move the automaximize heuristic here.
2003-06-09 23:49:02 +00:00
return;
}
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
if (window->tile_mode != META_TILE_NONE)
{
saved_rect = &window->saved_rect;
window->maximized_vertically = FALSE;
window->tile_mode = META_TILE_NONE;
}
meta_window_maximize_internal (window,
directions,
saved_rect);
take a window mapped at fullscreen size/pos to desire maximization; once I 2001-10-14 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_new): take a window mapped at fullscreen size/pos to desire maximization; once I add a fullscreen state, will change to copy kwin and take this mapping as a desire for fullscreen, but for now testing with maximization. * src/window.h: remove fullscreen window type, now proposing it as a window state instead. 2001-10-14 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_maximize): always raise windows on maximize (meta_window_client_message): when activating a window, move it to current workspace, instead of moving user to the window's workspace.
2001-10-14 22:13:53 +00:00
window: Inform the compositor when a window effectively changes size In order for the compositor plugin to be able to animate window size changes properly we need to let it know of the starting and final window sizes. For X clients this can be done synchronously and thus with a single call into the compositor plugin since it's us (the window manager) who's in charge of the final window size. Wayland clients though, have the final say over their window size since it's determined from the client allocated buffer. This patch moves the meta_compositor_size_change_window() calls before move_resize_internal() which lets the compositor plugin know the old window size and freezes the MetaWindowActor. Then we get rid of the META_MOVE_RESIZE_DONT_SYNC_COMPOSITOR flag since it's not needed anymore as the window actor is frozen and that means we can use meta_compositor_sync_window_geometry() as the point where we inform the compositor plugin of the final window size. https://bugzilla.gnome.org/show_bug.cgi?id=770345
2016-09-26 14:30:54 +00:00
MetaRectangle old_frame_rect, old_buffer_rect;
Implement a generic "size change" mechanism A much less hacky version of maximize / unmaximize is reimplemented in terms of this, but it could also eventually be used for fullscreen / unfullscreen, and tile / untile.
2015-07-06 04:08:08 +00:00
meta_window_get_frame_rect (window, &old_frame_rect);
meta_window_get_buffer_rect (window, &old_buffer_rect);
Adds support in src/core for tracking override redirect windows. The metacity core is now directly aware of override redirect windows. - They get MetaWindows like normal windows, so mutter no longer need to special case them. The net wm types applicable to override redirects are also recognised. - The original positioning/stacking semantics of metacity with respect to OR windows are maintained, but now it's easier to synchronize the stacking between the core and mutter. - mutter no longer needs to manualy track UnmapNotify, MapNotify, ReparentNotify, CreateNotify and DestroyNotify events; instead map, unmap, add and remove events can now be consistently delivered via the MetaCompositor callbacks.
2008-11-23 19:28:40 +00:00
window: Inform the compositor when a window effectively changes size In order for the compositor plugin to be able to animate window size changes properly we need to let it know of the starting and final window sizes. For X clients this can be done synchronously and thus with a single call into the compositor plugin since it's us (the window manager) who's in charge of the final window size. Wayland clients though, have the final say over their window size since it's determined from the client allocated buffer. This patch moves the meta_compositor_size_change_window() calls before move_resize_internal() which lets the compositor plugin know the old window size and freezes the MetaWindowActor. Then we get rid of the META_MOVE_RESIZE_DONT_SYNC_COMPOSITOR flag since it's not needed anymore as the window actor is frozen and that means we can use meta_compositor_sync_window_geometry() as the point where we inform the compositor plugin of the final window size. https://bugzilla.gnome.org/show_bug.cgi?id=770345
2016-09-26 14:30:54 +00:00
meta_compositor_size_change_window (window->display->compositor, window,
META_SIZE_CHANGE_MAXIMIZE,
&old_frame_rect, &old_buffer_rect);
window: Force state changes on maximized / fullscreen
2014-12-15 21:44:22 +00:00
meta_window_move_resize_internal (window,
Implement a generic "size change" mechanism A much less hacky version of maximize / unmaximize is reimplemented in terms of this, but it could also eventually be used for fullscreen / unfullscreen, and tile / untile.
2015-07-06 04:08:08 +00:00
(META_MOVE_RESIZE_MOVE_ACTION |
META_MOVE_RESIZE_RESIZE_ACTION |
window: Inform the compositor when a window effectively changes size In order for the compositor plugin to be able to animate window size changes properly we need to let it know of the starting and final window sizes. For X clients this can be done synchronously and thus with a single call into the compositor plugin since it's us (the window manager) who's in charge of the final window size. Wayland clients though, have the final say over their window size since it's determined from the client allocated buffer. This patch moves the meta_compositor_size_change_window() calls before move_resize_internal() which lets the compositor plugin know the old window size and freezes the MetaWindowActor. Then we get rid of the META_MOVE_RESIZE_DONT_SYNC_COMPOSITOR flag since it's not needed anymore as the window actor is frozen and that means we can use meta_compositor_sync_window_geometry() as the point where we inform the compositor plugin of the final window size. https://bugzilla.gnome.org/show_bug.cgi?id=770345
2016-09-26 14:30:54 +00:00
META_MOVE_RESIZE_STATE_CHANGED),
window: Force state changes on maximized / fullscreen
2014-12-15 21:44:22 +00:00
NorthWestGravity,
window->unconstrained_rect);
...
2001-06-07 05:18:10 +00:00
}
}
Add meta_window_get_maximized() and meta_window_is_fullscreen() These functions duplicate existing properties; they are added for convenience and to avoid the GObject property code on some performance critical painting paths. https://bugzilla.gnome.org/show_bug.cgi?id=592382
2010-11-11 23:42:44 +00:00
/**
* meta_window_get_maximized:
Fix gobs of gtk-doc warnings https://bugzilla.gnome.org/show_bug.cgi?id=676856
2013-02-15 18:42:08 +00:00
* @window: a #MetaWindow
Add meta_window_get_maximized() and meta_window_is_fullscreen() These functions duplicate existing properties; they are added for convenience and to avoid the GObject property code on some performance critical painting paths. https://bugzilla.gnome.org/show_bug.cgi?id=592382
2010-11-11 23:42:44 +00:00
*
* Gets the current maximization state of the window, as combination
* of the %META_MAXIMIZE_HORIZONTAL and %META_MAXIMIZE_VERTICAL flags;
*
* Return value: current maximization state
*/
MetaMaximizeFlags
meta_window_get_maximized (MetaWindow *window)
{
return ((window->maximized_horizontally ? META_MAXIMIZE_HORIZONTAL : 0) |
(window->maximized_vertically ? META_MAXIMIZE_VERTICAL : 0));
}
/**
* meta_window_is_fullscreen:
Fix gobs of gtk-doc warnings https://bugzilla.gnome.org/show_bug.cgi?id=676856
2013-02-15 18:42:08 +00:00
* @window: a #MetaWindow
Add meta_window_get_maximized() and meta_window_is_fullscreen() These functions duplicate existing properties; they are added for convenience and to avoid the GObject property code on some performance critical painting paths. https://bugzilla.gnome.org/show_bug.cgi?id=592382
2010-11-11 23:42:44 +00:00
*
* Return value: %TRUE if the window is currently fullscreen
*/
gboolean
meta_window_is_fullscreen (MetaWindow *window)
{
return window->fullscreen;
}
window: Add is_screen_sized method Add a method that returns whether the window occupies the whole screen (i.e all montiors).
2013-02-18 12:30:37 +00:00
/**
* meta_window_is_screen_sized:
Fix gobs of gtk-doc warnings https://bugzilla.gnome.org/show_bug.cgi?id=676856
2013-02-15 18:42:08 +00:00
* @window: A #MetaWindow
window: Add is_screen_sized method Add a method that returns whether the window occupies the whole screen (i.e all montiors).
2013-02-18 12:30:37 +00:00
*
* Return value: %TRUE if the window is occupies the
* the whole screen (all monitors).
*/
gboolean
meta_window_is_screen_sized (MetaWindow *window)
{
MetaRectangle window_rect;
int screen_width, screen_height;
Move screen size and cursor setting to MetaDisplay Split X11 specific parts into MetaX11Display. This also required changing MetaScreen to stop listening to any signals by itself, but instead relying on MetaDisplay forwarding them. This was to ensure the ordering. MetaDisplay listens to both the internal and external monitors-changed signal so that it can pass the external one via the redundant MetaDisplay(prev MetaScreen)::monitors-changed. https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 16:37:29 +00:00
meta_display_get_size (window->display, &screen_width, &screen_height);
Rename meta_window_get_outer_rect() to meta_window_get_frame_rect() For clarity, rename meta_window_get_outer_rect() to match terminology we use elsewhere. The old function is left as a deprecated compatibility wrapper.
2013-11-19 17:24:45 +00:00
meta_window_get_frame_rect (window, &window_rect);
window: Add is_screen_sized method Add a method that returns whether the window occupies the whole screen (i.e all montiors).
2013-02-18 12:30:37 +00:00
if (window_rect.x == 0 && window_rect.y == 0 &&
window_rect.width == screen_width && window_rect.height == screen_height)
return TRUE;
return FALSE;
}
window: Add meta_window_is_monitor_sized We duplicate this checks in multiple places so lets add this to avoid code duplication.
2013-02-17 20:12:45 +00:00
/**
* meta_window_is_monitor_sized:
docs: Fix cross-reference generation https://bugzilla.gnome.org/show_bug.cgi?id=676856
2013-02-18 13:19:28 +00:00
* @window: a #MetaWindow
window: Add meta_window_is_monitor_sized We duplicate this checks in multiple places so lets add this to avoid code duplication.
2013-02-17 20:12:45 +00:00
*
* Return value: %TRUE if the window is occupies an entire monitor or
* the whole screen.
*/
gboolean
meta_window_is_monitor_sized (MetaWindow *window)
{
window: Treat being headless as not monitor sized When we are headless, treat this as if the window is always not monitor sized. This might cause windows to temporarly become redirected while being headless, but this is harmless as when a new monitor is connected, we'll recalculate weather it should be redirected or not. https://bugzilla.gnome.org/show_bug.cgi?id=787637
2017-09-25 18:09:31 +00:00
if (!window->monitor)
return FALSE;
window: Add meta_window_is_monitor_sized We duplicate this checks in multiple places so lets add this to avoid code duplication.
2013-02-17 20:12:45 +00:00
if (window->fullscreen)
return TRUE;
window: Add is_screen_sized method Add a method that returns whether the window occupies the whole screen (i.e all montiors).
2013-02-18 12:30:37 +00:00
if (meta_window_is_screen_sized (window))
return TRUE;
window: Add meta_window_is_monitor_sized We duplicate this checks in multiple places so lets add this to avoid code duplication.
2013-02-17 20:12:45 +00:00
if (window->override_redirect)
{
MetaRectangle window_rect, monitor_rect;
Rename meta_window_get_outer_rect() to meta_window_get_frame_rect() For clarity, rename meta_window_get_outer_rect() to match terminology we use elsewhere. The old function is left as a deprecated compatibility wrapper.
2013-11-19 17:24:45 +00:00
meta_window_get_frame_rect (window, &window_rect);
Move monitor management API to MetaDisplay This includes changing various users to use MetaDisplay directly, who used MetaScreen only for this before. https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:22:34 +00:00
meta_display_get_monitor_geometry (window->display, window->monitor->number, &monitor_rect);
window: Add meta_window_is_monitor_sized We duplicate this checks in multiple places so lets add this to avoid code duplication.
2013-02-17 20:12:45 +00:00
if (meta_rectangle_equal (&window_rect, &monitor_rect))
return TRUE;
}
return FALSE;
}
Add meta_window_is_on_primary_monitor function This is useful in a couple of places to avoid opencoding it. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-03-09 12:04:18 +00:00
/**
* meta_window_is_on_primary_monitor:
Fix gobs of gtk-doc warnings https://bugzilla.gnome.org/show_bug.cgi?id=676856
2013-02-15 18:42:08 +00:00
* @window: a #MetaWindow
Add meta_window_is_on_primary_monitor function This is useful in a couple of places to avoid opencoding it. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-03-09 12:04:18 +00:00
*
* Return value: %TRUE if the window is on the primary monitor
*/
gboolean
meta_window_is_on_primary_monitor (MetaWindow *window)
{
window: Make should_be_on_all_workspaces() handle being headless Also adds a soft assert to meta_window_is_on_primary_monitor() to make it easier to spot when callers might want to handle headless in a certain way. https://bugzilla.gnome.org/show_bug.cgi?id=730551
2017-09-25 19:10:58 +00:00
g_return_val_if_fail (window->monitor, FALSE);
When monitors change, keep windows on same output. If XRANDR is availible, we track the first (or primary) output per crtc (== xinerama monitor) so when the monitors change we can try to find the same output and move windows there. If we can't find the original monitor in the new set (or XRANDR is not supported) we move the window to the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=645408
2011-05-20 08:56:12 +00:00
return window->monitor->is_primary;
Add meta_window_is_on_primary_monitor function This is useful in a couple of places to avoid opencoding it. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-03-09 12:04:18 +00:00
}
Support bypass compositor hints Add support for _NET_WM_BYPASS_COMPOSITOR and _NET_WM_DONT_BYPASS_COMPOSITOR as proposed here: https://mail.gnome.org/archives/wm-spec-list/2012-February/msg00010.html https://bugzilla.gnome.org/show_bug.cgi?id=683020
2012-08-30 06:40:18 +00:00
/**
* meta_window_requested_bypass_compositor:
Fix gobs of gtk-doc warnings https://bugzilla.gnome.org/show_bug.cgi?id=676856
2013-02-15 18:42:08 +00:00
* @window: a #MetaWindow
Support bypass compositor hints Add support for _NET_WM_BYPASS_COMPOSITOR and _NET_WM_DONT_BYPASS_COMPOSITOR as proposed here: https://mail.gnome.org/archives/wm-spec-list/2012-February/msg00010.html https://bugzilla.gnome.org/show_bug.cgi?id=683020
2012-08-30 06:40:18 +00:00
*
* Return value: %TRUE if the window requested to bypass the compositor
*/
gboolean
meta_window_requested_bypass_compositor (MetaWindow *window)
{
meta-window-actor: Change unredirection hints to match spec changes Change the bypass / dont_bypass compositor code to match the latest spec. https://bugzilla.gnome.org/show_bug.cgi?id=693064
2013-02-02 19:05:43 +00:00
return window->bypass_compositor == _NET_WM_BYPASS_COMPOSITOR_HINT_ON;
Support bypass compositor hints Add support for _NET_WM_BYPASS_COMPOSITOR and _NET_WM_DONT_BYPASS_COMPOSITOR as proposed here: https://mail.gnome.org/archives/wm-spec-list/2012-February/msg00010.html https://bugzilla.gnome.org/show_bug.cgi?id=683020
2012-08-30 06:40:18 +00:00
}
/**
* meta_window_requested_dont_bypass_compositor:
Fix gobs of gtk-doc warnings https://bugzilla.gnome.org/show_bug.cgi?id=676856
2013-02-15 18:42:08 +00:00
* @window: a #MetaWindow
Support bypass compositor hints Add support for _NET_WM_BYPASS_COMPOSITOR and _NET_WM_DONT_BYPASS_COMPOSITOR as proposed here: https://mail.gnome.org/archives/wm-spec-list/2012-February/msg00010.html https://bugzilla.gnome.org/show_bug.cgi?id=683020
2012-08-30 06:40:18 +00:00
*
* Return value: %TRUE if the window requested to opt out of unredirecting
*/
gboolean
meta_window_requested_dont_bypass_compositor (MetaWindow *window)
{
meta-window-actor: Change unredirection hints to match spec changes Change the bypass / dont_bypass compositor code to match the latest spec. https://bugzilla.gnome.org/show_bug.cgi?id=693064
2013-02-02 19:05:43 +00:00
return window->bypass_compositor == _NET_WM_BYPASS_COMPOSITOR_HINT_OFF;
Support bypass compositor hints Add support for _NET_WM_BYPASS_COMPOSITOR and _NET_WM_DONT_BYPASS_COMPOSITOR as proposed here: https://mail.gnome.org/archives/wm-spec-list/2012-February/msg00010.html https://bugzilla.gnome.org/show_bug.cgi?id=683020
2012-08-30 06:40:18 +00:00
}
window: Allow resizing of tiled windows Currently tiled windows are not resizable and their size is fixed to half the screen width. Adjust the code to work with fractions other than half, and allow users to adjust the split by dragging the window edge that is not constrained by a monitor edge. Follow-up patches will improve on that by resizing neighboring tiled windows by a shared edge, and making the functionality available to client-side decorated windows implementing the new edge constraints protocol.
2017-09-27 12:37:57 +00:00
static void
meta_window_get_tile_fraction (MetaWindow *window,
MetaTileMode tile_mode,
double *fraction)
{
window: Tile and resize considering the tile match After the introduction of the possibility to resize tiled windows, it is a sensible decision to make windows aware of their tiling match. A tiling match is another window that is tiled in such a way that is the complement of the current window. The newly introduced behavior attepts to make tiling as smooth as possible, with the following rules: * Windows now compute their tile match when tiling and, if there's a match, they automatically complement the sibling's width. * Resizing a window with a sibling automatically resizes the sibling too to be the complement of the window's width. * It is not possible to resize below windows' minimum widths. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-12 01:13:03 +00:00
MetaWindow *tile_match;
/* Make sure the tile match is up-to-date and matches the
* passed in mode rather than the current state
*/
tile_match = meta_window_find_tile_match (window, tile_mode);
window: Allow resizing of tiled windows Currently tiled windows are not resizable and their size is fixed to half the screen width. Adjust the code to work with fractions other than half, and allow users to adjust the split by dragging the window edge that is not constrained by a monitor edge. Follow-up patches will improve on that by resizing neighboring tiled windows by a shared edge, and making the functionality available to client-side decorated windows implementing the new edge constraints protocol.
2017-09-27 12:37:57 +00:00
if (tile_mode == META_TILE_NONE)
*fraction = -1.;
else if (tile_mode == META_TILE_MAXIMIZED)
*fraction = 1.;
window: Tile and resize considering the tile match After the introduction of the possibility to resize tiled windows, it is a sensible decision to make windows aware of their tiling match. A tiling match is another window that is tiled in such a way that is the complement of the current window. The newly introduced behavior attepts to make tiling as smooth as possible, with the following rules: * Windows now compute their tile match when tiling and, if there's a match, they automatically complement the sibling's width. * Resizing a window with a sibling automatically resizes the sibling too to be the complement of the window's width. * It is not possible to resize below windows' minimum widths. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-12 01:13:03 +00:00
else if (tile_match)
*fraction = 1. - tile_match->tile_hfraction;
window: Allow resizing of tiled windows Currently tiled windows are not resizable and their size is fixed to half the screen width. Adjust the code to work with fractions other than half, and allow users to adjust the split by dragging the window edge that is not constrained by a monitor edge. Follow-up patches will improve on that by resizing neighboring tiled windows by a shared edge, and making the functionality available to client-side decorated windows implementing the new edge constraints protocol.
2017-09-27 12:37:57 +00:00
else if (META_WINDOW_TILED_SIDE_BY_SIDE (window))
{
if (window->tile_mode != tile_mode)
*fraction = 1. - window->tile_hfraction;
else
*fraction = window->tile_hfraction;
}
else
*fraction = .5;
}
static void
meta_window_update_tile_fraction (MetaWindow *window,
int new_w,
int new_h)
{
window: Tile and resize considering the tile match After the introduction of the possibility to resize tiled windows, it is a sensible decision to make windows aware of their tiling match. A tiling match is another window that is tiled in such a way that is the complement of the current window. The newly introduced behavior attepts to make tiling as smooth as possible, with the following rules: * Windows now compute their tile match when tiling and, if there's a match, they automatically complement the sibling's width. * Resizing a window with a sibling automatically resizes the sibling too to be the complement of the window's width. * It is not possible to resize below windows' minimum widths. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-12 01:13:03 +00:00
MetaWindow *tile_match = window->tile_match;
window: Allow resizing of tiled windows Currently tiled windows are not resizable and their size is fixed to half the screen width. Adjust the code to work with fractions other than half, and allow users to adjust the split by dragging the window edge that is not constrained by a monitor edge. Follow-up patches will improve on that by resizing neighboring tiled windows by a shared edge, and making the functionality available to client-side decorated windows implementing the new edge constraints protocol.
2017-09-27 12:37:57 +00:00
MetaRectangle work_area;
if (!META_WINDOW_TILED_SIDE_BY_SIDE (window))
return;
meta_window_get_work_area_for_monitor (window,
window->tile_monitor_number,
&work_area);
window->tile_hfraction = (double)new_w / work_area.width;
window: Tile and resize considering the tile match After the introduction of the possibility to resize tiled windows, it is a sensible decision to make windows aware of their tiling match. A tiling match is another window that is tiled in such a way that is the complement of the current window. The newly introduced behavior attepts to make tiling as smooth as possible, with the following rules: * Windows now compute their tile match when tiling and, if there's a match, they automatically complement the sibling's width. * Resizing a window with a sibling automatically resizes the sibling too to be the complement of the window's width. * It is not possible to resize below windows' minimum widths. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-12 01:13:03 +00:00
if (tile_match && window->display->grab_window == window)
meta_window_tile (tile_match, tile_match->tile_mode);
window: Allow resizing of tiled windows Currently tiled windows are not resizable and their size is fixed to half the screen width. Adjust the code to work with fractions other than half, and allow users to adjust the split by dragging the window edge that is not constrained by a monitor edge. Follow-up patches will improve on that by resizing neighboring tiled windows by a shared edge, and making the functionality available to client-side decorated windows implementing the new edge constraints protocol.
2017-09-27 12:37:57 +00:00
}
window: Track edge constraints GTK has the ability to handle client-decorated windows in such a way that the behavior of these windows must match the behavior of the current window manager. In Mutter, windows can be tiled horizontally (and, in the future, vertically as well), which comes with a few requirements that the toolkit must supply. Tiled windows have their borders' behavior changed depending on the tiled position, and the toolkit must be aware of this information in order to properly match the window manager behavior. In order to provide toolkits with more precise and general data regarding resizable and constrained edges, this patch makes MetaWindow track its own edge constraints. This will later be used by the backends to send information to the toolkit. https://bugzilla.gnome.org/show_bug.cgi?id=751857
2017-08-17 03:43:21 +00:00
static void
update_edge_constraints (MetaWindow *window)
{
switch (window->tile_mode)
{
case META_TILE_NONE:
window: Make edge constraint code more readable It relied on indices in arrays determining tile direction and non-obvious bitmask logic to translate to _GTK_EDGE_CONSTRAINTS. Change this to explicitly named edge constraints, and clear translation methods that converts between mutters and GTK+s edge constraint formats.
2018-10-24 12:24:22 +00:00
window->edge_constraints.top = META_EDGE_CONSTRAINT_NONE;
window->edge_constraints.right = META_EDGE_CONSTRAINT_NONE;
window->edge_constraints.bottom = META_EDGE_CONSTRAINT_NONE;
window->edge_constraints.left = META_EDGE_CONSTRAINT_NONE;
window: Track edge constraints GTK has the ability to handle client-decorated windows in such a way that the behavior of these windows must match the behavior of the current window manager. In Mutter, windows can be tiled horizontally (and, in the future, vertically as well), which comes with a few requirements that the toolkit must supply. Tiled windows have their borders' behavior changed depending on the tiled position, and the toolkit must be aware of this information in order to properly match the window manager behavior. In order to provide toolkits with more precise and general data regarding resizable and constrained edges, this patch makes MetaWindow track its own edge constraints. This will later be used by the backends to send information to the toolkit. https://bugzilla.gnome.org/show_bug.cgi?id=751857
2017-08-17 03:43:21 +00:00
break;
case META_TILE_MAXIMIZED:
window: Make edge constraint code more readable It relied on indices in arrays determining tile direction and non-obvious bitmask logic to translate to _GTK_EDGE_CONSTRAINTS. Change this to explicitly named edge constraints, and clear translation methods that converts between mutters and GTK+s edge constraint formats.
2018-10-24 12:24:22 +00:00
window->edge_constraints.top = META_EDGE_CONSTRAINT_MONITOR;
window->edge_constraints.right = META_EDGE_CONSTRAINT_MONITOR;
window->edge_constraints.bottom = META_EDGE_CONSTRAINT_MONITOR;
window->edge_constraints.left = META_EDGE_CONSTRAINT_MONITOR;
window: Track edge constraints GTK has the ability to handle client-decorated windows in such a way that the behavior of these windows must match the behavior of the current window manager. In Mutter, windows can be tiled horizontally (and, in the future, vertically as well), which comes with a few requirements that the toolkit must supply. Tiled windows have their borders' behavior changed depending on the tiled position, and the toolkit must be aware of this information in order to properly match the window manager behavior. In order to provide toolkits with more precise and general data regarding resizable and constrained edges, this patch makes MetaWindow track its own edge constraints. This will later be used by the backends to send information to the toolkit. https://bugzilla.gnome.org/show_bug.cgi?id=751857
2017-08-17 03:43:21 +00:00
break;
case META_TILE_LEFT:
window: Make edge constraint code more readable It relied on indices in arrays determining tile direction and non-obvious bitmask logic to translate to _GTK_EDGE_CONSTRAINTS. Change this to explicitly named edge constraints, and clear translation methods that converts between mutters and GTK+s edge constraint formats.
2018-10-24 12:24:22 +00:00
window->edge_constraints.top = META_EDGE_CONSTRAINT_MONITOR;
window: Track edge constraints GTK has the ability to handle client-decorated windows in such a way that the behavior of these windows must match the behavior of the current window manager. In Mutter, windows can be tiled horizontally (and, in the future, vertically as well), which comes with a few requirements that the toolkit must supply. Tiled windows have their borders' behavior changed depending on the tiled position, and the toolkit must be aware of this information in order to properly match the window manager behavior. In order to provide toolkits with more precise and general data regarding resizable and constrained edges, this patch makes MetaWindow track its own edge constraints. This will later be used by the backends to send information to the toolkit. https://bugzilla.gnome.org/show_bug.cgi?id=751857
2017-08-17 03:43:21 +00:00
if (window->tile_match)
window: Make edge constraint code more readable It relied on indices in arrays determining tile direction and non-obvious bitmask logic to translate to _GTK_EDGE_CONSTRAINTS. Change this to explicitly named edge constraints, and clear translation methods that converts between mutters and GTK+s edge constraint formats.
2018-10-24 12:24:22 +00:00
window->edge_constraints.right = META_EDGE_CONSTRAINT_WINDOW;
window: Track edge constraints GTK has the ability to handle client-decorated windows in such a way that the behavior of these windows must match the behavior of the current window manager. In Mutter, windows can be tiled horizontally (and, in the future, vertically as well), which comes with a few requirements that the toolkit must supply. Tiled windows have their borders' behavior changed depending on the tiled position, and the toolkit must be aware of this information in order to properly match the window manager behavior. In order to provide toolkits with more precise and general data regarding resizable and constrained edges, this patch makes MetaWindow track its own edge constraints. This will later be used by the backends to send information to the toolkit. https://bugzilla.gnome.org/show_bug.cgi?id=751857
2017-08-17 03:43:21 +00:00
else
window: Make edge constraint code more readable It relied on indices in arrays determining tile direction and non-obvious bitmask logic to translate to _GTK_EDGE_CONSTRAINTS. Change this to explicitly named edge constraints, and clear translation methods that converts between mutters and GTK+s edge constraint formats.
2018-10-24 12:24:22 +00:00
window->edge_constraints.right = META_EDGE_CONSTRAINT_NONE;
window: Track edge constraints GTK has the ability to handle client-decorated windows in such a way that the behavior of these windows must match the behavior of the current window manager. In Mutter, windows can be tiled horizontally (and, in the future, vertically as well), which comes with a few requirements that the toolkit must supply. Tiled windows have their borders' behavior changed depending on the tiled position, and the toolkit must be aware of this information in order to properly match the window manager behavior. In order to provide toolkits with more precise and general data regarding resizable and constrained edges, this patch makes MetaWindow track its own edge constraints. This will later be used by the backends to send information to the toolkit. https://bugzilla.gnome.org/show_bug.cgi?id=751857
2017-08-17 03:43:21 +00:00
window: Make edge constraint code more readable It relied on indices in arrays determining tile direction and non-obvious bitmask logic to translate to _GTK_EDGE_CONSTRAINTS. Change this to explicitly named edge constraints, and clear translation methods that converts between mutters and GTK+s edge constraint formats.
2018-10-24 12:24:22 +00:00
window->edge_constraints.bottom = META_EDGE_CONSTRAINT_MONITOR;
window->edge_constraints.left = META_EDGE_CONSTRAINT_MONITOR;
window: Track edge constraints GTK has the ability to handle client-decorated windows in such a way that the behavior of these windows must match the behavior of the current window manager. In Mutter, windows can be tiled horizontally (and, in the future, vertically as well), which comes with a few requirements that the toolkit must supply. Tiled windows have their borders' behavior changed depending on the tiled position, and the toolkit must be aware of this information in order to properly match the window manager behavior. In order to provide toolkits with more precise and general data regarding resizable and constrained edges, this patch makes MetaWindow track its own edge constraints. This will later be used by the backends to send information to the toolkit. https://bugzilla.gnome.org/show_bug.cgi?id=751857
2017-08-17 03:43:21 +00:00
break;
case META_TILE_RIGHT:
window: Make edge constraint code more readable It relied on indices in arrays determining tile direction and non-obvious bitmask logic to translate to _GTK_EDGE_CONSTRAINTS. Change this to explicitly named edge constraints, and clear translation methods that converts between mutters and GTK+s edge constraint formats.
2018-10-24 12:24:22 +00:00
window->edge_constraints.top = META_EDGE_CONSTRAINT_MONITOR;
window->edge_constraints.right = META_EDGE_CONSTRAINT_MONITOR;
window->edge_constraints.bottom = META_EDGE_CONSTRAINT_MONITOR;
window: Track edge constraints GTK has the ability to handle client-decorated windows in such a way that the behavior of these windows must match the behavior of the current window manager. In Mutter, windows can be tiled horizontally (and, in the future, vertically as well), which comes with a few requirements that the toolkit must supply. Tiled windows have their borders' behavior changed depending on the tiled position, and the toolkit must be aware of this information in order to properly match the window manager behavior. In order to provide toolkits with more precise and general data regarding resizable and constrained edges, this patch makes MetaWindow track its own edge constraints. This will later be used by the backends to send information to the toolkit. https://bugzilla.gnome.org/show_bug.cgi?id=751857
2017-08-17 03:43:21 +00:00
if (window->tile_match)
window: Make edge constraint code more readable It relied on indices in arrays determining tile direction and non-obvious bitmask logic to translate to _GTK_EDGE_CONSTRAINTS. Change this to explicitly named edge constraints, and clear translation methods that converts between mutters and GTK+s edge constraint formats.
2018-10-24 12:24:22 +00:00
window->edge_constraints.left = META_EDGE_CONSTRAINT_WINDOW;
window: Track edge constraints GTK has the ability to handle client-decorated windows in such a way that the behavior of these windows must match the behavior of the current window manager. In Mutter, windows can be tiled horizontally (and, in the future, vertically as well), which comes with a few requirements that the toolkit must supply. Tiled windows have their borders' behavior changed depending on the tiled position, and the toolkit must be aware of this information in order to properly match the window manager behavior. In order to provide toolkits with more precise and general data regarding resizable and constrained edges, this patch makes MetaWindow track its own edge constraints. This will later be used by the backends to send information to the toolkit. https://bugzilla.gnome.org/show_bug.cgi?id=751857
2017-08-17 03:43:21 +00:00
else
window: Make edge constraint code more readable It relied on indices in arrays determining tile direction and non-obvious bitmask logic to translate to _GTK_EDGE_CONSTRAINTS. Change this to explicitly named edge constraints, and clear translation methods that converts between mutters and GTK+s edge constraint formats.
2018-10-24 12:24:22 +00:00
window->edge_constraints.left = META_EDGE_CONSTRAINT_NONE;
window: Track edge constraints GTK has the ability to handle client-decorated windows in such a way that the behavior of these windows must match the behavior of the current window manager. In Mutter, windows can be tiled horizontally (and, in the future, vertically as well), which comes with a few requirements that the toolkit must supply. Tiled windows have their borders' behavior changed depending on the tiled position, and the toolkit must be aware of this information in order to properly match the window manager behavior. In order to provide toolkits with more precise and general data regarding resizable and constrained edges, this patch makes MetaWindow track its own edge constraints. This will later be used by the backends to send information to the toolkit. https://bugzilla.gnome.org/show_bug.cgi?id=751857
2017-08-17 03:43:21 +00:00
break;
}
/* h/vmaximize also modify the edge constraints */
if (window->maximized_vertically)
{
window: Make edge constraint code more readable It relied on indices in arrays determining tile direction and non-obvious bitmask logic to translate to _GTK_EDGE_CONSTRAINTS. Change this to explicitly named edge constraints, and clear translation methods that converts between mutters and GTK+s edge constraint formats.
2018-10-24 12:24:22 +00:00
window->edge_constraints.top = META_EDGE_CONSTRAINT_MONITOR;
window->edge_constraints.bottom = META_EDGE_CONSTRAINT_MONITOR;
window: Track edge constraints GTK has the ability to handle client-decorated windows in such a way that the behavior of these windows must match the behavior of the current window manager. In Mutter, windows can be tiled horizontally (and, in the future, vertically as well), which comes with a few requirements that the toolkit must supply. Tiled windows have their borders' behavior changed depending on the tiled position, and the toolkit must be aware of this information in order to properly match the window manager behavior. In order to provide toolkits with more precise and general data regarding resizable and constrained edges, this patch makes MetaWindow track its own edge constraints. This will later be used by the backends to send information to the toolkit. https://bugzilla.gnome.org/show_bug.cgi?id=751857
2017-08-17 03:43:21 +00:00
}
if (window->maximized_horizontally)
{
window: Make edge constraint code more readable It relied on indices in arrays determining tile direction and non-obvious bitmask logic to translate to _GTK_EDGE_CONSTRAINTS. Change this to explicitly named edge constraints, and clear translation methods that converts between mutters and GTK+s edge constraint formats.
2018-10-24 12:24:22 +00:00
window->edge_constraints.right = META_EDGE_CONSTRAINT_MONITOR;
window->edge_constraints.left = META_EDGE_CONSTRAINT_MONITOR;
window: Track edge constraints GTK has the ability to handle client-decorated windows in such a way that the behavior of these windows must match the behavior of the current window manager. In Mutter, windows can be tiled horizontally (and, in the future, vertically as well), which comes with a few requirements that the toolkit must supply. Tiled windows have their borders' behavior changed depending on the tiled position, and the toolkit must be aware of this information in order to properly match the window manager behavior. In order to provide toolkits with more precise and general data regarding resizable and constrained edges, this patch makes MetaWindow track its own edge constraints. This will later be used by the backends to send information to the toolkit. https://bugzilla.gnome.org/show_bug.cgi?id=751857
2017-08-17 03:43:21 +00:00
}
}
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
void
window: Pass mode as parameter to tile() operation Now that the preview tile mode has been split from the window's tile_mode property, it is much more natural to pass the requested tile_mode to the tile() function instead of setting it externally and calling the function to apply the state.
2017-09-27 13:11:54 +00:00
meta_window_tile (MetaWindow *window,
MetaTileMode tile_mode)
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
{
MetaMaximizeFlags directions;
window: Notify about size-change when tiling Call meta_compositor_size_change_window while tiling in order to emit the size-change signal. Since the untiling action is considered a unmaximize size change, treat tiling as a maximize size change for consistency. https://bugzilla.gnome.org/show_bug.cgi?id=782968
2016-09-24 19:47:35 +00:00
MetaRectangle old_frame_rect, old_buffer_rect;
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
window: Allow resizing of tiled windows Currently tiled windows are not resizable and their size is fixed to half the screen width. Adjust the code to work with fractions other than half, and allow users to adjust the split by dragging the window edge that is not constrained by a monitor edge. Follow-up patches will improve on that by resizing neighboring tiled windows by a shared edge, and making the functionality available to client-side decorated windows implementing the new edge constraints protocol.
2017-09-27 12:37:57 +00:00
meta_window_get_tile_fraction (window, tile_mode, &window->tile_hfraction);
window: Pass mode as parameter to tile() operation Now that the preview tile mode has been split from the window's tile_mode property, it is much more natural to pass the requested tile_mode to the tile() function instead of setting it externally and calling the function to apply the state.
2017-09-27 13:11:54 +00:00
window->tile_mode = tile_mode;
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
/* Don't do anything if no tiling is requested */
if (window->tile_mode == META_TILE_NONE)
window: Reset tile monitor number when untiling Otherwise we'll end up trying to access the out of date state later. Fixes the following test failure backtrace: #0 _g_log_abort () #1 g_logv () #2 g_log () #3 meta_monitor_manager_get_logical_monitor_from_number () #4 meta_window_get_work_area_for_monitor () #5 meta_window_get_tile_area () #6 constrain_maximization () #7 do_all_constraints () #8 meta_window_constrain () #9 meta_window_move_resize_internal () #10 meta_window_tile () https://gitlab.gnome.org/GNOME/mutter/merge_requests/912
2019-11-01 12:40:04 +00:00
{
window->tile_monitor_number = -1;
return;
}
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
if (window->tile_mode == META_TILE_MAXIMIZED)
directions = META_MAXIMIZE_BOTH;
else
directions = META_MAXIMIZE_VERTICAL;
meta_window_maximize_internal (window, directions, NULL);
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
meta_display_update_tile_preview (window->display, FALSE);
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
window: Track edge constraints GTK has the ability to handle client-decorated windows in such a way that the behavior of these windows must match the behavior of the current window manager. In Mutter, windows can be tiled horizontally (and, in the future, vertically as well), which comes with a few requirements that the toolkit must supply. Tiled windows have their borders' behavior changed depending on the tiled position, and the toolkit must be aware of this information in order to properly match the window manager behavior. In order to provide toolkits with more precise and general data regarding resizable and constrained edges, this patch makes MetaWindow track its own edge constraints. This will later be used by the backends to send information to the toolkit. https://bugzilla.gnome.org/show_bug.cgi?id=751857
2017-08-17 03:43:21 +00:00
/* Setup the edge constraints */
update_edge_constraints (window);
window: Notify about size-change when tiling Call meta_compositor_size_change_window while tiling in order to emit the size-change signal. Since the untiling action is considered a unmaximize size change, treat tiling as a maximize size change for consistency. https://bugzilla.gnome.org/show_bug.cgi?id=782968
2016-09-24 19:47:35 +00:00
meta_window_get_frame_rect (window, &old_frame_rect);
meta_window_get_buffer_rect (window, &old_buffer_rect);
meta_compositor_size_change_window (window->display->compositor, window,
META_SIZE_CHANGE_MAXIMIZE,
&old_frame_rect, &old_buffer_rect);
window: Include STATE_CHANGED flag when tiling For size change animations, plugins rely on the size change effect being followed by size changed signal (or effects being kill altogether). However unless the move_resize operation included the STATE_CHANGED flag, the size changed event emitted when the compositor syncs the window geometry only happens when the operation resulted in an actual change. To avoid animations getting stuck in that case, make sure to include the flag when tiling a window. https://bugzilla.gnome.org/show_bug.cgi?id=783293
2017-06-03 13:48:20 +00:00
meta_window_move_resize_internal (window,
(META_MOVE_RESIZE_MOVE_ACTION |
META_MOVE_RESIZE_RESIZE_ACTION |
META_MOVE_RESIZE_STATE_CHANGED),
NorthWestGravity,
window->unconstrained_rect);
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
if (window->frame)
meta_frame_queue_draw (window->frame);
}
window: Add tile mode getter Lets avoid peeking in the MetaWindow struct itself and add a getter for the relevant state. https://gitlab.gnome.org/GNOME/mutter/merge_requests/621
2019-06-13 13:49:26 +00:00
MetaTileMode
meta_window_get_tile_mode (MetaWindow *window)
{
return window->tile_mode;
}
window: Allow resizing of tiled windows Currently tiled windows are not resizable and their size is fixed to half the screen width. Adjust the code to work with fractions other than half, and allow users to adjust the split by dragging the window edge that is not constrained by a monitor edge. Follow-up patches will improve on that by resizing neighboring tiled windows by a shared edge, and making the functionality available to client-side decorated windows implementing the new edge constraints protocol.
2017-09-27 12:37:57 +00:00
void
meta_window_restore_tile (MetaWindow *window,
MetaTileMode mode,
int width,
int height)
{
meta_window_update_tile_fraction (window, width, height);
meta_window_tile (window, mode);
}
Revert "window: Add new tiling code" This reverts commit 50e3e3b929f181bc64549a05ab2abf4258a9673e.
2016-01-10 14:16:08 +00:00
static gboolean
meta_window_can_tile_maximized (MetaWindow *window)
window: don't allow side-by-side tiling of non-maximizable windows If a window is not maximizable, then that probably means it looks dumb at very large sizes. Even if its hints would allow you to manually resize it to a large size, don't allow automatically tiling it to half the screen. https://bugzilla.gnome.org/show_bug.cgi?id=647901
2011-04-18 16:27:03 +00:00
{
Revert "window: Add new tiling code" This reverts commit 50e3e3b929f181bc64549a05ab2abf4258a9673e.
2016-01-10 14:16:08 +00:00
return window->has_maximize_func;
}
window: don't allow side-by-side tiling of non-maximizable windows If a window is not maximizable, then that probably means it looks dumb at very large sizes. Even if its hints would allow you to manually resize it to a large size, don't allow automatically tiling it to half the screen. https://bugzilla.gnome.org/show_bug.cgi?id=647901
2011-04-18 16:27:03 +00:00
Revert "window: Add new tiling code" This reverts commit 50e3e3b929f181bc64549a05ab2abf4258a9673e.
2016-01-10 14:16:08 +00:00
gboolean
meta_window_can_tile_side_by_side (MetaWindow *window)
{
int monitor;
MetaRectangle tile_area;
MetaRectangle client_rect;
Implement side-by-side tiling When dragging a window over a screen edge and dropping it there, maximize it vertically and scale it horizontally to cover the corresponding half of the current monitor. Whenever a "hot area" which triggers this behavior is entered, an indication of window's target size is displayed after a short delay to avoid distraction when moving a window between monitors. https://bugzilla.gnome.org/show_bug.cgi?id=606260
2010-06-24 18:41:28 +00:00
Revert "window: Add new tiling code" This reverts commit 50e3e3b929f181bc64549a05ab2abf4258a9673e.
2016-01-10 14:16:08 +00:00
if (!meta_window_can_tile_maximized (window))
return FALSE;
Implement side-by-side tiling When dragging a window over a screen edge and dropping it there, maximize it vertically and scale it horizontally to cover the corresponding half of the current monitor. Whenever a "hot area" which triggers this behavior is entered, an indication of window's target size is displayed after a short delay to avoid distraction when moving a window between monitors. https://bugzilla.gnome.org/show_bug.cgi?id=606260
2010-06-24 18:41:28 +00:00
Move monitor management API to MetaDisplay This includes changing various users to use MetaDisplay directly, who used MetaScreen only for this before. https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:22:34 +00:00
monitor = meta_display_get_current_monitor (window->display);
Revert "window: Add new tiling code" This reverts commit 50e3e3b929f181bc64549a05ab2abf4258a9673e.
2016-01-10 14:16:08 +00:00
meta_window_get_work_area_for_monitor (window, monitor, &tile_area);
/* Do not allow tiling in portrait orientation */
if (tile_area.height > tile_area.width)
return FALSE;
tile_area.width /= 2;
meta_window_frame_rect_to_client_rect (window, &tile_area, &client_rect);
Implement side-by-side tiling When dragging a window over a screen edge and dropping it there, maximize it vertically and scale it horizontally to cover the corresponding half of the current monitor. Whenever a "hot area" which triggers this behavior is entered, an indication of window's target size is displayed after a short delay to avoid distraction when moving a window between monitors. https://bugzilla.gnome.org/show_bug.cgi?id=606260
2010-06-24 18:41:28 +00:00
Revert "window: Add new tiling code" This reverts commit 50e3e3b929f181bc64549a05ab2abf4258a9673e.
2016-01-10 14:16:08 +00:00
return client_rect.width >= window->size_hints.min_width &&
client_rect.height >= window->size_hints.min_height;
Implement side-by-side tiling When dragging a window over a screen edge and dropping it there, maximize it vertically and scale it horizontally to cover the corresponding half of the current monitor. Whenever a "hot area" which triggers this behavior is entered, an indication of window's target size is displayed after a short delay to avoid distraction when moving a window between monitors. https://bugzilla.gnome.org/show_bug.cgi?id=606260
2010-06-24 18:41:28 +00:00
}
Avoid flashing when closing a maximized window. Fixes #317254. 2006-01-20 Elijah Newren <newren gmail com> Avoid flashing when closing a maximized window. Fixes #317254. * src/window.c (unmaximize_window_before_freeing): new function that just fixes the net_wm_state and sends a configure_notify, (meta_window_free): use unmaximize_window_before_freeing() instead of meta_window_unmaximize() to avoid flicker
2006-01-20 23:36:23 +00:00
static void
unmaximize_window_before_freeing (MetaWindow *window)
{
meta_topic (META_DEBUG_WINDOW_OPS,
"Unmaximizing %s just before freeing\n",
window->desc);
window->maximized_horizontally = FALSE;
window->maximized_vertically = FALSE;
Patch from Carlo Wood to ensure that maximized and minimized properties 2006-10-01 Elijah Newren <newren gmail com> Patch from Carlo Wood to ensure that maximized and minimized properties are maintained across restarts. #358042. * src/constraints.c (place_window_if_needed): fix up partial maximization handling and add minimize_after_placement handling. * src/display.[ch] (struct MetaDisplay, meta_display_open): add a new display->display_opening flag to allow handling startup differently where needed. * src/window-props.c (reload_net_wm_state): handle _net_wm_state_hidden as well, setting window->minimize_after_placement appropriately * src/window.[ch] (struct MetaWindow, meta_window_new_with_attrs): add a window->minimize_after_placement field * src/window.c (meta_window_new_with_attrs): only unminimize the window and its transients if the display isn't being opened, (unmaximize_window_before_freeing): don't reset the state unless the window is becoming withdrawn, if the screen is being closed be sure to save the unmaximized state of the window so the next window manager can restore it
2006-10-01 21:59:09 +00:00
if (window->withdrawn) /* See bug #137185 */
{
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
window->rect = window->saved_rect;
Patch from Carlo Wood to ensure that maximized and minimized properties 2006-10-01 Elijah Newren <newren gmail com> Patch from Carlo Wood to ensure that maximized and minimized properties are maintained across restarts. #358042. * src/constraints.c (place_window_if_needed): fix up partial maximization handling and add minimize_after_placement handling. * src/display.[ch] (struct MetaDisplay, meta_display_open): add a new display->display_opening flag to allow handling startup differently where needed. * src/window-props.c (reload_net_wm_state): handle _net_wm_state_hidden as well, setting window->minimize_after_placement appropriately * src/window.[ch] (struct MetaWindow, meta_window_new_with_attrs): add a window->minimize_after_placement field * src/window.c (meta_window_new_with_attrs): only unminimize the window and its transients if the display isn't being opened, (unmaximize_window_before_freeing): don't reset the state unless the window is becoming withdrawn, if the screen is being closed be sure to save the unmaximized state of the window so the next window manager can restore it
2006-10-01 21:59:09 +00:00
set_net_wm_state (window);
}
window/wayland: Don't try to resize window on tear down When terminating mutter running as a display server, don't try to resize maximized windows when unmanaging, as at this point, they will have no MetaWaylandSurface. Originally this was done instead of setting the net_wm_state to not mess with future window managers, but when we're a Wayland compositor, this does not matter. https://bugzilla.gnome.org/show_bug.cgi?id=782156
2017-04-21 09:40:25 +00:00
#ifdef HAVE_WAYLAND
Stop using MetaScreen where it is unnecessary https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:43:17 +00:00
else if (!meta_is_wayland_compositor ())
Patch from Carlo Wood to ensure that maximized and minimized properties 2006-10-01 Elijah Newren <newren gmail com> Patch from Carlo Wood to ensure that maximized and minimized properties are maintained across restarts. #358042. * src/constraints.c (place_window_if_needed): fix up partial maximization handling and add minimize_after_placement handling. * src/display.[ch] (struct MetaDisplay, meta_display_open): add a new display->display_opening flag to allow handling startup differently where needed. * src/window-props.c (reload_net_wm_state): handle _net_wm_state_hidden as well, setting window->minimize_after_placement appropriately * src/window.[ch] (struct MetaWindow, meta_window_new_with_attrs): add a window->minimize_after_placement field * src/window.c (meta_window_new_with_attrs): only unminimize the window and its transients if the display isn't being opened, (unmaximize_window_before_freeing): don't reset the state unless the window is becoming withdrawn, if the screen is being closed be sure to save the unmaximized state of the window so the next window manager can restore it
2006-10-01 21:59:09 +00:00
{
/* Do NOT update net_wm_state: this screen is closing,
* it likely will be managed by another window manager
* that will need the current _NET_WM_STATE atoms.
* Moreover, it will need to know the unmaximized geometry,
* therefore move_resize the window to saved_rect here
* before closing it. */
window: Refactor all move/resize operations to be in frame rect space For Wayland, we want to have everything possible in terms of the frame rect, or "window geometry" as the Wayland protocol calls it, in order to properly eliminate some flashing when changing states to fullscreen or similar. For this, we need to heavily refactor how the code is structured, and make it so that meta_window_move_resize_internal is specified in terms of the frame rect coordinate space, and transforming all entry points to meta_window_move_resize_internal. This is a big commit that's hard to tear apart. I tried to split it as best I can, but there's still just a large amount of changes that need to happen at once. Expect some regressions from this. Sorry for any temporary regression that this might cause.
2014-05-20 21:47:10 +00:00
meta_window_move_resize_frame (window,
FALSE,
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
window->saved_rect.x,
window->saved_rect.y,
window->saved_rect.width,
window->saved_rect.height);
Patch from Carlo Wood to ensure that maximized and minimized properties 2006-10-01 Elijah Newren <newren gmail com> Patch from Carlo Wood to ensure that maximized and minimized properties are maintained across restarts. #358042. * src/constraints.c (place_window_if_needed): fix up partial maximization handling and add minimize_after_placement handling. * src/display.[ch] (struct MetaDisplay, meta_display_open): add a new display->display_opening flag to allow handling startup differently where needed. * src/window-props.c (reload_net_wm_state): handle _net_wm_state_hidden as well, setting window->minimize_after_placement appropriately * src/window.[ch] (struct MetaWindow, meta_window_new_with_attrs): add a window->minimize_after_placement field * src/window.c (meta_window_new_with_attrs): only unminimize the window and its transients if the display isn't being opened, (unmaximize_window_before_freeing): don't reset the state unless the window is becoming withdrawn, if the screen is being closed be sure to save the unmaximized state of the window so the next window manager can restore it
2006-10-01 21:59:09 +00:00
}
Stop using MetaScreen where it is unnecessary https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:43:17 +00:00
#endif
Avoid flashing when closing a maximized window. Fixes #317254. 2006-01-20 Elijah Newren <newren gmail com> Avoid flashing when closing a maximized window. Fixes #317254. * src/window.c (unmaximize_window_before_freeing): new function that just fixes the net_wm_state and sends a configure_notify, (meta_window_free): use unmaximize_window_before_freeing() instead of meta_window_unmaximize() to avoid flicker
2006-01-20 23:36:23 +00:00
}
Remove the ability to grab resize unmaximize This is an extremely niche feature, and conflicts with the rest of our interface being consistent about not allowing resizing while tiled or maximized.
2015-07-01 05:46:31 +00:00
void
meta_window_unmaximize (MetaWindow *window,
MetaMaximizeFlags directions)
...
2001-06-07 05:18:10 +00:00
{
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
gboolean unmaximize_horizontally, unmaximize_vertically;
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
/* At least one of the two directions ought to be set */
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
unmaximize_horizontally = directions & META_MAXIMIZE_HORIZONTAL;
unmaximize_vertically = directions & META_MAXIMIZE_VERTICAL;
g_assert (unmaximize_horizontally || unmaximize_vertically);
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
if (unmaximize_horizontally && unmaximize_vertically)
window->saved_maximize = FALSE;
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
/* Only do something if the window isn't already maximized in the
* given direction(s).
*/
if ((unmaximize_horizontally && window->maximized_horizontally) ||
(unmaximize_vertically && window->maximized_vertically))
Add "size states" which save window size information https://bugzilla.gnome.org/show_bug.cgi?id=751857
2015-07-01 05:36:23 +00:00
{
Remove the ability to grab resize unmaximize This is an extremely niche feature, and conflicts with the rest of our interface being consistent about not allowing resizing while tiled or maximized.
2015-07-01 05:46:31 +00:00
MetaRectangle *desired_rect;
Only use saved_rect for determining the position to unmaximize to for the 2007-04-03 Elijah Newren <newren gmail com> * src/window.c (meta_window_unmaximize): Only use saved_rect for determining the position to unmaximize to for the previously-maximized direction(s). Fixes #355497. svn path=/trunk/; revision=3154
2007-04-04 03:07:26 +00:00
MetaRectangle target_rect;
Don't unmaximize to nearly maximized size Basically we don't really want to create windows that are almost maximized in size but not actually maximized. This creates work for the user and makes it very difficult to use and resize manually. So set the newly unmaximized window size to the previously used size or 80% of the size of the current workarea (attempting to retain natural aspect ratio if possible), whichever is smaller. https://bugzilla.gnome.org/show_bug.cgi?id=671677
2012-03-12 16:09:17 +00:00
MetaRectangle work_area;
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
MetaRectangle old_frame_rect, old_buffer_rect;
Don't unmaximize to nearly maximized size Basically we don't really want to create windows that are almost maximized in size but not actually maximized. This creates work for the user and makes it very difficult to use and resize manually. So set the newly unmaximized window size to the previously used size or 80% of the size of the current workarea (attempting to retain natural aspect ratio if possible), whichever is smaller. https://bugzilla.gnome.org/show_bug.cgi?id=671677
2012-03-12 16:09:17 +00:00
meta_window_get_work_area_for_monitor (window, window->monitor->number, &work_area);
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
meta_window_get_frame_rect (window, &old_frame_rect);
meta_window_get_buffer_rect (window, &old_buffer_rect);
window: Split out preview_tile_mode The existing semantics of the tile_mode property are terribly confusing, as it depends on some other property whether it represents the requested or current mode. Clear this up by just using separate variables for the two. As it is unlikely that we will ever support more than one tile preview, we can track the requested mode globally instead of adding another per-window variable. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-09-27 12:53:54 +00:00
if (unmaximize_vertically)
window->tile_mode = META_TILE_NONE;
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
meta_topic (META_DEBUG_WINDOW_OPS,
"Unmaximizing %s%s\n",
window->desc,
unmaximize_horizontally && unmaximize_vertically ? "" :
unmaximize_horizontally ? " horizontally" :
unmaximize_vertically ? " vertically" : "BUGGGGG");
window->maximized_horizontally =
window->maximized_horizontally && !unmaximize_horizontally;
window->maximized_vertically =
window->maximized_vertically && !unmaximize_vertically;
window: Track edge constraints GTK has the ability to handle client-decorated windows in such a way that the behavior of these windows must match the behavior of the current window manager. In Mutter, windows can be tiled horizontally (and, in the future, vertically as well), which comes with a few requirements that the toolkit must supply. Tiled windows have their borders' behavior changed depending on the tiled position, and the toolkit must be aware of this information in order to properly match the window manager behavior. In order to provide toolkits with more precise and general data regarding resizable and constrained edges, this patch makes MetaWindow track its own edge constraints. This will later be used by the backends to send information to the toolkit. https://bugzilla.gnome.org/show_bug.cgi?id=751857
2017-08-17 03:43:21 +00:00
/* Update the edge constraints */
update_edge_constraints (window);
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
/* recalc_features() will eventually clear the cached frame
* extents, but we need the correct frame extents in the code below,
* so invalidate the old frame extents manually up front.
*/
meta_window_frame_size_changed (window);
Use the correct frame size during unmaximize When unmaximizing, we changed bits of window state, then called out to code that used the frame extents *before* we cleared old cached extents. Clear the cache up-front as soon as we change the window state. https://bugzilla.gnome.org/show_bug.cgi?id=714707
2013-12-05 13:27:28 +00:00
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
desired_rect = &window->saved_rect;
Remove the ability to grab resize unmaximize This is an extremely niche feature, and conflicts with the rest of our interface being consistent about not allowing resizing while tiled or maximized.
2015-07-01 05:46:31 +00:00
Only use saved_rect for determining the position to unmaximize to for the 2007-04-03 Elijah Newren <newren gmail com> * src/window.c (meta_window_unmaximize): Only use saved_rect for determining the position to unmaximize to for the previously-maximized direction(s). Fixes #355497. svn path=/trunk/; revision=3154
2007-04-04 03:07:26 +00:00
/* Unmaximize to the saved_rect position in the direction(s)
* being unmaximized.
*/
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
target_rect = old_frame_rect;
Don't unmaximize to nearly maximized size Basically we don't really want to create windows that are almost maximized in size but not actually maximized. This creates work for the user and makes it very difficult to use and resize manually. So set the newly unmaximized window size to the previously used size or 80% of the size of the current workarea (attempting to retain natural aspect ratio if possible), whichever is smaller. https://bugzilla.gnome.org/show_bug.cgi?id=671677
2012-03-12 16:09:17 +00:00
/* Avoid unmaximizing to "almost maximized" size when the previous size
* is greater then 80% of the work area use MAX_UNMAXIMIZED_WINDOW_AREA of the work area as upper limit
* while maintaining the aspect ratio.
*/
if (unmaximize_horizontally && unmaximize_vertically &&
desired_rect->width * desired_rect->height > work_area.width * work_area.height * MAX_UNMAXIMIZED_WINDOW_AREA)
{
if (desired_rect->width > desired_rect->height)
{
float aspect = (float)desired_rect->height / (float)desired_rect->width;
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
desired_rect->width = MAX (work_area.width * sqrt (MAX_UNMAXIMIZED_WINDOW_AREA), window->size_hints.min_width);
desired_rect->height = MAX (desired_rect->width * aspect, window->size_hints.min_height);
Don't unmaximize to nearly maximized size Basically we don't really want to create windows that are almost maximized in size but not actually maximized. This creates work for the user and makes it very difficult to use and resize manually. So set the newly unmaximized window size to the previously used size or 80% of the size of the current workarea (attempting to retain natural aspect ratio if possible), whichever is smaller. https://bugzilla.gnome.org/show_bug.cgi?id=671677
2012-03-12 16:09:17 +00:00
}
else
{
float aspect = (float)desired_rect->width / (float)desired_rect->height;
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
desired_rect->height = MAX (work_area.height * sqrt (MAX_UNMAXIMIZED_WINDOW_AREA), window->size_hints.min_height);
desired_rect->width = MAX (desired_rect->height * aspect, window->size_hints.min_width);
Don't unmaximize to nearly maximized size Basically we don't really want to create windows that are almost maximized in size but not actually maximized. This creates work for the user and makes it very difficult to use and resize manually. So set the newly unmaximized window size to the previously used size or 80% of the size of the current workarea (attempting to retain natural aspect ratio if possible), whichever is smaller. https://bugzilla.gnome.org/show_bug.cgi?id=671677
2012-03-12 16:09:17 +00:00
}
}
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
if (unmaximize_horizontally)
{
target_rect.x = desired_rect->x;
target_rect.width = desired_rect->width;
}
if (unmaximize_vertically)
{
target_rect.y = desired_rect->y;
target_rect.height = desired_rect->height;
}
Only use saved_rect for determining the position to unmaximize to for the 2007-04-03 Elijah Newren <newren gmail com> * src/window.c (meta_window_unmaximize): Only use saved_rect for determining the position to unmaximize to for the previously-maximized direction(s). Fixes #355497. svn path=/trunk/; revision=3154
2007-04-04 03:07:26 +00:00
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
/* Window's size hints may have changed while maximized, making
* saved_rect invalid. #329152
*/
meta_window_frame_rect_to_client_rect (window, &target_rect, &target_rect);
ensure_size_hints_satisfied (&target_rect, &window->size_hints);
meta_window_client_rect_to_frame_rect (window, &target_rect, &target_rect);
window: Inform the compositor when a window effectively changes size In order for the compositor plugin to be able to animate window size changes properly we need to let it know of the starting and final window sizes. For X clients this can be done synchronously and thus with a single call into the compositor plugin since it's us (the window manager) who's in charge of the final window size. Wayland clients though, have the final say over their window size since it's determined from the client allocated buffer. This patch moves the meta_compositor_size_change_window() calls before move_resize_internal() which lets the compositor plugin know the old window size and freezes the MetaWindowActor. Then we get rid of the META_MOVE_RESIZE_DONT_SYNC_COMPOSITOR flag since it's not needed anymore as the window actor is frozen and that means we can use meta_compositor_sync_window_geometry() as the point where we inform the compositor plugin of the final window size. https://bugzilla.gnome.org/show_bug.cgi?id=770345
2016-09-26 14:30:54 +00:00
meta_compositor_size_change_window (window->display->compositor, window,
META_SIZE_CHANGE_UNMAXIMIZE,
&old_frame_rect, &old_buffer_rect);
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
meta_window_move_resize_internal (window,
(META_MOVE_RESIZE_MOVE_ACTION |
META_MOVE_RESIZE_RESIZE_ACTION |
core: Add new unmaximize flag Wayland clients know their size better, so for Wayland we'd rather not try to resize the client on un-maximize, but for this to work we need a new MetaMoveResizeFlags. https://bugzilla.gnome.org/show_bug.cgi?id=783901
2017-06-21 09:30:09 +00:00
META_MOVE_RESIZE_STATE_CHANGED |
META_MOVE_RESIZE_UNMAXIMIZE),
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
NorthWestGravity,
target_rect);
/* When we unmaximize, if we're doing a mouse move also we could
* get the window suddenly jumping to the upper left corner of
* the workspace, since that's where it was when the grab op
window: Use the target rect for the grab anchor position on unmaximize A window's unconstrained_rect is essentially just the target rectangle we hand to meta_window_move_resize_internal() except it's not updated until the window actually moves or resizes. As such, for wayland client resizes, since they're async, using window->unconstrained_rect right after calling move_resize_internal() to update the grab anchor position on unmaximize doesn't work as it does for X clients. To fix this, we can just use the target rectangle for the grab anchor. Note that comment here was already wrong since it says we should be taking constraints into account and yet the code used the unconstrained rect anyway. https://bugzilla.gnome.org/show_bug.cgi?id=770345
2016-09-26 15:09:52 +00:00
* started. So we need to update the grab anchor position.
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
*/
if (meta_grab_op_is_moving (window->display->grab_op) &&
window->display->grab_window == window)
{
window: Use the target rect for the grab anchor position on unmaximize A window's unconstrained_rect is essentially just the target rectangle we hand to meta_window_move_resize_internal() except it's not updated until the window actually moves or resizes. As such, for wayland client resizes, since they're async, using window->unconstrained_rect right after calling move_resize_internal() to update the grab anchor position on unmaximize doesn't work as it does for X clients. To fix this, we can just use the target rectangle for the grab anchor. Note that comment here was already wrong since it says we should be taking constraints into account and yet the code used the unconstrained rect anyway. https://bugzilla.gnome.org/show_bug.cgi?id=770345
2016-09-26 15:09:52 +00:00
window->display->grab_anchor_window_pos = target_rect;
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
}
meta_window_recalc_features (window);
set_net_wm_state (window);
if (!window->monitor->in_fullscreen)
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
meta_display_queue_check_fullscreen (window->display);
...
2001-06-04 06:17:52 +00:00
}
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
g_object_freeze_notify (G_OBJECT (window));
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_MAXIMIZED_HORIZONTALLY]);
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_MAXIMIZED_VERTICALLY]);
g_object_thaw_notify (G_OBJECT (window));
...
2001-06-02 04:14:18 +00:00
}
Add keybinding to allow the user to toggle _NET_WM_STATE_ABOVE on windows. 2003-06-26 Rob Adams <robadams@ucla.edu> Add keybinding to allow the user to toggle _NET_WM_STATE_ABOVE on windows. Disabled by default. See #98387. * src/keybindings.c (handle_toggle_above): new function implements the keybinding * src/metacity.schemas.in: add toggle_above keybinding * src/prefs.[ch]: add toggle_above keybinding * src/window.[ch] (meta_window_make_above): new function to put a window into the above state (meta_window_unmake_above): new function takes a window out of the above state
2003-06-27 14:49:56 +00:00
void
meta_window_make_above (MetaWindow *window)
{
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
MetaWindow: Add :resizable and :above properties Allow libmutter users to treat windows different based on these attributes and to watch for changes. https://bugzilla.gnome.org/show_bug.cgi?id=653858
2011-07-02 11:08:17 +00:00
meta_window_set_above (window, TRUE);
Add keybinding to allow the user to toggle _NET_WM_STATE_ABOVE on windows. 2003-06-26 Rob Adams <robadams@ucla.edu> Add keybinding to allow the user to toggle _NET_WM_STATE_ABOVE on windows. Disabled by default. See #98387. * src/keybindings.c (handle_toggle_above): new function implements the keybinding * src/metacity.schemas.in: add toggle_above keybinding * src/prefs.[ch]: add toggle_above keybinding * src/window.[ch] (meta_window_make_above): new function to put a window into the above state (meta_window_unmake_above): new function takes a window out of the above state
2003-06-27 14:49:56 +00:00
meta_window_raise (window);
}
void
meta_window_unmake_above (MetaWindow *window)
{
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
MetaWindow: Add :resizable and :above properties Allow libmutter users to treat windows different based on these attributes and to watch for changes. https://bugzilla.gnome.org/show_bug.cgi?id=653858
2011-07-02 11:08:17 +00:00
meta_window_set_above (window, FALSE);
Add keybinding to allow the user to toggle _NET_WM_STATE_ABOVE on windows. 2003-06-26 Rob Adams <robadams@ucla.edu> Add keybinding to allow the user to toggle _NET_WM_STATE_ABOVE on windows. Disabled by default. See #98387. * src/keybindings.c (handle_toggle_above): new function implements the keybinding * src/metacity.schemas.in: add toggle_above keybinding * src/prefs.[ch]: add toggle_above keybinding * src/window.[ch] (meta_window_make_above): new function to put a window into the above state (meta_window_unmake_above): new function takes a window out of the above state
2003-06-27 14:49:56 +00:00
meta_window_raise (window);
MetaWindow: Add :resizable and :above properties Allow libmutter users to treat windows different based on these attributes and to watch for changes. https://bugzilla.gnome.org/show_bug.cgi?id=653858
2011-07-02 11:08:17 +00:00
}
static void
meta_window_set_above (MetaWindow *window,
gboolean new_value)
{
new_value = new_value != FALSE;
if (new_value == window->wm_state_above)
return;
window->wm_state_above = new_value;
Add keybinding to allow the user to toggle _NET_WM_STATE_ABOVE on windows. 2003-06-26 Rob Adams <robadams@ucla.edu> Add keybinding to allow the user to toggle _NET_WM_STATE_ABOVE on windows. Disabled by default. See #98387. * src/keybindings.c (handle_toggle_above): new function implements the keybinding * src/metacity.schemas.in: add toggle_above keybinding * src/prefs.[ch]: add toggle_above keybinding * src/window.[ch] (meta_window_make_above): new function to put a window into the above state (meta_window_unmake_above): new function takes a window out of the above state
2003-06-27 14:49:56 +00:00
meta_window_update_layer (window);
set_net_wm_state (window);
MetaFrame: Cache borders Cache the computed border size so we can fetch the border size at any time without worrying that we'll be spending too much time in the theme code (in some cases we might allocate a PangoFontDescription or do other significant work.) The main effort here is clearing the cache when various bits of window state change that could potentially affect the computed borders. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 22:37:50 +00:00
meta_window_frame_size_changed (window);
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_ABOVE]);
Add keybinding to allow the user to toggle _NET_WM_STATE_ABOVE on windows. 2003-06-26 Rob Adams <robadams@ucla.edu> Add keybinding to allow the user to toggle _NET_WM_STATE_ABOVE on windows. Disabled by default. See #98387. * src/keybindings.c (handle_toggle_above): new function implements the keybinding * src/metacity.schemas.in: add toggle_above keybinding * src/prefs.[ch]: add toggle_above keybinding * src/window.[ch] (meta_window_make_above): new function to put a window into the above state (meta_window_unmake_above): new function takes a window out of the above state
2003-06-27 14:49:56 +00:00
}
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
void
Fix several bugs with handling of fullscreen windows, causing them to not 2006-08-21 Elijah Newren <newren gmail com> Fix several bugs with handling of fullscreen windows, causing them to not actually be fullscreen. #343115 (and also #346927, #350547, #351643, the recent additional WINE-related issue mentioned on the mailing list, and probably others...) * src/constraints.c (setup_constraint_info): if a window tries to resize to fullscreen-size and it has a fullscreen function but isn't actually marked as fullscreen then assist it by marking it as such, (constrain_fully_onscreen, constrain_titlebar_visible): ignore this constraint for fullscreen windows since such windows have a separate specialized constraint * src/stack.c (window_is_fullscreen_size, get_standalone_layer): remove the old window_is_fullscreen_size() hack for detecting windows to treat as fullscreen since it doesn't work well with the new constraints framework (i.e. we needed a slightly different hack) * src/window.[ch] (meta_window_new_with_addrs): shuffle the order of adding the window to the stack and moveresizing the window since moveresizing can cause stack changes if the window's initial size is fullscreen size, (meta_window_make_fullscreen, meta_window_make_fullscreen_internal): split meta_window_make_fullscreen() similar to meta_window_maximize() so that constraints can make use of it
2006-08-21 18:08:05 +00:00
meta_window_make_fullscreen_internal (MetaWindow *window)
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
{
if (!window->fullscreen)
{
meta_topic (META_DEBUG_WINDOW_OPS,
"Fullscreening %s\n", window->desc);
unshade window if shaded, from JeyaSudha (meta_window_make_fullscreen): 2002-08-10 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_maximize): unshade window if shaded, from JeyaSudha (meta_window_make_fullscreen): ditto
2002-08-10 19:04:55 +00:00
if (window->shaded)
Partial audit to fix timestamp usage. One step towards fixing #355180; see 2006-09-18 Elijah Newren <newren gmail com> Partial audit to fix timestamp usage. One step towards fixing #355180; see important comments in that bug. * src/core.[ch] (meta_core_unshade, meta_core_shade): * src/delete.c (meta_window_present_delete_dialog, delete_ping_timeout_func): * src/display.[ch] (meta_display_open, meta_display_close, event_callback, meta_display_begin_grab_op, process_selection_clear, meta_display_unmanage_screen, meta_display_unmanage_windows_for_screen): * src/frames.c (meta_frames_button_press_event): * src/keybindings.c (handle_toggle_shade): * src/main.c (main): * src/screen.[ch] (update_num_workspaces, meta_screen_new, meta_screen_free, prefs_changed_callback): * src/window.[ch] (meta_window_free, finish_minimize, implement_showing, meta_window_show, meta_window_maximize, meta_window_make_fullscreen_internal, meta_window_unmake_fullscreen, meta_window_shade, meta_window_unshade, window_activate, send_sync_request, meta_window_client_message, menu_callback, meta_window_update_keyboard_resize): Remove usage of CurrentTime, meta_display_get_current_time() and meta_display_get_current_time_roundtrip() where possible, or document why it isn't possible, or at very least add a FIXME with some explanation of my laziness and what needs to be done.
2006-09-18 17:27:24 +00:00
{
/* Shading sucks anyway; I'm not adding a timestamp argument
* to this function just for this niche usage & corner case.
*/
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
guint32 timestamp =
Partial audit to fix timestamp usage. One step towards fixing #355180; see 2006-09-18 Elijah Newren <newren gmail com> Partial audit to fix timestamp usage. One step towards fixing #355180; see important comments in that bug. * src/core.[ch] (meta_core_unshade, meta_core_shade): * src/delete.c (meta_window_present_delete_dialog, delete_ping_timeout_func): * src/display.[ch] (meta_display_open, meta_display_close, event_callback, meta_display_begin_grab_op, process_selection_clear, meta_display_unmanage_screen, meta_display_unmanage_windows_for_screen): * src/frames.c (meta_frames_button_press_event): * src/keybindings.c (handle_toggle_shade): * src/main.c (main): * src/screen.[ch] (update_num_workspaces, meta_screen_new, meta_screen_free, prefs_changed_callback): * src/window.[ch] (meta_window_free, finish_minimize, implement_showing, meta_window_show, meta_window_maximize, meta_window_make_fullscreen_internal, meta_window_unmake_fullscreen, meta_window_shade, meta_window_unshade, window_activate, send_sync_request, meta_window_client_message, menu_callback, meta_window_update_keyboard_resize): Remove usage of CurrentTime, meta_display_get_current_time() and meta_display_get_current_time_roundtrip() where possible, or document why it isn't possible, or at very least add a FIXME with some explanation of my laziness and what needs to be done.
2006-09-18 17:27:24 +00:00
meta_display_get_current_time_roundtrip (window->display);
meta_window_unshade (window, timestamp);
}
new function, only saves rect after checking current state, #93795 2002-09-24 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_save_rect): new function, only saves rect after checking current state, #93795 (meta_window_make_fullscreen): use new function (meta_window_maximize): use new function
2002-09-24 21:33:34 +00:00
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
meta_window_save_rect (window);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
window->fullscreen = TRUE;
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_freeze (window->display->stack);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
meta_window_raise (window);
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_thaw (window->display->stack);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window: Fix build The proper function name is "meta_window_recalc_features"
2014-02-01 23:58:58 +00:00
meta_window_recalc_features (window);
Fix several bugs with handling of fullscreen windows, causing them to not 2006-08-21 Elijah Newren <newren gmail com> Fix several bugs with handling of fullscreen windows, causing them to not actually be fullscreen. #343115 (and also #346927, #350547, #351643, the recent additional WINE-related issue mentioned on the mailing list, and probably others...) * src/constraints.c (setup_constraint_info): if a window tries to resize to fullscreen-size and it has a fullscreen function but isn't actually marked as fullscreen then assist it by marking it as such, (constrain_fully_onscreen, constrain_titlebar_visible): ignore this constraint for fullscreen windows since such windows have a separate specialized constraint * src/stack.c (window_is_fullscreen_size, get_standalone_layer): remove the old window_is_fullscreen_size() hack for detecting windows to treat as fullscreen since it doesn't work well with the new constraints framework (i.e. we needed a slightly different hack) * src/window.[ch] (meta_window_new_with_addrs): shuffle the order of adding the window to the stack and moveresizing the window since moveresizing can cause stack changes if the window's initial size is fullscreen size, (meta_window_make_fullscreen, meta_window_make_fullscreen_internal): split meta_window_make_fullscreen() similar to meta_window_maximize() so that constraints can make use of it
2006-08-21 18:08:05 +00:00
set_net_wm_state (window);
Added MetaWindow::fullscreen property (read only).
2009-03-17 12:27:13 +00:00
MetaScreen: Add tracking of whether there are fullscreen windows Trying to track the fullscreen status outside of Mutter, as GNOME Shell was doing previously, was very prone to errors, because Mutter has a very tricky definition of when a window is set to be fullscreen and *actually* acting like a fullscreen window. * Add meta_screen_get_monitor_in_fullscreen() and an ::in-fullscreen-changed signal. This allows an application to track when there are fullscreen windows on a monitor. * Do the computation of fullscreen status in a "later" function that runs after showing, so we properly take focus into account. * To get ordering of different phases right, add more values to MetaLaterType. * Add auto-minimization, similar to what was added to GNOME Shell earlier in this cycle - if a window is set to be fullscreen, but not actually fullscreen, minimize. https://bugzilla.gnome.org/show_bug.cgi?id=649748
2013-03-14 20:55:49 +00:00
/* For the auto-minimize feature, if we fail to get focus */
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
meta_display_queue_check_fullscreen (window->display);
MetaScreen: Add tracking of whether there are fullscreen windows Trying to track the fullscreen status outside of Mutter, as GNOME Shell was doing previously, was very prone to errors, because Mutter has a very tricky definition of when a window is set to be fullscreen and *actually* acting like a fullscreen window. * Add meta_screen_get_monitor_in_fullscreen() and an ::in-fullscreen-changed signal. This allows an application to track when there are fullscreen windows on a monitor. * Do the computation of fullscreen status in a "later" function that runs after showing, so we properly take focus into account. * To get ordering of different phases right, add more values to MetaLaterType. * Add auto-minimization, similar to what was added to GNOME Shell earlier in this cycle - if a window is set to be fullscreen, but not actually fullscreen, minimize. https://bugzilla.gnome.org/show_bug.cgi?id=649748
2013-03-14 20:55:49 +00:00
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_FULLSCREEN]);
Fix several bugs with handling of fullscreen windows, causing them to not 2006-08-21 Elijah Newren <newren gmail com> Fix several bugs with handling of fullscreen windows, causing them to not actually be fullscreen. #343115 (and also #346927, #350547, #351643, the recent additional WINE-related issue mentioned on the mailing list, and probably others...) * src/constraints.c (setup_constraint_info): if a window tries to resize to fullscreen-size and it has a fullscreen function but isn't actually marked as fullscreen then assist it by marking it as such, (constrain_fully_onscreen, constrain_titlebar_visible): ignore this constraint for fullscreen windows since such windows have a separate specialized constraint * src/stack.c (window_is_fullscreen_size, get_standalone_layer): remove the old window_is_fullscreen_size() hack for detecting windows to treat as fullscreen since it doesn't work well with the new constraints framework (i.e. we needed a slightly different hack) * src/window.[ch] (meta_window_new_with_addrs): shuffle the order of adding the window to the stack and moveresizing the window since moveresizing can cause stack changes if the window's initial size is fullscreen size, (meta_window_make_fullscreen, meta_window_make_fullscreen_internal): split meta_window_make_fullscreen() similar to meta_window_maximize() so that constraints can make use of it
2006-08-21 18:08:05 +00:00
}
}
void
meta_window_make_fullscreen (MetaWindow *window)
{
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
Fix several bugs with handling of fullscreen windows, causing them to not 2006-08-21 Elijah Newren <newren gmail com> Fix several bugs with handling of fullscreen windows, causing them to not actually be fullscreen. #343115 (and also #346927, #350547, #351643, the recent additional WINE-related issue mentioned on the mailing list, and probably others...) * src/constraints.c (setup_constraint_info): if a window tries to resize to fullscreen-size and it has a fullscreen function but isn't actually marked as fullscreen then assist it by marking it as such, (constrain_fully_onscreen, constrain_titlebar_visible): ignore this constraint for fullscreen windows since such windows have a separate specialized constraint * src/stack.c (window_is_fullscreen_size, get_standalone_layer): remove the old window_is_fullscreen_size() hack for detecting windows to treat as fullscreen since it doesn't work well with the new constraints framework (i.e. we needed a slightly different hack) * src/window.[ch] (meta_window_new_with_addrs): shuffle the order of adding the window to the stack and moveresizing the window since moveresizing can cause stack changes if the window's initial size is fullscreen size, (meta_window_make_fullscreen, meta_window_make_fullscreen_internal): split meta_window_make_fullscreen() similar to meta_window_maximize() so that constraints can make use of it
2006-08-21 18:08:05 +00:00
if (!window->fullscreen)
{
compositor: add hooks for fullscreen and unfullscreen animations https://bugzilla.gnome.org/show_bug.cgi?id=707248
2013-09-01 20:04:19 +00:00
MetaRectangle old_frame_rect, old_buffer_rect;
meta_window_get_frame_rect (window, &old_frame_rect);
meta_window_get_buffer_rect (window, &old_buffer_rect);
window: Force state changes on maximized / fullscreen
2014-12-15 21:44:22 +00:00
window: Inform the compositor when a window effectively changes size In order for the compositor plugin to be able to animate window size changes properly we need to let it know of the starting and final window sizes. For X clients this can be done synchronously and thus with a single call into the compositor plugin since it's us (the window manager) who's in charge of the final window size. Wayland clients though, have the final say over their window size since it's determined from the client allocated buffer. This patch moves the meta_compositor_size_change_window() calls before move_resize_internal() which lets the compositor plugin know the old window size and freezes the MetaWindowActor. Then we get rid of the META_MOVE_RESIZE_DONT_SYNC_COMPOSITOR flag since it's not needed anymore as the window actor is frozen and that means we can use meta_compositor_sync_window_geometry() as the point where we inform the compositor plugin of the final window size. https://bugzilla.gnome.org/show_bug.cgi?id=770345
2016-09-26 14:30:54 +00:00
meta_compositor_size_change_window (window->display->compositor,
window, META_SIZE_CHANGE_FULLSCREEN,
&old_frame_rect, &old_buffer_rect);
compositor: add hooks for fullscreen and unfullscreen animations https://bugzilla.gnome.org/show_bug.cgi?id=707248
2013-09-01 20:04:19 +00:00
meta_window_make_fullscreen_internal (window);
window: Force state changes on maximized / fullscreen
2014-12-15 21:44:22 +00:00
meta_window_move_resize_internal (window,
compositor: add hooks for fullscreen and unfullscreen animations https://bugzilla.gnome.org/show_bug.cgi?id=707248
2013-09-01 20:04:19 +00:00
(META_MOVE_RESIZE_MOVE_ACTION |
META_MOVE_RESIZE_RESIZE_ACTION |
window: Inform the compositor when a window effectively changes size In order for the compositor plugin to be able to animate window size changes properly we need to let it know of the starting and final window sizes. For X clients this can be done synchronously and thus with a single call into the compositor plugin since it's us (the window manager) who's in charge of the final window size. Wayland clients though, have the final say over their window size since it's determined from the client allocated buffer. This patch moves the meta_compositor_size_change_window() calls before move_resize_internal() which lets the compositor plugin know the old window size and freezes the MetaWindowActor. Then we get rid of the META_MOVE_RESIZE_DONT_SYNC_COMPOSITOR flag since it's not needed anymore as the window actor is frozen and that means we can use meta_compositor_sync_window_geometry() as the point where we inform the compositor plugin of the final window size. https://bugzilla.gnome.org/show_bug.cgi?id=770345
2016-09-26 14:30:54 +00:00
META_MOVE_RESIZE_STATE_CHANGED),
window: Force state changes on maximized / fullscreen
2014-12-15 21:44:22 +00:00
NorthWestGravity,
window->unconstrained_rect);
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
}
}
void
meta_window_unmake_fullscreen (MetaWindow *window)
{
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
if (window->fullscreen)
{
compositor: add hooks for fullscreen and unfullscreen animations https://bugzilla.gnome.org/show_bug.cgi?id=707248
2013-09-01 20:04:19 +00:00
MetaRectangle old_frame_rect, old_buffer_rect, target_rect;
Fix lots of little issues with min/max constraints and size increment 2004-04-04 Elijah Newren <newren gmail com> Fix lots of little issues with min/max constraints and size increment constraints. Fixes #329152, #418395, and possibly others. * src/window-props.c (meta_set_normal_hints): Do more checking to make sure application specified constraints are self-consistent, modifying the size_hints as necessary to achieve self-consistency. * src/constraints.c (setup_constraint_info): remove ugly copy-pasto, (constrain_size_increments): be careful that fixing violation of the constraints doesn't cause a violation of the minimum size constraints. * src/window.c (ensure_size_hints_satisfied): new function, (meta_window_unmaximize, meta_window_unmake_fullscreen): the saved_rect may no longer be valid (as in the case of #329152) so call ensure_size_hints_satisfied to fix it up. * doc/how-to-get-focus-right.txt: Some minor spacing and wording fixes completely unrelated to the rest of this commit svn path=/trunk/; revision=3155
2007-04-04 21:54:56 +00:00
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
meta_topic (META_DEBUG_WINDOW_OPS,
"Unfullscreening %s\n", window->desc);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
window->fullscreen = FALSE;
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
target_rect = window->saved_rect;
Fix lots of little issues with min/max constraints and size increment 2004-04-04 Elijah Newren <newren gmail com> Fix lots of little issues with min/max constraints and size increment constraints. Fixes #329152, #418395, and possibly others. * src/window-props.c (meta_set_normal_hints): Do more checking to make sure application specified constraints are self-consistent, modifying the size_hints as necessary to achieve self-consistency. * src/constraints.c (setup_constraint_info): remove ugly copy-pasto, (constrain_size_increments): be careful that fixing violation of the constraints doesn't cause a violation of the minimum size constraints. * src/window.c (ensure_size_hints_satisfied): new function, (meta_window_unmaximize, meta_window_unmake_fullscreen): the saved_rect may no longer be valid (as in the case of #329152) so call ensure_size_hints_satisfied to fix it up. * doc/how-to-get-focus-right.txt: Some minor spacing and wording fixes completely unrelated to the rest of this commit svn path=/trunk/; revision=3155
2007-04-04 21:54:56 +00:00
window: Clear the frame borders before calculating the unfullscreen rect Going from fullscreen to unfullscreen involves a frame border size, so in order to properly interpret the saved rect size, we need to make sure that the frame borders are fully up to date.
2015-06-24 00:05:27 +00:00
meta_window_frame_size_changed (window);
compositor: add hooks for fullscreen and unfullscreen animations https://bugzilla.gnome.org/show_bug.cgi?id=707248
2013-09-01 20:04:19 +00:00
meta_window_get_frame_rect (window, &old_frame_rect);
meta_window_get_buffer_rect (window, &old_buffer_rect);
window: Clear the frame borders before calculating the unfullscreen rect Going from fullscreen to unfullscreen involves a frame border size, so in order to properly interpret the saved rect size, we need to make sure that the frame borders are fully up to date.
2015-06-24 00:05:27 +00:00
Fix lots of little issues with min/max constraints and size increment 2004-04-04 Elijah Newren <newren gmail com> Fix lots of little issues with min/max constraints and size increment constraints. Fixes #329152, #418395, and possibly others. * src/window-props.c (meta_set_normal_hints): Do more checking to make sure application specified constraints are self-consistent, modifying the size_hints as necessary to achieve self-consistency. * src/constraints.c (setup_constraint_info): remove ugly copy-pasto, (constrain_size_increments): be careful that fixing violation of the constraints doesn't cause a violation of the minimum size constraints. * src/window.c (ensure_size_hints_satisfied): new function, (meta_window_unmaximize, meta_window_unmake_fullscreen): the saved_rect may no longer be valid (as in the case of #329152) so call ensure_size_hints_satisfied to fix it up. * doc/how-to-get-focus-right.txt: Some minor spacing and wording fixes completely unrelated to the rest of this commit svn path=/trunk/; revision=3155
2007-04-04 21:54:56 +00:00
/* Window's size hints may have changed while maximized, making
* saved_rect invalid. #329152
*/
window: Make sure size hints are applied in client rect on unfullscreen
2014-11-13 01:53:44 +00:00
meta_window_frame_rect_to_client_rect (window, &target_rect, &target_rect);
Fix lots of little issues with min/max constraints and size increment 2004-04-04 Elijah Newren <newren gmail com> Fix lots of little issues with min/max constraints and size increment constraints. Fixes #329152, #418395, and possibly others. * src/window-props.c (meta_set_normal_hints): Do more checking to make sure application specified constraints are self-consistent, modifying the size_hints as necessary to achieve self-consistency. * src/constraints.c (setup_constraint_info): remove ugly copy-pasto, (constrain_size_increments): be careful that fixing violation of the constraints doesn't cause a violation of the minimum size constraints. * src/window.c (ensure_size_hints_satisfied): new function, (meta_window_unmaximize, meta_window_unmake_fullscreen): the saved_rect may no longer be valid (as in the case of #329152) so call ensure_size_hints_satisfied to fix it up. * doc/how-to-get-focus-right.txt: Some minor spacing and wording fixes completely unrelated to the rest of this commit svn path=/trunk/; revision=3155
2007-04-04 21:54:56 +00:00
ensure_size_hints_satisfied (&target_rect, &window->size_hints);
window: Make sure size hints are applied in client rect on unfullscreen
2014-11-13 01:53:44 +00:00
meta_window_client_rect_to_frame_rect (window, &target_rect, &target_rect);
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
Update window->has_resize_func at the right time when unfullscreening Since the frame window size that meta_window_move_resize() uses depends on whether the window has horizontal/vertical resize functionality, we need to update this flag before we resize the window. https://bugzilla.gnome.org/show_bug.cgi?id=659854
2011-10-17 18:56:56 +00:00
/* Need to update window->has_resize_func before we move_resize()
*/
window: Fix build The proper function name is "meta_window_recalc_features"
2014-02-01 23:58:58 +00:00
meta_window_recalc_features (window);
Update window->has_resize_func at the right time when unfullscreening Since the frame window size that meta_window_move_resize() uses depends on whether the window has horizontal/vertical resize functionality, we need to update this flag before we resize the window. https://bugzilla.gnome.org/show_bug.cgi?id=659854
2011-10-17 18:56:56 +00:00
set_net_wm_state (window);
window: Inform the compositor when a window effectively changes size In order for the compositor plugin to be able to animate window size changes properly we need to let it know of the starting and final window sizes. For X clients this can be done synchronously and thus with a single call into the compositor plugin since it's us (the window manager) who's in charge of the final window size. Wayland clients though, have the final say over their window size since it's determined from the client allocated buffer. This patch moves the meta_compositor_size_change_window() calls before move_resize_internal() which lets the compositor plugin know the old window size and freezes the MetaWindowActor. Then we get rid of the META_MOVE_RESIZE_DONT_SYNC_COMPOSITOR flag since it's not needed anymore as the window actor is frozen and that means we can use meta_compositor_sync_window_geometry() as the point where we inform the compositor plugin of the final window size. https://bugzilla.gnome.org/show_bug.cgi?id=770345
2016-09-26 14:30:54 +00:00
meta_compositor_size_change_window (window->display->compositor,
window, META_SIZE_CHANGE_UNFULLSCREEN,
&old_frame_rect, &old_buffer_rect);
window: Force state changes on maximized / fullscreen
2014-12-15 21:44:22 +00:00
meta_window_move_resize_internal (window,
compositor: add hooks for fullscreen and unfullscreen animations https://bugzilla.gnome.org/show_bug.cgi?id=707248
2013-09-01 20:04:19 +00:00
(META_MOVE_RESIZE_MOVE_ACTION |
META_MOVE_RESIZE_RESIZE_ACTION |
window/wayland: Don't always use constrained size when unfullscreening When we're unfullscreening, we might be returning to a window state that has its size either managed by constraints (tiled, maximized), or not (floating). Lets just pass the configure size 0x0 when we're not using constrained sizes (i.e. the window going from being fullscreen to not maximized) and let the application decide how to size itself. Fixes: https://gitlab.gnome.org/GNOME/mutter/issues/638 https://gitlab.gnome.org/GNOME/mutter/merge_requests/621
2019-06-13 08:35:35 +00:00
META_MOVE_RESIZE_STATE_CHANGED |
META_MOVE_RESIZE_UNFULLSCREEN),
window: Force state changes on maximized / fullscreen
2014-12-15 21:44:22 +00:00
NorthWestGravity,
target_rect);
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
meta_display_queue_check_fullscreen (window->display);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_FULLSCREEN]);
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
}
}
window: Keep track of fullscreen monitors directly Instead of keeping around array indexes, keep track of them by storing a pointer instead. This also changes from using an array (imitating the X11 behaviour) to more explicit storing. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 09:50:17 +00:00
static void
meta_window_clear_fullscreen_monitors (MetaWindow *window)
This change adds support for the new _NET_WM_FULLSCREEN_MONITORS property and client message. This allows client applications to request that a fullscreen window cover more than one monitor. * src/include/boxes.h: * src/core/boxes.c: Add meta_rectangle_union * src/core/window-private.h: * src/core/window.c: (meta_window_new_with_attrs, meta_window_free, set_net_wm_state, meta_window_update_fullscreen_monitors, meta_window_client_message): Add MetaWindow property to store fullscreen monitors field, update _NET_WM_FULLSCREEN_MONITORS property on windows, and handle client message. * src/core/atomnames.h: Add _NET_WM_FULLSCREEN_MONITORS atom. * src/core/constraints.c (setup_constraint_info): If _NET_WM_FULLSCREEN_MONITORS is interesting, use the data stored in MetaWindow::fullscreen_monitors to determine the fullscreen area instead of the basic xinerama_info area. svn path=/trunk/; revision=4021
2008-11-17 02:57:20 +00:00
{
window: Keep track of fullscreen monitors directly Instead of keeping around array indexes, keep track of them by storing a pointer instead. This also changes from using an array (imitating the X11 behaviour) to more explicit storing. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 09:50:17 +00:00
window->fullscreen_monitors.top = NULL;
window->fullscreen_monitors.bottom = NULL;
window->fullscreen_monitors.left = NULL;
window->fullscreen_monitors.right = NULL;
}
MetaScreen: Remove redundant copy of logical monitors array It was just pointer to the actual list; having to synchronize a list of logical monitors with the actual monitors managed by the backend is unnecessary. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-28 12:11:24 +00:00
window: Keep track of fullscreen monitors directly Instead of keeping around array indexes, keep track of them by storing a pointer instead. This also changes from using an array (imitating the X11 behaviour) to more explicit storing. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 09:50:17 +00:00
void
meta_window_update_fullscreen_monitors (MetaWindow *window,
MetaLogicalMonitor *top,
MetaLogicalMonitor *bottom,
MetaLogicalMonitor *left,
MetaLogicalMonitor *right)
{
if (top && bottom && left && right)
This change adds support for the new _NET_WM_FULLSCREEN_MONITORS property and client message. This allows client applications to request that a fullscreen window cover more than one monitor. * src/include/boxes.h: * src/core/boxes.c: Add meta_rectangle_union * src/core/window-private.h: * src/core/window.c: (meta_window_new_with_attrs, meta_window_free, set_net_wm_state, meta_window_update_fullscreen_monitors, meta_window_client_message): Add MetaWindow property to store fullscreen monitors field, update _NET_WM_FULLSCREEN_MONITORS property on windows, and handle client message. * src/core/atomnames.h: Add _NET_WM_FULLSCREEN_MONITORS atom. * src/core/constraints.c (setup_constraint_info): If _NET_WM_FULLSCREEN_MONITORS is interesting, use the data stored in MetaWindow::fullscreen_monitors to determine the fullscreen area instead of the basic xinerama_info area. svn path=/trunk/; revision=4021
2008-11-17 02:57:20 +00:00
{
window: Keep track of fullscreen monitors directly Instead of keeping around array indexes, keep track of them by storing a pointer instead. This also changes from using an array (imitating the X11 behaviour) to more explicit storing. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 09:50:17 +00:00
window->fullscreen_monitors.top = top;
window->fullscreen_monitors.bottom = bottom;
window->fullscreen_monitors.left = left;
window->fullscreen_monitors.right = right;
This change adds support for the new _NET_WM_FULLSCREEN_MONITORS property and client message. This allows client applications to request that a fullscreen window cover more than one monitor. * src/include/boxes.h: * src/core/boxes.c: Add meta_rectangle_union * src/core/window-private.h: * src/core/window.c: (meta_window_new_with_attrs, meta_window_free, set_net_wm_state, meta_window_update_fullscreen_monitors, meta_window_client_message): Add MetaWindow property to store fullscreen monitors field, update _NET_WM_FULLSCREEN_MONITORS property on windows, and handle client message. * src/core/atomnames.h: Add _NET_WM_FULLSCREEN_MONITORS atom. * src/core/constraints.c (setup_constraint_info): If _NET_WM_FULLSCREEN_MONITORS is interesting, use the data stored in MetaWindow::fullscreen_monitors to determine the fullscreen area instead of the basic xinerama_info area. svn path=/trunk/; revision=4021
2008-11-17 02:57:20 +00:00
}
else
{
window: Keep track of fullscreen monitors directly Instead of keeping around array indexes, keep track of them by storing a pointer instead. This also changes from using an array (imitating the X11 behaviour) to more explicit storing. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 09:50:17 +00:00
meta_window_clear_fullscreen_monitors (window);
This change adds support for the new _NET_WM_FULLSCREEN_MONITORS property and client message. This allows client applications to request that a fullscreen window cover more than one monitor. * src/include/boxes.h: * src/core/boxes.c: Add meta_rectangle_union * src/core/window-private.h: * src/core/window.c: (meta_window_new_with_attrs, meta_window_free, set_net_wm_state, meta_window_update_fullscreen_monitors, meta_window_client_message): Add MetaWindow property to store fullscreen monitors field, update _NET_WM_FULLSCREEN_MONITORS property on windows, and handle client message. * src/core/atomnames.h: Add _NET_WM_FULLSCREEN_MONITORS atom. * src/core/constraints.c (setup_constraint_info): If _NET_WM_FULLSCREEN_MONITORS is interesting, use the data stored in MetaWindow::fullscreen_monitors to determine the fullscreen area instead of the basic xinerama_info area. svn path=/trunk/; revision=4021
2008-11-17 02:57:20 +00:00
}
if (window->fullscreen)
{
meta_window_queue(window, META_QUEUE_MOVE_RESIZE);
}
}
window: Keep track of fullscreen monitors directly Instead of keeping around array indexes, keep track of them by storing a pointer instead. This also changes from using an array (imitating the X11 behaviour) to more explicit storing. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 09:50:17 +00:00
gboolean
meta_window_has_fullscreen_monitors (MetaWindow *window)
{
return window->fullscreen_monitors.top != NULL;
}
window: Add adjust_fullscreen_monitor_rect virtual method Add an adjust_fullscreen_monitor_rect virtual method to MetaWindowClass and call this from setup_constraint_info() if the window is fullscreen. This allows MetaWindowClass to adjust the monitor-rectangle used to size the window when going fullscreen, which will be used in further commits for a workaround related to fullscreen games under Xwayland. https://gitlab.gnome.org/GNOME/mutter/merge_requests/739
2019-08-22 08:55:17 +00:00
void
meta_window_adjust_fullscreen_monitor_rect (MetaWindow *window,
MetaRectangle *monitor_rect)
{
MetaWindowClass *window_class = META_WINDOW_GET_CLASS (window);
if (window_class->adjust_fullscreen_monitor_rect)
window_class->adjust_fullscreen_monitor_rect (window, monitor_rect);
}
...
2001-06-03 01:33:27 +00:00
void
Partial audit to fix timestamp usage. One step towards fixing #355180; see 2006-09-18 Elijah Newren <newren gmail com> Partial audit to fix timestamp usage. One step towards fixing #355180; see important comments in that bug. * src/core.[ch] (meta_core_unshade, meta_core_shade): * src/delete.c (meta_window_present_delete_dialog, delete_ping_timeout_func): * src/display.[ch] (meta_display_open, meta_display_close, event_callback, meta_display_begin_grab_op, process_selection_clear, meta_display_unmanage_screen, meta_display_unmanage_windows_for_screen): * src/frames.c (meta_frames_button_press_event): * src/keybindings.c (handle_toggle_shade): * src/main.c (main): * src/screen.[ch] (update_num_workspaces, meta_screen_new, meta_screen_free, prefs_changed_callback): * src/window.[ch] (meta_window_free, finish_minimize, implement_showing, meta_window_show, meta_window_maximize, meta_window_make_fullscreen_internal, meta_window_unmake_fullscreen, meta_window_shade, meta_window_unshade, window_activate, send_sync_request, meta_window_client_message, menu_callback, meta_window_update_keyboard_resize): Remove usage of CurrentTime, meta_display_get_current_time() and meta_display_get_current_time_roundtrip() where possible, or document why it isn't possible, or at very least add a FIXME with some explanation of my laziness and what needs to be done.
2006-09-18 17:27:24 +00:00
meta_window_shade (MetaWindow *window,
guint32 timestamp)
...
2001-06-03 01:33:27 +00:00
{
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
Throughout: move to meta_topic rather than meta_verbose so metacity.log 2002-02-07 Havoc Pennington <hp@pobox.com> Throughout: move to meta_topic rather than meta_verbose so metacity.log can start being more useful * src/util.h (enum): add more debug topics * src/frames.c: clean up some cruft that caused warnings
2002-02-08 03:34:26 +00:00
meta_topic (META_DEBUG_WINDOW_OPS,
"Shading %s\n", window->desc);
...
2001-06-08 02:17:48 +00:00
if (!window->shaded)
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
{
draw animation for shading too 2001-08-06 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_shade): draw animation for shading too
2001-08-06 04:43:31 +00:00
window->shaded = TRUE;
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
meta_window_queue(window, META_QUEUE_MOVE_RESIZE | META_QUEUE_CALC_SHOWING);
MetaFrame: Cache borders Cache the computed border size so we can fetch the border size at any time without worrying that we'll be spending too much time in the theme code (in some cases we might allocate a PangoFontDescription or do other significant work.) The main effort here is clearing the cache when various bits of window state change that could potentially affect the computed borders. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 22:37:50 +00:00
meta_window_frame_size_changed (window);
...
2001-06-11 03:24:20 +00:00
focus top window when switching to a new workspace 2002-01-03 Havoc Pennington <hp@pobox.com> * src/workspace.c (meta_workspace_activate): focus top window when switching to a new workspace * src/util.c (meta_topic): start putting verbose output in categories * src/window.c (meta_window_shade): focus frame after we queue the calc_showing so the maps/unmaps have already happened. * src/display.c (meta_display_get_current_time): add the "get time of current event" function and call it occasionally. * src/window.c (meta_window_free): if we have focus, call meta_screen_focus_top_window(). (meta_window_minimize): ditto (meta_window_delete): ditto * src/screen.c (meta_screen_ensure_tab_popup): fix memory leak - didn't free tab list (meta_screen_focus_top_window): new function to use when we unmap or unmanage a focused window * src/stack.c (meta_stack_get_default_focus_window): function used in meta_screen_focus_top_window
2002-01-03 23:28:19 +00:00
/* After queuing the calc showing, since _focus flushes it,
* and we need to focus the frame
*/
meta_topic (META_DEBUG_FOCUS,
"Re-focusing window %s after shading it\n",
window->desc);
Partial audit to fix timestamp usage. One step towards fixing #355180; see 2006-09-18 Elijah Newren <newren gmail com> Partial audit to fix timestamp usage. One step towards fixing #355180; see important comments in that bug. * src/core.[ch] (meta_core_unshade, meta_core_shade): * src/delete.c (meta_window_present_delete_dialog, delete_ping_timeout_func): * src/display.[ch] (meta_display_open, meta_display_close, event_callback, meta_display_begin_grab_op, process_selection_clear, meta_display_unmanage_screen, meta_display_unmanage_windows_for_screen): * src/frames.c (meta_frames_button_press_event): * src/keybindings.c (handle_toggle_shade): * src/main.c (main): * src/screen.[ch] (update_num_workspaces, meta_screen_new, meta_screen_free, prefs_changed_callback): * src/window.[ch] (meta_window_free, finish_minimize, implement_showing, meta_window_show, meta_window_maximize, meta_window_make_fullscreen_internal, meta_window_unmake_fullscreen, meta_window_shade, meta_window_unshade, window_activate, send_sync_request, meta_window_client_message, menu_callback, meta_window_update_keyboard_resize): Remove usage of CurrentTime, meta_display_get_current_time() and meta_display_get_current_time_roundtrip() where possible, or document why it isn't possible, or at very least add a FIXME with some explanation of my laziness and what needs to be done.
2006-09-18 17:27:24 +00:00
meta_window_focus (window, timestamp);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-06-11 03:24:20 +00:00
set_net_wm_state (window);
...
2001-06-03 01:33:27 +00:00
}
}
...
2001-06-06 04:47:37 +00:00
void
Partial audit to fix timestamp usage. One step towards fixing #355180; see 2006-09-18 Elijah Newren <newren gmail com> Partial audit to fix timestamp usage. One step towards fixing #355180; see important comments in that bug. * src/core.[ch] (meta_core_unshade, meta_core_shade): * src/delete.c (meta_window_present_delete_dialog, delete_ping_timeout_func): * src/display.[ch] (meta_display_open, meta_display_close, event_callback, meta_display_begin_grab_op, process_selection_clear, meta_display_unmanage_screen, meta_display_unmanage_windows_for_screen): * src/frames.c (meta_frames_button_press_event): * src/keybindings.c (handle_toggle_shade): * src/main.c (main): * src/screen.[ch] (update_num_workspaces, meta_screen_new, meta_screen_free, prefs_changed_callback): * src/window.[ch] (meta_window_free, finish_minimize, implement_showing, meta_window_show, meta_window_maximize, meta_window_make_fullscreen_internal, meta_window_unmake_fullscreen, meta_window_shade, meta_window_unshade, window_activate, send_sync_request, meta_window_client_message, menu_callback, meta_window_update_keyboard_resize): Remove usage of CurrentTime, meta_display_get_current_time() and meta_display_get_current_time_roundtrip() where possible, or document why it isn't possible, or at very least add a FIXME with some explanation of my laziness and what needs to be done.
2006-09-18 17:27:24 +00:00
meta_window_unshade (MetaWindow *window,
guint32 timestamp)
...
2001-06-06 04:47:37 +00:00
{
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
Throughout: move to meta_topic rather than meta_verbose so metacity.log 2002-02-07 Havoc Pennington <hp@pobox.com> Throughout: move to meta_topic rather than meta_verbose so metacity.log can start being more useful * src/util.h (enum): add more debug topics * src/frames.c: clean up some cruft that caused warnings
2002-02-08 03:34:26 +00:00
meta_topic (META_DEBUG_WINDOW_OPS,
"Unshading %s\n", window->desc);
...
2001-06-08 02:17:48 +00:00
if (window->shaded)
{
window->shaded = FALSE;
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
meta_window_queue(window, META_QUEUE_MOVE_RESIZE | META_QUEUE_CALC_SHOWING);
MetaFrame: Cache borders Cache the computed border size so we can fetch the border size at any time without worrying that we'll be spending too much time in the theme code (in some cases we might allocate a PangoFontDescription or do other significant work.) The main effort here is clearing the cache when various bits of window state change that could potentially affect the computed borders. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 22:37:50 +00:00
meta_window_frame_size_changed (window);
focus top window when switching to a new workspace 2002-01-03 Havoc Pennington <hp@pobox.com> * src/workspace.c (meta_workspace_activate): focus top window when switching to a new workspace * src/util.c (meta_topic): start putting verbose output in categories * src/window.c (meta_window_shade): focus frame after we queue the calc_showing so the maps/unmaps have already happened. * src/display.c (meta_display_get_current_time): add the "get time of current event" function and call it occasionally. * src/window.c (meta_window_free): if we have focus, call meta_screen_focus_top_window(). (meta_window_minimize): ditto (meta_window_delete): ditto * src/screen.c (meta_screen_ensure_tab_popup): fix memory leak - didn't free tab list (meta_screen_focus_top_window): new function to use when we unmap or unmanage a focused window * src/stack.c (meta_stack_get_default_focus_window): function used in meta_screen_focus_top_window
2002-01-03 23:28:19 +00:00
...
2001-06-09 21:58:30 +00:00
/* focus the window */
focus top window when switching to a new workspace 2002-01-03 Havoc Pennington <hp@pobox.com> * src/workspace.c (meta_workspace_activate): focus top window when switching to a new workspace * src/util.c (meta_topic): start putting verbose output in categories * src/window.c (meta_window_shade): focus frame after we queue the calc_showing so the maps/unmaps have already happened. * src/display.c (meta_display_get_current_time): add the "get time of current event" function and call it occasionally. * src/window.c (meta_window_free): if we have focus, call meta_screen_focus_top_window(). (meta_window_minimize): ditto (meta_window_delete): ditto * src/screen.c (meta_screen_ensure_tab_popup): fix memory leak - didn't free tab list (meta_screen_focus_top_window): new function to use when we unmap or unmanage a focused window * src/stack.c (meta_stack_get_default_focus_window): function used in meta_screen_focus_top_window
2002-01-03 23:28:19 +00:00
meta_topic (META_DEBUG_FOCUS,
"Focusing window %s after unshading it\n",
window->desc);
Partial audit to fix timestamp usage. One step towards fixing #355180; see 2006-09-18 Elijah Newren <newren gmail com> Partial audit to fix timestamp usage. One step towards fixing #355180; see important comments in that bug. * src/core.[ch] (meta_core_unshade, meta_core_shade): * src/delete.c (meta_window_present_delete_dialog, delete_ping_timeout_func): * src/display.[ch] (meta_display_open, meta_display_close, event_callback, meta_display_begin_grab_op, process_selection_clear, meta_display_unmanage_screen, meta_display_unmanage_windows_for_screen): * src/frames.c (meta_frames_button_press_event): * src/keybindings.c (handle_toggle_shade): * src/main.c (main): * src/screen.[ch] (update_num_workspaces, meta_screen_new, meta_screen_free, prefs_changed_callback): * src/window.[ch] (meta_window_free, finish_minimize, implement_showing, meta_window_show, meta_window_maximize, meta_window_make_fullscreen_internal, meta_window_unmake_fullscreen, meta_window_shade, meta_window_unshade, window_activate, send_sync_request, meta_window_client_message, menu_callback, meta_window_update_keyboard_resize): Remove usage of CurrentTime, meta_display_get_current_time() and meta_display_get_current_time_roundtrip() where possible, or document why it isn't possible, or at very least add a FIXME with some explanation of my laziness and what needs to be done.
2006-09-18 17:27:24 +00:00
meta_window_focus (window, timestamp);
...
2001-06-11 03:24:20 +00:00
set_net_wm_state (window);
}
}
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
static gboolean
unminimize_func (MetaWindow *window,
void *data)
{
meta_window_unminimize (window);
return TRUE;
}
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
static void
unminimize_window_and_all_transient_parents (MetaWindow *window)
{
revert broken change that assumed foreach_ancestor iterated over the 2003-05-18 Havoc Pennington <hp@pobox.com> * src/window.c (unminimize_window_and_all_transient_parents): revert broken change that assumed foreach_ancestor iterated over the window itself. Andrew Sobala, Rob Adams, #113232 `
2003-05-18 17:16:03 +00:00
meta_window_unminimize (window);
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
meta_window_foreach_ancestor (window, unminimize_func, NULL);
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
}
Start moving X11-specific code to window-x11.c The goal here is to make MetaWindow represent a toplevel, managed window, regardless of if it's X11 or Wayland, and build an abstraction layer up. Right now, most of the X11 code is in core/ and the wayland code in wayland/, but in the future, I want to move a lot of the X11 code to a new toplevel, x11/.
2014-01-23 21:33:53 +00:00
void
meta_window_activate_full (MetaWindow *window,
guint32 timestamp,
MetaClientType source_indication,
MetaWorkspace *workspace)
note exciting new unminimize feature for the tab popup 2001-10-29 Havoc Pennington <hp@pobox.com> * README: note exciting new unminimize feature for the tab popup * src/keybindings.c (process_tab_grab): use meta_window_activate() when choosing a window with tab popup, this should deiconify it * src/window.c (meta_window_client_message): use meta_window_activate for _NET_ACTIVE_WINDOW message (meta_window_activate): new function to raise/focus/unminimize (meta_window_flush_calc_showing): new function (meta_window_focus): force a calc showing on focus, so that we can focus the window if appropriate (it must be mapped)
2001-10-29 07:00:46 +00:00
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
window: Allow activation on non-active workspaces with proper timestamps Our focus stealing prevention is still mostly inherited from metacity; in particular, a (non-transient) window that is not on the current workspace will not be given focus. This behavior made sense in the GNOME 2 days, where workspaces were separated much more strictly. However this is no longer the case in GNOME 3 - activating a launcher will switch workspaces if necessary, and so will the app switcher. There is no good reason to not do the same for other user actions like clicking a URL or activating a search result, so allow activation of windows on non-active workspaces if a proper timestamp is supplied, assuming that this is a strong enough indication that we are dealing with a legitimate user action. https://bugzilla.gnome.org/show_bug.cgi?id=728018
2014-04-11 11:52:55 +00:00
gboolean allow_workspace_switch;
window: Emit an error and return when trying to activate an unmanaged If something (i.e. gnome-shell or an extension) tries to activate an unmanaged window, we should warn about this and avoid to perform further actions as this could lead to a crash of mutter, since the window has not valid flags (like workspace) set anymore at this stage. Fixes https://gitlab.gnome.org/GNOME/mutter/issues/580 https://gitlab.gnome.org/GNOME/mutter/merge_requests/564
2019-05-03 18:10:47 +00:00
if (window->unmanaging)
{
g_warning ("Trying to activate unmanaged window '%s'", window->desc);
return;
}
Big patch to cover about 6 different issues in order to correct rare 2005-02-20 Elijah Newren <newren@gmail.com> Big patch to cover about 6 different issues in order to correct rare problems with timestamps (make sure window selected in tasklist actually gets focus, sanity check timestamps to avoid rogue apps hosing the system, correct the updating of net_wm_user_time, correctly handle timestamps of 0 when comparing xserver timestamps for those who have had their systems up for over 25 days or so, add some debugging information to verbose logs, some code cleanups). Fixes all issues listed in #167358. * src/display.h: (struct _MetaDisplay): clarify comment on last_focus_time, introduce a new variable--last_user_time, (XSERVER_TIME_IS_BEFORE macro): put this functionality into a separate macro and then introduce a new macro with this name that uses the old one but adds additional special-case checks for timestamps that are 0, (comment to meta_display_set_input_focus_window): add information about how last_user_time should be used in this function * src/display.c (santiy_check_timestamps): new function, (meta_display_open): intialize display->last_user_time, (meta_display_get_current_time_roundtrip): use the timestamp, which is known to be good, in order to sanity_check_timestamps, (event_callback): use the new meta_window_ste_user_time() function in order to correct problems, use the timestamp of KeyPress and ButtonPress events, which are known to be good, in order to sanity_check_timestamps, (timestamp_too_old): new function for common behavior of meta_display_focus_the_no_focus_window and meta_display_set_input_focus_window, with added checking for display->last_user_time in addition to display->last_focus_time, (meta_display_set_input_focus_window): replace some of the code with a call to timestamp_too_old(), (meta_display_focus_the_no_focus_window): replace some of th ecode with a call to timestamp_too_old() * src/window.h: (meta_window_set_user_time): new function to abstract the many things that need to be done when updating the net_wm_user_time of any window * src/window.c: (meta_window_activate): add debugging spew, make sure the comparison is made with last_user_time NOT last_focus_time, use meta_window_set_user_time() function in order to correct problems, (meta_window_client_message): add a newline to a debugging message to make them easier to read, (meta_window_set_user_time): new function * src/window-props.c (reload_net_wm_user_time): use the new meta_window_ste_user_time() function in order to correct problems
2005-02-20 17:14:16 +00:00
meta_topic (META_DEBUG_FOCUS,
Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ 2006-09-13 Elijah Newren <newren gmail com> * src/common.h (MetaWindowMenuFunc): * src/core.[ch] (meta_core_user_lower_and_unfocus, meta_core_user_focus, meta_core_show_window_menu, meta_core_begin_grab_op, meta_core_end_grab_op): * src/delete.c (delete_ping_reply_func, delete_ping_timeout_func, meta_window_delete): * src/display.[ch] (struct MetaDisplay, struct MetaPingData, sanity_check_timestamps, meta_display_open, event_callback, meta_spew_event, meta_display_set_grab_op_cursor, meta_display_begin_grab_op, meta_display_end_grab_op, meta_display_ping_timeout, meta_display_ping_window, process_pong_message, timestamp_too_old, meta_display_set_input_focus_window): * src/keybindings.[ch] (grab_keyboard, ungrab_keyboard, meta_screen_grab_all_keys, meta_window_grab_all_keys, meta_window_ungrab_all_keys, error_on_generic_command, error_on_command, error_on_terminal_command): * src/metacity-dialog.c (on_realize, warn_about_no_sm_support, error_about_command, main): * src/screen.[ch] (struct _MetaScreen, meta_screen_new, meta_screen_show_desktop, meta_screen_apply_startup_properties): * src/session.c (warn_about_lame_clients_and_finish_interact): * src/window.[ch] (struct _MetaWindow, intervening_user_event_occurred, window_activate, meta_window_delete, meta_window_focus, meta_window_send_icccm_message, meta_window_client_message, menu_callback, meta_window_show_menu, struct EventScannerData, check_use_this_motion_notify, meta_window_begin_grab_op, meta_window_set_user_time): * src/workspace.[ch] (focus_ancestor_or_mru_window, meta_workspace_activate_with_focus, meta_workspace_activate, meta_workspace_focus_default_window, focus_ancestor_or_mru_window): Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ does) instead of Time. #348305
2006-09-13 16:32:33 +00:00
"_NET_ACTIVE_WINDOW message sent for %s at time %u "
More thorough handling of source indication. Part of #326041. 2006-01-09 Elijah Newren <newren@gmail.com> More thorough handling of source indication. Part of #326041. * src/window.c (window_activate): new function based off the old meta_window_activate but which also takes source indication into account, (meta_window_active): just call window_activate() with the necessary source indication to get the behavior wanted, (meta_window_client_message): check source indication too for _net_active_window messages * src/window.h (enum MetaClientType): convenience enum for source indication handling
2006-01-10 05:44:40 +00:00
"by client type %u.\n",
Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ 2006-09-13 Elijah Newren <newren gmail com> * src/common.h (MetaWindowMenuFunc): * src/core.[ch] (meta_core_user_lower_and_unfocus, meta_core_user_focus, meta_core_show_window_menu, meta_core_begin_grab_op, meta_core_end_grab_op): * src/delete.c (delete_ping_reply_func, delete_ping_timeout_func, meta_window_delete): * src/display.[ch] (struct MetaDisplay, struct MetaPingData, sanity_check_timestamps, meta_display_open, event_callback, meta_spew_event, meta_display_set_grab_op_cursor, meta_display_begin_grab_op, meta_display_end_grab_op, meta_display_ping_timeout, meta_display_ping_window, process_pong_message, timestamp_too_old, meta_display_set_input_focus_window): * src/keybindings.[ch] (grab_keyboard, ungrab_keyboard, meta_screen_grab_all_keys, meta_window_grab_all_keys, meta_window_ungrab_all_keys, error_on_generic_command, error_on_command, error_on_terminal_command): * src/metacity-dialog.c (on_realize, warn_about_no_sm_support, error_about_command, main): * src/screen.[ch] (struct _MetaScreen, meta_screen_new, meta_screen_show_desktop, meta_screen_apply_startup_properties): * src/session.c (warn_about_lame_clients_and_finish_interact): * src/window.[ch] (struct _MetaWindow, intervening_user_event_occurred, window_activate, meta_window_delete, meta_window_focus, meta_window_send_icccm_message, meta_window_client_message, menu_callback, meta_window_show_menu, struct EventScannerData, check_use_this_motion_notify, meta_window_begin_grab_op, meta_window_set_user_time): * src/workspace.[ch] (focus_ancestor_or_mru_window, meta_workspace_activate_with_focus, meta_workspace_activate, meta_workspace_focus_default_window, focus_ancestor_or_mru_window): Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ does) instead of Time. #348305
2006-09-13 16:32:33 +00:00
window->desc, timestamp, source_indication);
Big patch to cover about 6 different issues in order to correct rare 2005-02-20 Elijah Newren <newren@gmail.com> Big patch to cover about 6 different issues in order to correct rare problems with timestamps (make sure window selected in tasklist actually gets focus, sanity check timestamps to avoid rogue apps hosing the system, correct the updating of net_wm_user_time, correctly handle timestamps of 0 when comparing xserver timestamps for those who have had their systems up for over 25 days or so, add some debugging information to verbose logs, some code cleanups). Fixes all issues listed in #167358. * src/display.h: (struct _MetaDisplay): clarify comment on last_focus_time, introduce a new variable--last_user_time, (XSERVER_TIME_IS_BEFORE macro): put this functionality into a separate macro and then introduce a new macro with this name that uses the old one but adds additional special-case checks for timestamps that are 0, (comment to meta_display_set_input_focus_window): add information about how last_user_time should be used in this function * src/display.c (santiy_check_timestamps): new function, (meta_display_open): intialize display->last_user_time, (meta_display_get_current_time_roundtrip): use the timestamp, which is known to be good, in order to sanity_check_timestamps, (event_callback): use the new meta_window_ste_user_time() function in order to correct problems, use the timestamp of KeyPress and ButtonPress events, which are known to be good, in order to sanity_check_timestamps, (timestamp_too_old): new function for common behavior of meta_display_focus_the_no_focus_window and meta_display_set_input_focus_window, with added checking for display->last_user_time in addition to display->last_focus_time, (meta_display_set_input_focus_window): replace some of the code with a call to timestamp_too_old(), (meta_display_focus_the_no_focus_window): replace some of th ecode with a call to timestamp_too_old() * src/window.h: (meta_window_set_user_time): new function to abstract the many things that need to be done when updating the net_wm_user_time of any window * src/window.c: (meta_window_activate): add debugging spew, make sure the comparison is made with last_user_time NOT last_focus_time, use meta_window_set_user_time() function in order to correct problems, (meta_window_client_message): add a newline to a debugging message to make them easier to read, (meta_window_set_user_time): new function * src/window-props.c (reload_net_wm_user_time): use the new meta_window_ste_user_time() function in order to correct problems
2005-02-20 17:14:16 +00:00
window: Allow activation on non-active workspaces with proper timestamps Our focus stealing prevention is still mostly inherited from metacity; in particular, a (non-transient) window that is not on the current workspace will not be given focus. This behavior made sense in the GNOME 2 days, where workspaces were separated much more strictly. However this is no longer the case in GNOME 3 - activating a launcher will switch workspaces if necessary, and so will the app switcher. There is no good reason to not do the same for other user actions like clicking a URL or activating a search result, so allow activation of windows on non-active workspaces if a proper timestamp is supplied, assuming that this is a strong enough indication that we are dealing with a legitimate user action. https://bugzilla.gnome.org/show_bug.cgi?id=728018
2014-04-11 11:52:55 +00:00
allow_workspace_switch = (timestamp != 0);
window: Treat CurrentTime as legal timestamp in activation Effectively we have been accepting CurrentTime timestamps for years, but still complained about "stupid pagers" when encountering them; just accept that we will never limit treating 0 timestamps as current time to pagers. https://bugzilla.gnome.org/show_bug.cgi?id=728018
2014-04-11 17:05:20 +00:00
if (timestamp != 0 &&
XSERVER_TIME_IS_BEFORE (timestamp, window->display->last_user_time))
If activation requests are too old, set the demands_attention hint instead 2005-02-06 Elijah Newren <newren@gmail.com> If activation requests are too old, set the demands_attention hint instead of actually activating. Thanks to Crispin Flowerday for the test case and for testing the patch. Fixes half of #166395. * src/window.c: (meta_window_activate): if the request came before the last focus time, set the demands attention hint instead
2005-02-06 16:52:26 +00:00
{
meta_topic (META_DEBUG_FOCUS,
Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ 2006-09-13 Elijah Newren <newren gmail com> * src/common.h (MetaWindowMenuFunc): * src/core.[ch] (meta_core_user_lower_and_unfocus, meta_core_user_focus, meta_core_show_window_menu, meta_core_begin_grab_op, meta_core_end_grab_op): * src/delete.c (delete_ping_reply_func, delete_ping_timeout_func, meta_window_delete): * src/display.[ch] (struct MetaDisplay, struct MetaPingData, sanity_check_timestamps, meta_display_open, event_callback, meta_spew_event, meta_display_set_grab_op_cursor, meta_display_begin_grab_op, meta_display_end_grab_op, meta_display_ping_timeout, meta_display_ping_window, process_pong_message, timestamp_too_old, meta_display_set_input_focus_window): * src/keybindings.[ch] (grab_keyboard, ungrab_keyboard, meta_screen_grab_all_keys, meta_window_grab_all_keys, meta_window_ungrab_all_keys, error_on_generic_command, error_on_command, error_on_terminal_command): * src/metacity-dialog.c (on_realize, warn_about_no_sm_support, error_about_command, main): * src/screen.[ch] (struct _MetaScreen, meta_screen_new, meta_screen_show_desktop, meta_screen_apply_startup_properties): * src/session.c (warn_about_lame_clients_and_finish_interact): * src/window.[ch] (struct _MetaWindow, intervening_user_event_occurred, window_activate, meta_window_delete, meta_window_focus, meta_window_send_icccm_message, meta_window_client_message, menu_callback, meta_window_show_menu, struct EventScannerData, check_use_this_motion_notify, meta_window_begin_grab_op, meta_window_set_user_time): * src/workspace.[ch] (focus_ancestor_or_mru_window, meta_workspace_activate_with_focus, meta_workspace_activate, meta_workspace_focus_default_window, focus_ancestor_or_mru_window): Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ does) instead of Time. #348305
2006-09-13 16:32:33 +00:00
"last_user_time (%u) is more recent; ignoring "
Big patch to cover about 6 different issues in order to correct rare 2005-02-20 Elijah Newren <newren@gmail.com> Big patch to cover about 6 different issues in order to correct rare problems with timestamps (make sure window selected in tasklist actually gets focus, sanity check timestamps to avoid rogue apps hosing the system, correct the updating of net_wm_user_time, correctly handle timestamps of 0 when comparing xserver timestamps for those who have had their systems up for over 25 days or so, add some debugging information to verbose logs, some code cleanups). Fixes all issues listed in #167358. * src/display.h: (struct _MetaDisplay): clarify comment on last_focus_time, introduce a new variable--last_user_time, (XSERVER_TIME_IS_BEFORE macro): put this functionality into a separate macro and then introduce a new macro with this name that uses the old one but adds additional special-case checks for timestamps that are 0, (comment to meta_display_set_input_focus_window): add information about how last_user_time should be used in this function * src/display.c (santiy_check_timestamps): new function, (meta_display_open): intialize display->last_user_time, (meta_display_get_current_time_roundtrip): use the timestamp, which is known to be good, in order to sanity_check_timestamps, (event_callback): use the new meta_window_ste_user_time() function in order to correct problems, use the timestamp of KeyPress and ButtonPress events, which are known to be good, in order to sanity_check_timestamps, (timestamp_too_old): new function for common behavior of meta_display_focus_the_no_focus_window and meta_display_set_input_focus_window, with added checking for display->last_user_time in addition to display->last_focus_time, (meta_display_set_input_focus_window): replace some of the code with a call to timestamp_too_old(), (meta_display_focus_the_no_focus_window): replace some of th ecode with a call to timestamp_too_old() * src/window.h: (meta_window_set_user_time): new function to abstract the many things that need to be done when updating the net_wm_user_time of any window * src/window.c: (meta_window_activate): add debugging spew, make sure the comparison is made with last_user_time NOT last_focus_time, use meta_window_set_user_time() function in order to correct problems, (meta_window_client_message): add a newline to a debugging message to make them easier to read, (meta_window_set_user_time): new function * src/window-props.c (reload_net_wm_user_time): use the new meta_window_ste_user_time() function in order to correct problems
2005-02-20 17:14:16 +00:00
" _NET_ACTIVE_WINDOW message.\n",
window->display->last_user_time);
mark a window as needing or not needing the user's attention use the new 2006-03-29 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (meta_window_set_demands_attention, meta_window_unset_demands_attention): mark a window as needing or not needing the user's attention * src/window.c (meta_window_show, window_activate, meta_window_focus, meta_window_configure_request, meta_window_client_message): use the new set/unset demands attention functions. Fixes #305822.
2006-03-29 18:43:22 +00:00
meta_window_set_demands_attention(window);
If activation requests are too old, set the demands_attention hint instead 2005-02-06 Elijah Newren <newren@gmail.com> If activation requests are too old, set the demands_attention hint instead of actually activating. Thanks to Crispin Flowerday for the test case and for testing the patch. Fixes half of #166395. * src/window.c: (meta_window_activate): if the request came before the last focus time, set the demands attention hint instead
2005-02-06 16:52:26 +00:00
return;
}
More thorough handling of source indication. Part of #326041. 2006-01-09 Elijah Newren <newren@gmail.com> More thorough handling of source indication. Part of #326041. * src/window.c (window_activate): new function based off the old meta_window_activate but which also takes source indication into account, (meta_window_active): just call window_activate() with the necessary source indication to get the behavior wanted, (meta_window_client_message): check source indication too for _net_active_window messages * src/window.h (enum MetaClientType): convenience enum for source indication handling
2006-01-10 05:44:40 +00:00
Partial audit to fix timestamp usage. One step towards fixing #355180; see 2006-09-18 Elijah Newren <newren gmail com> Partial audit to fix timestamp usage. One step towards fixing #355180; see important comments in that bug. * src/core.[ch] (meta_core_unshade, meta_core_shade): * src/delete.c (meta_window_present_delete_dialog, delete_ping_timeout_func): * src/display.[ch] (meta_display_open, meta_display_close, event_callback, meta_display_begin_grab_op, process_selection_clear, meta_display_unmanage_screen, meta_display_unmanage_windows_for_screen): * src/frames.c (meta_frames_button_press_event): * src/keybindings.c (handle_toggle_shade): * src/main.c (main): * src/screen.[ch] (update_num_workspaces, meta_screen_new, meta_screen_free, prefs_changed_callback): * src/window.[ch] (meta_window_free, finish_minimize, implement_showing, meta_window_show, meta_window_maximize, meta_window_make_fullscreen_internal, meta_window_unmake_fullscreen, meta_window_shade, meta_window_unshade, window_activate, send_sync_request, meta_window_client_message, menu_callback, meta_window_update_keyboard_resize): Remove usage of CurrentTime, meta_display_get_current_time() and meta_display_get_current_time_roundtrip() where possible, or document why it isn't possible, or at very least add a FIXME with some explanation of my laziness and what needs to be done.
2006-09-18 17:27:24 +00:00
if (timestamp == 0)
window: Treat CurrentTime as legal timestamp in activation Effectively we have been accepting CurrentTime timestamps for years, but still complained about "stupid pagers" when encountering them; just accept that we will never limit treating 0 timestamps as current time to pagers. https://bugzilla.gnome.org/show_bug.cgi?id=728018
2014-04-11 17:05:20 +00:00
timestamp = meta_display_get_current_time_roundtrip (window->display);
If we're not passed a timestamp, make sure to manually get one. Fixes 2005-02-08 Elijah Newren <newren@gmail.com> * src/window.c: (meta_window_activate): If we're not passed a timestamp, make sure to manually get one. Fixes #166728.
2005-02-09 03:15:11 +00:00
Big patch to cover about 6 different issues in order to correct rare 2005-02-20 Elijah Newren <newren@gmail.com> Big patch to cover about 6 different issues in order to correct rare problems with timestamps (make sure window selected in tasklist actually gets focus, sanity check timestamps to avoid rogue apps hosing the system, correct the updating of net_wm_user_time, correctly handle timestamps of 0 when comparing xserver timestamps for those who have had their systems up for over 25 days or so, add some debugging information to verbose logs, some code cleanups). Fixes all issues listed in #167358. * src/display.h: (struct _MetaDisplay): clarify comment on last_focus_time, introduce a new variable--last_user_time, (XSERVER_TIME_IS_BEFORE macro): put this functionality into a separate macro and then introduce a new macro with this name that uses the old one but adds additional special-case checks for timestamps that are 0, (comment to meta_display_set_input_focus_window): add information about how last_user_time should be used in this function * src/display.c (santiy_check_timestamps): new function, (meta_display_open): intialize display->last_user_time, (meta_display_get_current_time_roundtrip): use the timestamp, which is known to be good, in order to sanity_check_timestamps, (event_callback): use the new meta_window_ste_user_time() function in order to correct problems, use the timestamp of KeyPress and ButtonPress events, which are known to be good, in order to sanity_check_timestamps, (timestamp_too_old): new function for common behavior of meta_display_focus_the_no_focus_window and meta_display_set_input_focus_window, with added checking for display->last_user_time in addition to display->last_focus_time, (meta_display_set_input_focus_window): replace some of the code with a call to timestamp_too_old(), (meta_display_focus_the_no_focus_window): replace some of th ecode with a call to timestamp_too_old() * src/window.h: (meta_window_set_user_time): new function to abstract the many things that need to be done when updating the net_wm_user_time of any window * src/window.c: (meta_window_activate): add debugging spew, make sure the comparison is made with last_user_time NOT last_focus_time, use meta_window_set_user_time() function in order to correct problems, (meta_window_client_message): add a newline to a debugging message to make them easier to read, (meta_window_set_user_time): new function * src/window-props.c (reload_net_wm_user_time): use the new meta_window_ste_user_time() function in order to correct problems
2005-02-20 17:14:16 +00:00
meta_window_set_user_time (window, timestamp);
Revert Rob's 2004-07-31 patch that ignored net_wm_user_time when 2004-08-07 Elijah Newren <newren@math.utah.edu> * window.c, window.h: Revert Rob's 2004-07-31 patch that ignored net_wm_user_time when unminimizing a window * window.c (meta_window_activate): If a nonzero timestamp is passed, update the window's net_wm_user_time accordingly. (see comments 102-108 of bug 118372)
2004-08-08 00:02:02 +00:00
remove caveats about keybindings 2002-04-28 Havoc Pennington <hp@pobox.com> * README: remove caveats about keybindings * src/metacity.schemas: add schemas for all the keybindings. * src/window.c (meta_window_activate): if in "show desktop" mode when a window is activated, leave show desktop mode. So e.g. when you click on a task in the task list, show desktop mode will be turned off. * src/workspace.c (meta_workspace_get_neighbor): new function that doesn't quite work yet (needs support for getting workspace layout from the pager) * src/prefs.c: keybindings stuff * src/keybindings.c: make keybindings configurable * src/ui.c (meta_ui_parse_accelerator): new function
2002-04-28 04:52:26 +00:00
/* disable show desktop mode unless we're a desktop component */
fill in window->desc sooner since we use it sooner now. 2003-05-16 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_new): fill in window->desc sooner since we use it sooner now. * src/display.c (meta_display_open): init display->grab_update_alarm * src/window.c (meta_window_new): initialize the always_sticky field (meta_window_new): initialize the update_icon_queued field Patch from Julien Olivier bug #92335 for converting "show desktop mode" to "all windows are minimized" when you open a new window, instead of just mapping all the windows again. * src/window.c (meta_window_activate): minimize all windows before coming out of show desktop mode. (meta_window_unminimize): don't toggle show desktop mode here * src/screen.c (meta_screen_minimize_all_except): new function
2003-05-16 21:59:08 +00:00
maybe_leave_show_desktop_mode (window);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Patch from Vytautas Liuolia to react to _NET_STARTUP_ID changes, as 2006-08-07 Elijah Newren <newren gmail com> Patch from Vytautas Liuolia to react to _NET_STARTUP_ID changes, as proposed for the new startup-notification/EWMH spec. #347515 * src/window-props.c (reload_net_startup_id): be sure to act on the new id instead of just recording it * src/window.[ch] (window_activate, meta_window_activate, meta_window_activate_with_workspace, meta_window_client_message): change window_activate() to take a workspace parameter instead of hardcoding to the current workspace, add meta_window_activate_with_workspace() function needed by reload_net_startup_id().
2006-08-07 18:08:27 +00:00
/* Get window on current or given workspace */
if (workspace == NULL)
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
workspace = workspace_manager->active_workspace;
windows which attempt to present themselves but are offscreen end up * src/core/window.c: windows which attempt to present themselves but are offscreen end up demanding attention, unless they are transient, when they move to the current workspace as before. Closes #482354. svn path=/trunk/; revision=4060
2008-12-21 05:35:30 +00:00
Added MetaWindow::fullscreen property (read only).
2009-03-17 12:27:13 +00:00
/* For non-transient windows, we just set up a pulsing indicator,
windows which attempt to present themselves but are offscreen end up * src/core/window.c: windows which attempt to present themselves but are offscreen end up demanding attention, unless they are transient, when they move to the current workspace as before. Closes #482354. svn path=/trunk/; revision=4060
2008-12-21 05:35:30 +00:00
rather than move windows or workspaces.
See http://bugzilla.gnome.org/show_bug.cgi?id=482354 */
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
if (window->transient_for == NULL &&
window: Allow activation on non-active workspaces with proper timestamps Our focus stealing prevention is still mostly inherited from metacity; in particular, a (non-transient) window that is not on the current workspace will not be given focus. This behavior made sense in the GNOME 2 days, where workspaces were separated much more strictly. However this is no longer the case in GNOME 3 - activating a launcher will switch workspaces if necessary, and so will the app switcher. There is no good reason to not do the same for other user actions like clicking a URL or activating a search result, so allow activation of windows on non-active workspaces if a proper timestamp is supplied, assuming that this is a strong enough indication that we are dealing with a legitimate user action. https://bugzilla.gnome.org/show_bug.cgi?id=728018
2014-04-11 11:52:55 +00:00
!allow_workspace_switch &&
windows which attempt to present themselves but are offscreen end up * src/core/window.c: windows which attempt to present themselves but are offscreen end up demanding attention, unless they are transient, when they move to the current workspace as before. Closes #482354. svn path=/trunk/; revision=4060
2008-12-21 05:35:30 +00:00
!meta_window_located_on_workspace (window, workspace))
{
meta_window_set_demands_attention (window);
/* We've marked it as demanding, don't need to do anything else. */
return;
}
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
else if (window->transient_for != NULL)
windows which attempt to present themselves but are offscreen end up * src/core/window.c: windows which attempt to present themselves but are offscreen end up demanding attention, unless they are transient, when they move to the current workspace as before. Closes #482354. svn path=/trunk/; revision=4060
2008-12-21 05:35:30 +00:00
{
Added MetaWindow::fullscreen property (read only).
2009-03-17 12:27:13 +00:00
/* Move transients to current workspace - preference dialogs should appear over
windows which attempt to present themselves but are offscreen end up * src/core/window.c: windows which attempt to present themselves but are offscreen end up demanding attention, unless they are transient, when they move to the current workspace as before. Closes #482354. svn path=/trunk/; revision=4060
2008-12-21 05:35:30 +00:00
the source window. */
window: Allow activation on non-active workspaces with proper timestamps Our focus stealing prevention is still mostly inherited from metacity; in particular, a (non-transient) window that is not on the current workspace will not be given focus. This behavior made sense in the GNOME 2 days, where workspaces were separated much more strictly. However this is no longer the case in GNOME 3 - activating a launcher will switch workspaces if necessary, and so will the app switcher. There is no good reason to not do the same for other user actions like clicking a URL or activating a search result, so allow activation of windows on non-active workspaces if a proper timestamp is supplied, assuming that this is a strong enough indication that we are dealing with a legitimate user action. https://bugzilla.gnome.org/show_bug.cgi?id=728018
2014-04-11 11:52:55 +00:00
meta_window_change_workspace (window, workspace);
windows which attempt to present themselves but are offscreen end up * src/core/window.c: windows which attempt to present themselves but are offscreen end up demanding attention, unless they are transient, when they move to the current workspace as before. Closes #482354. svn path=/trunk/; revision=4060
2008-12-21 05:35:30 +00:00
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
grab buttons 2 and 3 also, so you can focus a window with those, #70840 002-02-08 Havoc Pennington <hp@pobox.com> * src/display.c (meta_display_grab_focus_window_button): grab buttons 2 and 3 also, so you can focus a window with those, #70840 (event_callback): fix this to let you focus a window with any unmodified click, and also with Alt+button1 * configure.in (AC_OUTPUT): add po/Makefile.in * autogen.sh: port to glib-gettextize, remove stupid auto-find-subdirs crap * Makefile.am (SUBDIRS): add po to subdirs, #70615 * src/window.c (meta_window_activate): unshaded window if shaded, I thought this was in bugzilla but I don't see it. anyway thanks whoever mentioned it to me.
2002-02-08 06:50:09 +00:00
if (window->shaded)
Partial audit to fix timestamp usage. One step towards fixing #355180; see 2006-09-18 Elijah Newren <newren gmail com> Partial audit to fix timestamp usage. One step towards fixing #355180; see important comments in that bug. * src/core.[ch] (meta_core_unshade, meta_core_shade): * src/delete.c (meta_window_present_delete_dialog, delete_ping_timeout_func): * src/display.[ch] (meta_display_open, meta_display_close, event_callback, meta_display_begin_grab_op, process_selection_clear, meta_display_unmanage_screen, meta_display_unmanage_windows_for_screen): * src/frames.c (meta_frames_button_press_event): * src/keybindings.c (handle_toggle_shade): * src/main.c (main): * src/screen.[ch] (update_num_workspaces, meta_screen_new, meta_screen_free, prefs_changed_callback): * src/window.[ch] (meta_window_free, finish_minimize, implement_showing, meta_window_show, meta_window_maximize, meta_window_make_fullscreen_internal, meta_window_unmake_fullscreen, meta_window_shade, meta_window_unshade, window_activate, send_sync_request, meta_window_client_message, menu_callback, meta_window_update_keyboard_resize): Remove usage of CurrentTime, meta_display_get_current_time() and meta_display_get_current_time_roundtrip() where possible, or document why it isn't possible, or at very least add a FIXME with some explanation of my laziness and what needs to be done.
2006-09-18 17:27:24 +00:00
meta_window_unshade (window, timestamp);
note exciting new unminimize feature for the tab popup 2001-10-29 Havoc Pennington <hp@pobox.com> * README: note exciting new unminimize feature for the tab popup * src/keybindings.c (process_tab_grab): use meta_window_activate() when choosing a window with tab popup, this should deiconify it * src/window.c (meta_window_client_message): use meta_window_activate for _NET_ACTIVE_WINDOW message (meta_window_activate): new function to raise/focus/unminimize (meta_window_flush_calc_showing): new function (meta_window_focus): force a calc showing on focus, so that we can focus the window if appropriate (it must be mapped)
2001-10-29 07:00:46 +00:00
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
unminimize_window_and_all_transient_parents (window);
Add a raise on click option, basically only because all the major distros 2006-01-10 Elijah Newren <newren@gmail.com> Add a raise on click option, basically only because all the major distros are patching it in anyway. See #326156. * src/metacity.schemas.in: add the new gconf key and explanation * src/prefs.[ch] (#define KEY_RAISE_ON_CLICK, static gboolean raise_on_click, update_raise_on_click, meta_prefs_init, change_notify, meta_prefs_get_raise_on_click, meta_preference_to_string): Add all the normal preference handling stuff for this new raise-on-click option. * src/core.c (meta_core_show_window_menu): * src/display.c (event_callback, meta_display_begin_grab_op): * src/window.c (window_activate, meta_window_configure_request, ): Only raise the window if in raise_on_click mode. * src/display.c (meta_display_begin_grab_op, meta_display_end_grab_op, meta_display_check_threshold_reached): * src/display.h (struct MetaDisplay): * src/window.c (meta_window_handle_mouse_grab_op_event): if not in raise-on-click mode only raise on button release if the click didn't start a move or resize operation; needs a few extra MetaDisplay fields to handle this * src/core.c (meta_core_user_lower_and_unfocus): no need to do the MRU shuffling if not maintaining the stacking order == MRU order invariant * src/frames.c (meta_frames_button_press_event): * src/window.c (meta_window_begin_grab_op): remove an unneeded window raising that is already handled elsewhere
2006-01-10 19:35:03 +00:00
if (meta_prefs_get_raise_on_click () ||
source_indication == META_CLIENT_TYPE_PAGER)
meta_window_raise (window);
revert the patch from #128380--change _NET_ACTIVE_WINDOW behavior to what 2005-07-23 Elijah Newren <newren@gmail.com> * src/window.c: (meta_window_activate): revert the patch from #128380--change _NET_ACTIVE_WINDOW behavior to what it originally was.
2005-07-24 01:13:41 +00:00
meta_topic (META_DEBUG_FOCUS,
"Focusing window %s due to activation\n",
window->desc);
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
window: Allow activation on non-active workspaces with proper timestamps Our focus stealing prevention is still mostly inherited from metacity; in particular, a (non-transient) window that is not on the current workspace will not be given focus. This behavior made sense in the GNOME 2 days, where workspaces were separated much more strictly. However this is no longer the case in GNOME 3 - activating a launcher will switch workspaces if necessary, and so will the app switcher. There is no good reason to not do the same for other user actions like clicking a URL or activating a search result, so allow activation of windows on non-active workspaces if a proper timestamp is supplied, assuming that this is a strong enough indication that we are dealing with a legitimate user action. https://bugzilla.gnome.org/show_bug.cgi?id=728018
2014-04-11 11:52:55 +00:00
if (meta_window_located_on_workspace (window, workspace))
meta_window_focus (window, timestamp);
else
meta_workspace_activate_with_focus (window->workspace, window, timestamp);
note exciting new unminimize feature for the tab popup 2001-10-29 Havoc Pennington <hp@pobox.com> * README: note exciting new unminimize feature for the tab popup * src/keybindings.c (process_tab_grab): use meta_window_activate() when choosing a window with tab popup, this should deiconify it * src/window.c (meta_window_client_message): use meta_window_activate for _NET_ACTIVE_WINDOW message (meta_window_activate): new function to raise/focus/unminimize (meta_window_flush_calc_showing): new function (meta_window_focus): force a calc showing on focus, so that we can focus the window if appropriate (it must be mapped)
2001-10-29 07:00:46 +00:00
}
...
2001-06-11 03:24:20 +00:00
More thorough handling of source indication. Part of #326041. 2006-01-09 Elijah Newren <newren@gmail.com> More thorough handling of source indication. Part of #326041. * src/window.c (window_activate): new function based off the old meta_window_activate but which also takes source indication into account, (meta_window_active): just call window_activate() with the necessary source indication to get the behavior wanted, (meta_window_client_message): check source indication too for _net_active_window messages * src/window.h (enum MetaClientType): convenience enum for source indication handling
2006-01-10 05:44:40 +00:00
/* This function exists since most of the functionality in window_activate
Comprehensively rename to Mutter Code: All references in the code not related to themes, keybindings, or GConf were changed from 'metacity' to 'mutter'. This includes, among other things, strings, comments, the atoms used in the message protocol, and the envvars used for debugging. The GConf schema file was reduced to the 3 settings new to mutter. The overall version was brought up to 2.27 to match current gnome. Structure: All files named '*metacity*' were renamed '*mutter*' with appropriate changes in the automake system. Files removed are doc/creating_themes, src/themes, doc/metacity-theme.dtd, metacity.doap. These files will eventually end up in an external gnome-wm-data module. Installation location: On the filesystem the mutter-plugindir was change from $(libdir)/metacity/plugins/clutter to just $(libdir)/mutter/plugins. The mutter-plugins.pc.in reflects these changes. Note: mutter.desktop.in and mutter-wm.desktop both continue to have X-GNOME-WMSettingsModule=metacity set. This allows gnome-control-center to continue using libmetacity.so for configuration. This is fine since most the general keybindings and wm settings are being read from /apps/metacity/* in gconf.
2009-06-10 10:29:20 +00:00
* is useful for Mutter, but Mutter shouldn't need to specify a client
More thorough handling of source indication. Part of #326041. 2006-01-09 Elijah Newren <newren@gmail.com> More thorough handling of source indication. Part of #326041. * src/window.c (window_activate): new function based off the old meta_window_activate but which also takes source indication into account, (meta_window_active): just call window_activate() with the necessary source indication to get the behavior wanted, (meta_window_client_message): check source indication too for _net_active_window messages * src/window.h (enum MetaClientType): convenience enum for source indication handling
2006-01-10 05:44:40 +00:00
* type for itself. ;-)
*/
void
meta_window_activate (MetaWindow *window,
guint32 timestamp)
{
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
More thorough handling of source indication. Part of #326041. 2006-01-09 Elijah Newren <newren@gmail.com> More thorough handling of source indication. Part of #326041. * src/window.c (window_activate): new function based off the old meta_window_activate but which also takes source indication into account, (meta_window_active): just call window_activate() with the necessary source indication to get the behavior wanted, (meta_window_client_message): check source indication too for _net_active_window messages * src/window.h (enum MetaClientType): convenience enum for source indication handling
2006-01-10 05:44:40 +00:00
/* We're not really a pager, but the behavior we want is the same as if
* we were such. If we change the pager behavior later, we could revisit
* this and just add extra flags to window_activate.
*/
Start moving X11-specific code to window-x11.c The goal here is to make MetaWindow represent a toplevel, managed window, regardless of if it's X11 or Wayland, and build an abstraction layer up. Right now, most of the X11 code is in core/ and the wayland code in wayland/, but in the future, I want to move a lot of the X11 code to a new toplevel, x11/.
2014-01-23 21:33:53 +00:00
meta_window_activate_full (window, timestamp, META_CLIENT_TYPE_PAGER, NULL);
Patch from Vytautas Liuolia to react to _NET_STARTUP_ID changes, as 2006-08-07 Elijah Newren <newren gmail com> Patch from Vytautas Liuolia to react to _NET_STARTUP_ID changes, as proposed for the new startup-notification/EWMH spec. #347515 * src/window-props.c (reload_net_startup_id): be sure to act on the new id instead of just recording it * src/window.[ch] (window_activate, meta_window_activate, meta_window_activate_with_workspace, meta_window_client_message): change window_activate() to take a workspace parameter instead of hardcoding to the current workspace, add meta_window_activate_with_workspace() function needed by reload_net_startup_id().
2006-08-07 18:08:27 +00:00
}
void
meta_window_activate_with_workspace (MetaWindow *window,
guint32 timestamp,
MetaWorkspace *workspace)
{
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
Start moving X11-specific code to window-x11.c The goal here is to make MetaWindow represent a toplevel, managed window, regardless of if it's X11 or Wayland, and build an abstraction layer up. Right now, most of the X11 code is in core/ and the wayland code in wayland/, but in the future, I want to move a lot of the X11 code to a new toplevel, x11/.
2014-01-23 21:33:53 +00:00
meta_window_activate_full (window, timestamp, META_CLIENT_TYPE_APPLICATION, workspace);
More thorough handling of source indication. Part of #326041. 2006-01-09 Elijah Newren <newren@gmail.com> More thorough handling of source indication. Part of #326041. * src/window.c (window_activate): new function based off the old meta_window_activate but which also takes source indication into account, (meta_window_active): just call window_activate() with the necessary source indication to get the behavior wanted, (meta_window_client_message): check source indication too for _net_active_window messages * src/window.h (enum MetaClientType): convenience enum for source indication handling
2006-01-10 05:44:40 +00:00
}
Implement freezing of updates during resize Replace the unused meta_compositor_set_updates() with a reversed-meaning meta_compositor_set_updates_frozen(), and use it to implement freezing application window updates during interactive resizing. This avoids drawing new areas of the window with blank content before the application has a chance to repaint. https://bugzilla.gnome.org/show_bug.cgi?id=685463
2011-06-13 21:53:23 +00:00
/**
* meta_window_updates_are_frozen:
* @window: a #MetaWindow
*
* Gets whether the compositor should be updating the window contents;
* window content updates may be frozen at client request by setting
window: Fix typo in comment
2014-05-01 19:04:09 +00:00
* an odd value in the extended _NET_WM_SYNC_REQUEST_COUNTER counter
Implement freezing of updates during resize Replace the unused meta_compositor_set_updates() with a reversed-meaning meta_compositor_set_updates_frozen(), and use it to implement freezing application window updates during interactive resizing. This avoids drawing new areas of the window with blank content before the application has a chance to repaint. https://bugzilla.gnome.org/show_bug.cgi?id=685463
2011-06-13 21:53:23 +00:00
* by the window manager during a resize operation while waiting for
* the client to redraw.
*
* Return value: %TRUE if updates are currently frozen
*/
gboolean
meta_window_updates_are_frozen (MetaWindow *window)
{
window: Move out 'updates frozen' state into implementations Implementation of said state was just related to X11, so move it into window-x11.c. The Wayland path always fell back on the returning TRUE, so just do that for now. https://gitlab.gnome.org/GNOME/mutter/merge_requests/229
2018-09-14 17:03:38 +00:00
return META_WINDOW_GET_CLASS (window)->are_updates_frozen (window);
Implement freezing of updates during resize Replace the unused meta_compositor_set_updates() with a reversed-meaning meta_compositor_set_updates_frozen(), and use it to implement freezing application window updates during interactive resizing. This avoids drawing new areas of the window with blank content before the application has a chance to repaint. https://bugzilla.gnome.org/show_bug.cgi?id=685463
2011-06-13 21:53:23 +00:00
}
window: Keep windows with placement rule attached to parent A window placed using a placement rule should keep that relative position even if the parent window moves, as the position tied to the parent window, not to the stage. Thus, if the parent window moves, the child window should move with it. In the implementation in this commit, the constraints engine is not used when repositioning the children; the window is simply positioned according to the effective placement rule that was derived from the initial constraining, as the a xdg_popup at the moment cannot move (relative its parent) after being mapped. Closes: https://gitlab.gnome.org/GNOME/mutter/issues/274
2018-08-22 19:54:16 +00:00
static void
meta_window_reposition (MetaWindow *window)
{
meta_window_move_resize_internal (window,
(META_MOVE_RESIZE_MOVE_ACTION |
META_MOVE_RESIZE_RESIZE_ACTION),
NorthWestGravity,
window->rect);
}
Optionally attach modal dialogs Add a preference /apps/mutter/general/attach_modal_dialogs. When true, instead of having independent titlebars, modal dialogs appear attached to the titlebar of the parent window and are moved together with the parent window. https://bugzilla.gnome.org/show_bug.cgi?id=612726
2010-09-10 09:55:20 +00:00
static gboolean
window: Keep windows with placement rule attached to parent A window placed using a placement rule should keep that relative position even if the parent window moves, as the position tied to the parent window, not to the stage. Thus, if the parent window moves, the child window should move with it. In the implementation in this commit, the constraints engine is not used when repositioning the children; the window is simply positioned according to the effective placement rule that was derived from the initial constraining, as the a xdg_popup at the moment cannot move (relative its parent) after being mapped. Closes: https://gitlab.gnome.org/GNOME/mutter/issues/274
2018-08-22 19:54:16 +00:00
maybe_move_attached_window (MetaWindow *window,
window: make determination of attached dialog windows more consistent Different bits of code were using slightly different checks to test whether a window was an attached dialog. Add a new meta_window_is_attached_dialog(), and use that everywhere. Also, freeze the is-attached status when the window is first shown, rather than recomputing it each time the caller asks, since this could cause problems if a window changes its type after it has already been attached, etc. However, if an attached window's parent is destroyed, or an attached window changes its transient-for, then fix things up by destroying the old MetaWindow and creating a new one (causing compositor unmap and map events to be fired off, allowing the display of the window to be fixed up). Remove some code in display.c that tried to fix existing windows if the gconf setting changed, but which didn't actually do anything (at least under gnome-shell). However, if 654643 was fixed then the new behavior with this patch would be that changing the gconf setting would affect new dialogs, but not existing ones. https://bugzilla.gnome.org/show_bug.cgi?id=646761
2011-04-05 14:14:52 +00:00
void *data)
Optionally attach modal dialogs Add a preference /apps/mutter/general/attach_modal_dialogs. When true, instead of having independent titlebars, modal dialogs appear attached to the titlebar of the parent window and are moved together with the parent window. https://bugzilla.gnome.org/show_bug.cgi?id=612726
2010-09-10 09:55:20 +00:00
{
window: Don't try to move hidden attached windows When a parent window is moved, attached windows (attached modal dialogs or popups) is moved with it. This is problematic when such a window hasn't been shown yet (e.g. a popup that has been configured but not shown), as it'll mean we try to constrain an empty window. Avoid this issue by not trying to auto-move empty windows. https://gitlab.gnome.org/GNOME/mutter/merge_requests/496
2019-03-15 16:10:38 +00:00
if (window->hidden)
window: Move all attached windows with parent We'd break the loop for moving attached windows at the first window, meaning we'd only ever move a single attached dialogs or popup if it was the first window in the list. This doesn't work out well when there are multiple popups open, so don't break out of the loop at all until all windows are potentially moved. This fixes an issue in gtk4 where one or more non-grabbing popups would end up unattached if there were more than one and the parent window was moved. https://gitlab.gnome.org/GNOME/mutter/merge_requests/592
2019-05-24 08:52:40 +00:00
return G_SOURCE_CONTINUE;
window: Don't try to move hidden attached windows When a parent window is moved, attached windows (attached modal dialogs or popups) is moved with it. This is problematic when such a window hasn't been shown yet (e.g. a popup that has been configured but not shown), as it'll mean we try to constrain an empty window. Avoid this issue by not trying to auto-move empty windows. https://gitlab.gnome.org/GNOME/mutter/merge_requests/496
2019-03-15 16:10:38 +00:00
window: Keep windows with placement rule attached to parent A window placed using a placement rule should keep that relative position even if the parent window moves, as the position tied to the parent window, not to the stage. Thus, if the parent window moves, the child window should move with it. In the implementation in this commit, the constraints engine is not used when repositioning the children; the window is simply positioned according to the effective placement rule that was derived from the initial constraining, as the a xdg_popup at the moment cannot move (relative its parent) after being mapped. Closes: https://gitlab.gnome.org/GNOME/mutter/issues/274
2018-08-22 19:54:16 +00:00
if (meta_window_is_attached_dialog (window) ||
meta_window_get_placement_rule (window))
meta_window_reposition (window);
Optionally attach modal dialogs Add a preference /apps/mutter/general/attach_modal_dialogs. When true, instead of having independent titlebars, modal dialogs appear attached to the titlebar of the parent window and are moved together with the parent window. https://bugzilla.gnome.org/show_bug.cgi?id=612726
2010-09-10 09:55:20 +00:00
window: Move all attached windows with parent We'd break the loop for moving attached windows at the first window, meaning we'd only ever move a single attached dialogs or popup if it was the first window in the list. This doesn't work out well when there are multiple popups open, so don't break out of the loop at all until all windows are potentially moved. This fixes an issue in gtk4 where one or more non-grabbing popups would end up unattached if there were more than one and the parent window was moved. https://gitlab.gnome.org/GNOME/mutter/merge_requests/592
2019-05-24 08:52:40 +00:00
return G_SOURCE_CONTINUE;
Optionally attach modal dialogs Add a preference /apps/mutter/general/attach_modal_dialogs. When true, instead of having independent titlebars, modal dialogs appear attached to the titlebar of the parent window and are moved together with the parent window. https://bugzilla.gnome.org/show_bug.cgi?id=612726
2010-09-10 09:55:20 +00:00
}
Add API to get the monitor of a window https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 14:21:35 +00:00
/**
* meta_window_get_monitor:
* @window: a #MetaWindow
*
* Gets index of the monitor that this window is on.
*
window: Return -1 if meta_window_get_monitor is called on an unmanaged window As opposed to crashing. In this case, letting the caller deal with it is the best policy, since this is public API. https://bugzilla.gnome.org/show_bug.cgi?id=788834
2017-10-10 16:39:40 +00:00
* Return Value: The index of the monitor in the screens monitor list, or -1
* if the window has been recently unmanaged and does not have a monitor.
Add API to get the monitor of a window https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 14:21:35 +00:00
*/
int
meta_window_get_monitor (MetaWindow *window)
{
window: Return -1 if meta_window_get_monitor is called on an unmanaged window As opposed to crashing. In this case, letting the caller deal with it is the best policy, since this is public API. https://bugzilla.gnome.org/show_bug.cgi?id=788834
2017-10-10 16:39:40 +00:00
if (!window->monitor)
return -1;
Add API to get the monitor of a window https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 14:21:35 +00:00
return window->monitor->number;
}
screen: Don't use monitor indices in check_fullscreen_func Rewrite check_fullscreen_func to not use indexes (and offset-index-as-pointer) tricks. This also removes the usage of an API constructing temporary logical monitor arrays carrying indices. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-12-02 07:38:08 +00:00
MetaLogicalMonitor *
meta_window_get_main_logical_monitor (MetaWindow *window)
{
return window->monitor;
}
Rename MetaMonitorInfo MetaLogicalMonitor In preparation for further refactorizations, rename the MetaMonitorInfo struct to MetaLogicalMonitor. Eventually, part of MetaLogicalMonitor will be split into a MetaMonitor type. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-25 06:31:38 +00:00
static MetaLogicalMonitor *
monitor-manager: Rename output_id to winsys_id The output_id is more of an opaque identifier for the monitor, based on its underlying ID from the windowing system. Since we also use the term "output_id" for the output's index, rename our use of the opaque cookie "output_id" to "winsys_id".
2014-07-01 17:23:05 +00:00
find_monitor_by_winsys_id (MetaWindow *window,
output: Turn winsys_id into a uint64_t We need a 64 bit field to combine the device id and connector id into the output id (winsys_id).
2018-10-17 14:55:18 +00:00
uint64_t winsys_id)
window: Keep track of preferred output Remember the last monitor a window was moved to by user action and try to move it back on monitor changes; this should match user expectations much better when a monitor is unplugged temporarily. https://bugzilla.gnome.org/show_bug.cgi?id=731760
2014-06-13 20:28:26 +00:00
{
MetaScreen: Remove redundant copy of logical monitors array It was just pointer to the actual list; having to synchronize a list of logical monitors with the actual monitors managed by the backend is unnecessary. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-28 12:11:24 +00:00
MetaBackend *backend = meta_get_backend ();
MetaMonitorManager *monitor_manager =
meta_backend_get_monitor_manager (backend);
monitor-manager: Store logical monitors in a GList Instead of storing the logical monitors in an array and having users either look up them in the array given an index or iterate using indices, put it in a GList, and use GList iterators when iterating and alternative API where array indices were previously used. This allows for more liberty regarding the type of the logical monitor. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-12-02 08:00:03 +00:00
GList *logical_monitors, *l;
MetaScreen: Remove redundant copy of logical monitors array It was just pointer to the actual list; having to synchronize a list of logical monitors with the actual monitors managed by the backend is unnecessary. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-28 12:11:24 +00:00
logical_monitors =
monitor-manager: Store logical monitors in a GList Instead of storing the logical monitors in an array and having users either look up them in the array given an index or iterate using indices, put it in a GList, and use GList iterators when iterating and alternative API where array indices were previously used. This allows for more liberty regarding the type of the logical monitor. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-12-02 08:00:03 +00:00
meta_monitor_manager_get_logical_monitors (monitor_manager);
window: Keep track of preferred output Remember the last monitor a window was moved to by user action and try to move it back on monitor changes; this should match user expectations much better when a monitor is unplugged temporarily. https://bugzilla.gnome.org/show_bug.cgi?id=731760
2014-06-13 20:28:26 +00:00
monitor-manager: Store logical monitors in a GList Instead of storing the logical monitors in an array and having users either look up them in the array given an index or iterate using indices, put it in a GList, and use GList iterators when iterating and alternative API where array indices were previously used. This allows for more liberty regarding the type of the logical monitor. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-12-02 08:00:03 +00:00
for (l = logical_monitors; l; l = l->next)
window: Keep track of preferred output Remember the last monitor a window was moved to by user action and try to move it back on monitor changes; this should match user expectations much better when a monitor is unplugged temporarily. https://bugzilla.gnome.org/show_bug.cgi?id=731760
2014-06-13 20:28:26 +00:00
{
monitor-manager: Store logical monitors in a GList Instead of storing the logical monitors in an array and having users either look up them in the array given an index or iterate using indices, put it in a GList, and use GList iterators when iterating and alternative API where array indices were previously used. This allows for more liberty regarding the type of the logical monitor. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-12-02 08:00:03 +00:00
MetaLogicalMonitor *logical_monitor = l->data;
window: Keep track of preferred output Remember the last monitor a window was moved to by user action and try to move it back on monitor changes; this should match user expectations much better when a monitor is unplugged temporarily. https://bugzilla.gnome.org/show_bug.cgi?id=731760
2014-06-13 20:28:26 +00:00
Rename MetaMonitorInfo MetaLogicalMonitor In preparation for further refactorizations, rename the MetaMonitorInfo struct to MetaLogicalMonitor. Eventually, part of MetaLogicalMonitor will be split into a MetaMonitor type. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-25 06:31:38 +00:00
if (logical_monitor->winsys_id == winsys_id)
return logical_monitor;
window: Keep track of preferred output Remember the last monitor a window was moved to by user action and try to move it back on monitor changes; this should match user expectations much better when a monitor is unplugged temporarily. https://bugzilla.gnome.org/show_bug.cgi?id=731760
2014-06-13 20:28:26 +00:00
}
return NULL;
}
When monitors change, keep windows on same output. If XRANDR is availible, we track the first (or primary) output per crtc (== xinerama monitor) so when the monitors change we can try to find the same output and move windows there. If we can't find the original monitor in the new set (or XRANDR is not supported) we move the window to the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=645408
2011-05-20 08:56:12 +00:00
/* This is called when the monitor setup has changed. The window->monitor
* reference is still "valid", but refer to the previous monitor setup */
Track the monitor for each window https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-25 15:37:05 +00:00
void
When monitors change, keep windows on same output. If XRANDR is availible, we track the first (or primary) output per crtc (== xinerama monitor) so when the monitors change we can try to find the same output and move windows there. If we can't find the original monitor in the new set (or XRANDR is not supported) we move the window to the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=645408
2011-05-20 08:56:12 +00:00
meta_window_update_for_monitors_changed (MetaWindow *window)
{
MetaScreen: Remove redundant copy of logical monitors array It was just pointer to the actual list; having to synchronize a list of logical monitors with the actual monitors managed by the backend is unnecessary. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-28 12:11:24 +00:00
MetaBackend *backend = meta_get_backend ();
MetaMonitorManager *monitor_manager =
meta_backend_get_monitor_manager (backend);
Rename MetaMonitorInfo MetaLogicalMonitor In preparation for further refactorizations, rename the MetaMonitorInfo struct to MetaLogicalMonitor. Eventually, part of MetaLogicalMonitor will be split into a MetaMonitor type. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-25 06:31:38 +00:00
const MetaLogicalMonitor *old, *new;
When monitors change, keep windows on same output. If XRANDR is availible, we track the first (or primary) output per crtc (== xinerama monitor) so when the monitors change we can try to find the same output and move windows there. If we can't find the original monitor in the new set (or XRANDR is not supported) we move the window to the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=645408
2011-05-20 08:56:12 +00:00
window: Keep track of fullscreen monitors directly Instead of keeping around array indexes, keep track of them by storing a pointer instead. This also changes from using an array (imitating the X11 behaviour) to more explicit storing. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 09:50:17 +00:00
if (meta_window_has_fullscreen_monitors (window))
meta_window_clear_fullscreen_monitors (window);
MetaWindow: Clear fullscreen monitors when monitors change The fullscreen monitors state is set given a set of xinerama monitor identification numbers. When the monitor configuration changes (e.g. by a hotplug event) these are no longer valid, and may point to uninitialized or unallocated data. Avoid accessing uninitialized/unallocated memory by clearing the fullscreen monitor state when the monitor configuration changes. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 08:13:21 +00:00
window: Properly update window->monitor for the desktop window We don't want to move the desktop window but we still need to update window->monitor or otherwise we'll be left with a pointer to invalid memory. https://bugzilla.gnome.org/show_bug.cgi?id=757148
2015-10-24 16:46:12 +00:00
if (window->override_redirect || window->type == META_WINDOW_DESKTOP)
window: Make sure override_redirect window have correct monitor info We need to update window->monitor on override_redirect windows as well, other wise they may end up with an invalid struct which triggers and assert when meta_window_is_monitor_sized is called. https://bugzilla.gnome.org/show_bug.cgi?id=702564
2013-06-24 07:49:44 +00:00
{
window: Pass flag to meta_window_update_monitor() instead of bool The bool determines whether the call was directly from a user operation or not. To add more state into the call without having to add more boolenas, change the boolean to a flag (so far with 'none' and 'user-op' as possible values). No functional changes were made. https://gitlab.gnome.org/GNOME/mutter/issues/192
2018-08-24 10:54:50 +00:00
meta_window_update_monitor (window,
window: Force update monitor on hot plugs Commit a3da4b8d5bd217c0262fd9361036877d155a300f changed updating of window monitors to always use take affect when it was done from a non-user operation. This could cause feed back loops when a non-user driven operation would trigger the changing of a monitor, which itself would trigger changing of the monitor again due to a window scale change. The reason for the change, was that when the window monitor changed due to a hot plug, if it didn't actually change, eventually the window monitor pointer would be pointing to freed memory. Instead of force updating the monitor on all non-user operations, just do it on hot plugs. This allows for the feedback loop preventing logic to still do what its supposed to do, without risking dangling pointers on hot plugs. Related: https://gitlab.gnome.org/GNOME/mutter/issues/189 Closes: https://gitlab.gnome.org/GNOME/mutter/issues/192
2018-08-24 10:56:31 +00:00
META_WINDOW_UPDATE_MONITOR_FLAGS_FORCE);
window: Assert we have an up to date monitor after they changed Add an assert that we don't have a MetaWindow::monitor pointer that points to an old MetaLogicalMonitor. After this, and the other monitors-changed callbacks have been called, the old MetaLogicalMonitor will be destoryed, thus if we didn't update the pointer here, we'll point to freed memory, and will eventually crash later on. https://gitlab.gnome.org/GNOME/mutter/merge_requests/929
2019-11-11 10:01:43 +00:00
goto out;
window: Make sure override_redirect window have correct monitor info We need to update window->monitor on override_redirect windows as well, other wise they may end up with an invalid struct which triggers and assert when meta_window_is_monitor_sized is called. https://bugzilla.gnome.org/show_bug.cgi?id=702564
2013-06-24 07:49:44 +00:00
}
When monitors change, keep windows on same output. If XRANDR is availible, we track the first (or primary) output per crtc (== xinerama monitor) so when the monitors change we can try to find the same output and move windows there. If we can't find the original monitor in the new set (or XRANDR is not supported) we move the window to the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=645408
2011-05-20 08:56:12 +00:00
old = window->monitor;
window: Keep track of preferred output Remember the last monitor a window was moved to by user action and try to move it back on monitor changes; this should match user expectations much better when a monitor is unplugged temporarily. https://bugzilla.gnome.org/show_bug.cgi?id=731760
2014-06-13 20:28:26 +00:00
/* Try the preferred output first */
monitor-manager: Rename output_id to winsys_id The output_id is more of an opaque identifier for the monitor, based on its underlying ID from the windowing system. Since we also use the term "output_id" for the output's index, rename our use of the opaque cookie "output_id" to "winsys_id".
2014-07-01 17:23:05 +00:00
new = find_monitor_by_winsys_id (window, window->preferred_output_winsys_id);
When monitors change, keep windows on same output. If XRANDR is availible, we track the first (or primary) output per crtc (== xinerama monitor) so when the monitors change we can try to find the same output and move windows there. If we can't find the original monitor in the new set (or XRANDR is not supported) we move the window to the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=645408
2011-05-20 08:56:12 +00:00
window: Keep track of preferred output Remember the last monitor a window was moved to by user action and try to move it back on monitor changes; this should match user expectations much better when a monitor is unplugged temporarily. https://bugzilla.gnome.org/show_bug.cgi?id=731760
2014-06-13 20:28:26 +00:00
/* Otherwise, try to find the old output on a new monitor */
window: Handle updating from no to no monitor When we received two hot plug events that both resulted in headless configuration, we tried to find a new window monitor given the old. That resulted in a null pointer dereference; avoid that by only trying to find the same monitor if there was an old one. https://bugzilla.gnome.org/show_bug.cgi?id=788607
2017-10-07 04:33:39 +00:00
if (old && !new)
monitor-manager: Rename output_id to winsys_id The output_id is more of an opaque identifier for the monitor, based on its underlying ID from the windowing system. Since we also use the term "output_id" for the output's index, rename our use of the opaque cookie "output_id" to "winsys_id".
2014-07-01 17:23:05 +00:00
new = find_monitor_by_winsys_id (window, old->winsys_id);
When monitors change, keep windows on same output. If XRANDR is availible, we track the first (or primary) output per crtc (== xinerama monitor) so when the monitors change we can try to find the same output and move windows there. If we can't find the original monitor in the new set (or XRANDR is not supported) we move the window to the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=645408
2011-05-20 08:56:12 +00:00
window: Keep track of preferred output Remember the last monitor a window was moved to by user action and try to move it back on monitor changes; this should match user expectations much better when a monitor is unplugged temporarily. https://bugzilla.gnome.org/show_bug.cgi?id=731760
2014-06-13 20:28:26 +00:00
/* Fall back to primary if everything else failed */
if (!new)
MetaMonitorManager: Track primary monitor by pointer instead of index Instead of keeping an index in an array to keep track of the current primary logical monitor, just keep a pointer instead. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-28 12:43:27 +00:00
new = meta_monitor_manager_get_primary_logical_monitor (monitor_manager);
When monitors change, keep windows on same output. If XRANDR is availible, we track the first (or primary) output per crtc (== xinerama monitor) so when the monitors change we can try to find the same output and move windows there. If we can't find the original monitor in the new set (or XRANDR is not supported) we move the window to the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=645408
2011-05-20 08:56:12 +00:00
window: Always update tile monitor number on hot plug Otherwise we'll end up crashing if we had two connected monitors, unplugged both, then replugged in a single one. Avoids the following error: #0 _g_log_abort () #1 g_logv () #2 g_log () #3 meta_monitor_manager_get_logical_monitor_from_number () #4 meta_window_get_work_area_for_monitor () #5 meta_window_get_tile_area () #6 constrain_maximization () #7 do_all_constraints () #8 meta_window_constrain () #9 meta_window_move_resize_internal () #10 meta_window_move_resize_frame () #11 meta_window_move_resize_now () #12 idle_move_resize () #13 call_idle_later () https://bugzilla.redhat.com/show_bug.cgi?id=1767703 https://gitlab.gnome.org/GNOME/mutter/merge_requests/912
2019-11-01 12:18:12 +00:00
if (window->tile_mode != META_TILE_NONE)
window: Handle being headless better This avoids updating state (such as position, size etc) when going headless. Eventually, when non-headless, things will be updated again, and not until then will we be able to update to a valid state. https://bugzilla.gnome.org/show_bug.cgi?id=730551
2017-08-18 06:21:11 +00:00
{
window: Always update tile monitor number on hot plug Otherwise we'll end up crashing if we had two connected monitors, unplugged both, then replugged in a single one. Avoids the following error: #0 _g_log_abort () #1 g_logv () #2 g_log () #3 meta_monitor_manager_get_logical_monitor_from_number () #4 meta_window_get_work_area_for_monitor () #5 meta_window_get_tile_area () #6 constrain_maximization () #7 do_all_constraints () #8 meta_window_constrain () #9 meta_window_move_resize_internal () #10 meta_window_move_resize_frame () #11 meta_window_move_resize_now () #12 idle_move_resize () #13 call_idle_later () https://bugzilla.redhat.com/show_bug.cgi?id=1767703 https://gitlab.gnome.org/GNOME/mutter/merge_requests/912
2019-11-01 12:18:12 +00:00
if (new)
window: Handle being headless better This avoids updating state (such as position, size etc) when going headless. Eventually, when non-headless, things will be updated again, and not until then will we be able to update to a valid state. https://bugzilla.gnome.org/show_bug.cgi?id=730551
2017-08-18 06:21:11 +00:00
window->tile_monitor_number = new->number;
window: Always update tile monitor number on hot plug Otherwise we'll end up crashing if we had two connected monitors, unplugged both, then replugged in a single one. Avoids the following error: #0 _g_log_abort () #1 g_logv () #2 g_log () #3 meta_monitor_manager_get_logical_monitor_from_number () #4 meta_window_get_work_area_for_monitor () #5 meta_window_get_tile_area () #6 constrain_maximization () #7 do_all_constraints () #8 meta_window_constrain () #9 meta_window_move_resize_internal () #10 meta_window_move_resize_frame () #11 meta_window_move_resize_now () #12 idle_move_resize () #13 call_idle_later () https://bugzilla.redhat.com/show_bug.cgi?id=1767703 https://gitlab.gnome.org/GNOME/mutter/merge_requests/912
2019-11-01 12:18:12 +00:00
else
window->tile_monitor_number = -1;
}
window: Handle being headless better This avoids updating state (such as position, size etc) when going headless. Eventually, when non-headless, things will be updated again, and not until then will we be able to update to a valid state. https://bugzilla.gnome.org/show_bug.cgi?id=730551
2017-08-18 06:21:11 +00:00
window: Always update tile monitor number on hot plug Otherwise we'll end up crashing if we had two connected monitors, unplugged both, then replugged in a single one. Avoids the following error: #0 _g_log_abort () #1 g_logv () #2 g_log () #3 meta_monitor_manager_get_logical_monitor_from_number () #4 meta_window_get_work_area_for_monitor () #5 meta_window_get_tile_area () #6 constrain_maximization () #7 do_all_constraints () #8 meta_window_constrain () #9 meta_window_move_resize_internal () #10 meta_window_move_resize_frame () #11 meta_window_move_resize_now () #12 idle_move_resize () #13 call_idle_later () https://bugzilla.redhat.com/show_bug.cgi?id=1767703 https://gitlab.gnome.org/GNOME/mutter/merge_requests/912
2019-11-01 12:18:12 +00:00
if (new && old)
{
window: Handle being headless better This avoids updating state (such as position, size etc) when going headless. Eventually, when non-headless, things will be updated again, and not until then will we be able to update to a valid state. https://bugzilla.gnome.org/show_bug.cgi?id=730551
2017-08-18 06:21:11 +00:00
/* This will eventually reach meta_window_update_monitor that
* will send leave/enter-monitor events. The old != new monitor
* check will always fail (due to the new logical_monitors set) so
* we will always send the events, even if the new and old monitor
* index is the same. That is right, since the enumeration of the
* monitors changed and the same index could be refereing
* to a different monitor. */
meta_window_move_between_rects (window,
window: Really force update monitor on hot plugs Commit 8d3e05305 ("window: Force update monitor on hot plugs") added the flag `META_WINDOW_UPDATE_MONITOR_FLAGS_FORCE` passed to `update_monitor()` from `update_for_monitors_changed()`. However, `update_for_monitors_changed()` may choose to call another code path to `move_between_rects()` and `meta_window_move_resize_internal()` eventually. As `meta_window_move_resize_internal()` does not use the "force" flag, we may still end up in case where the window->monitor is left unchanged. To avoid that problem, add a new `MetaMoveResizeFlags` that `update_for_monitors_changed()` can use to force the monitor update from `meta_window_move_resize_internal()`. Fixes: 8d3e05305 ("window: Force update monitor on hot plugs") Closes: https://gitlab.gnome.org/GNOME/mutter/issues/189
2018-11-06 12:35:31 +00:00
META_MOVE_RESIZE_FORCE_UPDATE_MONITOR,
window: Handle being headless better This avoids updating state (such as position, size etc) when going headless. Eventually, when non-headless, things will be updated again, and not until then will we be able to update to a valid state. https://bugzilla.gnome.org/show_bug.cgi?id=730551
2017-08-18 06:21:11 +00:00
&old->rect,
&new->rect);
}
else
{
window: Pass flag to meta_window_update_monitor() instead of bool The bool determines whether the call was directly from a user operation or not. To add more state into the call without having to add more boolenas, change the boolean to a flag (so far with 'none' and 'user-op' as possible values). No functional changes were made. https://gitlab.gnome.org/GNOME/mutter/issues/192
2018-08-24 10:54:50 +00:00
meta_window_update_monitor (window,
window: Force update monitor on hot plugs Commit a3da4b8d5bd217c0262fd9361036877d155a300f changed updating of window monitors to always use take affect when it was done from a non-user operation. This could cause feed back loops when a non-user driven operation would trigger the changing of a monitor, which itself would trigger changing of the monitor again due to a window scale change. The reason for the change, was that when the window monitor changed due to a hot plug, if it didn't actually change, eventually the window monitor pointer would be pointing to freed memory. Instead of force updating the monitor on all non-user operations, just do it on hot plugs. This allows for the feedback loop preventing logic to still do what its supposed to do, without risking dangling pointers on hot plugs. Related: https://gitlab.gnome.org/GNOME/mutter/issues/189 Closes: https://gitlab.gnome.org/GNOME/mutter/issues/192
2018-08-24 10:56:31 +00:00
META_WINDOW_UPDATE_MONITOR_FLAGS_FORCE);
window: Handle being headless better This avoids updating state (such as position, size etc) when going headless. Eventually, when non-headless, things will be updated again, and not until then will we be able to update to a valid state. https://bugzilla.gnome.org/show_bug.cgi?id=730551
2017-08-18 06:21:11 +00:00
}
window: Assert we have an up to date monitor after they changed Add an assert that we don't have a MetaWindow::monitor pointer that points to an old MetaLogicalMonitor. After this, and the other monitors-changed callbacks have been called, the old MetaLogicalMonitor will be destoryed, thus if we didn't update the pointer here, we'll point to freed memory, and will eventually crash later on. https://gitlab.gnome.org/GNOME/mutter/merge_requests/929
2019-11-11 10:01:43 +00:00
out:
g_assert (!window->monitor ||
g_list_find (meta_monitor_manager_get_logical_monitors (monitor_manager),
window->monitor));
When monitors change, keep windows on same output. If XRANDR is availible, we track the first (or primary) output per crtc (== xinerama monitor) so when the monitors change we can try to find the same output and move windows there. If we can't find the original monitor in the new set (or XRANDR is not supported) we move the window to the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=645408
2011-05-20 08:56:12 +00:00
}
window: Move meta_window_configure_notify to window-x11
2014-03-18 14:36:00 +00:00
void
window: Pass flag to meta_window_update_monitor() instead of bool The bool determines whether the call was directly from a user operation or not. To add more state into the call without having to add more boolenas, change the boolean to a flag (so far with 'none' and 'user-op' as possible values). No functional changes were made. https://gitlab.gnome.org/GNOME/mutter/issues/192
2018-08-24 10:54:50 +00:00
meta_window_update_monitor (MetaWindow *window,
MetaWindowUpdateMonitorFlags flags)
Track the monitor for each window https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-25 15:37:05 +00:00
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
Rename MetaMonitorInfo MetaLogicalMonitor In preparation for further refactorizations, rename the MetaMonitorInfo struct to MetaLogicalMonitor. Eventually, part of MetaLogicalMonitor will be split into a MetaMonitor type. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-25 06:31:38 +00:00
const MetaLogicalMonitor *old;
Add workspaces_only_on_primary preferences (default FALSE) This adds a preference that when enabled makes all windows not on the primary monitor be visible on all workspaces (i.e. not part of the workspace switching handling). https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 12:48:28 +00:00
old = window->monitor;
window: Pass flag to meta_window_update_monitor() instead of bool The bool determines whether the call was directly from a user operation or not. To add more state into the call without having to add more boolenas, change the boolean to a flag (so far with 'none' and 'user-op' as possible values). No functional changes were made. https://gitlab.gnome.org/GNOME/mutter/issues/192
2018-08-24 10:54:50 +00:00
META_WINDOW_GET_CLASS (window)->update_main_monitor (window, flags);
Add workspaces_only_on_primary preferences (default FALSE) This adds a preference that when enabled makes all windows not on the primary monitor be visible on all workspaces (i.e. not part of the workspace switching handling). https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 12:48:28 +00:00
if (old != window->monitor)
{
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
meta_window_on_all_workspaces_changed (window);
Add workspaces_only_on_primary preferences (default FALSE) This adds a preference that when enabled makes all windows not on the primary monitor be visible on all workspaces (i.e. not part of the workspace switching handling). https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 12:48:28 +00:00
window: Add user_op parameter to update_monitor() When workspaces-only-on-primary is set and a window is moved back to the primary, we also move it to the active workspace to avoid the confusion of a visible window suddenly disappearing when crossing the monitor border. However when the window is not actually moved by the user, preserving the workspace makes more sense - we already do this in some cases (e.g. when moving between primary monitors), but miss others (unplugging the previous monitor); just add an explicit user_op parameter as used elsewhere to cover all exceptions. https://bugzilla.gnome.org/show_bug.cgi?id=731760
2014-06-20 16:06:40 +00:00
/* If workspaces only on primary and we moved back to primary due to a user action,
* ensure that the window is now in that workspace. We do this because while
* the window is on a non-primary monitor it is always visible, so it would be
* very jarring if it disappeared when it crossed the monitor border.
Add workspaces_only_on_primary preferences (default FALSE) This adds a preference that when enabled makes all windows not on the primary monitor be visible on all workspaces (i.e. not part of the workspace switching handling). https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 12:48:28 +00:00
* The one time we want it to both change to the primary monitor and a non-active
* workspace is when dropping the window on some other workspace thumbnail directly.
* That should be handled by explicitly moving the window before changing the
window: Add user_op parameter to update_monitor() When workspaces-only-on-primary is set and a window is moved back to the primary, we also move it to the active workspace to avoid the confusion of a visible window suddenly disappearing when crossing the monitor border. However when the window is not actually moved by the user, preserving the workspace makes more sense - we already do this in some cases (e.g. when moving between primary monitors), but miss others (unplugging the previous monitor); just add an explicit user_op parameter as used elsewhere to cover all exceptions. https://bugzilla.gnome.org/show_bug.cgi?id=731760
2014-06-20 16:06:40 +00:00
* workspace.
Add workspaces_only_on_primary preferences (default FALSE) This adds a preference that when enabled makes all windows not on the primary monitor be visible on all workspaces (i.e. not part of the workspace switching handling). https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 12:48:28 +00:00
*/
window: Pass flag to meta_window_update_monitor() instead of bool The bool determines whether the call was directly from a user operation or not. To add more state into the call without having to add more boolenas, change the boolean to a flag (so far with 'none' and 'user-op' as possible values). No functional changes were made. https://gitlab.gnome.org/GNOME/mutter/issues/192
2018-08-24 10:54:50 +00:00
if (meta_prefs_get_workspaces_only_on_primary () &&
flags & META_WINDOW_UPDATE_MONITOR_FLAGS_USER_OP &&
Add workspaces_only_on_primary preferences (default FALSE) This adds a preference that when enabled makes all windows not on the primary monitor be visible on all workspaces (i.e. not part of the workspace switching handling). https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 12:48:28 +00:00
meta_window_is_on_primary_monitor (window) &&
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
workspace_manager->active_workspace != window->workspace)
meta_window_change_workspace (window, workspace_manager->active_workspace);
Add signals for when windows change monitors This is useful in order to track e.g. which windows are on the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 20:26:11 +00:00
wayland: Sync surface actor state when changing main monitor In order to switch to the correct surface actor scale given the monitor the surface is on, without relying on the client committing a new state given some other side effect, sync the surface actor state when the main monitor associated with the corresponding window changed. https://bugzilla.gnome.org/show_bug.cgi?id=744933
2015-03-03 03:13:05 +00:00
meta_window_main_monitor_changed (window, old);
window: Disallow maximization for windows that can't be maximized Windows that have minimum widths larger than the screen can't be maximized, even though we put them in a maximized state and allow users to do so: the window just won't change size and position. Fix this by simply not giving the option to maximize, like what happens for non-resizable windows. https://bugzilla.gnome.org/show_bug.cgi?id=643606
2012-03-13 03:18:03 +00:00
/* If we're changing monitors, we need to update the has_maximize_func flag,
* as the working area has changed. */
window: Fix build The proper function name is "meta_window_recalc_features"
2014-02-01 23:58:58 +00:00
meta_window_recalc_features (window);
Add workspaces_only_on_primary preferences (default FALSE) This adds a preference that when enabled makes all windows not on the primary monitor be visible on all workspaces (i.e. not part of the workspace switching handling). https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 12:48:28 +00:00
}
Track the monitor for each window https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-25 15:37:05 +00:00
}
window: Move move_resize_wayland to window-wayland.c The move/resize logic is still busted for top/left resizes... sigh.
2014-04-28 21:44:45 +00:00
void
Add support for _NET_MOVERESIZE_WINDOW. #344521. 2007-04-09 Elijah Newren <newren gmail com> Add support for _NET_MOVERESIZE_WINDOW. #344521. * src/display.c (handle_net_moveresize_window, event_callback): Remove handle_net_moveresize_window() and the call to it; this code was highly buggy, though to be fair it was never tested and had simply been put into the code in commented out form. * src/screen.c (set_supported_hint): add atom_net_moveresize_window * src/window.[ch]: (meta_window_configure_request, meta_window_move_resize_request): Split out the moving/resize part of the configure request and put it into meta_window_move_resize_request (meta_window_client_message): check for NET_MOVERESIZE_WINDOW messages and call meta_window_move_resize_request() with the appropriate parameters to handle them (meta_window_move_resize_internal): fix some of the big comment at this function -- it wasn't quite right, use the passed in gravity instead of window->size_hints.win_gravity when calling adjust_for_gravity() to make sure the correct adjustments are used. (meta_window_get_gravity_position, meta_window_get_geometry, meta_window_move_resize_request): add a gravity parameter to meta_window_get_gravity_position and have it use that gravity instead of window->size_hints.win_gravity svn path=/trunk/; revision=3186
2007-04-09 23:00:55 +00:00
meta_window_move_resize_internal (MetaWindow *window,
MetaMoveResizeFlags flags,
int gravity,
window: Refactor all move/resize operations to be in frame rect space For Wayland, we want to have everything possible in terms of the frame rect, or "window geometry" as the Wayland protocol calls it, in order to properly eliminate some flashing when changing states to fullscreen or similar. For this, we need to heavily refactor how the code is structured, and make it so that meta_window_move_resize_internal is specified in terms of the frame rect coordinate space, and transforming all entry points to meta_window_move_resize_internal. This is a big commit that's hard to tear apart. I tried to split it as best I can, but there's still just a large amount of changes that need to happen at once. Expect some regressions from this. Sorry for any temporary regression that this might cause.
2014-05-20 21:47:10 +00:00
MetaRectangle frame_rect)
...
2001-06-09 21:58:30 +00:00
{
window: Refactor all move/resize operations to be in frame rect space For Wayland, we want to have everything possible in terms of the frame rect, or "window geometry" as the Wayland protocol calls it, in order to properly eliminate some flashing when changing states to fullscreen or similar. For this, we need to heavily refactor how the code is structured, and make it so that meta_window_move_resize_internal is specified in terms of the frame rect coordinate space, and transforming all entry points to meta_window_move_resize_internal. This is a big commit that's hard to tear apart. I tried to split it as best I can, but there's still just a large amount of changes that need to happen at once. Expect some regressions from this. Sorry for any temporary regression that this might cause.
2014-05-20 21:47:10 +00:00
/* The rectangle here that's passed in *always* in "frame rect"
* coordinates. That means the position of the frame's visible bounds,
* with x and y being absolute (root window) coordinates.
*
* For an X11 framed window, the client window's server rectangle is
* inset from this rectangle by the frame's visible borders, and the
* frame window's server rectangle is outset by the invisible borders.
*
* For an X11 unframed window, the rectangle here directly matches
* the server's rectangle, since the visible and invisible borders
* are both 0.
*
* For an X11 CSD window, the client window's server rectangle is
* outset from this rectagle by the client-specified frame extents.
*
* For a Wayland window, this rectangle can simply be sent directly
* to the client.
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
*/
window: Refactor all move/resize operations to be in frame rect space For Wayland, we want to have everything possible in terms of the frame rect, or "window geometry" as the Wayland protocol calls it, in order to properly eliminate some flashing when changing states to fullscreen or similar. For this, we need to heavily refactor how the code is structured, and make it so that meta_window_move_resize_internal is specified in terms of the frame rect coordinate space, and transforming all entry points to meta_window_move_resize_internal. This is a big commit that's hard to tear apart. I tried to split it as best I can, but there's still just a large amount of changes that need to happen at once. Expect some regressions from this. Sorry for any temporary regression that this might cause.
2014-05-20 21:47:10 +00:00
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
MetaWindowActor: Go back to freezing affecting actor geometry We do, in fact, need freezing to affect window geometry, so that move-resize operations (such as an interactive resize from the left, or a resize of a popup centered by the application) occur atomically. So to make map effects work properly, only exclude the initial placement of a window from freezing. (In the future, we may want to consider whether pure moves of a window being done in response to a user drag should also be excluded from freezing.) Rename meta_window_sync_actor_position() to meta_window_sync_actor_geometry() for clarity. https://bugzilla.gnome.org/show_bug.cgi?id=693922
2013-02-16 02:27:00 +00:00
gboolean did_placement;
window: Rename the requested_rect to the unconstrained_rect The requested_rect is a strange name for it, because it's not actually the rect that the user or client requested all the time: in the case of a simple move or a simple resize, we calculate some of the fields ourselves. To the MetaWindow subclass implementations, it just means "the rect before we constrained it", so just use the name unconstrained_rect. This also makes it match the name of the MetaWindow field.
2014-05-21 17:59:13 +00:00
MetaRectangle unconstrained_rect;
MetaRectangle constrained_rect;
window: Initialize the result here The vfuncs simply |= their results into the result variable, so we need to make sure we start out with nothing.
2014-04-12 17:06:20 +00:00
MetaMoveResizeResultFlags result = 0;
window: Always sync window geometry on state change When a state changed, e.g. a window went from unfullscreen to fullscreen, always sync the window geometry, otherwise a compositor application (e.g. gnome-shell) might end up with an unfinished window state transition effect. Without always syncing, the compositor plugin will see a 'size-change' event, as a result of the state change, but if the size didn't change, it would never see the 'size-changed' event. If an effect, for example gnome-shell's fullscreen effect, is triggered on 'size-change' it might rely on the actual size change to not get stuck. This commit allows it to have this dependency. This fixes a bug where a fullscreen effect gets "stuck" when a window goes fullscreen without changing the window geometry. https://bugzilla.gnome.org/show_bug.cgi?id=780292
2017-03-20 05:49:34 +00:00
gboolean moved_or_resized = FALSE;
window: Pass flag to meta_window_update_monitor() instead of bool The bool determines whether the call was directly from a user operation or not. To add more state into the call without having to add more boolenas, change the boolean to a flag (so far with 'none' and 'user-op' as possible values). No functional changes were made. https://gitlab.gnome.org/GNOME/mutter/issues/192
2018-08-24 10:54:50 +00:00
MetaWindowUpdateMonitorFlags update_monitor_flags;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Avoid moving and resizing override-redirect windows Override-redirect windows should not be moved or resized by the window manager. - Mark override-redirect windows as already placed to avoid placing them when first shown. - Don't move-resize newly created override-redirect MetaWindow - Don't queue a resize on override-redirect windows when reading their WM_TRANSIENT_FOR hint. - Add g_return_if_fail (!window->override_redirect) to catch unexpected code paths that might result in override-redirect windows being moved or resized. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-15 22:25:07 +00:00
g_return_if_fail (!window->override_redirect);
wayland: implement resizing and maximization for wayland clients To properly resize clients, we need to send them configure events with the size we computed from the constraint system, and then check if the new size they ask is compatible with our expectation. Note that this does not handle interactive resizing yet, it merely makes the API calls work for wayland clients. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-03 10:00:29 +00:00
/* The action has to be a move, a resize or the wayland client
* acking our choice of size.
*/
window/wayland: Make .._wayland_move_resize() name more explanatory The intention of meta_window_wayland_move_resize() is to finish a move-resize requested previously, e.g. by a state change, or a interactive resize. Make the function name carry this intention, by renaming it to meta_window_wayland_finish_move_resize(). https://gitlab.gnome.org/GNOME/mutter/merge_requests/907
2018-10-22 14:41:12 +00:00
g_assert (flags & (META_MOVE_RESIZE_MOVE_ACTION |
META_MOVE_RESIZE_RESIZE_ACTION |
META_MOVE_RESIZE_WAYLAND_FINISH_MOVE_RESIZE));
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Revert "window: Move placement code from the constraints path" Window state like maximization and minimization should be preserved over restarts - in a patch review, this would qualify as "needs-work", so revert the cleanup until the issues are fixed. This reverts commit dc6decefb5cbd14d5ab059a59952fd96e86dc763.
2014-06-19 17:02:14 +00:00
did_placement = !window->placed && window->calc_placement;
guess if a window meant to be fullscreen, and if so put it in that state. 2002-05-29 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_move_resize_internal): guess if a window meant to be fullscreen, and if so put it in that state.
2002-05-29 04:14:15 +00:00
/* We don't need it in the idle queue anymore. */
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
meta_window_unqueue (window, META_QUEUE_MOVE_RESIZE);
Patch from Rob Adams addresses #95014 (placement issues), makes first fit 2003-02-23 Havoc Pennington <hp@pobox.com> Patch from Rob Adams addresses #95014 (placement issues), makes first fit algorithm "center tile", adds most code for per-xinerama workspaces (#86682) but disables it for now. * src/workspace.c (meta_workspace_get_work_area_for_xinerama) (meta_workspace_get_work_area_all_xineramas): new xinerama functions, maintain workspace->work_areas with a different work area for each xinerama. However for now all the work areas are the same, because haven't quite figured out how _NET_WM_STRUT is supposed to work * src/window.c: adapt to new meta_window_* xinerama APIs (meta_window_get_work_area_current_xinerama): new xinerama API (meta_window_get_work_area_for_xinerama): new xinerama API (constrain_position): be a bit more clever about which xinerama's work area we choose to use. * src/stack.c: adapt to new Xinerama API * src/screen.c (reload_xinerama_infos): invalidate all work areas (meta_screen_get_xinerama_for_rect): new function (meta_screen_window_intersects_xinerama): new function * src/place.c (find_first_fit): change to use "center tiling" (center a screen full of tiled windows, rather than aligning them top left). Adapt to new xinerama functions.
2003-02-23 17:09:46 +00:00
Rename MetaMoveResizeFlags items to fit with the theme Use a proper prefix, even if more wordy, instead of META_IS.
2014-12-15 21:28:47 +00:00
if ((flags & META_MOVE_RESIZE_RESIZE_ACTION) && (flags & META_MOVE_RESIZE_MOVE_ACTION))
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
{
window: Fix meta_window_move_resize_internal for the case of a sole ack When a Wayland window acks our arrangement and we don't really have anything to modify, we'll pass a sole flag of META_IS_WAYLAND_RESIZE to meta_window_move_resize_internal using a garbage rect. The existing code to calculate the new rectangle couldn't really handle this case, and so the garbage rectangle accidentally got stored. Revamp the flag checks to be more clear about it. This fixes the weird positioning issues that sometimes appear when resizing weston-terminal among others.
2014-07-14 21:00:01 +00:00
/* We're both moving and resizing. Just use the passed in rect. */
unconstrained_rect = frame_rect;
}
Rename MetaMoveResizeFlags items to fit with the theme Use a proper prefix, even if more wordy, instead of META_IS.
2014-12-15 21:28:47 +00:00
else if ((flags & META_MOVE_RESIZE_RESIZE_ACTION))
window: Fix meta_window_move_resize_internal for the case of a sole ack When a Wayland window acks our arrangement and we don't really have anything to modify, we'll pass a sole flag of META_IS_WAYLAND_RESIZE to meta_window_move_resize_internal using a garbage rect. The existing code to calculate the new rectangle couldn't really handle this case, and so the garbage rectangle accidentally got stored. Revamp the flag checks to be more clear about it. This fixes the weird positioning issues that sometimes appear when resizing weston-terminal among others.
2014-07-14 21:00:01 +00:00
{
/* If this is only a resize, then ignore the position given in
* the parameters and instead calculate the new position from
* resizing the old rectangle with the given gravity. */
window: Refactor all move/resize operations to be in frame rect space For Wayland, we want to have everything possible in terms of the frame rect, or "window geometry" as the Wayland protocol calls it, in order to properly eliminate some flashing when changing states to fullscreen or similar. For this, we need to heavily refactor how the code is structured, and make it so that meta_window_move_resize_internal is specified in terms of the frame rect coordinate space, and transforming all entry points to meta_window_move_resize_internal. This is a big commit that's hard to tear apart. I tried to split it as best I can, but there's still just a large amount of changes that need to happen at once. Expect some regressions from this. Sorry for any temporary regression that this might cause.
2014-05-20 21:47:10 +00:00
meta_rectangle_resize_with_gravity (&window->rect,
window: Rename the requested_rect to the unconstrained_rect The requested_rect is a strange name for it, because it's not actually the rect that the user or client requested all the time: in the case of a simple move or a simple resize, we calculate some of the fields ourselves. To the MetaWindow subclass implementations, it just means "the rect before we constrained it", so just use the name unconstrained_rect. This also makes it match the name of the MetaWindow field.
2014-05-21 17:59:13 +00:00
&unconstrained_rect,
window: Change meta_window_move_resize_internal to take a MetaRectangle We construct one anyway, and most callers already pass in a rectangle the long way around, so why not change the internal API?
2014-05-01 23:09:13 +00:00
gravity,
window: Refactor all move/resize operations to be in frame rect space For Wayland, we want to have everything possible in terms of the frame rect, or "window geometry" as the Wayland protocol calls it, in order to properly eliminate some flashing when changing states to fullscreen or similar. For this, we need to heavily refactor how the code is structured, and make it so that meta_window_move_resize_internal is specified in terms of the frame rect coordinate space, and transforming all entry points to meta_window_move_resize_internal. This is a big commit that's hard to tear apart. I tried to split it as best I can, but there's still just a large amount of changes that need to happen at once. Expect some regressions from this. Sorry for any temporary regression that this might cause.
2014-05-20 21:47:10 +00:00
frame_rect.width,
frame_rect.height);
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
}
Rename MetaMoveResizeFlags items to fit with the theme Use a proper prefix, even if more wordy, instead of META_IS.
2014-12-15 21:28:47 +00:00
else if ((flags & META_MOVE_RESIZE_MOVE_ACTION))
window: Allow passing garbage window sizes for move-only actions We'll just fix them up in meta_window_move_resize_internal.
2014-05-21 12:41:32 +00:00
{
window: Fix meta_window_move_resize_internal for the case of a sole ack When a Wayland window acks our arrangement and we don't really have anything to modify, we'll pass a sole flag of META_IS_WAYLAND_RESIZE to meta_window_move_resize_internal using a garbage rect. The existing code to calculate the new rectangle couldn't really handle this case, and so the garbage rectangle accidentally got stored. Revamp the flag checks to be more clear about it. This fixes the weird positioning issues that sometimes appear when resizing weston-terminal among others.
2014-07-14 21:00:01 +00:00
/* If this is only a move, then ignore the passed in size and
* just use the existing size of the window. */
unconstrained_rect.x = frame_rect.x;
unconstrained_rect.y = frame_rect.y;
window: Rename the requested_rect to the unconstrained_rect The requested_rect is a strange name for it, because it's not actually the rect that the user or client requested all the time: in the case of a simple move or a simple resize, we calculate some of the fields ourselves. To the MetaWindow subclass implementations, it just means "the rect before we constrained it", so just use the name unconstrained_rect. This also makes it match the name of the MetaWindow field.
2014-05-21 17:59:13 +00:00
unconstrained_rect.width = window->rect.width;
unconstrained_rect.height = window->rect.height;
window: Allow passing garbage window sizes for move-only actions We'll just fix them up in meta_window_move_resize_internal.
2014-05-21 12:41:32 +00:00
}
window/wayland: Make .._wayland_move_resize() name more explanatory The intention of meta_window_wayland_move_resize() is to finish a move-resize requested previously, e.g. by a state change, or a interactive resize. Make the function name carry this intention, by renaming it to meta_window_wayland_finish_move_resize(). https://gitlab.gnome.org/GNOME/mutter/merge_requests/907
2018-10-22 14:41:12 +00:00
else if ((flags & META_MOVE_RESIZE_WAYLAND_FINISH_MOVE_RESIZE))
window: Fix meta_window_move_resize_internal for the case of a sole ack When a Wayland window acks our arrangement and we don't really have anything to modify, we'll pass a sole flag of META_IS_WAYLAND_RESIZE to meta_window_move_resize_internal using a garbage rect. The existing code to calculate the new rectangle couldn't really handle this case, and so the garbage rectangle accidentally got stored. Revamp the flag checks to be more clear about it. This fixes the weird positioning issues that sometimes appear when resizing weston-terminal among others.
2014-07-14 21:00:01 +00:00
{
/* This is a Wayland buffer acking our size. The new rect is
* just the existing one we have. Ignore the passed-in rect
* completely. */
unconstrained_rect = window->rect;
}
else
g_assert_not_reached ();
window: Allow passing garbage window sizes for move-only actions We'll just fix them up in meta_window_move_resize_internal.
2014-05-21 12:41:32 +00:00
window: Rename the requested_rect to the unconstrained_rect The requested_rect is a strange name for it, because it's not actually the rect that the user or client requested all the time: in the case of a simple move or a simple resize, we calculate some of the fields ourselves. To the MetaWindow subclass implementations, it just means "the rect before we constrained it", so just use the name unconstrained_rect. This also makes it match the name of the MetaWindow field.
2014-05-21 17:59:13 +00:00
constrained_rect = unconstrained_rect;
window: Handle being headless better This avoids updating state (such as position, size etc) when going headless. Eventually, when non-headless, things will be updated again, and not until then will we be able to update to a valid state. https://bugzilla.gnome.org/show_bug.cgi?id=730551
2017-08-18 06:21:11 +00:00
if (flags & (META_MOVE_RESIZE_MOVE_ACTION | META_MOVE_RESIZE_RESIZE_ACTION) &&
window: Don't constrain an acked window geometry In Wayland, window configuration is asynchronous. Window geometry is constrained, the constrained geometry is sent to the client, and the client will adapt its surface and acknowledge the configuration. When acknowledged, we shouldn't reconstrain again, as that may invalidate the constraint calculated for the configured size. https://gitlab.gnome.org/GNOME/mutter/merge_requests/907
2019-07-05 15:45:39 +00:00
!(flags & META_MOVE_RESIZE_WAYLAND_FINISH_MOVE_RESIZE) &&
window: Handle being headless better This avoids updating state (such as position, size etc) when going headless. Eventually, when non-headless, things will be updated again, and not until then will we be able to update to a valid state. https://bugzilla.gnome.org/show_bug.cgi?id=730551
2017-08-18 06:21:11 +00:00
window->monitor)
wayland: implement resizing and maximization for wayland clients To properly resize clients, we need to send them configure events with the size we computed from the constraint system, and then check if the new size they ask is compatible with our expectation. Note that this does not handle interactive resizing yet, it merely makes the API calls work for wayland clients. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-03 10:00:29 +00:00
{
window: Clean up old_rect handling a tiny bit We need the old rect for two purposes: to find the x/y in a resize-only action, and to pass into the constraints code for nefarious purposes. The constraints code takes a frame rectangle, so we convert the original client rect into a frame rect, but never convert it back since it's unused for the rest of the function. Instead of playing games with the variables, just have two, separately-scoped variables. One is the client rect, the other is the frame rect.
2014-05-01 23:20:26 +00:00
MetaRectangle old_rect;
meta_window_get_frame_rect (window, &old_rect);
wayland: implement resizing and maximization for wayland clients To properly resize clients, we need to send them configure events with the size we computed from the constraint system, and then check if the new size they ask is compatible with our expectation. Note that this does not handle interactive resizing yet, it merely makes the API calls work for wayland clients. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-03 10:00:29 +00:00
meta_window_constrain (window,
flags,
gravity,
&old_rect,
window: Rename the requested_rect to the unconstrained_rect The requested_rect is a strange name for it, because it's not actually the rect that the user or client requested all the time: in the case of a simple move or a simple resize, we calculate some of the fields ourselves. To the MetaWindow subclass implementations, it just means "the rect before we constrained it", so just use the name unconstrained_rect. This also makes it match the name of the MetaWindow field.
2014-05-21 17:59:13 +00:00
&constrained_rect);
wayland: implement resizing and maximization for wayland clients To properly resize clients, we need to send them configure events with the size we computed from the constraint system, and then check if the new size they ask is compatible with our expectation. Note that this does not handle interactive resizing yet, it merely makes the API calls work for wayland clients. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-03 10:00:29 +00:00
}
Update constraints code to support the new _NET_WM_STRUT_PARTIAL EWMH 2003-06-10 Rob Adams <robadams@ucla.edu> Update constraints code to support the new _NET_WM_STRUT_PARTIAL EWMH draft specification. See #86682. Also, fix a bug involving work area invalidation on metacity startup. Fix for #108497. Finally, some minor fixes for full screen windows. * src/window.h: Add new MetaStruts structure to store strut rects for a window. Remove has_struts and do_not_cover flag, and support new MetaStruts instead of the four ints. * src/window.c (meta_window_new): change initialization to work with new struts. Also, move meta_window_update_struts call to after the workspaces are initialized to fix #108497. Remove do_not_cover and related code. (process_property_notify): add strut_partial (update_struts): change function name to meta_window_update_struts and expose in external MetaWindow API. Support partial width struts and the new strut rects. * src/workspace.h: add new GSLists containing pointers to all relevant struts for this workspace. * src/workspace.c (meta_workspace_new): initialize the list of strut rects for this workspace. (meta_workspace_free): free the strut rect lists (ensure_work_areas_validated): support new struts and new strut rect lists. Unleash the per-xinerama work areas. * src/constraints.c (get_outermost_onscreen_positions): Use the current window position along with the new per-workspace strut rects to compute the constraints that apply to a particular window. (constraint_hint_applies_func): don't do hints constraints on fullscreen windows (update_position_limits): for maximized windows use the work areas to set the position limits; for other windows rely on the struts constraints to be computed later in get_outermost_onscreen_positions (meta_window_constrain): don't apply aspect ratio hints to full screen windows * src/display.c (meta_display_open): add _NET_WM_STRUT_PARTIAL atom (meta_rectangle_equal): new helper function for MetaRectangles (event_queue_callback): #ifndef out if USE_GDK_DISPLAY not set to avoid compiler warning * src/display.h: add atom_net_wm_strut_partial, and add meta_rectangle_equal. * src/screen.c (meta_screen_rect_intersects_xinerama): change _window_intersects_ to _rect_intersects_ which is more useful now. (meta_screen_resize_func): update struts on windows with struts since struts are relative to the screen size, and this function is called when the screen size updates. * src/screen.h (meta_screen_rect_intersects_xinerama): change _window_intersects_ to _rect_intersects_ which is more useful now. * src/window-props.c (meta_display_init_window_prop_hooks): add hook for strut_partial * src/tools/metacity-window-demo.c: Support partial-width struts on the dock window tests for metacity testing purposes.
2003-06-26 03:09:38 +00:00
Revert "window: Move placement code from the constraints path" Window state like maximization and minimization should be preserved over restarts - in a patch review, this would qualify as "needs-work", so revert the cleanup until the issues are fixed. This reverts commit dc6decefb5cbd14d5ab059a59952fd96e86dc763.
2014-06-19 17:02:14 +00:00
/* If we did placement, then we need to save the position that the window
* was placed at to make sure that meta_window_move_resize_now places the
* window correctly.
*/
if (did_placement)
{
window: Only update the unconstrained rect when we actually moved/resized Since Wayland configures are more of a hint to the client than anything, we don't want to save the unconstrained rect when we're just hinting to the client that it should resize, since it could ignore us. This would get us stuck in a loop, since meta_window_move_resize_now would use the unconstrained_rect to resize, and we don't remove the resize from the queue if we have an outstanding request like that. This fixes a bunch of traffic / CPU usage when trying to resize weston-terminal.
2014-07-07 18:08:07 +00:00
unconstrained_rect.x = constrained_rect.x;
unconstrained_rect.y = constrained_rect.y;
Revert "window: Move placement code from the constraints path" Window state like maximization and minimization should be preserved over restarts - in a patch review, this would qualify as "needs-work", so revert the cleanup until the issues are fixed. This reverts commit dc6decefb5cbd14d5ab059a59952fd96e86dc763.
2014-06-19 17:02:14 +00:00
}
window: Move move_resize_internal logic to protocol-specific directories
2014-03-19 14:30:12 +00:00
/* Do the protocol-specific move/resize logic */
window: Rename the requested_rect to the unconstrained_rect The requested_rect is a strange name for it, because it's not actually the rect that the user or client requested all the time: in the case of a simple move or a simple resize, we calculate some of the fields ourselves. To the MetaWindow subclass implementations, it just means "the rect before we constrained it", so just use the name unconstrained_rect. This also makes it match the name of the MetaWindow field.
2014-05-21 17:59:13 +00:00
META_WINDOW_GET_CLASS (window)->move_resize_internal (window, gravity, unconstrained_rect, constrained_rect, flags, &result);
...
2001-06-10 03:17:15 +00:00
window: Move move_resize_internal logic to protocol-specific directories
2014-03-19 14:30:12 +00:00
if (result & META_MOVE_RESIZE_RESULT_MOVED)
window: Always sync window geometry on state change When a state changed, e.g. a window went from unfullscreen to fullscreen, always sync the window geometry, otherwise a compositor application (e.g. gnome-shell) might end up with an unfinished window state transition effect. Without always syncing, the compositor plugin will see a 'size-change' event, as a result of the state change, but if the size didn't change, it would never see the 'size-changed' event. If an effect, for example gnome-shell's fullscreen effect, is triggered on 'size-change' it might rely on the actual size change to not get stuck. This commit allows it to have this dependency. This fixes a bug where a fullscreen effect gets "stuck" when a window goes fullscreen without changing the window geometry. https://bugzilla.gnome.org/show_bug.cgi?id=780292
2017-03-20 05:49:34 +00:00
{
moved_or_resized = TRUE;
g_signal_emit (window, window_signals[POSITION_CHANGED], 0);
}
Move position-changed / size-changed signals to the MetaWindow They fit more appropriately over here... https://bugzilla.gnome.org/show_bug.cgi?id=720631
2013-12-06 20:39:24 +00:00
window: Move move_resize_internal logic to protocol-specific directories
2014-03-19 14:30:12 +00:00
if (result & META_MOVE_RESIZE_RESULT_RESIZED)
Don't separate user_has_moved/user_has_resized, fixes bug in east-resizing 2001-09-10 Havoc Pennington <hp@pobox.com> * src/window.c: Don't separate user_has_moved/user_has_resized, fixes bug in east-resizing Emacs, among other things * src/frame.c (meta_frame_sync_to_window): return immediately if nothing to do * src/util.c (ensure_logfile): replace rather than truncate old logfiles
2001-09-11 02:57:05 +00:00
{
window: Always sync window geometry on state change When a state changed, e.g. a window went from unfullscreen to fullscreen, always sync the window geometry, otherwise a compositor application (e.g. gnome-shell) might end up with an unfinished window state transition effect. Without always syncing, the compositor plugin will see a 'size-change' event, as a result of the state change, but if the size didn't change, it would never see the 'size-changed' event. If an effect, for example gnome-shell's fullscreen effect, is triggered on 'size-change' it might rely on the actual size change to not get stuck. This commit allows it to have this dependency. This fixes a bug where a fullscreen effect gets "stuck" when a window goes fullscreen without changing the window geometry. https://bugzilla.gnome.org/show_bug.cgi?id=780292
2017-03-20 05:49:34 +00:00
moved_or_resized = TRUE;
g_signal_emit (window, window_signals[SIZE_CHANGED], 0);
}
if (moved_or_resized || did_placement)
window->unconstrained_rect = unconstrained_rect;
window: Only update the unconstrained rect when we actually moved/resized Since Wayland configures are more of a hint to the client than anything, we don't want to save the unconstrained rect when we're just hinting to the client that it should resize, since it could ignore us. This would get us stuck in a loop, since meta_window_move_resize_now would use the unconstrained_rect to resize, and we don't remove the resize from the queue if we have an outstanding request like that. This fixes a bunch of traffic / CPU usage when trying to resize weston-terminal.
2014-07-07 18:08:07 +00:00
window: Always sync window geometry on state change When a state changed, e.g. a window went from unfullscreen to fullscreen, always sync the window geometry, otherwise a compositor application (e.g. gnome-shell) might end up with an unfinished window state transition effect. Without always syncing, the compositor plugin will see a 'size-change' event, as a result of the state change, but if the size didn't change, it would never see the 'size-changed' event. If an effect, for example gnome-shell's fullscreen effect, is triggered on 'size-change' it might rely on the actual size change to not get stuck. This commit allows it to have this dependency. This fixes a bug where a fullscreen effect gets "stuck" when a window goes fullscreen without changing the window geometry. https://bugzilla.gnome.org/show_bug.cgi?id=780292
2017-03-20 05:49:34 +00:00
if ((moved_or_resized ||
did_placement ||
window: Let implementations finish state changes In the old, synchronous X.org world, we could assume that a state change always meant a synchronizing the window geometry right after. After firing an operation that would change the window state, such as maximizing or tiling the window, With Wayland, however, this is not valid anymore, since Wayland is asynchronous. In this scenario, we call meta_window_move_resize_internal() twice: when the user executes an state-changing operation, and when the server ACKs this operation. This breaks the previous assumptions, and as a consequence, it breaks the GNOME Shell animations in Wayland. The solution is giving the MetaWindow control over the time when the window geometry is synchronized with the compositor. That is done by introducing a new result flag. Wayland asks for a compositor sync after receiving an ACK from the server, while X11 asks for it right away. Fixes #78
2018-04-18 02:42:33 +00:00
(result & META_MOVE_RESIZE_RESULT_STATE_CHANGED) != 0) &&
window: Always sync window geometry on state change When a state changed, e.g. a window went from unfullscreen to fullscreen, always sync the window geometry, otherwise a compositor application (e.g. gnome-shell) might end up with an unfinished window state transition effect. Without always syncing, the compositor plugin will see a 'size-change' event, as a result of the state change, but if the size didn't change, it would never see the 'size-changed' event. If an effect, for example gnome-shell's fullscreen effect, is triggered on 'size-change' it might rely on the actual size change to not get stuck. This commit allows it to have this dependency. This fixes a bug where a fullscreen effect gets "stuck" when a window goes fullscreen without changing the window geometry. https://bugzilla.gnome.org/show_bug.cgi?id=780292
2017-03-20 05:49:34 +00:00
window->known_to_compositor)
{
meta_compositor_sync_window_geometry (window->display->compositor,
window,
did_placement);
Don't separate user_has_moved/user_has_resized, fixes bug in east-resizing 2001-09-10 Havoc Pennington <hp@pobox.com> * src/window.c: Don't separate user_has_moved/user_has_resized, fixes bug in east-resizing Emacs, among other things * src/frame.c (meta_frame_sync_to_window): return immediately if nothing to do * src/util.c (ensure_logfile): replace rather than truncate old logfiles
2001-09-11 02:57:05 +00:00
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window: Pass flag to meta_window_update_monitor() instead of bool The bool determines whether the call was directly from a user operation or not. To add more state into the call without having to add more boolenas, change the boolean to a flag (so far with 'none' and 'user-op' as possible values). No functional changes were made. https://gitlab.gnome.org/GNOME/mutter/issues/192
2018-08-24 10:54:50 +00:00
update_monitor_flags = META_WINDOW_UPDATE_MONITOR_FLAGS_NONE;
if (flags & META_MOVE_RESIZE_USER_ACTION)
update_monitor_flags |= META_WINDOW_UPDATE_MONITOR_FLAGS_USER_OP;
window: Really force update monitor on hot plugs Commit 8d3e05305 ("window: Force update monitor on hot plugs") added the flag `META_WINDOW_UPDATE_MONITOR_FLAGS_FORCE` passed to `update_monitor()` from `update_for_monitors_changed()`. However, `update_for_monitors_changed()` may choose to call another code path to `move_between_rects()` and `meta_window_move_resize_internal()` eventually. As `meta_window_move_resize_internal()` does not use the "force" flag, we may still end up in case where the window->monitor is left unchanged. To avoid that problem, add a new `MetaMoveResizeFlags` that `update_for_monitors_changed()` can use to force the monitor update from `meta_window_move_resize_internal()`. Fixes: 8d3e05305 ("window: Force update monitor on hot plugs") Closes: https://gitlab.gnome.org/GNOME/mutter/issues/189
2018-11-06 12:35:31 +00:00
if (flags & META_MOVE_RESIZE_FORCE_UPDATE_MONITOR)
update_monitor_flags |= META_WINDOW_UPDATE_MONITOR_FLAGS_FORCE;
window: Pass flag to meta_window_update_monitor() instead of bool The bool determines whether the call was directly from a user operation or not. To add more state into the call without having to add more boolenas, change the boolean to a flag (so far with 'none' and 'user-op' as possible values). No functional changes were made. https://gitlab.gnome.org/GNOME/mutter/issues/192
2018-08-24 10:54:50 +00:00
window: Handle being headless better This avoids updating state (such as position, size etc) when going headless. Eventually, when non-headless, things will be updated again, and not until then will we be able to update to a valid state. https://bugzilla.gnome.org/show_bug.cgi?id=730551
2017-08-18 06:21:11 +00:00
if (window->monitor)
{
output: Turn winsys_id into a uint64_t We need a 64 bit field to combine the device id and connector id into the output id (winsys_id).
2018-10-17 14:55:18 +00:00
uint64_t old_output_winsys_id;
window: Keep track of preferred output Remember the last monitor a window was moved to by user action and try to move it back on monitor changes; this should match user expectations much better when a monitor is unplugged temporarily. https://bugzilla.gnome.org/show_bug.cgi?id=731760
2014-06-13 20:28:26 +00:00
window: Handle being headless better This avoids updating state (such as position, size etc) when going headless. Eventually, when non-headless, things will be updated again, and not until then will we be able to update to a valid state. https://bugzilla.gnome.org/show_bug.cgi?id=730551
2017-08-18 06:21:11 +00:00
old_output_winsys_id = window->monitor->winsys_id;
Track the monitor for each window https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-25 15:37:05 +00:00
window: Pass flag to meta_window_update_monitor() instead of bool The bool determines whether the call was directly from a user operation or not. To add more state into the call without having to add more boolenas, change the boolean to a flag (so far with 'none' and 'user-op' as possible values). No functional changes were made. https://gitlab.gnome.org/GNOME/mutter/issues/192
2018-08-24 10:54:50 +00:00
meta_window_update_monitor (window, update_monitor_flags);
window: Handle being headless better This avoids updating state (such as position, size etc) when going headless. Eventually, when non-headless, things will be updated again, and not until then will we be able to update to a valid state. https://bugzilla.gnome.org/show_bug.cgi?id=730551
2017-08-18 06:21:11 +00:00
if (old_output_winsys_id != window->monitor->winsys_id &&
flags & META_MOVE_RESIZE_MOVE_ACTION && flags & META_MOVE_RESIZE_USER_ACTION)
window->preferred_output_winsys_id = window->monitor->winsys_id;
}
else
{
window: Pass flag to meta_window_update_monitor() instead of bool The bool determines whether the call was directly from a user operation or not. To add more state into the call without having to add more boolenas, change the boolean to a flag (so far with 'none' and 'user-op' as possible values). No functional changes were made. https://gitlab.gnome.org/GNOME/mutter/issues/192
2018-08-24 10:54:50 +00:00
meta_window_update_monitor (window, update_monitor_flags);
window: Handle being headless better This avoids updating state (such as position, size etc) when going headless. Eventually, when non-headless, things will be updated again, and not until then will we be able to update to a valid state. https://bugzilla.gnome.org/show_bug.cgi?id=730551
2017-08-18 06:21:11 +00:00
}
window: Keep track of preferred output Remember the last monitor a window was moved to by user action and try to move it back on monitor changes; this should match user expectations much better when a monitor is unplugged temporarily. https://bugzilla.gnome.org/show_bug.cgi?id=731760
2014-06-13 20:28:26 +00:00
window: Actually interpret the FRAME_SHAPE_CHANGED result When I refactored this out into a vfunc, I forgot to change the code that interprets the result flags to actually respect the new FRAME_SHAPE_CHANGED result flag. Since we weren't ever clearing the frame bounds, this meant that the "shadow clip" wasn't ever updated as a result. Since right now all Wayland surfaces are considered ARGB32, we always clip shadows under frames, and thus shadows had this weird "punch-out" from the first frame shape.
2014-03-20 22:00:55 +00:00
if ((result & META_MOVE_RESIZE_RESULT_FRAME_SHAPE_CHANGED) && window->frame_bounds)
Only shadow ARGB windows with a frame outside the frame An ARGB window with a frame is likely something like a transparent terminal. It looks awful (and breaks transparency) to draw a big opaque black shadow under the window, so clip out the region under the terminal from the shadow we draw. Add meta_window_get_frame_bounds() to get a cairo region for the outer bounds of the frame of a window, and modify the frame handling code to notice changes to the frame shape and discard a cached region. meta_frames_apply_shapes() is refactored so we can extract meta_frames_get_frame_bounds() from it. https://bugzilla.gnome.org/show_bug.cgi?id=635268
2011-03-22 19:36:12 +00:00
{
cairo_region_destroy (window->frame_bounds);
window->frame_bounds = NULL;
}
window: Keep windows with placement rule attached to parent A window placed using a placement rule should keep that relative position even if the parent window moves, as the position tied to the parent window, not to the stage. Thus, if the parent window moves, the child window should move with it. In the implementation in this commit, the constraints engine is not used when repositioning the children; the window is simply positioned according to the effective placement rule that was derived from the initial constraining, as the a xdg_popup at the moment cannot move (relative its parent) after being mapped. Closes: https://gitlab.gnome.org/GNOME/mutter/issues/274
2018-08-22 19:54:16 +00:00
meta_window_foreach_transient (window, maybe_move_attached_window, NULL);
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_update_window_tile_matches (window->display->stack,
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
workspace_manager->active_workspace);
...
2001-06-08 02:17:48 +00:00
}
expose MetaWindow .move(), resize() and add/expose .move_frame() The latter move method will place the window by the origin of the enclosing window decoration/frame, while the former will place by the origin of the inner window, itself. (Also moved meta_window_showing_on_its_workspace comment into gtk-doc) https://bugzilla.gnome.org/show_bug.cgi?id=642355
2011-03-09 15:01:44 +00:00
/**
* meta_window_move_frame:
* @window: a #MetaWindow
* @user_op: bool to indicate whether or not this is a user operation
* @root_x_nw: desired x pos
* @root_y_nw: desired y pos
*
* Moves the window to the desired location on window's assigned
* workspace, using the northwest edge of the frame as the reference,
* instead of the actual window's origin, but only if a frame is present.
* Otherwise, acts identically to meta_window_move().
*/
void
window: Reindent slightly
2014-05-20 22:14:59 +00:00
meta_window_move_frame (MetaWindow *window,
gboolean user_op,
int root_x_nw,
int root_y_nw)
expose MetaWindow .move(), resize() and add/expose .move_frame() The latter move method will place the window by the origin of the enclosing window decoration/frame, while the former will place by the origin of the inner window, itself. (Also moved meta_window_showing_on_its_workspace comment into gtk-doc) https://bugzilla.gnome.org/show_bug.cgi?id=642355
2011-03-09 15:01:44 +00:00
{
window: Remove meta_window_move as well Move to meta_window_move_frame everywhere...
2014-05-21 12:46:18 +00:00
MetaMoveResizeFlags flags;
Use utility functions to convert between frame and client rectangles There are extensive places in the code where we convert between the client rectangle and the frame rectangle. Instead of manually doing it use new helper functions on MetaWindow and the existing meta_window_get_outer_rect(). This fixes a number of bugs where the computation was being done incorrectly, most of these bugs are with the recently added custom frame extents, but some relate to invisible borders or even simply to confusion between the window and frame rectangle. Switch the placement code to place the frame rectangle rather than the client window - this simplifies things considerably. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 21:11:20 +00:00
MetaRectangle rect = { root_x_nw, root_y_nw, 0, 0 };
Simplify the frame testing logic in callers to grab borders A lot of code did something similar to: MetaFrameBorders borders; if (window->frame) meta_frame_calc_borders (window->frame, &borders); else meta_frame_borders_clear (&borders); Sometimes, the else part was omitted and we were unknowingly using uninitalized values for OR windows. Clean this up by just testing for a NULL frame in meta_frame_calc_borders and clearing for the caller if so. https://bugzilla.gnome.org/show_bug.cgi?id=643606
2012-03-13 03:11:07 +00:00
window: Remove meta_window_move as well Move to meta_window_move_frame everywhere...
2014-05-21 12:46:18 +00:00
g_return_if_fail (!window->override_redirect);
Rename MetaMoveResizeFlags items to fit with the theme Use a proper prefix, even if more wordy, instead of META_IS.
2014-12-15 21:28:47 +00:00
flags = (user_op ? META_MOVE_RESIZE_USER_ACTION : 0) | META_MOVE_RESIZE_MOVE_ACTION;
window: Remove meta_window_move as well Move to meta_window_move_frame everywhere...
2014-05-21 12:46:18 +00:00
meta_window_move_resize_internal (window, flags, NorthWestGravity, rect);
expose MetaWindow .move(), resize() and add/expose .move_frame() The latter move method will place the window by the origin of the enclosing window decoration/frame, while the former will place by the origin of the inner window, itself. (Also moved meta_window_showing_on_its_workspace comment into gtk-doc) https://bugzilla.gnome.org/show_bug.cgi?id=642355
2011-03-09 15:01:44 +00:00
}
...
2001-06-08 02:17:48 +00:00
When monitors change, keep windows on same output. If XRANDR is availible, we track the first (or primary) output per crtc (== xinerama monitor) so when the monitors change we can try to find the same output and move windows there. If we can't find the original monitor in the new set (or XRANDR is not supported) we move the window to the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=645408
2011-05-20 08:56:12 +00:00
static void
meta_window_move_between_rects (MetaWindow *window,
window: Really force update monitor on hot plugs Commit 8d3e05305 ("window: Force update monitor on hot plugs") added the flag `META_WINDOW_UPDATE_MONITOR_FLAGS_FORCE` passed to `update_monitor()` from `update_for_monitors_changed()`. However, `update_for_monitors_changed()` may choose to call another code path to `move_between_rects()` and `meta_window_move_resize_internal()` eventually. As `meta_window_move_resize_internal()` does not use the "force" flag, we may still end up in case where the window->monitor is left unchanged. To avoid that problem, add a new `MetaMoveResizeFlags` that `update_for_monitors_changed()` can use to force the monitor update from `meta_window_move_resize_internal()`. Fixes: 8d3e05305 ("window: Force update monitor on hot plugs") Closes: https://gitlab.gnome.org/GNOME/mutter/issues/189
2018-11-06 12:35:31 +00:00
MetaMoveResizeFlags move_resize_flags,
When monitors change, keep windows on same output. If XRANDR is availible, we track the first (or primary) output per crtc (== xinerama monitor) so when the monitors change we can try to find the same output and move windows there. If we can't find the original monitor in the new set (or XRANDR is not supported) we move the window to the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=645408
2011-05-20 08:56:12 +00:00
const MetaRectangle *old_area,
const MetaRectangle *new_area)
{
int rel_x, rel_y;
double scale_x, scale_y;
window: Make move_to_monitor work for zero sized and offscreen windows Wayland windows are initially zero sized until clients commit the first buffer. Despite being invisible, clients are allowed to request such windows to be fullscreened on a specific output before they attach the first buffer which means we need to be able to move them. meta_window_move_to_monitor() doesn't handle this case because these windows' initial monitor is a placeholder since their initial coordinates are 0,0+0+0, which results in us using a rectangle as old_area for meta_window_move_between_rects() that might be to the "right" of the window causing the move to go further out of the visible screen's coordinates. This is later "corrected" by the constraints system but the window might end up in the wrong monitor. To fix this, we can make meta_window_move_between_rects() accept a NULL old_area, meaning that we move the window to the new_area without trying to keep a relative position. https://bugzilla.gnome.org/show_bug.cgi?id=772525
2016-11-15 13:10:05 +00:00
if (old_area)
{
rel_x = window->unconstrained_rect.x - old_area->x;
rel_y = window->unconstrained_rect.y - old_area->y;
scale_x = (double)new_area->width / old_area->width;
scale_y = (double)new_area->height / old_area->height;
}
else
{
rel_x = rel_y = scale_x = scale_y = 0;
}
When monitors change, keep windows on same output. If XRANDR is availible, we track the first (or primary) output per crtc (== xinerama monitor) so when the monitors change we can try to find the same output and move windows there. If we can't find the original monitor in the new set (or XRANDR is not supported) we move the window to the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=645408
2011-05-20 08:56:12 +00:00
window: Replace the user_rect with the unconstrained_rect Realistically, the user rect contains the unconstrained window rectangle coordinates that we want to be displaying, in case something in the constraints change. Rename it to the "unconstrained_rect", and change the code to always save it, regardless of current state. When metacity was originally being built, the purpose of the user rect was a lot less clear. The code only saved it on user actions, with various other calls to save_user_window_placement() and a force mechanism sprinkled in to avoid windows being snapped back to odd places when constraints changed. This could lead to odd bugs. For instance, if the user uses some extension which automatically tiles windows and didn't pass user_action=TRUE, and then the struts changed, the window would be placed back at the last place a user moved it to, rather than where the window was tiled to. The META_IS_USER_ACTION flag is still used in the constraints code to determine whether we should allow shoving windows offscreen, so we can't remove it completely, but we should think about splitting out the constrainment policies it commands for a bit more fine-grained control. https://bugzilla.gnome.org/show_bug.cgi?id=726714
2014-03-18 14:53:00 +00:00
window->unconstrained_rect.x = new_area->x + rel_x * scale_x;
window->unconstrained_rect.y = new_area->y + rel_y * scale_y;
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
window->saved_rect.x = window->unconstrained_rect.x;
window->saved_rect.y = window->unconstrained_rect.y;
When monitors change, keep windows on same output. If XRANDR is availible, we track the first (or primary) output per crtc (== xinerama monitor) so when the monitors change we can try to find the same output and move windows there. If we can't find the original monitor in the new set (or XRANDR is not supported) we move the window to the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=645408
2011-05-20 08:56:12 +00:00
window: Really force update monitor on hot plugs Commit 8d3e05305 ("window: Force update monitor on hot plugs") added the flag `META_WINDOW_UPDATE_MONITOR_FLAGS_FORCE` passed to `update_monitor()` from `update_for_monitors_changed()`. However, `update_for_monitors_changed()` may choose to call another code path to `move_between_rects()` and `meta_window_move_resize_internal()` eventually. As `meta_window_move_resize_internal()` does not use the "force" flag, we may still end up in case where the window->monitor is left unchanged. To avoid that problem, add a new `MetaMoveResizeFlags` that `update_for_monitors_changed()` can use to force the monitor update from `meta_window_move_resize_internal()`. Fixes: 8d3e05305 ("window: Force update monitor on hot plugs") Closes: https://gitlab.gnome.org/GNOME/mutter/issues/189
2018-11-06 12:35:31 +00:00
meta_window_move_resize_internal (window,
move_resize_flags |
META_MOVE_RESIZE_MOVE_ACTION |
META_MOVE_RESIZE_RESIZE_ACTION,
NorthWestGravity,
window->unconstrained_rect);
When monitors change, keep windows on same output. If XRANDR is availible, we track the first (or primary) output per crtc (== xinerama monitor) so when the monitors change we can try to find the same output and move windows there. If we can't find the original monitor in the new set (or XRANDR is not supported) we move the window to the primary monitor. https://bugzilla.gnome.org/show_bug.cgi?id=645408
2011-05-20 08:56:12 +00:00
}
window.c: add meta_window_move_resize_frame meta_window_move_resize_frame operates much like meta_window_move_resize, but ensures the window and its frame (if present) will fit within the specified dimensions. https://bugzilla.gnome.org/show_bug.cgi?id=651899
2011-06-05 01:02:44 +00:00
/**
* meta_window_move_resize_frame:
* @window: a #MetaWindow
* @user_op: bool to indicate whether or not this is a user operation
* @root_x_nw: new x
* @root_y_nw: new y
* @w: desired width
* @h: desired height
*
* Resizes the window so that its outer bounds (including frame)
* fit within the given rect
*/
void
meta_window_move_resize_frame (MetaWindow *window,
gboolean user_op,
int root_x_nw,
int root_y_nw,
int w,
int h)
{
window: Refactor all move/resize operations to be in frame rect space For Wayland, we want to have everything possible in terms of the frame rect, or "window geometry" as the Wayland protocol calls it, in order to properly eliminate some flashing when changing states to fullscreen or similar. For this, we need to heavily refactor how the code is structured, and make it so that meta_window_move_resize_internal is specified in terms of the frame rect coordinate space, and transforming all entry points to meta_window_move_resize_internal. This is a big commit that's hard to tear apart. I tried to split it as best I can, but there's still just a large amount of changes that need to happen at once. Expect some regressions from this. Sorry for any temporary regression that this might cause.
2014-05-20 21:47:10 +00:00
MetaMoveResizeFlags flags;
Use utility functions to convert between frame and client rectangles There are extensive places in the code where we convert between the client rectangle and the frame rectangle. Instead of manually doing it use new helper functions on MetaWindow and the existing meta_window_get_outer_rect(). This fixes a number of bugs where the computation was being done incorrectly, most of these bugs are with the recently added custom frame extents, but some relate to invisible borders or even simply to confusion between the window and frame rectangle. Switch the placement code to place the frame rectangle rather than the client window - this simplifies things considerably. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 21:11:20 +00:00
MetaRectangle rect = { root_x_nw, root_y_nw, w, h };
Simplify the frame testing logic in callers to grab borders A lot of code did something similar to: MetaFrameBorders borders; if (window->frame) meta_frame_calc_borders (window->frame, &borders); else meta_frame_borders_clear (&borders); Sometimes, the else part was omitted and we were unknowingly using uninitalized values for OR windows. Clean this up by just testing for a NULL frame in meta_frame_calc_borders and clearing for the caller if so. https://bugzilla.gnome.org/show_bug.cgi?id=643606
2012-03-13 03:11:07 +00:00
window: Refactor all move/resize operations to be in frame rect space For Wayland, we want to have everything possible in terms of the frame rect, or "window geometry" as the Wayland protocol calls it, in order to properly eliminate some flashing when changing states to fullscreen or similar. For this, we need to heavily refactor how the code is structured, and make it so that meta_window_move_resize_internal is specified in terms of the frame rect coordinate space, and transforming all entry points to meta_window_move_resize_internal. This is a big commit that's hard to tear apart. I tried to split it as best I can, but there's still just a large amount of changes that need to happen at once. Expect some regressions from this. Sorry for any temporary regression that this might cause.
2014-05-20 21:47:10 +00:00
g_return_if_fail (!window->override_redirect);
Rename MetaMoveResizeFlags items to fit with the theme Use a proper prefix, even if more wordy, instead of META_IS.
2014-12-15 21:28:47 +00:00
flags = (user_op ? META_MOVE_RESIZE_USER_ACTION : 0) | META_MOVE_RESIZE_MOVE_ACTION | META_MOVE_RESIZE_RESIZE_ACTION;
window: Refactor all move/resize operations to be in frame rect space For Wayland, we want to have everything possible in terms of the frame rect, or "window geometry" as the Wayland protocol calls it, in order to properly eliminate some flashing when changing states to fullscreen or similar. For this, we need to heavily refactor how the code is structured, and make it so that meta_window_move_resize_internal is specified in terms of the frame rect coordinate space, and transforming all entry points to meta_window_move_resize_internal. This is a big commit that's hard to tear apart. I tried to split it as best I can, but there's still just a large amount of changes that need to happen at once. Expect some regressions from this. Sorry for any temporary regression that this might cause.
2014-05-20 21:47:10 +00:00
meta_window_move_resize_internal (window, flags, NorthWestGravity, rect);
window.c: add meta_window_move_resize_frame meta_window_move_resize_frame operates much like meta_window_move_resize, but ensures the window and its frame (if present) will fit within the specified dimensions. https://bugzilla.gnome.org/show_bug.cgi?id=651899
2011-06-05 01:02:44 +00:00
}
Add and export meta_window_move_to_monitor This is useful for DnD to another monitor in gnome-shell. In addition to a normal move it corrects the saved rect for maximized and fullscreened windows. https://bugzilla.gnome.org/show_bug.cgi?id=645032
2011-03-21 11:36:01 +00:00
/**
* meta_window_move_to_monitor:
* @window: a #MetaWindow
* @monitor: desired monitor index
*
* Moves the window to the monitor with index @monitor, keeping
* the relative position of the window's top left corner.
*/
void
meta_window_move_to_monitor (MetaWindow *window,
int monitor)
{
MetaRectangle old_area, new_area;
window: Update tile monitor before move The actual move may involve the tile monitor, so make sure to not use an outdated value by setting it before calling move_between_rects(). https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-16 00:29:48 +00:00
if (window->tile_mode != META_TILE_NONE)
window->tile_monitor_number = monitor;
Add and export meta_window_move_to_monitor This is useful for DnD to another monitor in gnome-shell. In addition to a normal move it corrects the saved rect for maximized and fullscreened windows. https://bugzilla.gnome.org/show_bug.cgi?id=645032
2011-03-21 11:36:01 +00:00
meta_window_get_work_area_for_monitor (window,
window->monitor->number,
&old_area);
meta_window_get_work_area_for_monitor (window,
monitor,
&new_area);
window: Make move_to_monitor work for zero sized and offscreen windows Wayland windows are initially zero sized until clients commit the first buffer. Despite being invisible, clients are allowed to request such windows to be fullscreened on a specific output before they attach the first buffer which means we need to be able to move them. meta_window_move_to_monitor() doesn't handle this case because these windows' initial monitor is a placeholder since their initial coordinates are 0,0+0+0, which results in us using a rectangle as old_area for meta_window_move_between_rects() that might be to the "right" of the window causing the move to go further out of the visible screen's coordinates. This is later "corrected" by the constraints system but the window might end up in the wrong monitor. To fix this, we can make meta_window_move_between_rects() accept a NULL old_area, meaning that we move the window to the new_area without trying to keep a relative position. https://bugzilla.gnome.org/show_bug.cgi?id=772525
2016-11-15 13:10:05 +00:00
if (window->unconstrained_rect.width == 0 ||
window->unconstrained_rect.height == 0 ||
!meta_rectangle_overlap (&window->unconstrained_rect, &old_area))
{
window: Really force update monitor on hot plugs Commit 8d3e05305 ("window: Force update monitor on hot plugs") added the flag `META_WINDOW_UPDATE_MONITOR_FLAGS_FORCE` passed to `update_monitor()` from `update_for_monitors_changed()`. However, `update_for_monitors_changed()` may choose to call another code path to `move_between_rects()` and `meta_window_move_resize_internal()` eventually. As `meta_window_move_resize_internal()` does not use the "force" flag, we may still end up in case where the window->monitor is left unchanged. To avoid that problem, add a new `MetaMoveResizeFlags` that `update_for_monitors_changed()` can use to force the monitor update from `meta_window_move_resize_internal()`. Fixes: 8d3e05305 ("window: Force update monitor on hot plugs") Closes: https://gitlab.gnome.org/GNOME/mutter/issues/189
2018-11-06 12:35:31 +00:00
meta_window_move_between_rects (window, 0, NULL, &new_area);
window: Make move_to_monitor work for zero sized and offscreen windows Wayland windows are initially zero sized until clients commit the first buffer. Despite being invisible, clients are allowed to request such windows to be fullscreened on a specific output before they attach the first buffer which means we need to be able to move them. meta_window_move_to_monitor() doesn't handle this case because these windows' initial monitor is a placeholder since their initial coordinates are 0,0+0+0, which results in us using a rectangle as old_area for meta_window_move_between_rects() that might be to the "right" of the window causing the move to go further out of the visible screen's coordinates. This is later "corrected" by the constraints system but the window might end up in the wrong monitor. To fix this, we can make meta_window_move_between_rects() accept a NULL old_area, meaning that we move the window to the new_area without trying to keep a relative position. https://bugzilla.gnome.org/show_bug.cgi?id=772525
2016-11-15 13:10:05 +00:00
}
else
{
if (monitor == window->monitor->number)
return;
window: Really force update monitor on hot plugs Commit 8d3e05305 ("window: Force update monitor on hot plugs") added the flag `META_WINDOW_UPDATE_MONITOR_FLAGS_FORCE` passed to `update_monitor()` from `update_for_monitors_changed()`. However, `update_for_monitors_changed()` may choose to call another code path to `move_between_rects()` and `meta_window_move_resize_internal()` eventually. As `meta_window_move_resize_internal()` does not use the "force" flag, we may still end up in case where the window->monitor is left unchanged. To avoid that problem, add a new `MetaMoveResizeFlags` that `update_for_monitors_changed()` can use to force the monitor update from `meta_window_move_resize_internal()`. Fixes: 8d3e05305 ("window: Force update monitor on hot plugs") Closes: https://gitlab.gnome.org/GNOME/mutter/issues/189
2018-11-06 12:35:31 +00:00
meta_window_move_between_rects (window, 0, &old_area, &new_area);
window: Make move_to_monitor work for zero sized and offscreen windows Wayland windows are initially zero sized until clients commit the first buffer. Despite being invisible, clients are allowed to request such windows to be fullscreened on a specific output before they attach the first buffer which means we need to be able to move them. meta_window_move_to_monitor() doesn't handle this case because these windows' initial monitor is a placeholder since their initial coordinates are 0,0+0+0, which results in us using a rectangle as old_area for meta_window_move_between_rects() that might be to the "right" of the window causing the move to go further out of the visible screen's coordinates. This is later "corrected" by the constraints system but the window might end up in the wrong monitor. To fix this, we can make meta_window_move_between_rects() accept a NULL old_area, meaning that we move the window to the new_area without trying to keep a relative position. https://bugzilla.gnome.org/show_bug.cgi?id=772525
2016-11-15 13:10:05 +00:00
}
monitor-manager: Rename output_id to winsys_id The output_id is more of an opaque identifier for the monitor, based on its underlying ID from the windowing system. Since we also use the term "output_id" for the output's index, rename our use of the opaque cookie "output_id" to "winsys_id".
2014-07-01 17:23:05 +00:00
window->preferred_output_winsys_id = window->monitor->winsys_id;
window: Queue a fullscreen check when moving between monitors We track changes to windows fullscreen state and stacking order to determine a monitor's in-fullscreen state, but missed the obvious case of moving a fullscreen window between monitors. https://bugzilla.gnome.org/show_bug.cgi?id=728395
2014-04-17 09:19:53 +00:00
if (window->fullscreen || window->override_redirect)
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
meta_display_queue_check_fullscreen (window->display);
Add and export meta_window_move_to_monitor This is useful for DnD to another monitor in gnome-shell. In addition to a normal move it corrects the saved rect for maximized and fullscreened windows. https://bugzilla.gnome.org/show_bug.cgi?id=645032
2011-03-21 11:36:01 +00:00
}
window: Tile and resize considering the tile match After the introduction of the possibility to resize tiled windows, it is a sensible decision to make windows aware of their tiling match. A tiling match is another window that is tiled in such a way that is the complement of the current window. The newly introduced behavior attepts to make tiling as smooth as possible, with the following rules: * Windows now compute their tile match when tiling and, if there's a match, they automatically complement the sibling's width. * Resizing a window with a sibling automatically resizes the sibling too to be the complement of the window's width. * It is not possible to resize below windows' minimum widths. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-12 01:13:03 +00:00
static void
adjust_size_for_tile_match (MetaWindow *window,
int *new_w,
int *new_h)
{
MetaRectangle work_area, rect;
MetaWindow *tile_match = window->tile_match;
if (!META_WINDOW_TILED_SIDE_BY_SIDE (window) || !tile_match)
return;
meta_window_get_work_area_for_monitor (window, window->tile_monitor_number, &work_area);
/* Make sure the resize does not break minimum sizes */
rect = work_area;
rect.width = *new_w;
meta_window_frame_rect_to_client_rect (window, &rect, &rect);
*new_w += MAX(0, window->size_hints.min_width - rect.width);
/* Make sure we're not resizing the tile match below its min width */
rect = work_area;
rect.width = work_area.width - *new_w;
meta_window_frame_rect_to_client_rect (tile_match, &rect, &rect);
*new_w -= MAX(0, tile_match->size_hints.min_width - rect.width);
}
...
2001-06-30 23:17:52 +00:00
void
window: Replace meta_window_resize_with_gravity with a frame-rect variant More low-hanging fruit for our window geometry cleanups...
2014-05-20 22:28:56 +00:00
meta_window_resize_frame_with_gravity (MetaWindow *window,
gboolean user_op,
int w,
int h,
int gravity)
...
2001-06-30 23:17:52 +00:00
{
Patch from Jens Granseuer to fix build with gcc 2.95. #322622. 2006-01-02 Elijah Newren <newren@gmail.com> Patch from Jens Granseuer to fix build with gcc 2.95. #322622. * src/boxes.c (meta_rectangle_region_to_string, meta_rectangle_edge_list_to_string, fix_up_edges): * src/constraints.c (meta_window_constrain, setup_constraint_info, place_window_if_needed, constrain_maximization, constrain_fullscreen, constrain_size_increments, constrain_size_limits, constrain_aspect_ratio, do_screen_and_xinerama_relative_constrai, constrain_to_single_xinerama, constrain_fully_onscreen, constrain_partially_onscreen): * src/edge-resistance.c (find_nearest_position, apply_edge_resistance, apply_edge_resistance_to_each_side): * src/testboxes.c (test_clamping_to_region, test_clipping_to_region, test_shoving_into_region): * src/window.c (meta_window_new_with_attrs, meta_window_apply_session_info, meta_window_resize, meta_window_resize_with_gravity, meta_window_configure_request): Remove C99 style variable initiailization
2006-01-02 18:37:46 +00:00
MetaMoveResizeFlags flags;
window: Change meta_window_move_resize_internal to take a MetaRectangle We construct one anyway, and most callers already pass in a rectangle the long way around, so why not change the internal API?
2014-05-01 23:09:13 +00:00
MetaRectangle rect;
...
2001-06-30 23:17:52 +00:00
window: Change meta_window_move_resize_internal to take a MetaRectangle We construct one anyway, and most callers already pass in a rectangle the long way around, so why not change the internal API?
2014-05-01 23:09:13 +00:00
rect.width = w;
rect.height = h;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window: Allow resizing of tiled windows Currently tiled windows are not resizable and their size is fixed to half the screen width. Adjust the code to work with fractions other than half, and allow users to adjust the split by dragging the window edge that is not constrained by a monitor edge. Follow-up patches will improve on that by resizing neighboring tiled windows by a shared edge, and making the functionality available to client-side decorated windows implementing the new edge constraints protocol.
2017-09-27 12:37:57 +00:00
if (user_op)
window: Tile and resize considering the tile match After the introduction of the possibility to resize tiled windows, it is a sensible decision to make windows aware of their tiling match. A tiling match is another window that is tiled in such a way that is the complement of the current window. The newly introduced behavior attepts to make tiling as smooth as possible, with the following rules: * Windows now compute their tile match when tiling and, if there's a match, they automatically complement the sibling's width. * Resizing a window with a sibling automatically resizes the sibling too to be the complement of the window's width. * It is not possible to resize below windows' minimum widths. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-12 01:13:03 +00:00
{
/* When resizing in-tandem with a tile match, we need to respect
* its minimum width
*/
if (window->display->grab_window == window)
adjust_size_for_tile_match (window, &w, &h);
meta_window_update_tile_fraction (window, w, h);
}
window: Allow resizing of tiled windows Currently tiled windows are not resizable and their size is fixed to half the screen width. Adjust the code to work with fractions other than half, and allow users to adjust the split by dragging the window edge that is not constrained by a monitor edge. Follow-up patches will improve on that by resizing neighboring tiled windows by a shared edge, and making the functionality available to client-side decorated windows implementing the new edge constraints protocol.
2017-09-27 12:37:57 +00:00
Rename MetaMoveResizeFlags items to fit with the theme Use a proper prefix, even if more wordy, instead of META_IS.
2014-12-15 21:28:47 +00:00
flags = (user_op ? META_MOVE_RESIZE_USER_ACTION : 0) | META_MOVE_RESIZE_RESIZE_ACTION;
window: Change meta_window_move_resize_internal to take a MetaRectangle We construct one anyway, and most callers already pass in a rectangle the long way around, so why not change the internal API?
2014-05-01 23:09:13 +00:00
meta_window_move_resize_internal (window, flags, gravity, rect);
...
2001-06-30 23:17:52 +00:00
}
Patch from Kjartan Maraas to fix a lot of tiny issues (unused variable 2006-01-20 Elijah Newren <newren gmail com> * src/async-getprop.c: * src/common.h: * src/display.c: * src/eggaccelerators.c: * src/frames.c: * src/gradient.c: * src/iconcache.c: * src/keybindings.c: * src/metaaccellabel.c: * src/place.c: * src/prefs.c: * src/preview-widget.c: * src/screen.c: * src/session.c: * src/stack.c: * src/tabpopup.c: * src/theme-viewer.c: * src/theme.c: * src/window-props.c: * src/window.c: * src/workspace.c: * src/tools/metacity-window-demo.c: * src/wm-tester/test-gravity.c: * src/wm-tester/test-resizing.c: * src/wm-tester/test-size-hints.c: Patch from Kjartan Maraas to fix a lot of tiny issues (unused variable removal, making unused variables used again, correction of types passed/declared for printf arguments, removal of unneeded breaks and returns, dead code removal, dead code revival, renaming to prevent shadowed variables, declaring unexported functions as static) spotted by the intel compiler. #321439
2006-01-20 22:03:56 +00:00
static void
...
2001-06-24 08:09:10 +00:00
meta_window_move_resize_now (MetaWindow *window)
...
2001-06-09 21:58:30 +00:00
{
window: Refactor all move/resize operations to be in frame rect space For Wayland, we want to have everything possible in terms of the frame rect, or "window geometry" as the Wayland protocol calls it, in order to properly eliminate some flashing when changing states to fullscreen or similar. For this, we need to heavily refactor how the code is structured, and make it so that meta_window_move_resize_internal is specified in terms of the frame rect coordinate space, and transforming all entry points to meta_window_move_resize_internal. This is a big commit that's hard to tear apart. I tried to split it as best I can, but there's still just a large amount of changes that need to happen at once. Expect some regressions from this. Sorry for any temporary regression that this might cause.
2014-05-20 21:47:10 +00:00
meta_window_move_resize_frame (window, FALSE,
window->unconstrained_rect.x,
window->unconstrained_rect.y,
window->unconstrained_rect.width,
window->unconstrained_rect.height);
...
2001-06-09 21:58:30 +00:00
}
give priority to keeping NW corner onscreen rather than SE, if we need to 2002-01-18 Havoc Pennington <hp@pobox.com> * src/window.c (constrain_position): give priority to keeping NW corner onscreen rather than SE, if we need to shift the window to fit inside constraints * src/frames.c (meta_frames_get_geometry): don't depend on the current window size * src/theme.c: move geometry stuff in here, to be calculated as part of the theme * src/core.c (meta_core_get_client_size): new function to replace meta_core_get_frame_size() so we don't have weird cycles in the geometry calculation
2002-01-19 03:50:03 +00:00
static gboolean
idle_move_resize (gpointer data)
{
GSList *tmp;
GSList *copy;
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
guint queue_index = GPOINTER_TO_INT (data);
give priority to keeping NW corner onscreen rather than SE, if we need to 2002-01-18 Havoc Pennington <hp@pobox.com> * src/window.c (constrain_position): give priority to keeping NW corner onscreen rather than SE, if we need to shift the window to fit inside constraints * src/frames.c (meta_frames_get_geometry): don't depend on the current window size * src/theme.c: move geometry stuff in here, to be calculated as part of the theme * src/core.c (meta_core_get_client_size): new function to replace meta_core_get_frame_size() so we don't have weird cycles in the geometry calculation
2002-01-19 03:50:03 +00:00
Throughout: move to meta_topic rather than meta_verbose so metacity.log 2002-02-07 Havoc Pennington <hp@pobox.com> Throughout: move to meta_topic rather than meta_verbose so metacity.log can start being more useful * src/util.h (enum): add more debug topics * src/frames.c: clean up some cruft that caused warnings
2002-02-08 03:34:26 +00:00
meta_topic (META_DEBUG_GEOMETRY, "Clearing the move_resize queue\n");
give priority to keeping NW corner onscreen rather than SE, if we need to 2002-01-18 Havoc Pennington <hp@pobox.com> * src/window.c (constrain_position): give priority to keeping NW corner onscreen rather than SE, if we need to shift the window to fit inside constraints * src/frames.c (meta_frames_get_geometry): don't depend on the current window size * src/theme.c: move geometry stuff in here, to be calculated as part of the theme * src/core.c (meta_core_get_client_size): new function to replace meta_core_get_frame_size() so we don't have weird cycles in the geometry calculation
2002-01-19 03:50:03 +00:00
/* Work with a copy, for reentrancy. The allowed reentrancy isn't
* complete; destroying a window while we're in here would result in
* badness. But it's OK to queue/unqueue move_resizes.
*/
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
copy = g_slist_copy (queue_pending[queue_index]);
g_slist_free (queue_pending[queue_index]);
queue_pending[queue_index] = NULL;
Use "later functions" to fix priority problems with Clutter redraw There was a problem where if, for example, a restack was triggered out of a clutter event handler, then after Clutter processed the events, it would proceed immmediately on to repaint the stage without ever returning control to the GLib main loop. So even though we had an idle handler installed with a higher priority than the Clutter stage repainting the clutter stage repainting would happen first and we'd get a wrong frame. Fix this by introducing the idea of "later functions", which abstract the idea of "doing something later" away from g_idle_add() and use a combination of GLib idle functions and Clutter "repaint functions" to get our callbacks triggered at the right time, even when they are installed from a clutter event handler. https://bugzilla.gnome.org/show_bug.cgi?id=596334 This also resolve a FIXME where MUTTER_PRIORITY_BEFORE_REDRAW could starve stage repainting.
2009-09-25 19:47:22 +00:00
queue_later[queue_index] = 0;
give priority to keeping NW corner onscreen rather than SE, if we need to 2002-01-18 Havoc Pennington <hp@pobox.com> * src/window.c (constrain_position): give priority to keeping NW corner onscreen rather than SE, if we need to shift the window to fit inside constraints * src/frames.c (meta_frames_get_geometry): don't depend on the current window size * src/theme.c: move geometry stuff in here, to be calculated as part of the theme * src/core.c (meta_core_get_client_size): new function to replace meta_core_get_frame_size() so we don't have weird cycles in the geometry calculation
2002-01-19 03:50:03 +00:00
destroying_windows_disallowed += 1;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
give priority to keeping NW corner onscreen rather than SE, if we need to 2002-01-18 Havoc Pennington <hp@pobox.com> * src/window.c (constrain_position): give priority to keeping NW corner onscreen rather than SE, if we need to shift the window to fit inside constraints * src/frames.c (meta_frames_get_geometry): don't depend on the current window size * src/theme.c: move geometry stuff in here, to be calculated as part of the theme * src/core.c (meta_core_get_client_size): new function to replace meta_core_get_frame_size() so we don't have weird cycles in the geometry calculation
2002-01-19 03:50:03 +00:00
tmp = copy;
while (tmp != NULL)
{
MetaWindow *window;
window = tmp->data;
/* As a side effect, sets window->move_resize_queued = FALSE */
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
meta_window_move_resize_now (window);
give priority to keeping NW corner onscreen rather than SE, if we need to 2002-01-18 Havoc Pennington <hp@pobox.com> * src/window.c (constrain_position): give priority to keeping NW corner onscreen rather than SE, if we need to shift the window to fit inside constraints * src/frames.c (meta_frames_get_geometry): don't depend on the current window size * src/theme.c: move geometry stuff in here, to be calculated as part of the theme * src/core.c (meta_core_get_client_size): new function to replace meta_core_get_frame_size() so we don't have weird cycles in the geometry calculation
2002-01-19 03:50:03 +00:00
tmp = tmp->next;
}
g_slist_free (copy);
destroying_windows_disallowed -= 1;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
give priority to keeping NW corner onscreen rather than SE, if we need to 2002-01-18 Havoc Pennington <hp@pobox.com> * src/window.c (constrain_position): give priority to keeping NW corner onscreen rather than SE, if we need to shift the window to fit inside constraints * src/frames.c (meta_frames_get_geometry): don't depend on the current window size * src/theme.c: move geometry stuff in here, to be calculated as part of the theme * src/core.c (meta_core_get_client_size): new function to replace meta_core_get_frame_size() so we don't have weird cycles in the geometry calculation
2002-01-19 03:50:03 +00:00
return FALSE;
}
...
2001-07-07 18:36:50 +00:00
void
meta_window_get_gravity_position (MetaWindow *window,
Add support for _NET_MOVERESIZE_WINDOW. #344521. 2007-04-09 Elijah Newren <newren gmail com> Add support for _NET_MOVERESIZE_WINDOW. #344521. * src/display.c (handle_net_moveresize_window, event_callback): Remove handle_net_moveresize_window() and the call to it; this code was highly buggy, though to be fair it was never tested and had simply been put into the code in commented out form. * src/screen.c (set_supported_hint): add atom_net_moveresize_window * src/window.[ch]: (meta_window_configure_request, meta_window_move_resize_request): Split out the moving/resize part of the configure request and put it into meta_window_move_resize_request (meta_window_client_message): check for NET_MOVERESIZE_WINDOW messages and call meta_window_move_resize_request() with the appropriate parameters to handle them (meta_window_move_resize_internal): fix some of the big comment at this function -- it wasn't quite right, use the passed in gravity instead of window->size_hints.win_gravity when calling adjust_for_gravity() to make sure the correct adjustments are used. (meta_window_get_gravity_position, meta_window_get_geometry, meta_window_move_resize_request): add a gravity parameter to meta_window_get_gravity_position and have it use that gravity instead of window->size_hints.win_gravity svn path=/trunk/; revision=3186
2007-04-09 23:00:55 +00:00
int gravity,
...
2001-07-07 18:36:50 +00:00
int *root_x,
int *root_y)
{
MetaRectangle frame_extents;
int w, h;
int x, y;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-07-07 18:36:50 +00:00
w = window->rect.width;
h = window->rect.height;
Add support for _NET_MOVERESIZE_WINDOW. #344521. 2007-04-09 Elijah Newren <newren gmail com> Add support for _NET_MOVERESIZE_WINDOW. #344521. * src/display.c (handle_net_moveresize_window, event_callback): Remove handle_net_moveresize_window() and the call to it; this code was highly buggy, though to be fair it was never tested and had simply been put into the code in commented out form. * src/screen.c (set_supported_hint): add atom_net_moveresize_window * src/window.[ch]: (meta_window_configure_request, meta_window_move_resize_request): Split out the moving/resize part of the configure request and put it into meta_window_move_resize_request (meta_window_client_message): check for NET_MOVERESIZE_WINDOW messages and call meta_window_move_resize_request() with the appropriate parameters to handle them (meta_window_move_resize_internal): fix some of the big comment at this function -- it wasn't quite right, use the passed in gravity instead of window->size_hints.win_gravity when calling adjust_for_gravity() to make sure the correct adjustments are used. (meta_window_get_gravity_position, meta_window_get_geometry, meta_window_move_resize_request): add a gravity parameter to meta_window_get_gravity_position and have it use that gravity instead of window->size_hints.win_gravity svn path=/trunk/; revision=3186
2007-04-09 23:00:55 +00:00
if (gravity == StaticGravity)
hrm, I fixed this wrong the other day. Fixes static gravity when moving 2001-08-18 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_get_gravity_position): hrm, I fixed this wrong the other day. Fixes static gravity when moving windows.
2001-08-19 02:29:38 +00:00
{
frame_extents = window->rect;
if (window->frame)
{
frame_extents.x = window->frame->rect.x + window->frame->child_x;
frame_extents.y = window->frame->rect.y + window->frame->child_y;
}
}
...
2001-07-07 18:36:50 +00:00
else
hrm, I fixed this wrong the other day. Fixes static gravity when moving 2001-08-18 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_get_gravity_position): hrm, I fixed this wrong the other day. Fixes static gravity when moving windows.
2001-08-19 02:29:38 +00:00
{
if (window->frame == NULL)
frame_extents = window->rect;
else
frame_extents = window->frame->rect;
}
...
2001-07-07 18:36:50 +00:00
x = frame_extents.x;
y = frame_extents.y;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Add support for _NET_MOVERESIZE_WINDOW. #344521. 2007-04-09 Elijah Newren <newren gmail com> Add support for _NET_MOVERESIZE_WINDOW. #344521. * src/display.c (handle_net_moveresize_window, event_callback): Remove handle_net_moveresize_window() and the call to it; this code was highly buggy, though to be fair it was never tested and had simply been put into the code in commented out form. * src/screen.c (set_supported_hint): add atom_net_moveresize_window * src/window.[ch]: (meta_window_configure_request, meta_window_move_resize_request): Split out the moving/resize part of the configure request and put it into meta_window_move_resize_request (meta_window_client_message): check for NET_MOVERESIZE_WINDOW messages and call meta_window_move_resize_request() with the appropriate parameters to handle them (meta_window_move_resize_internal): fix some of the big comment at this function -- it wasn't quite right, use the passed in gravity instead of window->size_hints.win_gravity when calling adjust_for_gravity() to make sure the correct adjustments are used. (meta_window_get_gravity_position, meta_window_get_geometry, meta_window_move_resize_request): add a gravity parameter to meta_window_get_gravity_position and have it use that gravity instead of window->size_hints.win_gravity svn path=/trunk/; revision=3186
2007-04-09 23:00:55 +00:00
switch (gravity)
...
2001-07-07 18:36:50 +00:00
{
case NorthGravity:
case CenterGravity:
case SouthGravity:
/* Find center of frame. */
x += frame_extents.width / 2;
/* Center client window on that point. */
x -= w / 2;
break;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-07-07 18:36:50 +00:00
case SouthEastGravity:
case EastGravity:
case NorthEastGravity:
/* Find right edge of frame */
x += frame_extents.width;
/* Align left edge of client at that point. */
x -= w;
break;
default:
break;
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Add support for _NET_MOVERESIZE_WINDOW. #344521. 2007-04-09 Elijah Newren <newren gmail com> Add support for _NET_MOVERESIZE_WINDOW. #344521. * src/display.c (handle_net_moveresize_window, event_callback): Remove handle_net_moveresize_window() and the call to it; this code was highly buggy, though to be fair it was never tested and had simply been put into the code in commented out form. * src/screen.c (set_supported_hint): add atom_net_moveresize_window * src/window.[ch]: (meta_window_configure_request, meta_window_move_resize_request): Split out the moving/resize part of the configure request and put it into meta_window_move_resize_request (meta_window_client_message): check for NET_MOVERESIZE_WINDOW messages and call meta_window_move_resize_request() with the appropriate parameters to handle them (meta_window_move_resize_internal): fix some of the big comment at this function -- it wasn't quite right, use the passed in gravity instead of window->size_hints.win_gravity when calling adjust_for_gravity() to make sure the correct adjustments are used. (meta_window_get_gravity_position, meta_window_get_geometry, meta_window_move_resize_request): add a gravity parameter to meta_window_get_gravity_position and have it use that gravity instead of window->size_hints.win_gravity svn path=/trunk/; revision=3186
2007-04-09 23:00:55 +00:00
switch (gravity)
...
2001-07-07 18:36:50 +00:00
{
case WestGravity:
case CenterGravity:
case EastGravity:
/* Find center of frame. */
y += frame_extents.height / 2;
/* Center client window there. */
y -= h / 2;
break;
case SouthWestGravity:
case SouthGravity:
case SouthEastGravity:
/* Find south edge of frame */
y += frame_extents.height;
/* Place bottom edge of client there */
y -= h;
break;
default:
break;
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-07-07 18:36:50 +00:00
if (root_x)
*root_x = x;
if (root_y)
*root_y = y;
}
...
2001-07-28 06:35:19 +00:00
void
window: Rename get_geometry to get_session_geometry
2014-05-21 17:49:24 +00:00
meta_window_get_session_geometry (MetaWindow *window,
int *x,
int *y,
int *width,
int *height)
...
2001-07-28 06:35:19 +00:00
{
Add support for _NET_MOVERESIZE_WINDOW. #344521. 2007-04-09 Elijah Newren <newren gmail com> Add support for _NET_MOVERESIZE_WINDOW. #344521. * src/display.c (handle_net_moveresize_window, event_callback): Remove handle_net_moveresize_window() and the call to it; this code was highly buggy, though to be fair it was never tested and had simply been put into the code in commented out form. * src/screen.c (set_supported_hint): add atom_net_moveresize_window * src/window.[ch]: (meta_window_configure_request, meta_window_move_resize_request): Split out the moving/resize part of the configure request and put it into meta_window_move_resize_request (meta_window_client_message): check for NET_MOVERESIZE_WINDOW messages and call meta_window_move_resize_request() with the appropriate parameters to handle them (meta_window_move_resize_internal): fix some of the big comment at this function -- it wasn't quite right, use the passed in gravity instead of window->size_hints.win_gravity when calling adjust_for_gravity() to make sure the correct adjustments are used. (meta_window_get_gravity_position, meta_window_get_geometry, meta_window_move_resize_request): add a gravity parameter to meta_window_get_gravity_position and have it use that gravity instead of window->size_hints.win_gravity svn path=/trunk/; revision=3186
2007-04-09 23:00:55 +00:00
meta_window_get_gravity_position (window,
window->size_hints.win_gravity,
x, y);
...
2001-07-28 06:35:19 +00:00
*width = (window->rect.width - window->size_hints.base_width) /
window->size_hints.width_inc;
*height = (window->rect.height - window->size_hints.base_height) /
window->size_hints.height_inc;
}
MetaWindow: Repurpose get_outer_rect and add get_input_rect get_outer_rect now returns the visible region, and a new get_input_rect method returns the boundaries of the full frame, including the possible invisible regions. When undecorated, both do the samething. https://bugzilla.gnome.org/show_bug.cgi?id=644930
2011-06-29 17:37:04 +00:00
/**
window: Rename get_input_rect to get_buffer_rect With get_input_region existing, get_input_rect is a misnomer. Really, it's about the geometry of the output surface, and it's only used that way in the compositor code. Way back when in GNOME 3.2, get_input_rect was added when we added invisible borders. get_outer_rect was always synonymous with server-side geometry of the toplevel. get_outer_rect was used for both user-side policy (the "frame rect") and to get the geometry of the window. Invisible borders were meant to extend the input region of the frame window silently. Since most users of get_outer_rect cared about the frame rect, we kept that the same and added a new method, get_input_rect to get the full rect of the framed window with all invisible borders for input kept on. As time went on and CSD and Wayland became a reality, the relationship between the server-side geometry and the "frame rect" became more complicated, as can be evidenced by the recent commits. Since clients don't tend to be framed anymore, they set their own input region. get_buffer_rect is also sort of a poor name, since X11 doesn't really have buffers, but we don't really have many other alternatives. This doesn't change any of the code, nor the meaning. It will always refer to the rectangle where the toplevel should be placed.
2014-06-17 14:33:52 +00:00
* meta_window_get_buffer_rect:
MetaWindow: Repurpose get_outer_rect and add get_input_rect get_outer_rect now returns the visible region, and a new get_input_rect method returns the boundaries of the full frame, including the possible invisible regions. When undecorated, both do the samething. https://bugzilla.gnome.org/show_bug.cgi?id=644930
2011-06-29 17:37:04 +00:00
* @window: a #MetaWindow
* @rect: (out): pointer to an allocated #MetaRectangle
*
window: Rename get_input_rect to get_buffer_rect With get_input_region existing, get_input_rect is a misnomer. Really, it's about the geometry of the output surface, and it's only used that way in the compositor code. Way back when in GNOME 3.2, get_input_rect was added when we added invisible borders. get_outer_rect was always synonymous with server-side geometry of the toplevel. get_outer_rect was used for both user-side policy (the "frame rect") and to get the geometry of the window. Invisible borders were meant to extend the input region of the frame window silently. Since most users of get_outer_rect cared about the frame rect, we kept that the same and added a new method, get_input_rect to get the full rect of the framed window with all invisible borders for input kept on. As time went on and CSD and Wayland became a reality, the relationship between the server-side geometry and the "frame rect" became more complicated, as can be evidenced by the recent commits. Since clients don't tend to be framed anymore, they set their own input region. get_buffer_rect is also sort of a poor name, since X11 doesn't really have buffers, but we don't really have many other alternatives. This doesn't change any of the code, nor the meaning. It will always refer to the rectangle where the toplevel should be placed.
2014-06-17 14:33:52 +00:00
* Gets the rectangle that the pixmap or buffer of @window occupies.
*
* For X11 windows, this is the server-side geometry of the toplevel
* window.
*
* For Wayland windows, this is the bounding rectangle of the attached
* buffer.
MetaWindow: Repurpose get_outer_rect and add get_input_rect get_outer_rect now returns the visible region, and a new get_input_rect method returns the boundaries of the full frame, including the possible invisible regions. When undecorated, both do the samething. https://bugzilla.gnome.org/show_bug.cgi?id=644930
2011-06-29 17:37:04 +00:00
*/
void
window: Rename get_input_rect to get_buffer_rect With get_input_region existing, get_input_rect is a misnomer. Really, it's about the geometry of the output surface, and it's only used that way in the compositor code. Way back when in GNOME 3.2, get_input_rect was added when we added invisible borders. get_outer_rect was always synonymous with server-side geometry of the toplevel. get_outer_rect was used for both user-side policy (the "frame rect") and to get the geometry of the window. Invisible borders were meant to extend the input region of the frame window silently. Since most users of get_outer_rect cared about the frame rect, we kept that the same and added a new method, get_input_rect to get the full rect of the framed window with all invisible borders for input kept on. As time went on and CSD and Wayland became a reality, the relationship between the server-side geometry and the "frame rect" became more complicated, as can be evidenced by the recent commits. Since clients don't tend to be framed anymore, they set their own input region. get_buffer_rect is also sort of a poor name, since X11 doesn't really have buffers, but we don't really have many other alternatives. This doesn't change any of the code, nor the meaning. It will always refer to the rectangle where the toplevel should be placed.
2014-06-17 14:33:52 +00:00
meta_window_get_buffer_rect (const MetaWindow *window,
MetaRectangle *rect)
MetaWindow: Repurpose get_outer_rect and add get_input_rect get_outer_rect now returns the visible region, and a new get_input_rect method returns the boundaries of the full frame, including the possible invisible regions. When undecorated, both do the samething. https://bugzilla.gnome.org/show_bug.cgi?id=644930
2011-06-29 17:37:04 +00:00
{
window: Save the buffer_rect internally Rather than calculate it speculatively with the current properties which may be too new or too out of date, make sure it always fits with the proper definition. We update it when we update the toplevel window for X11, and when a Wayland surface is committed with a newly attached buffer.
2014-06-17 15:03:29 +00:00
*rect = window->buffer_rect;
MetaWindow: Repurpose get_outer_rect and add get_input_rect get_outer_rect now returns the visible region, and a new get_input_rect method returns the boundaries of the full frame, including the possible invisible regions. When undecorated, both do the samething. https://bugzilla.gnome.org/show_bug.cgi?id=644930
2011-06-29 17:37:04 +00:00
}
Use utility functions to convert between frame and client rectangles There are extensive places in the code where we convert between the client rectangle and the frame rectangle. Instead of manually doing it use new helper functions on MetaWindow and the existing meta_window_get_outer_rect(). This fixes a number of bugs where the computation was being done incorrectly, most of these bugs are with the recently added custom frame extents, but some relate to invisible borders or even simply to confusion between the window and frame rectangle. Switch the placement code to place the frame rectangle rather than the client window - this simplifies things considerably. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 21:11:20 +00:00
/**
* meta_window_client_rect_to_frame_rect:
* @window: a #MetaWindow
window: Proper argument naming for meta_window_client_rect_to_frame_rect (cherry picked from commit 9b88059e55a0d4c8eea89518388116e88dc4c240)
2013-11-29 12:52:18 +00:00
* @client_rect: client rectangle in root coordinates
* @frame_rect: (out): location to store the computed corresponding frame bounds.
Use utility functions to convert between frame and client rectangles There are extensive places in the code where we convert between the client rectangle and the frame rectangle. Instead of manually doing it use new helper functions on MetaWindow and the existing meta_window_get_outer_rect(). This fixes a number of bugs where the computation was being done incorrectly, most of these bugs are with the recently added custom frame extents, but some relate to invisible borders or even simply to confusion between the window and frame rectangle. Switch the placement code to place the frame rectangle rather than the client window - this simplifies things considerably. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 21:11:20 +00:00
*
window: Don't reference a dead function meta_window_move_resize has been gone for a while now.
2015-07-06 07:52:49 +00:00
* Converts a desired bounds of the client window into the corresponding bounds
* of the window frame (excluding invisible borders and client side shadows.)
Use utility functions to convert between frame and client rectangles There are extensive places in the code where we convert between the client rectangle and the frame rectangle. Instead of manually doing it use new helper functions on MetaWindow and the existing meta_window_get_outer_rect(). This fixes a number of bugs where the computation was being done incorrectly, most of these bugs are with the recently added custom frame extents, but some relate to invisible borders or even simply to confusion between the window and frame rectangle. Switch the placement code to place the frame rectangle rather than the client window - this simplifies things considerably. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 21:11:20 +00:00
*/
void
meta_window_client_rect_to_frame_rect (MetaWindow *window,
window: Proper argument naming for meta_window_client_rect_to_frame_rect (cherry picked from commit 9b88059e55a0d4c8eea89518388116e88dc4c240)
2013-11-29 12:52:18 +00:00
MetaRectangle *client_rect,
MetaRectangle *frame_rect)
Use utility functions to convert between frame and client rectangles There are extensive places in the code where we convert between the client rectangle and the frame rectangle. Instead of manually doing it use new helper functions on MetaWindow and the existing meta_window_get_outer_rect(). This fixes a number of bugs where the computation was being done incorrectly, most of these bugs are with the recently added custom frame extents, but some relate to invisible borders or even simply to confusion between the window and frame rectangle. Switch the placement code to place the frame rectangle rather than the client window - this simplifies things considerably. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 21:11:20 +00:00
{
window: Proper argument naming for meta_window_client_rect_to_frame_rect (cherry picked from commit 9b88059e55a0d4c8eea89518388116e88dc4c240)
2013-11-29 12:52:18 +00:00
if (!frame_rect)
Use utility functions to convert between frame and client rectangles There are extensive places in the code where we convert between the client rectangle and the frame rectangle. Instead of manually doing it use new helper functions on MetaWindow and the existing meta_window_get_outer_rect(). This fixes a number of bugs where the computation was being done incorrectly, most of these bugs are with the recently added custom frame extents, but some relate to invisible borders or even simply to confusion between the window and frame rectangle. Switch the placement code to place the frame rectangle rather than the client window - this simplifies things considerably. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 21:11:20 +00:00
return;
window: Proper argument naming for meta_window_client_rect_to_frame_rect (cherry picked from commit 9b88059e55a0d4c8eea89518388116e88dc4c240)
2013-11-29 12:52:18 +00:00
*frame_rect = *client_rect;
Use utility functions to convert between frame and client rectangles There are extensive places in the code where we convert between the client rectangle and the frame rectangle. Instead of manually doing it use new helper functions on MetaWindow and the existing meta_window_get_outer_rect(). This fixes a number of bugs where the computation was being done incorrectly, most of these bugs are with the recently added custom frame extents, but some relate to invisible borders or even simply to confusion between the window and frame rectangle. Switch the placement code to place the frame rectangle rather than the client window - this simplifies things considerably. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 21:11:20 +00:00
Stop passing around MetaFrameBorders Instead of passing around MetaFrameBorders, compute it when we need it. This also allows us to know that we are using MetaFrameBorders only for windows with frames (where it is meaningful) and not for frameless windows, which can have custom borders which we need to interpret differently. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 23:03:50 +00:00
/* The support for G_MAXINT here to mean infinity is a convenience for
* constraints.c:get_size_limits() and not something that we provide
* in other locations or document.
*/
Use utility functions to convert between frame and client rectangles There are extensive places in the code where we convert between the client rectangle and the frame rectangle. Instead of manually doing it use new helper functions on MetaWindow and the existing meta_window_get_outer_rect(). This fixes a number of bugs where the computation was being done incorrectly, most of these bugs are with the recently added custom frame extents, but some relate to invisible borders or even simply to confusion between the window and frame rectangle. Switch the placement code to place the frame rectangle rather than the client window - this simplifies things considerably. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 21:11:20 +00:00
if (window->frame)
{
MetaFrameBorders borders;
meta_frame_calc_borders (window->frame, &borders);
window: Proper argument naming for meta_window_client_rect_to_frame_rect (cherry picked from commit 9b88059e55a0d4c8eea89518388116e88dc4c240)
2013-11-29 12:52:18 +00:00
frame_rect->x -= borders.visible.left;
frame_rect->y -= borders.visible.top;
if (frame_rect->width != G_MAXINT)
frame_rect->width += borders.visible.left + borders.visible.right;
if (frame_rect->height != G_MAXINT)
frame_rect->height += borders.visible.top + borders.visible.bottom;
Use utility functions to convert between frame and client rectangles There are extensive places in the code where we convert between the client rectangle and the frame rectangle. Instead of manually doing it use new helper functions on MetaWindow and the existing meta_window_get_outer_rect(). This fixes a number of bugs where the computation was being done incorrectly, most of these bugs are with the recently added custom frame extents, but some relate to invisible borders or even simply to confusion between the window and frame rectangle. Switch the placement code to place the frame rectangle rather than the client window - this simplifies things considerably. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 21:11:20 +00:00
}
else
{
window: Set custom frame extents to 0 if we don't have any This is just a quick code cleanup.
2014-06-26 15:13:09 +00:00
const GtkBorder *extents = &window->custom_frame_extents;
frame_rect->x += extents->left;
frame_rect->y += extents->top;
if (frame_rect->width != G_MAXINT)
frame_rect->width -= extents->left + extents->right;
if (frame_rect->height != G_MAXINT)
frame_rect->height -= extents->top + extents->bottom;
Use utility functions to convert between frame and client rectangles There are extensive places in the code where we convert between the client rectangle and the frame rectangle. Instead of manually doing it use new helper functions on MetaWindow and the existing meta_window_get_outer_rect(). This fixes a number of bugs where the computation was being done incorrectly, most of these bugs are with the recently added custom frame extents, but some relate to invisible borders or even simply to confusion between the window and frame rectangle. Switch the placement code to place the frame rectangle rather than the client window - this simplifies things considerably. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 21:11:20 +00:00
}
}
/**
* meta_window_frame_rect_to_client_rect:
* @window: a #MetaWindow
* @frame_rect: desired frame bounds for the window
* @client_rect: (out): location to store the computed corresponding client rectangle.
*
* Converts a desired frame bounds for a window into the bounds of the client
window: Don't reference a dead function meta_window_move_resize has been gone for a while now.
2015-07-06 07:52:49 +00:00
* window.
Use utility functions to convert between frame and client rectangles There are extensive places in the code where we convert between the client rectangle and the frame rectangle. Instead of manually doing it use new helper functions on MetaWindow and the existing meta_window_get_outer_rect(). This fixes a number of bugs where the computation was being done incorrectly, most of these bugs are with the recently added custom frame extents, but some relate to invisible borders or even simply to confusion between the window and frame rectangle. Switch the placement code to place the frame rectangle rather than the client window - this simplifies things considerably. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 21:11:20 +00:00
*/
void
meta_window_frame_rect_to_client_rect (MetaWindow *window,
MetaRectangle *frame_rect,
MetaRectangle *client_rect)
{
if (!client_rect)
return;
*client_rect = *frame_rect;
if (window->frame)
{
MetaFrameBorders borders;
meta_frame_calc_borders (window->frame, &borders);
client_rect->x += borders.visible.left;
client_rect->y += borders.visible.top;
client_rect->width -= borders.visible.left + borders.visible.right;
client_rect->height -= borders.visible.top + borders.visible.bottom;
}
else
{
window: Set custom frame extents to 0 if we don't have any This is just a quick code cleanup.
2014-06-26 15:13:09 +00:00
const GtkBorder *extents = &window->custom_frame_extents;
client_rect->x -= extents->left;
client_rect->y -= extents->top;
client_rect->width += extents->left + extents->right;
client_rect->height += extents->top + extents->bottom;
Use utility functions to convert between frame and client rectangles There are extensive places in the code where we convert between the client rectangle and the frame rectangle. Instead of manually doing it use new helper functions on MetaWindow and the existing meta_window_get_outer_rect(). This fixes a number of bugs where the computation was being done incorrectly, most of these bugs are with the recently added custom frame extents, but some relate to invisible borders or even simply to confusion between the window and frame rectangle. Switch the placement code to place the frame rectangle rather than the client window - this simplifies things considerably. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 21:11:20 +00:00
}
}
Add (out) annotation and documentation to meta_window_get_outer_rectangle() GObject introspection cannot detect that rect is an (out) parameter. Also add a meaningful documentation for humans like us.
2010-11-22 21:26:37 +00:00
/**
Rename meta_window_get_outer_rect() to meta_window_get_frame_rect() For clarity, rename meta_window_get_outer_rect() to match terminology we use elsewhere. The old function is left as a deprecated compatibility wrapper.
2013-11-19 17:24:45 +00:00
* meta_window_get_frame_rect:
Add (out) annotation and documentation to meta_window_get_outer_rectangle() GObject introspection cannot detect that rect is an (out) parameter. Also add a meaningful documentation for humans like us.
2010-11-22 21:26:37 +00:00
* @window: a #MetaWindow
* @rect: (out): pointer to an allocated #MetaRectangle
*
Rename meta_window_get_outer_rect() to meta_window_get_frame_rect() For clarity, rename meta_window_get_outer_rect() to match terminology we use elsewhere. The old function is left as a deprecated compatibility wrapper.
2013-11-19 17:24:45 +00:00
* Gets the rectangle that bounds @window that is what the user thinks of
* as the edge of the window. This doesn't include any extra reactive
* area that we or the client adds to the window, or any area that the
* client adds to draw a client-side shadow.
Add (out) annotation and documentation to meta_window_get_outer_rectangle() GObject introspection cannot detect that rect is an (out) parameter. Also add a meaningful documentation for humans like us.
2010-11-22 21:26:37 +00:00
*/
...
2001-07-12 05:53:56 +00:00
void
Rename meta_window_get_outer_rect() to meta_window_get_frame_rect() For clarity, rename meta_window_get_outer_rect() to match terminology we use elsewhere. The old function is left as a deprecated compatibility wrapper.
2013-11-19 17:24:45 +00:00
meta_window_get_frame_rect (const MetaWindow *window,
Make the taskbar less flash happy and fix up some related stacking issues. 2006-01-09 Elijah Newren <newren@gmail.com> Make the taskbar less flash happy and fix up some related stacking issues. #326035. * src/window.c (windows_overlap): new function, (meta_window_show): if a window is denied focus but doesn't overlap with the focus window there is no need to set the demands attention hint nor stack that window below the focus window, (meta_window_get_outer_rect): we're not modifying the window so declare it to be const
2006-01-10 05:14:48 +00:00
MetaRectangle *rect)
...
2001-07-12 05:53:56 +00:00
{
window: Refactor all move/resize operations to be in frame rect space For Wayland, we want to have everything possible in terms of the frame rect, or "window geometry" as the Wayland protocol calls it, in order to properly eliminate some flashing when changing states to fullscreen or similar. For this, we need to heavily refactor how the code is structured, and make it so that meta_window_move_resize_internal is specified in terms of the frame rect coordinate space, and transforming all entry points to meta_window_move_resize_internal. This is a big commit that's hard to tear apart. I tried to split it as best I can, but there's still just a large amount of changes that need to happen at once. Expect some regressions from this. Sorry for any temporary regression that this might cause.
2014-05-20 21:47:10 +00:00
*rect = window->rect;
...
2001-07-12 05:53:56 +00:00
}
window: Add meta_window_get_client_area_rect
2014-02-27 00:33:43 +00:00
/**
* meta_window_get_client_area_rect:
* @window: a #MetaWindow
* @rect: (out): pointer to a cairo rectangle
*
* Gets the rectangle for the boundaries of the client area, relative
window: Fix get_client_area_rect for the frame rect conversion Specifically for CSD windows -- this was just absolutely wrong before. This fixes weird painting and clipping artifacts for CSD windows.
2014-06-27 15:56:52 +00:00
* to the buffer rect. If the window is shaded, the height of the
* rectangle is 0.
window: Add meta_window_get_client_area_rect
2014-02-27 00:33:43 +00:00
*/
void
meta_window_get_client_area_rect (const MetaWindow *window,
cairo_rectangle_int_t *rect)
{
window: Refactor all move/resize operations to be in frame rect space For Wayland, we want to have everything possible in terms of the frame rect, or "window geometry" as the Wayland protocol calls it, in order to properly eliminate some flashing when changing states to fullscreen or similar. For this, we need to heavily refactor how the code is structured, and make it so that meta_window_move_resize_internal is specified in terms of the frame rect coordinate space, and transforming all entry points to meta_window_move_resize_internal. This is a big commit that's hard to tear apart. I tried to split it as best I can, but there's still just a large amount of changes that need to happen at once. Expect some regressions from this. Sorry for any temporary regression that this might cause.
2014-05-20 21:47:10 +00:00
MetaFrameBorders borders;
meta_frame_calc_borders (window->frame, &borders);
rect->x = borders.total.left;
rect->y = borders.total.top;
window: Add meta_window_get_client_area_rect
2014-02-27 00:33:43 +00:00
window: Fix get_client_area_rect for the frame rect conversion Specifically for CSD windows -- this was just absolutely wrong before. This fixes weird painting and clipping artifacts for CSD windows.
2014-06-27 15:56:52 +00:00
rect->width = window->buffer_rect.width - borders.total.left - borders.total.right;
window: Add meta_window_get_client_area_rect
2014-02-27 00:33:43 +00:00
if (window->shaded)
rect->height = 0;
window: Fix meta_window_get_client_area_rect The shaded logic here was backwards.
2014-02-27 15:32:19 +00:00
else
window: Fix get_client_area_rect for the frame rect conversion Specifically for CSD windows -- this was just absolutely wrong before. This fixes weird painting and clipping artifacts for CSD windows.
2014-06-27 15:56:52 +00:00
rect->height = window->buffer_rect.height - borders.total.top - borders.total.bottom;
window: Add meta_window_get_client_area_rect
2014-02-27 00:33:43 +00:00
}
window: Add a meta_window_get_titlebar_rect
2014-05-22 20:48:58 +00:00
void
meta_window_get_titlebar_rect (MetaWindow *window,
MetaRectangle *rect)
{
meta_window_get_frame_rect (window, rect);
/* The returned rectangle is relative to the frame rect. */
rect->x = 0;
rect->y = 0;
if (window->frame)
{
rect->height = window->frame->child_y;
}
else
{
/* Pick an arbitrary height for a titlebar. We might want to
* eventually have CSD windows expose their borders to us. */
window: Increase the height of CSD titlebars This seems to be more accurate with what we currently see in GNOME. Without having the app expose this information to us, it might be a better idea to use the default frame style for this information instead.
2014-08-19 17:58:45 +00:00
rect->height = 50;
window: Add a meta_window_get_titlebar_rect
2014-05-22 20:48:58 +00:00
}
}
lengthen to 15 seconds 2002-11-30 Havoc Pennington <hp@pobox.com> * src/screen.c (STARTUP_TIMEOUT): lengthen to 15 seconds * src/util.c (utf8_fputs): hmm, return a value * src/screen.c (meta_screen_apply_startup_properties): new function to apply initial workspace based on startup sequence. * src/window.c (meta_window_new): load _NET_STARTUP_ID (meta_window_get_startup_id): new function * src/window-props.c (meta_display_init_window_prop_hooks): add hooks for _NET_STARTUP_ID * src/display.c (event_callback): send property events to groups. * src/xprops.c (meta_prop_get_values): make a type of INVALID mean to ignore that property (don't fetch its value). * src/group.c (meta_group_property_notify): new function * src/screen.c (set_supported_hint): support _NET_STARTUP_ID * src/display.c (meta_display_open): add _NET_STARTUP_ID to atoms we initialize * src/group-private.h: private header shared between group-props.c, group.c * src/group-props.h, src/group-props.c: new files to contain functions for retrieving group properties * src/window.c (meta_window_same_application): change this a bit to work with new definition of group * src/group.c (meta_window_get_group): always create a group for every window, using the window's own ID as group leader if required. * src/window.c (update_wm_hints): handle changes to group leader * src/group.c (meta_window_group_leader_changed): new function * src/display.h (struct _MetaDisplay): _NET_WM_WINDOW_TYPE_SPLASH, not SPLASHSCREEN. Reported by Gregory Merchan and Matthias Clasen. * src/screen.c (startup_sequence_timeout): when timing out a startup sequence, send a remove message, don't just time it out locally.
2002-12-01 03:58:04 +00:00
const char*
meta_window_get_startup_id (MetaWindow *window)
{
if (window->startup_id == NULL)
{
MetaGroup *group;
group = meta_window_get_group (window);
if (group != NULL)
return meta_group_get_startup_id (group);
}
return window->startup_id;
}
Refuse to focus a window with a modal transient, and focus the transient 2005-01-25 Elijah Newren <newren@gmail.com> Refuse to focus a window with a modal transient, and focus the transient instead. Fixes #164716. * src/window.c: (get_modal_transient): new function, (meta_window_focus): if the window has a modal transient, make sure it is on the current workspace and then focus it instead.
2005-01-25 17:26:06 +00:00
static MetaWindow*
get_modal_transient (MetaWindow *window)
{
GSList *windows;
GSList *tmp;
MetaWindow *modal_transient;
/* A window can't be the transient of itself, but this is just for
* convenience in the loop below; we manually fix things up at the
* end if no real modal transient was found.
*/
modal_transient = window;
meta_display_list_windows: Exclude override-redirect Don't include override-redirect windows in the list return by meta_display_list_windows(), since we almost never want to handle them when considering "all window" for the display. Add a separate meta_display_list_all_windows() that includes override-redirect windows. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-15 19:32:23 +00:00
windows = meta_display_list_windows (window->display, META_LIST_DEFAULT);
Refuse to focus a window with a modal transient, and focus the transient 2005-01-25 Elijah Newren <newren@gmail.com> Refuse to focus a window with a modal transient, and focus the transient instead. Fixes #164716. * src/window.c: (get_modal_transient): new function, (meta_window_focus): if the window has a modal transient, make sure it is on the current workspace and then focus it instead.
2005-01-25 17:26:06 +00:00
tmp = windows;
while (tmp != NULL)
{
MetaWindow *transient = tmp->data;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
if (transient->transient_for == modal_transient &&
Replace wm_state_modal usage with META_WINDOW_TYPE_DIALOG
2014-03-18 14:58:26 +00:00
transient->type == META_WINDOW_MODAL_DIALOG)
Refuse to focus a window with a modal transient, and focus the transient 2005-01-25 Elijah Newren <newren@gmail.com> Refuse to focus a window with a modal transient, and focus the transient instead. Fixes #164716. * src/window.c: (get_modal_transient): new function, (meta_window_focus): if the window has a modal transient, make sure it is on the current workspace and then focus it instead.
2005-01-25 17:26:06 +00:00
{
modal_transient = transient;
tmp = windows;
continue;
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Refuse to focus a window with a modal transient, and focus the transient 2005-01-25 Elijah Newren <newren@gmail.com> Refuse to focus a window with a modal transient, and focus the transient instead. Fixes #164716. * src/window.c: (get_modal_transient): new function, (meta_window_focus): if the window has a modal transient, make sure it is on the current workspace and then focus it instead.
2005-01-25 17:26:06 +00:00
tmp = tmp->next;
}
g_slist_free (windows);
if (window == modal_transient)
modal_transient = NULL;
return modal_transient;
}
window: Fix focus of unmappable modal transient's parent When a modal transient is unmanaging, most likely the parent of the modal transient should be focused. In Wayland, a MetaWindow is created when a shell surface role (like xdg_toplevel) is created, but a window cannot be shown until a buffer is attached. If a client would create two modal transients and make them both have the same parent, but only one get a buffer attached (i.e. shown), when unmanaging the modal transient that was showing, when finding a new focus candidate, the stacking code will ignore the not-to-be-shown buffer-less modal transient when finding a good candidate for focusing. In the case described here, this means it will find the parent of the unmanaging modal transient. This newly chosen candidate will then be passed to meta_window_focus(); meta_window_focus() will then try to find any modal transient to focus instead, will find the one without any buffer, then fail to focus it because it cannot be mapped, thus making meta_window_focus() not focus anything. Since meta_window_focus() didn't change any focus state, the assert in meta_window_unmanage() checking that the unmanaging window isn't focused anymore will be hit, causing mutter to abort. For now, fix this by checking whether the modal transient can actually be focused in meta_window_focus(). For X11 client windows, a window will be defined to be focusable always, but for Wayland client windows, a window will be determined focusable only if it has a buffer attached. In the future, we should probably do a more thorough refactorization of focus handling to get rid of any X11 - Wayland differences. https://bugzilla.gnome.org/show_bug.cgi?id=757568
2016-09-01 10:42:58 +00:00
static gboolean
meta_window_transient_can_focus (MetaWindow *window)
{
#ifdef HAVE_WAYLAND
if (window->client_type == META_WINDOW_CLIENT_TYPE_WAYLAND)
return meta_wayland_surface_get_buffer (window->surface) != NULL;
#endif
return TRUE;
}
Move shrink effect code from compositor.c to c-window.c. Stubs for restore effect. Notes in various places for where to hook in other effects.
2006-05-23 21:42:34 +00:00
/* XXX META_EFFECT_FOCUS */
...
2001-06-04 04:58:22 +00:00
void
meta_window_focus (MetaWindow *window,
Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ 2006-09-13 Elijah Newren <newren gmail com> * src/common.h (MetaWindowMenuFunc): * src/core.[ch] (meta_core_user_lower_and_unfocus, meta_core_user_focus, meta_core_show_window_menu, meta_core_begin_grab_op, meta_core_end_grab_op): * src/delete.c (delete_ping_reply_func, delete_ping_timeout_func, meta_window_delete): * src/display.[ch] (struct MetaDisplay, struct MetaPingData, sanity_check_timestamps, meta_display_open, event_callback, meta_spew_event, meta_display_set_grab_op_cursor, meta_display_begin_grab_op, meta_display_end_grab_op, meta_display_ping_timeout, meta_display_ping_window, process_pong_message, timestamp_too_old, meta_display_set_input_focus_window): * src/keybindings.[ch] (grab_keyboard, ungrab_keyboard, meta_screen_grab_all_keys, meta_window_grab_all_keys, meta_window_ungrab_all_keys, error_on_generic_command, error_on_command, error_on_terminal_command): * src/metacity-dialog.c (on_realize, warn_about_no_sm_support, error_about_command, main): * src/screen.[ch] (struct _MetaScreen, meta_screen_new, meta_screen_show_desktop, meta_screen_apply_startup_properties): * src/session.c (warn_about_lame_clients_and_finish_interact): * src/window.[ch] (struct _MetaWindow, intervening_user_event_occurred, window_activate, meta_window_delete, meta_window_focus, meta_window_send_icccm_message, meta_window_client_message, menu_callback, meta_window_show_menu, struct EventScannerData, check_use_this_motion_notify, meta_window_begin_grab_op, meta_window_set_user_time): * src/workspace.[ch] (focus_ancestor_or_mru_window, meta_workspace_activate_with_focus, meta_workspace_activate, meta_workspace_focus_default_window, focus_ancestor_or_mru_window): Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ does) instead of Time. #348305
2006-09-13 16:32:33 +00:00
guint32 timestamp)
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
Refuse to focus a window with a modal transient, and focus the transient 2005-01-25 Elijah Newren <newren@gmail.com> Refuse to focus a window with a modal transient, and focus the transient instead. Fixes #164716. * src/window.c: (get_modal_transient): new function, (meta_window_focus): if the window has a modal transient, make sure it is on the current workspace and then focus it instead.
2005-01-25 17:26:06 +00:00
MetaWindow *modal_transient;
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
core: Preserve focus across decoration changes Changes in window decoration result in the window being reparented in and out its frame. This in turn causes unmap/map events, and XI_FocusOut if the window happened to be focused. In order to preserve the focused window across the decoration change, add a flag so that the focus may be restored on MapNotify. Closes: #273
2018-08-21 22:58:06 +00:00
/* This is a oneshot flag */
window->restore_focus_on_map = FALSE;
focus top window when switching to a new workspace 2002-01-03 Havoc Pennington <hp@pobox.com> * src/workspace.c (meta_workspace_activate): focus top window when switching to a new workspace * src/util.c (meta_topic): start putting verbose output in categories * src/window.c (meta_window_shade): focus frame after we queue the calc_showing so the maps/unmaps have already happened. * src/display.c (meta_display_get_current_time): add the "get time of current event" function and call it occasionally. * src/window.c (meta_window_free): if we have focus, call meta_screen_focus_top_window(). (meta_window_minimize): ditto (meta_window_delete): ditto * src/screen.c (meta_screen_ensure_tab_popup): fix memory leak - didn't free tab list (meta_screen_focus_top_window): new function to use when we unmap or unmanage a focused window * src/stack.c (meta_stack_get_default_focus_window): function used in meta_screen_focus_top_window
2002-01-03 23:28:19 +00:00
meta_topic (META_DEBUG_FOCUS,
window-x11: Move take_focus to MetaWindowX11Private https://gitlab.gnome.org/GNOME/mutter/merge_requests/421
2019-01-30 19:19:41 +00:00
"Setting input focus to window %s, input: %d focusable: %d\n",
window->desc, window->input, meta_window_is_focusable (window));
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-07-11 06:22:00 +00:00
if (window->display->grab_window &&
window: Don't refuse to move focus to the grab window We refuse to move focus while a grab operation is in place. While this generally makes sense, there's no reason why the window that owns the grab shouldn't be given the regular input focus as well - we pretty much assume that the grab window is also the focus window anyway. In fact there's a strong reason for allowing the focus change here: If the grab window isn't the focus window, it probably has a modal transient that is focused instead, and a likely reason for the focus request is that the transient is being unmanaged and we must move the focus elsewhere. https://gitlab.gnome.org/GNOME/mutter/issues/15
2018-05-25 18:18:23 +00:00
window->display->grab_window != window &&
Be willing to unfocus the grab window when we are unmanaging it When we are unmanaging the grab window, we /need/ to unfocus it, so we shouldn't bail out early from meta_window_focus(). https://bugzilla.gnome.org/show_bug.cgi?id=711618
2013-12-18 14:23:08 +00:00
window->display->grab_window->all_keys_grabbed &&
!window->display->grab_window->unmanaging)
...
2001-07-11 06:22:00 +00:00
{
GTK 1.2 plug/socket clients still broken, don't know why. 2002-01-05 Havoc Pennington <hp@pobox.com> GTK 1.2 plug/socket clients still broken, don't know why. * src/screen.c (meta_screen_new): select focus change on root window, for debugging * src/display.c (event_callback): when unfocusing, use no_focus_window to hold the focus * src/display.h (struct _MetaDisplay): have a no_focus_window to hold the focus when we don't want to have anything focused. Then we can avoid confusing focusing-the-frame stuff. * src/window.c (meta_window_notify_focus): improve some debug spew (meta_window_notify_focus): add hack from WindowMaker to ignore focus in events with detail > NotifyNonlinearVirtual
2002-01-06 03:15:49 +00:00
meta_topic (META_DEBUG_FOCUS,
"Current focus window %s has global keygrab, not focusing window %s after all\n",
window->display->grab_window->desc, window->desc);
...
2001-07-11 06:22:00 +00:00
return;
}
note exciting new unminimize feature for the tab popup 2001-10-29 Havoc Pennington <hp@pobox.com> * README: note exciting new unminimize feature for the tab popup * src/keybindings.c (process_tab_grab): use meta_window_activate() when choosing a window with tab popup, this should deiconify it * src/window.c (meta_window_client_message): use meta_window_activate for _NET_ACTIVE_WINDOW message (meta_window_activate): new function to raise/focus/unminimize (meta_window_flush_calc_showing): new function (meta_window_focus): force a calc showing on focus, so that we can focus the window if appropriate (it must be mapped)
2001-10-29 07:00:46 +00:00
Refuse to focus a window with a modal transient, and focus the transient 2005-01-25 Elijah Newren <newren@gmail.com> Refuse to focus a window with a modal transient, and focus the transient instead. Fixes #164716. * src/window.c: (get_modal_transient): new function, (meta_window_focus): if the window has a modal transient, make sure it is on the current workspace and then focus it instead.
2005-01-25 17:26:06 +00:00
modal_transient = get_modal_transient (window);
if the window has a modal transient which is being unmanaged, don't focus 2005-06-02 Elijah Newren <newren@gmail.com> * src/window.c (meta_window_focus): if the window has a modal transient which is being unmanaged, don't focus it. Fixes the Metacity issue reported in #305362.
2005-06-02 15:24:40 +00:00
if (modal_transient != NULL &&
window: Fix focus of unmappable modal transient's parent When a modal transient is unmanaging, most likely the parent of the modal transient should be focused. In Wayland, a MetaWindow is created when a shell surface role (like xdg_toplevel) is created, but a window cannot be shown until a buffer is attached. If a client would create two modal transients and make them both have the same parent, but only one get a buffer attached (i.e. shown), when unmanaging the modal transient that was showing, when finding a new focus candidate, the stacking code will ignore the not-to-be-shown buffer-less modal transient when finding a good candidate for focusing. In the case described here, this means it will find the parent of the unmanaging modal transient. This newly chosen candidate will then be passed to meta_window_focus(); meta_window_focus() will then try to find any modal transient to focus instead, will find the one without any buffer, then fail to focus it because it cannot be mapped, thus making meta_window_focus() not focus anything. Since meta_window_focus() didn't change any focus state, the assert in meta_window_unmanage() checking that the unmanaging window isn't focused anymore will be hit, causing mutter to abort. For now, fix this by checking whether the modal transient can actually be focused in meta_window_focus(). For X11 client windows, a window will be defined to be focusable always, but for Wayland client windows, a window will be determined focusable only if it has a buffer attached. In the future, we should probably do a more thorough refactorization of focus handling to get rid of any X11 - Wayland differences. https://bugzilla.gnome.org/show_bug.cgi?id=757568
2016-09-01 10:42:58 +00:00
!modal_transient->unmanaging &&
meta_window_transient_can_focus (modal_transient))
Refuse to focus a window with a modal transient, and focus the transient 2005-01-25 Elijah Newren <newren@gmail.com> Refuse to focus a window with a modal transient, and focus the transient instead. Fixes #164716. * src/window.c: (get_modal_transient): new function, (meta_window_focus): if the window has a modal transient, make sure it is on the current workspace and then focus it instead.
2005-01-25 17:26:06 +00:00
{
meta_topic (META_DEBUG_FOCUS,
"%s has %s as a modal transient, so focusing it instead.\n",
window->desc, modal_transient->desc);
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
if (!meta_window_located_on_workspace (modal_transient, workspace_manager->active_workspace))
meta_window_change_workspace (modal_transient, workspace_manager->active_workspace);
Refuse to focus a window with a modal transient, and focus the transient 2005-01-25 Elijah Newren <newren@gmail.com> Refuse to focus a window with a modal transient, and focus the transient instead. Fixes #164716. * src/window.c: (get_modal_transient): new function, (meta_window_focus): if the window has a modal transient, make sure it is on the current workspace and then focus it instead.
2005-01-25 17:26:06 +00:00
window = modal_transient;
}
note exciting new unminimize feature for the tab popup 2001-10-29 Havoc Pennington <hp@pobox.com> * README: note exciting new unminimize feature for the tab popup * src/keybindings.c (process_tab_grab): use meta_window_activate() when choosing a window with tab popup, this should deiconify it * src/window.c (meta_window_client_message): use meta_window_activate for _NET_ACTIVE_WINDOW message (meta_window_activate): new function to raise/focus/unminimize (meta_window_flush_calc_showing): new function (meta_window_focus): force a calc showing on focus, so that we can focus the window if appropriate (it must be mapped)
2001-10-29 07:00:46 +00:00
meta_window_flush_calc_showing (window);
if window is not mapped after the calc_showing, don't focus it, it's 2002-05-10 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_focus): if window is not mapped after the calc_showing, don't focus it, it's probably on another workspace or something.
2002-05-11 02:25:11 +00:00
Tries to consider how window->hidden affects existing window->mapped tests src/core does some things depending on window->mapped, but since we now leave the window mapped for hidden windows we might get some wrong descisions. Also instead of calling meta_window_show when in meta_window_hide for the case that the window isn't currently mapped, we now simply XMapWindow.
2008-11-03 12:36:55 +00:00
if ((!window->mapped || window->hidden) && !window->shaded)
if window is not mapped after the calc_showing, don't focus it, it's 2002-05-10 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_focus): if window is not mapped after the calc_showing, don't focus it, it's probably on another workspace or something.
2002-05-11 02:25:11 +00:00
{
meta_topic (META_DEBUG_FOCUS,
"Window %s is not showing, not focusing after all\n",
window->desc);
return;
}
Fix some support for EWMH hints, and fix USER_TIME support to include the 2004-07-31 Rob Adams <readams@readams.net> Fix some support for EWMH hints, and fix USER_TIME support to include the DEMANDS_ATTENTION hint. Also includes some code for implementing _NET_RESTACK_WINDOW and _NET_MOVERESIZE_WINDOW, but this is disabled pending feature thaw. * COMPLIANCE: update with new information * src/display.c (meta_display_open): add new hints to list * src/display.h (_MetaDisplay): Add new atoms to struct * src/screen.c (set_supported_hint): update the list of support hints. (set_desktop_viewport_hint): new function sets the viewport hint to (0,0) as required by the spec for WMs with no viewport support. (set_desktop_geometry_hint): new function to set the desktop size hint to the size of the display, since we don't implement large desktop support, as required by the spec. (meta_screen_resize): update the geometry hint on screen resize * src/window.c (meta_window_new_with_attrs): Initialize demands_attention state (set_net_wm_state): Set demands_attention hint in the window state (meta_window_show): If we don't pop up a window because of USER_TIME, set DEMANDS_ATTENTION on the window. (meta_window_focus): When a window receives focus, remove DEMANDS_ATTENTION hint (meta_window_client_message): Allow other apps to set DEMANDS_ATTENTION on a window. Also, if the _NET_ACTIVE_WINDOW hint includes a timestamp, use it. (update_net_wm_state): Read DEMANDS_ATTENTION state also * src/window.h (_MetaWindow): add wm_state_demands_attention bit.
2004-07-31 19:56:10 +00:00
window: Check window responsiveness on every window focus Increase the number of checks whether a window is still responsive and ping windows on every call to `meta_window_focus()` instead of `meta_window_activate_full()`. This ensures the window is also pinged in case normal interaction like clicks on the window happen and a close dialog will eventually get shown. Related https://gitlab.gnome.org/GNOME/mutter/issues/395 https://gitlab.gnome.org/GNOME/mutter/merge_requests/891
2019-10-15 16:29:27 +00:00
meta_window_check_alive (window, timestamp);
Move focus to be a vfunc
2014-03-20 19:16:57 +00:00
META_WINDOW_GET_CLASS (window)->focus (window, timestamp);
Fix some support for EWMH hints, and fix USER_TIME support to include the 2004-07-31 Rob Adams <readams@readams.net> Fix some support for EWMH hints, and fix USER_TIME support to include the DEMANDS_ATTENTION hint. Also includes some code for implementing _NET_RESTACK_WINDOW and _NET_MOVERESIZE_WINDOW, but this is disabled pending feature thaw. * COMPLIANCE: update with new information * src/display.c (meta_display_open): add new hints to list * src/display.h (_MetaDisplay): Add new atoms to struct * src/screen.c (set_supported_hint): update the list of support hints. (set_desktop_viewport_hint): new function sets the viewport hint to (0,0) as required by the spec for WMs with no viewport support. (set_desktop_geometry_hint): new function to set the desktop size hint to the size of the display, since we don't implement large desktop support, as required by the spec. (meta_screen_resize): update the geometry hint on screen resize * src/window.c (meta_window_new_with_attrs): Initialize demands_attention state (set_net_wm_state): Set demands_attention hint in the window state (meta_window_show): If we don't pop up a window because of USER_TIME, set DEMANDS_ATTENTION on the window. (meta_window_focus): When a window receives focus, remove DEMANDS_ATTENTION hint (meta_window_client_message): Allow other apps to set DEMANDS_ATTENTION on a window. Also, if the _NET_ACTIVE_WINDOW hint includes a timestamp, use it. (update_net_wm_state): Read DEMANDS_ATTENTION state also * src/window.h (_MetaWindow): add wm_state_demands_attention bit.
2004-07-31 19:56:10 +00:00
events: Only pass key events to Wayland if focus is on the stage Even without a compositor grab, key events may still be expected to be processed by the compositor and not applications, for instance when using ctrl-alt-tab to keynav in the top bar. On X11, focus is moved to the stage window in that case, so that events are processed before they are dispatched by the window manager. On wayland, we need to handle this case ourselves, so make sure to not pass key events to wayland in that case, and move the key focus back to the stage when appropriate. https://bugzilla.gnome.org/show_bug.cgi?id=758167
2016-03-10 16:51:46 +00:00
if (window->display->event_route == META_EVENT_ROUTE_NORMAL)
{
MetaBackend *backend = meta_get_backend ();
ClutterStage *stage = CLUTTER_STAGE (meta_backend_get_stage (backend));
clutter_stage_set_key_focus (stage, NULL);
}
core: Add meta_close_dialog_focus() vmethod This is used to request key focus on the close dialog whenever a window that is frozen would receive key focus. Also, ensure that the dialog gets focus when first shown if the window was meant to receive input. https://bugzilla.gnome.org/show_bug.cgi?id=762083
2017-07-14 21:34:05 +00:00
if (window->close_dialog &&
meta_close_dialog_is_visible (window->close_dialog))
meta_close_dialog_focus (window->close_dialog);
Fix some support for EWMH hints, and fix USER_TIME support to include the 2004-07-31 Rob Adams <readams@readams.net> Fix some support for EWMH hints, and fix USER_TIME support to include the DEMANDS_ATTENTION hint. Also includes some code for implementing _NET_RESTACK_WINDOW and _NET_MOVERESIZE_WINDOW, but this is disabled pending feature thaw. * COMPLIANCE: update with new information * src/display.c (meta_display_open): add new hints to list * src/display.h (_MetaDisplay): Add new atoms to struct * src/screen.c (set_supported_hint): update the list of support hints. (set_desktop_viewport_hint): new function sets the viewport hint to (0,0) as required by the spec for WMs with no viewport support. (set_desktop_geometry_hint): new function to set the desktop size hint to the size of the display, since we don't implement large desktop support, as required by the spec. (meta_screen_resize): update the geometry hint on screen resize * src/window.c (meta_window_new_with_attrs): Initialize demands_attention state (set_net_wm_state): Set demands_attention hint in the window state (meta_window_show): If we don't pop up a window because of USER_TIME, set DEMANDS_ATTENTION on the window. (meta_window_focus): When a window receives focus, remove DEMANDS_ATTENTION hint (meta_window_client_message): Allow other apps to set DEMANDS_ATTENTION on a window. Also, if the _NET_ACTIVE_WINDOW hint includes a timestamp, use it. (update_net_wm_state): Read DEMANDS_ATTENTION state also * src/window.h (_MetaWindow): add wm_state_demands_attention bit.
2004-07-31 19:56:10 +00:00
if (window->wm_state_demands_attention)
mark a window as needing or not needing the user's attention use the new 2006-03-29 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (meta_window_set_demands_attention, meta_window_unset_demands_attention): mark a window as needing or not needing the user's attention * src/window.c (meta_window_show, window_activate, meta_window_focus, meta_window_configure_request, meta_window_client_message): use the new set/unset demands attention functions. Fixes #305822.
2006-03-29 18:43:22 +00:00
meta_window_unset_demands_attention(window);
Bounce on window focus.
2006-05-25 14:40:50 +00:00
Remove wireframe mode and old effects framework Remove the reduced_resources preference and all all wireframe logic and effects. http://bugzilla.gnome.org/show_bug.cgi?id=581812
2009-05-07 17:53:47 +00:00
/* meta_effect_run_focus(window, NULL, NULL); */
...
2001-06-04 04:58:22 +00:00
}
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
/* Workspace management. Invariants:
*
* - window->workspace describes the workspace the window is on.
*
* - workspace->windows is a list of windows that is located on
* that workspace.
*
window: Fix typo
2014-09-27 01:58:33 +00:00
* - If the window is on_all_workspaces, then
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
* window->workspace == NULL, but workspace->windows contains
* the window.
*/
patch from Hidetoshi Tajima to move a window's transients when moving the 2002-11-22 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_change_workspace): patch from Hidetoshi Tajima to move a window's transients when moving the window between workspaces. #98900 2002-11-21 Havoc Pennington <hp@pobox.com> * src/display.c (meta_display_open): init ret_to to RevertToPointerRoot out of sheer paranoia; don't want no RevertToNone in my code!
2002-11-22 06:00:18 +00:00
static void
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
set_workspace_state (MetaWindow *window,
gboolean on_all_workspaces,
MetaWorkspace *workspace)
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
window: Assert we only set a NULL workspace when unmanaging There might be cases in which a window might be marked as both not in all workspaces and with NULL workspace. So to avoid this to happen, let's just assert early instead of doing this at later point where the context might not be clear. Related to https://gitlab.gnome.org/GNOME/mutter/issues/885 https://gitlab.gnome.org/GNOME/mutter/merge_requests/895
2019-10-29 02:54:42 +00:00
/* If we're on all workspaces, then our new workspace must be NULL,
* otherwise it must be set, unless we're unmanaging. */
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
if (on_all_workspaces)
window: Assert we only set a NULL workspace when unmanaging There might be cases in which a window might be marked as both not in all workspaces and with NULL workspace. So to avoid this to happen, let's just assert early instead of doing this at later point where the context might not be clear. Related to https://gitlab.gnome.org/GNOME/mutter/issues/885 https://gitlab.gnome.org/GNOME/mutter/merge_requests/895
2019-10-29 02:54:42 +00:00
g_assert_null (workspace);
else
g_assert_true (window->unmanaging || workspace != NULL);
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
/* If this is an override-redirect window, ensure that the only
* times we're setting the workspace state is either during construction
* to mark as on_all_workspaces, or when unmanaging to remove all the
* workspaces. */
if (window->override_redirect)
g_return_if_fail ((window->constructing && on_all_workspaces) || window->unmanaging);
MetaWindow::workspace-changed signal. Emitted when window is moved from one workspace to another; the number of the old workspace is passed to the signal handlers.
2009-01-20 12:52:06 +00:00
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
if (on_all_workspaces == window->on_all_workspaces &&
window: Always set workspace state while constructing set_workspace_state () returns early when the desired sticky state and workspace match the current property values, assuming that the corresponding MRU lists are already correct in that case. However that might not be the case when we are setting the initial state, so don't take the shortcut in that case. https://bugzilla.gnome.org/show_bug.cgi?id=737178
2014-09-25 12:59:25 +00:00
workspace == window->workspace &&
!window->constructing)
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
return;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
if (window->workspace)
meta_workspace_remove_window (window->workspace, window);
else if (window->on_all_workspaces)
{
GList *l;
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
for (l = workspace_manager->workspaces; l != NULL; l = l->next)
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
{
Avoid shadowing existing variables
2015-09-23 23:24:33 +00:00
MetaWorkspace *ws = l->data;
meta_workspace_remove_window (ws, window);
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
}
}
window->on_all_workspaces = on_all_workspaces;
window->workspace = workspace;
if (window->workspace)
meta_workspace_add_window (window->workspace, window);
else if (window->on_all_workspaces)
MetaWindow::workspace-changed signal. Emitted when window is moved from one workspace to another; the number of the old workspace is passed to the signal handlers.
2009-01-20 12:52:06 +00:00
{
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
GList *l;
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
for (l = workspace_manager->workspaces; l != NULL; l = l->next)
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
{
Avoid shadowing existing variables
2015-09-23 23:24:33 +00:00
MetaWorkspace *ws = l->data;
meta_workspace_add_window (ws, window);
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
}
MetaWindow::workspace-changed signal. Emitted when window is moved from one workspace to another; the number of the old workspace is passed to the signal handlers.
2009-01-20 12:52:06 +00:00
}
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
/* queue a move_resize since changing workspaces may change
* the relevant struts
call meta_window_unstick before adding window to workspace. 2002-10-04 Arvind Samptur <arvind.samptur@wipro.com> * src/window.c (meta_window_change_workspace): call meta_window_unstick before adding window to workspace. (menu_callback): call meta_workspace_activate before meta_window_change_workspace. This would avoid us running an extra loop for determining the window workspace list. Patches from Jeyasudha and Arvind. Fixes #92575
2002-10-04 14:49:00 +00:00
*/
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
if (!window->override_redirect)
meta_window_queue (window, META_QUEUE_MOVE_RESIZE);
meta_window_queue (window, META_QUEUE_CALC_SHOWING);
meta_window_current_workspace_changed (window);
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_ON_ALL_WORKSPACES]);
g_signal_emit (window, window_signals[WORKSPACE_CHANGED], 0);
}
static gboolean
should_be_on_all_workspaces (MetaWindow *window)
{
window: Make should_be_on_all_workspaces() handle being headless Also adds a soft assert to meta_window_is_on_primary_monitor() to make it easier to spot when callers might want to handle headless in a certain way. https://bugzilla.gnome.org/show_bug.cgi?id=730551
2017-09-25 19:10:58 +00:00
if (window->always_sticky)
return TRUE;
if (window->on_all_workspaces_requested)
return TRUE;
if (window->override_redirect)
return TRUE;
if (meta_prefs_get_workspaces_only_on_primary () &&
!window->unmanaging &&
window->monitor &&
!meta_window_is_on_primary_monitor (window))
return TRUE;
return FALSE;
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
}
void
meta_window_on_all_workspaces_changed (MetaWindow *window)
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
gboolean on_all_workspaces = should_be_on_all_workspaces (window);
if (window->on_all_workspaces == on_all_workspaces)
return;
call meta_window_unstick before adding window to workspace. 2002-10-04 Arvind Samptur <arvind.samptur@wipro.com> * src/window.c (meta_window_change_workspace): call meta_window_unstick before adding window to workspace. (menu_callback): call meta_workspace_activate before meta_window_change_workspace. This would avoid us running an extra loop for determining the window workspace list. Patches from Jeyasudha and Arvind. Fixes #92575
2002-10-04 14:49:00 +00:00
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
MetaWorkspace *workspace;
if (on_all_workspaces)
{
workspace = NULL;
}
else
disable animation when shading windows, just doesn't really convey the 2002-07-28 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_shade): disable animation when shading windows, just doesn't really convey the idea anyway. * src/effects.c: Move to using a shaped window instead of IncludeInferiors to do the animations, looks a lot better because we don't have to grab the server. * src/window.c (meta_window_change_workspace): remove bogus assertion that was causing a crash (meta_window_new): auto-fullscreen huge undecorated windows. * src/keybindings.c (switch_to_workspace): use meta_window_change_workspace() to avoid same bug in cut-and-paste code from there
2002-08-06 04:11:23 +00:00
{
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
/* We're coming out of the sticky state. Put the window on
* the currently active workspace. */
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
workspace = workspace_manager->active_workspace;
disable animation when shading windows, just doesn't really convey the 2002-07-28 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_shade): disable animation when shading windows, just doesn't really convey the idea anyway. * src/effects.c: Move to using a shaped window instead of IncludeInferiors to do the animations, looks a lot better because we don't have to grab the server. * src/window.c (meta_window_change_workspace): remove bogus assertion that was causing a crash (meta_window_new): auto-fullscreen huge undecorated windows. * src/keybindings.c (switch_to_workspace): use meta_window_change_workspace() to avoid same bug in cut-and-paste code from there
2002-08-06 04:11:23 +00:00
}
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
set_workspace_state (window, on_all_workspaces, workspace);
}
static void
meta_window_change_workspace_without_transients (MetaWindow *window,
MetaWorkspace *workspace)
{
/* Try to unstick the window if it's stuck. This doesn't
* have any guarantee that we'll actually unstick the
* window, since it could be stuck for other reasons. */
if (window->on_all_workspaces_requested)
meta_window_unstick (window);
/* We failed to unstick the window. */
if (window->on_all_workspaces)
return;
if (window->workspace == workspace)
return;
set_workspace_state (window, FALSE, workspace);
workspace menu
2001-06-09 05:14:43 +00:00
}
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
static gboolean
patch from Hidetoshi Tajima to move a window's transients when moving the 2002-11-22 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_change_workspace): patch from Hidetoshi Tajima to move a window's transients when moving the window between workspaces. #98900 2002-11-21 Havoc Pennington <hp@pobox.com> * src/display.c (meta_display_open): init ret_to to RevertToPointerRoot out of sheer paranoia; don't want no RevertToNone in my code!
2002-11-22 06:00:18 +00:00
change_workspace_foreach (MetaWindow *window,
void *data)
{
meta_window_change_workspace_without_transients (window, data);
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
return TRUE;
patch from Hidetoshi Tajima to move a window's transients when moving the 2002-11-22 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_change_workspace): patch from Hidetoshi Tajima to move a window's transients when moving the window between workspaces. #98900 2002-11-21 Havoc Pennington <hp@pobox.com> * src/display.c (meta_display_open): init ret_to to RevertToPointerRoot out of sheer paranoia; don't want no RevertToNone in my code!
2002-11-22 06:00:18 +00:00
}
void
meta_window_change_workspace (MetaWindow *window,
MetaWorkspace *workspace)
{
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
patch from Hidetoshi Tajima to move a window's transients when moving the 2002-11-22 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_change_workspace): patch from Hidetoshi Tajima to move a window's transients when moving the window between workspaces. #98900 2002-11-21 Havoc Pennington <hp@pobox.com> * src/display.c (meta_display_open): init ret_to to RevertToPointerRoot out of sheer paranoia; don't want no RevertToNone in my code!
2002-11-22 06:00:18 +00:00
meta_window_change_workspace_without_transients (window, workspace);
meta_window_foreach_transient (window, change_workspace_foreach,
workspace);
Patch from Björn Lindqvist to have ancestors come along with the 2005-10-03 Elijah Newren <newren@gmail.com> Patch from Björn Lindqvist to have ancestors come along with the transient when moving the window from one workspace to another. Fixes #314977. * src/window.c (meta_window_change_workspace): have all ancestors change workspaces too
2005-10-03 19:00:01 +00:00
meta_window_foreach_ancestor (window, change_workspace_foreach,
workspace);
patch from Hidetoshi Tajima to move a window's transients when moving the 2002-11-22 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_change_workspace): patch from Hidetoshi Tajima to move a window's transients when moving the window between workspaces. #98900 2002-11-21 Havoc Pennington <hp@pobox.com> * src/display.c (meta_display_open): init ret_to to RevertToPointerRoot out of sheer paranoia; don't want no RevertToNone in my code!
2002-11-22 06:00:18 +00:00
}
Stick and unstick transients with their parent automatically. Fixes 2005-01-26 Elijah Newren <newren@gmail.com> Stick and unstick transients with their parent automatically. Fixes #152283. * src/window.c: (window_stick_impl, window_unstick_impl): rename from meta_window_stick and meta_window_unstick respectively, (stick_foreach_func): a function to assist calling window_(un)stick_impl on each transient, (meta_window_stick, meta_window_unstick): new functions that call window_stick_impl or window_unstick_impl for the window and each of its transients.
2005-01-26 23:25:05 +00:00
static void
window_stick_impl (MetaWindow *window)
...
2001-06-10 03:17:15 +00:00
{
do a recalc_window_features after setting new wm_state in order to update 2002-11-19 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_client_message): do a recalc_window_features after setting new wm_state in order to update skip_pager in addition to wm_state_skip_pager (set_net_wm_state): base _NET_WM_STATE on skip_pager not wm_state_skip_pager, ditto for skip_taskbar
2002-11-20 04:37:55 +00:00
meta_verbose ("Sticking window %s current on_all_workspaces = %d\n",
window->desc, window->on_all_workspaces);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Split out on_all_workspaces and on_all_workspaces_requested Sometimes on_all_workspaces is requested by the client/user, and sometimes its calculated implicitly due to internal state. We split this up so that we know when the user has explicitly asked for sticky window, when e.g. setting wmspec properties or storing session info. on_all_workspaces means this window is visible on all workspaces. on_all_workspaces_requested, means the user explicitly made the window sticky somehow (via imported session, _NET_WM_STATE from another wm, toggled in the window menu, etc). It always implies on_all_workspaces is TRUE. Right now the only time we set on_all_workspaces is for override-redirect windows, but later we can add a "windows on non-primary monitor are not part of the workspace switching" feature. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 10:41:23 +00:00
if (window->on_all_workspaces_requested)
...
2001-06-10 03:17:15 +00:00
return;
/* We don't change window->workspaces, because we revert
* to that original workspace list if on_all_workspaces is
* toggled back off.
*/
Split out on_all_workspaces and on_all_workspaces_requested Sometimes on_all_workspaces is requested by the client/user, and sometimes its calculated implicitly due to internal state. We split this up so that we know when the user has explicitly asked for sticky window, when e.g. setting wmspec properties or storing session info. on_all_workspaces means this window is visible on all workspaces. on_all_workspaces_requested, means the user explicitly made the window sticky somehow (via imported session, _NET_WM_STATE from another wm, toggled in the window menu, etc). It always implies on_all_workspaces is TRUE. Right now the only time we set on_all_workspaces is for override-redirect windows, but later we can add a "windows on non-primary monitor are not part of the workspace switching" feature. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 10:41:23 +00:00
window->on_all_workspaces_requested = TRUE;
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
meta_window_on_all_workspaces_changed (window);
...
2001-06-10 03:17:15 +00:00
}
Stick and unstick transients with their parent automatically. Fixes 2005-01-26 Elijah Newren <newren@gmail.com> Stick and unstick transients with their parent automatically. Fixes #152283. * src/window.c: (window_stick_impl, window_unstick_impl): rename from meta_window_stick and meta_window_unstick respectively, (stick_foreach_func): a function to assist calling window_(un)stick_impl on each transient, (meta_window_stick, meta_window_unstick): new functions that call window_stick_impl or window_unstick_impl for the window and each of its transients.
2005-01-26 23:25:05 +00:00
static void
window_unstick_impl (MetaWindow *window)
...
2001-06-10 03:17:15 +00:00
{
Split out on_all_workspaces and on_all_workspaces_requested Sometimes on_all_workspaces is requested by the client/user, and sometimes its calculated implicitly due to internal state. We split this up so that we know when the user has explicitly asked for sticky window, when e.g. setting wmspec properties or storing session info. on_all_workspaces means this window is visible on all workspaces. on_all_workspaces_requested, means the user explicitly made the window sticky somehow (via imported session, _NET_WM_STATE from another wm, toggled in the window menu, etc). It always implies on_all_workspaces is TRUE. Right now the only time we set on_all_workspaces is for override-redirect windows, but later we can add a "windows on non-primary monitor are not part of the workspace switching" feature. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 10:41:23 +00:00
if (!window->on_all_workspaces_requested)
...
2001-06-10 03:17:15 +00:00
return;
/* Revert to window->workspaces */
Split out on_all_workspaces and on_all_workspaces_requested Sometimes on_all_workspaces is requested by the client/user, and sometimes its calculated implicitly due to internal state. We split this up so that we know when the user has explicitly asked for sticky window, when e.g. setting wmspec properties or storing session info. on_all_workspaces means this window is visible on all workspaces. on_all_workspaces_requested, means the user explicitly made the window sticky somehow (via imported session, _NET_WM_STATE from another wm, toggled in the window menu, etc). It always implies on_all_workspaces is TRUE. Right now the only time we set on_all_workspaces is for override-redirect windows, but later we can add a "windows on non-primary monitor are not part of the workspace switching" feature. https://bugzilla.gnome.org/show_bug.cgi?id=609258
2011-02-28 10:41:23 +00:00
window->on_all_workspaces_requested = FALSE;
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
meta_window_on_all_workspaces_changed (window);
...
2001-06-10 03:17:15 +00:00
}
Stick and unstick transients with their parent automatically. Fixes 2005-01-26 Elijah Newren <newren@gmail.com> Stick and unstick transients with their parent automatically. Fixes #152283. * src/window.c: (window_stick_impl, window_unstick_impl): rename from meta_window_stick and meta_window_unstick respectively, (stick_foreach_func): a function to assist calling window_(un)stick_impl on each transient, (meta_window_stick, meta_window_unstick): new functions that call window_stick_impl or window_unstick_impl for the window and each of its transients.
2005-01-26 23:25:05 +00:00
static gboolean
stick_foreach_func (MetaWindow *window,
void *data)
{
gboolean stick;
stick = *(gboolean*)data;
if (stick)
window_stick_impl (window);
else
window_unstick_impl (window);
return TRUE;
}
void
meta_window_stick (MetaWindow *window)
{
gboolean stick = TRUE;
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
Stick and unstick transients with their parent automatically. Fixes 2005-01-26 Elijah Newren <newren@gmail.com> Stick and unstick transients with their parent automatically. Fixes #152283. * src/window.c: (window_stick_impl, window_unstick_impl): rename from meta_window_stick and meta_window_unstick respectively, (stick_foreach_func): a function to assist calling window_(un)stick_impl on each transient, (meta_window_stick, meta_window_unstick): new functions that call window_stick_impl or window_unstick_impl for the window and each of its transients.
2005-01-26 23:25:05 +00:00
window_stick_impl (window);
meta_window_foreach_transient (window,
stick_foreach_func,
&stick);
}
void
meta_window_unstick (MetaWindow *window)
{
gboolean stick = FALSE;
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
Stick and unstick transients with their parent automatically. Fixes 2005-01-26 Elijah Newren <newren@gmail.com> Stick and unstick transients with their parent automatically. Fixes #152283. * src/window.c: (window_stick_impl, window_unstick_impl): rename from meta_window_stick and meta_window_unstick respectively, (stick_foreach_func): a function to assist calling window_(un)stick_impl on each transient, (meta_window_stick, meta_window_unstick): new functions that call window_stick_impl or window_unstick_impl for the window and each of its transients.
2005-01-26 23:25:05 +00:00
window_unstick_impl (window);
meta_window_foreach_transient (window,
stick_foreach_func,
&stick);
}
Optimizations for managing new windows (do not all take effect if 2002-10-21 Havoc Pennington <hp@redhat.com> Optimizations for managing new windows (do not all take effect if METACITY_DEBUG=1). Bug #96404 * src/keybindings.c (meta_change_keygrab): use error trap nesting and conditionalize on meta_is_verbose() to avoid a ton of XSync * src/display.c (meta_change_button_grab): ditto Throughout: move to new error trap setup to save on XSync calls, new setup is: * src/errors.c (meta_error_trap_push_with_return): new function, an error trap that needs to care about return value and thus sync even if an outer trap still exists (meta_error_trap_pop_with_return): new function (meta_error_trap_pop): add "last_request_was_roundtrip" argument allowing us to avoid XSync() if we just did a GetProperty or whatever. * src/util.c (meta_warning): flush the warning file descriptor * src/Makefile.am (INCLUDES): define G_LOG_DOMAIN
2002-10-21 21:44:35 +00:00
void
window: Move _NET_WM_DESKTOP setting to window-x11
2014-05-20 19:46:21 +00:00
meta_window_current_workspace_changed (MetaWindow *window)
...
2001-06-10 03:17:15 +00:00
{
window: Move _NET_WM_DESKTOP setting to window-x11
2014-05-20 19:46:21 +00:00
META_WINDOW_GET_CLASS (window)->current_workspace_changed (window);
...
2001-06-10 03:17:15 +00:00
}
Raise the ancestor of a window instead of the window itself. Fixes 2005-02-12 Elijah Newren <newren@gmail.com> Raise the ancestor of a window instead of the window itself. Fixes #166894. * src/window.c: (find_root_ancestor): new function, (meta_window_raise): get the ancestor of the given window and raise it if possible instead of the window
2005-02-12 07:34:30 +00:00
static gboolean
find_root_ancestor (MetaWindow *window,
void *data)
{
MetaWindow **ancestor = data;
/* Overwrite the previously "most-root" ancestor with the new one found */
*ancestor = window;
/* We want this to continue until meta_window_foreach_ancestor quits because
* there are no more valid ancestors.
*/
return TRUE;
}
introspection: Build with --warn-fatal, drop fix-meta-rectangle.py hack Cleanly build with --warn-fatal. Implementation: * Liberally apply (skip) where the API is clearly C only, e.g. uses XLib. The theming code and MutterPlugin are skipped too. * Add missing (transfer) and (element-type) annotations For a few functions that had a comment, I turned it into gtk-doc, but I didn't (with a few exceptions) try to write new documentation in this pass.
2010-09-01 19:39:53 +00:00
/**
* meta_window_find_root_ancestor:
* @window: a #MetaWindow
*
* Follow the chain of parents of @window, skipping transient windows,
* and return the "root" window which has no non-transient parent.
*
* Returns: (transfer none): The root ancestor window
*/
Fix grouping in the presence of ancestors; caught by Björn. #336184 2006-03-29 Elijah Newren <newren gmail com> Fix grouping in the presence of ancestors; caught by Björn. #336184 * src/group.c (meta_window_compute_group): Use new meta_window_find_root_ancestor() function to get ancestor; for the computed group, use the ancestor's group instead of the ancestor itself * src/window.[ch] (meta_window_find_root_ancestor, meta_window_raise): split meta_window_find_root_ancestor() functionality of meta_window_raise() and make it available elsewhere
2006-03-30 19:22:38 +00:00
MetaWindow *
meta_window_find_root_ancestor (MetaWindow *window)
...
2001-06-06 04:47:37 +00:00
{
Raise the ancestor of a window instead of the window itself. Fixes 2005-02-12 Elijah Newren <newren@gmail.com> Raise the ancestor of a window instead of the window itself. Fixes #166894. * src/window.c: (find_root_ancestor): new function, (meta_window_raise): get the ancestor of the given window and raise it if possible instead of the window
2005-02-12 07:34:30 +00:00
MetaWindow *ancestor;
ancestor = window;
meta_window_foreach_ancestor (window, find_root_ancestor, &ancestor);
Fix grouping in the presence of ancestors; caught by Björn. #336184 2006-03-29 Elijah Newren <newren gmail com> Fix grouping in the presence of ancestors; caught by Björn. #336184 * src/group.c (meta_window_compute_group): Use new meta_window_find_root_ancestor() function to get ancestor; for the computed group, use the ancestor's group instead of the ancestor itself * src/window.[ch] (meta_window_find_root_ancestor, meta_window_raise): split meta_window_find_root_ancestor() functionality of meta_window_raise() and make it available elsewhere
2006-03-30 19:22:38 +00:00
return ancestor;
}
void
meta_window_raise (MetaWindow *window)
{
MetaWindow *ancestor;
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
Fix grouping in the presence of ancestors; caught by Björn. #336184 2006-03-29 Elijah Newren <newren gmail com> Fix grouping in the presence of ancestors; caught by Björn. #336184 * src/group.c (meta_window_compute_group): Use new meta_window_find_root_ancestor() function to get ancestor; for the computed group, use the ancestor's group instead of the ancestor itself * src/window.[ch] (meta_window_find_root_ancestor, meta_window_raise): split meta_window_find_root_ancestor() functionality of meta_window_raise() and make it available elsewhere
2006-03-30 19:22:38 +00:00
ancestor = meta_window_find_root_ancestor (window);
Raise the ancestor of a window instead of the window itself. Fixes 2005-02-12 Elijah Newren <newren@gmail.com> Raise the ancestor of a window instead of the window itself. Fixes #166894. * src/window.c: (find_root_ancestor): new function, (meta_window_raise): get the ancestor of the given window and raise it if possible instead of the window
2005-02-12 07:34:30 +00:00
Throughout: move to meta_topic rather than meta_verbose so metacity.log 2002-02-07 Havoc Pennington <hp@pobox.com> Throughout: move to meta_topic rather than meta_verbose so metacity.log can start being more useful * src/util.h (enum): add more debug topics * src/frames.c: clean up some cruft that caused warnings
2002-02-08 03:34:26 +00:00
meta_topic (META_DEBUG_WINDOW_OPS,
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
"Raising window %s, ancestor of %s\n",
Raise the ancestor of a window instead of the window itself. Fixes 2005-02-12 Elijah Newren <newren@gmail.com> Raise the ancestor of a window instead of the window itself. Fixes #166894. * src/window.c: (find_root_ancestor): new function, (meta_window_raise): get the ancestor of the given window and raise it if possible instead of the window
2005-02-12 07:34:30 +00:00
ancestor->desc, window->desc);
...
2001-06-06 04:47:37 +00:00
raise the window as well as its ancestor; fixes a stacking bug with an 2005-07-24 Elijah Newren <newren@gmail.com> * src/window.c (meta_window_raise): raise the window as well as its ancestor; fixes a stacking bug with an ancestor that has more than one child window. Fixes one of the issues in #307875.
2005-07-25 01:52:50 +00:00
/* Raise the ancestor of the window (if the window has no ancestor,
* then ancestor will be set to the window itself); do this because
* it's weird to see windows from other apps stacked between a child
* and parent window of the currently active app. The stacking
* constraints in stack.c then magically take care of raising all
* the child windows appropriately.
*/
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
if (window->display->stack == ancestor->display->stack)
{
meta_stack_raise (window->display->stack, ancestor);
}
raise the window as well as its ancestor; fixes a stacking bug with an 2005-07-24 Elijah Newren <newren@gmail.com> * src/window.c (meta_window_raise): raise the window as well as its ancestor; fixes a stacking bug with an ancestor that has more than one child window. Fixes one of the issues in #307875.
2005-07-25 01:52:50 +00:00
else
Raise the ancestor of a window instead of the window itself. Fixes 2005-02-12 Elijah Newren <newren@gmail.com> Raise the ancestor of a window instead of the window itself. Fixes #166894. * src/window.c: (find_root_ancestor): new function, (meta_window_raise): get the ancestor of the given window and raise it if possible instead of the window
2005-02-12 07:34:30 +00:00
{
meta_warning (
"Either stacks aren't per screen or some window has a weird "
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
"transient_for hint; window->display->stack != "
Raise the ancestor of a window instead of the window itself. Fixes 2005-02-12 Elijah Newren <newren@gmail.com> Raise the ancestor of a window instead of the window itself. Fixes #166894. * src/window.c: (find_root_ancestor): new function, (meta_window_raise): get the ancestor of the given window and raise it if possible instead of the window
2005-02-12 07:34:30 +00:00
"ancestor->screen->stack. window = %s, ancestor = %s.\n",
window->desc, ancestor->desc);
raise the window as well as its ancestor; fixes a stacking bug with an 2005-07-24 Elijah Newren <newren@gmail.com> * src/window.c (meta_window_raise): raise the window as well as its ancestor; fixes a stacking bug with an ancestor that has more than one child window. Fixes one of the issues in #307875.
2005-07-25 01:52:50 +00:00
/* We could raise the window here, but don't want to do that twice and
* so we let the case below handle that.
*/
Raise the ancestor of a window instead of the window itself. Fixes 2005-02-12 Elijah Newren <newren@gmail.com> Raise the ancestor of a window instead of the window itself. Fixes #166894. * src/window.c: (find_root_ancestor): new function, (meta_window_raise): get the ancestor of the given window and raise it if possible instead of the window
2005-02-12 07:34:30 +00:00
}
raise the window as well as its ancestor; fixes a stacking bug with an 2005-07-24 Elijah Newren <newren@gmail.com> * src/window.c (meta_window_raise): raise the window as well as its ancestor; fixes a stacking bug with an ancestor that has more than one child window. Fixes one of the issues in #307875.
2005-07-25 01:52:50 +00:00
/* Okay, so stacking constraints misses one case: If a window has
* two children and we want to raise one of those children, then
* raising the ancestor isn't enough; we need to also raise the
* correct child. See bug 307875.
*/
if (window != ancestor)
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_raise (window->display->stack, window);
MetaWindow::raised signal.
2009-02-02 14:08:46 +00:00
g_signal_emit (window, window_signals[RAISED], 0);
...
2001-06-06 04:47:37 +00:00
}
new function 2001-09-16 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_lower): new function * configure.in: bump version to 2.3.8 * src/display.c (event_callback): raise dock on enter notify, lower it on leave notify (need to refine this behavior) * src/stack.c (compute_layer): experiment with putting the panel in the normal layer, and raising it on mouseover
2001-09-16 21:50:27 +00:00
void
meta_window_lower (MetaWindow *window)
{
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
Throughout: move to meta_topic rather than meta_verbose so metacity.log 2002-02-07 Havoc Pennington <hp@pobox.com> Throughout: move to meta_topic rather than meta_verbose so metacity.log can start being more useful * src/util.h (enum): add more debug topics * src/frames.c: clean up some cruft that caused warnings
2002-02-08 03:34:26 +00:00
meta_topic (META_DEBUG_WINDOW_OPS,
"Lowering window %s\n", window->desc);
new function 2001-09-16 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_lower): new function * configure.in: bump version to 2.3.8 * src/display.c (event_callback): raise dock on enter notify, lower it on leave notify (need to refine this behavior) * src/stack.c (compute_layer): experiment with putting the panel in the normal layer, and raising it on mouseover
2001-09-16 21:50:27 +00:00
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_lower (window->display->stack, window);
new function 2001-09-16 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_lower): new function * configure.in: bump version to 2.3.8 * src/display.c (event_callback): raise dock on enter notify, lower it on leave notify (need to refine this behavior) * src/stack.c (compute_layer): experiment with putting the panel in the normal layer, and raising it on mouseover
2001-09-16 21:50:27 +00:00
}
meta_window_change_workspace_by_index()
2008-11-20 09:14:58 +00:00
/*
* Move window to the requested workspace; append controls whether new WS
* should be created if one does not exist.
*/
void
meta_window_change_workspace_by_index (MetaWindow *window,
gint space_index,
window: Remove timestamp argument from change_workspace_by_index It's unused, since we aren't activating the workspace. https://bugzilla.gnome.org/show_bug.cgi?id=709776
2013-10-09 19:36:51 +00:00
gboolean append)
meta_window_change_workspace_by_index()
2008-11-20 09:14:58 +00:00
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager;
meta_window_change_workspace_by_index()
2008-11-20 09:14:58 +00:00
MetaWorkspace *workspace;
Move workspace handling to MetaDisplay and MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:39:46 +00:00
MetaDisplay *display;
meta_window_change_workspace_by_index()
2008-11-20 09:14:58 +00:00
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
meta_window_change_workspace_by_index()
2008-11-20 09:14:58 +00:00
if (space_index == -1)
{
meta_window_stick (window);
return;
}
Move workspace handling to MetaDisplay and MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:39:46 +00:00
display = window->display;
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
workspace_manager = display->workspace_manager;
meta_window_change_workspace_by_index()
2008-11-20 09:14:58 +00:00
workspace =
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
meta_workspace_manager_get_workspace_by_index (workspace_manager, space_index);
meta_window_change_workspace_by_index()
2008-11-20 09:14:58 +00:00
if (!workspace && append)
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
workspace = meta_workspace_manager_append_new_workspace (workspace_manager, FALSE, META_CURRENT_TIME);
meta_window_change_workspace_by_index()
2008-11-20 09:14:58 +00:00
if (workspace)
window: Remove duplicated code meta_window_change_workspace_without_transients() already does exactly that.
2015-06-25 14:46:17 +00:00
meta_window_change_workspace (window, workspace);
meta_window_change_workspace_by_index()
2008-11-20 09:14:58 +00:00
}
...
2001-06-03 01:33:27 +00:00
window: add _NET_WM_STATE_FOCUSED hint to _NET_WM_STATE This hint reflects whether a window appears focused. https://bugzilla.gnome.org/show_bug.cgi?id=661427
2011-10-26 18:00:18 +00:00
static void
meta_window_appears_focused_changed (MetaWindow *window)
{
set_net_wm_state (window);
MetaFrame: Cache borders Cache the computed border size so we can fetch the border size at any time without worrying that we'll be spending too much time in the theme code (in some cases we might allocate a PangoFontDescription or do other significant work.) The main effort here is clearing the cache when various bits of window state change that could potentially affect the computed borders. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 22:37:50 +00:00
meta_window_frame_size_changed (window);
window: add _NET_WM_STATE_FOCUSED hint to _NET_WM_STATE This hint reflects whether a window appears focused. https://bugzilla.gnome.org/show_bug.cgi?id=661427
2011-10-26 18:00:18 +00:00
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_APPEARS_FOCUSED]);
window: add _NET_WM_STATE_FOCUSED hint to _NET_WM_STATE This hint reflects whether a window appears focused. https://bugzilla.gnome.org/show_bug.cgi?id=661427
2011-10-26 18:00:18 +00:00
if (window->frame)
meta_frame_queue_draw (window->frame);
}
window: Ensure that popup window types propagate their focus appearance In Wayland, popup window types are not override-redirect, and thus can steal window focus away from their parent window when clicked on. This means that we need to make sure their appearance is properly propagated to the parent windows so the parent windows don't lose their focus while they're propagated.
2014-10-06 23:55:01 +00:00
static gboolean
should_propagate_focus_appearance (MetaWindow *window)
{
window: Mark all override-redirect window types as appears-focused
2014-08-13 22:38:30 +00:00
/* Parents of attached modal dialogs should appear focused. */
window: Ensure that popup window types propagate their focus appearance In Wayland, popup window types are not override-redirect, and thus can steal window focus away from their parent window when clicked on. This means that we need to make sure their appearance is properly propagated to the parent windows so the parent windows don't lose their focus while they're propagated.
2014-10-06 23:55:01 +00:00
if (meta_window_is_attached_dialog (window))
return TRUE;
window: Mark all override-redirect window types as appears-focused
2014-08-13 22:38:30 +00:00
/* Parents of these sorts of override-redirect windows should
* appear focused. */
window: Ensure that popup window types propagate their focus appearance In Wayland, popup window types are not override-redirect, and thus can steal window focus away from their parent window when clicked on. This means that we need to make sure their appearance is properly propagated to the parent windows so the parent windows don't lose their focus while they're propagated.
2014-10-06 23:55:01 +00:00
switch (window->type)
{
case META_WINDOW_DROPDOWN_MENU:
case META_WINDOW_POPUP_MENU:
case META_WINDOW_COMBO:
window: Mark all override-redirect window types as appears-focused
2014-08-13 22:38:30 +00:00
case META_WINDOW_TOOLTIP:
case META_WINDOW_NOTIFICATION:
case META_WINDOW_DND:
case META_WINDOW_OVERRIDE_OTHER:
window: Ensure that popup window types propagate their focus appearance In Wayland, popup window types are not override-redirect, and thus can steal window focus away from their parent window when clicked on. This means that we need to make sure their appearance is properly propagated to the parent windows so the parent windows don't lose their focus while they're propagated.
2014-10-06 23:55:01 +00:00
return TRUE;
default:
break;
}
return FALSE;
}
window: fix appears-focused propagation with attached grandchildren When detaching/attaching a dialog, we were only updating appears-focused on the parent if the child itself was focused, but in fact, we need to do it if the child has an attached child which is focused too. To simplify the case of detaching a focused subtree from its parent, we change meta_window_propagate_focus_appearance() to use @window->display->focus_window as the window to add/remove as the attached_focus_window, and @window only as the starting point to propagate from. That way we can propagate focus-removal up to @window's (soon-to-be-ex-)ancestors without having to remove it from its descendants as well. https://bugzilla.gnome.org/show_bug.cgi?id=647712
2011-04-13 21:08:12 +00:00
/**
* meta_window_propagate_focus_appearance:
* @window: the window to start propagating from
* @focused: %TRUE if @window's ancestors should appear focused,
* %FALSE if they should not.
*
* Adjusts the value of #MetaWindow:appears-focused on @window's
* ancestors (but not @window itself). If @focused is %TRUE, each of
* @window's ancestors will have its %attached_focus_window field set
* to the current %focus_window. If @focused if %FALSE, each of
* @window's ancestors will have its %attached_focus_window field
* cleared if it is currently %focus_window.
*/
window: Make propagate_focus_appearance internal to MetaWindow It's an internal helper function. The public interface is meta_window_activate or meta_window_focus.
2014-05-20 17:56:41 +00:00
static void
window: add an appears-focused property, redraw shadows when it changes We need to redraw a window's shadow any time the value of meta_window_appears_focused() changes. So make that into a property so we can get notifications on it. https://bugzilla.gnome.org/show_bug.cgi?id=636904
2011-03-25 01:36:47 +00:00
meta_window_propagate_focus_appearance (MetaWindow *window,
gboolean focused)
Optionally attach modal dialogs Add a preference /apps/mutter/general/attach_modal_dialogs. When true, instead of having independent titlebars, modal dialogs appear attached to the titlebar of the parent window and are moved together with the parent window. https://bugzilla.gnome.org/show_bug.cgi?id=612726
2010-09-10 09:55:20 +00:00
{
window: fix appears-focused propagation with attached grandchildren When detaching/attaching a dialog, we were only updating appears-focused on the parent if the child itself was focused, but in fact, we need to do it if the child has an attached child which is focused too. To simplify the case of detaching a focused subtree from its parent, we change meta_window_propagate_focus_appearance() to use @window->display->focus_window as the window to add/remove as the attached_focus_window, and @window only as the starting point to propagate from. That way we can propagate focus-removal up to @window's (soon-to-be-ex-)ancestors without having to remove it from its descendants as well. https://bugzilla.gnome.org/show_bug.cgi?id=647712
2011-04-13 21:08:12 +00:00
MetaWindow *child, *parent, *focus_window;
Optionally attach modal dialogs Add a preference /apps/mutter/general/attach_modal_dialogs. When true, instead of having independent titlebars, modal dialogs appear attached to the titlebar of the parent window and are moved together with the parent window. https://bugzilla.gnome.org/show_bug.cgi?id=612726
2010-09-10 09:55:20 +00:00
window: fix appears-focused propagation with attached grandchildren When detaching/attaching a dialog, we were only updating appears-focused on the parent if the child itself was focused, but in fact, we need to do it if the child has an attached child which is focused too. To simplify the case of detaching a focused subtree from its parent, we change meta_window_propagate_focus_appearance() to use @window->display->focus_window as the window to add/remove as the attached_focus_window, and @window only as the starting point to propagate from. That way we can propagate focus-removal up to @window's (soon-to-be-ex-)ancestors without having to remove it from its descendants as well. https://bugzilla.gnome.org/show_bug.cgi?id=647712
2011-04-13 21:08:12 +00:00
focus_window = window->display->focus_window;
window: add an appears-focused property, redraw shadows when it changes We need to redraw a window's shadow any time the value of meta_window_appears_focused() changes. So make that into a property so we can get notifications on it. https://bugzilla.gnome.org/show_bug.cgi?id=636904
2011-03-25 01:36:47 +00:00
child = window;
parent = meta_window_get_transient_for (child);
window: Ensure that popup window types propagate their focus appearance In Wayland, popup window types are not override-redirect, and thus can steal window focus away from their parent window when clicked on. This means that we need to make sure their appearance is properly propagated to the parent windows so the parent windows don't lose their focus while they're propagated.
2014-10-06 23:55:01 +00:00
while (parent && (!focused || should_propagate_focus_appearance (child)))
window: add an appears-focused property, redraw shadows when it changes We need to redraw a window's shadow any time the value of meta_window_appears_focused() changes. So make that into a property so we can get notifications on it. https://bugzilla.gnome.org/show_bug.cgi?id=636904
2011-03-25 01:36:47 +00:00
{
gboolean child_focus_state_changed;
Optionally attach modal dialogs Add a preference /apps/mutter/general/attach_modal_dialogs. When true, instead of having independent titlebars, modal dialogs appear attached to the titlebar of the parent window and are moved together with the parent window. https://bugzilla.gnome.org/show_bug.cgi?id=612726
2010-09-10 09:55:20 +00:00
window: add an appears-focused property, redraw shadows when it changes We need to redraw a window's shadow any time the value of meta_window_appears_focused() changes. So make that into a property so we can get notifications on it. https://bugzilla.gnome.org/show_bug.cgi?id=636904
2011-03-25 01:36:47 +00:00
if (focused)
{
window: fix appears-focused propagation with attached grandchildren When detaching/attaching a dialog, we were only updating appears-focused on the parent if the child itself was focused, but in fact, we need to do it if the child has an attached child which is focused too. To simplify the case of detaching a focused subtree from its parent, we change meta_window_propagate_focus_appearance() to use @window->display->focus_window as the window to add/remove as the attached_focus_window, and @window only as the starting point to propagate from. That way we can propagate focus-removal up to @window's (soon-to-be-ex-)ancestors without having to remove it from its descendants as well. https://bugzilla.gnome.org/show_bug.cgi?id=647712
2011-04-13 21:08:12 +00:00
if (parent->attached_focus_window == focus_window)
window: add an appears-focused property, redraw shadows when it changes We need to redraw a window's shadow any time the value of meta_window_appears_focused() changes. So make that into a property so we can get notifications on it. https://bugzilla.gnome.org/show_bug.cgi?id=636904
2011-03-25 01:36:47 +00:00
break;
child_focus_state_changed = (parent->attached_focus_window == NULL);
window: fix appears-focused propagation with attached grandchildren When detaching/attaching a dialog, we were only updating appears-focused on the parent if the child itself was focused, but in fact, we need to do it if the child has an attached child which is focused too. To simplify the case of detaching a focused subtree from its parent, we change meta_window_propagate_focus_appearance() to use @window->display->focus_window as the window to add/remove as the attached_focus_window, and @window only as the starting point to propagate from. That way we can propagate focus-removal up to @window's (soon-to-be-ex-)ancestors without having to remove it from its descendants as well. https://bugzilla.gnome.org/show_bug.cgi?id=647712
2011-04-13 21:08:12 +00:00
parent->attached_focus_window = focus_window;
window: add an appears-focused property, redraw shadows when it changes We need to redraw a window's shadow any time the value of meta_window_appears_focused() changes. So make that into a property so we can get notifications on it. https://bugzilla.gnome.org/show_bug.cgi?id=636904
2011-03-25 01:36:47 +00:00
}
else
{
window: fix appears-focused propagation with attached grandchildren When detaching/attaching a dialog, we were only updating appears-focused on the parent if the child itself was focused, but in fact, we need to do it if the child has an attached child which is focused too. To simplify the case of detaching a focused subtree from its parent, we change meta_window_propagate_focus_appearance() to use @window->display->focus_window as the window to add/remove as the attached_focus_window, and @window only as the starting point to propagate from. That way we can propagate focus-removal up to @window's (soon-to-be-ex-)ancestors without having to remove it from its descendants as well. https://bugzilla.gnome.org/show_bug.cgi?id=647712
2011-04-13 21:08:12 +00:00
if (parent->attached_focus_window != focus_window)
window: add an appears-focused property, redraw shadows when it changes We need to redraw a window's shadow any time the value of meta_window_appears_focused() changes. So make that into a property so we can get notifications on it. https://bugzilla.gnome.org/show_bug.cgi?id=636904
2011-03-25 01:36:47 +00:00
break;
child_focus_state_changed = (parent->attached_focus_window != NULL);
parent->attached_focus_window = NULL;
}
display: clean up focus_window vs expected_focus_window Mutter previously defined display->focus_window as the window that the server says is focused, but kept display->expected_focus_window to indicate the window that we have requested to be focused. But it turns out that "expected_focus_window" was almost always what we wanted. Make MetaDisplay do a better job of tracking focus-related requests and events, and change display->focus_window to be our best guess of the "currently" focused window (ie, the window that will be focused at the time when the server processes the next request we send it). https://bugzilla.gnome.org/show_bug.cgi?id=647706
2011-04-26 12:12:04 +00:00
if (child_focus_state_changed && !parent->has_focus)
window: add an appears-focused property, redraw shadows when it changes We need to redraw a window's shadow any time the value of meta_window_appears_focused() changes. So make that into a property so we can get notifications on it. https://bugzilla.gnome.org/show_bug.cgi?id=636904
2011-03-25 01:36:47 +00:00
{
window: add _NET_WM_STATE_FOCUSED hint to _NET_WM_STATE This hint reflects whether a window appears focused. https://bugzilla.gnome.org/show_bug.cgi?id=661427
2011-10-26 18:00:18 +00:00
meta_window_appears_focused_changed (parent);
window: add an appears-focused property, redraw shadows when it changes We need to redraw a window's shadow any time the value of meta_window_appears_focused() changes. So make that into a property so we can get notifications on it. https://bugzilla.gnome.org/show_bug.cgi?id=636904
2011-03-25 01:36:47 +00:00
}
child = parent;
parent = meta_window_get_transient_for (child);
}
Optionally attach modal dialogs Add a preference /apps/mutter/general/attach_modal_dialogs. When true, instead of having independent titlebars, modal dialogs appear attached to the titlebar of the parent window and are moved together with the parent window. https://bugzilla.gnome.org/show_bug.cgi?id=612726
2010-09-10 09:55:20 +00:00
}
display: clean up focus_window vs expected_focus_window Mutter previously defined display->focus_window as the window that the server says is focused, but kept display->expected_focus_window to indicate the window that we have requested to be focused. But it turns out that "expected_focus_window" was almost always what we wanted. Make MetaDisplay do a better job of tracking focus-related requests and events, and change display->focus_window to be our best guess of the "currently" focused window (ie, the window that will be focused at the time when the server processes the next request we send it). https://bugzilla.gnome.org/show_bug.cgi?id=647706
2011-04-26 12:12:04 +00:00
void
window: Merge got_focus/lost_focus to a new function Make it a static function for now, but this will be a private function soon, replacing meta_window_lost_focus. This should contain no functional changes, only cosmetic indentation changes, so best viewed with ignorews=1 or -w or -b, you know the drill. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 02:24:32 +00:00
meta_window_set_focused_internal (MetaWindow *window,
gboolean focused)
window: Refactor "got focus" code Just move this out to a separate function. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 02:22:05 +00:00
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
window: Merge got_focus/lost_focus to a new function Make it a static function for now, but this will be a private function soon, replacing meta_window_lost_focus. This should contain no functional changes, only cosmetic indentation changes, so best viewed with ignorews=1 or -w or -b, you know the drill. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 02:24:32 +00:00
if (focused)
window: Refactor "got focus" code Just move this out to a separate function. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 02:22:05 +00:00
{
window: Clean up the set_focused_internal function Move things out of an indentation layer, and reshuffle things around. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 03:24:15 +00:00
window->has_focus = TRUE;
window: Properly handle focusing override redirect windows If an app pops up an OR window and sets input focus to it, like Steam does, we'll think the focus window is null, causing us to think the app is not focused. OR windows should not be special if they get input focus, where the input focus would be set to NULL. Instead, the window should be marked as focused. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2013-05-01 21:37:50 +00:00
if (window->override_redirect)
return;
window: Clean up the set_focused_internal function Move things out of an indentation layer, and reshuffle things around. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 03:24:15 +00:00
/* Move to the front of the focusing workspace's MRU list.
* We should only be "removing" it from the MRU list if it's
* not already there. Note that it's possible that we might
* be processing this FocusIn after we've changed to a
* different workspace; we should therefore update the MRU
* list only if the window is actually on the active
* workspace.
*/
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
if (workspace_manager->active_workspace &&
window: Clean up the set_focused_internal function Move things out of an indentation layer, and reshuffle things around. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 03:24:15 +00:00
meta_window_located_on_workspace (window,
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
workspace_manager->active_workspace))
window: Refactor "got focus" code Just move this out to a separate function. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 02:22:05 +00:00
{
window: Clean up the set_focused_internal function Move things out of an indentation layer, and reshuffle things around. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 03:24:15 +00:00
GList* link;
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
link = g_list_find (workspace_manager->active_workspace->mru_list,
window: Clean up the set_focused_internal function Move things out of an indentation layer, and reshuffle things around. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 03:24:15 +00:00
window);
g_assert (link);
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
workspace_manager->active_workspace->mru_list =
g_list_remove_link (workspace_manager->active_workspace->mru_list,
window: Clean up the set_focused_internal function Move things out of an indentation layer, and reshuffle things around. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 03:24:15 +00:00
link);
g_list_free (link);
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
workspace_manager->active_workspace->mru_list =
g_list_prepend (workspace_manager->active_workspace->mru_list,
window: Clean up the set_focused_internal function Move things out of an indentation layer, and reshuffle things around. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 03:24:15 +00:00
window);
}
window: Refactor "got focus" code Just move this out to a separate function. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 02:22:05 +00:00
window: Clean up the set_focused_internal function Move things out of an indentation layer, and reshuffle things around. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 03:24:15 +00:00
if (window->frame)
meta_frame_queue_draw (window->frame);
window: Refactor "got focus" code Just move this out to a separate function. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 02:22:05 +00:00
window: Clean up the set_focused_internal function Move things out of an indentation layer, and reshuffle things around. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 03:24:15 +00:00
/* Ungrab click to focus button since the sync grab can interfere
* with some things you might do inside the focused window, by
* causing the client to get funky enter/leave events.
*
* The reason we usually have a passive grab on the window is
* so that we can intercept clicks and raise the window in
* response. For click-to-focus we don't need that since the
* focused window is already raised. When raise_on_click is
* FALSE we also don't need that since we don't do anything
* when the window is clicked.
*
* There is dicussion in bugs 102209, 115072, and 461577
*/
if (meta_prefs_get_focus_mode () == G_DESKTOP_FOCUS_MODE_CLICK ||
!meta_prefs_get_raise_on_click())
keybindings: Grab buttons with any modifier combo on unfocused windows We currently only focus unfocused windows on button press if no modifiers (or just ignored modifiers) are in effect. This behavior seems surprising and counter-intuitive so let's do it for any modifier combination instead. https://bugzilla.gnome.org/show_bug.cgi?id=746642
2016-02-10 19:17:49 +00:00
{
meta_display_ungrab_focus_window_button (window->display, window);
/* Since we ungrab with XIAnyModifier above, all button
grabs go way so we need to re-grab the window buttons. */
meta_display_grab_window_buttons (window->display, window->xwindow);
}
window: Refactor "got focus" code Just move this out to a separate function. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 02:22:05 +00:00
window: Clean up the set_focused_internal function Move things out of an indentation layer, and reshuffle things around. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 03:24:15 +00:00
g_signal_emit (window, window_signals[FOCUS], 0);
window: Refactor "got focus" code Just move this out to a separate function. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 02:22:05 +00:00
window: Clean up the set_focused_internal function Move things out of an indentation layer, and reshuffle things around. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 03:24:15 +00:00
if (!window->attached_focus_window)
meta_window_appears_focused_changed (window);
window: Refactor "got focus" code Just move this out to a separate function. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 02:22:05 +00:00
window: Clean up the set_focused_internal function Move things out of an indentation layer, and reshuffle things around. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 03:24:15 +00:00
meta_window_propagate_focus_appearance (window, TRUE);
window: Refactor "got focus" code Just move this out to a separate function. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 02:22:05 +00:00
}
window: Merge got_focus/lost_focus to a new function Make it a static function for now, but this will be a private function soon, replacing meta_window_lost_focus. This should contain no functional changes, only cosmetic indentation changes, so best viewed with ignorews=1 or -w or -b, you know the drill. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 02:24:32 +00:00
else
Port mutter to use XInput2 events instead of Core Events Mechanically transform the event processing of mutter to care about XI2 events instead of Core Events. Core Events will be left in the dust soon, and removed entirely. https://bugzilla.gnome.org/show_bug.cgi?id=688779
2012-11-15 21:35:42 +00:00
{
window: Clean up the set_focused_internal function Move things out of an indentation layer, and reshuffle things around. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 03:24:15 +00:00
window->has_focus = FALSE;
window: Properly handle focusing override redirect windows If an app pops up an OR window and sets input focus to it, like Steam does, we'll think the focus window is null, causing us to think the app is not focused. OR windows should not be special if they get input focus, where the input focus would be set to NULL. Instead, the window should be marked as focused. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2013-05-01 21:37:50 +00:00
if (window->override_redirect)
return;
meta_window_propagate_focus_appearance (window, FALSE);
Port mutter to use XInput2 events instead of Core Events Mechanically transform the event processing of mutter to care about XI2 events instead of Core Events. Core Events will be left in the dust soon, and removed entirely. https://bugzilla.gnome.org/show_bug.cgi?id=688779
2012-11-15 21:35:42 +00:00
window: Clean up the set_focused_internal function Move things out of an indentation layer, and reshuffle things around. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 03:24:15 +00:00
if (!window->attached_focus_window)
meta_window_appears_focused_changed (window);
Port mutter to use XInput2 events instead of Core Events Mechanically transform the event processing of mutter to care about XI2 events instead of Core Events. Core Events will be left in the dust soon, and removed entirely. https://bugzilla.gnome.org/show_bug.cgi?id=688779
2012-11-15 21:35:42 +00:00
window: Clean up the set_focused_internal function Move things out of an indentation layer, and reshuffle things around. https://bugzilla.gnome.org/show_bug.cgi?id=647706
2012-12-17 03:24:15 +00:00
/* Re-grab for click to focus and raise-on-click, if necessary */
if (meta_prefs_get_focus_mode () == G_DESKTOP_FOCUS_MODE_CLICK ||
!meta_prefs_get_raise_on_click ())
meta_display_grab_focus_window_button (window->display, window);
Port mutter to use XInput2 events instead of Core Events Mechanically transform the event processing of mutter to care about XI2 events instead of Core Events. Core Events will be left in the dust soon, and removed entirely. https://bugzilla.gnome.org/show_bug.cgi?id=688779
2012-11-15 21:35:42 +00:00
}
}
Expose meta_window_get_icon_geometry() Make meta_window_get_icon_geometry() public, so that it can be used to from plugins to animate windows minimizing to the correct position. Based on a patch from Cosimo Cecchi <cosimoc@gnome.org> http://bugzilla.gnome.org/show_bug.cgi?id=571109
2009-03-31 21:29:48 +00:00
/**
* meta_window_get_icon_geometry:
* @window: a #MetaWindow
window: Fix get_icon_geometry() annotation gjs has had support for (out) parameters for quite some time now ... https://bugzilla.gnome.org/show_bug.cgi?id=692997
2013-01-20 20:35:32 +00:00
* @rect: (out): rectangle into which to store the returned geometry.
Expose meta_window_get_icon_geometry() Make meta_window_get_icon_geometry() public, so that it can be used to from plugins to animate windows minimizing to the correct position. Based on a patch from Cosimo Cecchi <cosimoc@gnome.org> http://bugzilla.gnome.org/show_bug.cgi?id=571109
2009-03-31 21:29:48 +00:00
*
* Gets the location of the icon corresponding to the window. The location
* will be provided set by the task bar or other user interface element
window: Cache _NET_WM_ICON_GEOMETRY Rather than doing a server round trip each time when retrieving the icon geometry, use the existing property mechanism to cache it. https://bugzilla.gnome.org/show_bug.cgi?id=692997
2013-02-01 10:32:53 +00:00
* displaying the icon, and is relative to the root window.
Expose meta_window_get_icon_geometry() Make meta_window_get_icon_geometry() public, so that it can be used to from plugins to animate windows minimizing to the correct position. Based on a patch from Cosimo Cecchi <cosimoc@gnome.org> http://bugzilla.gnome.org/show_bug.cgi?id=571109
2009-03-31 21:29:48 +00:00
*
* Return value: %TRUE if the icon geometry was succesfully retrieved.
*/
make public 2002-10-24 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_get_icon_geometry): make public * src/screen.c (meta_screen_ensure_tab_popup): put the alt+tab highlight-window indicator on the icon, not the window itself, if the window is minimized.
2002-10-24 05:21:51 +00:00
gboolean
Add _NET_WM_ICON_GEOMETRY atom. 2001-08-05 Anders Carlsson <andersca@gnu.org> * src/display.h, src/display.c: Add _NET_WM_ICON_GEOMETRY atom. * src/window.c (meta_window_calc_showing): See if the window has an icon geometry and show a morphing animation from the window's coordinates to the icon's coordinates. (meta_window_get_icon_geometry): New function that fetches a window's icon geometry. * src/Makefile.am: Add effects.[ch]. * src/effects.c: New file with cool effects.
2001-08-05 16:04:52 +00:00
meta_window_get_icon_geometry (MetaWindow *window,
MetaRectangle *rect)
{
Don't read most properties for override-redirect windows Skipping handling of properties for override redirect windows has two advantages: first it reduces the amount of work needed to get an override-redirect window (menu, tooltip, drag icon) onto the screen. But more importantly, it reduces the number of code-paths for an override-redirect to get into some code portion where it isn't expected. * Integrate the list of properties we load initially with the list of property hooks; this avoids having two separate lists that we have to keep in sync. * Add a flag to MetaWindowPropHooks to indicate whether the property should be handled for override-redirect windows; currently we load a) properties that identify the window - useful for debugging purposes b) WM_TRANSIENT_FOR (could be used to associate menus with toplevels.) * For properties that aren't always loaded through window-props.c, add !window->override checks to places that trigger loading, and add g_return_if_fail(!window->override) to the load functions as a double-check. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:37:57 +00:00
g_return_val_if_fail (!window->override_redirect, FALSE);
window: Cache _NET_WM_ICON_GEOMETRY Rather than doing a server round trip each time when retrieving the icon geometry, use the existing property mechanism to cache it. https://bugzilla.gnome.org/show_bug.cgi?id=692997
2013-02-01 10:32:53 +00:00
if (window->icon_geometry_set)
we support _NET_WM_ICON 2001-08-19 Havoc Pennington <hp@pobox.com> * src/screen.c (set_supported_hint): we support _NET_WM_ICON * src/wm-tester/main.c: add stuff to test _NET_WM_ICON (but it doesn't work, so it isn't tested yet) * src/window.c (update_icon): read _NET_WM_ICON * src/screen.c (meta_screen_new): set the WM_ICON_SIZE hint * src/tabpopup.c (meta_ui_tab_popup_select): remove assertion * src/window.c (meta_window_get_icon_geometry): fix obscure memleak
2001-08-20 01:42:44 +00:00
{
clean up using meta_prop_get_atom_list (update_mwm_hints): clean up using 2002-01-03 Havoc Pennington <hp@pobox.com> * src/window.c (update_net_wm_state): clean up using meta_prop_get_atom_list (update_mwm_hints): clean up using meta_prop_get_motif_hints * src/Makefile.am (metacity_SOURCES): add xprops.[hc] * src/xprops.c: new file with convenience functions for X properties
2002-01-04 00:58:39 +00:00
if (rect)
window: Cache _NET_WM_ICON_GEOMETRY Rather than doing a server round trip each time when retrieving the icon geometry, use the existing property mechanism to cache it. https://bugzilla.gnome.org/show_bug.cgi?id=692997
2013-02-01 10:32:53 +00:00
*rect = window->icon_geometry;
Add _NET_WM_ICON_GEOMETRY atom. 2001-08-05 Anders Carlsson <andersca@gnu.org> * src/display.h, src/display.c: Add _NET_WM_ICON_GEOMETRY atom. * src/window.c (meta_window_calc_showing): See if the window has an icon geometry and show a morphing animation from the window's coordinates to the icon's coordinates. (meta_window_get_icon_geometry): New function that fetches a window's icon geometry. * src/Makefile.am: Add effects.[ch]. * src/effects.c: New file with cool effects.
2001-08-05 16:04:52 +00:00
clean up using meta_prop_get_atom_list (update_mwm_hints): clean up using 2002-01-03 Havoc Pennington <hp@pobox.com> * src/window.c (update_net_wm_state): clean up using meta_prop_get_atom_list (update_mwm_hints): clean up using meta_prop_get_motif_hints * src/Makefile.am (metacity_SOURCES): add xprops.[hc] * src/xprops.c: new file with convenience functions for X properties
2002-01-04 00:58:39 +00:00
return TRUE;
}
return FALSE;
Add _NET_WM_ICON_GEOMETRY atom. 2001-08-05 Anders Carlsson <andersca@gnu.org> * src/display.h, src/display.c: Add _NET_WM_ICON_GEOMETRY atom. * src/window.c (meta_window_calc_showing): See if the window has an icon geometry and show a morphing animation from the window's coordinates to the icon's coordinates. (meta_window_get_icon_geometry): New function that fetches a window's icon geometry. * src/Makefile.am: Add effects.[ch]. * src/effects.c: New file with cool effects.
2001-08-05 16:04:52 +00:00
}
window: Add set_icon_geometry() method Using a public method for setting the (cached) icon geometry rather than accessing the struct members directly allows setting the icon geometry from extensions. https://bugzilla.gnome.org/show_bug.cgi?id=692997
2013-01-23 00:11:23 +00:00
/**
* meta_window_set_icon_geometry:
* @window: a #MetaWindow
Update (allow-none) annotations The annotation has been deprecated in favor of (nullable) and/or (optional).
2014-05-28 19:44:23 +00:00
* @rect: (nullable): rectangle with the desired geometry or %NULL.
window: Add set_icon_geometry() method Using a public method for setting the (cached) icon geometry rather than accessing the struct members directly allows setting the icon geometry from extensions. https://bugzilla.gnome.org/show_bug.cgi?id=692997
2013-01-23 00:11:23 +00:00
*
* Sets or unsets the location of the icon corresponding to the window. If
* set, the location should correspond to a dock, task bar or other user
* interface element displaying the icon, and is relative to the root window.
*/
void
meta_window_set_icon_geometry (MetaWindow *window,
MetaRectangle *rect)
{
if (rect)
{
window->icon_geometry = *rect;
window->icon_geometry_set = TRUE;
}
else
{
window->icon_geometry_set = FALSE;
}
}
Optimizations for managing new windows (do not all take effect if 2002-10-21 Havoc Pennington <hp@redhat.com> Optimizations for managing new windows (do not all take effect if METACITY_DEBUG=1). Bug #96404 * src/keybindings.c (meta_change_keygrab): use error trap nesting and conditionalize on meta_is_verbose() to avoid a ton of XSync * src/display.c (meta_change_button_grab): ditto Throughout: move to new error trap setup to save on XSync calls, new setup is: * src/errors.c (meta_error_trap_push_with_return): new function, an error trap that needs to care about return value and thus sync even if an outer trap still exists (meta_error_trap_pop_with_return): new function (meta_error_trap_pop): add "last_request_was_roundtrip" argument allowing us to avoid XSync() if we just did a GetProperty or whatever. * src/util.c (meta_warning): flush the warning file descriptor * src/Makefile.am (INCLUDES): define G_LOG_DOMAIN
2002-10-21 21:44:35 +00:00
static void
add more debug spew about conditional build stuff (main): panic to 2003-02-27 Havoc Pennington <hp@pobox.com> * src/main.c (main): add more debug spew about conditional build stuff (main): panic to "Simple" theme * src/window.c, src/window-props.c: move WM_NORMAL_HINTS and WM_PROTOCOLS to new property system; don't queue move resize on updating WM_PROTOCOLS; move WM_HINTS to new property system; reload icon in an idle handler. Changes made on plane from FOSDEM, syncing from laptop.
2003-02-28 01:24:44 +00:00
redraw_icon (MetaWindow *window)
{
/* We could probably be smart and just redraw the icon here,
* instead of the whole frame.
*/
Always map the client and frame windows Traditionally, WMs unmap windows when minimizing them, and map them when restoring them or wanting to show them for other reasons, like upon creation. However, as metacity morphed into mutter, we optionally chose to keep windows mapped for the lifetime of the window under the user option "live-window-previews", which makes the code keep windows mapped so it can show window preview for minimized windows in other places, like Alt-Tab and Expose. I removed this preference two years ago mechanically, by removing all the if statements, but never went through and cleaned up the code so that windows are simply mapped for the lifetime of the window -- the "architecture" of the old code that maps and unmaps on show/hide was still there. Remove this now. The one case we still need to be careful of is shaded windows, in which we do still unmap the client window. In the future, we might want to show previews of shaded windows in the overview and Alt-Tab. In that we'd also keep shaded windows mapped, and could remove all unmap logic, but we'd need a more complex method of showing the shaded titlebar, such as using a different actor. At the same time, simplify the compositor interface by removing meta_compositor_window_[un]mapped API, and instead adding/removing the window on-demand. https://bugzilla.gnome.org/show_bug.cgi?id=720631
2014-02-02 00:06:51 +00:00
if (window->frame)
Only poke the frames UI code from inside frame.c Add frame.c wrappers for the missing calls, then adapt.
2015-01-01 05:24:49 +00:00
meta_frame_queue_draw (window->frame);
add more debug spew about conditional build stuff (main): panic to 2003-02-27 Havoc Pennington <hp@pobox.com> * src/main.c (main): add more debug spew about conditional build stuff (main): panic to "Simple" theme * src/window.c, src/window-props.c: move WM_NORMAL_HINTS and WM_PROTOCOLS to new property system; don't queue move resize on updating WM_PROTOCOLS; move WM_HINTS to new property system; reload icon in an idle handler. Changes made on plane from FOSDEM, syncing from laptop.
2003-02-28 01:24:44 +00:00
}
core: Remove useless meta_invalidate_default_icons implementation This code was supposed to refresh our default icons when the theme changed, but it actually was a no-op, since the default icons are cached in a static variable in MetaUI. I'm not sure the fact that the fallback icons don't update when the theme changes is an important enough use case to keep working, but I'm keeping the skeleton function there in case somebody wants to actually fix it properly.
2014-07-14 15:59:42 +00:00
static void
window: Force updating icons when initially loading them Otherwise, Wayland windows will never get an icon.
2014-07-14 19:26:09 +00:00
meta_window_update_icon_now (MetaWindow *window,
gboolean force)
we support _NET_WM_ICON 2001-08-19 Havoc Pennington <hp@pobox.com> * src/screen.c (set_supported_hint): we support _NET_WM_ICON * src/wm-tester/main.c: add stuff to test _NET_WM_ICON (but it doesn't work, so it isn't tested yet) * src/window.c (update_icon): read _NET_WM_ICON * src/screen.c (meta_screen_new): set the WM_ICON_SIZE hint * src/tabpopup.c (meta_ui_tab_popup_select): remove assertion * src/window.c (meta_window_get_icon_geometry): fix obscure memleak
2001-08-20 01:42:44 +00:00
{
window: Move X11-specific icon code to MetaWindowX11
2014-07-14 16:01:22 +00:00
gboolean changed;
x11: Change the iconcache / window icons to being cairo surfaces This simplifies the drawing codepath and makes us able to delete a bunch of GdkPixbuf manipulation.
2015-01-01 04:39:36 +00:00
cairo_surface_t *icon = NULL;
cairo_surface_t *mini_icon;
we support _NET_WM_ICON 2001-08-19 Havoc Pennington <hp@pobox.com> * src/screen.c (set_supported_hint): we support _NET_WM_ICON * src/wm-tester/main.c: add stuff to test _NET_WM_ICON (but it doesn't work, so it isn't tested yet) * src/window.c (update_icon): read _NET_WM_ICON * src/screen.c (meta_screen_new): set the WM_ICON_SIZE hint * src/tabpopup.c (meta_ui_tab_popup_select): remove assertion * src/window.c (meta_window_get_icon_geometry): fix obscure memleak
2001-08-20 01:42:44 +00:00
Don't read most properties for override-redirect windows Skipping handling of properties for override redirect windows has two advantages: first it reduces the amount of work needed to get an override-redirect window (menu, tooltip, drag icon) onto the screen. But more importantly, it reduces the number of code-paths for an override-redirect to get into some code portion where it isn't expected. * Integrate the list of properties we load initially with the list of property hooks; this avoids having two separate lists that we have to keep in sync. * Add a flag to MetaWindowPropHooks to indicate whether the property should be handled for override-redirect windows; currently we load a) properties that identify the window - useful for debugging purposes b) WM_TRANSIENT_FOR (could be used to associate menus with toplevels.) * For properties that aren't always loaded through window-props.c, add !window->override checks to places that trigger loading, and add g_return_if_fail(!window->override) to the load functions as a double-check. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:37:57 +00:00
g_return_if_fail (!window->override_redirect);
window: Move X11-specific icon code to MetaWindowX11
2014-07-14 16:01:22 +00:00
changed = META_WINDOW_GET_CLASS (window)->update_icon (window, &icon, &mini_icon);
window: Force updating icons when initially loading them Otherwise, Wayland windows will never get an icon.
2014-07-14 19:26:09 +00:00
if (changed || force)
port to icon cache 2002-02-09 Havoc Pennington <hp@pobox.com> * src/window.c (update_icon): port to icon cache * src/iconcache.c, src/iconcache.c: begin process of cleaning up window.c by moving the icon-reading code in here, based on the code in libwnck, which was in turn based on the earlier metacity code
2002-02-09 23:03:52 +00:00
{
if (window->icon)
x11: Change the iconcache / window icons to being cairo surfaces This simplifies the drawing codepath and makes us able to delete a bunch of GdkPixbuf manipulation.
2015-01-01 04:39:36 +00:00
cairo_surface_destroy (window->icon);
core: Relax requirement that MetaWindow shall have icon/mini-icon We use a GtkIconTheme (thus icon-theme, thus xsettings, thus x11) just to grab a "missing icon" icon to show in place. Relax this requirement that surfaces for icon/mini-icon will be set, and just let it have NULL here. It seems better to have the callers (presumably UI layers) aware of this and set a proper icon by themselves, but AFAICS there is none in sight, not even plain mutter seems to use MetaWindow::[mini-]icon. Probably worth a future cleanup. https://gitlab.gnome.org/GNOME/mutter/merge_requests/420
2018-12-30 13:18:09 +00:00
window->icon = icon;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
port to icon cache 2002-02-09 Havoc Pennington <hp@pobox.com> * src/window.c (update_icon): port to icon cache * src/iconcache.c, src/iconcache.c: begin process of cleaning up window.c by moving the icon-reading code in here, based on the code in libwnck, which was in turn based on the earlier metacity code
2002-02-09 23:03:52 +00:00
if (window->mini_icon)
x11: Change the iconcache / window icons to being cairo surfaces This simplifies the drawing codepath and makes us able to delete a bunch of GdkPixbuf manipulation.
2015-01-01 04:39:36 +00:00
cairo_surface_destroy (window->mini_icon);
core: Relax requirement that MetaWindow shall have icon/mini-icon We use a GtkIconTheme (thus icon-theme, thus xsettings, thus x11) just to grab a "missing icon" icon to show in place. Relax this requirement that surfaces for icon/mini-icon will be set, and just let it have NULL here. It seems better to have the callers (presumably UI layers) aware of this and set a proper icon by themselves, but AFAICS there is none in sight, not even plain mutter seems to use MetaWindow::[mini-]icon. Probably worth a future cleanup. https://gitlab.gnome.org/GNOME/mutter/merge_requests/420
2018-12-30 13:18:09 +00:00
window->mini_icon = mini_icon;
add more debug spew about conditional build stuff (main): panic to 2003-02-27 Havoc Pennington <hp@pobox.com> * src/main.c (main): add more debug spew about conditional build stuff (main): panic to "Simple" theme * src/window.c, src/window-props.c: move WM_NORMAL_HINTS and WM_PROTOCOLS to new property system; don't queue move resize on updating WM_PROTOCOLS; move WM_HINTS to new property system; reload icon in an idle handler. Changes made on plane from FOSDEM, syncing from laptop.
2003-02-28 01:24:44 +00:00
Add gproperties to MetaWindow: "title", "icon", "mini-icon" We need these properties to do things outside of the frame, without dropping to libwnck. http://bugzilla.gnome.org/show_bug.cgi?id=563405
2008-12-06 01:03:27 +00:00
g_object_freeze_notify (G_OBJECT (window));
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_ICON]);
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_MINI_ICON]);
Add gproperties to MetaWindow: "title", "icon", "mini-icon" We need these properties to do things outside of the frame, without dropping to libwnck. http://bugzilla.gnome.org/show_bug.cgi?id=563405
2008-12-06 01:03:27 +00:00
g_object_thaw_notify (G_OBJECT (window));
add more debug spew about conditional build stuff (main): panic to 2003-02-27 Havoc Pennington <hp@pobox.com> * src/main.c (main): add more debug spew about conditional build stuff (main): panic to "Simple" theme * src/window.c, src/window-props.c: move WM_NORMAL_HINTS and WM_PROTOCOLS to new property system; don't queue move resize on updating WM_PROTOCOLS; move WM_HINTS to new property system; reload icon in an idle handler. Changes made on plane from FOSDEM, syncing from laptop.
2003-02-28 01:24:44 +00:00
redraw_icon (window);
attempt to use the mask as well as the pixmap. Probably doesn't work so 2001-08-23 Havoc Pennington <hp@pobox.com> * src/window.c (update_icon): attempt to use the mask as well as the pixmap. Probably doesn't work so well. * src/tabpopup.c: make this look a little nicer
2001-08-24 00:32:17 +00:00
}
...
2001-06-24 02:22:10 +00:00
}
add more debug spew about conditional build stuff (main): panic to 2003-02-27 Havoc Pennington <hp@pobox.com> * src/main.c (main): add more debug spew about conditional build stuff (main): panic to "Simple" theme * src/window.c, src/window-props.c: move WM_NORMAL_HINTS and WM_PROTOCOLS to new property system; don't queue move resize on updating WM_PROTOCOLS; move WM_HINTS to new property system; reload icon in an idle handler. Changes made on plane from FOSDEM, syncing from laptop.
2003-02-28 01:24:44 +00:00
static gboolean
idle_update_icon (gpointer data)
Redraw the window frame when the icon changes. Fixes #78543, reported by 2002-05-24 Anders Carlsson <andersca@gnu.org> * src/window.c: Redraw the window frame when the icon changes. Fixes #78543, reported by Kang Jeong-Hee.
2002-05-24 08:16:59 +00:00
{
add more debug spew about conditional build stuff (main): panic to 2003-02-27 Havoc Pennington <hp@pobox.com> * src/main.c (main): add more debug spew about conditional build stuff (main): panic to "Simple" theme * src/window.c, src/window-props.c: move WM_NORMAL_HINTS and WM_PROTOCOLS to new property system; don't queue move resize on updating WM_PROTOCOLS; move WM_HINTS to new property system; reload icon in an idle handler. Changes made on plane from FOSDEM, syncing from laptop.
2003-02-28 01:24:44 +00:00
GSList *tmp;
GSList *copy;
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
guint queue_index = GPOINTER_TO_INT (data);
add more debug spew about conditional build stuff (main): panic to 2003-02-27 Havoc Pennington <hp@pobox.com> * src/main.c (main): add more debug spew about conditional build stuff (main): panic to "Simple" theme * src/window.c, src/window-props.c: move WM_NORMAL_HINTS and WM_PROTOCOLS to new property system; don't queue move resize on updating WM_PROTOCOLS; move WM_HINTS to new property system; reload icon in an idle handler. Changes made on plane from FOSDEM, syncing from laptop.
2003-02-28 01:24:44 +00:00
meta_topic (META_DEBUG_GEOMETRY, "Clearing the update_icon queue\n");
/* Work with a copy, for reentrancy. The allowed reentrancy isn't
* complete; destroying a window while we're in here would result in
* badness. But it's OK to queue/unqueue update_icons.
*/
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
copy = g_slist_copy (queue_pending[queue_index]);
g_slist_free (queue_pending[queue_index]);
queue_pending[queue_index] = NULL;
Use "later functions" to fix priority problems with Clutter redraw There was a problem where if, for example, a restack was triggered out of a clutter event handler, then after Clutter processed the events, it would proceed immmediately on to repaint the stage without ever returning control to the GLib main loop. So even though we had an idle handler installed with a higher priority than the Clutter stage repainting the clutter stage repainting would happen first and we'd get a wrong frame. Fix this by introducing the idea of "later functions", which abstract the idea of "doing something later" away from g_idle_add() and use a combination of GLib idle functions and Clutter "repaint functions" to get our callbacks triggered at the right time, even when they are installed from a clutter event handler. https://bugzilla.gnome.org/show_bug.cgi?id=596334 This also resolve a FIXME where MUTTER_PRIORITY_BEFORE_REDRAW could starve stage repainting.
2009-09-25 19:47:22 +00:00
queue_later[queue_index] = 0;
add more debug spew about conditional build stuff (main): panic to 2003-02-27 Havoc Pennington <hp@pobox.com> * src/main.c (main): add more debug spew about conditional build stuff (main): panic to "Simple" theme * src/window.c, src/window-props.c: move WM_NORMAL_HINTS and WM_PROTOCOLS to new property system; don't queue move resize on updating WM_PROTOCOLS; move WM_HINTS to new property system; reload icon in an idle handler. Changes made on plane from FOSDEM, syncing from laptop.
2003-02-28 01:24:44 +00:00
destroying_windows_disallowed += 1;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
add more debug spew about conditional build stuff (main): panic to 2003-02-27 Havoc Pennington <hp@pobox.com> * src/main.c (main): add more debug spew about conditional build stuff (main): panic to "Simple" theme * src/window.c, src/window-props.c: move WM_NORMAL_HINTS and WM_PROTOCOLS to new property system; don't queue move resize on updating WM_PROTOCOLS; move WM_HINTS to new property system; reload icon in an idle handler. Changes made on plane from FOSDEM, syncing from laptop.
2003-02-28 01:24:44 +00:00
tmp = copy;
while (tmp != NULL)
{
MetaWindow *window;
window = tmp->data;
window: Force updating icons when initially loading them Otherwise, Wayland windows will never get an icon.
2014-07-14 19:26:09 +00:00
meta_window_update_icon_now (window, FALSE);
Refactor thrice-duplicated queue code in window.c. Closes #376760. 2007-06-10 Thomas Thurman <thomas@thurman.org.uk> Refactor thrice-duplicated queue code in window.c. Closes #376760. * src/window.c (meta_window_queue, meta_window_unqueue): New functions. * src/window.[ch] (meta_window_unqueue_*, meta_window_queue_*): Removed functions. * src/window.c (meta_window_new_with_attrs, meta_window_free, meta_window_flush_calc_showing, queue_calc_showing_func, meta_window_minimize, meta_window_unminimize, meta_window_maximize, meta_window_make_fullscreen, meta_window_shade, meta_window_unshade, meta_window_move_resize_internal, window_stick_impl, window_unstick_impl, meta_window_client_message, process_property_notify): Modified to use new queueing functions. * src/window.c (idle_move_resize, idle_update_icon, idle_calc_showing): update to receive queue number from pointer. * src/window.h (MetaQueueType): new enum. * src/window.h (MetaWindow): *_queued replaced with is_in_queue bitfield. * src/core.c (meta_core_queue_frame_resize): * src/display.c (event_callback, meta_display_queue_retheme_all_windows): Using new queueing functions. * src/frame.c (meta_window_destroy_frame): Using new queueing functions. * src/screen.c (queue_resize, meta_screen_resize_func, queue_windows_showing): Using new queueing functions. * src/window-props.c (reload_mwm_hints, reload_wm_hints, reload_transient_for): Using new queueing functions. * src/workspace.c (meta_workspace_add_window, meta_workspace_remove_window, meta_workspace_queue_calc_showing, meta_workspace_invalidate_work_area): Using new queueing functions. svn path=/trunk/; revision=3236
2007-06-11 01:15:33 +00:00
window->is_in_queues &= ~META_QUEUE_UPDATE_ICON;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
add more debug spew about conditional build stuff (main): panic to 2003-02-27 Havoc Pennington <hp@pobox.com> * src/main.c (main): add more debug spew about conditional build stuff (main): panic to "Simple" theme * src/window.c, src/window-props.c: move WM_NORMAL_HINTS and WM_PROTOCOLS to new property system; don't queue move resize on updating WM_PROTOCOLS; move WM_HINTS to new property system; reload icon in an idle handler. Changes made on plane from FOSDEM, syncing from laptop.
2003-02-28 01:24:44 +00:00
tmp = tmp->next;
}
g_slist_free (copy);
destroying_windows_disallowed -= 1;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
add more debug spew about conditional build stuff (main): panic to 2003-02-27 Havoc Pennington <hp@pobox.com> * src/main.c (main): add more debug spew about conditional build stuff (main): panic to "Simple" theme * src/window.c, src/window-props.c: move WM_NORMAL_HINTS and WM_PROTOCOLS to new property system; don't queue move resize on updating WM_PROTOCOLS; move WM_HINTS to new property system; reload icon in an idle handler. Changes made on plane from FOSDEM, syncing from laptop.
2003-02-28 01:24:44 +00:00
return FALSE;
}
Update constraints code to support the new _NET_WM_STRUT_PARTIAL EWMH 2003-06-10 Rob Adams <robadams@ucla.edu> Update constraints code to support the new _NET_WM_STRUT_PARTIAL EWMH draft specification. See #86682. Also, fix a bug involving work area invalidation on metacity startup. Fix for #108497. Finally, some minor fixes for full screen windows. * src/window.h: Add new MetaStruts structure to store strut rects for a window. Remove has_struts and do_not_cover flag, and support new MetaStruts instead of the four ints. * src/window.c (meta_window_new): change initialization to work with new struts. Also, move meta_window_update_struts call to after the workspaces are initialized to fix #108497. Remove do_not_cover and related code. (process_property_notify): add strut_partial (update_struts): change function name to meta_window_update_struts and expose in external MetaWindow API. Support partial width struts and the new strut rects. * src/workspace.h: add new GSLists containing pointers to all relevant struts for this workspace. * src/workspace.c (meta_workspace_new): initialize the list of strut rects for this workspace. (meta_workspace_free): free the strut rect lists (ensure_work_areas_validated): support new struts and new strut rect lists. Unleash the per-xinerama work areas. * src/constraints.c (get_outermost_onscreen_positions): Use the current window position along with the new per-workspace strut rects to compute the constraints that apply to a particular window. (constraint_hint_applies_func): don't do hints constraints on fullscreen windows (update_position_limits): for maximized windows use the work areas to set the position limits; for other windows rely on the struts constraints to be computed later in get_outermost_onscreen_positions (meta_window_constrain): don't apply aspect ratio hints to full screen windows * src/display.c (meta_display_open): add _NET_WM_STRUT_PARTIAL atom (meta_rectangle_equal): new helper function for MetaRectangles (event_queue_callback): #ifndef out if USE_GDK_DISPLAY not set to avoid compiler warning * src/display.h: add atom_net_wm_strut_partial, and add meta_rectangle_equal. * src/screen.c (meta_screen_rect_intersects_xinerama): change _window_intersects_ to _rect_intersects_ which is more useful now. (meta_screen_resize_func): update struts on windows with struts since struts are relative to the screen size, and this function is called when the screen size updates. * src/screen.h (meta_screen_rect_intersects_xinerama): change _window_intersects_ to _rect_intersects_ which is more useful now. * src/window-props.c (meta_display_init_window_prop_hooks): add hook for strut_partial * src/tools/metacity-window-demo.c: Support partial-width struts on the dock window tests for metacity testing purposes.
2003-06-26 03:09:38 +00:00
GList*
store strut information, update it on property changes, etc. etc. so we 2002-01-09 Havoc Pennington <hp@pobox.com> * src/window.c, src/window.h: store strut information, update it on property changes, etc. etc. so we avoid panel on maximize. * src/workspace.c (meta_workspace_get_work_area): add accessor for work area so we can compute it lazily * src/display.h, src/display.c: add _NET_WM_STRUT atom and _WIN_HINTS atom
2002-01-10 06:31:31 +00:00
meta_window_get_workspaces (MetaWindow *window)
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
store strut information, update it on property changes, etc. etc. so we 2002-01-09 Havoc Pennington <hp@pobox.com> * src/window.c, src/window.h: store strut information, update it on property changes, etc. etc. so we avoid panel on maximize. * src/workspace.c (meta_workspace_get_work_area): add accessor for work area so we can compute it lazily * src/display.h, src/display.c: add _NET_WM_STRUT atom and _WIN_HINTS atom
2002-01-10 06:31:31 +00:00
if (window->on_all_workspaces)
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
return workspace_manager->workspaces;
window: Fix meta_window_get_workspaces when a window isn't on a workspace Since we're going to be evaluating the work area at startup now, we need to make sure that we don't iterate over workspaces before they're assigned. The easiest way to do this is to make sure that meta_window_get_workspaces doesn't crash. https://bugzilla.gnome.org/show_bug.cgi?id=643606
2012-03-13 04:37:31 +00:00
else if (window->workspace != NULL)
Avoid a memory leak when checking which workspace(s) a window is on. Fixes 2006-02-10 Thomas Thurman <thomas thurman org uk> Avoid a memory leak when checking which workspace(s) a window is on. Fixes #322059. * src/workspace.h (struct MetaWorkspace): * src/workspace.c (meta_workspace_new, meta_workspace_free): added list_containing_self member to MetaWorkspace * src/window.c (meta_window_get_workspaces): use window->workspace->list_containing_self instead of allocating (and leaking) such a list on the fly.
2006-02-11 05:06:08 +00:00
return window->workspace->list_containing_self;
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
else if (window->constructing)
window: Fix meta_window_get_workspaces when a window isn't on a workspace Since we're going to be evaluating the work area at startup now, we need to make sure that we don't iterate over workspaces before they're assigned. The easiest way to do this is to make sure that meta_window_get_workspaces doesn't crash. https://bugzilla.gnome.org/show_bug.cgi?id=643606
2012-03-13 04:37:31 +00:00
return NULL;
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
else
g_assert_not_reached ();
Fix builds with G_DISABLE_ASSERT Commit 25f416c13db added additional compilation warnings, including -Werror=return-type. There are several places where this results in build failures if `g_assert_not_reached()` is disabled at compile time and the compiler misses a return value. https://gitlab.gnome.org/GNOME/mutter/issues/447
2019-01-24 23:47:44 +00:00
return NULL;
store strut information, update it on property changes, etc. etc. so we 2002-01-09 Havoc Pennington <hp@pobox.com> * src/window.c, src/window.h: store strut information, update it on property changes, etc. etc. so we avoid panel on maximize. * src/workspace.c (meta_workspace_get_work_area): add accessor for work area so we can compute it lazily * src/display.h, src/display.c: add _NET_WM_STRUT atom and _WIN_HINTS atom
2002-01-10 06:31:31 +00:00
}
static void
invalidate_work_areas (MetaWindow *window)
{
GList *tmp;
tmp = meta_window_get_workspaces (window);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
store strut information, update it on property changes, etc. etc. so we 2002-01-09 Havoc Pennington <hp@pobox.com> * src/window.c, src/window.h: store strut information, update it on property changes, etc. etc. so we avoid panel on maximize. * src/workspace.c (meta_workspace_get_work_area): add accessor for work area so we can compute it lazily * src/display.h, src/display.c: add _NET_WM_STRUT atom and _WIN_HINTS atom
2002-01-10 06:31:31 +00:00
while (tmp != NULL)
{
meta_workspace_invalidate_work_area (tmp->data);
tmp = tmp->next;
}
}
Update constraints code to support the new _NET_WM_STRUT_PARTIAL EWMH 2003-06-10 Rob Adams <robadams@ucla.edu> Update constraints code to support the new _NET_WM_STRUT_PARTIAL EWMH draft specification. See #86682. Also, fix a bug involving work area invalidation on metacity startup. Fix for #108497. Finally, some minor fixes for full screen windows. * src/window.h: Add new MetaStruts structure to store strut rects for a window. Remove has_struts and do_not_cover flag, and support new MetaStruts instead of the four ints. * src/window.c (meta_window_new): change initialization to work with new struts. Also, move meta_window_update_struts call to after the workspaces are initialized to fix #108497. Remove do_not_cover and related code. (process_property_notify): add strut_partial (update_struts): change function name to meta_window_update_struts and expose in external MetaWindow API. Support partial width struts and the new strut rects. * src/workspace.h: add new GSLists containing pointers to all relevant struts for this workspace. * src/workspace.c (meta_workspace_new): initialize the list of strut rects for this workspace. (meta_workspace_free): free the strut rect lists (ensure_work_areas_validated): support new struts and new strut rect lists. Unleash the per-xinerama work areas. * src/constraints.c (get_outermost_onscreen_positions): Use the current window position along with the new per-workspace strut rects to compute the constraints that apply to a particular window. (constraint_hint_applies_func): don't do hints constraints on fullscreen windows (update_position_limits): for maximized windows use the work areas to set the position limits; for other windows rely on the struts constraints to be computed later in get_outermost_onscreen_positions (meta_window_constrain): don't apply aspect ratio hints to full screen windows * src/display.c (meta_display_open): add _NET_WM_STRUT_PARTIAL atom (meta_rectangle_equal): new helper function for MetaRectangles (event_queue_callback): #ifndef out if USE_GDK_DISPLAY not set to avoid compiler warning * src/display.h: add atom_net_wm_strut_partial, and add meta_rectangle_equal. * src/screen.c (meta_screen_rect_intersects_xinerama): change _window_intersects_ to _rect_intersects_ which is more useful now. (meta_screen_resize_func): update struts on windows with struts since struts are relative to the screen size, and this function is called when the screen size updates. * src/screen.h (meta_screen_rect_intersects_xinerama): change _window_intersects_ to _rect_intersects_ which is more useful now. * src/window-props.c (meta_display_init_window_prop_hooks): add hook for strut_partial * src/tools/metacity-window-demo.c: Support partial-width struts on the dock window tests for metacity testing purposes.
2003-06-26 03:09:38 +00:00
void
meta_window_update_struts (MetaWindow *window)
store strut information, update it on property changes, etc. etc. so we 2002-01-09 Havoc Pennington <hp@pobox.com> * src/window.c, src/window.h: store strut information, update it on property changes, etc. etc. so we avoid panel on maximize. * src/workspace.c (meta_workspace_get_work_area): add accessor for work area so we can compute it lazily * src/display.h, src/display.c: add _NET_WM_STRUT atom and _WIN_HINTS atom
2002-01-10 06:31:31 +00:00
{
window: Move X11 struts implementation to X11 codepath
2014-04-28 21:06:38 +00:00
if (META_WINDOW_GET_CLASS (window)->update_struts (window))
invalidate_work_areas (window);
store strut information, update it on property changes, etc. etc. so we 2002-01-09 Havoc Pennington <hp@pobox.com> * src/window.c, src/window.h: store strut information, update it on property changes, etc. etc. so we avoid panel on maximize. * src/workspace.c (meta_workspace_get_work_area): add accessor for work area so we can compute it lazily * src/display.h, src/display.c: add _NET_WM_STRUT atom and _WIN_HINTS atom
2002-01-10 06:31:31 +00:00
}
window: Replace meta_window_type_changed with meta_window_set_type Which does the equality checking for us.
2014-03-13 20:52:31 +00:00
static void
wayland: implement support for popup surfaces Popup surfaces are mapped into override_redirect surfaces of a DROPDOWN_MENU type, with the addition of a special pointer grab. https://bugzilla.gnome.org/show_bug.cgi?id=707863
2013-09-10 13:53:31 +00:00
meta_window_type_changed (MetaWindow *window)
{
gboolean old_decorated = window->decorated;
GObject *object = G_OBJECT (window);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
wayland: implement support for popup surfaces Popup surfaces are mapped into override_redirect surfaces of a DROPDOWN_MENU type, with the addition of a special pointer grab. https://bugzilla.gnome.org/show_bug.cgi?id=707863
2013-09-10 13:53:31 +00:00
window->attached = meta_window_should_attach_to_parent (window);
window: Fix build The proper function name is "meta_window_recalc_features"
2014-02-01 23:58:58 +00:00
meta_window_recalc_features (window);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
wayland: implement support for popup surfaces Popup surfaces are mapped into override_redirect surfaces of a DROPDOWN_MENU type, with the addition of a special pointer grab. https://bugzilla.gnome.org/show_bug.cgi?id=707863
2013-09-10 13:53:31 +00:00
if (!window->override_redirect)
set_net_wm_state (window);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
wayland: implement support for popup surfaces Popup surfaces are mapped into override_redirect surfaces of a DROPDOWN_MENU type, with the addition of a special pointer grab. https://bugzilla.gnome.org/show_bug.cgi?id=707863
2013-09-10 13:53:31 +00:00
/* Update frame */
if (window->decorated)
meta_window_ensure_frame (window);
else
meta_window_destroy_frame (window);
Give me back my keys. 2003-02-28 Mark McLoughlin <mark@skynet.ie> Give me back my keys. * src/keybindings.c: (meta_window_grab_keys): don't grab keys on DOCK windows. * src/window.c: (recalc_window_type): re-grab the keys.
2003-02-27 22:44:36 +00:00
wayland: implement support for popup surfaces Popup surfaces are mapped into override_redirect surfaces of a DROPDOWN_MENU type, with the addition of a special pointer grab. https://bugzilla.gnome.org/show_bug.cgi?id=707863
2013-09-10 13:53:31 +00:00
/* update stacking constraints */
meta_window_update_layer (window);
meta_window_grab_keys (window);
Turned window decorated flag into MetaWindow::decorated property. This allows things like the compositor to easily track decoration status.
2009-02-11 12:16:41 +00:00
wayland: implement support for popup surfaces Popup surfaces are mapped into override_redirect surfaces of a DROPDOWN_MENU type, with the addition of a special pointer grab. https://bugzilla.gnome.org/show_bug.cgi?id=707863
2013-09-10 13:53:31 +00:00
g_object_freeze_notify (object);
Added MetaWindow::window-type property Read-only property for querying the type of MetaWindow. http://bugzilla.gnome.org/show_bug.cgi?id=588230
2009-08-04 07:06:30 +00:00
wayland: implement support for popup surfaces Popup surfaces are mapped into override_redirect surfaces of a DROPDOWN_MENU type, with the addition of a special pointer grab. https://bugzilla.gnome.org/show_bug.cgi?id=707863
2013-09-10 13:53:31 +00:00
if (old_decorated != window->decorated)
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_DECORATED]);
Added MetaWindow::window-type property Read-only property for querying the type of MetaWindow. http://bugzilla.gnome.org/show_bug.cgi?id=588230
2009-08-04 07:06:30 +00:00
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_WINDOW_TYPE]);
Added MetaWindow::window-type property Read-only property for querying the type of MetaWindow. http://bugzilla.gnome.org/show_bug.cgi?id=588230
2009-08-04 07:06:30 +00:00
wayland: implement support for popup surfaces Popup surfaces are mapped into override_redirect surfaces of a DROPDOWN_MENU type, with the addition of a special pointer grab. https://bugzilla.gnome.org/show_bug.cgi?id=707863
2013-09-10 13:53:31 +00:00
g_object_thaw_notify (object);
...
2001-06-10 03:17:15 +00:00
}
window: Replace meta_window_type_changed with meta_window_set_type Which does the equality checking for us.
2014-03-13 20:52:31 +00:00
void
meta_window_set_type (MetaWindow *window,
MetaWindowType type)
{
if (window->type == type)
return;
window->type = type;
meta_window_type_changed (window);
}
MetaFrame: Cache borders Cache the computed border size so we can fetch the border size at any time without worrying that we'll be spending too much time in the theme code (in some cases we might allocate a PangoFontDescription or do other significant work.) The main effort here is clearing the cache when various bits of window state change that could potentially affect the computed borders. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 22:37:50 +00:00
void
meta_window_frame_size_changed (MetaWindow *window)
{
if (window->frame)
meta_frame_clear_cached_borders (window->frame);
}
Start splitting the X11-specific stuff of MetaWindow out into a subclass This is fairly simple and basic for now, with just skip_taskbar / skip_pager, but eventually a lot of "WM policy" like this, including move-resize, will be in subclasses for each individual surface.
2014-03-18 15:20:22 +00:00
static void
meta_window_get_default_skip_hints (MetaWindow *window,
gboolean *skip_taskbar_out,
gboolean *skip_pager_out)
{
META_WINDOW_GET_CLASS (window)->get_default_skip_hints (window, skip_taskbar_out, skip_pager_out);
}
window: Split out recalc of skip_taskbar / skip_pager This will be our first attempt for the MetaWindowX11Private
2014-03-18 15:10:22 +00:00
static void
meta_window_recalc_skip_features (MetaWindow *window)
{
switch (window->type)
{
/* Force skip taskbar/pager on these window types */
case META_WINDOW_DESKTOP:
case META_WINDOW_DOCK:
case META_WINDOW_TOOLBAR:
case META_WINDOW_MENU:
case META_WINDOW_UTILITY:
case META_WINDOW_SPLASHSCREEN:
case META_WINDOW_DROPDOWN_MENU:
case META_WINDOW_POPUP_MENU:
case META_WINDOW_TOOLTIP:
case META_WINDOW_NOTIFICATION:
case META_WINDOW_COMBO:
case META_WINDOW_DND:
case META_WINDOW_OVERRIDE_OTHER:
window->skip_taskbar = TRUE;
window->skip_pager = TRUE;
break;
case META_WINDOW_DIALOG:
case META_WINDOW_MODAL_DIALOG:
/* only skip taskbar if we have a real transient parent
(and ignore the application hints) */
if (window->transient_for != NULL)
window->skip_taskbar = TRUE;
else
window->skip_taskbar = FALSE;
break;
case META_WINDOW_NORMAL:
Start splitting the X11-specific stuff of MetaWindow out into a subclass This is fairly simple and basic for now, with just skip_taskbar / skip_pager, but eventually a lot of "WM policy" like this, including move-resize, will be in subclasses for each individual surface.
2014-03-18 15:20:22 +00:00
{
gboolean skip_taskbar_hint, skip_pager_hint;
meta_window_get_default_skip_hints (window, &skip_taskbar_hint, &skip_pager_hint);
window->skip_taskbar = skip_taskbar_hint;
window->skip_pager = skip_pager_hint;
}
window: Split out recalc of skip_taskbar / skip_pager This will be our first attempt for the MetaWindowX11Private
2014-03-18 15:10:22 +00:00
break;
}
}
add more debug spew about conditional build stuff (main): panic to 2003-02-27 Havoc Pennington <hp@pobox.com> * src/main.c (main): add more debug spew about conditional build stuff (main): panic to "Simple" theme * src/window.c, src/window-props.c: move WM_NORMAL_HINTS and WM_PROTOCOLS to new property system; don't queue move resize on updating WM_PROTOCOLS; move WM_HINTS to new property system; reload icon in an idle handler. Changes made on plane from FOSDEM, syncing from laptop.
2003-02-28 01:24:44 +00:00
void
meta_window_recalc_features (MetaWindow *window)
...
2001-06-23 18:30:27 +00:00
{
Implements support for _NET_WM_ALLOWED_ACTIONS. Fixes #84282. 2002-08-01 Mark McLoughlin <mark@skynet.ie> Implements support for _NET_WM_ALLOWED_ACTIONS. Fixes #84282. * src/display.[ch]: (meta_display_open): add _NET_WM_ALLOWED_ACTIONS atoms. * src/screen.c: (set_supported_hint): set them as being supported. * src/window.c: (set_allowed_actions_hint): impl setting _NET_WM_ALLOWED_ACTIONS. (recalc_window_features): use it here, but only if things have changed.
2002-08-01 23:52:47 +00:00
gboolean old_has_close_func;
gboolean old_has_minimize_func;
gboolean old_has_move_func;
gboolean old_has_resize_func;
gboolean old_has_shade_func;
gboolean old_always_sticky;
window: Add "skip-taskbar" property We currently only have a method to query the skip-taskbar hint. Add a corresponding property to allow listening for change notifications. https://bugzilla.gnome.org/show_bug.cgi?id=723307
2014-01-30 21:39:54 +00:00
gboolean old_skip_taskbar;
Implements support for _NET_WM_ALLOWED_ACTIONS. Fixes #84282. 2002-08-01 Mark McLoughlin <mark@skynet.ie> Implements support for _NET_WM_ALLOWED_ACTIONS. Fixes #84282. * src/display.[ch]: (meta_display_open): add _NET_WM_ALLOWED_ACTIONS atoms. * src/screen.c: (set_supported_hint): set them as being supported. * src/window.c: (set_allowed_actions_hint): impl setting _NET_WM_ALLOWED_ACTIONS. (recalc_window_features): use it here, but only if things have changed.
2002-08-01 23:52:47 +00:00
old_has_close_func = window->has_close_func;
old_has_minimize_func = window->has_minimize_func;
old_has_move_func = window->has_move_func;
old_has_resize_func = window->has_resize_func;
old_has_shade_func = window->has_shade_func;
old_always_sticky = window->always_sticky;
window: Add "skip-taskbar" property We currently only have a method to query the skip-taskbar hint. Add a corresponding property to allow listening for change notifications. https://bugzilla.gnome.org/show_bug.cgi?id=723307
2014-01-30 21:39:54 +00:00
old_skip_taskbar = window->skip_taskbar;
Implements support for _NET_WM_ALLOWED_ACTIONS. Fixes #84282. 2002-08-01 Mark McLoughlin <mark@skynet.ie> Implements support for _NET_WM_ALLOWED_ACTIONS. Fixes #84282. * src/display.[ch]: (meta_display_open): add _NET_WM_ALLOWED_ACTIONS atoms. * src/screen.c: (set_supported_hint): set them as being supported. * src/window.c: (set_allowed_actions_hint): impl setting _NET_WM_ALLOWED_ACTIONS. (recalc_window_features): use it here, but only if things have changed.
2002-08-01 23:52:47 +00:00
...
2001-06-23 18:30:27 +00:00
/* Use MWM hints initially */
wayland: implement support for popup surfaces Popup surfaces are mapped into override_redirect surfaces of a DROPDOWN_MENU type, with the addition of a special pointer grab. https://bugzilla.gnome.org/show_bug.cgi?id=707863
2013-09-10 13:53:31 +00:00
if (window->client_type == META_WINDOW_CLIENT_TYPE_X11)
window->decorated = window->mwm_decorated;
else
window->decorated = FALSE;
Theme breakage! Themes have to implement "border" frames now, see Atlanta 2002-06-21 Havoc Pennington <hp@pobox.com> Theme breakage! Themes have to implement "border" frames now, see Atlanta for an example. Fixes #84285 * src/tools/metacity-window-demo.c (do_appwindow): add a border-only window * src/window.c (update_mwm_hints): read border only from the MWM hints * src/window.h (struct _MetaWindow): add border_only flag * src/core.c (meta_core_get_frame_type): report border type if required * src/common.h (enum): add META_FRAME_TYPE_BORDER
2002-06-22 03:23:02 +00:00
window->border_only = window->mwm_border_only;
...
2001-06-23 18:30:27 +00:00
window->has_close_func = window->mwm_has_close_func;
window->has_minimize_func = window->mwm_has_minimize_func;
window->has_maximize_func = window->mwm_has_maximize_func;
window->has_move_func = window->mwm_has_move_func;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window->has_resize_func = TRUE;
translate some strings that should have been, and convert to locale 2002-08-24 Havoc Pennington <hp@redhat.com> * src/util.c: translate some strings that should have been, and convert to locale encoding before printing stuff. * src/stack.c (group_member_is_fullscreen): if window itself is fullscreen, return TRUE immediately. * src/window.c (meta_window_configure_request): add hack to fullscreenize large undecorated windows.
2002-08-24 20:54:23 +00:00
/* If min_size == max_size, then don't allow resize */
if (window->size_hints.min_width == window->size_hints.max_width &&
window->size_hints.min_height == window->size_hints.max_height)
window->has_resize_func = FALSE;
else if (!window->mwm_has_resize_func)
{
/* We ignore mwm_has_resize_func because WM_NORMAL_HINTS is the
* authoritative source for that info. Some apps such as mplayer or
* xine disable resize via MWM but not WM_NORMAL_HINTS, but that
* leads to e.g. us not fullscreening their windows. Apps that set
* MWM but not WM_NORMAL_HINTS are basically broken. We complain
* about these apps but make them work.
*/
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Don't translate debug logs and warnings Warnings that are going to the journal should be not translated: they're not user visible, and translating them would just make bug reporting harder (as now the developers need to understand what the warning is saying) https://bugzilla.gnome.org/show_bug.cgi?id=707897
2013-09-11 08:37:36 +00:00
meta_warning ("Window %s sets an MWM hint indicating it isn't resizable, but sets min size %d x %d and max size %d x %d; this doesn't make much sense.\n",
translate some strings that should have been, and convert to locale 2002-08-24 Havoc Pennington <hp@redhat.com> * src/util.c: translate some strings that should have been, and convert to locale encoding before printing stuff. * src/stack.c (group_member_is_fullscreen): if window itself is fullscreen, return TRUE immediately. * src/window.c (meta_window_configure_request): add hack to fullscreenize large undecorated windows.
2002-08-24 20:54:23 +00:00
window->desc,
window->size_hints.min_width,
window->size_hints.min_height,
window->size_hints.max_width,
window->size_hints.max_height);
}
...
2001-06-23 18:30:27 +00:00
window->has_shade_func = TRUE;
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
window->has_fullscreen_func = TRUE;
Patch from Gaute Lindkvist so you can't move the panel or desktop to only 2002-05-26 Havoc Pennington <hp@pobox.com> Patch from Gaute Lindkvist so you can't move the panel or desktop to only one workspace. * src/keybindings.c (handle_move_to_workspace): don't allow moving window to another space if the window is always_sticky * src/window.c (recalc_window_features): set the always_sticky field for desktop/dock windows. (meta_window_show_menu): disable unsticking always sticky windows via the menus * src/menu.c (meta_window_menu_new): disable workspace items if requested
2002-05-26 15:54:38 +00:00
window->always_sticky = FALSE;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-06-23 18:30:27 +00:00
/* Semantic category overrides the MWM hints */
don't try to decorate toolbars. 2002-04-30 Havoc Pennington <hp@pobox.com> * src/window.c (recalc_window_features): don't try to decorate toolbars. * src/tools/metacity-window-demo.c: add menu and toolbar tests * src/place.c (meta_window_place): only dialogs should be centered over parent, not anything with transient for set. * src/window.c (meta_window_configure_request): become more fascist about window positioning if workarounds are disabled, and less fascist if they are enabled. * src/metacity.schemas: add a "disable_workarounds" option. Kind of crack-smoking. But we just can't get all applications fixed. And I need no-workarounds mode to monitor which apps are broken and what needs fixing in specs. * src/window.c (meta_window_configure_request): always allow windows to resize themselves * src/keybindings.c (reload_modmap): don't filter out Mode_switch, apparently some people bind window manager shortcuts to that.
2002-05-01 03:23:46 +00:00
if (window->type == META_WINDOW_TOOLBAR)
window->decorated = FALSE;
Patch from Gaute Lindkvist so you can't move the panel or desktop to only 2002-05-26 Havoc Pennington <hp@pobox.com> Patch from Gaute Lindkvist so you can't move the panel or desktop to only one workspace. * src/keybindings.c (handle_move_to_workspace): don't allow moving window to another space if the window is always_sticky * src/window.c (recalc_window_features): set the always_sticky field for desktop/dock windows. (meta_window_show_menu): disable unsticking always sticky windows via the menus * src/menu.c (meta_window_menu_new): disable workspace items if requested
2002-05-26 15:54:38 +00:00
if (window->type == META_WINDOW_DESKTOP ||
Adds support in src/core for tracking override redirect windows. The metacity core is now directly aware of override redirect windows. - They get MetaWindows like normal windows, so mutter no longer need to special case them. The net wm types applicable to override redirects are also recognised. - The original positioning/stacking semantics of metacity with respect to OR windows are maintained, but now it's easier to synchronize the stacking between the core and mutter. - mutter no longer needs to manualy track UnmapNotify, MapNotify, ReparentNotify, CreateNotify and DestroyNotify events; instead map, unmap, add and remove events can now be consistently delivered via the MetaCompositor callbacks.
2008-11-23 19:28:40 +00:00
window->type == META_WINDOW_DOCK ||
window->override_redirect)
Patch from Gaute Lindkvist so you can't move the panel or desktop to only 2002-05-26 Havoc Pennington <hp@pobox.com> Patch from Gaute Lindkvist so you can't move the panel or desktop to only one workspace. * src/keybindings.c (handle_move_to_workspace): don't allow moving window to another space if the window is always_sticky * src/window.c (recalc_window_features): set the always_sticky field for desktop/dock windows. (meta_window_show_menu): disable unsticking always sticky windows via the menus * src/menu.c (meta_window_menu_new): disable workspace items if requested
2002-05-26 15:54:38 +00:00
window->always_sticky = TRUE;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window.c: use a consistent mapping from frame_type => decorated If a window had a type hint intended for override-redirect windows like NOTIFICATION, we ended up with a window that was decorated but with a frame type of FRAME_TYPE_LAST, causing assertion failures. Fix this by making recalc_window_features() just call meta_window_get_frame_type(). https://bugzilla.gnome.org/show_bug.cgi?id=599988
2011-10-17 15:42:35 +00:00
if (window->override_redirect ||
meta_window_get_frame_type (window) == META_FRAME_TYPE_LAST)
...
2001-06-23 18:30:27 +00:00
{
...
2001-07-31 03:59:55 +00:00
window->decorated = FALSE;
...
2001-06-23 18:30:27 +00:00
window->has_close_func = FALSE;
window->has_shade_func = FALSE;
don't try to decorate toolbars. 2002-04-30 Havoc Pennington <hp@pobox.com> * src/window.c (recalc_window_features): don't try to decorate toolbars. * src/tools/metacity-window-demo.c: add menu and toolbar tests * src/place.c (meta_window_place): only dialogs should be centered over parent, not anything with transient for set. * src/window.c (meta_window_configure_request): become more fascist about window positioning if workarounds are disabled, and less fascist if they are enabled. * src/metacity.schemas: add a "disable_workarounds" option. Kind of crack-smoking. But we just can't get all applications fixed. And I need no-workarounds mode to monitor which apps are broken and what needs fixing in specs. * src/window.c (meta_window_configure_request): always allow windows to resize themselves * src/keybindings.c (reload_modmap): don't filter out Mode_switch, apparently some people bind window manager shortcuts to that.
2002-05-01 03:23:46 +00:00
/* FIXME this keeps panels and things from using
* NET_WM_MOVERESIZE; the problem is that some
* panels (edge panels) have fixed possible locations,
* and others ("floating panels") do not.
*
* Perhaps we should require edge panels to explicitly
* disable movement?
*/
...
2001-06-23 18:30:27 +00:00
window->has_move_func = FALSE;
window->has_resize_func = FALSE;
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
...
2001-06-23 18:30:27 +00:00
if (window->type != META_WINDOW_NORMAL)
{
window->has_minimize_func = FALSE;
window->has_maximize_func = FALSE;
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
window->has_fullscreen_func = FALSE;
...
2001-06-23 18:30:27 +00:00
}
push error trap around configure of withdrawn window, fixes a crash caused 2001-08-03 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): push error trap around configure of withdrawn window, fixes a crash caused by rapidly creating/destroying a window. * src/window.c (recalc_window_features): don't allow shading undecorated windows. * src/wm-tester/main.c: add a program to torture window managers.
2001-08-03 04:20:27 +00:00
if (!window->has_resize_func)
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
{
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
window->has_maximize_func = FALSE;
Use MetaMonitorManager insted of MetaDisplay where possible This drops display's monitors-changed signal and makes all the code rely on MetaMonitorManager. https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 18:44:38 +00:00
MetaRectangle display_rect = { 0 };
meta_display_get_size (window->display, &display_rect.width,
&display_rect.height);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
translate some strings that should have been, and convert to locale 2002-08-24 Havoc Pennington <hp@redhat.com> * src/util.c: translate some strings that should have been, and convert to locale encoding before printing stuff. * src/stack.c (group_member_is_fullscreen): if window itself is fullscreen, return TRUE immediately. * src/window.c (meta_window_configure_request): add hack to fullscreenize large undecorated windows.
2002-08-24 20:54:23 +00:00
/* don't allow fullscreen if we can't resize, unless the size
* is entire screen size (kind of broken, because we
Refer to monitors as "monitors" rather than "xineramas" http://bugzilla.gnome.org/show_bug.cgi?id=593686
2009-08-31 13:52:16 +00:00
* actually fullscreen to monitor size not screen size)
translate some strings that should have been, and convert to locale 2002-08-24 Havoc Pennington <hp@redhat.com> * src/util.c: translate some strings that should have been, and convert to locale encoding before printing stuff. * src/stack.c (group_member_is_fullscreen): if window itself is fullscreen, return TRUE immediately. * src/window.c (meta_window_configure_request): add hack to fullscreenize large undecorated windows.
2002-08-24 20:54:23 +00:00
*/
Use MetaMonitorManager insted of MetaDisplay where possible This drops display's monitors-changed signal and makes all the code rely on MetaMonitorManager. https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 18:44:38 +00:00
if (window->size_hints.min_width == display_rect.width &&
window->size_hints.min_height == display_rect.height)
leave has_fullscreen_func set to TRUE if the window is screen sized and 2002-08-15 Havoc Pennington <hp@pobox.com> * src/window.c (recalc_window_features): leave has_fullscreen_func set to TRUE if the window is screen sized and undecorated, even if the window isn't resizable. idea from Christian - Manny Calavera - Neumair * src/keybindings.c (handle_toggle_fullscreen) (handle_toggle_maximize): these disabled fullscreen/maximize if the window wasn't resizable, should have used has_fullscreen_func has_maximize_func instead. 2002-08-15 Havoc Pennington <hp@pobox.com> * src/keybindings.c: implement raise/lower * src/metacity.schemas.in: add raise/lower * src/prefs.c: add "raise" and "lower" prefs to keybindings * src/display.c (meta_display_set_grab_op_cursor): assert that the screen arg is non-NULL in appropriate cases
2002-08-15 05:14:49 +00:00
; /* leave fullscreen available */
else
window->has_fullscreen_func = FALSE;
small reordering of code 2002-09-22 Havoc Pennington <hp@pobox.com> * src/window.c (recalc_window_features): small reordering of code * src/display.c (meta_spew_event): more spew for MapNotify, UnmapNotify * src/window.c (recalc_window_features): spew more stuff * src/display.c (meta_spew_event): spew override_redirect field of ConfigureNotify
2002-09-23 01:43:20 +00:00
}
translate some strings that should have been, and convert to locale 2002-08-24 Havoc Pennington <hp@redhat.com> * src/util.c: translate some strings that should have been, and convert to locale encoding before printing stuff. * src/stack.c (group_member_is_fullscreen): if window itself is fullscreen, return TRUE immediately. * src/window.c (meta_window_configure_request): add hack to fullscreenize large undecorated windows.
2002-08-24 20:54:23 +00:00
small reordering of code 2002-09-22 Havoc Pennington <hp@pobox.com> * src/window.c (recalc_window_features): small reordering of code * src/display.c (meta_spew_event): more spew for MapNotify, UnmapNotify * src/window.c (recalc_window_features): spew more stuff * src/display.c (meta_spew_event): spew override_redirect field of ConfigureNotify
2002-09-23 01:43:20 +00:00
/* We leave fullscreen windows decorated, just push the frame outside
* the screen. This avoids flickering to unparent them.
*
* Note that setting has_resize_func = FALSE here must come after the
* above code that may disable fullscreen, because if the window
* is not resizable purely due to fullscreen, we don't want to
* disable fullscreen mode.
*/
if (window->fullscreen)
{
window->has_shade_func = FALSE;
window->has_move_func = FALSE;
window->has_resize_func = FALSE;
window->has_maximize_func = FALSE;
put in hack to keep Pango from mangling our server grab and locking up on 2002-02-19 Havoc Pennington <hp@pobox.com> * src/ui.c (meta_ui_init): put in hack to keep Pango from mangling our server grab and locking up on startup. (hack doesn't work but I want to fix it on my real computer not this laptop) * src/window.c: Implement _NET_WM_STATE_FULLSCREEN * src/display.c (meta_display_open): add atoms for _NET_WM_STATE_FULLSCREEN
2002-02-23 22:58:02 +00:00
}
push error trap around configure of withdrawn window, fixes a crash caused 2001-08-03 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): push error trap around configure of withdrawn window, fixes a crash caused by rapidly creating/destroying a window. * src/window.c (recalc_window_features): don't allow shading undecorated windows. * src/wm-tester/main.c: add a program to torture window managers.
2001-08-03 04:20:27 +00:00
window: Handle being headless better This avoids updating state (such as position, size etc) when going headless. Eventually, when non-headless, things will be updated again, and not until then will we be able to update to a valid state. https://bugzilla.gnome.org/show_bug.cgi?id=730551
2017-08-18 06:21:11 +00:00
if (window->has_maximize_func && window->monitor)
window: Disallow maximization for windows that can't be maximized Windows that have minimum widths larger than the screen can't be maximized, even though we put them in a maximized state and allow users to do so: the window just won't change size and position. Fix this by simply not giving the option to maximize, like what happens for non-resizable windows. https://bugzilla.gnome.org/show_bug.cgi?id=643606
2012-03-13 03:18:03 +00:00
{
Use utility functions to convert between frame and client rectangles There are extensive places in the code where we convert between the client rectangle and the frame rectangle. Instead of manually doing it use new helper functions on MetaWindow and the existing meta_window_get_outer_rect(). This fixes a number of bugs where the computation was being done incorrectly, most of these bugs are with the recently added custom frame extents, but some relate to invisible borders or even simply to confusion between the window and frame rectangle. Switch the placement code to place the frame rectangle rather than the client window - this simplifies things considerably. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 21:11:20 +00:00
MetaRectangle work_area, client_rect;
window: Disallow maximization for windows that can't be maximized Windows that have minimum widths larger than the screen can't be maximized, even though we put them in a maximized state and allow users to do so: the window just won't change size and position. Fix this by simply not giving the option to maximize, like what happens for non-resizable windows. https://bugzilla.gnome.org/show_bug.cgi?id=643606
2012-03-13 03:18:03 +00:00
meta_window_get_work_area_current_monitor (window, &work_area);
Use utility functions to convert between frame and client rectangles There are extensive places in the code where we convert between the client rectangle and the frame rectangle. Instead of manually doing it use new helper functions on MetaWindow and the existing meta_window_get_outer_rect(). This fixes a number of bugs where the computation was being done incorrectly, most of these bugs are with the recently added custom frame extents, but some relate to invisible borders or even simply to confusion between the window and frame rectangle. Switch the placement code to place the frame rectangle rather than the client window - this simplifies things considerably. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 21:11:20 +00:00
meta_window_frame_rect_to_client_rect (window, &work_area, &client_rect);
window: Disallow maximization for windows that can't be maximized Windows that have minimum widths larger than the screen can't be maximized, even though we put them in a maximized state and allow users to do so: the window just won't change size and position. Fix this by simply not giving the option to maximize, like what happens for non-resizable windows. https://bugzilla.gnome.org/show_bug.cgi?id=643606
2012-03-13 03:18:03 +00:00
Use utility functions to convert between frame and client rectangles There are extensive places in the code where we convert between the client rectangle and the frame rectangle. Instead of manually doing it use new helper functions on MetaWindow and the existing meta_window_get_outer_rect(). This fixes a number of bugs where the computation was being done incorrectly, most of these bugs are with the recently added custom frame extents, but some relate to invisible borders or even simply to confusion between the window and frame rectangle. Switch the placement code to place the frame rectangle rather than the client window - this simplifies things considerably. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 21:11:20 +00:00
if (window->size_hints.min_width >= client_rect.width ||
window->size_hints.min_height >= client_rect.height)
window: Disallow maximization for windows that can't be maximized Windows that have minimum widths larger than the screen can't be maximized, even though we put them in a maximized state and allow users to do so: the window just won't change size and position. Fix this by simply not giving the option to maximize, like what happens for non-resizable windows. https://bugzilla.gnome.org/show_bug.cgi?id=643606
2012-03-13 03:18:03 +00:00
window->has_maximize_func = FALSE;
}
small reordering of code 2002-09-22 Havoc Pennington <hp@pobox.com> * src/window.c (recalc_window_features): small reordering of code * src/display.c (meta_spew_event): more spew for MapNotify, UnmapNotify * src/window.c (recalc_window_features): spew more stuff * src/display.c (meta_spew_event): spew override_redirect field of ConfigureNotify
2002-09-23 01:43:20 +00:00
meta_topic (META_DEBUG_WINDOW_OPS,
"Window %s fullscreen = %d not resizable, maximizable = %d fullscreenable = %d min size %dx%d max size %dx%d\n",
window->desc,
window->fullscreen,
window->has_maximize_func, window->has_fullscreen_func,
window->size_hints.min_width,
window->size_hints.min_height,
window->size_hints.max_width,
window->size_hints.max_height);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
push error trap around configure of withdrawn window, fixes a crash caused 2001-08-03 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): push error trap around configure of withdrawn window, fixes a crash caused by rapidly creating/destroying a window. * src/window.c (recalc_window_features): don't allow shading undecorated windows. * src/wm-tester/main.c: add a program to torture window managers.
2001-08-03 04:20:27 +00:00
/* no shading if not decorated */
add Metabox theme from Garrett 2002-07-24 Havoc Pennington <hp@pobox.com> * src/themes/Makefile.am (THEMES): add Metabox theme from Garrett * README: updates 2002-07-21 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_new): don't automaximize fullscreen windows. 2002-07-14 Havoc Pennington <hp@pobox.com> * src/window.c (recalc_window_features): don't allow shading of border-only windows.
2002-07-25 02:45:38 +00:00
if (!window->decorated || window->border_only)
push error trap around configure of withdrawn window, fixes a crash caused 2001-08-03 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): push error trap around configure of withdrawn window, fixes a crash caused by rapidly creating/destroying a window. * src/window.c (recalc_window_features): don't allow shading undecorated windows. * src/wm-tester/main.c: add a program to torture window managers.
2001-08-03 04:20:27 +00:00
window->has_shade_func = FALSE;
Apply blackc@speakeasy.net patch, bug #83940, to do mini-workspaces 2002-07-06 Havoc Pennington <hp@pobox.com> Apply blackc@speakeasy.net patch, bug #83940, to do mini-workspaces similar to the pager, when switching spaces. * src/window.c (update_net_wm_state): actually fill in wm_state_skip_taskbar, wm_state_skip_pager flags * src/tabpopup.c: support drawing a mini-workspace similar to the one the pager draws. * src/stack.c (meta_stack_list_windows): new function to list the windows in stacking order * src/screen.c (meta_screen_ensure_workspace_popup): don't pass in the ugly default app icon for workspaces * src/display.c (event_callback): fix from blackc@speakeasy.net to avoid dereferencing a NULL grab window.
2002-07-06 19:05:37 +00:00
window: Split out recalc of skip_taskbar / skip_pager This will be our first attempt for the MetaWindowX11Private
2014-03-18 15:10:22 +00:00
meta_window_recalc_skip_features (window);
Implements support for _NET_WM_ALLOWED_ACTIONS. Fixes #84282. 2002-08-01 Mark McLoughlin <mark@skynet.ie> Implements support for _NET_WM_ALLOWED_ACTIONS. Fixes #84282. * src/display.[ch]: (meta_display_open): add _NET_WM_ALLOWED_ACTIONS atoms. * src/screen.c: (set_supported_hint): set them as being supported. * src/window.c: (set_allowed_actions_hint): impl setting _NET_WM_ALLOWED_ACTIONS. (recalc_window_features): use it here, but only if things have changed.
2002-08-01 23:52:47 +00:00
window: Allow minimizing windows which don't advertise support for it Wine removes the minimize func from its Motif hints on full-screen windows, because, as the Win32 API literally says, the minimize button is indeed not visible on full-screen windows. Given that this code was added to prevent minimizing a panel by accident, I don't necessarily think that it's relevant anymore. https://bugzilla.gnome.org/show_bug.cgi?id=758186
2015-11-16 23:31:55 +00:00
/* To prevent users from losing windows, let's prevent users from
* minimizing skip-taskbar windows through the window decorations. */
if (window->skip_taskbar)
window->has_minimize_func = FALSE;
small reordering of code 2002-09-22 Havoc Pennington <hp@pobox.com> * src/window.c (recalc_window_features): small reordering of code * src/display.c (meta_spew_event): more spew for MapNotify, UnmapNotify * src/window.c (recalc_window_features): spew more stuff * src/display.c (meta_spew_event): spew override_redirect field of ConfigureNotify
2002-09-23 01:43:20 +00:00
meta_topic (META_DEBUG_WINDOW_OPS,
"Window %s decorated = %d border_only = %d has_close = %d has_minimize = %d has_maximize = %d has_move = %d has_shade = %d skip_taskbar = %d skip_pager = %d\n",
window->desc,
window->decorated,
window->border_only,
window->has_close_func,
window->has_minimize_func,
window->has_maximize_func,
window->has_move_func,
window->has_shade_func,
window->skip_taskbar,
window->skip_pager);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window: Add "skip-taskbar" property We currently only have a method to query the skip-taskbar hint. Add a corresponding property to allow listening for change notifications. https://bugzilla.gnome.org/show_bug.cgi?id=723307
2014-01-30 21:39:54 +00:00
if (old_skip_taskbar != window->skip_taskbar)
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_SKIP_TASKBAR]);
window: Add "skip-taskbar" property We currently only have a method to query the skip-taskbar hint. Add a corresponding property to allow listening for change notifications. https://bugzilla.gnome.org/show_bug.cgi?id=723307
2014-01-30 21:39:54 +00:00
Implements support for _NET_WM_ALLOWED_ACTIONS. Fixes #84282. 2002-08-01 Mark McLoughlin <mark@skynet.ie> Implements support for _NET_WM_ALLOWED_ACTIONS. Fixes #84282. * src/display.[ch]: (meta_display_open): add _NET_WM_ALLOWED_ACTIONS atoms. * src/screen.c: (set_supported_hint): set them as being supported. * src/window.c: (set_allowed_actions_hint): impl setting _NET_WM_ALLOWED_ACTIONS. (recalc_window_features): use it here, but only if things have changed.
2002-08-01 23:52:47 +00:00
/* FIXME:
window: Fix build The proper function name is "meta_window_recalc_features"
2014-02-01 23:58:58 +00:00
* Lame workaround for recalc_features being used overzealously.
* The fix is to only recalc_features when something has
* actually changed.
Implements support for _NET_WM_ALLOWED_ACTIONS. Fixes #84282. 2002-08-01 Mark McLoughlin <mark@skynet.ie> Implements support for _NET_WM_ALLOWED_ACTIONS. Fixes #84282. * src/display.[ch]: (meta_display_open): add _NET_WM_ALLOWED_ACTIONS atoms. * src/screen.c: (set_supported_hint): set them as being supported. * src/window.c: (set_allowed_actions_hint): impl setting _NET_WM_ALLOWED_ACTIONS. (recalc_window_features): use it here, but only if things have changed.
2002-08-01 23:52:47 +00:00
*/
make sure to set _NET_WM_ALLOWED_ACTIONS so that libwnck menus don't have 2007-04-10 Elijah Newren <newren gmail com> * src/window.c (recalc_window_features): make sure to set _NET_WM_ALLOWED_ACTIONS so that libwnck menus don't have sensitive but ineffective menu items. The "On Top" item is now buggy, but due to the fact that _NET_WM_ACTION_ABOVE is not yet defined in the EWMH. Fixes #115247. svn path=/trunk/; revision=3189
2007-04-11 02:37:30 +00:00
if (window->constructing ||
old_has_close_func != window->has_close_func ||
Implements support for _NET_WM_ALLOWED_ACTIONS. Fixes #84282. 2002-08-01 Mark McLoughlin <mark@skynet.ie> Implements support for _NET_WM_ALLOWED_ACTIONS. Fixes #84282. * src/display.[ch]: (meta_display_open): add _NET_WM_ALLOWED_ACTIONS atoms. * src/screen.c: (set_supported_hint): set them as being supported. * src/window.c: (set_allowed_actions_hint): impl setting _NET_WM_ALLOWED_ACTIONS. (recalc_window_features): use it here, but only if things have changed.
2002-08-01 23:52:47 +00:00
old_has_minimize_func != window->has_minimize_func ||
old_has_move_func != window->has_move_func ||
old_has_resize_func != window->has_resize_func ||
old_has_shade_func != window->has_shade_func ||
old_always_sticky != window->always_sticky)
set_allowed_actions_hint (window);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
MetaWindow: Add :resizable and :above properties Allow libmutter users to treat windows different based on these attributes and to watch for changes. https://bugzilla.gnome.org/show_bug.cgi?id=653858
2011-07-02 11:08:17 +00:00
if (window->has_resize_func != old_has_resize_func)
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_RESIZEABLE]);
MetaWindow: Add :resizable and :above properties Allow libmutter users to treat windows different based on these attributes and to watch for changes. https://bugzilla.gnome.org/show_bug.cgi?id=653858
2011-07-02 11:08:17 +00:00
MetaFrame: Cache borders Cache the computed border size so we can fetch the border size at any time without worrying that we'll be spending too much time in the theme code (in some cases we might allocate a PangoFontDescription or do other significant work.) The main effort here is clearing the cache when various bits of window state change that could potentially affect the computed borders. https://bugzilla.gnome.org/show_bug.cgi?id=707194
2013-11-15 22:37:50 +00:00
meta_window_frame_size_changed (window);
...
2001-06-23 18:30:27 +00:00
/* FIXME perhaps should ensure if we don't have a shade func,
* we aren't shaded, etc.
*/
}
...
2001-06-23 05:49:35 +00:00
void
Actually implement opening the app menu The last commit added support for the "appmenu" button in decorations, but didn't actually implement it. Add a new MetaWindowMenuType parameter to the show_window_menu () functions and use it to ask the compositor to display the app menu when the new button is activated. https://bugzilla.gnome.org/show_bug.cgi?id=730752
2014-05-23 21:14:51 +00:00
meta_window_show_menu (MetaWindow *window,
MetaWindowMenuType menu,
int x,
int y)
Convert window menus to a compositor implementation
2014-03-13 22:34:14 +00:00
{
Add checks against inappropriate changes to override-redirect window Add g_return_if_fail() to check that window-management functions like meta_window_maximize() aren't called on override-redirect windows. This reveals that were were "unminimizing" override-redirect windows when adding them; avoid doing that. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:11:29 +00:00
g_return_if_fail (!window->override_redirect);
Actually implement opening the app menu The last commit added support for the "appmenu" button in decorations, but didn't actually implement it. Add a new MetaWindowMenuType parameter to the show_window_menu () functions and use it to ask the compositor to display the app menu when the new button is activated. https://bugzilla.gnome.org/show_bug.cgi?id=730752
2014-05-23 21:14:51 +00:00
meta_compositor_show_window_menu (window->display->compositor, window, menu, x, y);
...
2001-06-23 05:49:35 +00:00
}
...
2001-06-24 08:09:10 +00:00
Pass button_rect when opening window menu from button When opening the window menu without an associated control - e.g. by right-clicking the titlebar or by keyboard - using coordinates for the menu position is appropriate. However when the menu is associated with a window button, the expected behavior in the shell can be implemented much easier with the full button geometry: the menu will point to the center of the button's bottom edge rather than align to the left/right side of the titlebar as it does now, and the clickable area where a release event does not dismiss the menu will match the actual clickable area in mutter. So add an additional show_window_menu_for_rect() function and use it when opening the menu from a button. https://bugzilla.gnome.org/show_bug.cgi?id=731058
2014-05-30 22:52:06 +00:00
void
meta_window_show_menu_for_rect (MetaWindow *window,
MetaWindowMenuType menu,
MetaRectangle *rect)
{
g_return_if_fail (!window->override_redirect);
meta_compositor_show_window_menu_for_rect (window->display->compositor, window, menu, rect);
}
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
void
meta_window_shove_titlebar_onscreen (MetaWindow *window)
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
Rename meta_window_get_outer_rect() to meta_window_get_frame_rect() For clarity, rename meta_window_get_outer_rect() to match terminology we use elsewhere. The old function is left as a deprecated compatibility wrapper.
2013-11-19 17:24:45 +00:00
MetaRectangle frame_rect;
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
GList *onscreen_region;
int horiz_amount, vert_amount;
Avoid moving and resizing override-redirect windows Override-redirect windows should not be moved or resized by the window manager. - Mark override-redirect windows as already placed to avoid placing them when first shown. - Don't move-resize newly created override-redirect MetaWindow - Don't queue a resize on override-redirect windows when reading their WM_TRANSIENT_FOR hint. - Add g_return_if_fail (!window->override_redirect) to catch unexpected code paths that might result in override-redirect windows being moved or resized. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-15 22:25:07 +00:00
g_return_if_fail (!window->override_redirect);
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
/* If there's no titlebar, don't bother */
if (!window->frame)
return;
/* Get the basic info we need */
Rename meta_window_get_outer_rect() to meta_window_get_frame_rect() For clarity, rename meta_window_get_outer_rect() to match terminology we use elsewhere. The old function is left as a deprecated compatibility wrapper.
2013-11-19 17:24:45 +00:00
meta_window_get_frame_rect (window, &frame_rect);
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
onscreen_region = workspace_manager->active_workspace->screen_region;
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
/* Extend the region (just in case the window is too big to fit on the
* screen), then shove the window on screen, then return the region to
* normal.
*/
Rename meta_window_get_outer_rect() to meta_window_get_frame_rect() For clarity, rename meta_window_get_outer_rect() to match terminology we use elsewhere. The old function is left as a deprecated compatibility wrapper.
2013-11-19 17:24:45 +00:00
horiz_amount = frame_rect.width;
vert_amount = frame_rect.height;
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
meta_rectangle_expand_region (onscreen_region,
horiz_amount,
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
horiz_amount,
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
0,
vert_amount);
meta_rectangle_shove_into_region(onscreen_region,
FIXED_DIRECTION_X,
Rename meta_window_get_outer_rect() to meta_window_get_frame_rect() For clarity, rename meta_window_get_outer_rect() to match terminology we use elsewhere. The old function is left as a deprecated compatibility wrapper.
2013-11-19 17:24:45 +00:00
&frame_rect);
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
meta_rectangle_expand_region (onscreen_region,
-horiz_amount,
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
-horiz_amount,
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
0,
-vert_amount);
window: Remove some overcomplicated uses of meta_window_move_resize Replace them with meta_window_move_frame, since that's all we need to do.
2014-05-21 12:51:24 +00:00
meta_window_move_frame (window, FALSE, frame_rect.x, frame_rect.y);
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
}
gboolean
meta_window_titlebar_is_onscreen (MetaWindow *window)
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
window: Fix titlebar_is_onscreen() test The titlebar rect is in window coordinates, while screen regions are obviously not. Fix by translating into screen coordinates before testing for overlaps. https://bugzilla.gnome.org/show_bug.cgi?id=736915
2014-09-18 15:29:50 +00:00
MetaRectangle titlebar_rect, frame_rect;
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
GList *onscreen_region;
gboolean is_onscreen;
const int min_height_needed = 8;
window: fix coerced value (int) 0.5 = 0, so there always was 0 instead of 50%
2013-12-19 15:56:31 +00:00
const float min_width_percent = 0.5;
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
const int min_width_absolute = 50;
/* Titlebar can't be offscreen if there is no titlebar... */
if (!window->frame)
Fix meta_window_titlebar_is_onscreen() for titlebar-less windows Make the code correspond to the comment - the titlebar can't be offscreen if there's no titlebar. https://bugzilla.gnome.org/show_bug.cgi?id=723580
2014-03-06 00:40:09 +00:00
return TRUE;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
/* Get the rectangle corresponding to the titlebar */
window: Add a meta_window_get_titlebar_rect
2014-05-22 20:48:58 +00:00
meta_window_get_titlebar_rect (window, &titlebar_rect);
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
window: Fix titlebar_is_onscreen() test The titlebar rect is in window coordinates, while screen regions are obviously not. Fix by translating into screen coordinates before testing for overlaps. https://bugzilla.gnome.org/show_bug.cgi?id=736915
2014-09-18 15:29:50 +00:00
/* Translate into screen coordinates */
meta_window_get_frame_rect (window, &frame_rect);
titlebar_rect.x = frame_rect.x;
titlebar_rect.y = frame_rect.y;
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
/* Run through the spanning rectangles for the screen and see if one of
* them overlaps with the titlebar sufficiently to consider it onscreen.
*/
is_onscreen = FALSE;
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
onscreen_region = workspace_manager->active_workspace->screen_region;
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
while (onscreen_region)
{
MetaRectangle *spanning_rect = onscreen_region->data;
MetaRectangle overlap;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
meta_rectangle_intersect (&titlebar_rect, spanning_rect, &overlap);
if (overlap.height > MIN (titlebar_rect.height, min_height_needed) &&
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
overlap.width > MIN (titlebar_rect.width * min_width_percent,
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
min_width_absolute))
{
is_onscreen = TRUE;
break;
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
onscreen_region = onscreen_region->next;
}
return is_onscreen;
}
track time to avoid sending a deluge of move/resize requests, suggestion 2002-08-10 Havoc Pennington <hp@pobox.com> * src/window.c (update_resize): track time to avoid sending a deluge of move/resize requests, suggestion from xavier.bestel@free.fr bug #86830. Not really sure if this will make a difference or not. We'll see I guess. (update_move): do same on move though it seems less important here. * src/display.h (struct _MetaDisplay): store the last time we sent a move/resize event.
2002-08-10 05:27:17 +00:00
static gboolean
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
check_moveresize_frequency (MetaWindow *window,
Fix bug 143333, support for update counter spec, and 109362, schedule Sat Jun 19 02:21:08 2004 Soeren Sandmann <sandmann@daimi.au.dk> Fix bug 143333, support for update counter spec, and 109362, schedule compensation events when events are ignored. * src/display.c (meta_display_open): Add _NET_WM_SYNC_REQUEST and _NET_WM_SYNC_REQUEST_COUNTER atoms. Remove the old METACITY_SYNC_COUNTER stuff. (meta_display_begin_op): Setup the sync counter * src/xprops.c, src/xprops.h, src/window-props.c, src/display.h: Add new atoms. * src/window.c (send_sync_request): new function. (meta_window_move_resize_internal): send a sync request before resizing. (check_move_resize_frequence): Rework logic to also check the SYNC case. If an event is ignored return the remaining time. (update_resize_timeout): Timeout that gets called when a compensation event is scheduled. (uddate_resize): schedule compensation events when an event is ignored. (meta_window_handle_mouse_grap_op_event): When an alarm is received and sync was turned off, turn it back on. * src/window.h (struct MetaWindow) Add some variables
2004-06-19 00:45:24 +00:00
gdouble *remaining)
track time to avoid sending a deluge of move/resize requests, suggestion 2002-08-10 Havoc Pennington <hp@pobox.com> * src/window.c (update_resize): track time to avoid sending a deluge of move/resize requests, suggestion from xavier.bestel@free.fr bug #86830. Not really sure if this will make a difference or not. We'll see I guess. (update_move): do same on move though it seems less important here. * src/display.h (struct _MetaDisplay): store the last time we sent a move/resize event.
2002-08-10 05:27:17 +00:00
{
cleanup: Stop using g_get_current_time () It has been deprecated because it isn't Y2k38 ready, so replace it with g_get_real_time () which is. https://gitlab.gnome.org/GNOME/mutter/merge_requests/708
2019-07-31 22:21:03 +00:00
int64_t current_time;
Make handling of windows that don't respond to _NET_WM_SYNC_REQUEST reliable Previously, we were handling failure to respond to _NET_WM_SYNC_REQUEST in the code path for throttling motion events. But this meant that if a window didn't respond to _NET_WM_SYNC_REQUEST and there were no motion events - for a keyboard resize, or after the end of the grab operation - it would end up in a stuck state. Use a separate per-window timeout to reliably catch the failure to respond to _NET_WM_SYNC_REQUEST. https://bugzilla.gnome.org/show_bug.cgi?id=694046
2013-03-13 19:31:11 +00:00
const double max_resizes_per_second = 25.0;
const double ms_between_resizes = 1000.0 / max_resizes_per_second;
double elapsed;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
cleanup: Stop using g_get_current_time () It has been deprecated because it isn't Y2k38 ready, so replace it with g_get_real_time () which is. https://gitlab.gnome.org/GNOME/mutter/merge_requests/708
2019-07-31 22:21:03 +00:00
current_time = g_get_real_time ();
track time to avoid sending a deluge of move/resize requests, suggestion 2002-08-10 Havoc Pennington <hp@pobox.com> * src/window.c (update_resize): track time to avoid sending a deluge of move/resize requests, suggestion from xavier.bestel@free.fr bug #86830. Not really sure if this will make a difference or not. We'll see I guess. (update_move): do same on move though it seems less important here. * src/display.h (struct _MetaDisplay): store the last time we sent a move/resize event.
2002-08-10 05:27:17 +00:00
Make handling of windows that don't respond to _NET_WM_SYNC_REQUEST reliable Previously, we were handling failure to respond to _NET_WM_SYNC_REQUEST in the code path for throttling motion events. But this meant that if a window didn't respond to _NET_WM_SYNC_REQUEST and there were no motion events - for a keyboard resize, or after the end of the grab operation - it would end up in a stuck state. Use a separate per-window timeout to reliably catch the failure to respond to _NET_WM_SYNC_REQUEST. https://bugzilla.gnome.org/show_bug.cgi?id=694046
2013-03-13 19:31:11 +00:00
/* If we are throttling via _NET_WM_SYNC_REQUEST, we don't need
* an artificial timeout-based throttled */
Fix bug 143333, support for update counter spec, and 109362, schedule Sat Jun 19 02:21:08 2004 Soeren Sandmann <sandmann@daimi.au.dk> Fix bug 143333, support for update counter spec, and 109362, schedule compensation events when events are ignored. * src/display.c (meta_display_open): Add _NET_WM_SYNC_REQUEST and _NET_WM_SYNC_REQUEST_COUNTER atoms. Remove the old METACITY_SYNC_COUNTER stuff. (meta_display_begin_op): Setup the sync counter * src/xprops.c, src/xprops.h, src/window-props.c, src/display.h: Add new atoms. * src/window.c (send_sync_request): new function. (meta_window_move_resize_internal): send a sync request before resizing. (check_move_resize_frequence): Rework logic to also check the SYNC case. If an event is ignored return the remaining time. (update_resize_timeout): Timeout that gets called when a compensation event is scheduled. (uddate_resize): schedule compensation events when an event is ignored. (meta_window_handle_mouse_grap_op_event): When an alarm is received and sync was turned off, turn it back on. * src/window.h (struct MetaWindow) Add some variables
2004-06-19 00:45:24 +00:00
if (!window->disable_sync &&
Move sync alarms to be per-window and permanent Instead of creating a new alarm each time we resize a window interactively, create an alarm the first time we resize a window and keep it around permanently until we unmanage the window. Doing it this way will be useful when we allow the application to spontaneously generate sync request updates to indicate frames it is drawing. https://bugzilla.gnome.org/show_bug.cgi?id=685463
2011-06-08 15:26:03 +00:00
window->sync_request_alarm != None)
Make handling of windows that don't respond to _NET_WM_SYNC_REQUEST reliable Previously, we were handling failure to respond to _NET_WM_SYNC_REQUEST in the code path for throttling motion events. But this meant that if a window didn't respond to _NET_WM_SYNC_REQUEST and there were no motion events - for a keyboard resize, or after the end of the grab operation - it would end up in a stuck state. Use a separate per-window timeout to reliably catch the failure to respond to _NET_WM_SYNC_REQUEST. https://bugzilla.gnome.org/show_bug.cgi?id=694046
2013-03-13 19:31:11 +00:00
return TRUE;
Fix bug 143333, support for update counter spec, and 109362, schedule Sat Jun 19 02:21:08 2004 Soeren Sandmann <sandmann@daimi.au.dk> Fix bug 143333, support for update counter spec, and 109362, schedule compensation events when events are ignored. * src/display.c (meta_display_open): Add _NET_WM_SYNC_REQUEST and _NET_WM_SYNC_REQUEST_COUNTER atoms. Remove the old METACITY_SYNC_COUNTER stuff. (meta_display_begin_op): Setup the sync counter * src/xprops.c, src/xprops.h, src/window-props.c, src/display.h: Add new atoms. * src/window.c (send_sync_request): new function. (meta_window_move_resize_internal): send a sync request before resizing. (check_move_resize_frequence): Rework logic to also check the SYNC case. If an event is ignored return the remaining time. (update_resize_timeout): Timeout that gets called when a compensation event is scheduled. (uddate_resize): schedule compensation events when an event is ignored. (meta_window_handle_mouse_grap_op_event): When an alarm is received and sync was turned off, turn it back on. * src/window.h (struct MetaWindow) Add some variables
2004-06-19 00:45:24 +00:00
cleanup: Stop using g_get_current_time () It has been deprecated because it isn't Y2k38 ready, so replace it with g_get_real_time () which is. https://gitlab.gnome.org/GNOME/mutter/merge_requests/708
2019-07-31 22:21:03 +00:00
elapsed = (current_time - window->display->grab_last_moveresize_time) / 1000;
Fix bug 143333, support for update counter spec, and 109362, schedule Sat Jun 19 02:21:08 2004 Soeren Sandmann <sandmann@daimi.au.dk> Fix bug 143333, support for update counter spec, and 109362, schedule compensation events when events are ignored. * src/display.c (meta_display_open): Add _NET_WM_SYNC_REQUEST and _NET_WM_SYNC_REQUEST_COUNTER atoms. Remove the old METACITY_SYNC_COUNTER stuff. (meta_display_begin_op): Setup the sync counter * src/xprops.c, src/xprops.h, src/window-props.c, src/display.h: Add new atoms. * src/window.c (send_sync_request): new function. (meta_window_move_resize_internal): send a sync request before resizing. (check_move_resize_frequence): Rework logic to also check the SYNC case. If an event is ignored return the remaining time. (update_resize_timeout): Timeout that gets called when a compensation event is scheduled. (uddate_resize): schedule compensation events when an event is ignored. (meta_window_handle_mouse_grap_op_event): When an alarm is received and sync was turned off, turn it back on. * src/window.h (struct MetaWindow) Add some variables
2004-06-19 00:45:24 +00:00
Make handling of windows that don't respond to _NET_WM_SYNC_REQUEST reliable Previously, we were handling failure to respond to _NET_WM_SYNC_REQUEST in the code path for throttling motion events. But this meant that if a window didn't respond to _NET_WM_SYNC_REQUEST and there were no motion events - for a keyboard resize, or after the end of the grab operation - it would end up in a stuck state. Use a separate per-window timeout to reliably catch the failure to respond to _NET_WM_SYNC_REQUEST. https://bugzilla.gnome.org/show_bug.cgi?id=694046
2013-03-13 19:31:11 +00:00
if (elapsed >= 0.0 && elapsed < ms_between_resizes)
{
meta_topic (META_DEBUG_RESIZING,
"Delaying move/resize as only %g of %g ms elapsed\n",
elapsed, ms_between_resizes);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Make handling of windows that don't respond to _NET_WM_SYNC_REQUEST reliable Previously, we were handling failure to respond to _NET_WM_SYNC_REQUEST in the code path for throttling motion events. But this meant that if a window didn't respond to _NET_WM_SYNC_REQUEST and there were no motion events - for a keyboard resize, or after the end of the grab operation - it would end up in a stuck state. Use a separate per-window timeout to reliably catch the failure to respond to _NET_WM_SYNC_REQUEST. https://bugzilla.gnome.org/show_bug.cgi?id=694046
2013-03-13 19:31:11 +00:00
if (remaining)
*remaining = (ms_between_resizes - elapsed);
Fix bug 143333, support for update counter spec, and 109362, schedule Sat Jun 19 02:21:08 2004 Soeren Sandmann <sandmann@daimi.au.dk> Fix bug 143333, support for update counter spec, and 109362, schedule compensation events when events are ignored. * src/display.c (meta_display_open): Add _NET_WM_SYNC_REQUEST and _NET_WM_SYNC_REQUEST_COUNTER atoms. Remove the old METACITY_SYNC_COUNTER stuff. (meta_display_begin_op): Setup the sync counter * src/xprops.c, src/xprops.h, src/window-props.c, src/display.h: Add new atoms. * src/window.c (send_sync_request): new function. (meta_window_move_resize_internal): send a sync request before resizing. (check_move_resize_frequence): Rework logic to also check the SYNC case. If an event is ignored return the remaining time. (update_resize_timeout): Timeout that gets called when a compensation event is scheduled. (uddate_resize): schedule compensation events when an event is ignored. (meta_window_handle_mouse_grap_op_event): When an alarm is received and sync was turned off, turn it back on. * src/window.h (struct MetaWindow) Add some variables
2004-06-19 00:45:24 +00:00
Make handling of windows that don't respond to _NET_WM_SYNC_REQUEST reliable Previously, we were handling failure to respond to _NET_WM_SYNC_REQUEST in the code path for throttling motion events. But this meant that if a window didn't respond to _NET_WM_SYNC_REQUEST and there were no motion events - for a keyboard resize, or after the end of the grab operation - it would end up in a stuck state. Use a separate per-window timeout to reliably catch the failure to respond to _NET_WM_SYNC_REQUEST. https://bugzilla.gnome.org/show_bug.cgi?id=694046
2013-03-13 19:31:11 +00:00
return FALSE;
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Make handling of windows that don't respond to _NET_WM_SYNC_REQUEST reliable Previously, we were handling failure to respond to _NET_WM_SYNC_REQUEST in the code path for throttling motion events. But this meant that if a window didn't respond to _NET_WM_SYNC_REQUEST and there were no motion events - for a keyboard resize, or after the end of the grab operation - it would end up in a stuck state. Use a separate per-window timeout to reliably catch the failure to respond to _NET_WM_SYNC_REQUEST. https://bugzilla.gnome.org/show_bug.cgi?id=694046
2013-03-13 19:31:11 +00:00
meta_topic (META_DEBUG_RESIZING,
" Checked moveresize freq, allowing move/resize now (%g of %g seconds elapsed)\n",
elapsed / 1000.0, 1.0 / max_resizes_per_second);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Make handling of windows that don't respond to _NET_WM_SYNC_REQUEST reliable Previously, we were handling failure to respond to _NET_WM_SYNC_REQUEST in the code path for throttling motion events. But this meant that if a window didn't respond to _NET_WM_SYNC_REQUEST and there were no motion events - for a keyboard resize, or after the end of the grab operation - it would end up in a stuck state. Use a separate per-window timeout to reliably catch the failure to respond to _NET_WM_SYNC_REQUEST. https://bugzilla.gnome.org/show_bug.cgi?id=694046
2013-03-13 19:31:11 +00:00
return TRUE;
track time to avoid sending a deluge of move/resize requests, suggestion 2002-08-10 Havoc Pennington <hp@pobox.com> * src/window.c (update_resize): track time to avoid sending a deluge of move/resize requests, suggestion from xavier.bestel@free.fr bug #86830. Not really sure if this will make a difference or not. We'll see I guess. (update_move): do same on move though it seems less important here. * src/display.h (struct _MetaDisplay): store the last time we sent a move/resize event.
2002-08-10 05:27:17 +00:00
}
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
static gboolean
update_move_timeout (gpointer data)
{
MetaWindow *window = data;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
update_move (window,
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
window->display->grab_last_user_action_was_snap,
window->display->grab_latest_motion_x,
window->display->grab_latest_motion_y);
return FALSE;
}
window: Don't crash when moving across non-adjecent logical monitors When moving a window between two non-adjecent logical monitors, don't try to tile a window when the window position is outside of any logical monitor. https://bugzilla.gnome.org/show_bug.cgi?id=783630
2017-06-13 04:14:45 +00:00
static void
update_move_maybe_tile (MetaWindow *window,
int shake_threshold,
int x,
int y)
{
MetaBackend *backend = meta_get_backend ();
MetaMonitorManager *monitor_manager =
meta_backend_get_monitor_manager (backend);
MetaLogicalMonitor *logical_monitor;
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
MetaDisplay *display = window->display;
window: Don't crash when moving across non-adjecent logical monitors When moving a window between two non-adjecent logical monitors, don't try to tile a window when the window position is outside of any logical monitor. https://bugzilla.gnome.org/show_bug.cgi?id=783630
2017-06-13 04:14:45 +00:00
MetaRectangle work_area;
/* For side-by-side tiling we are interested in the inside vertical
* edges of the work area of the monitor where the pointer is located,
* and in the outside top edge for maximized tiling.
*
* For maximized tiling we use the outside edge instead of the
* inside edge, because we don't want to force users to maximize
* windows they are placing near the top of their screens.
*
* The "current" idea of meta_window_get_work_area_current_monitor() and
* meta_screen_get_current_monitor() is slightly different: the former
* refers to the monitor which contains the largest part of the window,
* the latter to the one where the pointer is located.
*/
logical_monitor =
meta_monitor_manager_get_logical_monitor_at (monitor_manager, x, y);
if (!logical_monitor)
return;
meta_window_get_work_area_for_monitor (window,
logical_monitor->number,
&work_area);
/* Check if the cursor is in a position which triggers tiling
* and set tile_mode accordingly.
*/
if (meta_window_can_tile_side_by_side (window) &&
x >= logical_monitor->rect.x && x < (work_area.x + shake_threshold))
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
display->preview_tile_mode = META_TILE_LEFT;
window: Don't crash when moving across non-adjecent logical monitors When moving a window between two non-adjecent logical monitors, don't try to tile a window when the window position is outside of any logical monitor. https://bugzilla.gnome.org/show_bug.cgi?id=783630
2017-06-13 04:14:45 +00:00
else if (meta_window_can_tile_side_by_side (window) &&
x >= work_area.x + work_area.width - shake_threshold &&
x < (logical_monitor->rect.x + logical_monitor->rect.width))
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
display->preview_tile_mode = META_TILE_RIGHT;
window: Don't crash when moving across non-adjecent logical monitors When moving a window between two non-adjecent logical monitors, don't try to tile a window when the window position is outside of any logical monitor. https://bugzilla.gnome.org/show_bug.cgi?id=783630
2017-06-13 04:14:45 +00:00
else if (meta_window_can_tile_maximized (window) &&
y >= logical_monitor->rect.y && y <= work_area.y)
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
display->preview_tile_mode = META_TILE_MAXIMIZED;
window: Don't crash when moving across non-adjecent logical monitors When moving a window between two non-adjecent logical monitors, don't try to tile a window when the window position is outside of any logical monitor. https://bugzilla.gnome.org/show_bug.cgi?id=783630
2017-06-13 04:14:45 +00:00
else
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
display->preview_tile_mode = META_TILE_NONE;
window: Don't crash when moving across non-adjecent logical monitors When moving a window between two non-adjecent logical monitors, don't try to tile a window when the window position is outside of any logical monitor. https://bugzilla.gnome.org/show_bug.cgi?id=783630
2017-06-13 04:14:45 +00:00
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
if (display->preview_tile_mode != META_TILE_NONE)
window: Don't crash when moving across non-adjecent logical monitors When moving a window between two non-adjecent logical monitors, don't try to tile a window when the window position is outside of any logical monitor. https://bugzilla.gnome.org/show_bug.cgi?id=783630
2017-06-13 04:14:45 +00:00
window->tile_monitor_number = logical_monitor->number;
}
track time to avoid sending a deluge of move/resize requests, suggestion 2002-08-10 Havoc Pennington <hp@pobox.com> * src/window.c (update_resize): track time to avoid sending a deluge of move/resize requests, suggestion from xavier.bestel@free.fr bug #86830. Not really sure if this will make a difference or not. We'll see I guess. (update_move): do same on move though it seems less important here. * src/display.h (struct _MetaDisplay): store the last time we sent a move/resize event.
2002-08-10 05:27:17 +00:00
static void
...
2001-07-26 02:55:35 +00:00
update_move (MetaWindow *window,
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
gboolean snap,
...
2001-07-26 02:55:35 +00:00
int x,
int y)
{
int dx, dy;
...
2001-07-26 03:58:24 +00:00
int new_x, new_y;
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
MetaRectangle old;
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
int shake_threshold;
Call meta_compositor_begin_move if there is a compositor Sat Feb 25 11:46:14 2006 Søren Sandmann <sandmann@redhat.com> * src/display.c (meta_display_begin_grab_op): Call meta_compositor_begin_move if there is a compositor * src/compositor.c (meta_compositor_begin/update/end_move): Implement those functions. * src/spring-model.[ch]: New files
2006-02-25 16:54:39 +00:00
MetaDisplay *display = window->display;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Call meta_compositor_begin_move if there is a compositor Sat Feb 25 11:46:14 2006 Søren Sandmann <sandmann@redhat.com> * src/display.c (meta_display_begin_grab_op): Call meta_compositor_begin_move if there is a compositor * src/compositor.c (meta_compositor_begin/update/end_move): Implement those functions. * src/spring-model.[ch]: New files
2006-02-25 16:54:39 +00:00
display->grab_latest_motion_x = x;
display->grab_latest_motion_y = y;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Call meta_compositor_begin_move if there is a compositor Sat Feb 25 11:46:14 2006 Søren Sandmann <sandmann@redhat.com> * src/display.c (meta_display_begin_grab_op): Call meta_compositor_begin_move if there is a compositor * src/compositor.c (meta_compositor_begin/update/end_move): Implement those functions. * src/spring-model.[ch]: New files
2006-02-25 16:54:39 +00:00
dx = x - display->grab_anchor_root_x;
dy = y - display->grab_anchor_root_y;
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
Call meta_compositor_begin_move if there is a compositor Sat Feb 25 11:46:14 2006 Søren Sandmann <sandmann@redhat.com> * src/display.c (meta_display_begin_grab_op): Call meta_compositor_begin_move if there is a compositor * src/compositor.c (meta_compositor_begin/update/end_move): Implement those functions. * src/spring-model.[ch]: New files
2006-02-25 16:54:39 +00:00
new_x = display->grab_anchor_window_pos.x + dx;
new_y = display->grab_anchor_window_pos.y + dy;
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
meta_verbose ("x,y = %d,%d anchor ptr %d,%d anchor pos %d,%d dx,dy %d,%d\n",
x, y,
Call meta_compositor_begin_move if there is a compositor Sat Feb 25 11:46:14 2006 Søren Sandmann <sandmann@redhat.com> * src/display.c (meta_display_begin_grab_op): Call meta_compositor_begin_move if there is a compositor * src/compositor.c (meta_compositor_begin/update/end_move): Implement those functions. * src/spring-model.[ch]: New files
2006-02-25 16:54:39 +00:00
display->grab_anchor_root_x,
display->grab_anchor_root_y,
display->grab_anchor_window_pos.x,
display->grab_anchor_window_pos.y,
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
dx, dy);
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
/* Don't bother doing anything if no move has been specified. (This
* happens often, even in keyboard moving, due to the warping of the
* pointer.
*/
if (dx == 0 && dy == 0)
return;
Revert "window: Add new tiling code" This reverts commit 50e3e3b929f181bc64549a05ab2abf4258a9673e.
2016-01-10 14:16:08 +00:00
/* Originally for detaching maximized windows, but we use this
* for the zones at the sides of the monitor where trigger tiling
* because it's about the right size
*/
#define DRAG_THRESHOLD_TO_SHAKE_THRESHOLD_FACTOR 6
shake_threshold = meta_prefs_get_drag_threshold () *
DRAG_THRESHOLD_TO_SHAKE_THRESHOLD_FACTOR;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
if (snap)
{
/* We don't want to tile while snapping. Also, clear any previous tile
request. */
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
display->preview_tile_mode = META_TILE_NONE;
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
window->tile_monitor_number = -1;
}
else if (meta_prefs_get_edge_tiling () &&
!META_WINDOW_MAXIMIZED (window) &&
!META_WINDOW_TILED_SIDE_BY_SIDE (window))
{
window: Don't crash when moving across non-adjecent logical monitors When moving a window between two non-adjecent logical monitors, don't try to tile a window when the window position is outside of any logical monitor. https://bugzilla.gnome.org/show_bug.cgi?id=783630
2017-06-13 04:14:45 +00:00
update_move_maybe_tile (window, shake_threshold, x, y);
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
}
Implement side-by-side tiling When dragging a window over a screen edge and dropping it there, maximize it vertically and scale it horizontally to cover the corresponding half of the current monitor. Whenever a "hot area" which triggers this behavior is entered, an indication of window's target size is displayed after a short delay to avoid distraction when moving a window between monitors. https://bugzilla.gnome.org/show_bug.cgi?id=606260
2010-06-24 18:41:28 +00:00
/* shake loose (unmaximize) maximized or tiled window if dragged beyond
* the threshold in the Y direction. Tiled windows can also be pulled
* loose via X motion.
*/
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
if ((META_WINDOW_MAXIMIZED (window) && ABS (dy) >= shake_threshold) ||
(META_WINDOW_TILED_SIDE_BY_SIDE (window) && (MAX (ABS (dx), ABS (dy)) >= shake_threshold)))
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
{
Update window shaking loose so that the window is moved to the pointer and 2003-07-27 Rob Adams <robadams@ucla.edu> * src/window.c (update_move): Update window shaking loose so that the window is moved to the pointer and certain drag state is properly restored once windows "reattach". Fix for #115000 based on the patch by Jurg Billeter. * src/screen.c (meta_screen_resize): Invalidate work areas after an xrandr screen size update. Fix for #117230. * src/stack.c (window_is_fullscreen_size): Check the bottom corner of the window in addition to the top corner. Fix for #118194. * src/constraints.c (meta_window_constrain): Support aspect ratio hints in the new constraints code. Fix for #113798. * src/tools/metacity-window-demo.c (toggle_aspect_ratio): toggle the aspect ratio hints to force a 16:9 aspect ratio. (do_appwindow): add a button to toggle aspect ratio.
2003-07-28 02:09:20 +00:00
double prop;
tiling: disable "shake loose" feature when edge tiling The old behavior of being able to shake loose a maximized window overlaps with and is for the most part superceded by top edge tiling. This commit changes the code to only enable shake loose behavior when edge tiling is disabled. https://bugzilla.gnome.org/show_bug.cgi?id=630548
2010-12-02 21:43:21 +00:00
/* Shake loose, so that the window snaps back to maximized
* when dragged near the top; do not snap back if tiling
* is enabled, as top edge tiling can be used in that case
*/
window->shaken_loose = !meta_prefs_get_edge_tiling ();
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
window->tile_mode = META_TILE_NONE;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Update window shaking loose so that the window is moved to the pointer and 2003-07-27 Rob Adams <robadams@ucla.edu> * src/window.c (update_move): Update window shaking loose so that the window is moved to the pointer and certain drag state is properly restored once windows "reattach". Fix for #115000 based on the patch by Jurg Billeter. * src/screen.c (meta_screen_resize): Invalidate work areas after an xrandr screen size update. Fix for #117230. * src/stack.c (window_is_fullscreen_size): Check the bottom corner of the window in addition to the top corner. Fix for #118194. * src/constraints.c (meta_window_constrain): Support aspect ratio hints in the new constraints code. Fix for #113798. * src/tools/metacity-window-demo.c (toggle_aspect_ratio): toggle the aspect ratio hints to force a 16:9 aspect ratio. (do_appwindow): add a button to toggle aspect ratio.
2003-07-28 02:09:20 +00:00
/* move the unmaximized window to the cursor */
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
prop =
((double)(x - display->grab_initial_window_pos.x)) /
Call meta_compositor_begin_move if there is a compositor Sat Feb 25 11:46:14 2006 Søren Sandmann <sandmann@redhat.com> * src/display.c (meta_display_begin_grab_op): Call meta_compositor_begin_move if there is a compositor * src/compositor.c (meta_compositor_begin/update/end_move): Implement those functions. * src/spring-model.[ch]: New files
2006-02-25 16:54:39 +00:00
((double)display->grab_initial_window_pos.width);
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
display->grab_initial_window_pos.x = x - window->saved_rect.width * prop;
reset drag state after shaking loose or reattaching. Fix for #132625. 2004-02-16 Rob Adams <readams@readams.net> * src/window.c (update_move): reset drag state after shaking loose or reattaching. Fix for #132625.
2004-02-16 19:01:25 +00:00
window: Add a hack to correct dragging from the top panel in gnome-shell In gnome-shell, we have a feature where the user can unmaximize windows by dragging them from the panel above the window. With accurate anchoring, this looks really weird as the cursor is now "detached" from the window. Detect this case and put the cursor in the middle of the window titlebar instead.
2014-08-19 17:54:30 +00:00
/* If we started dragging the window from above the top of the window,
* pretend like we started dragging from the middle of the titlebar
* instead, as the "correct" anchoring looks wrong. */
if (display->grab_anchor_root_y < display->grab_initial_window_pos.y)
{
MetaRectangle titlebar_rect;
meta_window_get_titlebar_rect (window, &titlebar_rect);
display->grab_anchor_root_y = display->grab_initial_window_pos.y + titlebar_rect.height / 2;
}
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
window->saved_rect.x = display->grab_initial_window_pos.x;
window->saved_rect.y = display->grab_initial_window_pos.y;
Update window shaking loose so that the window is moved to the pointer and 2003-07-27 Rob Adams <robadams@ucla.edu> * src/window.c (update_move): Update window shaking loose so that the window is moved to the pointer and certain drag state is properly restored once windows "reattach". Fix for #115000 based on the patch by Jurg Billeter. * src/screen.c (meta_screen_resize): Invalidate work areas after an xrandr screen size update. Fix for #117230. * src/stack.c (window_is_fullscreen_size): Check the bottom corner of the window in addition to the top corner. Fix for #118194. * src/constraints.c (meta_window_constrain): Support aspect ratio hints in the new constraints code. Fix for #113798. * src/tools/metacity-window-demo.c (toggle_aspect_ratio): toggle the aspect ratio hints to force a 16:9 aspect ratio. (do_appwindow): add a button to toggle aspect ratio.
2003-07-28 02:09:20 +00:00
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
meta_window_unmaximize (window, META_MAXIMIZE_BOTH);
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
return;
}
Implement side-by-side tiling When dragging a window over a screen edge and dropping it there, maximize it vertically and scale it horizontally to cover the corresponding half of the current monitor. Whenever a "hot area" which triggers this behavior is entered, an indication of window's target size is displayed after a short delay to avoid distraction when moving a window between monitors. https://bugzilla.gnome.org/show_bug.cgi?id=606260
2010-06-24 18:41:28 +00:00
Refer to monitors as "monitors" rather than "xineramas" http://bugzilla.gnome.org/show_bug.cgi?id=593686
2009-08-31 13:52:16 +00:00
/* remaximize window on another monitor if window has been shaken
* loose or it is still maximized (then move straight)
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
*/
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
else if ((window->shaken_loose || META_WINDOW_MAXIMIZED (window)) &&
window->tile_mode != META_TILE_LEFT && window->tile_mode != META_TILE_RIGHT)
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
{
MetaScreen: Remove redundant copy of logical monitors array It was just pointer to the actual list; having to synchronize a list of logical monitors with the actual monitors managed by the backend is unnecessary. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-28 12:11:24 +00:00
MetaBackend *backend = meta_get_backend ();
MetaMonitorManager *monitor_manager =
meta_backend_get_monitor_manager (backend);
int n_logical_monitors;
Rename MetaMonitorInfo MetaLogicalMonitor In preparation for further refactorizations, rename the MetaMonitorInfo struct to MetaLogicalMonitor. Eventually, part of MetaLogicalMonitor will be split into a MetaMonitor type. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-25 06:31:38 +00:00
const MetaLogicalMonitor *wmonitor;
Update window shaking loose so that the window is moved to the pointer and 2003-07-27 Rob Adams <robadams@ucla.edu> * src/window.c (update_move): Update window shaking loose so that the window is moved to the pointer and certain drag state is properly restored once windows "reattach". Fix for #115000 based on the patch by Jurg Billeter. * src/screen.c (meta_screen_resize): Invalidate work areas after an xrandr screen size update. Fix for #117230. * src/stack.c (window_is_fullscreen_size): Check the bottom corner of the window in addition to the top corner. Fix for #118194. * src/constraints.c (meta_window_constrain): Support aspect ratio hints in the new constraints code. Fix for #113798. * src/tools/metacity-window-demo.c (toggle_aspect_ratio): toggle the aspect ratio hints to force a 16:9 aspect ratio. (do_appwindow): add a button to toggle aspect ratio.
2003-07-28 02:09:20 +00:00
MetaRectangle work_area;
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
int monitor;
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
window->tile_mode = META_TILE_NONE;
Don't calculate the main window monitor every time it`s needed The main monitor of a window is maintained as 'window->monitor' and is updated when the window is resized or moved. Lets avoid calculating it every time it`s needed. https://bugzilla.gnome.org/show_bug.cgi?id=744934
2015-04-09 04:20:24 +00:00
wmonitor = window->monitor;
MetaScreen: Remove redundant copy of logical monitors array It was just pointer to the actual list; having to synchronize a list of logical monitors with the actual monitors managed by the backend is unnecessary. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-28 12:11:24 +00:00
n_logical_monitors =
meta_monitor_manager_get_num_logical_monitors (monitor_manager);
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
MetaScreen: Remove redundant copy of logical monitors array It was just pointer to the actual list; having to synchronize a list of logical monitors with the actual monitors managed by the backend is unnecessary. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-28 12:11:24 +00:00
for (monitor = 0; monitor < n_logical_monitors; monitor++)
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
{
Refer to monitors as "monitors" rather than "xineramas" http://bugzilla.gnome.org/show_bug.cgi?id=593686
2009-08-31 13:52:16 +00:00
meta_window_get_work_area_for_monitor (window, monitor, &work_area);
Update window shaking loose so that the window is moved to the pointer and 2003-07-27 Rob Adams <robadams@ucla.edu> * src/window.c (update_move): Update window shaking loose so that the window is moved to the pointer and certain drag state is properly restored once windows "reattach". Fix for #115000 based on the patch by Jurg Billeter. * src/screen.c (meta_screen_resize): Invalidate work areas after an xrandr screen size update. Fix for #117230. * src/stack.c (window_is_fullscreen_size): Check the bottom corner of the window in addition to the top corner. Fix for #118194. * src/constraints.c (meta_window_constrain): Support aspect ratio hints in the new constraints code. Fix for #113798. * src/tools/metacity-window-demo.c (toggle_aspect_ratio): toggle the aspect ratio hints to force a 16:9 aspect ratio. (do_appwindow): add a button to toggle aspect ratio.
2003-07-28 02:09:20 +00:00
Refer to monitors as "monitors" rather than "xineramas" http://bugzilla.gnome.org/show_bug.cgi?id=593686
2009-08-31 13:52:16 +00:00
/* check if cursor is near the top of a monitor work area */
Update window shaking loose so that the window is moved to the pointer and 2003-07-27 Rob Adams <robadams@ucla.edu> * src/window.c (update_move): Update window shaking loose so that the window is moved to the pointer and certain drag state is properly restored once windows "reattach". Fix for #115000 based on the patch by Jurg Billeter. * src/screen.c (meta_screen_resize): Invalidate work areas after an xrandr screen size update. Fix for #117230. * src/stack.c (window_is_fullscreen_size): Check the bottom corner of the window in addition to the top corner. Fix for #118194. * src/constraints.c (meta_window_constrain): Support aspect ratio hints in the new constraints code. Fix for #113798. * src/tools/metacity-window-demo.c (toggle_aspect_ratio): toggle the aspect ratio hints to force a 16:9 aspect ratio. (do_appwindow): add a button to toggle aspect ratio.
2003-07-28 02:09:20 +00:00
if (x >= work_area.x &&
x < (work_area.x + work_area.width) &&
reset drag state after shaking loose or reattaching. Fix for #132625. 2004-02-16 Rob Adams <readams@readams.net> * src/window.c (update_move): reset drag state after shaking loose or reattaching. Fix for #132625.
2004-02-16 19:01:25 +00:00
y >= work_area.y &&
y < (work_area.y + shake_threshold))
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
{
/* move the saved rect if window will become maximized on an
* other monitor so user isn't surprised on a later unmaximize
*/
Refer to monitors as "monitors" rather than "xineramas" http://bugzilla.gnome.org/show_bug.cgi?id=593686
2009-08-31 13:52:16 +00:00
if (wmonitor->number != monitor)
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
{
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
window->saved_rect.x = work_area.x;
window->saved_rect.y = work_area.y;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
if (window->frame)
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
{
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
window->saved_rect.x += window->frame->child_x;
window->saved_rect.y += window->frame->child_y;
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
}
Revert "Add "size states" which save window size information" This reverts commit 2c7ef2269fc19eaef1769632a2b92f06119cc413.
2016-01-10 14:16:09 +00:00
window->unconstrained_rect.x = window->saved_rect.x;
window->unconstrained_rect.y = window->saved_rect.y;
Fix flickering about when dragging maximised windows between xineramas. 2006-12-05 Christof Krüger <mail@pop2wap.net> * src/window.c (update_move): Fix flickering about when dragging maximised windows between xineramas. Closes #358715.
2006-12-06 01:26:30 +00:00
Add a META_MAXIMIZE_BOTH Which has the value of META_MAXIMIZE_VERTICAL | META_MAXIMIZE_HORIZONTAL. This is an obvious code cleanup.
2014-03-13 22:32:20 +00:00
meta_window_unmaximize (window, META_MAXIMIZE_BOTH);
...
2001-07-26 02:55:35 +00:00
window: Fix cursor anchoring issues when drag-unmaximizing windows The cursor was anchored wrongly when trying to unmaximize windows from dragging them from the top of the screen because of a few think-o's and some code that forgot to be updated when we moved to the frame rect coordinate system. The cursor is still offset for windows that start dragging from the top panel. This is technically correct, but looks wrong. We'll fix this in the next commit.
2014-08-19 17:48:00 +00:00
display->grab_initial_window_pos = work_area;
display->grab_anchor_root_x = x;
display->grab_anchor_root_y = y;
window->shaken_loose = FALSE;
meta_window_maximize (window, META_MAXIMIZE_BOTH);
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
reset drag state after shaking loose or reattaching. Fix for #132625. 2004-02-16 Rob Adams <readams@readams.net> * src/window.c (update_move): reset drag state after shaking loose or reattaching. Fix for #132625.
2004-02-16 19:01:25 +00:00
return;
make raise-on-click explicitly only happen in click to focus mode. 2003-06-12 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make raise-on-click explicitly only happen in click to focus mode. * src/window.c (update_move): apply patch from Jurg Billeter to allow you to "shake loose" maximized windows and move them between Xinerama heads. #93586 * src/display.c: delete event_queue_callback * src/display.h (struct _MetaDisplay): get rid of grab_current_window_pos and grab_current_root_[xy] as I could find absolutely no code using them for anything. They were just sort of randomly assigned to for no apparent reason. * src/display.c (event_callback): double-click timeout is per screen, so get the screen and pass screen->ui to meta_ui_get_double_click_timeout() * src/ui.c (meta_ui_get_double_click_timeout): take a MetaUI argument so we get the right settings for each screen (meta_ui_get_drag_threshold): new function
2003-06-12 05:55:06 +00:00
}
}
}
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
/* Delay showing the tile preview slightly to make it more unlikely to
* trigger it unwittingly, e.g. when shaking loose the window or moving
* it to another monitor.
*/
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
meta_display_update_tile_preview (window->display,
window->tile_mode != META_TILE_NONE);
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
window: Remove meta_window_move as well Move to meta_window_move_frame everywhere...
2014-05-21 12:46:18 +00:00
meta_window_get_frame_rect (window, &old);
Improve the behavior of keyboard move/resize and edge snapping. Still not 2005-08-03 Ray Strode <rstrode@redhat.com> Improve the behavior of keyboard move/resize and edge snapping. Still not perfect, bug 310888. * src/effects.c (draw_xor_rect): Make the outside of a wireframe rectangle line up with the outside edge of its window, instead of centering the wireframe edges on the window edges. * src/keybindings.c (process_keyboard_move_grab): allow edge snapping in wireframe mode. Adjust code to take into account changed semantics of find_next_*_edge functions. (process_keyboard_resize_grab_op_change): new function to take some orthogonal logic out of process_keyboard_resize_grab_op. Only allow keyboard resize cursor to go to flat edges, not corners. (process_keyboard_resize_grab): allow edge snapping in wireframe mode. Fix up snapping logic. * src/place.c (get_{vertical,horizontal}_edges): use GArray instead of int *, since the number of output edges isn't known until the middle of the function now. Use xor rect extents instead of window extends if in wireframe mode. (meta_window_find_next_{vertical,horizontal}_edge: add new source_edge_position parameter to specify which edge on the active window to start from when looking for next edge on the screen. Return the coordinate of the edge found and not the coordinate of where the window should be moved to snap to where the edge was found. * src/window.c (update_move): all the user to specify an edge to resize with mouse in keyboard resize mode. window
2005-08-03 02:22:00 +00:00
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
/* Don't allow movement in the maximized directions or while tiled */
if (window->maximized_horizontally || META_WINDOW_TILED_SIDE_BY_SIDE (window))
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
new_x = old.x;
if (window->maximized_vertically)
new_y = old.y;
/* Do any edge resistance/snapping */
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
meta_window_edge_resistance_for_move (window,
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
&new_x,
&new_y,
update_move_timeout,
snap,
FALSE);
window: Remove meta_window_move as well Move to meta_window_move_frame everywhere...
2014-05-21 12:46:18 +00:00
meta_window_move_frame (window, TRUE, new_x, new_y);
...
2001-07-26 02:55:35 +00:00
}
Fix bug 143333, support for update counter spec, and 109362, schedule Sat Jun 19 02:21:08 2004 Soeren Sandmann <sandmann@daimi.au.dk> Fix bug 143333, support for update counter spec, and 109362, schedule compensation events when events are ignored. * src/display.c (meta_display_open): Add _NET_WM_SYNC_REQUEST and _NET_WM_SYNC_REQUEST_COUNTER atoms. Remove the old METACITY_SYNC_COUNTER stuff. (meta_display_begin_op): Setup the sync counter * src/xprops.c, src/xprops.h, src/window-props.c, src/display.h: Add new atoms. * src/window.c (send_sync_request): new function. (meta_window_move_resize_internal): send a sync request before resizing. (check_move_resize_frequence): Rework logic to also check the SYNC case. If an event is ignored return the remaining time. (update_resize_timeout): Timeout that gets called when a compensation event is scheduled. (uddate_resize): schedule compensation events when an event is ignored. (meta_window_handle_mouse_grap_op_event): When an alarm is received and sync was turned off, turn it back on. * src/window.h (struct MetaWindow) Add some variables
2004-06-19 00:45:24 +00:00
static gboolean
update_resize_timeout (gpointer data)
{
MetaWindow *window = data;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
update_resize (window,
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
window->display->grab_last_user_action_was_snap,
window->display->grab_latest_motion_x,
window->display->grab_latest_motion_y,
TRUE);
Fix bug 143333, support for update counter spec, and 109362, schedule Sat Jun 19 02:21:08 2004 Soeren Sandmann <sandmann@daimi.au.dk> Fix bug 143333, support for update counter spec, and 109362, schedule compensation events when events are ignored. * src/display.c (meta_display_open): Add _NET_WM_SYNC_REQUEST and _NET_WM_SYNC_REQUEST_COUNTER atoms. Remove the old METACITY_SYNC_COUNTER stuff. (meta_display_begin_op): Setup the sync counter * src/xprops.c, src/xprops.h, src/window-props.c, src/display.h: Add new atoms. * src/window.c (send_sync_request): new function. (meta_window_move_resize_internal): send a sync request before resizing. (check_move_resize_frequence): Rework logic to also check the SYNC case. If an event is ignored return the remaining time. (update_resize_timeout): Timeout that gets called when a compensation event is scheduled. (uddate_resize): schedule compensation events when an event is ignored. (meta_window_handle_mouse_grap_op_event): When an alarm is received and sync was turned off, turn it back on. * src/window.h (struct MetaWindow) Add some variables
2004-06-19 00:45:24 +00:00
return FALSE;
}
...
2001-07-26 02:55:35 +00:00
static void
update_resize (MetaWindow *window,
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
gboolean snap,
Fix bug 143333, support for update counter spec, and 109362, schedule Sat Jun 19 02:21:08 2004 Soeren Sandmann <sandmann@daimi.au.dk> Fix bug 143333, support for update counter spec, and 109362, schedule compensation events when events are ignored. * src/display.c (meta_display_open): Add _NET_WM_SYNC_REQUEST and _NET_WM_SYNC_REQUEST_COUNTER atoms. Remove the old METACITY_SYNC_COUNTER stuff. (meta_display_begin_op): Setup the sync counter * src/xprops.c, src/xprops.h, src/window-props.c, src/display.h: Add new atoms. * src/window.c (send_sync_request): new function. (meta_window_move_resize_internal): send a sync request before resizing. (check_move_resize_frequence): Rework logic to also check the SYNC case. If an event is ignored return the remaining time. (update_resize_timeout): Timeout that gets called when a compensation event is scheduled. (uddate_resize): schedule compensation events when an event is ignored. (meta_window_handle_mouse_grap_op_event): When an alarm is received and sync was turned off, turn it back on. * src/window.h (struct MetaWindow) Add some variables
2004-06-19 00:45:24 +00:00
int x, int y,
Partial audit to fix timestamp usage. One step towards fixing #355180; see 2006-09-18 Elijah Newren <newren gmail com> Partial audit to fix timestamp usage. One step towards fixing #355180; see important comments in that bug. * src/core.[ch] (meta_core_unshade, meta_core_shade): * src/delete.c (meta_window_present_delete_dialog, delete_ping_timeout_func): * src/display.[ch] (meta_display_open, meta_display_close, event_callback, meta_display_begin_grab_op, process_selection_clear, meta_display_unmanage_screen, meta_display_unmanage_windows_for_screen): * src/frames.c (meta_frames_button_press_event): * src/keybindings.c (handle_toggle_shade): * src/main.c (main): * src/screen.[ch] (update_num_workspaces, meta_screen_new, meta_screen_free, prefs_changed_callback): * src/window.[ch] (meta_window_free, finish_minimize, implement_showing, meta_window_show, meta_window_maximize, meta_window_make_fullscreen_internal, meta_window_unmake_fullscreen, meta_window_shade, meta_window_unshade, window_activate, send_sync_request, meta_window_client_message, menu_callback, meta_window_update_keyboard_resize): Remove usage of CurrentTime, meta_display_get_current_time() and meta_display_get_current_time_roundtrip() where possible, or document why it isn't possible, or at very least add a FIXME with some explanation of my laziness and what needs to be done.
2006-09-18 17:27:24 +00:00
gboolean force)
...
2001-07-26 02:55:35 +00:00
{
int dx, dy;
int new_w, new_h;
int gravity;
add myself here, bug #100789 2002-12-09 Havoc Pennington <hp@pobox.com> * AUTHORS: add myself here, bug #100789 * src/display.c (meta_display_set_grab_op_cursor): drop PointerMotionHintMask * src/window.c (meta_window_handle_mouse_grab_op_event): don't use XQueryPointer, as we aren't using PointerMotionHint now * src/display.c (event_callback): rearrange a bit of code for slight speedup and clarity * src/window.c (update_resize) (meta_window_handle_mouse_grab_op_event): implement usage of the _METACITY_UPDATE_COUNTER (meta_window_handle_mouse_grab_op_event): fix code that used event->xbutton with a motion event * src/display.c (meta_display_open): add new atoms, and initialize Xsync if we have it (grab_op_is_resizing): new function (meta_display_begin_grab_op): create an alarm monitoring window's _METACITY_UPDATE_COUNTER (meta_spew_event): conditionalize this on WITH_VERBOSE_MODE and print alarm events. * src/window.c (meta_window_new): fetch _METACITY_UPDATE_COUNTER * configure.in (HAVE_XSYNC): check for Xsync extension
2002-12-10 03:23:04 +00:00
MetaRectangle old;
window: Placate new gcc It thinks remaining can be used uninitialized. It's wrong, but let's help it out by initializing the variable.
2014-10-23 23:03:46 +00:00
double remaining = 0;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
add myself here, bug #100789 2002-12-09 Havoc Pennington <hp@pobox.com> * AUTHORS: add myself here, bug #100789 * src/display.c (meta_display_set_grab_op_cursor): drop PointerMotionHintMask * src/window.c (meta_window_handle_mouse_grab_op_event): don't use XQueryPointer, as we aren't using PointerMotionHint now * src/display.c (event_callback): rearrange a bit of code for slight speedup and clarity * src/window.c (update_resize) (meta_window_handle_mouse_grab_op_event): implement usage of the _METACITY_UPDATE_COUNTER (meta_window_handle_mouse_grab_op_event): fix code that used event->xbutton with a motion event * src/display.c (meta_display_open): add new atoms, and initialize Xsync if we have it (grab_op_is_resizing): new function (meta_display_begin_grab_op): create an alarm monitoring window's _METACITY_UPDATE_COUNTER (meta_spew_event): conditionalize this on WITH_VERBOSE_MODE and print alarm events. * src/window.c (meta_window_new): fetch _METACITY_UPDATE_COUNTER * configure.in (HAVE_XSYNC): check for Xsync extension
2002-12-10 03:23:04 +00:00
window->display->grab_latest_motion_x = x;
window->display->grab_latest_motion_y = y;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
dx = x - window->display->grab_anchor_root_x;
dy = y - window->display->grab_anchor_root_y;
...
2001-07-26 02:55:35 +00:00
constraints: Center modal dialogs on their parent ... rather than attaching them to the parent's title bar. https://bugzilla.gnome.org/show_bug.cgi?id=674499
2012-07-03 20:30:02 +00:00
/* Attached modal dialogs are special in that size
* changes apply to both sides, so that the dialog
window: Allow resizing of attached modal dialogs Currently attached modal dialogs are not resizable, but we don't communicate this to GTK+, so the dialog may end up with resize grips anyway. As a fix, allow resizing, but account for the dialog being centered to its parent. https://bugzilla.gnome.org/show_bug.cgi?id=643597
2011-03-21 17:23:53 +00:00
* remains centered to the parent.
*/
window: make determination of attached dialog windows more consistent Different bits of code were using slightly different checks to test whether a window was an attached dialog. Add a new meta_window_is_attached_dialog(), and use that everywhere. Also, freeze the is-attached status when the window is first shown, rather than recomputing it each time the caller asks, since this could cause problems if a window changes its type after it has already been attached, etc. However, if an attached window's parent is destroyed, or an attached window changes its transient-for, then fix things up by destroying the old MetaWindow and creating a new one (causing compositor unmap and map events to be fired off, allowing the display of the window to be fixed up). Remove some code in display.c that tried to fix existing windows if the gconf setting changed, but which didn't actually do anything (at least under gnome-shell). However, if 654643 was fixed then the new behavior with this patch would be that changing the gconf setting would affect new dialogs, but not existing ones. https://bugzilla.gnome.org/show_bug.cgi?id=646761
2011-04-05 14:14:52 +00:00
if (meta_window_is_attached_dialog (window))
constraints: Center modal dialogs on their parent ... rather than attaching them to the parent's title bar. https://bugzilla.gnome.org/show_bug.cgi?id=674499
2012-07-03 20:30:02 +00:00
{
dx *= 2;
dy *= 2;
}
window: Allow resizing of attached modal dialogs Currently attached modal dialogs are not resizable, but we don't communicate this to GTK+, so the dialog may end up with resize grips anyway. As a fix, allow resizing, but account for the dialog being centered to its parent. https://bugzilla.gnome.org/show_bug.cgi?id=643597
2011-03-21 17:23:53 +00:00
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
new_w = window->display->grab_anchor_window_pos.width;
new_h = window->display->grab_anchor_window_pos.height;
...
2001-07-26 02:55:35 +00:00
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
/* Don't bother doing anything if no move has been specified. (This
* happens often, even in keyboard resizing, due to the warping of the
* pointer.
*/
if (dx == 0 && dy == 0)
return;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Improve the behavior of keyboard move/resize and edge snapping. Still not 2005-08-03 Ray Strode <rstrode@redhat.com> Improve the behavior of keyboard move/resize and edge snapping. Still not perfect, bug 310888. * src/effects.c (draw_xor_rect): Make the outside of a wireframe rectangle line up with the outside edge of its window, instead of centering the wireframe edges on the window edges. * src/keybindings.c (process_keyboard_move_grab): allow edge snapping in wireframe mode. Adjust code to take into account changed semantics of find_next_*_edge functions. (process_keyboard_resize_grab_op_change): new function to take some orthogonal logic out of process_keyboard_resize_grab_op. Only allow keyboard resize cursor to go to flat edges, not corners. (process_keyboard_resize_grab): allow edge snapping in wireframe mode. Fix up snapping logic. * src/place.c (get_{vertical,horizontal}_edges): use GArray instead of int *, since the number of output edges isn't known until the middle of the function now. Use xor rect extents instead of window extends if in wireframe mode. (meta_window_find_next_{vertical,horizontal}_edge: add new source_edge_position parameter to specify which edge on the active window to start from when looking for next edge on the screen. Return the coordinate of the edge found and not the coordinate of where the window should be moved to snap to where the edge was found. * src/window.c (update_move): all the user to specify an edge to resize with mouse in keyboard resize mode. window
2005-08-03 02:22:00 +00:00
if (window->display->grab_op == META_GRAB_OP_KEYBOARD_RESIZING_UNKNOWN)
{
common: Create a better encoding for MetaGrabOp MetaGrabOp is painful and tedious to work with, because it's a sequential series of values, meaning we have to use a giant unreadable switch statement to figure out some basic things about the value. To solve this, modify the encoding for MetaGrabOp and for the specific window grab operations so that they're a set of bitflags that we can easily check.
2014-08-15 18:05:04 +00:00
MetaGrabOp op = META_GRAB_OP_WINDOW_BASE | META_GRAB_OP_WINDOW_FLAG_KEYBOARD;
if (dx > 0)
op |= META_GRAB_OP_WINDOW_DIR_EAST;
Improve the behavior of keyboard move/resize and edge snapping. Still not 2005-08-03 Ray Strode <rstrode@redhat.com> Improve the behavior of keyboard move/resize and edge snapping. Still not perfect, bug 310888. * src/effects.c (draw_xor_rect): Make the outside of a wireframe rectangle line up with the outside edge of its window, instead of centering the wireframe edges on the window edges. * src/keybindings.c (process_keyboard_move_grab): allow edge snapping in wireframe mode. Adjust code to take into account changed semantics of find_next_*_edge functions. (process_keyboard_resize_grab_op_change): new function to take some orthogonal logic out of process_keyboard_resize_grab_op. Only allow keyboard resize cursor to go to flat edges, not corners. (process_keyboard_resize_grab): allow edge snapping in wireframe mode. Fix up snapping logic. * src/place.c (get_{vertical,horizontal}_edges): use GArray instead of int *, since the number of output edges isn't known until the middle of the function now. Use xor rect extents instead of window extends if in wireframe mode. (meta_window_find_next_{vertical,horizontal}_edge: add new source_edge_position parameter to specify which edge on the active window to start from when looking for next edge on the screen. Return the coordinate of the edge found and not the coordinate of where the window should be moved to snap to where the edge was found. * src/window.c (update_move): all the user to specify an edge to resize with mouse in keyboard resize mode. window
2005-08-03 02:22:00 +00:00
else if (dx < 0)
common: Create a better encoding for MetaGrabOp MetaGrabOp is painful and tedious to work with, because it's a sequential series of values, meaning we have to use a giant unreadable switch statement to figure out some basic things about the value. To solve this, modify the encoding for MetaGrabOp and for the specific window grab operations so that they're a set of bitflags that we can easily check.
2014-08-15 18:05:04 +00:00
op |= META_GRAB_OP_WINDOW_DIR_WEST;
if (dy > 0)
op |= META_GRAB_OP_WINDOW_DIR_SOUTH;
Improve the behavior of keyboard move/resize and edge snapping. Still not 2005-08-03 Ray Strode <rstrode@redhat.com> Improve the behavior of keyboard move/resize and edge snapping. Still not perfect, bug 310888. * src/effects.c (draw_xor_rect): Make the outside of a wireframe rectangle line up with the outside edge of its window, instead of centering the wireframe edges on the window edges. * src/keybindings.c (process_keyboard_move_grab): allow edge snapping in wireframe mode. Adjust code to take into account changed semantics of find_next_*_edge functions. (process_keyboard_resize_grab_op_change): new function to take some orthogonal logic out of process_keyboard_resize_grab_op. Only allow keyboard resize cursor to go to flat edges, not corners. (process_keyboard_resize_grab): allow edge snapping in wireframe mode. Fix up snapping logic. * src/place.c (get_{vertical,horizontal}_edges): use GArray instead of int *, since the number of output edges isn't known until the middle of the function now. Use xor rect extents instead of window extends if in wireframe mode. (meta_window_find_next_{vertical,horizontal}_edge: add new source_edge_position parameter to specify which edge on the active window to start from when looking for next edge on the screen. Return the coordinate of the edge found and not the coordinate of where the window should be moved to snap to where the edge was found. * src/window.c (update_move): all the user to specify an edge to resize with mouse in keyboard resize mode. window
2005-08-03 02:22:00 +00:00
else if (dy < 0)
common: Create a better encoding for MetaGrabOp MetaGrabOp is painful and tedious to work with, because it's a sequential series of values, meaning we have to use a giant unreadable switch statement to figure out some basic things about the value. To solve this, modify the encoding for MetaGrabOp and for the specific window grab operations so that they're a set of bitflags that we can easily check.
2014-08-15 18:05:04 +00:00
op |= META_GRAB_OP_WINDOW_DIR_NORTH;
window->display->grab_op = op;
window: Clean up keyboard-resizing code path
2014-07-27 13:03:38 +00:00
meta_window_update_keyboard_resize (window, TRUE);
Improve the behavior of keyboard move/resize and edge snapping. Still not 2005-08-03 Ray Strode <rstrode@redhat.com> Improve the behavior of keyboard move/resize and edge snapping. Still not perfect, bug 310888. * src/effects.c (draw_xor_rect): Make the outside of a wireframe rectangle line up with the outside edge of its window, instead of centering the wireframe edges on the window edges. * src/keybindings.c (process_keyboard_move_grab): allow edge snapping in wireframe mode. Adjust code to take into account changed semantics of find_next_*_edge functions. (process_keyboard_resize_grab_op_change): new function to take some orthogonal logic out of process_keyboard_resize_grab_op. Only allow keyboard resize cursor to go to flat edges, not corners. (process_keyboard_resize_grab): allow edge snapping in wireframe mode. Fix up snapping logic. * src/place.c (get_{vertical,horizontal}_edges): use GArray instead of int *, since the number of output edges isn't known until the middle of the function now. Use xor rect extents instead of window extends if in wireframe mode. (meta_window_find_next_{vertical,horizontal}_edge: add new source_edge_position parameter to specify which edge on the active window to start from when looking for next edge on the screen. Return the coordinate of the edge found and not the coordinate of where the window should be moved to snap to where the edge was found. * src/window.c (update_move): all the user to specify an edge to resize with mouse in keyboard resize mode. window
2005-08-03 02:22:00 +00:00
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
common: Create a better encoding for MetaGrabOp MetaGrabOp is painful and tedious to work with, because it's a sequential series of values, meaning we have to use a giant unreadable switch statement to figure out some basic things about the value. To solve this, modify the encoding for MetaGrabOp and for the specific window grab operations so that they're a set of bitflags that we can easily check.
2014-08-15 18:05:04 +00:00
if (window->display->grab_op & META_GRAB_OP_WINDOW_DIR_EAST)
new_w += dx;
else if (window->display->grab_op & META_GRAB_OP_WINDOW_DIR_WEST)
new_w -= dx;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
common: Create a better encoding for MetaGrabOp MetaGrabOp is painful and tedious to work with, because it's a sequential series of values, meaning we have to use a giant unreadable switch statement to figure out some basic things about the value. To solve this, modify the encoding for MetaGrabOp and for the specific window grab operations so that they're a set of bitflags that we can easily check.
2014-08-15 18:05:04 +00:00
if (window->display->grab_op & META_GRAB_OP_WINDOW_DIR_SOUTH)
new_h += dy;
else if (window->display->grab_op & META_GRAB_OP_WINDOW_DIR_NORTH)
new_h -= dy;
...
2001-07-26 02:55:35 +00:00
Don't configure a window before it responds to _NET_WM_SYNC_REQUEST In 97a4cc8c, we accidentally lost the check that kept us from sending multiple configures to a window before it responds to _NET_WM_SYNC_REQUEST. So _NET_WM_SYNC_REQUEST stopped working properly. Add a check back with the same effect. https://bugzilla.gnome.org/show_bug.cgi?id=696091
2013-03-18 18:16:41 +00:00
/* If we're waiting for a request for _NET_WM_SYNC_REQUEST, we'll
* resize the window when the window responds, or when we time
* the response out.
*/
if (window->sync_request_timeout_id != 0)
return;
Fix bug 143333, support for update counter spec, and 109362, schedule Sat Jun 19 02:21:08 2004 Soeren Sandmann <sandmann@daimi.au.dk> Fix bug 143333, support for update counter spec, and 109362, schedule compensation events when events are ignored. * src/display.c (meta_display_open): Add _NET_WM_SYNC_REQUEST and _NET_WM_SYNC_REQUEST_COUNTER atoms. Remove the old METACITY_SYNC_COUNTER stuff. (meta_display_begin_op): Setup the sync counter * src/xprops.c, src/xprops.h, src/window-props.c, src/display.h: Add new atoms. * src/window.c (send_sync_request): new function. (meta_window_move_resize_internal): send a sync request before resizing. (check_move_resize_frequence): Rework logic to also check the SYNC case. If an event is ignored return the remaining time. (update_resize_timeout): Timeout that gets called when a compensation event is scheduled. (uddate_resize): schedule compensation events when an event is ignored. (meta_window_handle_mouse_grap_op_event): When an alarm is received and sync was turned off, turn it back on. * src/window.h (struct MetaWindow) Add some variables
2004-06-19 00:45:24 +00:00
if (!check_moveresize_frequency (window, &remaining) && !force)
{
/* we are ignoring an event here, so we schedule a
* compensation event when we would otherwise not ignore
* an event. Otherwise we can become stuck if the user never
* generates another event.
*/
if (!window->display->grab_resize_timeout_id)
{
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window->display->grab_resize_timeout_id =
Fix bug 143333, support for update counter spec, and 109362, schedule Sat Jun 19 02:21:08 2004 Soeren Sandmann <sandmann@daimi.au.dk> Fix bug 143333, support for update counter spec, and 109362, schedule compensation events when events are ignored. * src/display.c (meta_display_open): Add _NET_WM_SYNC_REQUEST and _NET_WM_SYNC_REQUEST_COUNTER atoms. Remove the old METACITY_SYNC_COUNTER stuff. (meta_display_begin_op): Setup the sync counter * src/xprops.c, src/xprops.h, src/window-props.c, src/display.h: Add new atoms. * src/window.c (send_sync_request): new function. (meta_window_move_resize_internal): send a sync request before resizing. (check_move_resize_frequence): Rework logic to also check the SYNC case. If an event is ignored return the remaining time. (update_resize_timeout): Timeout that gets called when a compensation event is scheduled. (uddate_resize): schedule compensation events when an event is ignored. (meta_window_handle_mouse_grap_op_event): When an alarm is received and sync was turned off, turn it back on. * src/window.h (struct MetaWindow) Add some variables
2004-06-19 00:45:24 +00:00
g_timeout_add ((int)remaining, update_resize_timeout, window);
Name all timeouts and idles Better names can be used once we make more use of them. https://bugzilla.gnome.org/show_bug.cgi?id=727979
2014-04-10 16:58:58 +00:00
g_source_set_name_by_id (window->display->grab_resize_timeout_id,
"[mutter] update_resize_timeout");
Fix bug 143333, support for update counter spec, and 109362, schedule Sat Jun 19 02:21:08 2004 Soeren Sandmann <sandmann@daimi.au.dk> Fix bug 143333, support for update counter spec, and 109362, schedule compensation events when events are ignored. * src/display.c (meta_display_open): Add _NET_WM_SYNC_REQUEST and _NET_WM_SYNC_REQUEST_COUNTER atoms. Remove the old METACITY_SYNC_COUNTER stuff. (meta_display_begin_op): Setup the sync counter * src/xprops.c, src/xprops.h, src/window-props.c, src/display.h: Add new atoms. * src/window.c (send_sync_request): new function. (meta_window_move_resize_internal): send a sync request before resizing. (check_move_resize_frequence): Rework logic to also check the SYNC case. If an event is ignored return the remaining time. (update_resize_timeout): Timeout that gets called when a compensation event is scheduled. (uddate_resize): schedule compensation events when an event is ignored. (meta_window_handle_mouse_grap_op_event): When an alarm is received and sync was turned off, turn it back on. * src/window.h (struct MetaWindow) Add some variables
2004-06-19 00:45:24 +00:00
}
return;
}
/* Remove any scheduled compensation events */
cleanup: Use g_clear_handle_id() for g_source_remove() It makes sure we do not forget to zero the id and lets us avoid zero checks before. We use it for all new code, lets clean up the existing code base. https://gitlab.gnome.org/GNOME/mutter/merge_requests/947
2019-11-21 23:25:30 +00:00
g_clear_handle_id (&window->display->grab_resize_timeout_id, g_source_remove);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window: Replace meta_window_resize_with_gravity with a frame-rect variant More low-hanging fruit for our window geometry cleanups...
2014-05-20 22:28:56 +00:00
meta_window_get_frame_rect (window, &old);
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
/* One sided resizing ought to actually be one-sided, despite the fact that
* aspect ratio windows don't interact nicely with the above stuff. So,
* to avoid some nasty flicker, we enforce that.
*/
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
common: Create a better encoding for MetaGrabOp MetaGrabOp is painful and tedious to work with, because it's a sequential series of values, meaning we have to use a giant unreadable switch statement to figure out some basic things about the value. To solve this, modify the encoding for MetaGrabOp and for the specific window grab operations so that they're a set of bitflags that we can easily check.
2014-08-15 18:05:04 +00:00
if ((window->display->grab_op & (META_GRAB_OP_WINDOW_DIR_WEST | META_GRAB_OP_WINDOW_DIR_EAST)) == 0)
new_w = old.width;
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
common: Create a better encoding for MetaGrabOp MetaGrabOp is painful and tedious to work with, because it's a sequential series of values, meaning we have to use a giant unreadable switch statement to figure out some basic things about the value. To solve this, modify the encoding for MetaGrabOp and for the specific window grab operations so that they're a set of bitflags that we can easily check.
2014-08-15 18:05:04 +00:00
if ((window->display->grab_op & (META_GRAB_OP_WINDOW_DIR_NORTH | META_GRAB_OP_WINDOW_DIR_SOUTH)) == 0)
new_h = old.height;
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
...
2001-07-26 02:55:35 +00:00
/* compute gravity of client during operation */
Add some total crackrock resize-grid indication for windows that have 2002-03-17 Havoc Pennington <hp@pobox.com> * src/resizepopup.c: Add some total crackrock resize-grid indication for windows that have width_inc/height_inc so I can debug gnome-terminal sizing.
2002-03-17 17:22:23 +00:00
gravity = meta_resize_gravity_from_grab_op (window->display->grab_op);
g_assert (gravity >= 0);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
/* Do any edge resistance/snapping */
meta_window_edge_resistance_for_resize (window,
&new_w,
&new_h,
gravity,
update_resize_timeout,
snap,
FALSE);
Remove the ability to grab resize unmaximize This is an extremely niche feature, and conflicts with the rest of our interface being consistent about not allowing resizing while tiled or maximized.
2015-07-01 05:46:31 +00:00
meta_window_resize_frame_with_gravity (window, TRUE, new_w, new_h, gravity);
add myself here, bug #100789 2002-12-09 Havoc Pennington <hp@pobox.com> * AUTHORS: add myself here, bug #100789 * src/display.c (meta_display_set_grab_op_cursor): drop PointerMotionHintMask * src/window.c (meta_window_handle_mouse_grab_op_event): don't use XQueryPointer, as we aren't using PointerMotionHint now * src/display.c (event_callback): rearrange a bit of code for slight speedup and clarity * src/window.c (update_resize) (meta_window_handle_mouse_grab_op_event): implement usage of the _METACITY_UPDATE_COUNTER (meta_window_handle_mouse_grab_op_event): fix code that used event->xbutton with a motion event * src/display.c (meta_display_open): add new atoms, and initialize Xsync if we have it (grab_op_is_resizing): new function (meta_display_begin_grab_op): create an alarm monitoring window's _METACITY_UPDATE_COUNTER (meta_spew_event): conditionalize this on WITH_VERBOSE_MODE and print alarm events. * src/window.c (meta_window_new): fetch _METACITY_UPDATE_COUNTER * configure.in (HAVE_XSYNC): check for Xsync extension
2002-12-10 03:23:04 +00:00
Fix bug 143333, support for update counter spec, and 109362, schedule Sat Jun 19 02:21:08 2004 Soeren Sandmann <sandmann@daimi.au.dk> Fix bug 143333, support for update counter spec, and 109362, schedule compensation events when events are ignored. * src/display.c (meta_display_open): Add _NET_WM_SYNC_REQUEST and _NET_WM_SYNC_REQUEST_COUNTER atoms. Remove the old METACITY_SYNC_COUNTER stuff. (meta_display_begin_op): Setup the sync counter * src/xprops.c, src/xprops.h, src/window-props.c, src/display.h: Add new atoms. * src/window.c (send_sync_request): new function. (meta_window_move_resize_internal): send a sync request before resizing. (check_move_resize_frequence): Rework logic to also check the SYNC case. If an event is ignored return the remaining time. (update_resize_timeout): Timeout that gets called when a compensation event is scheduled. (uddate_resize): schedule compensation events when an event is ignored. (meta_window_handle_mouse_grap_op_event): When an alarm is received and sync was turned off, turn it back on. * src/window.h (struct MetaWindow) Add some variables
2004-06-19 00:45:24 +00:00
/* Store the latest resize time, if we actually resized. */
Patch from Björn Lindqvist to fix a logic error. #322149. 2006-01-02 Elijah Newren <newren@gmail.com> Patch from Björn Lindqvist to fix a logic error. #322149. * src/window.c (update_resize): && should have been ||.
2006-01-02 18:48:30 +00:00
if (window->rect.width != old.width || window->rect.height != old.height)
cleanup: Stop using g_get_current_time () It has been deprecated because it isn't Y2k38 ready, so replace it with g_get_real_time () which is. https://gitlab.gnome.org/GNOME/mutter/merge_requests/708
2019-07-31 22:21:03 +00:00
window->display->grab_last_moveresize_time = g_get_real_time ();
...
2001-07-26 02:55:35 +00:00
}
window: Maximize tiled windows when resizing to work area Now that tiled windows are resizable, the user may grow a tiled windows until it covers the entire work area. As this makes the window state mostly indistinguishable from maximization, avoid subtle differences by properly maximizing the window in that case. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-11 17:58:21 +00:00
static void
maybe_maximize_tiled_window (MetaWindow *window)
{
MetaRectangle work_area;
gint shake_threshold;
if (!META_WINDOW_TILED_SIDE_BY_SIDE (window))
return;
shake_threshold = meta_prefs_get_drag_threshold ();
meta_window_get_work_area_for_monitor (window,
window->tile_monitor_number,
&work_area);
if (window->rect.width >= work_area.width - shake_threshold)
meta_window_maximize (window, META_MAXIMIZE_BOTH);
}
window: Move move_resize_internal logic to protocol-specific directories
2014-03-19 14:30:12 +00:00
void
meta_window_update_resize (MetaWindow *window,
gboolean snap,
int x, int y,
gboolean force)
{
update_resize (window, snap, x, y, force);
}
window: Properly end grab ops started from a keybind / menu If we start a grab op from a keybind / menu, we'll handle the ButtonPress and drop the grab then, never giving the window a chance to handle what it needs to do before the grab is dropped. This means that if you use Alt+F7 to move a window around, move it to a side-tiling or maximization area, and then left-click, it will just hang there in the sky.
2014-04-20 16:45:40 +00:00
static void
end_grab_op (MetaWindow *window,
const ClutterEvent *event)
{
window: Use event data getters in event handling code This makes these functions more independent wrt touch vs pointer events https://bugzilla.gnome.org/show_bug.cgi?id=733631
2014-07-21 23:06:22 +00:00
ClutterModifierType modifiers;
gfloat x, y;
clutter_event_get_coords (event, &x, &y);
modifiers = clutter_event_get_state (event);
meta_display_check_threshold_reached (window->display, x, y);
window: Properly end grab ops started from a keybind / menu If we start a grab op from a keybind / menu, we'll handle the ButtonPress and drop the grab then, never giving the window a chance to handle what it needs to do before the grab is dropped. This means that if you use Alt+F7 to move a window around, move it to a side-tiling or maximization area, and then left-click, it will just hang there in the sky.
2014-04-20 16:45:40 +00:00
/* If the user was snap moving then ignore the button
* release because they may have let go of shift before
* releasing the mouse button and they almost certainly do
* not want a non-snapped movement to occur from the button
* release.
*/
if (!window->display->grab_last_user_action_was_snap)
{
if (meta_grab_op_is_moving (window->display->grab_op))
{
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
if (window->display->preview_tile_mode != META_TILE_NONE)
meta_window_tile (window, window->display->preview_tile_mode);
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
else
update_move (window,
modifiers & CLUTTER_SHIFT_MASK,
x, y);
window: Properly end grab ops started from a keybind / menu If we start a grab op from a keybind / menu, we'll handle the ButtonPress and drop the grab then, never giving the window a chance to handle what it needs to do before the grab is dropped. This means that if you use Alt+F7 to move a window around, move it to a side-tiling or maximization area, and then left-click, it will just hang there in the sky.
2014-04-20 16:45:40 +00:00
}
else if (meta_grab_op_is_resizing (window->display->grab_op))
{
update_resize (window,
edge-resistance: Add snapping for tiled windows When windows are tiled, it improves the interaction with them when they have a set of snapping edges relative to the monitor. For example, when there's a document editor and a PDF file opened, I might want to rescale the former to 2/3 of the screen and the latter to 1/3. These snapping sections are not really tied to any other window, and only depend on the current work area of the window. Thus, it is not necessary to adapt the current snapping edge detection algorithm. This patch adds the necessary code in edge-resistance.c to special-case tiled windows and allow them to cover 1/4, 1/3 and 1/2 (horizontally) of the screen. These values are hardcoded. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-13 21:30:10 +00:00
modifiers & CLUTTER_SHIFT_MASK || window->tile_match != NULL,
window: Use event data getters in event handling code This makes these functions more independent wrt touch vs pointer events https://bugzilla.gnome.org/show_bug.cgi?id=733631
2014-07-21 23:06:22 +00:00
x, y,
window: Properly end grab ops started from a keybind / menu If we start a grab op from a keybind / menu, we'll handle the ButtonPress and drop the grab then, never giving the window a chance to handle what it needs to do before the grab is dropped. This means that if you use Alt+F7 to move a window around, move it to a side-tiling or maximization area, and then left-click, it will just hang there in the sky.
2014-04-20 16:45:40 +00:00
TRUE);
window: Maximize tiled windows when resizing to work area Now that tiled windows are resizable, the user may grow a tiled windows until it covers the entire work area. As this makes the window state mostly indistinguishable from maximization, avoid subtle differences by properly maximizing the window in that case. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-11 17:58:21 +00:00
maybe_maximize_tiled_window (window);
window: Properly end grab ops started from a keybind / menu If we start a grab op from a keybind / menu, we'll handle the ButtonPress and drop the grab then, never giving the window a chance to handle what it needs to do before the grab is dropped. This means that if you use Alt+F7 to move a window around, move it to a side-tiling or maximization area, and then left-click, it will just hang there in the sky.
2014-04-20 16:45:40 +00:00
}
}
Move rest of non-X11 specific objects from MetaScreen This moves following objects from MetaScreen to MetaDisplay - workareas_later and in_fullscreen_later signals and functions - startup_sequences signals and functions - tile_preview functions https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 19:10:38 +00:00
window->display->preview_tile_mode = META_TILE_NONE;
window: Use event data getters in event handling code This makes these functions more independent wrt touch vs pointer events https://bugzilla.gnome.org/show_bug.cgi?id=733631
2014-07-21 23:06:22 +00:00
meta_display_end_grab_op (window->display, clutter_event_get_time (event));
window: Properly end grab ops started from a keybind / menu If we start a grab op from a keybind / menu, we'll handle the ButtonPress and drop the grab then, never giving the window a chance to handle what it needs to do before the grab is dropped. This means that if you use Alt+F7 to move a window around, move it to a side-tiling or maximization area, and then left-click, it will just hang there in the sky.
2014-04-20 16:45:40 +00:00
}
events: Handle move/resize grab ops as a first special case
2014-04-21 15:21:19 +00:00
gboolean
Support X button events again Do this by duplicating the current code and porting it to use X again. A better approach would involve our own event structures, and I really don't want to do that right now. We can clean this up later.
2013-12-05 21:13:03 +00:00
meta_window_handle_mouse_grab_op_event (MetaWindow *window,
const ClutterEvent *event)
window: Move grab op sync handling code out This removes some duplicate event type checks, and will make the code cleaner in the future when we want to make the grab_op_event handler take an XIDeviceEvent directly. Based on a patch by Owen Taylor <otaylor@fishsoup.net> https://bugzilla.gnome.org/show_bug.cgi?id=688779
2012-11-15 22:18:06 +00:00
{
window: Implement single-touch window dragging On X11 this works because only emulated pointer events are listened for. On wayland, the single touch behavior must be enforced in touch events, ignoring every other sequence. https://bugzilla.gnome.org/show_bug.cgi?id=733631
2014-07-21 23:17:40 +00:00
ClutterEventSequence *sequence = clutter_event_get_event_sequence (event);
window: Use event data getters in event handling code This makes these functions more independent wrt touch vs pointer events https://bugzilla.gnome.org/show_bug.cgi?id=733631
2014-07-21 23:06:22 +00:00
ClutterModifierType modifier_state;
gfloat x, y;
display: Move the pointer event handling code to work in terms of Clutter events There is now a meta_display_handle_event alongside the meta_display_handle_xevent function which handles events in terms of Clutter events instead of X events. A Clutter event filter is registered so that all Clutter events will pass through this function. The pointer event handling code from the X event version has been moved into this new function and has been modified to use the details from the Clutter event instead of the X event. This is a step towards moving all of the event handling code over to use Clutter events. Based-heavily-on-a-patch-by: Neil Roberts <neil@linux.intel.com>
2013-10-03 19:29:44 +00:00
switch (event->type)
add myself here, bug #100789 2002-12-09 Havoc Pennington <hp@pobox.com> * AUTHORS: add myself here, bug #100789 * src/display.c (meta_display_set_grab_op_cursor): drop PointerMotionHintMask * src/window.c (meta_window_handle_mouse_grab_op_event): don't use XQueryPointer, as we aren't using PointerMotionHint now * src/display.c (event_callback): rearrange a bit of code for slight speedup and clarity * src/window.c (update_resize) (meta_window_handle_mouse_grab_op_event): implement usage of the _METACITY_UPDATE_COUNTER (meta_window_handle_mouse_grab_op_event): fix code that used event->xbutton with a motion event * src/display.c (meta_display_open): add new atoms, and initialize Xsync if we have it (grab_op_is_resizing): new function (meta_display_begin_grab_op): create an alarm monitoring window's _METACITY_UPDATE_COUNTER (meta_spew_event): conditionalize this on WITH_VERBOSE_MODE and print alarm events. * src/window.c (meta_window_new): fetch _METACITY_UPDATE_COUNTER * configure.in (HAVE_XSYNC): check for Xsync extension
2002-12-10 03:23:04 +00:00
{
window: Properly end grab ops started from a keybind / menu If we start a grab op from a keybind / menu, we'll handle the ButtonPress and drop the grab then, never giving the window a chance to handle what it needs to do before the grab is dropped. This means that if you use Alt+F7 to move a window around, move it to a side-tiling or maximization area, and then left-click, it will just hang there in the sky.
2014-04-20 16:45:40 +00:00
case CLUTTER_BUTTON_PRESS:
window: Be better at filtering window grab mods It turns out that Clutter doesn't actually filter NumLock / ScrollLock / CapsLock from button events due to its terrible event translation code. Check only the grab mods to check if it's unmodified.
2014-08-15 20:03:50 +00:00
{
window: Fix build I break things a lot now.
2014-08-15 20:08:25 +00:00
ClutterModifierType grab_mods = meta_display_get_window_grab_modifiers (window->display);
window: Be better at filtering window grab mods It turns out that Clutter doesn't actually filter NumLock / ScrollLock / CapsLock from button events due to its terrible event translation code. Check only the grab mods to check if it's unmodified.
2014-08-15 20:03:50 +00:00
/* This is the keybinding or menu case where we've
* been dragging around the window without the button
* pressed. */
if ((meta_grab_op_is_mouse (window->display->grab_op) &&
(event->button.modifier_state & grab_mods) == grab_mods &&
window->display->grab_button != (int) event->button.button) ||
meta_grab_op_is_keyboard (window->display->grab_op))
{
end_grab_op (window, event);
return FALSE;
}
return TRUE;
}
window: Properly end grab ops started from a keybind / menu If we start a grab op from a keybind / menu, we'll handle the ButtonPress and drop the grab then, never giving the window a chance to handle what it needs to do before the grab is dropped. This means that if you use Alt+F7 to move a window around, move it to a side-tiling or maximization area, and then left-click, it will just hang there in the sky.
2014-04-20 16:45:40 +00:00
window: Implement single-touch window dragging On X11 this works because only emulated pointer events are listened for. On wayland, the single touch behavior must be enforced in touch events, ignoring every other sequence. https://bugzilla.gnome.org/show_bug.cgi?id=733631
2014-07-21 23:17:40 +00:00
case CLUTTER_TOUCH_END:
if (meta_display_is_pointer_emulating_sequence (window->display, sequence))
end_grab_op (window, event);
return TRUE;
display: Move the pointer event handling code to work in terms of Clutter events There is now a meta_display_handle_event alongside the meta_display_handle_xevent function which handles events in terms of Clutter events instead of X events. A Clutter event filter is registered so that all Clutter events will pass through this function. The pointer event handling code from the X event version has been moved into this new function and has been modified to use the details from the Clutter event instead of the X event. This is a step towards moving all of the event handling code over to use Clutter events. Based-heavily-on-a-patch-by: Neil Roberts <neil@linux.intel.com>
2013-10-03 19:29:44 +00:00
case CLUTTER_BUTTON_RELEASE:
window: don't ignore resize button release event for move/resize actions https://bugzilla.gnome.org/show_bug.cgi?id=710251
2013-10-16 20:29:54 +00:00
if (event->button.button == 1 ||
window: Fix signedness warning
2013-11-19 19:03:09 +00:00
event->button.button == (unsigned int) meta_prefs_get_mouse_button_resize ())
core: end-of-grab button releases must be consumed by the window Returning FALSE here gets the button release event propagated to the client on wayland, which is unexpected after xdg_surface.move/resize() have been called. https://bugzilla.gnome.org/show_bug.cgi?id=738888
2014-10-20 16:26:25 +00:00
end_grab_op (window, event);
events: Handle move/resize grab ops as a first special case
2014-04-21 15:21:19 +00:00
return TRUE;
add myself here, bug #100789 2002-12-09 Havoc Pennington <hp@pobox.com> * AUTHORS: add myself here, bug #100789 * src/display.c (meta_display_set_grab_op_cursor): drop PointerMotionHintMask * src/window.c (meta_window_handle_mouse_grab_op_event): don't use XQueryPointer, as we aren't using PointerMotionHint now * src/display.c (event_callback): rearrange a bit of code for slight speedup and clarity * src/window.c (update_resize) (meta_window_handle_mouse_grab_op_event): implement usage of the _METACITY_UPDATE_COUNTER (meta_window_handle_mouse_grab_op_event): fix code that used event->xbutton with a motion event * src/display.c (meta_display_open): add new atoms, and initialize Xsync if we have it (grab_op_is_resizing): new function (meta_display_begin_grab_op): create an alarm monitoring window's _METACITY_UPDATE_COUNTER (meta_spew_event): conditionalize this on WITH_VERBOSE_MODE and print alarm events. * src/window.c (meta_window_new): fetch _METACITY_UPDATE_COUNTER * configure.in (HAVE_XSYNC): check for Xsync extension
2002-12-10 03:23:04 +00:00
window: Implement single-touch window dragging On X11 this works because only emulated pointer events are listened for. On wayland, the single touch behavior must be enforced in touch events, ignoring every other sequence. https://bugzilla.gnome.org/show_bug.cgi?id=733631
2014-07-21 23:17:40 +00:00
case CLUTTER_TOUCH_BEGIN:
/* This will only catch the keybinding and menu cases, just deal with this
* like a CLUTTER_TOUCH_UPDATE rather than a CLUTTER_BUTTON_PRESS, and
* wait until CLUTTER_TOUCH_END to undo the grab, just so the window
* doesn't warp below the finger and remain there.
*/
case CLUTTER_TOUCH_UPDATE:
if (!meta_display_is_pointer_emulating_sequence (window->display, sequence))
return FALSE;
/* Fall through */
display: Move the pointer event handling code to work in terms of Clutter events There is now a meta_display_handle_event alongside the meta_display_handle_xevent function which handles events in terms of Clutter events instead of X events. A Clutter event filter is registered so that all Clutter events will pass through this function. The pointer event handling code from the X event version has been moved into this new function and has been modified to use the details from the Clutter event instead of the X event. This is a step towards moving all of the event handling code over to use Clutter events. Based-heavily-on-a-patch-by: Neil Roberts <neil@linux.intel.com>
2013-10-03 19:29:44 +00:00
case CLUTTER_MOTION:
window: Use event data getters in event handling code This makes these functions more independent wrt touch vs pointer events https://bugzilla.gnome.org/show_bug.cgi?id=733631
2014-07-21 23:06:22 +00:00
modifier_state = clutter_event_get_state (event);
clutter_event_get_coords (event, &x, &y);
meta_display_check_threshold_reached (window->display, x, y);
add myself here, bug #100789 2002-12-09 Havoc Pennington <hp@pobox.com> * AUTHORS: add myself here, bug #100789 * src/display.c (meta_display_set_grab_op_cursor): drop PointerMotionHintMask * src/window.c (meta_window_handle_mouse_grab_op_event): don't use XQueryPointer, as we aren't using PointerMotionHint now * src/display.c (event_callback): rearrange a bit of code for slight speedup and clarity * src/window.c (update_resize) (meta_window_handle_mouse_grab_op_event): implement usage of the _METACITY_UPDATE_COUNTER (meta_window_handle_mouse_grab_op_event): fix code that used event->xbutton with a motion event * src/display.c (meta_display_open): add new atoms, and initialize Xsync if we have it (grab_op_is_resizing): new function (meta_display_begin_grab_op): create an alarm monitoring window's _METACITY_UPDATE_COUNTER (meta_spew_event): conditionalize this on WITH_VERBOSE_MODE and print alarm events. * src/window.c (meta_window_new): fetch _METACITY_UPDATE_COUNTER * configure.in (HAVE_XSYNC): check for Xsync extension
2002-12-10 03:23:04 +00:00
if (meta_grab_op_is_moving (window->display->grab_op))
{
window: Remove is_window_root The entire point of it was to check whether the window was on the right screen. Since we don't handle multiple screens anymore, we don't need to check anything anymore.
2014-04-20 16:37:37 +00:00
update_move (window,
window: Use event data getters in event handling code This makes these functions more independent wrt touch vs pointer events https://bugzilla.gnome.org/show_bug.cgi?id=733631
2014-07-21 23:06:22 +00:00
modifier_state & CLUTTER_SHIFT_MASK,
x, y);
add myself here, bug #100789 2002-12-09 Havoc Pennington <hp@pobox.com> * AUTHORS: add myself here, bug #100789 * src/display.c (meta_display_set_grab_op_cursor): drop PointerMotionHintMask * src/window.c (meta_window_handle_mouse_grab_op_event): don't use XQueryPointer, as we aren't using PointerMotionHint now * src/display.c (event_callback): rearrange a bit of code for slight speedup and clarity * src/window.c (update_resize) (meta_window_handle_mouse_grab_op_event): implement usage of the _METACITY_UPDATE_COUNTER (meta_window_handle_mouse_grab_op_event): fix code that used event->xbutton with a motion event * src/display.c (meta_display_open): add new atoms, and initialize Xsync if we have it (grab_op_is_resizing): new function (meta_display_begin_grab_op): create an alarm monitoring window's _METACITY_UPDATE_COUNTER (meta_spew_event): conditionalize this on WITH_VERBOSE_MODE and print alarm events. * src/window.c (meta_window_new): fetch _METACITY_UPDATE_COUNTER * configure.in (HAVE_XSYNC): check for Xsync extension
2002-12-10 03:23:04 +00:00
}
else if (meta_grab_op_is_resizing (window->display->grab_op))
{
window: Remove is_window_root The entire point of it was to check whether the window was on the right screen. Since we don't handle multiple screens anymore, we don't need to check anything anymore.
2014-04-20 16:37:37 +00:00
update_resize (window,
edge-resistance: Add snapping for tiled windows When windows are tiled, it improves the interaction with them when they have a set of snapping edges relative to the monitor. For example, when there's a document editor and a PDF file opened, I might want to rescale the former to 2/3 of the screen and the latter to 1/3. These snapping sections are not really tied to any other window, and only depend on the current work area of the window. Thus, it is not necessary to adapt the current snapping edge detection algorithm. This patch adds the necessary code in edge-resistance.c to special-case tiled windows and allow them to cover 1/4, 1/3 and 1/2 (horizontally) of the screen. These values are hardcoded. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-13 21:30:10 +00:00
modifier_state & CLUTTER_SHIFT_MASK || window->tile_match != NULL,
window: Use event data getters in event handling code This makes these functions more independent wrt touch vs pointer events https://bugzilla.gnome.org/show_bug.cgi?id=733631
2014-07-21 23:06:22 +00:00
x, y,
window: Remove is_window_root The entire point of it was to check whether the window was on the right screen. Since we don't handle multiple screens anymore, we don't need to check anything anymore.
2014-04-20 16:37:37 +00:00
FALSE);
add myself here, bug #100789 2002-12-09 Havoc Pennington <hp@pobox.com> * AUTHORS: add myself here, bug #100789 * src/display.c (meta_display_set_grab_op_cursor): drop PointerMotionHintMask * src/window.c (meta_window_handle_mouse_grab_op_event): don't use XQueryPointer, as we aren't using PointerMotionHint now * src/display.c (event_callback): rearrange a bit of code for slight speedup and clarity * src/window.c (update_resize) (meta_window_handle_mouse_grab_op_event): implement usage of the _METACITY_UPDATE_COUNTER (meta_window_handle_mouse_grab_op_event): fix code that used event->xbutton with a motion event * src/display.c (meta_display_open): add new atoms, and initialize Xsync if we have it (grab_op_is_resizing): new function (meta_display_begin_grab_op): create an alarm monitoring window's _METACITY_UPDATE_COUNTER (meta_spew_event): conditionalize this on WITH_VERBOSE_MODE and print alarm events. * src/window.c (meta_window_new): fetch _METACITY_UPDATE_COUNTER * configure.in (HAVE_XSYNC): check for Xsync extension
2002-12-10 03:23:04 +00:00
}
events: Handle move/resize grab ops as a first special case
2014-04-21 15:21:19 +00:00
return TRUE;
add myself here, bug #100789 2002-12-09 Havoc Pennington <hp@pobox.com> * AUTHORS: add myself here, bug #100789 * src/display.c (meta_display_set_grab_op_cursor): drop PointerMotionHintMask * src/window.c (meta_window_handle_mouse_grab_op_event): don't use XQueryPointer, as we aren't using PointerMotionHint now * src/display.c (event_callback): rearrange a bit of code for slight speedup and clarity * src/window.c (update_resize) (meta_window_handle_mouse_grab_op_event): implement usage of the _METACITY_UPDATE_COUNTER (meta_window_handle_mouse_grab_op_event): fix code that used event->xbutton with a motion event * src/display.c (meta_display_open): add new atoms, and initialize Xsync if we have it (grab_op_is_resizing): new function (meta_display_begin_grab_op): create an alarm monitoring window's _METACITY_UPDATE_COUNTER (meta_spew_event): conditionalize this on WITH_VERBOSE_MODE and print alarm events. * src/window.c (meta_window_new): fetch _METACITY_UPDATE_COUNTER * configure.in (HAVE_XSYNC): check for Xsync extension
2002-12-10 03:23:04 +00:00
...
2001-07-26 02:55:35 +00:00
default:
events: Handle move/resize grab ops as a first special case
2014-04-21 15:21:19 +00:00
return FALSE;
...
2001-07-26 02:55:35 +00:00
}
}
Add API for getting work area given a logical monitor To complement the current API which takes an index referencing a logical monitor in the logical monitor array, add API that takes a direct reference to the logical monitor itself. The intention is to replace the usage of the index based API with one that doesn't rely on internal implementation details. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 03:48:52 +00:00
void
meta_window_get_work_area_for_logical_monitor (MetaWindow *window,
MetaLogicalMonitor *logical_monitor,
MetaRectangle *area)
store strut information, update it on property changes, etc. etc. so we 2002-01-09 Havoc Pennington <hp@pobox.com> * src/window.c, src/window.h: store strut information, update it on property changes, etc. etc. so we avoid panel on maximize. * src/workspace.c (meta_workspace_get_work_area): add accessor for work area so we can compute it lazily * src/display.h, src/display.c: add _NET_WM_STRUT atom and _WIN_HINTS atom
2002-01-10 06:31:31 +00:00
{
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
GList *tmp;
Add API for getting work area given a logical monitor To complement the current API which takes an index referencing a logical monitor in the logical monitor array, add API that takes a direct reference to the logical monitor itself. The intention is to replace the usage of the index based API with one that doesn't rely on internal implementation details. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 03:48:52 +00:00
g_assert (logical_monitor);
MetaScreen: Remove redundant copy of logical monitors array It was just pointer to the actual list; having to synchronize a list of logical monitors with the actual monitors managed by the backend is unnecessary. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-28 12:11:24 +00:00
Refer to monitors as "monitors" rather than "xineramas" http://bugzilla.gnome.org/show_bug.cgi?id=593686
2009-08-31 13:52:16 +00:00
/* Initialize to the whole monitor */
Add API for getting work area given a logical monitor To complement the current API which takes an index referencing a logical monitor in the logical monitor array, add API that takes a direct reference to the logical monitor itself. The intention is to replace the usage of the index based API with one that doesn't rely on internal implementation details. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 03:48:52 +00:00
*area = logical_monitor->rect;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
tmp = meta_window_get_workspaces (window);
store strut information, update it on property changes, etc. etc. so we 2002-01-09 Havoc Pennington <hp@pobox.com> * src/window.c, src/window.h: store strut information, update it on property changes, etc. etc. so we avoid panel on maximize. * src/workspace.c (meta_workspace_get_work_area): add accessor for work area so we can compute it lazily * src/display.h, src/display.c: add _NET_WM_STRUT atom and _WIN_HINTS atom
2002-01-10 06:31:31 +00:00
while (tmp != NULL)
{
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
MetaRectangle workspace_work_area;
Add API for getting work area given a logical monitor To complement the current API which takes an index referencing a logical monitor in the logical monitor array, add API that takes a direct reference to the logical monitor itself. The intention is to replace the usage of the index based API with one that doesn't rely on internal implementation details. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 03:48:52 +00:00
meta_workspace_get_work_area_for_logical_monitor (tmp->data,
logical_monitor,
&workspace_work_area);
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
meta_rectangle_intersect (area,
&workspace_work_area,
area);
store strut information, update it on property changes, etc. etc. so we 2002-01-09 Havoc Pennington <hp@pobox.com> * src/window.c, src/window.h: store strut information, update it on property changes, etc. etc. so we avoid panel on maximize. * src/workspace.c (meta_workspace_get_work_area): add accessor for work area so we can compute it lazily * src/display.h, src/display.c: add _NET_WM_STRUT atom and _WIN_HINTS atom
2002-01-10 06:31:31 +00:00
tmp = tmp->next;
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Throughout: move to meta_topic rather than meta_verbose so metacity.log 2002-02-07 Havoc Pennington <hp@pobox.com> Throughout: move to meta_topic rather than meta_verbose so metacity.log can start being more useful * src/util.h (enum): add more debug topics * src/frames.c: clean up some cruft that caused warnings
2002-02-08 03:34:26 +00:00
meta_topic (META_DEBUG_WORKAREA,
Refer to monitors as "monitors" rather than "xineramas" http://bugzilla.gnome.org/show_bug.cgi?id=593686
2009-08-31 13:52:16 +00:00
"Window %s monitor %d has work area %d,%d %d x %d\n",
Add API for getting work area given a logical monitor To complement the current API which takes an index referencing a logical monitor in the logical monitor array, add API that takes a direct reference to the logical monitor itself. The intention is to replace the usage of the index based API with one that doesn't rely on internal implementation details. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 03:48:52 +00:00
window->desc, logical_monitor->number,
Switch over to new constraints code, unquestionably introduces some bugs, 2003-02-27 Havoc Pennington <hp@redhat.com> Switch over to new constraints code, unquestionably introduces some bugs, but should get us on the right path. * src/window.c (meta_window_get_work_area_all_xineramas): create this function again as it turned out to be legitimate for window position constraint (adjust_for_gravity): use the width/height from the configure request to compute the requested move (meta_window_move_resize_internal): use meta_window_constrain (update_size_hints): clamp max size to MAXSHORT to avoid worrying about overflow stuff * src/constraints.c (meta_window_constrain): don't base placement on uninitialized variables, general hacking * src/Makefile.am (metacity_SOURCES): add constraints.c, constraints.h * src/constraints.c (meta_window_constrain): update the cut-and-paste aspect ratio code to have latest bugfixes
2003-03-08 23:43:17 +00:00
area->x, area->y, area->width, area->height);
store strut information, update it on property changes, etc. etc. so we 2002-01-09 Havoc Pennington <hp@pobox.com> * src/window.c, src/window.h: store strut information, update it on property changes, etc. etc. so we avoid panel on maximize. * src/workspace.c (meta_workspace_get_work_area): add accessor for work area so we can compute it lazily * src/display.h, src/display.c: add _NET_WM_STRUT atom and _WIN_HINTS atom
2002-01-10 06:31:31 +00:00
}
make the check for whether to eat focus click a lot more complicated 2002-01-27 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make the check for whether to eat focus click a lot more complicated * src/window.c (meta_window_same_application): new function * src/prefs.h, src/prefs.c: add application based pref * src/metacity.schemas: add "application_based" setting to give me a mode to fool with being application based, without being unusable in the meantime. Yeah the crack flows freely these days. Everyone knew it would happen.
2002-01-27 05:50:34 +00:00
Make work_area calculation funcs public and introspectible https://bugzilla.gnome.org/show_bug.cgi?id=692679
2013-01-28 04:08:17 +00:00
/**
* meta_window_get_work_area_current_monitor:
* @window: a #MetaWindow
* @area: (out): a location to store the work area
*
* Get the work area for the monitor @window is currently on.
*/
Patch from Rob Adams addresses #95014 (placement issues), makes first fit 2003-02-23 Havoc Pennington <hp@pobox.com> Patch from Rob Adams addresses #95014 (placement issues), makes first fit algorithm "center tile", adds most code for per-xinerama workspaces (#86682) but disables it for now. * src/workspace.c (meta_workspace_get_work_area_for_xinerama) (meta_workspace_get_work_area_all_xineramas): new xinerama functions, maintain workspace->work_areas with a different work area for each xinerama. However for now all the work areas are the same, because haven't quite figured out how _NET_WM_STRUT is supposed to work * src/window.c: adapt to new meta_window_* xinerama APIs (meta_window_get_work_area_current_xinerama): new xinerama API (meta_window_get_work_area_for_xinerama): new xinerama API (constrain_position): be a bit more clever about which xinerama's work area we choose to use. * src/stack.c: adapt to new Xinerama API * src/screen.c (reload_xinerama_infos): invalidate all work areas (meta_screen_get_xinerama_for_rect): new function (meta_screen_window_intersects_xinerama): new function * src/place.c (find_first_fit): change to use "center tiling" (center a screen full of tiled windows, rather than aligning them top left). Adapt to new xinerama functions.
2003-02-23 17:09:46 +00:00
void
Refer to monitors as "monitors" rather than "xineramas" http://bugzilla.gnome.org/show_bug.cgi?id=593686
2009-08-31 13:52:16 +00:00
meta_window_get_work_area_current_monitor (MetaWindow *window,
MetaRectangle *area)
Patch from Rob Adams addresses #95014 (placement issues), makes first fit 2003-02-23 Havoc Pennington <hp@pobox.com> Patch from Rob Adams addresses #95014 (placement issues), makes first fit algorithm "center tile", adds most code for per-xinerama workspaces (#86682) but disables it for now. * src/workspace.c (meta_workspace_get_work_area_for_xinerama) (meta_workspace_get_work_area_all_xineramas): new xinerama functions, maintain workspace->work_areas with a different work area for each xinerama. However for now all the work areas are the same, because haven't quite figured out how _NET_WM_STRUT is supposed to work * src/window.c: adapt to new meta_window_* xinerama APIs (meta_window_get_work_area_current_xinerama): new xinerama API (meta_window_get_work_area_for_xinerama): new xinerama API (constrain_position): be a bit more clever about which xinerama's work area we choose to use. * src/stack.c: adapt to new Xinerama API * src/screen.c (reload_xinerama_infos): invalidate all work areas (meta_screen_get_xinerama_for_rect): new function (meta_screen_window_intersects_xinerama): new function * src/place.c (find_first_fit): change to use "center tiling" (center a screen full of tiled windows, rather than aligning them top left). Adapt to new xinerama functions.
2003-02-23 17:09:46 +00:00
{
Refer to monitors as "monitors" rather than "xineramas" http://bugzilla.gnome.org/show_bug.cgi?id=593686
2009-08-31 13:52:16 +00:00
meta_window_get_work_area_for_monitor (window,
Don't calculate the main window monitor every time it`s needed The main monitor of a window is maintained as 'window->monitor' and is updated when the window is resized or moved. Lets avoid calculating it every time it`s needed. https://bugzilla.gnome.org/show_bug.cgi?id=744934
2015-04-09 04:20:24 +00:00
window->monitor->number,
Refer to monitors as "monitors" rather than "xineramas" http://bugzilla.gnome.org/show_bug.cgi?id=593686
2009-08-31 13:52:16 +00:00
area);
Patch from Rob Adams addresses #95014 (placement issues), makes first fit 2003-02-23 Havoc Pennington <hp@pobox.com> Patch from Rob Adams addresses #95014 (placement issues), makes first fit algorithm "center tile", adds most code for per-xinerama workspaces (#86682) but disables it for now. * src/workspace.c (meta_workspace_get_work_area_for_xinerama) (meta_workspace_get_work_area_all_xineramas): new xinerama functions, maintain workspace->work_areas with a different work area for each xinerama. However for now all the work areas are the same, because haven't quite figured out how _NET_WM_STRUT is supposed to work * src/window.c: adapt to new meta_window_* xinerama APIs (meta_window_get_work_area_current_xinerama): new xinerama API (meta_window_get_work_area_for_xinerama): new xinerama API (constrain_position): be a bit more clever about which xinerama's work area we choose to use. * src/stack.c: adapt to new Xinerama API * src/screen.c (reload_xinerama_infos): invalidate all work areas (meta_screen_get_xinerama_for_rect): new function (meta_screen_window_intersects_xinerama): new function * src/place.c (find_first_fit): change to use "center tiling" (center a screen full of tiled windows, rather than aligning them top left). Adapt to new xinerama functions.
2003-02-23 17:09:46 +00:00
}
Make work_area calculation funcs public and introspectible https://bugzilla.gnome.org/show_bug.cgi?id=692679
2013-01-28 04:08:17 +00:00
/**
* meta_window_get_work_area_for_monitor:
* @window: a #MetaWindow
* @which_monitor: a moniotr to get the work area for
* @area: (out): a location to store the work area
*
* Get the work area for @window, given the monitor index
* @which_monitor.
*/
Patch from Rob Adams addresses #95014 (placement issues), makes first fit 2003-02-23 Havoc Pennington <hp@pobox.com> Patch from Rob Adams addresses #95014 (placement issues), makes first fit algorithm "center tile", adds most code for per-xinerama workspaces (#86682) but disables it for now. * src/workspace.c (meta_workspace_get_work_area_for_xinerama) (meta_workspace_get_work_area_all_xineramas): new xinerama functions, maintain workspace->work_areas with a different work area for each xinerama. However for now all the work areas are the same, because haven't quite figured out how _NET_WM_STRUT is supposed to work * src/window.c: adapt to new meta_window_* xinerama APIs (meta_window_get_work_area_current_xinerama): new xinerama API (meta_window_get_work_area_for_xinerama): new xinerama API (constrain_position): be a bit more clever about which xinerama's work area we choose to use. * src/stack.c: adapt to new Xinerama API * src/screen.c (reload_xinerama_infos): invalidate all work areas (meta_screen_get_xinerama_for_rect): new function (meta_screen_window_intersects_xinerama): new function * src/place.c (find_first_fit): change to use "center tiling" (center a screen full of tiled windows, rather than aligning them top left). Adapt to new xinerama functions.
2003-02-23 17:09:46 +00:00
void
Refer to monitors as "monitors" rather than "xineramas" http://bugzilla.gnome.org/show_bug.cgi?id=593686
2009-08-31 13:52:16 +00:00
meta_window_get_work_area_for_monitor (MetaWindow *window,
int which_monitor,
MetaRectangle *area)
Patch from Rob Adams addresses #95014 (placement issues), makes first fit 2003-02-23 Havoc Pennington <hp@pobox.com> Patch from Rob Adams addresses #95014 (placement issues), makes first fit algorithm "center tile", adds most code for per-xinerama workspaces (#86682) but disables it for now. * src/workspace.c (meta_workspace_get_work_area_for_xinerama) (meta_workspace_get_work_area_all_xineramas): new xinerama functions, maintain workspace->work_areas with a different work area for each xinerama. However for now all the work areas are the same, because haven't quite figured out how _NET_WM_STRUT is supposed to work * src/window.c: adapt to new meta_window_* xinerama APIs (meta_window_get_work_area_current_xinerama): new xinerama API (meta_window_get_work_area_for_xinerama): new xinerama API (constrain_position): be a bit more clever about which xinerama's work area we choose to use. * src/stack.c: adapt to new Xinerama API * src/screen.c (reload_xinerama_infos): invalidate all work areas (meta_screen_get_xinerama_for_rect): new function (meta_screen_window_intersects_xinerama): new function * src/place.c (find_first_fit): change to use "center tiling" (center a screen full of tiled windows, rather than aligning them top left). Adapt to new xinerama functions.
2003-02-23 17:09:46 +00:00
{
Add API for getting work area given a logical monitor To complement the current API which takes an index referencing a logical monitor in the logical monitor array, add API that takes a direct reference to the logical monitor itself. The intention is to replace the usage of the index based API with one that doesn't rely on internal implementation details. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 03:48:52 +00:00
MetaBackend *backend = meta_get_backend ();
MetaMonitorManager *monitor_manager = meta_backend_get_monitor_manager (backend);
MetaLogicalMonitor *logical_monitor;
Refer to monitors as "monitors" rather than "xineramas" http://bugzilla.gnome.org/show_bug.cgi?id=593686
2009-08-31 13:52:16 +00:00
g_return_if_fail (which_monitor >= 0);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Add API for getting work area given a logical monitor To complement the current API which takes an index referencing a logical monitor in the logical monitor array, add API that takes a direct reference to the logical monitor itself. The intention is to replace the usage of the index based API with one that doesn't rely on internal implementation details. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 03:48:52 +00:00
logical_monitor =
meta_monitor_manager_get_logical_monitor_from_number (monitor_manager,
which_monitor);
meta_window_get_work_area_for_logical_monitor (window, logical_monitor, area);
Switch over to new constraints code, unquestionably introduces some bugs, 2003-02-27 Havoc Pennington <hp@redhat.com> Switch over to new constraints code, unquestionably introduces some bugs, but should get us on the right path. * src/window.c (meta_window_get_work_area_all_xineramas): create this function again as it turned out to be legitimate for window position constraint (adjust_for_gravity): use the width/height from the configure request to compute the requested move (meta_window_move_resize_internal): use meta_window_constrain (update_size_hints): clamp max size to MAXSHORT to avoid worrying about overflow stuff * src/constraints.c (meta_window_constrain): don't base placement on uninitialized variables, general hacking * src/Makefile.am (metacity_SOURCES): add constraints.c, constraints.h * src/constraints.c (meta_window_constrain): update the cut-and-paste aspect ratio code to have latest bugfixes
2003-03-08 23:43:17 +00:00
}
Make work_area calculation funcs public and introspectible https://bugzilla.gnome.org/show_bug.cgi?id=692679
2013-01-28 04:08:17 +00:00
/**
* meta_window_get_work_area_all_monitors:
* @window: a #MetaWindow
* @area: (out): a location to store the work area
*
* Get the work area for all monitors for @window.
*/
Switch over to new constraints code, unquestionably introduces some bugs, 2003-02-27 Havoc Pennington <hp@redhat.com> Switch over to new constraints code, unquestionably introduces some bugs, but should get us on the right path. * src/window.c (meta_window_get_work_area_all_xineramas): create this function again as it turned out to be legitimate for window position constraint (adjust_for_gravity): use the width/height from the configure request to compute the requested move (meta_window_move_resize_internal): use meta_window_constrain (update_size_hints): clamp max size to MAXSHORT to avoid worrying about overflow stuff * src/constraints.c (meta_window_constrain): don't base placement on uninitialized variables, general hacking * src/Makefile.am (metacity_SOURCES): add constraints.c, constraints.h * src/constraints.c (meta_window_constrain): update the cut-and-paste aspect ratio code to have latest bugfixes
2003-03-08 23:43:17 +00:00
void
Refer to monitors as "monitors" rather than "xineramas" http://bugzilla.gnome.org/show_bug.cgi?id=593686
2009-08-31 13:52:16 +00:00
meta_window_get_work_area_all_monitors (MetaWindow *window,
MetaRectangle *area)
Switch over to new constraints code, unquestionably introduces some bugs, 2003-02-27 Havoc Pennington <hp@redhat.com> Switch over to new constraints code, unquestionably introduces some bugs, but should get us on the right path. * src/window.c (meta_window_get_work_area_all_xineramas): create this function again as it turned out to be legitimate for window position constraint (adjust_for_gravity): use the width/height from the configure request to compute the requested move (meta_window_move_resize_internal): use meta_window_constrain (update_size_hints): clamp max size to MAXSHORT to avoid worrying about overflow stuff * src/constraints.c (meta_window_constrain): don't base placement on uninitialized variables, general hacking * src/Makefile.am (metacity_SOURCES): add constraints.c, constraints.h * src/constraints.c (meta_window_constrain): update the cut-and-paste aspect ratio code to have latest bugfixes
2003-03-08 23:43:17 +00:00
{
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
GList *tmp;
Use MetaMonitorManager insted of MetaDisplay where possible This drops display's monitors-changed signal and makes all the code rely on MetaMonitorManager. https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 18:44:38 +00:00
MetaRectangle display_rect = { 0 };
meta_display_get_size (window->display,
&display_rect.width,
&display_rect.height);
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
Move screen size and cursor setting to MetaDisplay Split X11 specific parts into MetaX11Display. This also required changing MetaScreen to stop listening to any signals by itself, but instead relying on MetaDisplay forwarding them. This was to ensure the ordering. MetaDisplay listens to both the internal and external monitors-changed signal so that it can pass the external one via the redundant MetaDisplay(prev MetaScreen)::monitors-changed. https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 16:37:29 +00:00
/* Initialize to the whole display */
Use MetaMonitorManager insted of MetaDisplay where possible This drops display's monitors-changed signal and makes all the code rely on MetaMonitorManager. https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 18:44:38 +00:00
*area = display_rect;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
tmp = meta_window_get_workspaces (window);
Switch over to new constraints code, unquestionably introduces some bugs, 2003-02-27 Havoc Pennington <hp@redhat.com> Switch over to new constraints code, unquestionably introduces some bugs, but should get us on the right path. * src/window.c (meta_window_get_work_area_all_xineramas): create this function again as it turned out to be legitimate for window position constraint (adjust_for_gravity): use the width/height from the configure request to compute the requested move (meta_window_move_resize_internal): use meta_window_constrain (update_size_hints): clamp max size to MAXSHORT to avoid worrying about overflow stuff * src/constraints.c (meta_window_constrain): don't base placement on uninitialized variables, general hacking * src/Makefile.am (metacity_SOURCES): add constraints.c, constraints.h * src/constraints.c (meta_window_constrain): update the cut-and-paste aspect ratio code to have latest bugfixes
2003-03-08 23:43:17 +00:00
while (tmp != NULL)
{
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
MetaRectangle workspace_work_area;
Refer to monitors as "monitors" rather than "xineramas" http://bugzilla.gnome.org/show_bug.cgi?id=593686
2009-08-31 13:52:16 +00:00
meta_workspace_get_work_area_all_monitors (tmp->data,
&workspace_work_area);
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
meta_rectangle_intersect (area,
&workspace_work_area,
area);
Switch over to new constraints code, unquestionably introduces some bugs, 2003-02-27 Havoc Pennington <hp@redhat.com> Switch over to new constraints code, unquestionably introduces some bugs, but should get us on the right path. * src/window.c (meta_window_get_work_area_all_xineramas): create this function again as it turned out to be legitimate for window position constraint (adjust_for_gravity): use the width/height from the configure request to compute the requested move (meta_window_move_resize_internal): use meta_window_constrain (update_size_hints): clamp max size to MAXSHORT to avoid worrying about overflow stuff * src/constraints.c (meta_window_constrain): don't base placement on uninitialized variables, general hacking * src/Makefile.am (metacity_SOURCES): add constraints.c, constraints.h * src/constraints.c (meta_window_constrain): update the cut-and-paste aspect ratio code to have latest bugfixes
2003-03-08 23:43:17 +00:00
tmp = tmp->next;
}
meta_topic (META_DEBUG_WORKAREA,
"Window %s has whole-screen work area %d,%d %d x %d\n",
window->desc, area->x, area->y, area->width, area->height);
Patch from Rob Adams addresses #95014 (placement issues), makes first fit 2003-02-23 Havoc Pennington <hp@pobox.com> Patch from Rob Adams addresses #95014 (placement issues), makes first fit algorithm "center tile", adds most code for per-xinerama workspaces (#86682) but disables it for now. * src/workspace.c (meta_workspace_get_work_area_for_xinerama) (meta_workspace_get_work_area_all_xineramas): new xinerama functions, maintain workspace->work_areas with a different work area for each xinerama. However for now all the work areas are the same, because haven't quite figured out how _NET_WM_STRUT is supposed to work * src/window.c: adapt to new meta_window_* xinerama APIs (meta_window_get_work_area_current_xinerama): new xinerama API (meta_window_get_work_area_for_xinerama): new xinerama API (constrain_position): be a bit more clever about which xinerama's work area we choose to use. * src/stack.c: adapt to new Xinerama API * src/screen.c (reload_xinerama_infos): invalidate all work areas (meta_screen_get_xinerama_for_rect): new function (meta_screen_window_intersects_xinerama): new function * src/place.c (find_first_fit): change to use "center tiling" (center a screen full of tiled windows, rather than aligning them top left). Adapt to new xinerama functions.
2003-02-23 17:09:46 +00:00
}
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
int
meta_window_get_current_tile_monitor_number (MetaWindow *window)
{
int tile_monitor_number = window->tile_monitor_number;
if (tile_monitor_number < 0)
{
meta_warning ("%s called with an invalid monitor number; using 0 instead\n", G_STRFUNC);
tile_monitor_number = 0;
}
return tile_monitor_number;
}
void
window: Split out preview_tile_mode The existing semantics of the tile_mode property are terribly confusing, as it depends on some other property whether it represents the requested or current mode. Clear this up by just using separate variables for the two. As it is unlikely that we will ever support more than one tile preview, we can track the requested mode globally instead of adding another per-window variable. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-09-27 12:53:54 +00:00
meta_window_get_tile_area (MetaWindow *window,
MetaTileMode tile_mode,
MetaRectangle *tile_area)
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
{
window: Allow resizing of tiled windows Currently tiled windows are not resizable and their size is fixed to half the screen width. Adjust the code to work with fractions other than half, and allow users to adjust the split by dragging the window edge that is not constrained by a monitor edge. Follow-up patches will improve on that by resizing neighboring tiled windows by a shared edge, and making the functionality available to client-side decorated windows implementing the new edge constraints protocol.
2017-09-27 12:37:57 +00:00
MetaRectangle work_area;
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
int tile_monitor_number;
window: Allow resizing of tiled windows Currently tiled windows are not resizable and their size is fixed to half the screen width. Adjust the code to work with fractions other than half, and allow users to adjust the split by dragging the window edge that is not constrained by a monitor edge. Follow-up patches will improve on that by resizing neighboring tiled windows by a shared edge, and making the functionality available to client-side decorated windows implementing the new edge constraints protocol.
2017-09-27 12:37:57 +00:00
double fraction;
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
window: Split out preview_tile_mode The existing semantics of the tile_mode property are terribly confusing, as it depends on some other property whether it represents the requested or current mode. Clear this up by just using separate variables for the two. As it is unlikely that we will ever support more than one tile preview, we can track the requested mode globally instead of adding another per-window variable. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-09-27 12:53:54 +00:00
g_return_if_fail (tile_mode != META_TILE_NONE);
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
tile_monitor_number = meta_window_get_current_tile_monitor_number (window);
window: Allow resizing of tiled windows Currently tiled windows are not resizable and their size is fixed to half the screen width. Adjust the code to work with fractions other than half, and allow users to adjust the split by dragging the window edge that is not constrained by a monitor edge. Follow-up patches will improve on that by resizing neighboring tiled windows by a shared edge, and making the functionality available to client-side decorated windows implementing the new edge constraints protocol.
2017-09-27 12:37:57 +00:00
meta_window_get_work_area_for_monitor (window, tile_monitor_number, &work_area);
meta_window_get_tile_fraction (window, tile_mode, &fraction);
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
window: Allow resizing of tiled windows Currently tiled windows are not resizable and their size is fixed to half the screen width. Adjust the code to work with fractions other than half, and allow users to adjust the split by dragging the window edge that is not constrained by a monitor edge. Follow-up patches will improve on that by resizing neighboring tiled windows by a shared edge, and making the functionality available to client-side decorated windows implementing the new edge constraints protocol.
2017-09-27 12:37:57 +00:00
*tile_area = work_area;
tile_area->width = round (tile_area->width * fraction);
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
window: Split out preview_tile_mode The existing semantics of the tile_mode property are terribly confusing, as it depends on some other property whether it represents the requested or current mode. Clear this up by just using separate variables for the two. As it is unlikely that we will ever support more than one tile preview, we can track the requested mode globally instead of adding another per-window variable. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-09-27 12:53:54 +00:00
if (tile_mode == META_TILE_RIGHT)
window: Allow resizing of tiled windows Currently tiled windows are not resizable and their size is fixed to half the screen width. Adjust the code to work with fractions other than half, and allow users to adjust the split by dragging the window edge that is not constrained by a monitor edge. Follow-up patches will improve on that by resizing neighboring tiled windows by a shared edge, and making the functionality available to client-side decorated windows implementing the new edge constraints protocol.
2017-09-27 12:37:57 +00:00
tile_area->x += work_area.width - tile_area->width;
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
}
make the check for whether to eat focus click a lot more complicated 2002-01-27 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make the check for whether to eat focus click a lot more complicated * src/window.c (meta_window_same_application): new function * src/prefs.h, src/prefs.c: add application based pref * src/metacity.schemas: add "application_based" setting to give me a mode to fool with being application based, without being unusable in the meantime. Yeah the crack flows freely these days. Everyone knew it would happen.
2002-01-27 05:50:34 +00:00
gboolean
meta_window_same_application (MetaWindow *window,
MetaWindow *other_window)
{
This function can now officially return NULL. Two windows can't belong to 2008-07-12 Thomas Thurman <tthurman@gnome.org> * src/core/group.c (meta_window_get_group): This function can now officially return NULL. * src/core/window.c (meta_window_same_application): Two windows can't belong to the same application unless they both belong to some application. (Both belonging to no application is not the same.) Closes #453022. svn path=/trunk/; revision=3785
2008-07-13 03:26:39 +00:00
MetaGroup *group = meta_window_get_group (window);
MetaGroup *other_group = meta_window_get_group (other_window);
lengthen to 15 seconds 2002-11-30 Havoc Pennington <hp@pobox.com> * src/screen.c (STARTUP_TIMEOUT): lengthen to 15 seconds * src/util.c (utf8_fputs): hmm, return a value * src/screen.c (meta_screen_apply_startup_properties): new function to apply initial workspace based on startup sequence. * src/window.c (meta_window_new): load _NET_STARTUP_ID (meta_window_get_startup_id): new function * src/window-props.c (meta_display_init_window_prop_hooks): add hooks for _NET_STARTUP_ID * src/display.c (event_callback): send property events to groups. * src/xprops.c (meta_prop_get_values): make a type of INVALID mean to ignore that property (don't fetch its value). * src/group.c (meta_group_property_notify): new function * src/screen.c (set_supported_hint): support _NET_STARTUP_ID * src/display.c (meta_display_open): add _NET_STARTUP_ID to atoms we initialize * src/group-private.h: private header shared between group-props.c, group.c * src/group-props.h, src/group-props.c: new files to contain functions for retrieving group properties * src/window.c (meta_window_same_application): change this a bit to work with new definition of group * src/group.c (meta_window_get_group): always create a group for every window, using the window's own ID as group leader if required. * src/window.c (update_wm_hints): handle changes to group leader * src/group.c (meta_window_group_leader_changed): new function * src/display.h (struct _MetaDisplay): _NET_WM_WINDOW_TYPE_SPLASH, not SPLASHSCREEN. Reported by Gregory Merchan and Matthias Clasen. * src/screen.c (startup_sequence_timeout): when timing out a startup sequence, send a remove message, don't just time it out locally.
2002-12-01 03:58:04 +00:00
return
This function can now officially return NULL. Two windows can't belong to 2008-07-12 Thomas Thurman <tthurman@gnome.org> * src/core/group.c (meta_window_get_group): This function can now officially return NULL. * src/core/window.c (meta_window_same_application): Two windows can't belong to the same application unless they both belong to some application. (Both belonging to no application is not the same.) Closes #453022. svn path=/trunk/; revision=3785
2008-07-13 03:26:39 +00:00
group!=NULL &&
other_group!=NULL &&
group==other_group;
make the check for whether to eat focus click a lot more complicated 2002-01-27 Havoc Pennington <hp@pobox.com> * src/display.c (event_callback): make the check for whether to eat focus click a lot more complicated * src/window.c (meta_window_same_application): new function * src/prefs.h, src/prefs.c: add application based pref * src/metacity.schemas: add "application_based" setting to give me a mode to fool with being application based, without being unusable in the meantime. Yeah the crack flows freely these days. Everyone knew it would happen.
2002-01-27 05:50:34 +00:00
}
Add some total crackrock resize-grid indication for windows that have 2002-03-17 Havoc Pennington <hp@pobox.com> * src/resizepopup.c: Add some total crackrock resize-grid indication for windows that have width_inc/height_inc so I can debug gnome-terminal sizing.
2002-03-17 17:22:23 +00:00
Fix identification of CSD windows when checking whether to force fullscreen We try to exempt CSD windows from being forced fullscreen if they are undecorated and the size of the screen; however, we also catch almost all windows that *do* need to be forced fullscreen in this check, since they also have decorations turned off. Identify actual CSD windows by checking whether _GTK_FRAME_EXTENTS is set - GTK+ will always set this on CSD windows even if they have no invisible borders or shadows at the current time. We explicitly turn off the legacy-fullscreen check for native wayland windows so we don't start legacy-fullscreening them if the new meta_window_is_client_decorated() is later made more accurate. https://bugzilla.gnome.org/show_bug.cgi?id=723029
2014-03-06 00:01:11 +00:00
/**
* meta_window_is_client_decorated:
*
* Check if if the window has decorations drawn by the client.
* (window->decorated refers only to whether we should add decorations)
*/
gboolean
meta_window_is_client_decorated (MetaWindow *window)
{
if (window->client_type == META_WINDOW_CLIENT_TYPE_WAYLAND)
{
/* Assume all Wayland clients draw decorations - not strictly
* true but good enough for current purposes.
*/
return TRUE;
}
else
{
/* Currently the implementation here is hackish -
* has_custom_frame_extents() is set if _GTK_FRAME_EXTENTS is set
* to any value even 0. GTK+ always sets _GTK_FRAME_EXTENTS for
* client-side-decorated window, even if the value is 0 because
* the window is maxized and has no invisible borders or shadows.
*/
return window->has_custom_frame_extents;
}
}
Export functions to iterate over window transients https://bugzilla.gnome.org/show_bug.cgi?id=616050
2010-04-24 21:19:25 +00:00
/**
* meta_window_foreach_transient:
* @window: a #MetaWindow
Fix use of (closure) annotation For functions (but not callback types), '(closure)' is used on the callback parameter, and takes the name of the parameter which is the closure/user data.
2010-09-24 15:26:36 +00:00
* @func: (scope call) (closure user_data): Called for each window which is a transient of @window (transitively)
* @user_data: User data
Export functions to iterate over window transients https://bugzilla.gnome.org/show_bug.cgi?id=616050
2010-04-24 21:19:25 +00:00
*
* Call @func for every window which is either transient for @window, or is
* a transient of a window which is in turn transient for @window.
* The order of window enumeration is not defined.
*
* Iteration will stop if @func at any point returns %FALSE.
*/
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
void
meta_window_foreach_transient (MetaWindow *window,
MetaWindowForeachFunc func,
Export functions to iterate over window transients https://bugzilla.gnome.org/show_bug.cgi?id=616050
2010-04-24 21:19:25 +00:00
void *user_data)
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
{
GSList *windows;
GSList *tmp;
meta_display_list_windows: Exclude override-redirect Don't include override-redirect windows in the list return by meta_display_list_windows(), since we almost never want to handle them when considering "all window" for the display. Add a separate meta_display_list_all_windows() that includes override-redirect windows. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-15 19:32:23 +00:00
windows = meta_display_list_windows (window->display, META_LIST_DEFAULT);
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
tmp = windows;
while (tmp != NULL)
{
MetaWindow *transient = tmp->data;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
if (meta_window_is_ancestor_of_transient (window, transient))
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
{
Export functions to iterate over window transients https://bugzilla.gnome.org/show_bug.cgi?id=616050
2010-04-24 21:19:25 +00:00
if (!(* func) (transient, user_data))
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
break;
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
tmp = tmp->next;
}
g_slist_free (windows);
}
Export functions to iterate over window transients https://bugzilla.gnome.org/show_bug.cgi?id=616050
2010-04-24 21:19:25 +00:00
/**
* meta_window_foreach_ancestor:
* @window: a #MetaWindow
Fix use of (closure) annotation For functions (but not callback types), '(closure)' is used on the callback parameter, and takes the name of the parameter which is the closure/user data.
2010-09-24 15:26:36 +00:00
* @func: (scope call) (closure user_data): Called for each window which is a transient parent of @window
* @user_data: User data
Export functions to iterate over window transients https://bugzilla.gnome.org/show_bug.cgi?id=616050
2010-04-24 21:19:25 +00:00
*
* If @window is transient, call @func with the window for which it's transient,
* repeatedly until either we find a non-transient window, or @func returns %FALSE.
*/
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
void
meta_window_foreach_ancestor (MetaWindow *window,
MetaWindowForeachFunc func,
Export functions to iterate over window transients https://bugzilla.gnome.org/show_bug.cgi?id=616050
2010-04-24 21:19:25 +00:00
void *user_data)
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
{
MetaWindow *w;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
w = window;
reload_transient_for: avoid xtransient_for loops Don't set a window's xtransient_for if it would create a loop. Since this is the only place we ever set xtransient_for, we can therefore assume everywhere else that it does not loop. https://bugzilla.gnome.org/show_bug.cgi?id=647712
2011-05-06 09:09:04 +00:00
do
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
{
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
if (w->transient_for == NULL)
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
break;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
w = w->transient_for;
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
}
reload_transient_for: avoid xtransient_for loops Don't set a window's xtransient_for if it would create a loop. Since this is the only place we ever set xtransient_for, we can therefore assume everywhere else that it does not loop. https://bugzilla.gnome.org/show_bug.cgi?id=647712
2011-05-06 09:09:04 +00:00
while (w && (* func) (w, user_data));
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
}
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
typedef struct
{
MetaWindow *ancestor;
gboolean found;
} FindAncestorData;
static gboolean
find_ancestor_func (MetaWindow *window,
void *data)
{
FindAncestorData *d = data;
if (window == d->ancestor)
{
d->found = TRUE;
return FALSE;
}
return TRUE;
}
Added public prototype for meta_window_is_ancestor_of_transient() http://bugzilla.gnome.org/show_bug.cgi?id=590439
2009-08-04 07:32:36 +00:00
/**
* meta_window_is_ancestor_of_transient:
* @window: a #MetaWindow
* @transient: a #MetaWindow
*
* The function determines whether @window is an ancestor of @transient; it does
* so by traversing the @transient's ancestors until it either locates @window
* or reaches an ancestor that is not transient.
*
window: Remove invalid (transfer) annnotations This tripped a new g-i warning; see https://bugzilla.gnome.org/show_bug.cgi?id=752047
2015-09-27 20:42:01 +00:00
* Return Value: %TRUE if window is an ancestor of transient.
Added public prototype for meta_window_is_ancestor_of_transient() http://bugzilla.gnome.org/show_bug.cgi?id=590439
2009-08-04 07:32:36 +00:00
*/
Should fix #108108, #106217, tracked down by Owen Taylor and Frederic 2003-03-11 Havoc Pennington <hp@pobox.com> Should fix #108108, #106217, tracked down by Owen Taylor and Frederic Crozat * src/window.c (meta_window_foreach_transient): change MetaWindowForeachFunc to return a boolean for whether to continue (meta_window_foreach_ancestor): new function (window_should_be_showing): use meta_window_foreach_ancestor (unminimize_window_and_all_transient_parents): ditto (update_sm_hints): ditto (meta_window_is_ancestor_of_transient): ditto * src/stack.c (get_maximum_layer_of_ancestor): use meta_window_foreach_ancestor
2003-03-17 06:36:39 +00:00
gboolean
meta_window_is_ancestor_of_transient (MetaWindow *window,
MetaWindow *transient)
{
FindAncestorData d;
d.ancestor = window;
d.found = FALSE;
meta_window_foreach_ancestor (transient, find_ancestor_func, &d);
return d.found;
on unminimize, queue calc_showing on all transients 2002-05-05 Havoc Pennington <hp@pobox.com> * src/window.c (meta_window_unminimize): on unminimize, queue calc_showing on all transients (meta_window_activate): on activate, unminimize all a window's ancestors, not just the window itself. * src/workspace.c (set_work_area_hint): don't increment "tmp" by 16 unsigned long, increment by 4 * src/window.c (meta_window_free): if a window isn't minimized, restore its WM_STATE to NormalState instead of IconicState, since IconicState on initial window map means that the window should be minimized. * src/workspace.c (meta_workspace_invalidate_work_area): queue an idle to recompute the work area hint. (set_work_area_hint): we need 4*num_workspaces ints, not just num_workspaces. * src/screen.c (meta_screen_new): add work_area_idle field, handle it on screen shutdown * src/common.h (META_PRIORITY_PREFS_NOTIFY, META_PRIORITY_WORK_AREA_HINT): define some idle priorities * src/window.c (meta_window_calc_showing): hide windows if their parent window is minimized (meta_window_minimize): also queue_calc_showing on all transients of the window being minimized * src/place.c (constrain_placement): function to apply placement-time-only constraints, such as "not off the left of the screen" (meta_window_place): put dialogs down a bit over their parent, not right at the top. (meta_window_place): when centering a dialog, center it on the current xinerama screen, rather than the entire screen. * src/screen.c (meta_screen_get_current_xinerama): new function, but not implemented
2002-05-05 05:41:13 +00:00
}
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
/* Warp pointer to location appropriate for grab,
* return root coordinates where pointer ended up.
*/
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
static gboolean
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
warp_grab_pointer (MetaWindow *window,
MetaGrabOp grab_op,
int *x,
int *y)
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
{
Use MetaMonitorManager insted of MetaDisplay where possible This drops display's monitors-changed signal and makes all the code rely on MetaMonitorManager. https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 18:44:38 +00:00
MetaRectangle rect;
MetaRectangle display_rect = { 0 };
MetaDisplay *display;
Fix move/resize events in relation to combinations of ConfigureRequest and 2007-04-08 Elijah Newren <newren gmail com> Fix move/resize events in relation to combinations of ConfigureRequest and WM_NORMAL_HINTS change notifications (plus a few code cleanups). Fixes #426519. * src/window.c (meta_window_move_resize_now): move to the user_rect position, not some weird combination of rect and user_rect * src/window.c (meta_window_configure_request): set user_rect in response to ConfigureRequest events (after the ConfigureRequest values have been constrained) and add a big comment explaining this change, remove unused only_resize variable and irrelevant huge FIXME comment about it * src/window.[ch] (meta_window_get_client_root_coords): new function * src/display.c (meta_display_begin_grab_op): * src/keybindings.c (process_keyboard_move_grab): * src/window.c (meta_window_unmaximize, meta_window_move_resize_internal, meta_window_begin_wireframe, update_move, meta_window_refresh_resize_popup, warp_grab_pointer) combine multi-step client rect root coord setting into a single function call to meta_window_get_client_root_coords() svn path=/trunk/; revision=3181
2007-04-09 03:43:55 +00:00
display = window->display;
Use MetaMonitorManager insted of MetaDisplay where possible This drops display's monitors-changed signal and makes all the code rely on MetaMonitorManager. https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 18:44:38 +00:00
meta_display_get_size (display,
&display_rect.width,
&display_rect.height);
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
/* We may not have done begin_grab_op yet, i.e. may not be in a grab
*/
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Rename meta_window_get_outer_rect() to meta_window_get_frame_rect() For clarity, rename meta_window_get_outer_rect() to match terminology we use elsewhere. The old function is left as a deprecated compatibility wrapper.
2013-11-19 17:24:45 +00:00
meta_window_get_frame_rect (window, &rect);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
common: Create a better encoding for MetaGrabOp MetaGrabOp is painful and tedious to work with, because it's a sequential series of values, meaning we have to use a giant unreadable switch statement to figure out some basic things about the value. To solve this, modify the encoding for MetaGrabOp and for the specific window grab operations so that they're a set of bitflags that we can easily check.
2014-08-15 18:05:04 +00:00
if (grab_op & META_GRAB_OP_WINDOW_DIR_WEST)
*x = 0;
else if (grab_op & META_GRAB_OP_WINDOW_DIR_EAST)
*x = rect.width - 1;
else
*x = rect.width / 2;
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
window: Fix the north/south cursor position when keyboard resizing We got these backwards...
2014-08-19 19:01:44 +00:00
if (grab_op & META_GRAB_OP_WINDOW_DIR_NORTH)
common: Create a better encoding for MetaGrabOp MetaGrabOp is painful and tedious to work with, because it's a sequential series of values, meaning we have to use a giant unreadable switch statement to figure out some basic things about the value. To solve this, modify the encoding for MetaGrabOp and for the specific window grab operations so that they're a set of bitflags that we can easily check.
2014-08-15 18:05:04 +00:00
*y = 0;
window: Fix the north/south cursor position when keyboard resizing We got these backwards...
2014-08-19 19:01:44 +00:00
else if (grab_op & META_GRAB_OP_WINDOW_DIR_SOUTH)
common: Create a better encoding for MetaGrabOp MetaGrabOp is painful and tedious to work with, because it's a sequential series of values, meaning we have to use a giant unreadable switch statement to figure out some basic things about the value. To solve this, modify the encoding for MetaGrabOp and for the specific window grab operations so that they're a set of bitflags that we can easily check.
2014-08-15 18:05:04 +00:00
*y = rect.height - 1;
else
*y = rect.height / 2;
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
*x += rect.x;
*y += rect.y;
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
/* Avoid weird bouncing at the screen edge; see bug 154706 */
Use MetaMonitorManager insted of MetaDisplay where possible This drops display's monitors-changed signal and makes all the code rely on MetaMonitorManager. https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 18:44:38 +00:00
*x = CLAMP (*x, 0, display_rect.width - 1);
*y = CLAMP (*y, 0, display_rect.height - 1);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Rename errors.[ch] to meta-x11-errors.[ch] Also rename meta_error_trap_* to meta_x11_error_trap_* and move meta-x11-errors.c to src/x11 https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 18:48:55 +00:00
meta_x11_error_trap_push (display->x11_display);
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
meta_topic (META_DEBUG_WINDOW_OPS,
"Warping pointer to %d,%d with window at %d,%d\n",
*x, *y, rect.x, rect.y);
Merge of all the changes on the constraints_experiments branch. This is 2005-11-18 Elijah Newren <newren@gmail.com> Merge of all the changes on the constraints_experiments branch. This is just a summary, to get the full ChangeLog of those changes (approx. 2000 lines): cvs -q -z3 update -Pd -r constraints_experiments cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog Bugs fixed: unfiled - constraints.c is overly complicated[1] unfiled - constraints.c is not robust when all constraints cannot simultaneously be met (constraints need to be prioritized) unfiled - keep-titlebar-onscreen constraint is decoration unaware (since get_outermost_onscreen_positions() forgets to include decorations) unfiled - keyboard snap-moving and snap-resizing snap to hidden edges 109553 - gravity w/ simultaneous move & resize doesn't work 113601 - maximize vertical and horizontal should toggle and be constrained 122196 - windows show up under vertical panels 122670 - jerky/random resizing of window via keyboard[2] 124582 - keyboard and mouse snap-resizing and snap-moving erroneously moves the window multidimensionally 136307 - don't allow apps to resize themselves off the screen (*cough* filechooser *cough*) 142016, 143784 - windows should not span multiple xineramas unless placed there by the user 143145 - clamp new windows to screensize and force them onscreen, if they'll fit 144126 - Handle pathological strut lists sanely[3] 149867 - fixed aspect ratio windows are difficult to resize[4] 152898 - make screen edges consistent; allow easy slamming of windows into the left, right, and bottom edges of the screen too. 154706 - bouncing weirdness at screen edge with keyboard moving or resizing 156699 - avoid struts when placing windows, if possible (nasty a11y blocker) 302456 - dragging offscreen too restrictive 304857 - wireframe moving off the top of the screen is misleading 308521 - make uni-directional resizing easier with alt-middle-drag and prevent the occasional super annoying resize-the-wrong-side(s) behavior 312007 - snap-resize moves windows with a minimum size constraint 312104 - resizing the top of a window can cause the bottom to grow 319351 - don't instantly snap on mouse-move-snapping, remove braindeadedness of having order of releasing shift and releasing button press matter so much [1] fixed in my opinion, anyway. [2] Actually, it's not totally fixed--it's just annoying instead of almost completely unusable. Matthias had a suggestion that may fix the remainder of the problems (see http://tinyurl.com/bwzuu). [3] This bug was originally about not-quite-so-pathological cases but was left open for the worse cases. The code from the branch handles the remainder of the cases mentioned in this bug. [4] Actually, although it's far better there's still some minor issues left: a slight drift that's only noticeable after lots of resizing, and potential problems with partially onscreen constraints due to not clearing any fixed_directions flags (aspect ratio windows get resized in both directions and thus aren't fixed in one of them) New feature: 81704 - edge resistance for user move and resize operations; in particular 3 different kinds of resistance are implemented: Pixel-Distance: window movement is resisted when it aligns with an edge unless the movement is greater than a threshold number of pixels Timeout: window movement past an edge is prevented until a certain amount of time has elapsed during the operation since the first request to move it past that edge Keyboard-Buildup: when moving or resizing with the keyboard, once a window is aligned with a certain edge it cannot move past until the correct direction has been pressed enough times (e.g. 2 or 3 times) Major changes: - constraints.c has been rewritten; very few lines of code from the old version remain. There is a comment near the top of the function explaining the basics of how the new framework works. A more detailed explanation can be found in doc/how-constraints-works.txt - edge-resistance.[ch] are new files implementing edge-resistance. - boxes.[ch] are new files containing low-level error-prone functions used heavily in constraints.c and edge-resistance.c, among various places throughout the code. testboxes.c contains a thorough testsuite for the boxes.[ch] functions compiled into a program, testboxes. - meta_window_move_resize_internal() *must* be told the gravity of the associated operation (if it's just a move operation, the gravity will be ignored, but for resize and move+resize the correct value is needed) - the craziness of different values that meta_window_move_resize_internal() accepts has been documented in a large comment at the beginning of the function. It may be possible to clean this up some, but until then things will remain as they were before--caller beware. - screen and xinerama usable areas (i.e. places not covered by e.g. panels) are cached in the workspace now, as are the screen and xinerama edges. These get updated with the workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 14:58:50 +00:00
/* Need to update the grab positions so that the MotionNotify and other
* events generated by the XWarpPointer() call below don't cause complete
* funkiness. See bug 124582 and bug 122670.
*/
Fix move/resize events in relation to combinations of ConfigureRequest and 2007-04-08 Elijah Newren <newren gmail com> Fix move/resize events in relation to combinations of ConfigureRequest and WM_NORMAL_HINTS change notifications (plus a few code cleanups). Fixes #426519. * src/window.c (meta_window_move_resize_now): move to the user_rect position, not some weird combination of rect and user_rect * src/window.c (meta_window_configure_request): set user_rect in response to ConfigureRequest events (after the ConfigureRequest values have been constrained) and add a big comment explaining this change, remove unused only_resize variable and irrelevant huge FIXME comment about it * src/window.[ch] (meta_window_get_client_root_coords): new function * src/display.c (meta_display_begin_grab_op): * src/keybindings.c (process_keyboard_move_grab): * src/window.c (meta_window_unmaximize, meta_window_move_resize_internal, meta_window_begin_wireframe, update_move, meta_window_refresh_resize_popup, warp_grab_pointer) combine multi-step client rect root coord setting into a single function call to meta_window_get_client_root_coords() svn path=/trunk/; revision=3181
2007-04-09 03:43:55 +00:00
display->grab_anchor_root_x = *x;
display->grab_anchor_root_y = *y;
display->grab_latest_motion_x = *x;
display->grab_latest_motion_y = *y;
window: Correct the anchoring of drag moving / resizing Now that meta_window_move_resize and friends act in frame rect coordinates, we need to convert the initial grab_anchor_window_pos storage to be in frame rect coordinates as well.
2014-05-21 13:08:39 +00:00
meta_window_get_frame_rect (window,
&display->grab_anchor_window_pos);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
backend: Add an XIWarpPointer wrapper This makes Alt+F7 / Alt+F8 work respectively under X11 nested mode. For the native backend implementation, we'll need a special Clutter function, so don't implement that for now.
2014-05-27 18:11:23 +00:00
{
backends: Move warp_pointer() to ClutterSeat The onscreen pointer sprite is a per-seat element, so it makes sense to move pointer warping over there too. https://gitlab.gnome.org/GNOME/mutter/merge_requests/852
2019-10-09 16:01:34 +00:00
ClutterSeat *seat;
seat = clutter_backend_get_default_seat (clutter_get_default_backend ());
clutter_seat_warp_pointer (seat, *x, *y);
backend: Add an XIWarpPointer wrapper This makes Alt+F7 / Alt+F8 work respectively under X11 nested mode. For the native backend implementation, we'll need a special Clutter function, so don't implement that for now.
2014-05-27 18:11:23 +00:00
}
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
Rename errors.[ch] to meta-x11-errors.[ch] Also rename meta_error_trap_* to meta_x11_error_trap_* and move meta-x11-errors.c to src/x11 https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 18:48:55 +00:00
if (meta_x11_error_trap_pop_with_return (display->x11_display) != Success)
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
{
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
meta_verbose ("Failed to warp pointer for window %s\n",
window->desc);
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
return FALSE;
}
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
return TRUE;
}
void
meta_window_begin_grab_op (MetaWindow *window,
MetaGrabOp op,
Fix cases when titlebar is allowed offscreen and shouldn't be (and 2006-10-13 Carlo Wood <carlo@alinoe.com> Fix cases when titlebar is allowed offscreen and shouldn't be (and vice-versa). #333995. * src/display.[ch] (struct _MetaDisplay): add grab_frame_action member * src/display.[ch] (meta_display_begin_grab_op): * src/window.[ch] (meta_window_begin_grab_op): * src/core.[ch] (meta_core_begin_grab_op): Add frame_action parameter (core & window versions pass it on to display) * src/display.c (event_callback): * src/window.c (meta_window_begin_grab_op, meta_window_client_message, menu_callback): * frames.c (meta_frames_button_press_event): * keybindings.c (do_choose_window, handle_begin_move, handle_begin_resize, handle_workspace_switch): Pass whether the action should be considered a 'frame_action', which will be used to determine whether to force the titlebar to remain onscreen, to meta_*_begin_grab_op * constraints.c (constrain_titlebar_visible): Replace previous ugly hack by using grab_frame_action (and whether the action is a user action) to determine whether to enforce the titlebar_visible constraint.
2006-10-13 00:28:34 +00:00
gboolean frame_action,
Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ 2006-09-13 Elijah Newren <newren gmail com> * src/common.h (MetaWindowMenuFunc): * src/core.[ch] (meta_core_user_lower_and_unfocus, meta_core_user_focus, meta_core_show_window_menu, meta_core_begin_grab_op, meta_core_end_grab_op): * src/delete.c (delete_ping_reply_func, delete_ping_timeout_func, meta_window_delete): * src/display.[ch] (struct MetaDisplay, struct MetaPingData, sanity_check_timestamps, meta_display_open, event_callback, meta_spew_event, meta_display_set_grab_op_cursor, meta_display_begin_grab_op, meta_display_end_grab_op, meta_display_ping_timeout, meta_display_ping_window, process_pong_message, timestamp_too_old, meta_display_set_input_focus_window): * src/keybindings.[ch] (grab_keyboard, ungrab_keyboard, meta_screen_grab_all_keys, meta_window_grab_all_keys, meta_window_ungrab_all_keys, error_on_generic_command, error_on_command, error_on_terminal_command): * src/metacity-dialog.c (on_realize, warn_about_no_sm_support, error_about_command, main): * src/screen.[ch] (struct _MetaScreen, meta_screen_new, meta_screen_show_desktop, meta_screen_apply_startup_properties): * src/session.c (warn_about_lame_clients_and_finish_interact): * src/window.[ch] (struct _MetaWindow, intervening_user_event_occurred, window_activate, meta_window_delete, meta_window_focus, meta_window_send_icccm_message, meta_window_client_message, menu_callback, meta_window_show_menu, struct EventScannerData, check_use_this_motion_notify, meta_window_begin_grab_op, meta_window_set_user_time): * src/workspace.[ch] (focus_ancestor_or_mru_window, meta_workspace_activate_with_focus, meta_workspace_activate, meta_workspace_focus_default_window, focus_ancestor_or_mru_window): Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ does) instead of Time. #348305
2006-09-13 16:32:33 +00:00
guint32 timestamp)
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
{
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
int x, y;
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
warp_grab_pointer (window,
op, &x, &y);
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
meta_display_begin_grab_op (window->display,
window,
op,
add an event_serial argument and use it when the pointer is already 2003-11-24 Havoc Pennington <hp@redhat.com> * src/display.c (meta_display_begin_grab_op): add an event_serial argument and use it when the pointer is already grabbed automatically on the button press. May fix bug #126871
2003-11-24 18:09:47 +00:00
FALSE,
Fix cases when titlebar is allowed offscreen and shouldn't be (and 2006-10-13 Carlo Wood <carlo@alinoe.com> Fix cases when titlebar is allowed offscreen and shouldn't be (and vice-versa). #333995. * src/display.[ch] (struct _MetaDisplay): add grab_frame_action member * src/display.[ch] (meta_display_begin_grab_op): * src/window.[ch] (meta_window_begin_grab_op): * src/core.[ch] (meta_core_begin_grab_op): Add frame_action parameter (core & window versions pass it on to display) * src/display.c (event_callback): * src/window.c (meta_window_begin_grab_op, meta_window_client_message, menu_callback): * frames.c (meta_frames_button_press_event): * keybindings.c (do_choose_window, handle_begin_move, handle_begin_resize, handle_workspace_switch): Pass whether the action should be considered a 'frame_action', which will be used to determine whether to force the titlebar to remain onscreen, to meta_*_begin_grab_op * constraints.c (constrain_titlebar_visible): Replace previous ugly hack by using grab_frame_action (and whether the action is a user action) to determine whether to enforce the titlebar_visible constraint.
2006-10-13 00:28:34 +00:00
frame_action,
add an event_serial argument and use it when the pointer is already 2003-11-24 Havoc Pennington <hp@redhat.com> * src/display.c (meta_display_begin_grab_op): add an event_serial argument and use it when the pointer is already grabbed automatically on the button press. May fix bug #126871
2003-11-24 18:09:47 +00:00
0 /* button */,
0,
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
timestamp,
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
x, y);
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
}
new function 2002-09-24 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_update_layer): new function * src/stack.c (compute_layer): put focused window in a layer above all other windows, in click-to-focus mode. #93022 * src/window.c (meta_window_notify_focus): update window layer on focus change.
2002-09-24 21:22:06 +00:00
void
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
meta_window_update_keyboard_resize (MetaWindow *window,
gboolean update_cursor)
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
{
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
int x, y;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
warp_grab_pointer (window,
window->display->grab_op,
&x, &y);
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
if (update_cursor)
display: Replace set_grab_op_cursor with update_cursor Now that we don't have to regrab to change the cursor, since it's simply the cursor on the root window, all we have to do is update the cursor on the screen.
2014-05-14 13:16:20 +00:00
meta_display_update_cursor (window->display);
Patch to provide extra cues to the user when using window menu move and 2002-08-08 Craig Black <blackc@speakeasy.net> Patch to provide extra cues to the user when using window menu move and resize, #85724. * src/common.h: add new cursors * src/display.c: (grab_op_is_mouse) (meta_display_create_x_cursor), (xcursor_for_op), (meta_display_set_grab_op_cursor), (meta_display_begin_grab_op): The keyboard move and resize grab ops now also use the mouse. Allow the grab cursor to be changed during the grab op. Hold onto the initial grab position in case of reset. * src/display.h: save the initial grab position * src/keybindings.c: (process_keyboard_move_grab), (process_keyboard_resize_grab), (handle_begin_move), (handle_begin_resize): The keyboard move and resize grab ops now also use the mouse. * src/window.c: (meta_window_client_message), (menu_callback), (update_move), (update_resize), (meta_window_handle_mouse_grab_op_event), (warp_pointer), (meta_window_warp_pointer), (meta_window_begin_grab_op), (meta_window_update_resize_grab_op): When moving or resizing a window use the last grab position in computing change increment. Provide support for warping the mouse pointer. * src/window.h: new warp pointer and grab op helper functions
2002-08-09 04:27:23 +00:00
}
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
void
meta_window_update_keyboard_move (MetaWindow *window)
{
int x, y;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Merge reduced_resources mode patch from the branch. Offers wireframe and 2003-10-12 Havoc Pennington <hp@redhat.com> Merge reduced_resources mode patch from the branch. Offers wireframe and no-animations. * src/window.c (implement_showing): no animation if we are in reduced resources mode * src/prefs.c: add REDUCED_RESOURCES pref * src/window.c (meta_window_update_keyboard_resize): fix to modify grab_anchor_window_pos to grab_wireframe_rect if appropriate instead of window->rect * src/display.h (struct _MetaDisplay): add grab_start_serial used to avoid responding to events that occurred prior to the grab initialization. Still broken in various ways, specifically EnterNotify that occurred prior to XGrabPointer is processed as if it occurred after. * src/window.c (meta_window_update_keyboard_move): add this instead of meta_window_warp_pointer() crack * src/effects.c (meta_effects_update_wireframe): draw a kind of grid for the wireframe, instead of just a rectangle, like twm * src/screen.c (meta_screen_new): line width of 3 for the XOR gc "Reduced resources" mode based on wireframe patch from Erwann Chenede. Still pretty buggy. * src/keybindings.c (process_keyboard_move_grab) (process_keyboard_resize_grab): add gruesome wireframe hacks * src/display.c (meta_display_end_grab_op): end wireframe (meta_display_begin_grab_op): begin wireframe * src/effects.c (meta_effects_end_wireframe) (meta_effects_update_wireframe, meta_effects_begin_wireframe): routines to draw the wireframe stuff * src/window.c (window_should_be_showing): hide window when doing wireframe, commented out as it breaks grab * src/window.c (meta_window_refresh_resize_popup): handle wireframe * src/screen.c (meta_screen_new): create a screen->root_xor_gc for use in drawing wireframes * src/frames.c (meta_frames_push_delay_exposes): repaint everything before we delay
2003-10-12 06:25:38 +00:00
warp_grab_pointer (window,
window->display->grab_op,
&x, &y);
}
window: Add get_default_layer() helper Most of the layer computation that the stack does actually depends on the windowing backend, so we will move it to a vfunc. However before we do that, split out the bit that will be shared. https://gitlab.gnome.org/GNOME/mutter/merge_requests/949
2019-11-26 20:01:37 +00:00
MetaStackLayer
meta_window_get_default_layer (MetaWindow *window)
{
if (window->wm_state_below)
return META_LAYER_BOTTOM;
else if (window->wm_state_above && !META_WINDOW_MAXIMIZED (window))
return META_LAYER_TOP;
else
return META_LAYER_NORMAL;
}
new function 2002-09-24 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_update_layer): new function * src/stack.c (compute_layer): put focused window in a layer above all other windows, in click-to-focus mode. #93022 * src/window.c (meta_window_notify_focus): update window layer on focus change.
2002-09-24 21:22:06 +00:00
void
meta_window_update_layer (MetaWindow *window)
{
MetaGroup *group;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_freeze (window->display->stack);
new function 2002-09-24 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_update_layer): new function * src/stack.c (compute_layer): put focused window in a layer above all other windows, in click-to-focus mode. #93022 * src/window.c (meta_window_notify_focus): update window layer on focus change.
2002-09-24 21:22:06 +00:00
group = meta_window_get_group (window);
Re-works the approach to supporting live preview to handle stacking. We can't easily use a metacity layer to hide windows as that means we loose our original stacking position. (Metacity's stack positions are only valid within a single layer) We now have a "guard window" per screen that is a fullscreen override redirect that is lowered to the bottom of the stack. Hidden windows now remain in their original layer so the stacking position remains valid, but all hidden windows get XRestacked under the guard window. A new compositor hook is also added to inform it when a window becomes hidden/unhidded, this lets us map/unmap the corresponding actor. missing files in preview commit (TODO: rebase -i and squash this later)
2008-11-03 14:50:22 +00:00
if (group)
new function 2002-09-24 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_update_layer): new function * src/stack.c (compute_layer): put focused window in a layer above all other windows, in click-to-focus mode. #93022 * src/window.c (meta_window_notify_focus): update window layer on focus change.
2002-09-24 21:22:06 +00:00
meta_group_update_layers (group);
else
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_update_layer (window->display->stack, window);
meta_stack_thaw (window->display->stack);
new function 2002-09-24 Havoc Pennington <hp@redhat.com> * src/window.c (meta_window_update_layer): new function * src/stack.c (compute_layer): put focused window in a layer above all other windows, in click-to-focus mode. #93022 * src/window.c (meta_window_notify_focus): update window layer on focus change.
2002-09-24 21:22:06 +00:00
}
Add support for _NET_WM_USER_TIME 2004-06-17 Elijah Newren <newren@math.utah.edu> Add support for _NET_WM_USER_TIME * src/display.c: (meta_display_open): Add _NET_WM_USER_TIME to atom_names[], (event_callback): Manually set _NET_WM_USER_TIME upon KeyPress (doesn't work since keyboard isn't grabbed) and ButtonPress (does work), this is just a fallback for applications that don't update this themselves. * src/display.h: (struct _MetaDisplay): Add atom_net_wm_user_time field * src/screen.c: (meta_screen_apply_startup_properties): Check for TIMESTAMP provided from startup sequence as well. * src/stack.c: s/meta_window_set_stack_position/meta_window_set_stack_position_no_sync/, (meta_window_set_stack_position): New function which calls the meta_window_set_stack_position_no_sync function followed immediately by calling meta_stack_sync_to_server. * src/window-props.c: (init_net_wm_user_time), (reload_net_wm_user_time): new functions, (reload_wm_hints): also load atom_net_wm_user_time * src/window.c: new XSERVER_TIME_IS_LATER macro (accounts for timestamp wraparound), (meta_window_new_with_attrs): add timestamp attributes, (window_takes_focus_on_map): use TIMESTAMP from startup notification and _NET_WM_USER_TIME to decide whether to focus new windows, (meta_window_show): if app doesn't take focus on map, place it just below the focused window in the stack (process_property_notify): check for changes to _NET_WM_USRE_TIME, (meta_window_stack_just_below): new function * src/window.h: (_MetaWindow struct): new fields for initial_timestamp, initial_timestamp_set, net_wm_user_time_set, and net_wm_user_time, (meta_window_stack_just_below): new function
2004-06-24 15:47:05 +00:00
Have newly mapped windows that are denied focus appear after the focused 2004-08-05 Elijah Newren <newren@math.utah.edu> Have newly mapped windows that are denied focus appear after the focused window in the alt-tab list. This allows one to switch to such a window with a single alt-tab press. * src/window.c (ensure_mru_position_after): new function, (meta_window_show): If newly mapped window is denied focus, call ensure_mru_position_after to make the window appear after the focus window in the mru list.
2004-08-05 17:48:39 +00:00
/* ensure_mru_position_after ensures that window appears after
* below_this_one in the active_workspace's mru_list (i.e. it treats
* window as having been less recently used than below_this_one)
*/
static void
ensure_mru_position_after (MetaWindow *window,
MetaWindow *after_this_one)
{
/* This is sort of slow since it runs through the entire list more
* than once (especially considering the fact that we expect the
* windows of interest to be the first two elements in the list),
* but it doesn't matter while we're only using it on new window
* map.
*/
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
Have newly mapped windows that are denied focus appear after the focused 2004-08-05 Elijah Newren <newren@math.utah.edu> Have newly mapped windows that are denied focus appear after the focused window in the alt-tab list. This allows one to switch to such a window with a single alt-tab press. * src/window.c (ensure_mru_position_after): new function, (meta_window_show): If newly mapped window is denied focus, call ensure_mru_position_after to make the window appear after the focus window in the mru list.
2004-08-05 17:48:39 +00:00
GList* active_mru_list;
GList* window_position;
GList* after_this_one_position;
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
active_mru_list = workspace_manager->active_workspace->mru_list;
Have newly mapped windows that are denied focus appear after the focused 2004-08-05 Elijah Newren <newren@math.utah.edu> Have newly mapped windows that are denied focus appear after the focused window in the alt-tab list. This allows one to switch to such a window with a single alt-tab press. * src/window.c (ensure_mru_position_after): new function, (meta_window_show): If newly mapped window is denied focus, call ensure_mru_position_after to make the window appear after the focus window in the mru list.
2004-08-05 17:48:39 +00:00
window_position = g_list_find (active_mru_list, window);
after_this_one_position = g_list_find (active_mru_list, after_this_one);
/* after_this_one_position is NULL when we switch workspaces, but in
* that case we don't need to do any MRU shuffling so we can simply
* return.
*/
if (after_this_one_position == NULL)
return;
if (g_list_length (window_position) > g_list_length (after_this_one_position))
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
workspace_manager->active_workspace->mru_list =
g_list_delete_link (workspace_manager->active_workspace->mru_list,
Have newly mapped windows that are denied focus appear after the focused 2004-08-05 Elijah Newren <newren@math.utah.edu> Have newly mapped windows that are denied focus appear after the focused window in the alt-tab list. This allows one to switch to such a window with a single alt-tab press. * src/window.c (ensure_mru_position_after): new function, (meta_window_show): If newly mapped window is denied focus, call ensure_mru_position_after to make the window appear after the focus window in the mru list.
2004-08-05 17:48:39 +00:00
window_position);
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
workspace_manager->active_workspace->mru_list =
g_list_insert_before (workspace_manager->active_workspace->mru_list,
Have newly mapped windows that are denied focus appear after the focused 2004-08-05 Elijah Newren <newren@math.utah.edu> Have newly mapped windows that are denied focus appear after the focused window in the alt-tab list. This allows one to switch to such a window with a single alt-tab press. * src/window.c (ensure_mru_position_after): new function, (meta_window_show): If newly mapped window is denied focus, call ensure_mru_position_after to make the window appear after the focus window in the mru list.
2004-08-05 17:48:39 +00:00
after_this_one_position->next,
window);
}
}
window: Defer stack placement without a buffer When closing a window and showing a new one, the new one may not be granted input focus until it gets a buffer on Wayland. If another window is chosen to receive focus and raised on top of stack, the newly mapped window is focused but placed underneath that other window. Meaning that for Wayland surfaces, we need to defer adding the window to the stack until we actually get to show it, once we have a buffer attached. Rather that checking the windowing backend prior to decide if a window is stackable or not, introduce a new vfunc is_stackable() which tells if a window should be added to the stack regardless of the underlying windowing system. Also add meta_window_is_in_stack() API rather than checking the stack position directly (replacing the define WINDOW_IN_STACK only available in stack.c) and remove a window from the stack only if it is present in the stack, so that the test in meta_stack_remote() becomes irrelevant. https://bugzilla.gnome.org/show_bug.cgi?id=780820
2018-01-09 12:19:40 +00:00
gboolean
meta_window_is_in_stack (MetaWindow *window)
{
return window->stack_position >= 0;
}
Add support for _NET_WM_USER_TIME 2004-06-17 Elijah Newren <newren@math.utah.edu> Add support for _NET_WM_USER_TIME * src/display.c: (meta_display_open): Add _NET_WM_USER_TIME to atom_names[], (event_callback): Manually set _NET_WM_USER_TIME upon KeyPress (doesn't work since keyboard isn't grabbed) and ButtonPress (does work), this is just a fallback for applications that don't update this themselves. * src/display.h: (struct _MetaDisplay): Add atom_net_wm_user_time field * src/screen.c: (meta_screen_apply_startup_properties): Check for TIMESTAMP provided from startup sequence as well. * src/stack.c: s/meta_window_set_stack_position/meta_window_set_stack_position_no_sync/, (meta_window_set_stack_position): New function which calls the meta_window_set_stack_position_no_sync function followed immediately by calling meta_stack_sync_to_server. * src/window-props.c: (init_net_wm_user_time), (reload_net_wm_user_time): new functions, (reload_wm_hints): also load atom_net_wm_user_time * src/window.c: new XSERVER_TIME_IS_LATER macro (accounts for timestamp wraparound), (meta_window_new_with_attrs): add timestamp attributes, (window_takes_focus_on_map): use TIMESTAMP from startup notification and _NET_WM_USER_TIME to decide whether to focus new windows, (meta_window_show): if app doesn't take focus on map, place it just below the focused window in the stack (process_property_notify): check for changes to _NET_WM_USRE_TIME, (meta_window_stack_just_below): new function * src/window.h: (_MetaWindow struct): new fields for initial_timestamp, initial_timestamp_set, net_wm_user_time_set, and net_wm_user_time, (meta_window_stack_just_below): new function
2004-06-24 15:47:05 +00:00
void
meta_window_stack_just_below (MetaWindow *window,
MetaWindow *below_this_one)
{
g_return_if_fail (window != NULL);
g_return_if_fail (below_this_one != NULL);
if (window->stack_position > below_this_one->stack_position)
{
meta_topic (META_DEBUG_STACK,
"Setting stack position of window %s to %d (making it below window %s).\n",
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window->desc,
below_this_one->stack_position,
Add support for _NET_WM_USER_TIME 2004-06-17 Elijah Newren <newren@math.utah.edu> Add support for _NET_WM_USER_TIME * src/display.c: (meta_display_open): Add _NET_WM_USER_TIME to atom_names[], (event_callback): Manually set _NET_WM_USER_TIME upon KeyPress (doesn't work since keyboard isn't grabbed) and ButtonPress (does work), this is just a fallback for applications that don't update this themselves. * src/display.h: (struct _MetaDisplay): Add atom_net_wm_user_time field * src/screen.c: (meta_screen_apply_startup_properties): Check for TIMESTAMP provided from startup sequence as well. * src/stack.c: s/meta_window_set_stack_position/meta_window_set_stack_position_no_sync/, (meta_window_set_stack_position): New function which calls the meta_window_set_stack_position_no_sync function followed immediately by calling meta_stack_sync_to_server. * src/window-props.c: (init_net_wm_user_time), (reload_net_wm_user_time): new functions, (reload_wm_hints): also load atom_net_wm_user_time * src/window.c: new XSERVER_TIME_IS_LATER macro (accounts for timestamp wraparound), (meta_window_new_with_attrs): add timestamp attributes, (window_takes_focus_on_map): use TIMESTAMP from startup notification and _NET_WM_USER_TIME to decide whether to focus new windows, (meta_window_show): if app doesn't take focus on map, place it just below the focused window in the stack (process_property_notify): check for changes to _NET_WM_USRE_TIME, (meta_window_stack_just_below): new function * src/window.h: (_MetaWindow struct): new fields for initial_timestamp, initial_timestamp_set, net_wm_user_time_set, and net_wm_user_time, (meta_window_stack_just_below): new function
2004-06-24 15:47:05 +00:00
below_this_one->desc);
Prevent an assertion failure that can occur after increasing the number of 2004-08-27 Elijah Newren <newren@math.utah.edu> Prevent an assertion failure that can occur after increasing the number of workspaces; also fix a warning and stacking order when a window is denied focus (fixes #150615) * src/window.c (meta_window_stack_just_below): the position of the window should be set equal to that of the one we want to be below, not 1 lower than that number * src/workspace.c (maybe_add_to_list): new function to add on_all_workspace windows to an mru_list, (meta_workspace_new): call maybe_add_to_list for all windows on the screen in order to initialize the mru_list
2004-08-27 17:22:54 +00:00
meta_window_set_stack_position (window, below_this_one->stack_position);
Add support for _NET_WM_USER_TIME 2004-06-17 Elijah Newren <newren@math.utah.edu> Add support for _NET_WM_USER_TIME * src/display.c: (meta_display_open): Add _NET_WM_USER_TIME to atom_names[], (event_callback): Manually set _NET_WM_USER_TIME upon KeyPress (doesn't work since keyboard isn't grabbed) and ButtonPress (does work), this is just a fallback for applications that don't update this themselves. * src/display.h: (struct _MetaDisplay): Add atom_net_wm_user_time field * src/screen.c: (meta_screen_apply_startup_properties): Check for TIMESTAMP provided from startup sequence as well. * src/stack.c: s/meta_window_set_stack_position/meta_window_set_stack_position_no_sync/, (meta_window_set_stack_position): New function which calls the meta_window_set_stack_position_no_sync function followed immediately by calling meta_stack_sync_to_server. * src/window-props.c: (init_net_wm_user_time), (reload_net_wm_user_time): new functions, (reload_wm_hints): also load atom_net_wm_user_time * src/window.c: new XSERVER_TIME_IS_LATER macro (accounts for timestamp wraparound), (meta_window_new_with_attrs): add timestamp attributes, (window_takes_focus_on_map): use TIMESTAMP from startup notification and _NET_WM_USER_TIME to decide whether to focus new windows, (meta_window_show): if app doesn't take focus on map, place it just below the focused window in the stack (process_property_notify): check for changes to _NET_WM_USRE_TIME, (meta_window_stack_just_below): new function * src/window.h: (_MetaWindow struct): new fields for initial_timestamp, initial_timestamp_set, net_wm_user_time_set, and net_wm_user_time, (meta_window_stack_just_below): new function
2004-06-24 15:47:05 +00:00
}
else
{
meta_topic (META_DEBUG_STACK,
"Window %s was already below window %s.\n",
window->desc, below_this_one->desc);
}
}
Big patch to cover about 6 different issues in order to correct rare 2005-02-20 Elijah Newren <newren@gmail.com> Big patch to cover about 6 different issues in order to correct rare problems with timestamps (make sure window selected in tasklist actually gets focus, sanity check timestamps to avoid rogue apps hosing the system, correct the updating of net_wm_user_time, correctly handle timestamps of 0 when comparing xserver timestamps for those who have had their systems up for over 25 days or so, add some debugging information to verbose logs, some code cleanups). Fixes all issues listed in #167358. * src/display.h: (struct _MetaDisplay): clarify comment on last_focus_time, introduce a new variable--last_user_time, (XSERVER_TIME_IS_BEFORE macro): put this functionality into a separate macro and then introduce a new macro with this name that uses the old one but adds additional special-case checks for timestamps that are 0, (comment to meta_display_set_input_focus_window): add information about how last_user_time should be used in this function * src/display.c (santiy_check_timestamps): new function, (meta_display_open): intialize display->last_user_time, (meta_display_get_current_time_roundtrip): use the timestamp, which is known to be good, in order to sanity_check_timestamps, (event_callback): use the new meta_window_ste_user_time() function in order to correct problems, use the timestamp of KeyPress and ButtonPress events, which are known to be good, in order to sanity_check_timestamps, (timestamp_too_old): new function for common behavior of meta_display_focus_the_no_focus_window and meta_display_set_input_focus_window, with added checking for display->last_user_time in addition to display->last_focus_time, (meta_display_set_input_focus_window): replace some of the code with a call to timestamp_too_old(), (meta_display_focus_the_no_focus_window): replace some of th ecode with a call to timestamp_too_old() * src/window.h: (meta_window_set_user_time): new function to abstract the many things that need to be done when updating the net_wm_user_time of any window * src/window.c: (meta_window_activate): add debugging spew, make sure the comparison is made with last_user_time NOT last_focus_time, use meta_window_set_user_time() function in order to correct problems, (meta_window_client_message): add a newline to a debugging message to make them easier to read, (meta_window_set_user_time): new function * src/window-props.c (reload_net_wm_user_time): use the new meta_window_ste_user_time() function in order to correct problems
2005-02-20 17:14:16 +00:00
x11/window: Implement _NET_RESTACK_WINDOW and XConfigureRequestEvent sibling Implement _NET_RESTACK_WINDOW, based on metacity commit 0b5a50c8. Also respect "above" field (sibling) of XConfigureRequestEvent. When it is set, perform a stack operation relative to that sibling. https://bugzilla.gnome.org/show_bug.cgi?id=786363 https://bugzilla.gnome.org/show_bug.cgi?id=786365
2017-09-29 14:57:22 +00:00
void
meta_window_stack_just_above (MetaWindow *window,
MetaWindow *above_this_one)
{
g_return_if_fail (window != NULL);
g_return_if_fail (above_this_one != NULL);
if (window->stack_position < above_this_one->stack_position)
{
meta_topic (META_DEBUG_STACK,
"Setting stack position of window %s to %d (making it above window %s).\n",
window->desc,
above_this_one->stack_position,
above_this_one->desc);
meta_window_set_stack_position (window, above_this_one->stack_position);
}
else
{
meta_topic (META_DEBUG_STACK,
"Window %s was already above window %s.\n",
window->desc, above_this_one->desc);
}
}
Add public meta_window_get_user_time Useful for sorting windows by interaction time.
2009-08-31 00:04:48 +00:00
/**
* meta_window_get_user_time:
Fix gobs of gtk-doc warnings https://bugzilla.gnome.org/show_bug.cgi?id=676856
2013-02-15 18:42:08 +00:00
* @window: a #MetaWindow
Add public meta_window_get_user_time Useful for sorting windows by interaction time.
2009-08-31 00:04:48 +00:00
*
* The user time represents a timestamp for the last time the user
* interacted with this window. Note this property is only available
* for non-override-redirect windows.
*
* The property is set by Mutter initially upon window creation,
* and updated thereafter on input events (key and button presses) seen by Mutter,
* client updates to the _NET_WM_USER_TIME property (if later than the current time)
* and when focusing the window.
*
* Returns: The last time the user interacted with this window.
*/
guint32
meta_window_get_user_time (MetaWindow *window)
{
return window->net_wm_user_time;
}
Big patch to cover about 6 different issues in order to correct rare 2005-02-20 Elijah Newren <newren@gmail.com> Big patch to cover about 6 different issues in order to correct rare problems with timestamps (make sure window selected in tasklist actually gets focus, sanity check timestamps to avoid rogue apps hosing the system, correct the updating of net_wm_user_time, correctly handle timestamps of 0 when comparing xserver timestamps for those who have had their systems up for over 25 days or so, add some debugging information to verbose logs, some code cleanups). Fixes all issues listed in #167358. * src/display.h: (struct _MetaDisplay): clarify comment on last_focus_time, introduce a new variable--last_user_time, (XSERVER_TIME_IS_BEFORE macro): put this functionality into a separate macro and then introduce a new macro with this name that uses the old one but adds additional special-case checks for timestamps that are 0, (comment to meta_display_set_input_focus_window): add information about how last_user_time should be used in this function * src/display.c (santiy_check_timestamps): new function, (meta_display_open): intialize display->last_user_time, (meta_display_get_current_time_roundtrip): use the timestamp, which is known to be good, in order to sanity_check_timestamps, (event_callback): use the new meta_window_ste_user_time() function in order to correct problems, use the timestamp of KeyPress and ButtonPress events, which are known to be good, in order to sanity_check_timestamps, (timestamp_too_old): new function for common behavior of meta_display_focus_the_no_focus_window and meta_display_set_input_focus_window, with added checking for display->last_user_time in addition to display->last_focus_time, (meta_display_set_input_focus_window): replace some of the code with a call to timestamp_too_old(), (meta_display_focus_the_no_focus_window): replace some of th ecode with a call to timestamp_too_old() * src/window.h: (meta_window_set_user_time): new function to abstract the many things that need to be done when updating the net_wm_user_time of any window * src/window.c: (meta_window_activate): add debugging spew, make sure the comparison is made with last_user_time NOT last_focus_time, use meta_window_set_user_time() function in order to correct problems, (meta_window_client_message): add a newline to a debugging message to make them easier to read, (meta_window_set_user_time): new function * src/window-props.c (reload_net_wm_user_time): use the new meta_window_ste_user_time() function in order to correct problems
2005-02-20 17:14:16 +00:00
void
meta_window_set_user_time (MetaWindow *window,
Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ 2006-09-13 Elijah Newren <newren gmail com> * src/common.h (MetaWindowMenuFunc): * src/core.[ch] (meta_core_user_lower_and_unfocus, meta_core_user_focus, meta_core_show_window_menu, meta_core_begin_grab_op, meta_core_end_grab_op): * src/delete.c (delete_ping_reply_func, delete_ping_timeout_func, meta_window_delete): * src/display.[ch] (struct MetaDisplay, struct MetaPingData, sanity_check_timestamps, meta_display_open, event_callback, meta_spew_event, meta_display_set_grab_op_cursor, meta_display_begin_grab_op, meta_display_end_grab_op, meta_display_ping_timeout, meta_display_ping_window, process_pong_message, timestamp_too_old, meta_display_set_input_focus_window): * src/keybindings.[ch] (grab_keyboard, ungrab_keyboard, meta_screen_grab_all_keys, meta_window_grab_all_keys, meta_window_ungrab_all_keys, error_on_generic_command, error_on_command, error_on_terminal_command): * src/metacity-dialog.c (on_realize, warn_about_no_sm_support, error_about_command, main): * src/screen.[ch] (struct _MetaScreen, meta_screen_new, meta_screen_show_desktop, meta_screen_apply_startup_properties): * src/session.c (warn_about_lame_clients_and_finish_interact): * src/window.[ch] (struct _MetaWindow, intervening_user_event_occurred, window_activate, meta_window_delete, meta_window_focus, meta_window_send_icccm_message, meta_window_client_message, menu_callback, meta_window_show_menu, struct EventScannerData, check_use_this_motion_notify, meta_window_begin_grab_op, meta_window_set_user_time): * src/workspace.[ch] (focus_ancestor_or_mru_window, meta_workspace_activate_with_focus, meta_workspace_activate, meta_workspace_focus_default_window, focus_ancestor_or_mru_window): Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ does) instead of Time. #348305
2006-09-13 16:32:33 +00:00
guint32 timestamp)
Big patch to cover about 6 different issues in order to correct rare 2005-02-20 Elijah Newren <newren@gmail.com> Big patch to cover about 6 different issues in order to correct rare problems with timestamps (make sure window selected in tasklist actually gets focus, sanity check timestamps to avoid rogue apps hosing the system, correct the updating of net_wm_user_time, correctly handle timestamps of 0 when comparing xserver timestamps for those who have had their systems up for over 25 days or so, add some debugging information to verbose logs, some code cleanups). Fixes all issues listed in #167358. * src/display.h: (struct _MetaDisplay): clarify comment on last_focus_time, introduce a new variable--last_user_time, (XSERVER_TIME_IS_BEFORE macro): put this functionality into a separate macro and then introduce a new macro with this name that uses the old one but adds additional special-case checks for timestamps that are 0, (comment to meta_display_set_input_focus_window): add information about how last_user_time should be used in this function * src/display.c (santiy_check_timestamps): new function, (meta_display_open): intialize display->last_user_time, (meta_display_get_current_time_roundtrip): use the timestamp, which is known to be good, in order to sanity_check_timestamps, (event_callback): use the new meta_window_ste_user_time() function in order to correct problems, use the timestamp of KeyPress and ButtonPress events, which are known to be good, in order to sanity_check_timestamps, (timestamp_too_old): new function for common behavior of meta_display_focus_the_no_focus_window and meta_display_set_input_focus_window, with added checking for display->last_user_time in addition to display->last_focus_time, (meta_display_set_input_focus_window): replace some of the code with a call to timestamp_too_old(), (meta_display_focus_the_no_focus_window): replace some of th ecode with a call to timestamp_too_old() * src/window.h: (meta_window_set_user_time): new function to abstract the many things that need to be done when updating the net_wm_user_time of any window * src/window.c: (meta_window_activate): add debugging spew, make sure the comparison is made with last_user_time NOT last_focus_time, use meta_window_set_user_time() function in order to correct problems, (meta_window_client_message): add a newline to a debugging message to make them easier to read, (meta_window_set_user_time): new function * src/window-props.c (reload_net_wm_user_time): use the new meta_window_ste_user_time() function in order to correct problems
2005-02-20 17:14:16 +00:00
{
/* FIXME: If Soeren's suggestion in bug 151984 is implemented, it will allow
* us to sanity check the timestamp here and ensure it doesn't correspond to
* a future time.
*/
Don't read most properties for override-redirect windows Skipping handling of properties for override redirect windows has two advantages: first it reduces the amount of work needed to get an override-redirect window (menu, tooltip, drag icon) onto the screen. But more importantly, it reduces the number of code-paths for an override-redirect to get into some code portion where it isn't expected. * Integrate the list of properties we load initially with the list of property hooks; this avoids having two separate lists that we have to keep in sync. * Add a flag to MetaWindowPropHooks to indicate whether the property should be handled for override-redirect windows; currently we load a) properties that identify the window - useful for debugging purposes b) WM_TRANSIENT_FOR (could be used to associate menus with toplevels.) * For properties that aren't always loaded through window-props.c, add !window->override checks to places that trigger loading, and add g_return_if_fail(!window->override) to the load functions as a double-check. http://bugzilla.gnome.org/show_bug.cgi?id=582639
2009-06-14 12:37:57 +00:00
g_return_if_fail (!window->override_redirect);
Big patch to cover about 6 different issues in order to correct rare 2005-02-20 Elijah Newren <newren@gmail.com> Big patch to cover about 6 different issues in order to correct rare problems with timestamps (make sure window selected in tasklist actually gets focus, sanity check timestamps to avoid rogue apps hosing the system, correct the updating of net_wm_user_time, correctly handle timestamps of 0 when comparing xserver timestamps for those who have had their systems up for over 25 days or so, add some debugging information to verbose logs, some code cleanups). Fixes all issues listed in #167358. * src/display.h: (struct _MetaDisplay): clarify comment on last_focus_time, introduce a new variable--last_user_time, (XSERVER_TIME_IS_BEFORE macro): put this functionality into a separate macro and then introduce a new macro with this name that uses the old one but adds additional special-case checks for timestamps that are 0, (comment to meta_display_set_input_focus_window): add information about how last_user_time should be used in this function * src/display.c (santiy_check_timestamps): new function, (meta_display_open): intialize display->last_user_time, (meta_display_get_current_time_roundtrip): use the timestamp, which is known to be good, in order to sanity_check_timestamps, (event_callback): use the new meta_window_ste_user_time() function in order to correct problems, use the timestamp of KeyPress and ButtonPress events, which are known to be good, in order to sanity_check_timestamps, (timestamp_too_old): new function for common behavior of meta_display_focus_the_no_focus_window and meta_display_set_input_focus_window, with added checking for display->last_user_time in addition to display->last_focus_time, (meta_display_set_input_focus_window): replace some of the code with a call to timestamp_too_old(), (meta_display_focus_the_no_focus_window): replace some of th ecode with a call to timestamp_too_old() * src/window.h: (meta_window_set_user_time): new function to abstract the many things that need to be done when updating the net_wm_user_time of any window * src/window.c: (meta_window_activate): add debugging spew, make sure the comparison is made with last_user_time NOT last_focus_time, use meta_window_set_user_time() function in order to correct problems, (meta_window_client_message): add a newline to a debugging message to make them easier to read, (meta_window_set_user_time): new function * src/window-props.c (reload_net_wm_user_time): use the new meta_window_ste_user_time() function in order to correct problems
2005-02-20 17:14:16 +00:00
/* Only update the time if this timestamp is newer... */
if (window->net_wm_user_time_set &&
XSERVER_TIME_IS_BEFORE (timestamp, window->net_wm_user_time))
{
meta_topic (META_DEBUG_STARTUP,
Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ 2006-09-13 Elijah Newren <newren gmail com> * src/common.h (MetaWindowMenuFunc): * src/core.[ch] (meta_core_user_lower_and_unfocus, meta_core_user_focus, meta_core_show_window_menu, meta_core_begin_grab_op, meta_core_end_grab_op): * src/delete.c (delete_ping_reply_func, delete_ping_timeout_func, meta_window_delete): * src/display.[ch] (struct MetaDisplay, struct MetaPingData, sanity_check_timestamps, meta_display_open, event_callback, meta_spew_event, meta_display_set_grab_op_cursor, meta_display_begin_grab_op, meta_display_end_grab_op, meta_display_ping_timeout, meta_display_ping_window, process_pong_message, timestamp_too_old, meta_display_set_input_focus_window): * src/keybindings.[ch] (grab_keyboard, ungrab_keyboard, meta_screen_grab_all_keys, meta_window_grab_all_keys, meta_window_ungrab_all_keys, error_on_generic_command, error_on_command, error_on_terminal_command): * src/metacity-dialog.c (on_realize, warn_about_no_sm_support, error_about_command, main): * src/screen.[ch] (struct _MetaScreen, meta_screen_new, meta_screen_show_desktop, meta_screen_apply_startup_properties): * src/session.c (warn_about_lame_clients_and_finish_interact): * src/window.[ch] (struct _MetaWindow, intervening_user_event_occurred, window_activate, meta_window_delete, meta_window_focus, meta_window_send_icccm_message, meta_window_client_message, menu_callback, meta_window_show_menu, struct EventScannerData, check_use_this_motion_notify, meta_window_begin_grab_op, meta_window_set_user_time): * src/workspace.[ch] (focus_ancestor_or_mru_window, meta_workspace_activate_with_focus, meta_workspace_activate, meta_workspace_focus_default_window, focus_ancestor_or_mru_window): Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ does) instead of Time. #348305
2006-09-13 16:32:33 +00:00
"Window %s _NET_WM_USER_TIME not updated to %u, because it "
"is less than %u\n",
Big patch to cover about 6 different issues in order to correct rare 2005-02-20 Elijah Newren <newren@gmail.com> Big patch to cover about 6 different issues in order to correct rare problems with timestamps (make sure window selected in tasklist actually gets focus, sanity check timestamps to avoid rogue apps hosing the system, correct the updating of net_wm_user_time, correctly handle timestamps of 0 when comparing xserver timestamps for those who have had their systems up for over 25 days or so, add some debugging information to verbose logs, some code cleanups). Fixes all issues listed in #167358. * src/display.h: (struct _MetaDisplay): clarify comment on last_focus_time, introduce a new variable--last_user_time, (XSERVER_TIME_IS_BEFORE macro): put this functionality into a separate macro and then introduce a new macro with this name that uses the old one but adds additional special-case checks for timestamps that are 0, (comment to meta_display_set_input_focus_window): add information about how last_user_time should be used in this function * src/display.c (santiy_check_timestamps): new function, (meta_display_open): intialize display->last_user_time, (meta_display_get_current_time_roundtrip): use the timestamp, which is known to be good, in order to sanity_check_timestamps, (event_callback): use the new meta_window_ste_user_time() function in order to correct problems, use the timestamp of KeyPress and ButtonPress events, which are known to be good, in order to sanity_check_timestamps, (timestamp_too_old): new function for common behavior of meta_display_focus_the_no_focus_window and meta_display_set_input_focus_window, with added checking for display->last_user_time in addition to display->last_focus_time, (meta_display_set_input_focus_window): replace some of the code with a call to timestamp_too_old(), (meta_display_focus_the_no_focus_window): replace some of th ecode with a call to timestamp_too_old() * src/window.h: (meta_window_set_user_time): new function to abstract the many things that need to be done when updating the net_wm_user_time of any window * src/window.c: (meta_window_activate): add debugging spew, make sure the comparison is made with last_user_time NOT last_focus_time, use meta_window_set_user_time() function in order to correct problems, (meta_window_client_message): add a newline to a debugging message to make them easier to read, (meta_window_set_user_time): new function * src/window-props.c (reload_net_wm_user_time): use the new meta_window_ste_user_time() function in order to correct problems
2005-02-20 17:14:16 +00:00
window->desc, timestamp, window->net_wm_user_time);
}
else
{
meta_topic (META_DEBUG_STARTUP,
Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ 2006-09-13 Elijah Newren <newren gmail com> * src/common.h (MetaWindowMenuFunc): * src/core.[ch] (meta_core_user_lower_and_unfocus, meta_core_user_focus, meta_core_show_window_menu, meta_core_begin_grab_op, meta_core_end_grab_op): * src/delete.c (delete_ping_reply_func, delete_ping_timeout_func, meta_window_delete): * src/display.[ch] (struct MetaDisplay, struct MetaPingData, sanity_check_timestamps, meta_display_open, event_callback, meta_spew_event, meta_display_set_grab_op_cursor, meta_display_begin_grab_op, meta_display_end_grab_op, meta_display_ping_timeout, meta_display_ping_window, process_pong_message, timestamp_too_old, meta_display_set_input_focus_window): * src/keybindings.[ch] (grab_keyboard, ungrab_keyboard, meta_screen_grab_all_keys, meta_window_grab_all_keys, meta_window_ungrab_all_keys, error_on_generic_command, error_on_command, error_on_terminal_command): * src/metacity-dialog.c (on_realize, warn_about_no_sm_support, error_about_command, main): * src/screen.[ch] (struct _MetaScreen, meta_screen_new, meta_screen_show_desktop, meta_screen_apply_startup_properties): * src/session.c (warn_about_lame_clients_and_finish_interact): * src/window.[ch] (struct _MetaWindow, intervening_user_event_occurred, window_activate, meta_window_delete, meta_window_focus, meta_window_send_icccm_message, meta_window_client_message, menu_callback, meta_window_show_menu, struct EventScannerData, check_use_this_motion_notify, meta_window_begin_grab_op, meta_window_set_user_time): * src/workspace.[ch] (focus_ancestor_or_mru_window, meta_workspace_activate_with_focus, meta_workspace_activate, meta_workspace_focus_default_window, focus_ancestor_or_mru_window): Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ does) instead of Time. #348305
2006-09-13 16:32:33 +00:00
"Window %s has _NET_WM_USER_TIME of %u\n",
Big patch to cover about 6 different issues in order to correct rare 2005-02-20 Elijah Newren <newren@gmail.com> Big patch to cover about 6 different issues in order to correct rare problems with timestamps (make sure window selected in tasklist actually gets focus, sanity check timestamps to avoid rogue apps hosing the system, correct the updating of net_wm_user_time, correctly handle timestamps of 0 when comparing xserver timestamps for those who have had their systems up for over 25 days or so, add some debugging information to verbose logs, some code cleanups). Fixes all issues listed in #167358. * src/display.h: (struct _MetaDisplay): clarify comment on last_focus_time, introduce a new variable--last_user_time, (XSERVER_TIME_IS_BEFORE macro): put this functionality into a separate macro and then introduce a new macro with this name that uses the old one but adds additional special-case checks for timestamps that are 0, (comment to meta_display_set_input_focus_window): add information about how last_user_time should be used in this function * src/display.c (santiy_check_timestamps): new function, (meta_display_open): intialize display->last_user_time, (meta_display_get_current_time_roundtrip): use the timestamp, which is known to be good, in order to sanity_check_timestamps, (event_callback): use the new meta_window_ste_user_time() function in order to correct problems, use the timestamp of KeyPress and ButtonPress events, which are known to be good, in order to sanity_check_timestamps, (timestamp_too_old): new function for common behavior of meta_display_focus_the_no_focus_window and meta_display_set_input_focus_window, with added checking for display->last_user_time in addition to display->last_focus_time, (meta_display_set_input_focus_window): replace some of the code with a call to timestamp_too_old(), (meta_display_focus_the_no_focus_window): replace some of th ecode with a call to timestamp_too_old() * src/window.h: (meta_window_set_user_time): new function to abstract the many things that need to be done when updating the net_wm_user_time of any window * src/window.c: (meta_window_activate): add debugging spew, make sure the comparison is made with last_user_time NOT last_focus_time, use meta_window_set_user_time() function in order to correct problems, (meta_window_client_message): add a newline to a debugging message to make them easier to read, (meta_window_set_user_time): new function * src/window-props.c (reload_net_wm_user_time): use the new meta_window_ste_user_time() function in order to correct problems
2005-02-20 17:14:16 +00:00
window->desc, timestamp);
window->net_wm_user_time_set = TRUE;
window->net_wm_user_time = timestamp;
if (XSERVER_TIME_IS_BEFORE (window->display->last_user_time, timestamp))
window->display->last_user_time = timestamp;
Fix accidental overzealous focus holding by the terminal introduced by the 2006-01-15 Elijah Newren <newren@gmail.com> Fix accidental overzealous focus holding by the terminal introduced by the original patch in bug 326159. Windows launched from panel icons, the panel menu, or global keybindings should get focus now. #326159. * src/display.c (meta_display_open, event_callback): * src/display.h (struct MetaDisplay): * src/keybindings.c (process_event): * src/window.c (meta_window_set_user_time): Add a new allow_terminal_deactivation field to MetaDisplay and use it to track whether the user's last action was interaction with the terminal or some outside action (global keybinding, clicking on a dock, etc.) likely to launch a new window. * src/window.c (window_state_on_map): Allow the focus switch from a terminal to something else if allow_terminal_deactiviation is true. * src/keybindings.c (handle_panel_keybinding): Remove some unneeded code.
2006-01-15 17:03:57 +00:00
/* If this is a terminal, user interaction with it means the user likely
* doesn't want to have focus transferred for now due to new windows.
*/
window: Make window_is_terminal private
2014-03-18 14:08:28 +00:00
if (meta_prefs_get_focus_new_windows () == G_DESKTOP_FOCUS_NEW_WINDOWS_STRICT &&
window_is_terminal (window))
Fix accidental overzealous focus holding by the terminal introduced by the 2006-01-15 Elijah Newren <newren@gmail.com> Fix accidental overzealous focus holding by the terminal introduced by the original patch in bug 326159. Windows launched from panel icons, the panel menu, or global keybindings should get focus now. #326159. * src/display.c (meta_display_open, event_callback): * src/display.h (struct MetaDisplay): * src/keybindings.c (process_event): * src/window.c (meta_window_set_user_time): Add a new allow_terminal_deactivation field to MetaDisplay and use it to track whether the user's last action was interaction with the terminal or some outside action (global keybinding, clicking on a dock, etc.) likely to launch a new window. * src/window.c (window_state_on_map): Allow the focus switch from a terminal to something else if allow_terminal_deactiviation is true. * src/keybindings.c (handle_panel_keybinding): Remove some unneeded code.
2006-01-15 17:03:57 +00:00
window->display->allow_terminal_deactivation = FALSE;
[MetaWindow] Make user-time a GObject property Notification of changes are useful for code ordering windows.
2009-08-31 16:06:53 +00:00
core: Only notify on MetaWindow::user-time on actual changes If the timestamp is the same, it doesn't make sense to update and we don't do so. So it doesn't make sense to notify on the property either. https://gitlab.gnome.org/GNOME/mutter/issues/556
2019-07-19 15:47:43 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_USER_TIME]);
}
Big patch to cover about 6 different issues in order to correct rare 2005-02-20 Elijah Newren <newren@gmail.com> Big patch to cover about 6 different issues in order to correct rare problems with timestamps (make sure window selected in tasklist actually gets focus, sanity check timestamps to avoid rogue apps hosing the system, correct the updating of net_wm_user_time, correctly handle timestamps of 0 when comparing xserver timestamps for those who have had their systems up for over 25 days or so, add some debugging information to verbose logs, some code cleanups). Fixes all issues listed in #167358. * src/display.h: (struct _MetaDisplay): clarify comment on last_focus_time, introduce a new variable--last_user_time, (XSERVER_TIME_IS_BEFORE macro): put this functionality into a separate macro and then introduce a new macro with this name that uses the old one but adds additional special-case checks for timestamps that are 0, (comment to meta_display_set_input_focus_window): add information about how last_user_time should be used in this function * src/display.c (santiy_check_timestamps): new function, (meta_display_open): intialize display->last_user_time, (meta_display_get_current_time_roundtrip): use the timestamp, which is known to be good, in order to sanity_check_timestamps, (event_callback): use the new meta_window_ste_user_time() function in order to correct problems, use the timestamp of KeyPress and ButtonPress events, which are known to be good, in order to sanity_check_timestamps, (timestamp_too_old): new function for common behavior of meta_display_focus_the_no_focus_window and meta_display_set_input_focus_window, with added checking for display->last_user_time in addition to display->last_focus_time, (meta_display_set_input_focus_window): replace some of the code with a call to timestamp_too_old(), (meta_display_focus_the_no_focus_window): replace some of th ecode with a call to timestamp_too_old() * src/window.h: (meta_window_set_user_time): new function to abstract the many things that need to be done when updating the net_wm_user_time of any window * src/window.c: (meta_window_activate): add debugging spew, make sure the comparison is made with last_user_time NOT last_focus_time, use meta_window_set_user_time() function in order to correct problems, (meta_window_client_message): add a newline to a debugging message to make them easier to read, (meta_window_set_user_time): new function * src/window-props.c (reload_net_wm_user_time): use the new meta_window_ste_user_time() function in order to correct problems
2005-02-20 17:14:16 +00:00
}
mark a window as needing or not needing the user's attention use the new 2006-03-29 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (meta_window_set_demands_attention, meta_window_unset_demands_attention): mark a window as needing or not needing the user's attention * src/window.c (meta_window_show, window_activate, meta_window_focus, meta_window_configure_request, meta_window_client_message): use the new set/unset demands attention functions. Fixes #305822.
2006-03-29 18:43:22 +00:00
Add meta_window_get_stable_sequence Useful for plugins which want to order windows in a stable fashion. https://bugzilla.gnome.org/show_bug.cgi?id=595882
2009-09-19 00:50:11 +00:00
/**
* meta_window_get_stable_sequence:
* @window: A #MetaWindow
*
* The stable sequence number is a monotonicially increasing
* unique integer assigned to each #MetaWindow upon creation.
*
* This number can be useful for sorting windows in a stable
* fashion.
*
* Returns: Internal sequence number for this window
*/
guint32
meta_window_get_stable_sequence (MetaWindow *window)
{
g_return_val_if_fail (META_IS_WINDOW (window), 0);
return window->stable_sequence;
}
mark a window as needing or not needing the user's attention use the new 2006-03-29 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (meta_window_set_demands_attention, meta_window_unset_demands_attention): mark a window as needing or not needing the user's attention * src/window.c (meta_window_show, window_activate, meta_window_focus, meta_window_configure_request, meta_window_client_message): use the new set/unset demands attention functions. Fixes #305822.
2006-03-29 18:43:22 +00:00
/* Sets the demands_attention hint on a window, but only
* if it's at least partially obscured (see #305882).
*/
void
meta_window_set_demands_attention (MetaWindow *window)
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
mark a window as needing or not needing the user's attention use the new 2006-03-29 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (meta_window_set_demands_attention, meta_window_unset_demands_attention): mark a window as needing or not needing the user's attention * src/window.c (meta_window_show, window_activate, meta_window_focus, meta_window_configure_request, meta_window_client_message): use the new set/unset demands attention functions. Fixes #305822.
2006-03-29 18:43:22 +00:00
MetaRectangle candidate_rect, other_rect;
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
GList *stack = window->display->stack->sorted;
mark a window as needing or not needing the user's attention use the new 2006-03-29 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (meta_window_set_demands_attention, meta_window_unset_demands_attention): mark a window as needing or not needing the user's attention * src/window.c (meta_window_show, window_activate, meta_window_focus, meta_window_configure_request, meta_window_client_message): use the new set/unset demands attention functions. Fixes #305822.
2006-03-29 18:43:22 +00:00
MetaWindow *other_window;
gboolean obscured = FALSE;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspace *workspace = workspace_manager->active_workspace;
[MetaWindow] Added boolean demands-attention property https://bugzilla.gnome.org/show_bug.cgi?id=588065
2009-11-17 10:02:06 +00:00
if (window->wm_state_demands_attention)
return;
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
if (!meta_window_located_on_workspace (window, workspace))
mark a window as needing or not needing the user's attention use the new 2006-03-29 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (meta_window_set_demands_attention, meta_window_unset_demands_attention): mark a window as needing or not needing the user's attention * src/window.c (meta_window_show, window_activate, meta_window_focus, meta_window_configure_request, meta_window_client_message): use the new set/unset demands attention functions. Fixes #305822.
2006-03-29 18:43:22 +00:00
{
Have the list also pull windows that are in other workspaces that have the 2008-02-01 Alex R.M. Turner <armtuk@gmail.com> * src/core/display.c (meta_get_tab_entry_list): Have the list also pull windows that are in other workspaces that have the wm_state_needs_attention flag set * src/core/window.c (meta_window_set_demands_attention): Make windows that are on other workspaces that demand attention that aren't obscured count as being obscured Bug #333548. svn path=/trunk/; revision=3533
2008-02-02 04:05:16 +00:00
/* windows on other workspaces are necessarily obscured */
obscured = TRUE;
}
minimised windows are necessarily obscured. 2008-10-22 Thomas Thurman <tthurman@gnome.org> * src/core/window.c (meta_window_set_demands_attention): minimised windows are necessarily obscured. svn path=/trunk/; revision=3971
2008-10-22 03:21:23 +00:00
else if (window->minimized)
{
obscured = TRUE;
}
Have the list also pull windows that are in other workspaces that have the 2008-02-01 Alex R.M. Turner <armtuk@gmail.com> * src/core/display.c (meta_get_tab_entry_list): Have the list also pull windows that are in other workspaces that have the wm_state_needs_attention flag set * src/core/window.c (meta_window_set_demands_attention): Make windows that are on other workspaces that demand attention that aren't obscured count as being obscured Bug #333548. svn path=/trunk/; revision=3533
2008-02-02 04:05:16 +00:00
else
{
Rename meta_window_get_outer_rect() to meta_window_get_frame_rect() For clarity, rename meta_window_get_outer_rect() to match terminology we use elsewhere. The old function is left as a deprecated compatibility wrapper.
2013-11-19 17:24:45 +00:00
meta_window_get_frame_rect (window, &candidate_rect);
mark a window as needing or not needing the user's attention use the new 2006-03-29 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (meta_window_set_demands_attention, meta_window_unset_demands_attention): mark a window as needing or not needing the user's attention * src/window.c (meta_window_show, window_activate, meta_window_focus, meta_window_configure_request, meta_window_client_message): use the new set/unset demands attention functions. Fixes #305822.
2006-03-29 18:43:22 +00:00
Have the list also pull windows that are in other workspaces that have the 2008-02-01 Alex R.M. Turner <armtuk@gmail.com> * src/core/display.c (meta_get_tab_entry_list): Have the list also pull windows that are in other workspaces that have the wm_state_needs_attention flag set * src/core/window.c (meta_window_set_demands_attention): Make windows that are on other workspaces that demand attention that aren't obscured count as being obscured Bug #333548. svn path=/trunk/; revision=3533
2008-02-02 04:05:16 +00:00
/* The stack is sorted with the top windows first. */
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
Have the list also pull windows that are in other workspaces that have the 2008-02-01 Alex R.M. Turner <armtuk@gmail.com> * src/core/display.c (meta_get_tab_entry_list): Have the list also pull windows that are in other workspaces that have the wm_state_needs_attention flag set * src/core/window.c (meta_window_set_demands_attention): Make windows that are on other workspaces that demand attention that aren't obscured count as being obscured Bug #333548. svn path=/trunk/; revision=3533
2008-02-02 04:05:16 +00:00
while (stack != NULL && stack->data != window)
{
other_window = stack->data;
stack = stack->next;
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
window: Fix corner case in set_demands_attention() We only grant requests to set the demands-attention hint if the window is at least partially obscured; so for non-minimized windows on the active workspace, we check if any other window on the same workspace that is higher in the stack overlaps. However in the case of a sticky window, window->workspace is NULL, so we end up considering any non-sticky window on a different workspace. At this point we have already established that the window is showing on the active workspace, so use that to filter for windows that may overlap.
2014-09-27 02:12:52 +00:00
if (meta_window_located_on_workspace (other_window, workspace))
mark a window as needing or not needing the user's attention use the new 2006-03-29 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (meta_window_set_demands_attention, meta_window_unset_demands_attention): mark a window as needing or not needing the user's attention * src/window.c (meta_window_show, window_activate, meta_window_focus, meta_window_configure_request, meta_window_client_message): use the new set/unset demands attention functions. Fixes #305822.
2006-03-29 18:43:22 +00:00
{
Rename meta_window_get_outer_rect() to meta_window_get_frame_rect() For clarity, rename meta_window_get_outer_rect() to match terminology we use elsewhere. The old function is left as a deprecated compatibility wrapper.
2013-11-19 17:24:45 +00:00
meta_window_get_frame_rect (other_window, &other_rect);
Have the list also pull windows that are in other workspaces that have the 2008-02-01 Alex R.M. Turner <armtuk@gmail.com> * src/core/display.c (meta_get_tab_entry_list): Have the list also pull windows that are in other workspaces that have the wm_state_needs_attention flag set * src/core/window.c (meta_window_set_demands_attention): Make windows that are on other workspaces that demand attention that aren't obscured count as being obscured Bug #333548. svn path=/trunk/; revision=3533
2008-02-02 04:05:16 +00:00
if (meta_rectangle_overlap (&candidate_rect, &other_rect))
{
obscured = TRUE;
break;
}
mark a window as needing or not needing the user's attention use the new 2006-03-29 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (meta_window_set_demands_attention, meta_window_unset_demands_attention): mark a window as needing or not needing the user's attention * src/window.c (meta_window_show, window_activate, meta_window_focus, meta_window_configure_request, meta_window_client_message): use the new set/unset demands attention functions. Fixes #305822.
2006-03-29 18:43:22 +00:00
}
}
minimised windows are necessarily obscured. 2008-10-22 Thomas Thurman <tthurman@gnome.org> * src/core/window.c (meta_window_set_demands_attention): minimised windows are necessarily obscured. svn path=/trunk/; revision=3971
2008-10-22 03:21:23 +00:00
}
if (obscured)
{
mark a window as needing or not needing the user's attention use the new 2006-03-29 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (meta_window_set_demands_attention, meta_window_unset_demands_attention): mark a window as needing or not needing the user's attention * src/window.c (meta_window_show, window_activate, meta_window_focus, meta_window_configure_request, meta_window_client_message): use the new set/unset demands attention functions. Fixes #305822.
2006-03-29 18:43:22 +00:00
meta_topic (META_DEBUG_WINDOW_OPS,
minimised windows are necessarily obscured. 2008-10-22 Thomas Thurman <tthurman@gnome.org> * src/core/window.c (meta_window_set_demands_attention): minimised windows are necessarily obscured. svn path=/trunk/; revision=3971
2008-10-22 03:21:23 +00:00
"Marking %s as needing attention\n",
window->desc);
window->wm_state_demands_attention = TRUE;
set_net_wm_state (window);
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_DEMANDS_ATTENTION]);
[MetaDisplay] Added window-demands-attention signal Having a MetaDisplay::window-demands-attention signal allows to deal with windows demanding attention in a cetralized fashion. The signal is emitted when a window is created with initial demands-attention state and/or when the state changes later on. Based on original patch by Jon Nettleton. https://bugzilla.gnome.org/show_bug.cgi?id=597052
2009-10-28 17:19:24 +00:00
g_signal_emit_by_name (window->display, "window-demands-attention",
window);
mark a window as needing or not needing the user's attention use the new 2006-03-29 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (meta_window_set_demands_attention, meta_window_unset_demands_attention): mark a window as needing or not needing the user's attention * src/window.c (meta_window_show, window_activate, meta_window_focus, meta_window_configure_request, meta_window_client_message): use the new set/unset demands attention functions. Fixes #305822.
2006-03-29 18:43:22 +00:00
}
minimised windows are necessarily obscured. 2008-10-22 Thomas Thurman <tthurman@gnome.org> * src/core/window.c (meta_window_set_demands_attention): minimised windows are necessarily obscured. svn path=/trunk/; revision=3971
2008-10-22 03:21:23 +00:00
else
{
/* If the window's in full view, there's no point setting the flag. */
mark a window as needing or not needing the user's attention use the new 2006-03-29 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (meta_window_set_demands_attention, meta_window_unset_demands_attention): mark a window as needing or not needing the user's attention * src/window.c (meta_window_show, window_activate, meta_window_focus, meta_window_configure_request, meta_window_client_message): use the new set/unset demands attention functions. Fixes #305822.
2006-03-29 18:43:22 +00:00
minimised windows are necessarily obscured. 2008-10-22 Thomas Thurman <tthurman@gnome.org> * src/core/window.c (meta_window_set_demands_attention): minimised windows are necessarily obscured. svn path=/trunk/; revision=3971
2008-10-22 03:21:23 +00:00
meta_topic (META_DEBUG_WINDOW_OPS,
"Not marking %s as needing attention because "
"it's in full view\n",
window->desc);
}
mark a window as needing or not needing the user's attention use the new 2006-03-29 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (meta_window_set_demands_attention, meta_window_unset_demands_attention): mark a window as needing or not needing the user's attention * src/window.c (meta_window_show, window_activate, meta_window_focus, meta_window_configure_request, meta_window_client_message): use the new set/unset demands attention functions. Fixes #305822.
2006-03-29 18:43:22 +00:00
}
void
meta_window_unset_demands_attention (MetaWindow *window)
{
meta_topic (META_DEBUG_WINDOW_OPS,
"Marking %s as not needing attention\n", window->desc);
Merge branch 'plugin-gobject' into next-generation Conflicts: src/compositor/mutter/compositor-mutter.c src/core/window.c
2008-12-18 12:41:56 +00:00
[MetaWindow] Added boolean demands-attention property https://bugzilla.gnome.org/show_bug.cgi?id=588065
2009-11-17 10:02:06 +00:00
if (window->wm_state_demands_attention)
{
window->wm_state_demands_attention = FALSE;
set_net_wm_state (window);
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_DEMANDS_ATTENTION]);
[MetaWindow] Added boolean demands-attention property https://bugzilla.gnome.org/show_bug.cgi?id=588065
2009-11-17 10:02:06 +00:00
}
mark a window as needing or not needing the user's attention use the new 2006-03-29 Thomas Thurman <thomas@thurman.org.uk> * src/window.c, src/window.h (meta_window_set_demands_attention, meta_window_unset_demands_attention): mark a window as needing or not needing the user's attention * src/window.c (meta_window_show, window_activate, meta_window_focus, meta_window_configure_request, meta_window_client_message): use the new set/unset demands attention functions. Fixes #305822.
2006-03-29 18:43:22 +00:00
}
src/include/frame.h src/include/display.h src/include/xprops.h 2008-05-19 Iain Holmes <iain@gnome.org> * src/include/frame.h * src/include/display.h * src/include/xprops.h * src/include/compositor.h * src/include/types.h * src/include/window.h * src/include/errors.h * src/include/screen.h: New basic public API for compositor. * src/compositor/*: Separate the compositor out into its own separate directory and set it up for backends. Initial XRender backend. * src/core/compositor.[ch]: Remove * src/core/frame.h * src/core/screen.h * src/core/display.h * src/core/window.h: Rename to -private.h so as not to clash with the new files in include * src/core/delete.c * src/core/workspace.h * src/core/stack.[ch] * src/core/keybindings.[ch] * src/core/errors.c * src/core/effects.[ch] * src/core/core.c * src/core/group.h * src/core/edge-resistance.[ch] * src/core/window-props.[ch] * src/core/constraints.h * src/core/bell.[ch] * src/core/iconcache.h * src/core/session.[ch] * src/core/main.c * src/core/place.h * src/core/xprops.c * src/ui/tabpopup.c: Use the new -private headers * src/core/display.c * src/core/frame.c * src/core/window.c * src/core/screen.c: Add the API functions required by the compositor * src/Makefile.am: Relocate the new files svn path=/trunk/; revision=3715
2008-05-19 00:00:09 +00:00
introspection: Build with --warn-fatal, drop fix-meta-rectangle.py hack Cleanly build with --warn-fatal. Implementation: * Liberally apply (skip) where the API is clearly C only, e.g. uses XLib. The theming code and MutterPlugin are skipped too. * Add missing (transfer) and (element-type) annotations For a few functions that had a comment, I turned it into gtk-doc, but I didn't (with a few exceptions) try to write new documentation in this pass.
2010-09-01 19:39:53 +00:00
/**
* meta_window_get_frame: (skip)
Fix gobs of gtk-doc warnings https://bugzilla.gnome.org/show_bug.cgi?id=676856
2013-02-15 18:42:08 +00:00
* @window: a #MetaWindow
introspection: Build with --warn-fatal, drop fix-meta-rectangle.py hack Cleanly build with --warn-fatal. Implementation: * Liberally apply (skip) where the API is clearly C only, e.g. uses XLib. The theming code and MutterPlugin are skipped too. * Add missing (transfer) and (element-type) annotations For a few functions that had a comment, I turned it into gtk-doc, but I didn't (with a few exceptions) try to write new documentation in this pass.
2010-09-01 19:39:53 +00:00
*
*/
src/include/frame.h src/include/display.h src/include/xprops.h 2008-05-19 Iain Holmes <iain@gnome.org> * src/include/frame.h * src/include/display.h * src/include/xprops.h * src/include/compositor.h * src/include/types.h * src/include/window.h * src/include/errors.h * src/include/screen.h: New basic public API for compositor. * src/compositor/*: Separate the compositor out into its own separate directory and set it up for backends. Initial XRender backend. * src/core/compositor.[ch]: Remove * src/core/frame.h * src/core/screen.h * src/core/display.h * src/core/window.h: Rename to -private.h so as not to clash with the new files in include * src/core/delete.c * src/core/workspace.h * src/core/stack.[ch] * src/core/keybindings.[ch] * src/core/errors.c * src/core/effects.[ch] * src/core/core.c * src/core/group.h * src/core/edge-resistance.[ch] * src/core/window-props.[ch] * src/core/constraints.h * src/core/bell.[ch] * src/core/iconcache.h * src/core/session.[ch] * src/core/main.c * src/core/place.h * src/core/xprops.c * src/ui/tabpopup.c: Use the new -private headers * src/core/display.c * src/core/frame.c * src/core/window.c * src/core/screen.c: Add the API functions required by the compositor * src/Makefile.am: Relocate the new files svn path=/trunk/; revision=3715
2008-05-19 00:00:09 +00:00
MetaFrame *
meta_window_get_frame (MetaWindow *window)
{
return window->frame;
}
Export meta_window_appears_focused() Move meta_window_appears_focused() into the public window.h so we can use it to change the shadow type. https://bugzilla.gnome.org/show_bug.cgi?id=592382
2010-11-11 21:04:31 +00:00
/**
* meta_window_appears_focused:
* @window: a #MetaWindow
*
* Determines if the window should be drawn with a focused appearance. This is
* true for focused windows but also true for windows with a focused modal
* dialog attached.
*
* Return value: %TRUE if the window should be drawn with a focused frame
*/
Optionally attach modal dialogs Add a preference /apps/mutter/general/attach_modal_dialogs. When true, instead of having independent titlebars, modal dialogs appear attached to the titlebar of the parent window and are moved together with the parent window. https://bugzilla.gnome.org/show_bug.cgi?id=612726
2010-09-10 09:55:20 +00:00
gboolean
meta_window_appears_focused (MetaWindow *window)
{
window: add an appears-focused property, redraw shadows when it changes We need to redraw a window's shadow any time the value of meta_window_appears_focused() changes. So make that into a property so we can get notifications on it. https://bugzilla.gnome.org/show_bug.cgi?id=636904
2011-03-25 01:36:47 +00:00
return window->has_focus || (window->attached_focus_window != NULL);
Optionally attach modal dialogs Add a preference /apps/mutter/general/attach_modal_dialogs. When true, instead of having independent titlebars, modal dialogs appear attached to the titlebar of the parent window and are moved together with the parent window. https://bugzilla.gnome.org/show_bug.cgi?id=612726
2010-09-10 09:55:20 +00:00
}
src/include/frame.h src/include/display.h src/include/xprops.h 2008-05-19 Iain Holmes <iain@gnome.org> * src/include/frame.h * src/include/display.h * src/include/xprops.h * src/include/compositor.h * src/include/types.h * src/include/window.h * src/include/errors.h * src/include/screen.h: New basic public API for compositor. * src/compositor/*: Separate the compositor out into its own separate directory and set it up for backends. Initial XRender backend. * src/core/compositor.[ch]: Remove * src/core/frame.h * src/core/screen.h * src/core/display.h * src/core/window.h: Rename to -private.h so as not to clash with the new files in include * src/core/delete.c * src/core/workspace.h * src/core/stack.[ch] * src/core/keybindings.[ch] * src/core/errors.c * src/core/effects.[ch] * src/core/core.c * src/core/group.h * src/core/edge-resistance.[ch] * src/core/window-props.[ch] * src/core/constraints.h * src/core/bell.[ch] * src/core/iconcache.h * src/core/session.[ch] * src/core/main.c * src/core/place.h * src/core/xprops.c * src/ui/tabpopup.c: Use the new -private headers * src/core/display.c * src/core/frame.c * src/core/window.c * src/core/screen.c: Add the API functions required by the compositor * src/Makefile.am: Relocate the new files svn path=/trunk/; revision=3715
2008-05-19 00:00:09 +00:00
gboolean
meta_window_has_focus (MetaWindow *window)
{
return window->has_focus;
}
gboolean
meta_window_is_shaded (MetaWindow *window)
{
return window->shaded;
}
Add meta_window_is_override_redirect Trivial function, useful for plugins which are doing analysis of windows.
2009-08-14 09:42:56 +00:00
/**
* meta_window_is_override_redirect:
* @window: A #MetaWindow
*
Fix gobs of gtk-doc warnings https://bugzilla.gnome.org/show_bug.cgi?id=676856
2013-02-15 18:42:08 +00:00
* Returns: %TRUE if this window isn't managed by mutter; it will
Add meta_window_is_override_redirect Trivial function, useful for plugins which are doing analysis of windows.
2009-08-14 09:42:56 +00:00
* control its own positioning and mutter won't draw decorations
* among other things. In X terminology this is "override redirect".
*/
gboolean
meta_window_is_override_redirect (MetaWindow *window)
{
return window->override_redirect;
}
Add meta_window_is_skip_taskbar Accessor for the 'skip-taskbar', which will allow gnome-shell not to consider windows with this hint in its overview thunbnails.
2009-08-28 16:39:55 +00:00
/**
* meta_window_is_skip_taskbar:
* @window: A #MetaWindow
*
* Gets whether this window should be ignored by task lists.
*
* Return value: %TRUE if the skip bar hint is set.
*/
gboolean
meta_window_is_skip_taskbar (MetaWindow *window)
{
g_return_val_if_fail (META_IS_WINDOW (window), FALSE);
return window->skip_taskbar;
}
introspection: Build with --warn-fatal, drop fix-meta-rectangle.py hack Cleanly build with --warn-fatal. Implementation: * Liberally apply (skip) where the API is clearly C only, e.g. uses XLib. The theming code and MutterPlugin are skipped too. * Add missing (transfer) and (element-type) annotations For a few functions that had a comment, I turned it into gtk-doc, but I didn't (with a few exceptions) try to write new documentation in this pass.
2010-09-01 19:39:53 +00:00
/**
* meta_window_get_display:
* @window: A #MetaWindow
*
* Returns: (transfer none): The display for @window
*/
src/include/frame.h src/include/display.h src/include/xprops.h 2008-05-19 Iain Holmes <iain@gnome.org> * src/include/frame.h * src/include/display.h * src/include/xprops.h * src/include/compositor.h * src/include/types.h * src/include/window.h * src/include/errors.h * src/include/screen.h: New basic public API for compositor. * src/compositor/*: Separate the compositor out into its own separate directory and set it up for backends. Initial XRender backend. * src/core/compositor.[ch]: Remove * src/core/frame.h * src/core/screen.h * src/core/display.h * src/core/window.h: Rename to -private.h so as not to clash with the new files in include * src/core/delete.c * src/core/workspace.h * src/core/stack.[ch] * src/core/keybindings.[ch] * src/core/errors.c * src/core/effects.[ch] * src/core/core.c * src/core/group.h * src/core/edge-resistance.[ch] * src/core/window-props.[ch] * src/core/constraints.h * src/core/bell.[ch] * src/core/iconcache.h * src/core/session.[ch] * src/core/main.c * src/core/place.h * src/core/xprops.c * src/ui/tabpopup.c: Use the new -private headers * src/core/display.c * src/core/frame.c * src/core/window.c * src/core/screen.c: Add the API functions required by the compositor * src/Makefile.am: Relocate the new files svn path=/trunk/; revision=3715
2008-05-19 00:00:09 +00:00
MetaDisplay *
meta_window_get_display (MetaWindow *window)
{
return window->display;
}
introspection: Build with --warn-fatal, drop fix-meta-rectangle.py hack Cleanly build with --warn-fatal. Implementation: * Liberally apply (skip) where the API is clearly C only, e.g. uses XLib. The theming code and MutterPlugin are skipped too. * Add missing (transfer) and (element-type) annotations For a few functions that had a comment, I turned it into gtk-doc, but I didn't (with a few exceptions) try to write new documentation in this pass.
2010-09-01 19:39:53 +00:00
/**
* meta_window_get_xwindow: (skip)
Fix gobs of gtk-doc warnings https://bugzilla.gnome.org/show_bug.cgi?id=676856
2013-02-15 18:42:08 +00:00
* @window: a #MetaWindow
introspection: Build with --warn-fatal, drop fix-meta-rectangle.py hack Cleanly build with --warn-fatal. Implementation: * Liberally apply (skip) where the API is clearly C only, e.g. uses XLib. The theming code and MutterPlugin are skipped too. * Add missing (transfer) and (element-type) annotations For a few functions that had a comment, I turned it into gtk-doc, but I didn't (with a few exceptions) try to write new documentation in this pass.
2010-09-01 19:39:53 +00:00
*
*/
src/include/frame.h src/include/display.h src/include/xprops.h 2008-05-19 Iain Holmes <iain@gnome.org> * src/include/frame.h * src/include/display.h * src/include/xprops.h * src/include/compositor.h * src/include/types.h * src/include/window.h * src/include/errors.h * src/include/screen.h: New basic public API for compositor. * src/compositor/*: Separate the compositor out into its own separate directory and set it up for backends. Initial XRender backend. * src/core/compositor.[ch]: Remove * src/core/frame.h * src/core/screen.h * src/core/display.h * src/core/window.h: Rename to -private.h so as not to clash with the new files in include * src/core/delete.c * src/core/workspace.h * src/core/stack.[ch] * src/core/keybindings.[ch] * src/core/errors.c * src/core/effects.[ch] * src/core/core.c * src/core/group.h * src/core/edge-resistance.[ch] * src/core/window-props.[ch] * src/core/constraints.h * src/core/bell.[ch] * src/core/iconcache.h * src/core/session.[ch] * src/core/main.c * src/core/place.h * src/core/xprops.c * src/ui/tabpopup.c: Use the new -private headers * src/core/display.c * src/core/frame.c * src/core/window.c * src/core/screen.c: Add the API functions required by the compositor * src/Makefile.am: Relocate the new files svn path=/trunk/; revision=3715
2008-05-19 00:00:09 +00:00
Window
meta_window_get_xwindow (MetaWindow *window)
{
return window->xwindow;
}
Exposed MetaWindowType so it can be used by compositor backends. meta_window_get_type: meta_window_get_type_atom: Accessors for window type/type atom.
2008-08-18 14:42:38 +00:00
MetaWindowType
Make MetaWindow a GObject Make MetaWindow into a GObject so that it is accessible to gobject-introspection (also allows for signals to be added.) Renames: meta_window_free() => meta_window_unmanage() meta_window_get_type() => meta_window_get_window_type() meta_window_get_type_atom() => meta_window_get_window_type_atom()
2008-11-07 09:57:00 +00:00
meta_window_get_window_type (MetaWindow *window)
Exposed MetaWindowType so it can be used by compositor backends. meta_window_get_type: meta_window_get_type_atom: Accessors for window type/type atom.
2008-08-18 14:42:38 +00:00
{
return window->type;
}
Fix return transfer annotations for a number of functions and add docs Add return transfer annotations (and while I was at it, docs), for public functions that return MetaDisplay, MetaWindow, and MetaScreen. http://bugzilla.gnome.org/show_bug.cgi?id=561297 http://bugzilla.gnome.org/show_bug.cgi?id=580027
2008-11-17 21:34:28 +00:00
/**
* meta_window_get_workspace:
* @window: a #MetaWindow
*
* Gets the #MetaWorkspace that the window is currently displayed on.
* If the window is on all workspaces, returns the currently active
* workspace.
*
* Return value: (transfer none): the #MetaWorkspace for the window
*/
Basic plugin infastructure and a sample simple plugin.
2008-09-18 15:09:11 +00:00
MetaWorkspace *
meta_window_get_workspace (MetaWindow *window)
{
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
MetaWorkspaceManager *workspace_manager = window->display->workspace_manager;
Basic plugin infastructure and a sample simple plugin.
2008-09-18 15:09:11 +00:00
if (window->on_all_workspaces)
Move workspace related code from MetaDisplay to MetaWorkspaceManager https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 19:02:40 +00:00
return workspace_manager->active_workspace;
workspace: Rewrite workspace management code The existing workspace management code is quite hairy, with plenty of logic inline in all of window.c, workspace.c, and screen.c, making it hard to understand or make changes to, since you might forget to change several of the other places the code was around. Rewrite the internal workspace management logic so that it's centralized and all in window.c. Document the invariants we need to maintain, and ensure that these invariants are properly kept, with asserts in various places. Extensive testing on gnome-shell did not bring up any issues, and this is a considerable cleanup.
2014-08-16 17:22:05 +00:00
else
return window->workspace;
Basic plugin infastructure and a sample simple plugin.
2008-09-18 15:09:11 +00:00
}
gboolean
meta_window_is_on_all_workspaces (MetaWindow *window)
{
return window->on_all_workspaces;
}
Live previews for hidden windows. ClutterActors for hidden windows (such windows on different than active workspaces and windows that are minimized) are available, and reflect the actual state of the window. This is intended for use in task-switchers etc. This feature is disabled by default (due to increased demand on resources), and can be enabled through the metacity/general/live_hidden_windows gconf key. A trivial sample window switcher is included in the scratch plugin (activated by clicking on the slide out panel).
2008-10-24 09:07:24 +00:00
gboolean
meta_window_is_hidden (MetaWindow *window)
{
return window->hidden;
}
mutter_window_get_description() Human redable description useful for debugging, now accessible to plugins and and also for override redirect windows.
2008-10-30 08:30:42 +00:00
const char *
meta_window_get_description (MetaWindow *window)
{
if (!window)
return NULL;
return window->desc;
}
Adds support in src/core for tracking override redirect windows. The metacity core is now directly aware of override redirect windows. - They get MetaWindows like normal windows, so mutter no longer need to special case them. The net wm types applicable to override redirects are also recognised. - The original positioning/stacking semantics of metacity with respect to OR windows are maintained, but now it's easier to synchronize the stacking between the core and mutter. - mutter no longer needs to manualy track UnmapNotify, MapNotify, ReparentNotify, CreateNotify and DestroyNotify events; instead map, unmap, add and remove events can now be consistently delivered via the MetaCompositor callbacks.
2008-11-23 19:28:40 +00:00
Add meta_window_get_wm_class Public function to retrieve the cached WM_CLASS, used in gnome-shell for tracking applications.
2009-05-29 17:26:18 +00:00
/**
* meta_window_get_wm_class:
* @window: a #MetaWindow
[MetaWindow] Accessor for the instance part of WM_CLASS property https://bugzilla.gnome.org/show_bug.cgi?id=613128
2010-03-17 09:20:39 +00:00
*
* Return the current value of the name part of WM_CLASS X property.
Add meta_window_get_wm_class Public function to retrieve the cached WM_CLASS, used in gnome-shell for tracking applications.
2009-05-29 17:26:18 +00:00
*/
const char *
meta_window_get_wm_class (MetaWindow *window)
{
if (!window)
return NULL;
return window->res_class;
}
[MetaWindow] Accessor for the instance part of WM_CLASS property https://bugzilla.gnome.org/show_bug.cgi?id=613128
2010-03-17 09:20:39 +00:00
/**
* meta_window_get_wm_class_instance:
* @window: a #MetaWindow
*
* Return the current value of the instance part of WM_CLASS X property.
*/
const char *
meta_window_get_wm_class_instance (MetaWindow *window)
{
if (!window)
return NULL;
return window->res_name;
}
window: Expose Flatpak application ID GNOME Shell's window matching currently fails frequently with Flatpak applications, as one of the primary hints used to link windows with .desktop files - the WM_CLASS - no longer matches when flatpak renames the exported .desktop file. Luckily, Flatpak provides us with a fail-safe way to map from the PID to the corresponding application ID, so expose an appropriate method that allows GNOME Shell to reliably match windows to the corresponding Flatpak app. https://bugzilla.gnome.org/show_bug.cgi?id=772614
2016-10-07 15:55:32 +00:00
/**
window: rename get_flatpack_id into get_sandboxed_app_id This function can be more generic now. https://bugzilla.gnome.org/show_bug.cgi?id=789277
2017-10-21 02:45:23 +00:00
* meta_window_get_sandboxed_app_id:
window: Expose Flatpak application ID GNOME Shell's window matching currently fails frequently with Flatpak applications, as one of the primary hints used to link windows with .desktop files - the WM_CLASS - no longer matches when flatpak renames the exported .desktop file. Luckily, Flatpak provides us with a fail-safe way to map from the PID to the corresponding application ID, so expose an appropriate method that allows GNOME Shell to reliably match windows to the corresponding Flatpak app. https://bugzilla.gnome.org/show_bug.cgi?id=772614
2016-10-07 15:55:32 +00:00
* @window: a #MetaWindow
*
window: rename get_flatpack_id into get_sandboxed_app_id This function can be more generic now. https://bugzilla.gnome.org/show_bug.cgi?id=789277
2017-10-21 02:45:23 +00:00
* Gets an unique id for a sandboxed app (currently flatpaks and snaps are
* supported).
*
* Return value: (transfer none): the sandboxed application ID or %NULL
window: Expose Flatpak application ID GNOME Shell's window matching currently fails frequently with Flatpak applications, as one of the primary hints used to link windows with .desktop files - the WM_CLASS - no longer matches when flatpak renames the exported .desktop file. Luckily, Flatpak provides us with a fail-safe way to map from the PID to the corresponding application ID, so expose an appropriate method that allows GNOME Shell to reliably match windows to the corresponding Flatpak app. https://bugzilla.gnome.org/show_bug.cgi?id=772614
2016-10-07 15:55:32 +00:00
**/
const char *
window: rename get_flatpack_id into get_sandboxed_app_id This function can be more generic now. https://bugzilla.gnome.org/show_bug.cgi?id=789277
2017-10-21 02:45:23 +00:00
meta_window_get_sandboxed_app_id (MetaWindow *window)
window: Expose Flatpak application ID GNOME Shell's window matching currently fails frequently with Flatpak applications, as one of the primary hints used to link windows with .desktop files - the WM_CLASS - no longer matches when flatpak renames the exported .desktop file. Luckily, Flatpak provides us with a fail-safe way to map from the PID to the corresponding application ID, so expose an appropriate method that allows GNOME Shell to reliably match windows to the corresponding Flatpak app. https://bugzilla.gnome.org/show_bug.cgi?id=772614
2016-10-07 15:55:32 +00:00
{
window: Support snap packages for sandboxed app IDs For now we abuse of meta_window_get_flatpak_id not to break the APIs, so that it's working seamlessly in gnone shell too. Rename flatpak_id to sandboxed_app_id internally to get prepared to the future API. https://bugzilla.gnome.org/show_bug.cgi?id=788217
2017-09-26 21:22:43 +00:00
/* We're abusing this API here not to break the gnome shell assumptions
* or adding a new function, to be renamed to generic names in new versions */
return window->sandboxed_app_id;
window: Expose Flatpak application ID GNOME Shell's window matching currently fails frequently with Flatpak applications, as one of the primary hints used to link windows with .desktop files - the WM_CLASS - no longer matches when flatpak renames the exported .desktop file. Luckily, Flatpak provides us with a fail-safe way to map from the PID to the corresponding application ID, so expose an appropriate method that allows GNOME Shell to reliably match windows to the corresponding Flatpak app. https://bugzilla.gnome.org/show_bug.cgi?id=772614
2016-10-07 15:55:32 +00:00
}
window: Add accessor method for gtk_theme_variant This is useful information for UI associated with a window, so add a corresponding method. https://bugzilla.gnome.org/show_bug.cgi?id=730752
2014-05-25 14:57:15 +00:00
/**
* meta_window_get_gtk_theme_variant:
* @window: a #MetaWindow
*
* Return value: (transfer none): the theme variant or %NULL
**/
const char *
meta_window_get_gtk_theme_variant (MetaWindow *window)
{
return window->gtk_theme_variant;
}
Load _DBUS_APPLICATION_ID property, expose it via API This is used to associate GtkApplication -> X window, and will be consumed by gnome-shell. https://bugzilla.gnome.org/show_bug.cgi?id=664851
2011-11-25 23:42:41 +00:00
/**
adjust to new Gtk properties for app menu https://bugzilla.gnome.org/show_bug.cgi?id=668118
2012-01-17 18:27:10 +00:00
* meta_window_get_gtk_application_id:
Load _DBUS_APPLICATION_ID property, expose it via API This is used to associate GtkApplication -> X window, and will be consumed by gnome-shell. https://bugzilla.gnome.org/show_bug.cgi?id=664851
2011-11-25 23:42:41 +00:00
* @window: a #MetaWindow
*
* Return value: (transfer none): the application ID
**/
const char *
adjust to new Gtk properties for app menu https://bugzilla.gnome.org/show_bug.cgi?id=668118
2012-01-17 18:27:10 +00:00
meta_window_get_gtk_application_id (MetaWindow *window)
Load _DBUS_APPLICATION_ID property, expose it via API This is used to associate GtkApplication -> X window, and will be consumed by gnome-shell. https://bugzilla.gnome.org/show_bug.cgi?id=664851
2011-11-25 23:42:41 +00:00
{
adjust to new Gtk properties for app menu https://bugzilla.gnome.org/show_bug.cgi?id=668118
2012-01-17 18:27:10 +00:00
return window->gtk_application_id;
Load _DBUS_APPLICATION_ID property, expose it via API This is used to associate GtkApplication -> X window, and will be consumed by gnome-shell. https://bugzilla.gnome.org/show_bug.cgi?id=664851
2011-11-25 23:42:41 +00:00
}
Add _DBUS_UNIQUE_NAME and _OBJECT_PATH properties https://bugzilla.gnome.org/show_bug.cgi?id=664851
2011-12-05 17:52:35 +00:00
/**
adjust to new Gtk properties for app menu https://bugzilla.gnome.org/show_bug.cgi?id=668118
2012-01-17 18:27:10 +00:00
* meta_window_get_gtk_unique_bus_name:
Add _DBUS_UNIQUE_NAME and _OBJECT_PATH properties https://bugzilla.gnome.org/show_bug.cgi?id=664851
2011-12-05 17:52:35 +00:00
* @window: a #MetaWindow
*
* Return value: (transfer none): the unique name
**/
const char *
adjust to new Gtk properties for app menu https://bugzilla.gnome.org/show_bug.cgi?id=668118
2012-01-17 18:27:10 +00:00
meta_window_get_gtk_unique_bus_name (MetaWindow *window)
{
return window->gtk_unique_bus_name;
}
/**
* meta_window_get_gtk_application_object_path:
* @window: a #MetaWindow
*
* Return value: (transfer none): the object path
**/
const char *
meta_window_get_gtk_application_object_path (MetaWindow *window)
{
return window->gtk_application_object_path;
}
/**
* meta_window_get_gtk_window_object_path:
* @window: a #MetaWindow
*
* Return value: (transfer none): the object path
**/
const char *
meta_window_get_gtk_window_object_path (MetaWindow *window)
{
return window->gtk_window_object_path;
}
/**
* meta_window_get_gtk_app_menu_object_path:
* @window: a #MetaWindow
*
* Return value: (transfer none): the object path
**/
const char *
meta_window_get_gtk_app_menu_object_path (MetaWindow *window)
Add _DBUS_UNIQUE_NAME and _OBJECT_PATH properties https://bugzilla.gnome.org/show_bug.cgi?id=664851
2011-12-05 17:52:35 +00:00
{
adjust to new Gtk properties for app menu https://bugzilla.gnome.org/show_bug.cgi?id=668118
2012-01-17 18:27:10 +00:00
return window->gtk_app_menu_object_path;
Add _DBUS_UNIQUE_NAME and _OBJECT_PATH properties https://bugzilla.gnome.org/show_bug.cgi?id=664851
2011-12-05 17:52:35 +00:00
}
/**
adjust to new Gtk properties for app menu https://bugzilla.gnome.org/show_bug.cgi?id=668118
2012-01-17 18:27:10 +00:00
* meta_window_get_gtk_menubar_object_path:
Add _DBUS_UNIQUE_NAME and _OBJECT_PATH properties https://bugzilla.gnome.org/show_bug.cgi?id=664851
2011-12-05 17:52:35 +00:00
* @window: a #MetaWindow
*
* Return value: (transfer none): the object path
**/
const char *
adjust to new Gtk properties for app menu https://bugzilla.gnome.org/show_bug.cgi?id=668118
2012-01-17 18:27:10 +00:00
meta_window_get_gtk_menubar_object_path (MetaWindow *window)
Add _DBUS_UNIQUE_NAME and _OBJECT_PATH properties https://bugzilla.gnome.org/show_bug.cgi?id=664851
2011-12-05 17:52:35 +00:00
{
adjust to new Gtk properties for app menu https://bugzilla.gnome.org/show_bug.cgi?id=668118
2012-01-17 18:27:10 +00:00
return window->gtk_menubar_object_path;
Add _DBUS_UNIQUE_NAME and _OBJECT_PATH properties https://bugzilla.gnome.org/show_bug.cgi?id=664851
2011-12-05 17:52:35 +00:00
}
Make compositor private a GObject than a void pointer Requiring the compositor private object to be a GObject allows the return value of meta_window_get_compositor_private() to be used via gobject-introspection, since the type and memory management can be determined. This allows a reverse mapping from MetaWindow to MutterWindow. - Change meta_window_get/set_compositor_private to use GObject rather than void * - Adapt code in compositor-mutter.c to match.
2009-02-02 20:16:05 +00:00
/**
* meta_window_get_compositor_private:
* @window: a #MetaWindow
*
* Gets the compositor's wrapper object for @window.
*
* Return value: (transfer none): the wrapper object.
**/
GObject *
Adds support in src/core for tracking override redirect windows. The metacity core is now directly aware of override redirect windows. - They get MetaWindows like normal windows, so mutter no longer need to special case them. The net wm types applicable to override redirects are also recognised. - The original positioning/stacking semantics of metacity with respect to OR windows are maintained, but now it's easier to synchronize the stacking between the core and mutter. - mutter no longer needs to manualy track UnmapNotify, MapNotify, ReparentNotify, CreateNotify and DestroyNotify events; instead map, unmap, add and remove events can now be consistently delivered via the MetaCompositor callbacks.
2008-11-23 19:28:40 +00:00
meta_window_get_compositor_private (MetaWindow *window)
{
if (!window)
return NULL;
return window->compositor_private;
}
void
Make compositor private a GObject than a void pointer Requiring the compositor private object to be a GObject allows the return value of meta_window_get_compositor_private() to be used via gobject-introspection, since the type and memory management can be determined. This allows a reverse mapping from MetaWindow to MutterWindow. - Change meta_window_get/set_compositor_private to use GObject rather than void * - Adapt code in compositor-mutter.c to match.
2009-02-02 20:16:05 +00:00
meta_window_set_compositor_private (MetaWindow *window, GObject *priv)
Adds support in src/core for tracking override redirect windows. The metacity core is now directly aware of override redirect windows. - They get MetaWindows like normal windows, so mutter no longer need to special case them. The net wm types applicable to override redirects are also recognised. - The original positioning/stacking semantics of metacity with respect to OR windows are maintained, but now it's easier to synchronize the stacking between the core and mutter. - mutter no longer needs to manualy track UnmapNotify, MapNotify, ReparentNotify, CreateNotify and DestroyNotify events; instead map, unmap, add and remove events can now be consistently delivered via the MetaCompositor callbacks.
2008-11-23 19:28:40 +00:00
{
if (!window)
return;
window->compositor_private = priv;
}
Added meta_window_get_role().
2009-01-12 12:30:31 +00:00
const char *
meta_window_get_role (MetaWindow *window)
{
if (!window)
return NULL;
return window->role;
}
Add meta_window_get_title() method Update meta_window_get_title() as per comments
2009-06-10 03:02:14 +00:00
/**
* meta_window_get_title:
* @window: a #MetaWindow
*
Fix gobs of gtk-doc warnings https://bugzilla.gnome.org/show_bug.cgi?id=676856
2013-02-15 18:42:08 +00:00
* Returns: the current title of the window.
Add meta_window_get_title() method Update meta_window_get_title() as per comments
2009-06-10 03:02:14 +00:00
*/
const char *
meta_window_get_title (MetaWindow *window)
{
g_return_val_if_fail (META_IS_WINDOW (window), NULL);
return window->title;
}
Add a MetaScreen:restacked signal and expose MetaWindow.layer Expose restacking and a window's stack layer to allow a compositor to insert elements into the window stack in the right location. (See Bug 571827 – hide panel when screensaver is active) src/core/stack.h src/include/common.h: Move MetaStackLayer to a public header. src/core/screen.c src/core/screen-private.h src/core/stack.c: Add a ::restacked signal emitted after we finish restracking. src/core/window.h src/include/window.h: Add meta_window_get_layer()
2009-03-12 21:07:27 +00:00
MetaStackLayer
meta_window_get_layer (MetaWindow *window)
{
return window->layer;
}
Add meta_window_get_transient_for() method
2009-06-10 03:28:21 +00:00
/**
* meta_window_get_transient_for:
* @window: a #MetaWindow
*
* Returns the #MetaWindow for the window that is pointed to by the
* WM_TRANSIENT_FOR hint on this window (see XGetTransientForHint()
* or XSetTransientForHint()). Metacity keeps transient windows above their
* parents. A typical usage of this hint is for a dialog that wants to stay
* above its associated window.
*
* Return value: (transfer none): the window this window is transient for, or
* %NULL if the WM_TRANSIENT_FOR hint is unset or does not point to a toplevel
* window that Metacity knows about.
*/
MetaWindow *
meta_window_get_transient_for (MetaWindow *window)
{
g_return_val_if_fail (META_IS_WINDOW (window), NULL);
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
if (window->transient_for)
return window->transient_for;
else if (window->xtransient_for)
Move alarm and xids management to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 16:56:44 +00:00
return meta_x11_display_lookup_x_window (window->display->x11_display,
window->xtransient_for);
Add meta_window_get_transient_for() method
2009-06-10 03:28:21 +00:00
else
return NULL;
}
Accessors for pid and name of client machine associated with MetaWindow http://bugzilla.gnome.org/show_bug.cgi?id=590388
2009-07-31 17:52:25 +00:00
window: Add get_client_pid() method It is often useful to identify the client process that created a particular window, however the existing meta_window_get_pid() method relies on _NET_WM_PID, which is only available on X11 and depends on applications to set it correctly (which may not even be possible when the app runs in its own PID namespace as Flatpak apps do). So add a get_client_pid() method that uses windowing system facilities to resolve the PID associated with a particular window. https://bugzilla.gnome.org/show_bug.cgi?id=772613
2016-10-07 15:55:32 +00:00
/**
* meta_window_get_client_pid:
* @window: a #MetaWindow
*
* Returns the pid of the process that created this window, if available
* to the windowing system.
*
* Return value: the pid, or 0 if not known.
*/
uint32_t
meta_window_get_client_pid (MetaWindow *window)
{
return META_WINDOW_GET_CLASS (window)->get_client_pid (window);
}
Accessors for pid and name of client machine associated with MetaWindow http://bugzilla.gnome.org/show_bug.cgi?id=590388
2009-07-31 17:52:25 +00:00
/**
* meta_window_get_pid:
* @window: a #MetaWindow
*
* Returns pid of the process that created this window, if known (obtained from
* the _NET_WM_PID property).
*
window: Remove invalid (transfer) annnotations This tripped a new g-i warning; see https://bugzilla.gnome.org/show_bug.cgi?id=752047
2015-09-27 20:42:01 +00:00
* Return value: the pid, or -1 if not known.
Accessors for pid and name of client machine associated with MetaWindow http://bugzilla.gnome.org/show_bug.cgi?id=590388
2009-07-31 17:52:25 +00:00
*/
int
meta_window_get_pid (MetaWindow *window)
{
g_return_val_if_fail (META_IS_WINDOW (window), -1);
return window->net_wm_pid;
}
/**
* meta_window_get_client_machine:
* @window: a #MetaWindow
*
* Returns name of the client machine from which this windows was created,
* if known (obtained from the WM_CLIENT_MACHINE property).
*
* Return value: (transfer none): the machine name, or NULL; the string is
* owned by the window manager and should not be freed or modified by the
* caller.
*/
const char *
meta_window_get_client_machine (MetaWindow *window)
{
g_return_val_if_fail (META_IS_WINDOW (window), NULL);
return window->wm_client_machine;
}
Add meta_window_is_remote It's useful for plugins to be able to easily detect whether or not a window is from a remote host. Also, make use of this in the window delete codepath, instead of looking up the hostname each time. https://bugzilla.gnome.org/show_bug.cgi?id=620585
2010-06-04 17:57:41 +00:00
/**
* meta_window_is_remote:
* @window: a #MetaWindow
*
* Returns: %TRUE if this window originates from a host
* different from the one running mutter.
*/
gboolean
meta_window_is_remote (MetaWindow *window)
{
window: fix meta_window_is_remote across hostname changes meta_window_is_remote compares a cached copy of the system hostname with the hostname of the client window (as presented by the WM_CLIENT_MACHINE property). Of course, the system hostname can change at any time, so caching it is wrong. Also, the WM_CLIENT_MACHINE property won't necessarily change when the system hostname changes, so comparing it with the new system hostname is wrong, too. This commit makes the code call gethostname() at the time WM_CLIENT_MACHINE is set, check whether it's remote then, and cache that value, rather than comparing potentially out of sync hostnames later. https://bugzilla.gnome.org/show_bug.cgi?id=688716
2013-02-20 20:17:21 +00:00
return window->is_remote;
Add meta_window_is_remote It's useful for plugins to be able to easily detect whether or not a window is from a remote host. Also, make use of this in the window delete codepath, instead of looking up the hostname each time. https://bugzilla.gnome.org/show_bug.cgi?id=620585
2010-06-04 17:57:41 +00:00
}
_MUTTER_HINTS A per-window _MUTTER_HINTS property allowing plugins to use custom hints. The property holds a colon separated list of key=value pairs; plugin-specific keys must be suitably namespaced, while 'mutter-' prefix is reserved for internal Mutter use only. This commit adds MetaWindow::mutter-hints property, and meta_window_get_mutter_hints() accessor, as well as the internal machinery for reading and updating of the hints. https://bugzilla.gnome.org/show_bug.cgi?id=613123
2010-01-18 10:12:17 +00:00
/**
* meta_window_get_mutter_hints:
* @window: a #MetaWindow
*
* Gets the current value of the _MUTTER_HINTS property.
*
* The purpose of the hints is to allow fine-tuning of the Window Manager and
* Compositor behaviour on per-window basis, and is intended primarily for
* hints that are plugin-specific.
*
* The property is a list of colon-separated key=value pairs. The key names for
* any plugin-specific hints must be suitably namespaced to allow for shared
* use; 'mutter-' key prefix is reserved for internal use, and must not be used
* by plugins.
*
* Return value: (transfer none): the _MUTTER_HINTS string, or %NULL if no hints
* are set.
*/
const char *
meta_window_get_mutter_hints (MetaWindow *window)
{
g_return_val_if_fail (META_IS_WINDOW (window), NULL);
return window->mutter_hints;
}
Add meta_window_get_frame_type() Add a public function to get the frame type for a window; the code is refactored from existing code in core.c. https://bugzilla.gnome.org/show_bug.cgi?id=592382
2010-11-11 21:12:11 +00:00
/**
* meta_window_get_frame_type:
* @window: a #MetaWindow
*
* Gets the type of window decorations that should be used for this window.
*
* Return value: the frame type
*/
MetaFrameType
meta_window_get_frame_type (MetaWindow *window)
{
MetaFrameType base_type = META_FRAME_TYPE_LAST;
switch (window->type)
{
case META_WINDOW_NORMAL:
base_type = META_FRAME_TYPE_NORMAL;
break;
case META_WINDOW_DIALOG:
base_type = META_FRAME_TYPE_DIALOG;
break;
case META_WINDOW_MODAL_DIALOG:
window: make determination of attached dialog windows more consistent Different bits of code were using slightly different checks to test whether a window was an attached dialog. Add a new meta_window_is_attached_dialog(), and use that everywhere. Also, freeze the is-attached status when the window is first shown, rather than recomputing it each time the caller asks, since this could cause problems if a window changes its type after it has already been attached, etc. However, if an attached window's parent is destroyed, or an attached window changes its transient-for, then fix things up by destroying the old MetaWindow and creating a new one (causing compositor unmap and map events to be fired off, allowing the display of the window to be fixed up). Remove some code in display.c that tried to fix existing windows if the gconf setting changed, but which didn't actually do anything (at least under gnome-shell). However, if 654643 was fixed then the new behavior with this patch would be that changing the gconf setting would affect new dialogs, but not existing ones. https://bugzilla.gnome.org/show_bug.cgi?id=646761
2011-04-05 14:14:52 +00:00
if (meta_window_is_attached_dialog (window))
Add meta_window_get_frame_type() Add a public function to get the frame type for a window; the code is refactored from existing code in core.c. https://bugzilla.gnome.org/show_bug.cgi?id=592382
2010-11-11 21:12:11 +00:00
base_type = META_FRAME_TYPE_ATTACHED;
else
base_type = META_FRAME_TYPE_MODAL_DIALOG;
break;
case META_WINDOW_MENU:
base_type = META_FRAME_TYPE_MENU;
break;
case META_WINDOW_UTILITY:
base_type = META_FRAME_TYPE_UTILITY;
break;
case META_WINDOW_DESKTOP:
case META_WINDOW_DOCK:
case META_WINDOW_TOOLBAR:
case META_WINDOW_SPLASHSCREEN:
case META_WINDOW_DROPDOWN_MENU:
case META_WINDOW_POPUP_MENU:
case META_WINDOW_TOOLTIP:
case META_WINDOW_NOTIFICATION:
case META_WINDOW_COMBO:
case META_WINDOW_DND:
case META_WINDOW_OVERRIDE_OTHER:
/* No frame */
base_type = META_FRAME_TYPE_LAST;
break;
}
if (base_type == META_FRAME_TYPE_LAST)
{
/* can't add border if undecorated */
return META_FRAME_TYPE_LAST;
}
x11: Remove hide-titlebar-when-maximized support It's a UI pattern that has been superseded by client-side decorations, apps that used to set the hint have generally moved on to headerbars. Given that and the limitation to server-side decorated X11 windows, GTK4 removed the client-side API for setting the hint, it's time to follow suite and retire the feature. https://gitlab.gnome.org/GNOME/mutter/merge_requests/221
2018-09-08 11:26:13 +00:00
else if (window->border_only)
Add meta_window_get_frame_type() Add a public function to get the frame type for a window; the code is refactored from existing code in core.c. https://bugzilla.gnome.org/show_bug.cgi?id=592382
2010-11-11 21:12:11 +00:00
{
/* override base frame type */
return META_FRAME_TYPE_BORDER;
}
else
{
return base_type;
}
}
Only shadow ARGB windows with a frame outside the frame An ARGB window with a frame is likely something like a transparent terminal. It looks awful (and breaks transparency) to draw a big opaque black shadow under the window, so clip out the region under the terminal from the shadow we draw. Add meta_window_get_frame_bounds() to get a cairo region for the outer bounds of the frame of a window, and modify the frame handling code to notice changes to the frame shape and discard a cached region. meta_frames_apply_shapes() is refactored so we can extract meta_frames_get_frame_bounds() from it. https://bugzilla.gnome.org/show_bug.cgi?id=635268
2011-03-22 19:36:12 +00:00
/**
* meta_window_get_frame_bounds:
Fix gobs of gtk-doc warnings https://bugzilla.gnome.org/show_bug.cgi?id=676856
2013-02-15 18:42:08 +00:00
* @window: a #MetaWindow
Only shadow ARGB windows with a frame outside the frame An ARGB window with a frame is likely something like a transparent terminal. It looks awful (and breaks transparency) to draw a big opaque black shadow under the window, so clip out the region under the terminal from the shadow we draw. Add meta_window_get_frame_bounds() to get a cairo region for the outer bounds of the frame of a window, and modify the frame handling code to notice changes to the frame shape and discard a cached region. meta_frames_apply_shapes() is refactored so we can extract meta_frames_get_frame_bounds() from it. https://bugzilla.gnome.org/show_bug.cgi?id=635268
2011-03-22 19:36:12 +00:00
*
* Gets a region representing the outer bounds of the window's frame.
*
Update (allow-none) annotations The annotation has been deprecated in favor of (nullable) and/or (optional).
2014-05-28 19:44:23 +00:00
* Return value: (transfer none) (nullable): a #cairo_region_t
Only shadow ARGB windows with a frame outside the frame An ARGB window with a frame is likely something like a transparent terminal. It looks awful (and breaks transparency) to draw a big opaque black shadow under the window, so clip out the region under the terminal from the shadow we draw. Add meta_window_get_frame_bounds() to get a cairo region for the outer bounds of the frame of a window, and modify the frame handling code to notice changes to the frame shape and discard a cached region. meta_frames_apply_shapes() is refactored so we can extract meta_frames_get_frame_bounds() from it. https://bugzilla.gnome.org/show_bug.cgi?id=635268
2011-03-22 19:36:12 +00:00
* holding the outer bounds of the window, or %NULL if the window
* doesn't have a frame.
*/
cairo_region_t *
meta_window_get_frame_bounds (MetaWindow *window)
{
if (!window->frame_bounds)
{
if (window->frame)
window->frame_bounds = meta_frame_get_frame_bounds (window->frame);
}
return window->frame_bounds;
}
window: make determination of attached dialog windows more consistent Different bits of code were using slightly different checks to test whether a window was an attached dialog. Add a new meta_window_is_attached_dialog(), and use that everywhere. Also, freeze the is-attached status when the window is first shown, rather than recomputing it each time the caller asks, since this could cause problems if a window changes its type after it has already been attached, etc. However, if an attached window's parent is destroyed, or an attached window changes its transient-for, then fix things up by destroying the old MetaWindow and creating a new one (causing compositor unmap and map events to be fired off, allowing the display of the window to be fixed up). Remove some code in display.c that tried to fix existing windows if the gconf setting changed, but which didn't actually do anything (at least under gnome-shell). However, if 654643 was fixed then the new behavior with this patch would be that changing the gconf setting would affect new dialogs, but not existing ones. https://bugzilla.gnome.org/show_bug.cgi?id=646761
2011-04-05 14:14:52 +00:00
/**
* meta_window_is_attached_dialog:
* @window: a #MetaWindow
*
* Tests if @window is should be attached to its parent window.
* (If the "attach_modal_dialogs" option is not enabled, this will
* always return %FALSE.)
*
* Return value: whether @window should be attached to its parent
*/
gboolean
meta_window_is_attached_dialog (MetaWindow *window)
{
return window->attached;
}
window: Introduce meta_window_get_tile_match() Returns the matching tiled window. This is the topmost tiled window in a complementary tile mode that is: - on the same monitor; - on the same workspace; - spanning the remaining monitor width; - there is no 3rd window stacked between both tiled windows that's partially visible in the common edge. https://bugzilla.gnome.org/show_bug.cgi?id=643075
2012-02-24 16:08:55 +00:00
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
/**
* meta_window_get_tile_match:
* @window: a #MetaWindow
*
* Returns the matching tiled window on the same monitor as @window. This is
* the topmost tiled window in a complementary tile mode that is:
*
* - on the same monitor;
* - on the same workspace;
* - spanning the remaining monitor width;
* - there is no 3rd window stacked between both tiled windows that's
* partially visible in the common edge.
*
* Return value: (transfer none) (nullable): the matching tiled window or
* %NULL if it doesn't exist.
*/
MetaWindow *
meta_window_get_tile_match (MetaWindow *window)
{
return window->tile_match;
}
void
meta_window_compute_tile_match (MetaWindow *window)
window: Tile and resize considering the tile match After the introduction of the possibility to resize tiled windows, it is a sensible decision to make windows aware of their tiling match. A tiling match is another window that is tiled in such a way that is the complement of the current window. The newly introduced behavior attepts to make tiling as smooth as possible, with the following rules: * Windows now compute their tile match when tiling and, if there's a match, they automatically complement the sibling's width. * Resizing a window with a sibling automatically resizes the sibling too to be the complement of the window's width. * It is not possible to resize below windows' minimum widths. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-12 01:13:03 +00:00
{
window->tile_match = meta_window_find_tile_match (window, window->tile_mode);
}
static MetaWindow *
meta_window_find_tile_match (MetaWindow *window,
MetaTileMode current_mode)
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
{
MetaWindow *match;
MetaStack *stack;
MetaTileMode match_tile_mode = META_TILE_NONE;
if (window->shaded || window->minimized)
window: Tile and resize considering the tile match After the introduction of the possibility to resize tiled windows, it is a sensible decision to make windows aware of their tiling match. A tiling match is another window that is tiled in such a way that is the complement of the current window. The newly introduced behavior attepts to make tiling as smooth as possible, with the following rules: * Windows now compute their tile match when tiling and, if there's a match, they automatically complement the sibling's width. * Resizing a window with a sibling automatically resizes the sibling too to be the complement of the window's width. * It is not possible to resize below windows' minimum widths. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-12 01:13:03 +00:00
return NULL;
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
window: Tile and resize considering the tile match After the introduction of the possibility to resize tiled windows, it is a sensible decision to make windows aware of their tiling match. A tiling match is another window that is tiled in such a way that is the complement of the current window. The newly introduced behavior attepts to make tiling as smooth as possible, with the following rules: * Windows now compute their tile match when tiling and, if there's a match, they automatically complement the sibling's width. * Resizing a window with a sibling automatically resizes the sibling too to be the complement of the window's width. * It is not possible to resize below windows' minimum widths. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-12 01:13:03 +00:00
if (current_mode == META_TILE_LEFT)
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
match_tile_mode = META_TILE_RIGHT;
window: Tile and resize considering the tile match After the introduction of the possibility to resize tiled windows, it is a sensible decision to make windows aware of their tiling match. A tiling match is another window that is tiled in such a way that is the complement of the current window. The newly introduced behavior attepts to make tiling as smooth as possible, with the following rules: * Windows now compute their tile match when tiling and, if there's a match, they automatically complement the sibling's width. * Resizing a window with a sibling automatically resizes the sibling too to be the complement of the window's width. * It is not possible to resize below windows' minimum widths. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-12 01:13:03 +00:00
else if (current_mode == META_TILE_RIGHT)
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
match_tile_mode = META_TILE_LEFT;
else
window: Tile and resize considering the tile match After the introduction of the possibility to resize tiled windows, it is a sensible decision to make windows aware of their tiling match. A tiling match is another window that is tiled in such a way that is the complement of the current window. The newly introduced behavior attepts to make tiling as smooth as possible, with the following rules: * Windows now compute their tile match when tiling and, if there's a match, they automatically complement the sibling's width. * Resizing a window with a sibling automatically resizes the sibling too to be the complement of the window's width. * It is not possible to resize below windows' minimum widths. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-12 01:13:03 +00:00
return NULL;
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
stack = window->display->stack;
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
for (match = meta_stack_get_top (stack);
match;
match = meta_stack_get_below (stack, match, FALSE))
{
if (!match->shaded &&
!match->minimized &&
match->tile_mode == match_tile_mode &&
window: Tile and resize considering the tile match After the introduction of the possibility to resize tiled windows, it is a sensible decision to make windows aware of their tiling match. A tiling match is another window that is tiled in such a way that is the complement of the current window. The newly introduced behavior attepts to make tiling as smooth as possible, with the following rules: * Windows now compute their tile match when tiling and, if there's a match, they automatically complement the sibling's width. * Resizing a window with a sibling automatically resizes the sibling too to be the complement of the window's width. * It is not possible to resize below windows' minimum widths. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-12 01:13:03 +00:00
match->tile_monitor_number == window->tile_monitor_number &&
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
meta_window_get_workspace (match) == meta_window_get_workspace (window))
break;
}
if (match)
{
MetaWindow *above, *bottommost, *topmost;
MetaRectangle above_rect, bottommost_rect, topmost_rect;
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
if (meta_stack_windows_cmp (window->display->stack, match, window) > 0)
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
{
topmost = match;
bottommost = window;
}
else
{
topmost = window;
bottommost = match;
}
meta_window_get_frame_rect (bottommost, &bottommost_rect);
meta_window_get_frame_rect (topmost, &topmost_rect);
window: Also consider touching edges for matching tiled windows When computing a potential match for a tiled window, there is a chance we face the case where 2 windows really complement each other's tile mode (i.e. left and right) but they have different sizes, and their borders don't really touch each other. In that case, the current code would mistakenly assume they're tile matches, and would resize them with either a hole or an overlapping area between windows. This is clearly a misbehavior that is a consequence of the previous assumptions pre-resizable tiles. This patch adapts the tile match algorithm to also consider the touching edges when computing the matching tile, unless: * the window is not currently tiled (for example when computing the tile preview) * the window is currently resized in tandem with an existing tile match https://bugzilla.gnome.org/show_bug.cgi?id=645153 bar
2017-06-16 00:29:48 +00:00
/*
* If we are looking for a tile match while actually being tiled,
* rather than a match for a potential tile mode, then discard
* windows with too much gap or overlap
*/
if (window->tile_mode == current_mode &&
!(meta_grab_op_is_resizing (window->display->grab_op) &&
window->display->grab_window == window &&
window->tile_match != NULL))
{
int threshold = meta_prefs_get_drag_threshold ();
if (ABS (topmost_rect.x - bottommost_rect.x - bottommost_rect.width) > threshold &&
ABS (bottommost_rect.x - topmost_rect.x - topmost_rect.width) > threshold)
return NULL;
}
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
/*
* If there's a window stacked in between which is partially visible
* behind the topmost tile we don't consider the tiles to match.
*/
for (above = meta_stack_get_above (stack, bottommost, FALSE);
above && above != topmost;
above = meta_stack_get_above (stack, above, FALSE))
{
if (above->minimized ||
above->monitor != window->monitor ||
meta_window_get_workspace (above) != meta_window_get_workspace (window))
continue;
meta_window_get_frame_rect (above, &above_rect);
if (meta_rectangle_overlap (&above_rect, &bottommost_rect) &&
meta_rectangle_overlap (&above_rect, &topmost_rect))
window: Tile and resize considering the tile match After the introduction of the possibility to resize tiled windows, it is a sensible decision to make windows aware of their tiling match. A tiling match is another window that is tiled in such a way that is the complement of the current window. The newly introduced behavior attepts to make tiling as smooth as possible, with the following rules: * Windows now compute their tile match when tiling and, if there's a match, they automatically complement the sibling's width. * Resizing a window with a sibling automatically resizes the sibling too to be the complement of the window's width. * It is not possible to resize below windows' minimum widths. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-12 01:13:03 +00:00
return NULL;
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
}
}
window: Tile and resize considering the tile match After the introduction of the possibility to resize tiled windows, it is a sensible decision to make windows aware of their tiling match. A tiling match is another window that is tiled in such a way that is the complement of the current window. The newly introduced behavior attepts to make tiling as smooth as possible, with the following rules: * Windows now compute their tile match when tiling and, if there's a match, they automatically complement the sibling's width. * Resizing a window with a sibling automatically resizes the sibling too to be the complement of the window's width. * It is not possible to resize below windows' minimum widths. https://bugzilla.gnome.org/show_bug.cgi?id=645153
2017-06-12 01:13:03 +00:00
return match;
Revert "window: Remove old tiling code" This reverts commit 8bded7d497f493cf7c3c5bb0ff5a353e34981215.
2016-01-10 14:16:09 +00:00
}
Add a private gtk-mutter protocol Add a new interface, gtk_shell, than can be used by gtk to retrieve a surface extension called gtk_surface, which will be used to communicate with mutter all the GTK extensions to EWMH https://bugzilla.gnome.org/show_bug.cgi?id=707128 Add support for GTK application menus To do so, we need to be able to set surface state before creating the MetaWindow, so we introduce MetaWaylandSurfaceInitialState as a staging area. The gtk-shell-surface implementation would either write to the initial state, or directly to the window. At the same, implement set_title and set_class too, because it's easy enough. https://bugzilla.gnome.org/show_bug.cgi?id=707128
2013-08-30 07:40:36 +00:00
void
meta_window_set_title (MetaWindow *window,
const char *title)
{
g_free (window->title);
window->title = g_strdup (title);
if (window->frame)
Only poke the frames UI code from inside frame.c Add frame.c wrappers for the missing calls, then adapt.
2015-01-01 05:24:49 +00:00
meta_frame_update_title (window->frame);
Add a private gtk-mutter protocol Add a new interface, gtk_shell, than can be used by gtk to retrieve a surface extension called gtk_surface, which will be used to communicate with mutter all the GTK extensions to EWMH https://bugzilla.gnome.org/show_bug.cgi?id=707128 Add support for GTK application menus To do so, we need to be able to set surface state before creating the MetaWindow, so we introduce MetaWaylandSurfaceInitialState as a staging area. The gtk-shell-surface implementation would either write to the initial state, or directly to the window. At the same, implement set_title and set_class too, because it's easy enough. https://bugzilla.gnome.org/show_bug.cgi?id=707128
2013-08-30 07:40:36 +00:00
window: Make window->desc a bit clearer And remove the hack for the "broken GNU libc". It works fine on my system here.
2014-03-19 01:19:51 +00:00
meta_window_update_desc (window);
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_TITLE]);
Add a private gtk-mutter protocol Add a new interface, gtk_shell, than can be used by gtk to retrieve a surface extension called gtk_surface, which will be used to communicate with mutter all the GTK extensions to EWMH https://bugzilla.gnome.org/show_bug.cgi?id=707128 Add support for GTK application menus To do so, we need to be able to set surface state before creating the MetaWindow, so we introduce MetaWaylandSurfaceInitialState as a staging area. The gtk-shell-surface implementation would either write to the initial state, or directly to the window. At the same, implement set_title and set_class too, because it's easy enough. https://bugzilla.gnome.org/show_bug.cgi?id=707128
2013-08-30 07:40:36 +00:00
}
void
meta_window_set_wm_class (MetaWindow *window,
const char *wm_class,
const char *wm_instance)
{
g_free (window->res_class);
g_free (window->res_name);
window->res_name = g_strdup (wm_instance);
window->res_class = g_strdup (wm_class);
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_WM_CLASS]);
Add a private gtk-mutter protocol Add a new interface, gtk_shell, than can be used by gtk to retrieve a surface extension called gtk_surface, which will be used to communicate with mutter all the GTK extensions to EWMH https://bugzilla.gnome.org/show_bug.cgi?id=707128 Add support for GTK application menus To do so, we need to be able to set surface state before creating the MetaWindow, so we introduce MetaWaylandSurfaceInitialState as a staging area. The gtk-shell-surface implementation would either write to the initial state, or directly to the window. At the same, implement set_title and set_class too, because it's easy enough. https://bugzilla.gnome.org/show_bug.cgi?id=707128
2013-08-30 07:40:36 +00:00
}
void
meta_window_set_gtk_dbus_properties (MetaWindow *window,
const char *application_id,
const char *unique_bus_name,
const char *appmenu_path,
const char *menubar_path,
const char *application_object_path,
const char *window_object_path)
{
g_object_freeze_notify (G_OBJECT (window));
g_free (window->gtk_application_id);
window->gtk_application_id = g_strdup (application_id);
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_GTK_APPLICATION_ID]);
Add a private gtk-mutter protocol Add a new interface, gtk_shell, than can be used by gtk to retrieve a surface extension called gtk_surface, which will be used to communicate with mutter all the GTK extensions to EWMH https://bugzilla.gnome.org/show_bug.cgi?id=707128 Add support for GTK application menus To do so, we need to be able to set surface state before creating the MetaWindow, so we introduce MetaWaylandSurfaceInitialState as a staging area. The gtk-shell-surface implementation would either write to the initial state, or directly to the window. At the same, implement set_title and set_class too, because it's easy enough. https://bugzilla.gnome.org/show_bug.cgi?id=707128
2013-08-30 07:40:36 +00:00
g_free (window->gtk_unique_bus_name);
window->gtk_unique_bus_name = g_strdup (unique_bus_name);
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_GTK_UNIQUE_BUS_NAME]);
Add a private gtk-mutter protocol Add a new interface, gtk_shell, than can be used by gtk to retrieve a surface extension called gtk_surface, which will be used to communicate with mutter all the GTK extensions to EWMH https://bugzilla.gnome.org/show_bug.cgi?id=707128 Add support for GTK application menus To do so, we need to be able to set surface state before creating the MetaWindow, so we introduce MetaWaylandSurfaceInitialState as a staging area. The gtk-shell-surface implementation would either write to the initial state, or directly to the window. At the same, implement set_title and set_class too, because it's easy enough. https://bugzilla.gnome.org/show_bug.cgi?id=707128
2013-08-30 07:40:36 +00:00
g_free (window->gtk_app_menu_object_path);
window->gtk_app_menu_object_path = g_strdup (appmenu_path);
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_GTK_APP_MENU_OBJECT_PATH]);
Add a private gtk-mutter protocol Add a new interface, gtk_shell, than can be used by gtk to retrieve a surface extension called gtk_surface, which will be used to communicate with mutter all the GTK extensions to EWMH https://bugzilla.gnome.org/show_bug.cgi?id=707128 Add support for GTK application menus To do so, we need to be able to set surface state before creating the MetaWindow, so we introduce MetaWaylandSurfaceInitialState as a staging area. The gtk-shell-surface implementation would either write to the initial state, or directly to the window. At the same, implement set_title and set_class too, because it's easy enough. https://bugzilla.gnome.org/show_bug.cgi?id=707128
2013-08-30 07:40:36 +00:00
g_free (window->gtk_menubar_object_path);
window->gtk_menubar_object_path = g_strdup (menubar_path);
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_GTK_MENUBAR_OBJECT_PATH]);
Add a private gtk-mutter protocol Add a new interface, gtk_shell, than can be used by gtk to retrieve a surface extension called gtk_surface, which will be used to communicate with mutter all the GTK extensions to EWMH https://bugzilla.gnome.org/show_bug.cgi?id=707128 Add support for GTK application menus To do so, we need to be able to set surface state before creating the MetaWindow, so we introduce MetaWaylandSurfaceInitialState as a staging area. The gtk-shell-surface implementation would either write to the initial state, or directly to the window. At the same, implement set_title and set_class too, because it's easy enough. https://bugzilla.gnome.org/show_bug.cgi?id=707128
2013-08-30 07:40:36 +00:00
g_free (window->gtk_application_object_path);
window->gtk_application_object_path = g_strdup (application_object_path);
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_GTK_APPLICATION_OBJECT_PATH]);
Add a private gtk-mutter protocol Add a new interface, gtk_shell, than can be used by gtk to retrieve a surface extension called gtk_surface, which will be used to communicate with mutter all the GTK extensions to EWMH https://bugzilla.gnome.org/show_bug.cgi?id=707128 Add support for GTK application menus To do so, we need to be able to set surface state before creating the MetaWindow, so we introduce MetaWaylandSurfaceInitialState as a staging area. The gtk-shell-surface implementation would either write to the initial state, or directly to the window. At the same, implement set_title and set_class too, because it's easy enough. https://bugzilla.gnome.org/show_bug.cgi?id=707128
2013-08-30 07:40:36 +00:00
g_free (window->gtk_window_object_path);
window->gtk_window_object_path = g_strdup (window_object_path);
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_GTK_WINDOW_OBJECT_PATH]);
Add a private gtk-mutter protocol Add a new interface, gtk_shell, than can be used by gtk to retrieve a surface extension called gtk_surface, which will be used to communicate with mutter all the GTK extensions to EWMH https://bugzilla.gnome.org/show_bug.cgi?id=707128 Add support for GTK application menus To do so, we need to be able to set surface state before creating the MetaWindow, so we introduce MetaWaylandSurfaceInitialState as a staging area. The gtk-shell-surface implementation would either write to the initial state, or directly to the window. At the same, implement set_title and set_class too, because it's easy enough. https://bugzilla.gnome.org/show_bug.cgi?id=707128
2013-08-30 07:40:36 +00:00
g_object_thaw_notify (G_OBJECT (window));
}
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
window: check for possible loop in transients If a broken or naughty application tries set up its windows to create a loop in the transient relationship, mutter will hang, looping forever in meta_window_foreach_ancestor() To avoid looping infinitely at various point in the code, check for a possible loop when setting the transient relationship and deny the request to set a window transient for another if that would create a loop. Bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=759299
2015-12-15 15:55:29 +00:00
static gboolean
check_transient_for_loop (MetaWindow *window,
MetaWindow *parent)
{
while (parent)
{
window: Include window itself in transient loop check While it doesn't make sense to set a window as transient to itself, our existing check whether making a window transient doesn't cover it, so it's still possible to create an infinite loop. https://bugzilla.gnome.org/show_bug.cgi?id=783502
2017-06-07 12:12:39 +00:00
if (parent == window)
window: check for possible loop in transients If a broken or naughty application tries set up its windows to create a loop in the transient relationship, mutter will hang, looping forever in meta_window_foreach_ancestor() To avoid looping infinitely at various point in the code, check for a possible loop when setting the transient relationship and deny the request to set a window transient for another if that would create a loop. Bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=759299
2015-12-15 15:55:29 +00:00
return TRUE;
parent = parent->transient_for;
}
return FALSE;
}
stack: Move HAS_TRANSIENT_TYPE macro to window-private We'll soon need it elsewhere, so move it to a shared location. While at it, convert it to a function. https://gitlab.gnome.org/GNOME/mutter/merge_requests/949
2019-11-26 22:06:09 +00:00
gboolean
meta_window_has_transient_type (MetaWindow *window)
{
return (window->type == META_WINDOW_DIALOG ||
window->type == META_WINDOW_MODAL_DIALOG ||
window->type == META_WINDOW_TOOLBAR ||
window->type == META_WINDOW_MENU ||
window->type == META_WINDOW_UTILITY);
}
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
void
meta_window_set_transient_for (MetaWindow *window,
MetaWindow *parent)
{
window: check for possible loop in transients If a broken or naughty application tries set up its windows to create a loop in the transient relationship, mutter will hang, looping forever in meta_window_foreach_ancestor() To avoid looping infinitely at various point in the code, check for a possible loop when setting the transient relationship and deny the request to set a window transient for another if that would create a loop. Bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=759299
2015-12-15 15:55:29 +00:00
if (check_transient_for_loop (window, parent))
{
meta_warning ("Setting %s transient for %s would create a loop.\n",
window->desc, parent->desc);
return;
}
window: Fix some minor constant type issues
2014-08-13 22:14:15 +00:00
if (meta_window_appears_focused (window) && window->transient_for != NULL)
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
meta_window_propagate_focus_appearance (window, FALSE);
/* may now be a dialog */
window: Move recalc_type to window-x11.c It's only used by the X11 codepath.
2014-03-13 20:49:17 +00:00
if (window->client_type == META_WINDOW_CLIENT_TYPE_X11)
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
{
window: Don't unmanage transient_for when attached For some reason, when a modal dialog was made an attaching transient-for, if the window wasn't "constructing", it would be unmanaged and rely on some side effect to be recreated. This side effect is not triggered for Wayland clients, thus if one happen to set a surface as "modal" via gtk_surface.set_modal before xdg_toplevel.set_parent, it'd be unmanaged and never show up. Instead, simply just set the tranciency anyway for Wayland clients. This makes GTK+ clients that set_modal() before set_transient_for() work. https://bugzilla.gnome.org/show_bug.cgi?id=770324
2016-08-24 04:53:25 +00:00
meta_window_x11_recalc_window_type (window);
if (!window->constructing)
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
{
window: Don't unmanage transient_for when attached For some reason, when a modal dialog was made an attaching transient-for, if the window wasn't "constructing", it would be unmanaged and rely on some side effect to be recreated. This side effect is not triggered for Wayland clients, thus if one happen to set a surface as "modal" via gtk_surface.set_modal before xdg_toplevel.set_parent, it'd be unmanaged and never show up. Instead, simply just set the tranciency anyway for Wayland clients. This makes GTK+ clients that set_modal() before set_transient_for() work. https://bugzilla.gnome.org/show_bug.cgi?id=770324
2016-08-24 04:53:25 +00:00
/* If the window attaches, detaches, or changes attached
* parents, we need to destroy the MetaWindow and let a new one
* be created (which happens as a side effect of
* meta_window_unmanage()). The condition below is correct
* because we know window->transient_for has changed.
*/
if (window->attached || meta_window_should_attach_to_parent (window))
{
guint32 timestamp;
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
window: Don't unmanage transient_for when attached For some reason, when a modal dialog was made an attaching transient-for, if the window wasn't "constructing", it would be unmanaged and rely on some side effect to be recreated. This side effect is not triggered for Wayland clients, thus if one happen to set a surface as "modal" via gtk_surface.set_modal before xdg_toplevel.set_parent, it'd be unmanaged and never show up. Instead, simply just set the tranciency anyway for Wayland clients. This makes GTK+ clients that set_modal() before set_transient_for() work. https://bugzilla.gnome.org/show_bug.cgi?id=770324
2016-08-24 04:53:25 +00:00
timestamp =
meta_display_get_current_time_roundtrip (window->display);
meta_window_unmanage (window, timestamp);
return;
}
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
}
}
window: unmanage dialog when clearing transient_for On Wayland, xdg-foreign would leave a modal dialog managed even after the imported surface is destroyed. This is sub-optimal and this breaks the atomic relationship one would expect between the parent and its modal dialog. Make sure we unmanage the dialog if transient_for is unset even for Wayland native windows. Related: https://gitlab.gnome.org/GNOME/mutter/issues/174 Related: https://gitlab.gnome.org/GNOME/mutter/issues/221
2018-07-10 14:42:42 +00:00
else if (window->attached && parent == NULL)
{
guint32 timestamp;
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
window: unmanage dialog when clearing transient_for On Wayland, xdg-foreign would leave a modal dialog managed even after the imported surface is destroyed. This is sub-optimal and this breaks the atomic relationship one would expect between the parent and its modal dialog. Make sure we unmanage the dialog if transient_for is unset even for Wayland native windows. Related: https://gitlab.gnome.org/GNOME/mutter/issues/174 Related: https://gitlab.gnome.org/GNOME/mutter/issues/221
2018-07-10 14:42:42 +00:00
timestamp =
meta_display_get_current_time_roundtrip (window->display);
meta_window_unmanage (window, timestamp);
return;
}
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
/* We know this won't create a reference cycle because we check for loops */
g_clear_object (&window->transient_for);
window->transient_for = parent ? g_object_ref (parent) : NULL;
window: Update the stack after setting the transient_for field Don't update the stack until after setting the window->transient_for field. Updating before will cause the stack transient-for constraint to be missing until the next time constraints are applied. https://bugzilla.gnome.org/show_bug.cgi?id=755606
2015-09-24 05:35:42 +00:00
/* update stacking constraints */
if (!window->override_redirect)
Move stack tracking and guard_window outside of MetaScreen Move stack, stack_tracker to MetaDisplay guard_window to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 17:03:51 +00:00
meta_stack_update_transient (window->display->stack, window);
window: Update the stack after setting the transient_for field Don't update the stack until after setting the window->transient_for field. Updating before will cause the stack transient-for constraint to be missing until the next time constraints are applied. https://bugzilla.gnome.org/show_bug.cgi?id=755606
2015-09-24 05:35:42 +00:00
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
/* possibly change its group. We treat being a window's transient as
* equivalent to making it your group leader, to work around shortcomings
* in programs such as xmms-- see #328211.
*/
if (window->xtransient_for != None &&
window->xgroup_leader != None &&
window->xtransient_for != window->xgroup_leader)
meta_window_group_leader_changed (window);
if (!window->constructing && !window->override_redirect)
window: Re-evaluate window visibility when making it transient In case a window is hidden when we're ordered to make it transient to a different parent we must re-evaluate its visibility status or we'll get into an inconsistent state where the parent is visible and the child isn't. https://bugzilla.gnome.org/show_bug.cgi?id=759297
2016-01-06 16:11:19 +00:00
meta_window_queue (window, META_QUEUE_MOVE_RESIZE | META_QUEUE_CALC_SHOWING);
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
window: Fix some minor constant type issues
2014-08-13 22:14:15 +00:00
if (meta_window_appears_focused (window) && window->transient_for != NULL)
wayland: implement transient hints for wayland clients wl_shell supports a set_transient() map request that is equivalent to setting WM_TRANSIENT_FOR in X11, so implement that. https://bugzilla.gnome.org/show_bug.cgi?id=707401
2013-09-16 12:44:37 +00:00
meta_window_propagate_focus_appearance (window, TRUE);
}
wayland: Support alternative focus modes like focus-follows-mouse Use the existing code for MetaWindow focus-follows-mouse to support this.
2013-10-16 04:06:10 +00:00
Move _NET_WM_WINDOW_OPACITY handling to the standard window-props interface
2013-12-06 18:44:31 +00:00
void
meta_window_set_opacity (MetaWindow *window,
window: Use guint8 for opacity internally Except while reading _NET_WM_WINDOW_OPACITY, opacity is between 0 and 255. With guint8, we'll get compiler warnings if arbitrary int values are passed. https://bugzilla.gnome.org/show_bug.cgi?id=727874
2014-04-10 06:41:22 +00:00
guint8 opacity)
Move _NET_WM_WINDOW_OPACITY handling to the standard window-props interface
2013-12-06 18:44:31 +00:00
{
window->opacity = opacity;
Assume the compositor always exists At one point, it was supported to run mutter without a compositor, but we don't allow that any longer. A lot of code already assumes display->compositor exists and doesn't check for a NULL pointer, so just kill the rest of the checks.
2014-03-18 21:06:42 +00:00
meta_compositor_window_opacity_changed (window->display->compositor, window);
Move _NET_WM_WINDOW_OPACITY handling to the standard window-props interface
2013-12-06 18:44:31 +00:00
}
wayland: Support alternative focus modes like focus-follows-mouse Use the existing code for MetaWindow focus-follows-mouse to support this.
2013-10-16 04:06:10 +00:00
static void
reset_ignored_crossing_serials (MetaDisplay *display)
{
int i;
i = 0;
while (i < N_IGNORED_CROSSING_SERIALS)
{
display->ignored_crossing_serials[i] = 0;
++i;
}
}
typedef struct
{
MetaWindow *window;
int pointer_x;
int pointer_y;
} MetaFocusData;
static void
mouse_mode_focus (MetaWindow *window,
guint32 timestamp)
{
MetaDisplay *display = window->display;
window: Do not try to focus O-R windows in focus-follow-mouse Doing so would raise a critical warning. https://bugzilla.gnome.org/show_bug.cgi?id=767997
2016-06-24 09:14:39 +00:00
if (window->override_redirect)
return;
wayland: Support alternative focus modes like focus-follows-mouse Use the existing code for MetaWindow focus-follows-mouse to support this.
2013-10-16 04:06:10 +00:00
if (window->type != META_WINDOW_DESKTOP)
{
meta_topic (META_DEBUG_FOCUS,
"Focusing %s at time %u.\n", window->desc, timestamp);
meta_window_focus (window, timestamp);
if (meta_prefs_get_auto_raise ())
meta_display_queue_autoraise_callback (display, window);
else
meta_topic (META_DEBUG_FOCUS, "Auto raise is disabled\n");
}
else
{
/* In mouse focus mode, we defocus when the mouse *enters*
* the DESKTOP window, instead of defocusing on LeaveNotify.
* This is because having the mouse enter override-redirect
* child windows unfortunately causes LeaveNotify events that
* we can't distinguish from the mouse actually leaving the
* toplevel window as we expect. But, since we filter out
* EnterNotify events on override-redirect windows, this
* alternative mechanism works great.
*/
if (meta_prefs_get_focus_mode() == G_DESKTOP_FOCUS_MODE_MOUSE &&
display->focus_window != NULL)
{
meta_topic (META_DEBUG_FOCUS,
"Unsetting focus from %s due to mouse entering "
"the DESKTOP window\n",
display->focus_window->desc);
core: Untangle input focus management In all places (including src/wayland) we tap into meta_x11_display* focus API, which then calls meta_display* API. This relation is backwards, so rework input focus management so it's the other way around. We now have high-level meta_display_(un)set_input_focus functions, which perform the backend-independent maintenance, and calls into the X11 functions where relevant. These functions are what callers should use. https://gitlab.gnome.org/GNOME/mutter/merge_requests/420
2018-12-30 20:23:07 +00:00
meta_display_unset_input_focus (display, timestamp);
wayland: Support alternative focus modes like focus-follows-mouse Use the existing code for MetaWindow focus-follows-mouse to support this.
2013-10-16 04:06:10 +00:00
}
}
}
Revert "window: Make meta_window_has_pointer() per protocol implemented" Windows from Xwayland still needs to use the Wayland path, but is represented an MetaWindowX11, thus the abstraction introduced in "window: Make meta_window_has_pointer() per protocol implemented" is wrong. Lets turn back time, and reconsider how this can be abstracted more correctly in the future. This reverts commit 9fb891d216478b923f010be23be8790bba6bc7d6.
2016-08-25 22:51:19 +00:00
static gboolean
window_has_pointer_wayland (MetaWindow *window)
{
core: Replace ClutterDeviceManager usage in favor of ClutterSeat https://gitlab.gnome.org/GNOME/mutter/merge_requests/852
2019-10-04 12:02:53 +00:00
ClutterSeat *seat;
Revert "window: Make meta_window_has_pointer() per protocol implemented" Windows from Xwayland still needs to use the Wayland path, but is represented an MetaWindowX11, thus the abstraction introduced in "window: Make meta_window_has_pointer() per protocol implemented" is wrong. Lets turn back time, and reconsider how this can be abstracted more correctly in the future. This reverts commit 9fb891d216478b923f010be23be8790bba6bc7d6.
2016-08-25 22:51:19 +00:00
ClutterInputDevice *dev;
ClutterActor *pointer_actor, *window_actor;
core: Replace ClutterDeviceManager usage in favor of ClutterSeat https://gitlab.gnome.org/GNOME/mutter/merge_requests/852
2019-10-04 12:02:53 +00:00
seat = clutter_backend_get_default_seat (clutter_get_default_backend ());
dev = clutter_seat_get_pointer (seat);
Revert "window: Make meta_window_has_pointer() per protocol implemented" Windows from Xwayland still needs to use the Wayland path, but is represented an MetaWindowX11, thus the abstraction introduced in "window: Make meta_window_has_pointer() per protocol implemented" is wrong. Lets turn back time, and reconsider how this can be abstracted more correctly in the future. This reverts commit 9fb891d216478b923f010be23be8790bba6bc7d6.
2016-08-25 22:51:19 +00:00
pointer_actor = clutter_input_device_get_pointer_actor (dev);
window_actor = CLUTTER_ACTOR (meta_window_get_compositor_private (window));
return pointer_actor && clutter_actor_contains (window_actor, pointer_actor);
}
static gboolean
window_has_pointer_x11 (MetaWindow *window)
{
Move alarm and xids management to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 16:56:44 +00:00
MetaX11Display *x11_display = window->display->x11_display;
Revert "window: Make meta_window_has_pointer() per protocol implemented" Windows from Xwayland still needs to use the Wayland path, but is represented an MetaWindowX11, thus the abstraction introduced in "window: Make meta_window_has_pointer() per protocol implemented" is wrong. Lets turn back time, and reconsider how this can be abstracted more correctly in the future. This reverts commit 9fb891d216478b923f010be23be8790bba6bc7d6.
2016-08-25 22:51:19 +00:00
Window root, child;
double root_x, root_y, x, y;
XIButtonState buttons;
XIModifierState mods;
XIGroupState group;
Rename errors.[ch] to meta-x11-errors.[ch] Also rename meta_error_trap_* to meta_x11_error_trap_* and move meta-x11-errors.c to src/x11 https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 18:48:55 +00:00
meta_x11_error_trap_push (x11_display);
Move alarm and xids management to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 16:56:44 +00:00
XIQueryPointer (x11_display->xdisplay,
Revert "window: Make meta_window_has_pointer() per protocol implemented" Windows from Xwayland still needs to use the Wayland path, but is represented an MetaWindowX11, thus the abstraction introduced in "window: Make meta_window_has_pointer() per protocol implemented" is wrong. Lets turn back time, and reconsider how this can be abstracted more correctly in the future. This reverts commit 9fb891d216478b923f010be23be8790bba6bc7d6.
2016-08-25 22:51:19 +00:00
META_VIRTUAL_CORE_POINTER_ID,
Move alarm and xids management to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 16:56:44 +00:00
x11_display->xroot,
Revert "window: Make meta_window_has_pointer() per protocol implemented" Windows from Xwayland still needs to use the Wayland path, but is represented an MetaWindowX11, thus the abstraction introduced in "window: Make meta_window_has_pointer() per protocol implemented" is wrong. Lets turn back time, and reconsider how this can be abstracted more correctly in the future. This reverts commit 9fb891d216478b923f010be23be8790bba6bc7d6.
2016-08-25 22:51:19 +00:00
&root, &child,
&root_x, &root_y, &x, &y,
&buttons, &mods, &group);
Rename errors.[ch] to meta-x11-errors.[ch] Also rename meta_error_trap_* to meta_x11_error_trap_* and move meta-x11-errors.c to src/x11 https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-27 18:48:55 +00:00
meta_x11_error_trap_pop (x11_display);
Revert "window: Make meta_window_has_pointer() per protocol implemented" Windows from Xwayland still needs to use the Wayland path, but is represented an MetaWindowX11, thus the abstraction introduced in "window: Make meta_window_has_pointer() per protocol implemented" is wrong. Lets turn back time, and reconsider how this can be abstracted more correctly in the future. This reverts commit 9fb891d216478b923f010be23be8790bba6bc7d6.
2016-08-25 22:51:19 +00:00
free (buttons.mask);
Move alarm and xids management to MetaX11Display https://bugzilla.gnome.org/show_bug.cgi?id=759538
2017-08-26 16:56:44 +00:00
return meta_x11_display_lookup_x_window (x11_display, child) == window;
Revert "window: Make meta_window_has_pointer() per protocol implemented" Windows from Xwayland still needs to use the Wayland path, but is represented an MetaWindowX11, thus the abstraction introduced in "window: Make meta_window_has_pointer() per protocol implemented" is wrong. Lets turn back time, and reconsider how this can be abstracted more correctly in the future. This reverts commit 9fb891d216478b923f010be23be8790bba6bc7d6.
2016-08-25 22:51:19 +00:00
}
display: Use meta_window_has_pointer instead of XQueryPointer
2014-06-12 21:01:13 +00:00
gboolean
meta_window_has_pointer (MetaWindow *window)
window: Fix delayed mouse mode on X On X, basing the check whether the pointer is on the window on Clutter events does not work, as the relevant events are handled by GDK instead. So add an X-specific window_has_pointer() implementation to also fix mouse mode when running as X compositor. https://bugzilla.gnome.org/show_bug.cgi?id=730541
2014-05-07 21:22:41 +00:00
{
Revert "window: Make meta_window_has_pointer() per protocol implemented" Windows from Xwayland still needs to use the Wayland path, but is represented an MetaWindowX11, thus the abstraction introduced in "window: Make meta_window_has_pointer() per protocol implemented" is wrong. Lets turn back time, and reconsider how this can be abstracted more correctly in the future. This reverts commit 9fb891d216478b923f010be23be8790bba6bc7d6.
2016-08-25 22:51:19 +00:00
if (meta_is_wayland_compositor ())
return window_has_pointer_wayland (window);
else
return window_has_pointer_x11 (window);
window: Fix delayed mouse mode on X On X, basing the check whether the pointer is on the window on Clutter events does not work, as the relevant events are handled by GDK instead. So add an X-specific window_has_pointer() implementation to also fix mouse mode when running as X compositor. https://bugzilla.gnome.org/show_bug.cgi?id=730541
2014-05-07 21:22:41 +00:00
}
wayland: Support alternative focus modes like focus-follows-mouse Use the existing code for MetaWindow focus-follows-mouse to support this.
2013-10-16 04:06:10 +00:00
static gboolean
window_focus_on_pointer_rest_callback (gpointer data)
{
MetaFocusData *focus_data = data;
MetaWindow *window = focus_data->window;
MetaDisplay *display = window->display;
Move cursor tracker ownership to the backend Let the backend initialize the cursor tracker, and change all call sites to get the cursor tracker from the backend instead of from the screen. It wasn't associated with the screen anyway, so the API was missleading. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 12:30:22 +00:00
MetaBackend *backend = meta_get_backend ();
MetaCursorTracker *cursor_tracker = meta_backend_get_cursor_tracker (backend);
Use MetaCursorTracker to query the pointer position Functionally equivalent in the X11 case, but also correct for Wayland (where the X server doesn't have the updated pointer position). https://bugzilla.gnome.org/show_bug.cgi?id=725525
2014-03-02 22:27:50 +00:00
int root_x, root_y;
wayland: Support alternative focus modes like focus-follows-mouse Use the existing code for MetaWindow focus-follows-mouse to support this.
2013-10-16 04:06:10 +00:00
guint32 timestamp;
if (meta_prefs_get_focus_mode () == G_DESKTOP_FOCUS_MODE_CLICK)
goto out;
Move cursor tracker ownership to the backend Let the backend initialize the cursor tracker, and change all call sites to get the cursor tracker from the backend instead of from the screen. It wasn't associated with the screen anyway, so the API was missleading. https://bugzilla.gnome.org/show_bug.cgi?id=777732
2016-11-29 12:30:22 +00:00
meta_cursor_tracker_get_pointer (cursor_tracker, &root_x, &root_y, NULL);
wayland: Support alternative focus modes like focus-follows-mouse Use the existing code for MetaWindow focus-follows-mouse to support this.
2013-10-16 04:06:10 +00:00
if (root_x != focus_data->pointer_x ||
root_y != focus_data->pointer_y)
{
focus_data->pointer_x = root_x;
focus_data->pointer_y = root_y;
display: Use G_SOURCE_CONTINUE / G_SOURCE_REMOVE
2014-06-12 21:02:14 +00:00
return G_SOURCE_CONTINUE;
wayland: Support alternative focus modes like focus-follows-mouse Use the existing code for MetaWindow focus-follows-mouse to support this.
2013-10-16 04:06:10 +00:00
}
display: Use meta_window_has_pointer instead of XQueryPointer
2014-06-12 21:01:13 +00:00
if (!meta_window_has_pointer (window))
wayland: Support alternative focus modes like focus-follows-mouse Use the existing code for MetaWindow focus-follows-mouse to support this.
2013-10-16 04:06:10 +00:00
goto out;
timestamp = meta_display_get_current_time_roundtrip (display);
mouse_mode_focus (window, timestamp);
out:
display->focus_timeout_id = 0;
display: Use G_SOURCE_CONTINUE / G_SOURCE_REMOVE
2014-06-12 21:02:14 +00:00
return G_SOURCE_REMOVE;
wayland: Support alternative focus modes like focus-follows-mouse Use the existing code for MetaWindow focus-follows-mouse to support this.
2013-10-16 04:06:10 +00:00
}
/* The interval, in milliseconds, we use in focus-follows-mouse
* mode to check whether the pointer has stopped moving after a
* crossing event.
*/
#define FOCUS_TIMEOUT_DELAY 25
static void
queue_focus_callback (MetaDisplay *display,
MetaWindow *window,
int pointer_x,
int pointer_y)
{
MetaFocusData *focus_data;
focus_data = g_new (MetaFocusData, 1);
focus_data->window = window;
focus_data->pointer_x = pointer_x;
focus_data->pointer_y = pointer_y;
cleanup: Use g_clear_handle_id() for g_source_remove() It makes sure we do not forget to zero the id and lets us avoid zero checks before. We use it for all new code, lets clean up the existing code base. https://gitlab.gnome.org/GNOME/mutter/merge_requests/947
2019-11-21 23:25:30 +00:00
g_clear_handle_id (&display->focus_timeout_id, g_source_remove);
wayland: Support alternative focus modes like focus-follows-mouse Use the existing code for MetaWindow focus-follows-mouse to support this.
2013-10-16 04:06:10 +00:00
display->focus_timeout_id =
g_timeout_add_full (G_PRIORITY_DEFAULT,
FOCUS_TIMEOUT_DELAY,
window_focus_on_pointer_rest_callback,
focus_data,
g_free);
Name all timeouts and idles Better names can be used once we make more use of them. https://bugzilla.gnome.org/show_bug.cgi?id=727979
2014-04-10 16:58:58 +00:00
g_source_set_name_by_id (display->focus_timeout_id,
"[mutter] window_focus_on_pointer_rest_callback");
wayland: Support alternative focus modes like focus-follows-mouse Use the existing code for MetaWindow focus-follows-mouse to support this.
2013-10-16 04:06:10 +00:00
}
void
meta_window_handle_enter (MetaWindow *window,
guint32 timestamp,
guint root_x,
guint root_y)
{
MetaDisplay *display = window->display;
switch (meta_prefs_get_focus_mode ())
{
case G_DESKTOP_FOCUS_MODE_SLOPPY:
case G_DESKTOP_FOCUS_MODE_MOUSE:
display->mouse_mode = TRUE;
if (window->type != META_WINDOW_DOCK)
{
if (meta_prefs_get_focus_change_on_pointer_rest())
queue_focus_callback (display, window, root_x, root_y);
else
mouse_mode_focus (window, timestamp);
/* stop ignoring stuff */
reset_ignored_crossing_serials (display);
}
break;
case G_DESKTOP_FOCUS_MODE_CLICK:
break;
}
window: Complete moving enter/leave handling here
2014-05-15 20:20:41 +00:00
if (window->type == META_WINDOW_DOCK)
meta_window_raise (window);
}
void
meta_window_handle_leave (MetaWindow *window)
{
if (window->type == META_WINDOW_DOCK && !window->has_focus)
meta_window_lower (window);
wayland: Support alternative focus modes like focus-follows-mouse Use the existing code for MetaWindow focus-follows-mouse to support this.
2013-10-16 04:06:10 +00:00
}
window: Create a backing MetaWindow for unmapped Wayland surfaces We require a MetaWindow to properly implement some of the requests for xdg_surface, so add a way to have an unmapped MetaWindow that we can store properties on, that we later map when the client attaches a buffer...
2013-11-19 22:33:57 +00:00
window: Move UI frame event handler to a separate function In order to tell whether an event has been handled by the frame UI, move the UI frame handler to a specific helper function. https://gitlab.gnome.org/GNOME/mutter/issues/88
2019-07-25 06:57:05 +00:00
gboolean
meta_window_handle_ui_frame_event (MetaWindow *window,
const ClutterEvent *event)
{
if (!window->frame)
return FALSE;
return meta_ui_frame_handle_event (window->frame->ui_frame, event);
}
events: Make the ungrabbed button press handling more bullet proof Instead of returning a value based on whether or not we handled it, we have this logic: either we have taken a grab on the window, in which case we have a grab op and have handled it ourselves, or we did not take a grab and *need* to replay the event to the window. Handle this in events.c by checking the grab operation in the same way that we check the other grab ops.
2014-08-15 12:29:16 +00:00
void
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
meta_window_handle_ungrabbed_event (MetaWindow *window,
const ClutterEvent *event)
{
MetaDisplay *display = window->display;
gboolean unmodified;
window: Centralize the checks for the window grab modifiers The code in the grab code was only checking for one of the modifiers to be down, instead of all of them.
2014-08-14 19:51:36 +00:00
gboolean is_window_grab;
window: Don't use button grab modifiers with inhibit shortcuts On Wayland, if a client issues a inhibit-shortcut request, the Wayland compositor will disable its own shortcuts. We should also disable the default handler for the button grab modifier so that button events with the window grab modifiers pressed are not caught by the compositor but are forwarded to the client surface. That also fixes the same issue with Xwayland applications issuing grabs, as those end up being emulated like shortcut inhibition. Closes: https://gitlab.gnome.org/GNOME/mutter/issues/642
2019-06-24 16:11:22 +00:00
gboolean is_window_button_grab_allowed;
core: Make meta_window_handle_ungrabbed_event() touch-aware This fixes the effects of this function on touchscreens in wayland (most notably, window raising & focusing).
2015-11-24 14:43:42 +00:00
ClutterModifierType grab_mods, event_mods;
window: Don't use button grab modifiers with inhibit shortcuts On Wayland, if a client issues a inhibit-shortcut request, the Wayland compositor will disable its own shortcuts. We should also disable the default handler for the button grab modifier so that button events with the window grab modifiers pressed are not caught by the compositor but are forwarded to the client surface. That also fixes the same issue with Xwayland applications issuing grabs, as those end up being emulated like shortcut inhibition. Closes: https://gitlab.gnome.org/GNOME/mutter/issues/642
2019-06-24 16:11:22 +00:00
ClutterInputDevice *source;
core: Make meta_window_handle_ungrabbed_event() touch-aware This fixes the effects of this function on touchscreens in wayland (most notably, window raising & focusing).
2015-11-24 14:43:42 +00:00
gfloat x, y;
guint button;
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
core: Make meta_window_handle_ungrabbed_event() touch-aware This fixes the effects of this function on touchscreens in wayland (most notably, window raising & focusing).
2015-11-24 14:43:42 +00:00
if (event->type != CLUTTER_BUTTON_PRESS &&
event->type != CLUTTER_TOUCH_BEGIN)
events: Make the ungrabbed button press handling more bullet proof Instead of returning a value based on whether or not we handled it, we have this logic: either we have taken a grab on the window, in which case we have a grab op and have handled it ourselves, or we did not take a grab and *need* to replay the event to the window. Handle this in events.c by checking the grab operation in the same way that we check the other grab ops.
2014-08-15 12:29:16 +00:00
return;
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
core: Make meta_window_handle_ungrabbed_event() touch-aware This fixes the effects of this function on touchscreens in wayland (most notably, window raising & focusing).
2015-11-24 14:43:42 +00:00
if (event->type == CLUTTER_TOUCH_BEGIN)
{
ClutterEventSequence *sequence;
button = 1;
sequence = clutter_event_get_event_sequence (event);
if (!meta_display_is_pointer_emulating_sequence (window->display, sequence))
return;
}
else
button = clutter_event_get_button (event);
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
if (display->grab_op != META_GRAB_OP_NONE)
events: Make the ungrabbed button press handling more bullet proof Instead of returning a value based on whether or not we handled it, we have this logic: either we have taken a grab on the window, in which case we have a grab op and have handled it ourselves, or we did not take a grab and *need* to replay the event to the window. Handle this in events.c by checking the grab operation in the same way that we check the other grab ops.
2014-08-15 12:29:16 +00:00
return;
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
window: Make sure not to respond to input events on OR windows This can happen since we select for events on the root window, and clients themselves might not select for input, meaning the X server will bubble up. Just do nothing and ignore the event in this case. This should hopefully fix some of the Window manager warning: Log level 8: meta_window_raise: assertion '!window->override_redirect' failed Window manager warning: Log level 8: meta_window_focus: assertion '!window->override_redirect' failed spam that people have been seeing.
2014-06-02 19:37:43 +00:00
/* Some windows might not ask for input, in which case we might be here
* because we selected for ButtonPress on the root window. In that case,
* we have to take special care not to act for an override-redirect window.
window: Don't eat events on O-R windows For XWayland, we need to make sure to send out mouse events on O-R windows, otherwise they won't get motion or button events. The comment mentions being eaten for the compositor, but we already bypass the compositor for all events that have a window. The return value just controls whether we pass them to Wayland.
2014-07-01 18:39:09 +00:00
*/
window: Make sure not to respond to input events on OR windows This can happen since we select for events on the root window, and clients themselves might not select for input, meaning the X server will bubble up. Just do nothing and ignore the event in this case. This should hopefully fix some of the Window manager warning: Log level 8: meta_window_raise: assertion '!window->override_redirect' failed Window manager warning: Log level 8: meta_window_focus: assertion '!window->override_redirect' failed spam that people have been seeing.
2014-06-02 19:37:43 +00:00
if (window->override_redirect)
events: Make the ungrabbed button press handling more bullet proof Instead of returning a value based on whether or not we handled it, we have this logic: either we have taken a grab on the window, in which case we have a grab op and have handled it ourselves, or we did not take a grab and *need* to replay the event to the window. Handle this in events.c by checking the grab operation in the same way that we check the other grab ops.
2014-08-15 12:29:16 +00:00
return;
window: Make sure not to respond to input events on OR windows This can happen since we select for events on the root window, and clients themselves might not select for input, meaning the X server will bubble up. Just do nothing and ignore the event in this case. This should hopefully fix some of the Window manager warning: Log level 8: meta_window_raise: assertion '!window->override_redirect' failed Window manager warning: Log level 8: meta_window_focus: assertion '!window->override_redirect' failed spam that people have been seeing.
2014-06-02 19:37:43 +00:00
window: Focus windows on button press regardless of modifier state This seems like a more generally useful and intuitive behavior. Note that, in X sessions, this is what already happened in practice since meta_display_begin_grab_op() calls meta_window_grab_all_keys() which, on X11, does meta_window_focus(). https://bugzilla.gnome.org/show_bug.cgi?id=756789
2015-10-21 15:35:36 +00:00
/* Don't focus panels--they must explicitly request focus.
* See bug 160470
*/
if (window->type != META_WINDOW_DOCK)
{
meta_topic (META_DEBUG_FOCUS,
"Focusing %s due to button %u press (display.c)\n",
window->desc, button);
meta_window_focus (window, event->any.time);
}
else
/* However, do allow terminals to lose focus due to new
* window mappings after the user clicks on a panel.
*/
display->allow_terminal_deactivation = TRUE;
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
/* We have three passive button grabs:
* - on any button, without modifiers => focuses and maybe raises the window
* - on resize button, with modifiers => start an interactive resizing
* (normally <Super>middle)
* - on move button, with modifiers => start an interactive move
* (normally <Super>left)
* - on menu button, with modifiers => show the window menu
* (normally <Super>right)
*
* We may get here because we actually have a button
* grab on the window, or because we're a wayland
* compositor and thus we see all the events, so we
* need to check if the event is interesting.
* We want an event that is not modified for a window.
*
* We may have other events on the window, for example
* a click on a frame button, but that's not for us to
* care about. Just let the event through.
*/
core: Make meta_window_handle_ungrabbed_event() touch-aware This fixes the effects of this function on touchscreens in wayland (most notably, window raising & focusing).
2015-11-24 14:43:42 +00:00
grab_mods = meta_display_get_window_grab_modifiers (display);
event_mods = clutter_event_get_state (event);
unmodified = (event_mods & grab_mods) == 0;
window: Don't use button grab modifiers with inhibit shortcuts On Wayland, if a client issues a inhibit-shortcut request, the Wayland compositor will disable its own shortcuts. We should also disable the default handler for the button grab modifier so that button events with the window grab modifiers pressed are not caught by the compositor but are forwarded to the client surface. That also fixes the same issue with Xwayland applications issuing grabs, as those end up being emulated like shortcut inhibition. Closes: https://gitlab.gnome.org/GNOME/mutter/issues/642
2019-06-24 16:11:22 +00:00
source = clutter_event_get_source_device (event);
window: Allow grab if the display focus is unset As per commit 040de396b, we don't try to grab when shortcuts are inhibited, However, this uses the focus window assuming that it is always set, while this might not be the case in some scenarios (like when unsetting the focus before requesting take-focus-window to acquire the input). So allow the button grab even if the focus window is not set for the display Closes: https://gitlab.gnome.org/GNOME/mutter/issues/663 https://gitlab.gnome.org/GNOME/mutter/merge_requests/668
2019-07-03 16:11:46 +00:00
is_window_button_grab_allowed = !display->focus_window ||
window: Don't use button grab modifiers with inhibit shortcuts On Wayland, if a client issues a inhibit-shortcut request, the Wayland compositor will disable its own shortcuts. We should also disable the default handler for the button grab modifier so that button events with the window grab modifiers pressed are not caught by the compositor but are forwarded to the client surface. That also fixes the same issue with Xwayland applications issuing grabs, as those end up being emulated like shortcut inhibition. Closes: https://gitlab.gnome.org/GNOME/mutter/issues/642
2019-06-24 16:11:22 +00:00
!meta_window_shortcuts_inhibited (display->focus_window, source);
is_window_grab = (is_window_button_grab_allowed &&
((event_mods & grab_mods) == grab_mods));
core: Make meta_window_handle_ungrabbed_event() touch-aware This fixes the effects of this function on touchscreens in wayland (most notably, window raising & focusing).
2015-11-24 14:43:42 +00:00
clutter_event_get_coords (event, &x, &y);
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
if (unmodified)
{
if (meta_prefs_get_raise_on_click ())
meta_window_raise (window);
else
meta_topic (META_DEBUG_FOCUS,
"Not raising window on click due to don't-raise-on-click option\n");
}
core: Make meta_window_handle_ungrabbed_event() touch-aware This fixes the effects of this function on touchscreens in wayland (most notably, window raising & focusing).
2015-11-24 14:43:42 +00:00
else if (is_window_grab && (int) button == meta_prefs_get_mouse_button_resize ())
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
{
if (window->has_resize_func)
{
gboolean north, south;
gboolean west, east;
MetaRectangle frame_rect;
common: Create a better encoding for MetaGrabOp MetaGrabOp is painful and tedious to work with, because it's a sequential series of values, meaning we have to use a giant unreadable switch statement to figure out some basic things about the value. To solve this, modify the encoding for MetaGrabOp and for the specific window grab operations so that they're a set of bitflags that we can easily check.
2014-08-15 18:05:04 +00:00
MetaGrabOp op = META_GRAB_OP_WINDOW_BASE;
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
meta_window_get_frame_rect (window, &frame_rect);
core: Make meta_window_handle_ungrabbed_event() touch-aware This fixes the effects of this function on touchscreens in wayland (most notably, window raising & focusing).
2015-11-24 14:43:42 +00:00
west = x < (frame_rect.x + 1 * frame_rect.width / 3);
east = x > (frame_rect.x + 2 * frame_rect.width / 3);
north = y < (frame_rect.y + 1 * frame_rect.height / 3);
south = y > (frame_rect.y + 2 * frame_rect.height / 3);
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
common: Create a better encoding for MetaGrabOp MetaGrabOp is painful and tedious to work with, because it's a sequential series of values, meaning we have to use a giant unreadable switch statement to figure out some basic things about the value. To solve this, modify the encoding for MetaGrabOp and for the specific window grab operations so that they're a set of bitflags that we can easily check.
2014-08-15 18:05:04 +00:00
if (west)
op |= META_GRAB_OP_WINDOW_DIR_WEST;
if (east)
op |= META_GRAB_OP_WINDOW_DIR_EAST;
if (north)
op |= META_GRAB_OP_WINDOW_DIR_NORTH;
if (south)
op |= META_GRAB_OP_WINDOW_DIR_SOUTH;
if (op != META_GRAB_OP_WINDOW_BASE)
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
meta_display_begin_grab_op (display,
window,
op,
TRUE,
FALSE,
core: Make meta_window_handle_ungrabbed_event() touch-aware This fixes the effects of this function on touchscreens in wayland (most notably, window raising & focusing).
2015-11-24 14:43:42 +00:00
button,
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
0,
event->any.time,
core: Make meta_window_handle_ungrabbed_event() touch-aware This fixes the effects of this function on touchscreens in wayland (most notably, window raising & focusing).
2015-11-24 14:43:42 +00:00
x, y);
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
}
}
core: Make meta_window_handle_ungrabbed_event() touch-aware This fixes the effects of this function on touchscreens in wayland (most notably, window raising & focusing).
2015-11-24 14:43:42 +00:00
else if (is_window_grab && (int) button == meta_prefs_get_mouse_button_menu ())
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
{
if (meta_prefs_get_raise_on_click ())
meta_window_raise (window);
Add back coordinates to the window menu It looks weird to have Alt+Space pop up under the cursor instead of the top-left corner of the window, and the Wayland request will pass through the coordinates as well. Add it to the compositor interface, and extend the _GTK_SHOW_WINDOW_MENU ClientMessage to support it as well.
2014-05-22 12:35:11 +00:00
meta_window_show_menu (window,
Actually implement opening the app menu The last commit added support for the "appmenu" button in decorations, but didn't actually implement it. Add a new MetaWindowMenuType parameter to the show_window_menu () functions and use it to ask the compositor to display the app menu when the new button is activated. https://bugzilla.gnome.org/show_bug.cgi?id=730752
2014-05-23 21:14:51 +00:00
META_WINDOW_MENU_WM,
core: Make meta_window_handle_ungrabbed_event() touch-aware This fixes the effects of this function on touchscreens in wayland (most notably, window raising & focusing).
2015-11-24 14:43:42 +00:00
x, y);
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
}
core: Make meta_window_handle_ungrabbed_event() touch-aware This fixes the effects of this function on touchscreens in wayland (most notably, window raising & focusing).
2015-11-24 14:43:42 +00:00
else if (is_window_grab && (int) button == 1)
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
{
if (window->has_move_func)
{
meta_display_begin_grab_op (display,
window,
META_GRAB_OP_MOVING,
TRUE,
FALSE,
core: Make meta_window_handle_ungrabbed_event() touch-aware This fixes the effects of this function on touchscreens in wayland (most notably, window raising & focusing).
2015-11-24 14:43:42 +00:00
button,
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
0,
event->any.time,
core: Make meta_window_handle_ungrabbed_event() touch-aware This fixes the effects of this function on touchscreens in wayland (most notably, window raising & focusing).
2015-11-24 14:43:42 +00:00
x, y);
events: Move window button handling to window.c Look at how clean GCD is now!!!
2014-05-08 19:12:58 +00:00
}
}
}
window: Export a bunch of state flags as accessor methods This is necessary to reimplement window menus in gnome-shell.
2014-03-13 22:15:26 +00:00
gboolean
meta_window_can_maximize (MetaWindow *window)
{
return window->has_maximize_func;
}
gboolean
meta_window_can_minimize (MetaWindow *window)
{
return window->has_minimize_func;
}
gboolean
meta_window_can_shade (MetaWindow *window)
{
return window->has_shade_func;
}
gboolean
meta_window_can_close (MetaWindow *window)
{
return window->has_close_func;
}
gboolean
meta_window_is_always_on_all_workspaces (MetaWindow *window)
{
return window->always_sticky;
}
gboolean
meta_window_is_above (MetaWindow *window)
{
return window->wm_state_above;
}
gboolean
meta_window_allows_move (MetaWindow *window)
{
return META_WINDOW_ALLOWS_MOVE (window);
}
gboolean
meta_window_allows_resize (MetaWindow *window)
{
return META_WINDOW_ALLOWS_RESIZE (window);
}
window: Move urgency to a setter
2014-03-18 17:51:36 +00:00
void
meta_window_set_urgent (MetaWindow *window,
gboolean urgent)
{
window: Rename wm_hints_urgent to urgent The flag and setter is now decoupled from the WM_HINTS state.
2014-03-18 17:53:42 +00:00
if (window->urgent == urgent)
window: Move urgency to a setter
2014-03-18 17:51:36 +00:00
return;
window: Rename wm_hints_urgent to urgent The flag and setter is now decoupled from the WM_HINTS state.
2014-03-18 17:53:42 +00:00
window->urgent = urgent;
window: Use g_object_notify_by_pspec
2014-06-24 20:25:41 +00:00
g_object_notify_by_pspec (G_OBJECT (window), obj_props[PROP_URGENT]);
window: Move urgency to a setter
2014-03-18 17:51:36 +00:00
if (urgent)
g_signal_emit_by_name (window->display, "window-marked-urgent", window);
}
window: Add some hooks for when grab ops begin / end on windows
2014-04-29 19:30:21 +00:00
void
meta_window_grab_op_began (MetaWindow *window,
MetaGrabOp op)
{
window: Turn grab_op_begin / grab_op_ended into vfuncs And move the grab_resize_popup management to the X11 window class, as this is only used under X11.
2014-04-29 19:55:55 +00:00
META_WINDOW_GET_CLASS (window)->grab_op_began (window, op);
window: Add some hooks for when grab ops begin / end on windows
2014-04-29 19:30:21 +00:00
}
void
meta_window_grab_op_ended (MetaWindow *window,
MetaGrabOp op)
{
window: Turn grab_op_begin / grab_op_ended into vfuncs And move the grab_resize_popup management to the X11 window class, as this is only used under X11.
2014-04-29 19:55:55 +00:00
META_WINDOW_GET_CLASS (window)->grab_op_ended (window, op);
window: Add some hooks for when grab ops begin / end on windows
2014-04-29 19:30:21 +00:00
}
wayland: Scale window geometry rects given the main output Since we scale surface actors given what main output their toplevel window is on, also scale the window geometry coordinates and sizes (window->rect size and window->custom_frame_extents.top/left) in order to make the window geometry represent what is being rendered on the stage. https://bugzilla.gnome.org/show_bug.cgi?id=744934
2015-03-23 13:22:19 +00:00
void
meta_window_emit_size_changed (MetaWindow *window)
{
g_signal_emit (window, window_signals[SIZE_CHANGED], 0);
}
core: Add support for custom window placement rules Add support for assigning a window a custom window placement rule used for calculating the initial window position as well as defining how a window is constrained. The custom rule is a declarative rule which defines a set of parameters which the placing algorithm and constrain algorithm uses for calculating the position of a window. It is meant to be used to implement positioning of menus and other popup windows created via Wayland. A custom placement rule replaces any other placement or constraint rule. https://bugzilla.gnome.org/show_bug.cgi?id=769936
2016-02-01 10:46:11 +00:00
MetaPlacementRule *
meta_window_get_placement_rule (MetaWindow *window)
{
window: Put placement related fields in a anynomous struct To organize things a bit better, put the fields related to the placement rule state in its own anonymous struct inside MetaWindow. While at it, rename the somewhat oddly named variable that in practice means the current relative window position. https://gitlab.gnome.org/GNOME/mutter/merge_requests/705
2020-02-13 21:40:15 +00:00
return window->placement.rule;
core: Add support for custom window placement rules Add support for assigning a window a custom window placement rule used for calculating the initial window position as well as defining how a window is constrained. The custom rule is a declarative rule which defines a set of parameters which the placing algorithm and constrain algorithm uses for calculating the position of a window. It is meant to be used to implement positioning of menus and other popup windows created via Wayland. A custom placement rule replaces any other placement or constraint rule. https://bugzilla.gnome.org/show_bug.cgi?id=769936
2016-02-01 10:46:11 +00:00
}
wayland: add inhibit shortcut mechanism Add a mechanism to MetaWaylandSurface that inhibits compositor's own shortcuts when the surface has input focus, so that clients can receive all key events regardless of the compositor own shortcuts. This will help with implementing "fake" active grabs in Wayland and XWayland clients. https://bugzilla.gnome.org/show_bug.cgi?id=783342
2017-03-17 12:34:52 +00:00
void
meta_window_force_restore_shortcuts (MetaWindow *window,
ClutterInputDevice *source)
{
META_WINDOW_GET_CLASS (window)->force_restore_shortcuts (window, source);
}
gboolean
meta_window_shortcuts_inhibited (MetaWindow *window,
ClutterInputDevice *source)
{
return META_WINDOW_GET_CLASS (window)->shortcuts_inhibited (window, source);
}
window: Defer stack placement without a buffer When closing a window and showing a new one, the new one may not be granted input focus until it gets a buffer on Wayland. If another window is chosen to receive focus and raised on top of stack, the newly mapped window is focused but placed underneath that other window. Meaning that for Wayland surfaces, we need to defer adding the window to the stack until we actually get to show it, once we have a buffer attached. Rather that checking the windowing backend prior to decide if a window is stackable or not, introduce a new vfunc is_stackable() which tells if a window should be added to the stack regardless of the underlying windowing system. Also add meta_window_is_in_stack() API rather than checking the stack position directly (replacing the define WINDOW_IN_STACK only available in stack.c) and remove a window from the stack only if it is present in the stack, so that the test in meta_stack_remote() becomes irrelevant. https://bugzilla.gnome.org/show_bug.cgi?id=780820
2018-01-09 12:19:40 +00:00
window: Add is_focusable class method Implement is_focusable for both x11 and wayland and just use this check so that we can abstract things more and be less dependent on window backend. https://gitlab.gnome.org/GNOME/mutter/merge_requests/421
2018-11-13 07:56:53 +00:00
gboolean
meta_window_is_focusable (MetaWindow *window)
{
window: Warn if try to focus unmanaging windows https://gitlab.gnome.org/GNOME/mutter/merge_requests/307
2019-02-14 12:57:22 +00:00
g_return_val_if_fail (!window->unmanaging, FALSE);
window: Add is_focusable class method Implement is_focusable for both x11 and wayland and just use this check so that we can abstract things more and be less dependent on window backend. https://gitlab.gnome.org/GNOME/mutter/merge_requests/421
2018-11-13 07:56:53 +00:00
return META_WINDOW_GET_CLASS (window)->is_focusable (window);
}
window: Move can_ping to a function and implement in X11 https://gitlab.gnome.org/GNOME/mutter/merge_requests/421
2019-01-30 19:41:11 +00:00
gboolean
meta_window_can_ping (MetaWindow *window)
{
return META_WINDOW_GET_CLASS (window)->can_ping (window);
}
window: Defer stack placement without a buffer When closing a window and showing a new one, the new one may not be granted input focus until it gets a buffer on Wayland. If another window is chosen to receive focus and raised on top of stack, the newly mapped window is focused but placed underneath that other window. Meaning that for Wayland surfaces, we need to defer adding the window to the stack until we actually get to show it, once we have a buffer attached. Rather that checking the windowing backend prior to decide if a window is stackable or not, introduce a new vfunc is_stackable() which tells if a window should be added to the stack regardless of the underlying windowing system. Also add meta_window_is_in_stack() API rather than checking the stack position directly (replacing the define WINDOW_IN_STACK only available in stack.c) and remove a window from the stack only if it is present in the stack, so that the test in meta_stack_remote() becomes irrelevant. https://bugzilla.gnome.org/show_bug.cgi?id=780820
2018-01-09 12:19:40 +00:00
gboolean
meta_window_is_stackable (MetaWindow *window)
{
return META_WINDOW_GET_CLASS (window)->is_stackable (window);
}
window: Add window id Generate a unique 64bit window-id which is unrelated to any windowing backend. https://gitlab.gnome.org/GNOME/mutter/merge_requests/306
2018-09-21 15:49:36 +00:00
stack: Delegate layer calculation to a window vfunc While most of the code to compute a window's layer isn't explicitly windowing backend specific, it is in practice: On wayland there are no DESKTOP windows(*), docks(*) or groups. Reflect that by introducing a calculate_layer() vfunc that computes (and sets) a window's layer. (*) they shall burn in hell, amen! https://gitlab.gnome.org/GNOME/mutter/merge_requests/949
2019-11-26 19:53:24 +00:00
MetaStackLayer
meta_window_calculate_layer (MetaWindow *window)
{
return META_WINDOW_GET_CLASS (window)->calculate_layer (window);
}
window: Add window id Generate a unique 64bit window-id which is unrelated to any windowing backend. https://gitlab.gnome.org/GNOME/mutter/merge_requests/306
2018-09-21 15:49:36 +00:00
/**
* meta_window_get_id:
* @window: a #MetaWindow
*
* Returns the window id associated with window.
*
window: Fix introspection warnings (transfer none) was added for fundamental types, which can't be transfered. https://gitlab.gnome.org/GNOME/mutter/merge_requests/356
2018-12-14 14:55:36 +00:00
* Returns: The window id
window: Add window id Generate a unique 64bit window-id which is unrelated to any windowing backend. https://gitlab.gnome.org/GNOME/mutter/merge_requests/306
2018-09-21 15:49:36 +00:00
*/
uint64_t
meta_window_get_id (MetaWindow *window)
{
return window->id;
}
window: Expose the client type in the API We already have the enum exposed, but no accessor function. Add `meta_window_get_client_type()` which returns the `MetaWindowClientType` of a window. https://gitlab.gnome.org/GNOME/mutter/merge_requests/306
2018-12-12 12:05:21 +00:00
/**
* meta_window_get_client_type:
* @window: a #MetaWindow
*
* Returns the #MetaWindowClientType of the window.
*
window: Fix introspection warnings (transfer none) was added for fundamental types, which can't be transfered. https://gitlab.gnome.org/GNOME/mutter/merge_requests/356
2018-12-14 14:55:36 +00:00
* Returns: The root ancestor window
window: Expose the client type in the API We already have the enum exposed, but no accessor function. Add `meta_window_get_client_type()` which returns the `MetaWindowClientType` of a window. https://gitlab.gnome.org/GNOME/mutter/merge_requests/306
2018-12-12 12:05:21 +00:00
*/
MetaWindowClientType
meta_window_get_client_type (MetaWindow *window)
{
return window->client_type;
}
Copy permalink